Commit Graph

8293 Commits

Author SHA1 Message Date
Agetian
7ed295f4fd - Code deduplication. 2015-06-14 06:30:00 +00:00
Agetian
aa586eb9bc - Restored 'final' that was taken out during experiments. 2015-06-14 06:15:29 +00:00
Agetian
4c5e5d2cc8 - Fix imports. 2015-06-14 06:11:02 +00:00
Agetian
b8ce9a942f - Improved the way the number of targets is detected for the sake of copying spells that require only one target.
- Fixed one-target Profane Command not working with Precursor Golem, as well as other similar cases.
- Remaining issue: Radiate cannot copy one-target Profane Command for some reason (the user doesn't even get to the input prompt).
2015-06-14 06:09:20 +00:00
Sol
3a70cbce92 - Fix Graft from phantom move counters when the defined card is no longer in the expected state 2015-06-14 01:53:25 +00:00
drdev
3e6d5cd3e9 Show "Waiting for opponent..." while you wait for the other player to choose whether to go first or keep their first hand 2015-06-13 19:12:39 +00:00
Agetian
520a44196a - Use the {X} symbol to represent "colorless" in current card colors (in line with how it's represented in the deck editor, deck statistics etc.).
- Attempt to fix concurrent modification exceptions in getAttackers/getDefenders.
2015-06-13 07:35:57 +00:00
Agetian
011493189d - Fixed processing of wasNotCast and wasNotCastFrom (fixes Epochrasite and possibly other cards). 2015-06-12 05:09:10 +00:00
Agetian
7a55c53eba - Improved implementation of searching for targets in SpellAbilityTargetingCards + a better comment. 2015-06-10 05:47:36 +00:00
Agetian
de8ff5a0e1 - Utilize information from SpellAbilityTargetingCards triggering object to find targets for copied spell abilities (fixes Banefire/Lightning Bolt/etc. cast on Precursor Golem). 2015-06-10 05:41:28 +00:00
Agetian
f975117a0a - Better comment placement. 2015-06-10 04:33:23 +00:00
Agetian
2508585a15 - Fixed manifested instants and sorceries returning to battlefield via Endless Whispers (implemented rules 304.4, 304.7). 2015-06-10 04:32:27 +00:00
Agetian
df7288fc89 - Replaced a call that uses the Objects class with a standard throw mechanism according to the class description (java.util.Objects doesn't work with mobile Forge and makes it crash with a ClassNotFound error, and I don't know if we should and even could introduce that as a dependency or not... input is welcome). 2015-06-07 17:55:44 +00:00
elcnesh
fcd98ef99d Update, cleanup and fully document FCollection and related classes. 2015-06-07 09:40:43 +00:00
Agetian
b41e2304bf - Fixed a NPE when processing a fizzled DigUntilEffect (e.g. Condemn on a creature equipped with Trepanation Blade). 2015-06-06 14:31:01 +00:00
Chris
c48418a77f [maven-release-plugin] prepare for next development iteration 2015-06-05 20:31:07 +00:00
Chris
f3edbb23af [maven-release-plugin] prepare release forge-1.5.40 2015-06-05 20:31:00 +00:00
Sol
f11daa3f64 - Thawing Glaciers trigger will now cause players to gain priority if it's waiting to be added to the stack 2015-06-05 15:11:17 +00:00
elcnesh
4eef9618d0 - Cleanup GameRules (mostly make a variable private)
- Minor cleanup in some other files
2015-06-04 16:06:48 +00:00
Agetian
5ad4ebdabd - Get rid of the redundant block of code in Phantom Nomad implementation. 2015-06-02 18:22:48 +00:00
Agetian
201542300b - Fixed Phantom Nomad getting multiple counters removed from combat damage (only one counter is now removed from it for all the damage applied to it simultaneously). 2015-06-02 17:12:35 +00:00
drdev
661636c2fa Prevent crash when activating Stonehewer Giant's avatar ability 2015-05-30 18:09:17 +00:00
Agetian
76089e0eba - Fixed River of Tears and improved user interaction with it (especially when it comes to using Auto or to tapping it in response to a mana payment prompt). 2015-05-30 16:37:15 +00:00
Agetian
0993837aa2 - Fixed the split cards not showing the Fuse ability in the card detail panel. 2015-05-30 05:02:31 +00:00
Agetian
f2636586a8 - Fixed the cards exiled face down showing up as Morph in exile zone instead of as a hidden face down card (card back picture). 2015-05-29 19:37:14 +00:00
Agetian
ce976bd391 - When checking state-based effects, check the game over condition early to account for win conditions that trigger before the cards die due to zero toughness (e.g. Platinum Angel + lethal Hurricane that gets both players to zero or below).
- To be on the safe side I left the original check intact and I'm running it in case the first check wasn't positive, assuming that the situation may change somehow after all the card-based state effects are checked and relevant effects apply. Is this necessary?
- Please test this in various win/lose conditions and let me know if anything is wrong with this approach, I can try to adapt or revert as necessary.
2015-05-27 16:35:26 +00:00
drdev
8d151174ab Put commander life back to 40 even for 2 player 2015-05-25 19:39:43 +00:00
Agetian
ea672e92f8 - Minor cleanup. 2015-05-25 12:14:30 +00:00
Agetian
f38e54912d - A better implementation of announcement when playing with the top card of the library revealed: announce all cards at once. 2015-05-25 12:13:19 +00:00
Agetian
090009ffa3 - Reveal and announce the cards drawn when playing with the top of the library revealed (currently does not announce when drawing one card by one since a card on the top of the library can easily be seen in that case, to avoid message box spam). 2015-05-25 11:59:32 +00:00
Agetian
01fb31969e - Removed an extra space. 2015-05-24 07:45:10 +00:00
Agetian
20d86418e2 - Make DealtCombatDamageOnce trigger report the amount of damage dealt in combat. Fixes Sunhome Enforcer. 2015-05-24 07:37:50 +00:00
Agetian
5bfec80d90 - Use a standard mechanism of testing object equality so that mobile Forge doesn't hang. 2015-05-23 19:06:41 +00:00
Agetian
d859d378c6 - Use java.util.Objects instead of the Google class. 2015-05-23 13:57:58 +00:00
Agetian
069d8a5b00 - Attempt to fix Courser of Kruphix and friends not revealing the cards in game 2+ of the match. 2015-05-23 13:54:33 +00:00
elcnesh
ab03da16a0 - Cleanup and fix PlayEffect, especially related to optionally playing multiple cards
- Fix Jace, Architect of Thought's ultimate to search each player's library
2015-05-23 07:13:10 +00:00
Agetian
f233a0345f - Improved the implementation of fizzling triggered SAs (so that hasFizzled returns true for failed SAs). 2015-05-22 17:55:47 +00:00
Agetian
e915b68a7e - Changed a method name a little. 2015-05-22 17:34:26 +00:00
Agetian
25f0e03808 - Fix an issue with the "damage done" triggers lingering in certain cases on creatures returning from graveyard to battlefield, which caused e.g. a wrong interaction of Stone-Tongue Basilisk with Persist creatures (killing them "twice", once with combat damage and then again with the trigger once they returned from graveyard via Persist).
- This fix is somewhat roundabout, I'm not sure if maybe it breaks something, please review.
2015-05-22 16:58:20 +00:00
Agetian
842167d1ff - More correct implementation of the way GameEventCardModeChosen game event is processed. 2015-05-19 18:04:33 +00:00
Agetian
4e56670a23 - Cards which need a mode choice (e.g. the Siege cycle, Master of Predicaments etc.) will now log the choice that was made.
- The Siege cycle cards will now also report the choice in a message box so that it's immediately apparent what was chosen for them.
- Changed the default value of "Display Tokens in a Separate Row" to "disabled" (tokens are now displayed on the same row as non-token cards).
2015-05-19 17:56:38 +00:00
elcnesh
b3f38edef3 Huge cleanup: use collection interfaces (List, Set, Map) rather than
implementations (ArrayList etc.) in references to objects
2015-05-17 11:28:21 +00:00
elcnesh
6274c5379a Use morph/manifest reminder overlays for face-down cards on the battlefield 2015-05-17 11:16:39 +00:00
Sol
c6a55f6af2 - Added Taste of Paradise with pseudokicker structure 2015-05-15 21:55:25 +00:00
Sloth
2c42c9bd76 - Fixed Auras displaying their names at the end of their descriptions. 2015-05-15 21:02:00 +00:00
Sol
ce438fa313 - Fixing Ash Zealot grabbing the wrong property 2015-05-13 12:13:17 +00:00
Sol
ce9c1d87ae - Improve handling of Dragon Presence for Flicker effects 2015-05-13 01:43:10 +00:00
Sol
b8b217d7f1 - Some more improvements needed for Dragon Presence cards 2015-05-13 01:24:18 +00:00
Sol
b115625de8 - Adding the capability for cards to reference "Dragon Presence" in the BF, or as an optional payment 2015-05-12 03:35:44 +00:00
Sol
579522418e - Don't print Kicker in the card text panel for Pseudo-kickers (Undergrowth) 2015-05-12 02:58:06 +00:00