Migrate SPM (and some other early spoilers)

forge-core/src/main/java/forge/StaticData.java

@@ -878,7 +878,7 @@ public class StaticData {
                 }
             }
         }
-        // stream().toList() causes crash on Android 8-13, use Collectors.toList()
+        // stream().toList() causes crash on Android, use Collectors.toList()
         List<String> NIF = new ArrayList<>(NIF_Q).stream().sorted().collect(Collectors.toList());
         List<String> CNI = new ArrayList<>(CNI_Q).stream().sorted().collect(Collectors.toList());
         List<String> TOK = new ArrayList<>(TOKEN_Q).stream().sorted().collect(Collectors.toList());

forge-core/src/main/java/forge/card/CardEdition.java

@@ -1018,13 +1018,16 @@ public final class CardEdition implements Comparable<CardEdition> {
 
         public static final Predicate<CardEdition> HAS_BOOSTER_BOX = edition -> edition.getBoosterBoxCount() > 0;
 
-        @Deprecated //Use CardEdition::hasBasicLands and a nonnull test.
         public static final Predicate<CardEdition> hasBasicLands = ed -> {
             if (ed == null) {
                 // Happens for new sets with "???" code
                 return false;
             }
-            return ed.hasBasicLands();
+            for(String landName : MagicColor.Constant.BASIC_LANDS) {
+                if (null == StaticData.instance().getCommonCards().getCard(landName, ed.getCode(), 0))
+                    return false;
+            }
+            return true;
         };
     }
 
@@ -1045,7 +1048,7 @@ public final class CardEdition implements Comparable<CardEdition> {
 
     public boolean hasBasicLands() {
         for(String landName : MagicColor.Constant.BASIC_LANDS) {
-            if (this.getCardInSet(landName).isEmpty())
+            if (null == StaticData.instance().getCommonCards().getCard(landName, this.getCode(), 0))
                 return false;
         }
         return true;

forge-core/src/main/java/forge/deck/DeckRecognizer.java

@@ -49,16 +49,6 @@ public class DeckRecognizer {
         LIMITED_CARD,
         CARD_FROM_NOT_ALLOWED_SET,
         CARD_FROM_INVALID_SET,
-        /**
-         * Valid card request, but can't be imported because the player does not have enough copies.
-         * Should be replaced with a different printing if possible.
-         */
-        CARD_NOT_IN_INVENTORY,
-        /**
-         * Valid card request for a card that isn't in the player's inventory, but new copies can be acquired freely.
-         * Usually used for basic lands. Should be supplied to the import controller by the editor.
-         */
-        FREE_CARD_NOT_IN_INVENTORY,
         // Warning messages
         WARNING_MESSAGE,
         UNKNOWN_CARD,
@@ -73,11 +63,7 @@ public class DeckRecognizer {
         CARD_TYPE,
         CARD_RARITY,
         CARD_CMC,
-        MANA_COLOUR;
+        MANA_COLOUR
-
-        public static final EnumSet<TokenType> CARD_TOKEN_TYPES = EnumSet.of(LEGAL_CARD, LIMITED_CARD, CARD_FROM_NOT_ALLOWED_SET, CARD_FROM_INVALID_SET, CARD_NOT_IN_INVENTORY, FREE_CARD_NOT_IN_INVENTORY);
-        public static final EnumSet<TokenType> IN_DECK_TOKEN_TYPES = EnumSet.of(LEGAL_CARD, LIMITED_CARD, DECK_NAME, FREE_CARD_NOT_IN_INVENTORY);
-        public static final EnumSet<TokenType> CARD_PLACEHOLDER_TOKEN_TYPES = EnumSet.of(CARD_TYPE, CARD_RARITY, CARD_CMC, MANA_COLOUR);
     }
 
     public enum LimitedCardType{
@@ -122,10 +108,6 @@ public class DeckRecognizer {
             return new Token(TokenType.CARD_FROM_INVALID_SET, count, card, cardRequestHasSetCode);
         }
 
-        public static Token NotInInventoryFree(final PaperCard card, final int count, final DeckSection section) {
-            return new Token(TokenType.FREE_CARD_NOT_IN_INVENTORY, count, card, section, true);
-        }
-
         // WARNING MESSAGES
         // ================
         public static Token UnknownCard(final String cardName, final String setCode, final int count) {
@@ -144,10 +126,6 @@ public class DeckRecognizer {
            return new Token(TokenType.WARNING_MESSAGE, msg);
         }
 
-        public static Token NotInInventory(final PaperCard card, final int count, final DeckSection section) {
-            return new Token(TokenType.CARD_NOT_IN_INVENTORY, count, card, section, false);
-        }
-
         /* =================================
          * DECK SECTIONS
          * ================================= */
@@ -261,11 +239,14 @@ public class DeckRecognizer {
         /**
          * Filters all token types that have a PaperCard instance set (not null)
          * @return true for tokens of type:
-         * LEGAL_CARD, LIMITED_CARD, CARD_FROM_NOT_ALLOWED_SET and CARD_FROM_INVALID_SET, CARD_NOT_IN_INVENTORY, FREE_CARD_NOT_IN_INVENTORY.
+         * LEGAL_CARD, LIMITED_CARD, CARD_FROM_NOT_ALLOWED_SET and CARD_FROM_INVALID_SET.
          * False otherwise.
          */
         public boolean isCardToken() {
-            return TokenType.CARD_TOKEN_TYPES.contains(this.type);
+            return (this.type == TokenType.LEGAL_CARD ||
+                    this.type == TokenType.LIMITED_CARD ||
+                    this.type == TokenType.CARD_FROM_NOT_ALLOWED_SET ||
+                    this.type == TokenType.CARD_FROM_INVALID_SET);
         }
 
         /**
@@ -274,7 +255,9 @@ public class DeckRecognizer {
          * LEGAL_CARD, LIMITED_CARD, DECK_NAME; false otherwise.
          */
         public boolean isTokenForDeck() {
-            return TokenType.IN_DECK_TOKEN_TYPES.contains(this.type);
+            return (this.type == TokenType.LEGAL_CARD ||
+                    this.type == TokenType.LIMITED_CARD ||
+                    this.type == TokenType.DECK_NAME);
         }
 
         /**
@@ -283,7 +266,7 @@ public class DeckRecognizer {
          * False otherwise.
          */
         public boolean isCardTokenForDeck() {
-            return isCardToken() && isTokenForDeck();
+            return (this.type == TokenType.LEGAL_CARD || this.type == TokenType.LIMITED_CARD);
         }
 
         /**
@@ -293,7 +276,10 @@ public class DeckRecognizer {
          * CARD_RARITY, CARD_CMC, CARD_TYPE, MANA_COLOUR
          */
         public boolean isCardPlaceholder(){
-            return TokenType.CARD_PLACEHOLDER_TOKEN_TYPES.contains(this.type);
+            return (this.type == TokenType.CARD_RARITY ||
+                    this.type == TokenType.CARD_CMC ||
+                    this.type == TokenType.MANA_COLOUR ||
+                    this.type == TokenType.CARD_TYPE);
         }
 
         /** Determines if current token is a Deck Section token
@@ -550,7 +536,7 @@ public class DeckRecognizer {
             PaperCard tokenCard = token.getCard();
 
             if (isAllowed(tokenSection)) {
-                if (tokenSection != referenceDeckSectionInParsing) {
+                if (!tokenSection.equals(referenceDeckSectionInParsing)) {
                     Token sectionToken = Token.DeckSection(tokenSection.name(), this.allowedDeckSections);
                     // just check that last token is stack is a card placeholder.
                     // In that case, add the new section token before the placeholder
@@ -589,7 +575,7 @@ public class DeckRecognizer {
         refLine = purgeAllLinks(refLine);
 
         String line;
-        if (refLine.startsWith(LINE_COMMENT_DELIMITER_OR_MD_HEADER))
+        if (StringUtils.startsWith(refLine, LINE_COMMENT_DELIMITER_OR_MD_HEADER))
             line = refLine.replaceAll(LINE_COMMENT_DELIMITER_OR_MD_HEADER, "");
         else
             line = refLine.trim();  // Remove any trailing formatting
@@ -598,7 +584,7 @@ public class DeckRecognizer {
         // Final fantasy cards like Summon: Choco/Mog should be ommited to be recognized. TODO: fix maybe for future cards
         if (!line.contains("Summon:"))
             line = SEARCH_SINGLE_SLASH.matcher(line).replaceFirst(" // ");
-        if (line.startsWith(ASTERISK))  // Markdown lists (tappedout md export)
+        if (StringUtils.startsWith(line, ASTERISK))  // markdown lists (tappedout md export)
             line = line.substring(2);
 
         // == Patches to Corner Cases
@@ -614,8 +600,8 @@ public class DeckRecognizer {
         Token result = recogniseCardToken(line, referenceSection);
         if (result == null)
             result = recogniseNonCardToken(line);
-        return result != null ? result : refLine.startsWith(DOUBLE_SLASH) ||
+        return result != null ? result : StringUtils.startsWith(refLine, DOUBLE_SLASH) ||
-                refLine.startsWith(LINE_COMMENT_DELIMITER_OR_MD_HEADER) ?
+                StringUtils.startsWith(refLine, LINE_COMMENT_DELIMITER_OR_MD_HEADER) ?
                 new Token(TokenType.COMMENT, 0, refLine) : new Token(TokenType.UNKNOWN_TEXT, 0, refLine);
     }
 
@@ -627,7 +613,7 @@ public class DeckRecognizer {
         while (m.find()) {
             line = line.replaceAll(m.group(), "").trim();
         }
-        if (line.endsWith("()"))
+        if (StringUtils.endsWith(line, "()"))
             return line.substring(0, line.length()-2);
         return line;
     }
@@ -755,12 +741,21 @@ public class DeckRecognizer {
     // This would save tons of time in parsing Input + would also allow to return UnsupportedCardTokens beforehand
     private DeckSection getTokenSection(String deckSec, DeckSection currentDeckSection, PaperCard card){
         if (deckSec != null) {
-            DeckSection cardSection = switch (deckSec.toUpperCase().trim()) {
+            DeckSection cardSection;
-                case "MB" -> DeckSection.Main;
+            switch (deckSec.toUpperCase().trim()) {
-                case "SB" -> DeckSection.Sideboard;
+                case "MB":
-                case "CM" -> DeckSection.Commander;
+                    cardSection = DeckSection.Main;
-                default -> DeckSection.matchingSection(card);
+                    break;
-            };
+                case "SB":
+                    cardSection = DeckSection.Sideboard;
+                    break;
+                case "CM":
+                    cardSection = DeckSection.Commander;
+                    break;
+                default:
+                    cardSection = DeckSection.matchingSection(card);
+                    break;
+            }
             if (cardSection.validate(card))
                 return cardSection;
         }
@@ -1022,21 +1017,51 @@ public class DeckRecognizer {
     private static MagicColor.Color getMagicColor(String colorName){
         if (colorName.toLowerCase().startsWith("multi") || colorName.equalsIgnoreCase("m"))
             return null;  // will be handled separately
-        return MagicColor.Color.fromByte(MagicColor.fromName(colorName.toLowerCase()));
+
+        byte color = MagicColor.fromName(colorName.toLowerCase());
+        switch (color) {
+            case MagicColor.WHITE:
+                return MagicColor.Color.WHITE;
+            case MagicColor.BLUE:
+                return MagicColor.Color.BLUE;
+            case MagicColor.BLACK:
+                return MagicColor.Color.BLACK;
+            case MagicColor.RED:
+                return MagicColor.Color.RED;
+            case MagicColor.GREEN:
+                return MagicColor.Color.GREEN;
+            default:
+                return MagicColor.Color.COLORLESS;
+
+        }
     }
 
     public static String getLocalisedMagicColorName(String colorName){
         Localizer localizer = Localizer.getInstance();
-        return switch (colorName.toLowerCase()) {
+        switch(colorName.toLowerCase()){
-            case MagicColor.Constant.WHITE -> localizer.getMessage("lblWhite");
+            case MagicColor.Constant.WHITE:
-            case MagicColor.Constant.BLUE -> localizer.getMessage("lblBlue");
+                return localizer.getMessage("lblWhite");
-            case MagicColor.Constant.BLACK -> localizer.getMessage("lblBlack");
+
-            case MagicColor.Constant.RED -> localizer.getMessage("lblRed");
+            case MagicColor.Constant.BLUE:
-            case MagicColor.Constant.GREEN -> localizer.getMessage("lblGreen");
+                return localizer.getMessage("lblBlue");
-            case MagicColor.Constant.COLORLESS -> localizer.getMessage("lblColorless");
+
-            case "multicolour", "multicolor" -> localizer.getMessage("lblMulticolor");
+            case MagicColor.Constant.BLACK:
-            default -> "";
+                return localizer.getMessage("lblBlack");
-        };
+
+            case MagicColor.Constant.RED:
+                return localizer.getMessage("lblRed");
+
+            case MagicColor.Constant.GREEN:
+                return localizer.getMessage("lblGreen");
+
+            case MagicColor.Constant.COLORLESS:
+                return localizer.getMessage("lblColorless");
+            case "multicolour":
+            case "multicolor":
+                return localizer.getMessage("lblMulticolor");
+            default:
+                return "";
+        }
     }
 
     /**
@@ -1055,6 +1080,37 @@ public class DeckRecognizer {
 
         return "";
     }
+
+
+    private static Pair<String, String> getManaNameAndSymbol(String matchedMana) {
+        if (matchedMana == null)
+            return null;
+
+        Localizer localizer = Localizer.getInstance();
+        switch (matchedMana.toLowerCase()) {
+            case MagicColor.Constant.WHITE:
+            case "w":
+                return Pair.of(localizer.getMessage("lblWhite"), MagicColor.Color.WHITE.getSymbol());
+            case MagicColor.Constant.BLUE:
+            case "u":
+                return Pair.of(localizer.getMessage("lblBlue"), MagicColor.Color.BLUE.getSymbol());
+            case MagicColor.Constant.BLACK:
+            case "b":
+                return Pair.of(localizer.getMessage("lblBlack"), MagicColor.Color.BLACK.getSymbol());
+            case MagicColor.Constant.RED:
+            case "r":
+                return Pair.of(localizer.getMessage("lblRed"), MagicColor.Color.RED.getSymbol());
+            case MagicColor.Constant.GREEN:
+            case "g":
+                return Pair.of(localizer.getMessage("lblGreen"), MagicColor.Color.GREEN.getSymbol());
+            case MagicColor.Constant.COLORLESS:
+            case "c":
+                return Pair.of(localizer.getMessage("lblColorless"), MagicColor.Color.COLORLESS.getSymbol());
+            default: // Multicolour
+                return Pair.of(localizer.getMessage("lblMulticolor"), "");
+        }
+    }
+
     public static boolean isDeckName(final String lineAsIs) {
         if (lineAsIs == null)
             return false;

forge-game/src/main/java/forge/game/card/CardState.java

@@ -367,7 +367,7 @@ public class CardState extends GameObject implements IHasSVars, ITranslatable {
     public final FCollectionView<SpellAbility> getManaAbilities() {
         FCollection<SpellAbility> newCol = new FCollection<>();
         updateSpellAbilities(newCol, true);
-        // stream().toList() causes crash on Android 8-13, use Collectors.toList()
+        // stream().toList() causes crash on Android, use Collectors.toList()
         newCol.addAll(abilities.stream().filter(SpellAbility::isManaAbility).collect(Collectors.toList()));
         card.updateSpellAbilities(newCol, this, true);
         return newCol;
@@ -375,7 +375,7 @@ public class CardState extends GameObject implements IHasSVars, ITranslatable {
     public final FCollectionView<SpellAbility> getNonManaAbilities() {
         FCollection<SpellAbility> newCol = new FCollection<>();
         updateSpellAbilities(newCol, false);
-        // stream().toList() causes crash on Android 8-13, use Collectors.toList()
+        // stream().toList() causes crash on Android, use Collectors.toList()
         newCol.addAll(abilities.stream().filter(Predicate.not(SpellAbility::isManaAbility)).collect(Collectors.toList()));
         card.updateSpellAbilities(newCol, this, false);
         return newCol;
@@ -390,7 +390,7 @@ public class CardState extends GameObject implements IHasSVars, ITranslatable {
                 if (null != mana) {
                     leftAbilities = leftAbilities.stream()
                             .filter(mana ? SpellAbility::isManaAbility : Predicate.not(SpellAbility::isManaAbility))
-                            // stream().toList() causes crash on Android 8-13, use Collectors.toList()
+                            // stream().toList() causes crash on Android, use Collectors.toList()
                             .collect(Collectors.toList());
                 }
                 newCol.addAll(leftAbilities);
@@ -402,7 +402,7 @@ public class CardState extends GameObject implements IHasSVars, ITranslatable {
                 if (null != mana) {
                     rightAbilities = rightAbilities.stream()
                             .filter(mana ? SpellAbility::isManaAbility : Predicate.not(SpellAbility::isManaAbility))
-                            // stream().toList() causes crash on Android 8-13, use Collectors.toList()
+                            // stream().toList() causes crash on Android, use Collectors.toList()
                             .collect(Collectors.toList());
                 }
                 newCol.addAll(rightAbilities);

forge-game/src/main/java/forge/game/keyword/Keyword.java

@@ -1,8 +1,8 @@
 package forge.game.keyword;
 
-import forge.card.CardSplitType;
+import forge.StaticData;
+import forge.game.card.Card;
 import forge.item.PaperCard;
-import org.apache.commons.lang3.tuple.Pair;
 
 import java.util.*;
 
@@ -223,7 +223,7 @@ public enum Keyword {
         displayName = displayName0;
     }
 
-    private static Pair<Keyword, String> getKeywordDetails(String k) {
+    public static KeywordInterface getInstance(String k) {
         Keyword keyword = Keyword.UNDEFINED;
         String details = k;
         // try to get real part
@@ -255,20 +255,15 @@ public enum Keyword {
             keyword = smartValueOf(k);
             details = "";
         }
-        return Pair.of(keyword, details);
-    }
-
-    public static KeywordInterface getInstance(String k) {
-        Pair<Keyword, String> p = getKeywordDetails(k);
 
         KeywordInstance<?> inst;
         try {
-            inst = p.getKey().type.getConstructor().newInstance();
+            inst = keyword.type.getConstructor().newInstance();
         }
         catch (Exception e) {
             inst = new UndefinedKeyword();
         }
-        inst.initialize(k, p.getKey(), p.getValue());
+        inst.initialize(k, keyword, details);
         return inst;
     }
 
@@ -283,44 +278,36 @@ public enum Keyword {
         return keywords;
     }
 
-    private static Keyword get(String k) {
-        if (k == null || k.isEmpty())
-            return Keyword.UNDEFINED;
-
-        return getKeywordDetails(k).getKey();
-    }
-
     private static final Map<String, Set<Keyword>> cardKeywordSetLookup = new HashMap<>();
 
     public static Set<Keyword> getKeywordSet(PaperCard card) {
-        String name = card.getName();
+        String key = card.getName();
-        Set<Keyword> keywordSet = cardKeywordSetLookup.get(name);
+        Set<Keyword> keywordSet = cardKeywordSetLookup.get(key);
         if (keywordSet == null) {
-            CardSplitType cardSplitType = card.getRules().getSplitType();
+            keywordSet = new HashSet<>();
-            keywordSet = EnumSet.noneOf(Keyword.class);
+            for (KeywordInterface inst : Card.getCardForUi(card).getKeywords()) {
-            if (cardSplitType != CardSplitType.None && cardSplitType != CardSplitType.Split) {
+                final Keyword keyword = inst.getKeyword();
-                if (card.getRules().getOtherPart() != null) {
+                if (keyword != Keyword.UNDEFINED) {
-                    if (card.getRules().getOtherPart().getKeywords() != null) {
-                        for (String key : card.getRules().getOtherPart().getKeywords()) {
-                            Keyword keyword = get(key);
-                            if (!Keyword.UNDEFINED.equals(keyword))
                     keywordSet.add(keyword);
                 }
             }
-                }
+            cardKeywordSetLookup.put(card.getName(), keywordSet);
-            }
-            if (card.getRules().getMainPart().getKeywords() != null) {
-                for (String key : card.getRules().getMainPart().getKeywords()) {
-                    Keyword keyword = get(key);
-                    if (!Keyword.UNDEFINED.equals(keyword))
-                        keywordSet.add(keyword);
-                }
-            }
-            cardKeywordSetLookup.put(name, keywordSet);
         }
         return keywordSet;
     }
 
+    public static Runnable getPreloadTask() {
+        if (cardKeywordSetLookup.size() < 10000) { //allow preloading even if some but not all cards loaded
+            return () -> {
+                final Collection<PaperCard> cards = StaticData.instance().getCommonCards().getUniqueCards();
+                for (PaperCard card : cards) {
+                    getKeywordSet(card);
+                }
+            };
+        }
+        return null;
+    }
+
     public static Keyword smartValueOf(String value) {
         for (final Keyword v : Keyword.values()) {
             if (v.displayName.equalsIgnoreCase(value)) {

forge-gui-desktop/src/main/java/forge/screens/deckeditor/AddBasicLandsDialog.java

@@ -68,7 +68,7 @@ public class AddBasicLandsDialog {
     private static final int LAND_PANEL_PADDING = 3;
 
     private final FComboBoxPanel<CardEdition> cbLandSet = new FComboBoxPanel<>(Localizer.getInstance().getMessage("lblLandSet") + ":", FlowLayout.CENTER,
-            IterableUtil.filter(StaticData.instance().getSortedEditions(), CardEdition::hasBasicLands));
+            IterableUtil.filter(StaticData.instance().getSortedEditions(), CardEdition.Predicates.hasBasicLands));
 
     private final MainPanel panel = new MainPanel();
     private final LandPanel pnlPlains = new LandPanel("Plains");

forge-gui-desktop/src/main/java/forge/screens/deckeditor/DeckImport.java

@@ -46,6 +46,7 @@ import forge.toolbox.*;
 import forge.util.Localizer;
 import forge.view.FDialog;
 import net.miginfocom.swing.MigLayout;
+import org.apache.commons.lang3.StringUtils;
 
 import static forge.deck.DeckRecognizer.TokenType.*;
 
@@ -522,7 +523,7 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
                 else
                     deck.setName(currentDeckName);
             }
-            host.getDeckController().loadDeck(deck, controller.getImportBehavior() != DeckImportController.ImportBehavior.MERGE);
+            host.getDeckController().loadDeck(deck, controller.getCreateNewDeck());
             processWindowEvent(new WindowEvent(DeckImport.this, WindowEvent.WINDOW_CLOSING));
         });
 
@@ -530,7 +531,7 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
             this.createNewDeckCheckbox.setSelected(false);
             this.createNewDeckCheckbox.addActionListener(e -> {
                 boolean createNewDeck = createNewDeckCheckbox.isSelected();
-                controller.setImportBehavior(createNewDeck ? DeckImportController.ImportBehavior.CREATE_NEW : DeckImportController.ImportBehavior.MERGE);
+                controller.setCreateNewDeck(createNewDeck);
                 String cmdAcceptLabel = createNewDeck ? CREATE_NEW_DECK_CMD_LABEL : IMPORT_CARDS_CMD_LABEL;
                 cmdAcceptButton.setText(cmdAcceptLabel);
                 String smartCardArtChboxTooltip = createNewDeck ? SMART_CARDART_TT_NO_DECK : SMART_CARDART_TT_WITH_DECK;
@@ -599,7 +600,7 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
             if (token.getType() == LIMITED_CARD)
                 cssClass = WARN_MSG_CLASS;
             String statusMsg = String.format("<span class=\"%s\" style=\"font-size: 9px;\">%s</span>", cssClass,
-                    controller.getTokenStatusMessage(token));
+                                                                                        getTokenStatusMessage(token));
             statusLbl.append(statusMsg);
         }
 
@@ -739,12 +740,12 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
     private String toHTML(final DeckRecognizer.Token token) {
         if (token == null)
             return "";
-        String tokenMsg = controller.getTokenMessage(token);
+        String tokenMsg = getTokenMessage(token);
         if (tokenMsg == null)
             return "";
-        String tokenStatus = controller.getTokenStatusMessage(token);
+        String tokenStatus = getTokenStatusMessage(token);
         String cssClass = getTokenCSSClass(token.getType());
-        if (tokenStatus.isEmpty())
+        if (tokenStatus.length() == 0)
             tokenMsg = padEndWithHTMLSpaces(tokenMsg, 2*PADDING_TOKEN_MSG_LENGTH+10);
         else {
             tokenMsg = padEndWithHTMLSpaces(tokenMsg, PADDING_TOKEN_MSG_LENGTH);
@@ -754,6 +755,11 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
             tokenMsg = String.format("<a class=\"%s\" href=\"%s\">%s</a>", cssClass,
                     token.getKey().toString(), tokenMsg);
 
+        if (tokenStatus == null) {
+            String tokenTag = String.format("<td colspan=\"2\" class=\"%s\">%s</td>", cssClass, tokenMsg);
+            return String.format("<tr>%s</tr>", tokenTag);
+        }
+
         String tokenTag = "<td class=\"%s\">%s</td>";
         String tokenMsgTag = String.format(tokenTag, cssClass, tokenMsg);
         String tokenStatusTag;
@@ -770,6 +776,97 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
         return String.format("%s%s", targetMsg, spacer);
     }
 
+    private String getTokenMessage(DeckRecognizer.Token token) {
+        switch (token.getType()) {
+            case LEGAL_CARD:
+            case LIMITED_CARD:
+            case CARD_FROM_NOT_ALLOWED_SET:
+            case CARD_FROM_INVALID_SET:
+                return String.format("%s x %s %s", token.getQuantity(), token.getText(), getTokenFoilLabel(token));
+            // Card Warning Msgs
+            case UNKNOWN_CARD:
+            case UNSUPPORTED_CARD:
+                return token.getQuantity() > 0 ? String.format("%s x %s", token.getQuantity(), token.getText())
+                        : token.getText();
+
+            case UNSUPPORTED_DECK_SECTION:
+                return String.format("%s: %s", Localizer.getInstance().getMessage("lblWarningMsgPrefix"),
+                                        Localizer.getInstance()
+                                                .getMessage("lblWarnDeckSectionNotAllowedInEditor", token.getText(),
+                                                        this.currentGameType));
+
+            // Special Case of Card moved into another section (e.g. Commander from Sideboard)
+            case WARNING_MESSAGE:
+                return String.format("%s: %s", Localizer.getInstance()
+                                .getMessage("lblWarningMsgPrefix"), token.getText());
+
+            // Placeholders
+            case DECK_SECTION_NAME:
+                return String.format("%s: %s", Localizer.getInstance().getMessage("lblDeckSection"),
+                                        token.getText());
+
+            case CARD_RARITY:
+                return String.format("%s: %s", Localizer.getInstance().getMessage("lblRarity"),
+                                        token.getText());
+
+            case CARD_TYPE:
+            case CARD_CMC:
+            case MANA_COLOUR:
+            case COMMENT:
+                return token.getText();
+
+            case DECK_NAME:
+                return String.format("%s: %s", Localizer.getInstance().getMessage("lblDeckName"),
+                        token.getText());
+
+            case UNKNOWN_TEXT:
+            default:
+                return null;
+
+        }
+    }
+
+    private String getTokenStatusMessage(DeckRecognizer.Token token){
+        if (token == null)
+            return "";
+
+        switch (token.getType()) {
+            case LIMITED_CARD:
+                return String.format("%s: %s", Localizer.getInstance().getMessage("lblWarningMsgPrefix"),
+                        Localizer.getInstance().getMessage("lblWarnLimitedCard",
+                        StringUtils.capitalize(token.getLimitedCardType().name()), getGameFormatLabel()));
+
+            case CARD_FROM_NOT_ALLOWED_SET:
+                return Localizer.getInstance().getMessage("lblErrNotAllowedCard", getGameFormatLabel());
+
+            case CARD_FROM_INVALID_SET:
+                return Localizer.getInstance().getMessage("lblErrCardEditionDate");
+
+            case UNSUPPORTED_CARD:
+                return Localizer.getInstance().getMessage("lblErrUnsupportedCard", this.currentGameType);
+
+            case UNKNOWN_CARD:
+                return String.format("%s: %s", Localizer.getInstance().getMessage("lblWarningMsgPrefix"),
+                        Localizer.getInstance().getMessage("lblWarnUnknownCardMsg"));
+
+            case UNSUPPORTED_DECK_SECTION:
+            case WARNING_MESSAGE:
+            case COMMENT:
+            case CARD_CMC:
+            case MANA_COLOUR:
+            case CARD_TYPE:
+            case DECK_SECTION_NAME:
+            case CARD_RARITY:
+            case DECK_NAME:
+            case LEGAL_CARD:
+            case UNKNOWN_TEXT:
+            default:
+                return "";
+
+        }
+
+    }
+
     private String getTokenCSSClass(DeckRecognizer.TokenType tokenType){
         switch (tokenType){
             case LEGAL_CARD:
@@ -802,6 +899,17 @@ public class DeckImport<TModel extends DeckBase> extends FDialog {
                 return "";
         }
     }
+
+    private String getTokenFoilLabel(DeckRecognizer.Token token) {
+        if (!token.isCardToken())
+            return "";
+        final String foilMarker = "- (Foil)";
+        return token.getCard().isFoil() ? foilMarker : "";
+    }
+
+    private String getGameFormatLabel() {
+         return String.format("\"%s\"", this.controller.getCurrentGameFormatName());
+    }
 }
 
 class GameFormatDropdownRenderer extends JLabel implements ListCellRenderer<GameFormat> {

forge-gui-mobile/src/forge/adventure/character/EntryActor.java

@@ -43,7 +43,7 @@ public class EntryActor extends MapActor{
     {
         if(targetMap==null||targetMap.isEmpty())
         {
-            stage.exitDungeon(false, false);
+            stage.exitDungeon(false);
         }
         else
         {

forge-gui-mobile/src/forge/adventure/character/PortalActor.java

@@ -39,7 +39,7 @@ public class PortalActor extends EntryActor {
         }
         if (currentAnimationType == PortalAnimationTypes.Active) {
             if (targetMap == null || targetMap.isEmpty()) {
-                stage.exitDungeon(false, false);
+                stage.exitDungeon(false);
             } else {
                 if (targetMap.equals(currentMap)) {
                     stage.spawn(entryTargetObject);

forge-gui-mobile/src/forge/adventure/player/AdventurePlayer.java

@@ -1077,25 +1077,6 @@ public class AdventurePlayer implements Serializable, SaveFileContent {
         return items.random();
     }
 
-    public boolean hasEquippedItem() {
-        for (Long id : equippedItems.values()) {
-            ItemData item = getEquippedItem(id);
-            if (item == null)
-                continue;
-            if (isHardorInsaneDifficulty()) {
-                return true;
-            } else {
-                switch (item.equipmentSlot) {
-                    // limit to these for easy and normal
-                    case "Boots", "Body", "Neck" -> {
-                        return true;
-                    }
-                }
-            }
-        }
-        return false;
-    }
-
     public ItemData getEquippedAbility1() {
         for (Long id : equippedItems.values()) {
             ItemData data = getEquippedItem(id);

forge-gui-mobile/src/forge/adventure/scene/AdventureDeckEditor.java

@@ -27,6 +27,8 @@ import forge.item.PaperCard;
 import forge.itemmanager.*;
 import forge.itemmanager.filters.CardColorFilter;
 import forge.itemmanager.filters.CardTypeFilter;
+import forge.localinstance.properties.ForgePreferences;
+import forge.menu.FCheckBoxMenuItem;
 import forge.menu.FDropDownMenu;
 import forge.menu.FMenuItem;
 import forge.menu.FPopupMenu;
@@ -39,7 +41,6 @@ import forge.util.Utils;
 import java.util.*;
 import java.util.function.Consumer;
 import java.util.function.Function;
-import java.util.function.Predicate;
 
 public class AdventureDeckEditor extends FDeckEditor {
     protected static class AdventureEditorConfig extends DeckEditorConfig {
@@ -145,8 +146,7 @@ public class AdventureDeckEditor extends FDeckEditor {
             if(event.cardBlock != null) {
                 if(event.cardBlock.getLandSet() != null)
                     return List.of(event.cardBlock.getLandSet());
-                List<CardEdition> eventSets = new ArrayList<>(event.cardBlock.getSets());
+                List<CardEdition> eventSets = event.cardBlock.getSets();
-                eventSets.removeIf(Predicate.not(CardEdition::hasBasicLands));
                 if(!eventSets.isEmpty())
                     return eventSets;
             }
@@ -558,7 +558,7 @@ public class AdventureDeckEditor extends FDeckEditor {
             currentEvent.participants[i].setDeck(opponentDecks[i]);
         }
         currentEvent.draftedDeck = (Deck) currentEvent.registeredDeck.copyTo("Draft Deck");
-        if (allowAddBasic()) {
+        if (allowsAddBasic()) {
             showAddBasicLandsDialog();
             //Might be annoying if you haven't pruned your deck yet, but best to remind player that
             //this probably needs to be done since it's there since it's not normally part of Adventure
@@ -713,6 +713,27 @@ public class AdventureDeckEditor extends FDeckEditor {
         return this.deckHeader;
     }
 
+    @Override
+    protected FPopupMenu createMoreOptionsMenu() {
+        return new FPopupMenu() {
+            @Override
+            protected void buildMenu() {
+                Localizer localizer = Forge.getLocalizer();
+                addItem(new FMenuItem(localizer.getMessage("btnCopyToClipboard"), Forge.hdbuttons ? FSkinImage.HDEXPORT : FSkinImage.BLANK, e1 -> FDeckViewer.copyDeckToClipboard(getDeck())));
+                if (allowsAddBasic()) {
+                    FMenuItem addBasic = new FMenuItem(localizer.getMessage("lblAddBasicLands"), FSkinImage.LANDLOGO, e1 -> showAddBasicLandsDialog());
+                    addItem(addBasic);
+                }
+                if(FModel.getPreferences().getPrefBoolean(ForgePreferences.FPref.DEV_MODE_ENABLED)) {
+                    addItem(new FCheckBoxMenuItem(localizer.getMessage("cbEnforceDeckLegality"), shouldEnforceConformity(), e -> toggleConformity()));
+                    String devSuffix = " (" + localizer.getMessage("lblDev") + ")";
+                    addItem(new FMenuItem(localizer.getMessage("lblAddcard") + devSuffix, FSkinImage.HDPLUS, e -> showDevAddCardDialog()));
+                }
+                ((DeckEditorPage) getSelectedPage()).buildDeckMenu(this);
+            }
+        };
+    }
+
     @Override
     protected void addChosenBasicLands(CardPool landsToAdd) {
         if(isLimitedEditor())
@@ -744,12 +765,6 @@ public class AdventureDeckEditor extends FDeckEditor {
         catalog.moveCards(landsToMove, getMainDeckPage());
     }
 
-    @Override
-    protected PaperCard supplyPrintForImporter(PaperCard missingCard) {
-        PaperCard out = super.supplyPrintForImporter(missingCard);
-        return out == null ? null : out.getNoSellVersion();
-    }
-
     @Override
     protected void cacheTabPages() {
         super.cacheTabPages();
@@ -760,9 +775,7 @@ public class AdventureDeckEditor extends FDeckEditor {
     }
 
     @Override
-    protected boolean allowAddBasic() {
+    protected boolean allowsAddBasic() {
-        if(getEditorConfig() instanceof DeckPreviewConfig)
-            return false;
         AdventureEventData currentEvent = getCurrentEvent();
         if (currentEvent == null)
             return true;

forge-gui-mobile/src/forge/adventure/scene/ArenaScene.java

@@ -157,7 +157,7 @@ public class ArenaScene extends UIScene implements IAfterMatch {
     }
 
     @Override
-    public void setWinner(boolean winner, boolean isArena) {
+    public void setWinner(boolean winner) {
         enable = false;
         Array<ArenaRecord> winners = new Array<>();
         Array<EnemySprite> winnersEnemies = new Array<>();

forge-gui-mobile/src/forge/adventure/scene/DuelScene.java

@@ -142,7 +142,7 @@ public class DuelScene extends ForgeScene {
             Current.player().getStatistic().setResult(enemyName, winner);
 
             if (last instanceof IAfterMatch) {
-                ((IAfterMatch) last).setWinner(winner, isArena);
+                ((IAfterMatch) last).setWinner(winner);
             }
         });
     }

forge-gui-mobile/src/forge/adventure/scene/EventScene.java

@@ -541,7 +541,7 @@ public class EventScene extends MenuScene implements IAfterMatch {
 
     AdventureEventData.AdventureEventMatch humanMatch = null;
 
-    public void setWinner(boolean winner, boolean isArena) {
+    public void setWinner(boolean winner) {
         if (winner) {
             humanMatch.winner = humanMatch.p1;
             humanMatch.p1.wins++;

forge-gui-mobile/src/forge/adventure/scene/HudScene.java

@@ -181,8 +181,8 @@ public abstract class HudScene extends Scene implements InputProcessor, IAfterMa
     }
 
     @Override
-    public void setWinner(boolean winner, boolean isArena) {
+    public void setWinner(boolean winner) {
-        stage.setWinner(winner, isArena);
+        stage.setWinner(winner);
     }
 
     public boolean isInHudOnlyMode() {

forge-gui-mobile/src/forge/adventure/stage/ConsoleCommandInterpreter.java

@@ -203,7 +203,7 @@ public class ConsoleCommandInterpreter {
         });
         registerCommand(new String[]{"leave"}, s -> {
             if (!MapStage.getInstance().isInMap()) return "not on a map";
-            MapStage.getInstance().exitDungeon(false, false);
+            MapStage.getInstance().exitDungeon(false);
             return "Got out";
         });
         registerCommand(new String[]{"debug", "collision"}, s -> {

forge-gui-mobile/src/forge/adventure/stage/GameHUD.java

@@ -893,7 +893,7 @@ public class GameHUD extends Stage {
             @Override
             public boolean act(float v) {
                 if (exitDungeon) {
-                    MapStage.getInstance().exitDungeon(false, false);
+                    MapStage.getInstance().exitDungeon(false);
                     setDisabled(exitToWorldMapActor, true, "[%120][+ExitToWorldMap]", "\u2613");
                     setDisabled(bookmarkActor, true, "[%120][+Bookmark]", "\u2613");
                 }

forge-gui-mobile/src/forge/adventure/stage/GameStage.java

@@ -97,7 +97,6 @@ public abstract class GameStage extends Stage {
     public void setDialogStage(Stage dialogStage) {
         this.dialogStage = dialogStage;
     }
-
     public void showDialog() {
         if (dialogStage == null){
             setDialogStage(GameHUD.getInstance());
@@ -124,7 +123,6 @@ public abstract class GameStage extends Stage {
 
     /**
      * Triggered when the hud is showing a dialog, which is tracked separately
-     *
      * @param isShowing Whether a dialog is currently showing
      */
     public void hudIsShowingDialog(boolean isShowing) {
@@ -251,6 +249,7 @@ public abstract class GameStage extends Stage {
     }
 
     
+
     public boolean axisMoved(Controller controller, int axisIndex, float value) {
 
         if (MapStage.getInstance().isDialogOnlyInput()||isPaused()) {
@@ -258,13 +257,15 @@ public abstract class GameStage extends Stage {
         }
         player.getMovementDirection().x = controller.getAxis(0);
         player.getMovementDirection().y = -controller.getAxis(1);
-        if (player.getMovementDirection().len() < 0.2) {
+        if(player.getMovementDirection().len()<0.2)
+        {
             player.stop();
         }
         return true;
     }
 
-    enum PlayerModification {
+    enum PlayerModification
+    {
         Sprint,
         Hide,
         Fly
@@ -273,10 +274,10 @@ public abstract class GameStage extends Stage {
 
 
     HashMap<PlayerModification,Float> currentModifications=new HashMap<>();
-
     public void modifyPlayer(PlayerModification mod,float value) {
         float currentValue=0;
-        if (currentModifications.containsKey(mod)) {
+        if(currentModifications.containsKey(mod))
+        {
             currentValue=currentModifications.get(mod);
         }
         currentModifications.put(mod,currentValue+value);
@@ -286,18 +287,15 @@ public abstract class GameStage extends Stage {
         modifyPlayer(PlayerModification.Fly,value);
         player.playEffect(Paths.EFFECT_FLY);
     }
-
     public void hideFor(float value) {
         modifyPlayer(PlayerModification.Hide,value);
         player.setColor(player.getColor().r,player.getColor().g,player.getColor().b,0.5f);
         player.playEffect(Paths.EFFECT_HIDE);
     }
-
     public void sprintFor(float value) {
         modifyPlayer(PlayerModification.Sprint,value);
         player.playEffect(Paths.EFFECT_SPRINT);
     }
-
     public void startPause(float i) {
         startPause(i, null);
     }
@@ -307,7 +305,6 @@ public abstract class GameStage extends Stage {
         animationTimeout = i;
         player.setMovementDirection(Vector2.Zero);
     }
-
     public boolean isPaused() {
         return animationTimeout > 0;
     }
@@ -333,7 +330,7 @@ public abstract class GameStage extends Stage {
         dialog = Controls.newDialog("");
     }
 
-    public void setWinner(boolean b, boolean a) {
+    public void setWinner(boolean b) {
     }
 
     public void setBounds(float width, float height) {
@@ -369,12 +366,14 @@ public abstract class GameStage extends Stage {
             return;
         }
         Array<PlayerModification> modsToRemove=new Array<>();
-        for (Map.Entry<PlayerModification, Float> mod : currentModifications.entrySet()) {
+        for(Map.Entry<PlayerModification, Float> mod:currentModifications.entrySet())
+        {
             mod.setValue(mod.getValue()-delta);
             if(mod.getValue()<0)
                 modsToRemove.add(mod.getKey());
         }
-        for (PlayerModification mod : modsToRemove) {
+        for(PlayerModification mod:modsToRemove)
+        {
             currentModifications.remove(mod);
             onRemoveEffect(mod);
         }
@@ -409,7 +408,8 @@ public abstract class GameStage extends Stage {
     }
 
     private void onRemoveEffect(PlayerModification mod) {
-        switch (mod) {
+        switch (mod)
+        {
             case Hide:
                 player.setColor(player.getColor().r,player.getColor().g,player.getColor().b,1f);
                 break;
@@ -430,16 +430,20 @@ public abstract class GameStage extends Stage {
         super.keyDown(keycode);
         if (isPaused())
             return true;
-        if (KeyBinding.Left.isPressed(keycode)) {
+        if (KeyBinding.Left.isPressed(keycode))
+        {
             player.getMovementDirection().x = -1;
         }
-        if (KeyBinding.Right.isPressed(keycode)) {
+        if (KeyBinding.Right.isPressed(keycode) )
+        {
             player.getMovementDirection().x = +1;
         }
-        if (KeyBinding.Up.isPressed(keycode)) {
+        if (KeyBinding.Up.isPressed(keycode))
+        {
             player.getMovementDirection().y = +1;
         }
-        if (KeyBinding.Down.isPressed(keycode)) {
+        if (KeyBinding.Down.isPressed(keycode))
+        {
             player.getMovementDirection().y = -1;
         }
         if (keycode == Input.Keys.F5)//todo config
@@ -479,7 +483,8 @@ public abstract class GameStage extends Stage {
             if (GameHUD.getInstance().isDebugMap()) {
                 TileMapScene S = TileMapScene.instance();
                 PointOfInterestData P = PointOfInterestData.getPointOfInterest("DEBUGZONE");
-                if (P != null) {
+                if( P != null)
+                {
                     PointOfInterest PoI = new PointOfInterest(P,new Vector2(0,0), MyRandom.getRandom());
                     S.load(PoI);
                     Forge.switchScene(S);
@@ -566,12 +571,14 @@ public abstract class GameStage extends Stage {
     public boolean keyUp(int keycode) {
         if (isPaused())
             return true;
-        if (KeyBinding.Left.isPressed(keycode) || KeyBinding.Right.isPressed(keycode)) {
+        if (KeyBinding.Left.isPressed(keycode)||KeyBinding.Right.isPressed(keycode))
+        {
             player.getMovementDirection().x = 0;
             if (!player.isMoving())
                 stop();
         }
-        if (KeyBinding.Down.isPressed(keycode) || KeyBinding.Up.isPressed(keycode)) {
+        if (KeyBinding.Down.isPressed(keycode)||KeyBinding.Up.isPressed(keycode))
+        {
             player.getMovementDirection().y = 0;
             if (!player.isMoving())
                 stop();
@@ -651,16 +658,17 @@ public abstract class GameStage extends Stage {
         return Vector2.Zero.cpy();
     }
 
-    protected void teleported(Vector2 position) {
+    protected void teleported(Vector2 position)
+    {
 
     }
-
     public void setPosition(Vector2 position) {
         getPlayerSprite().setPosition(position);
         teleported(position);
     }
 
-    public void resetPlayerLocation() {
+    public void resetPlayerLocation()
+    {
         PointOfInterest poi = Current.world().findPointsOfInterest("Spawn");
         if (poi != null) {
             Forge.advFreezePlayerControls = true;
@@ -669,7 +677,7 @@ public abstract class GameStage extends Stage {
             Timer.schedule(new Timer.Task() {
                 @Override
                 public void run() {
-                showImageDialog(Current.generateDefeatMessage(true), getDefeatBadge(),
+                showImageDialog(Current.generateDefeatMessage(), getDefeatBadge(),
                     () -> FThreads.invokeInEdtNowOrLater(() -> Forge.setTransitionScreen(new CoverScreen(() -> {
                         Forge.advFreezePlayerControls = false;
                         WorldStage.getInstance().setPosition(new Vector2(poi.getPosition().x - 16f, poi.getPosition().y + 16f));
@@ -681,21 +689,6 @@ public abstract class GameStage extends Stage {
             }, 1f);
         }//Spawn shouldn't be null
     }
-
-    public void defeatedFromBoss() {
-        if (!Current.player().hasEquippedItem())
-            return;
-        Forge.advFreezePlayerControls = true;
-        getPlayerSprite().setAnimation(CharacterSprite.AnimationTypes.Hit);
-        getPlayerSprite().playEffect(Paths.EFFECT_BLOOD, 0.5f);
-        Timer.schedule(new Timer.Task() {
-            @Override
-            public void run() {
-                showImageDialog(Current.generateDefeatMessage(false), getDefeatBadge(), () -> Forge.advFreezePlayerControls = false);
-            }
-        }, 1f);
-    }
-
     private FBufferedImage getDefeatBadge() {
         FileHandle defeat = Config.instance().getFile("ui/defeat.png");
         if (defeat.exists()) {

forge-gui-mobile/src/forge/adventure/stage/IAfterMatch.java

@@ -1,5 +1,5 @@
 package forge.adventure.stage;
 
 public interface IAfterMatch {
-    void setWinner(boolean winner, boolean isArena);
+    void setWinner(boolean winner);
 }

forge-gui-mobile/src/forge/adventure/stage/MapStage.java

@@ -606,7 +606,7 @@ public class MapStage extends GameStage {
                         }));
                         break;
                     case "exit":
-                        addMapActor(obj, new OnCollide(() -> MapStage.this.exitDungeon(false, false)));
+                        addMapActor(obj, new OnCollide(() -> MapStage.this.exitDungeon(false)));
                         break;
                     case "dialog":
                         if (obj instanceof TiledMapTileMapObject) {
@@ -750,7 +750,7 @@ public class MapStage extends GameStage {
         }
     }
 
-    public boolean exitDungeon(boolean defeated, boolean defeatedByBoss) {
+    public boolean exitDungeon(boolean defeated) {
         AdventureQuestController.instance().updateQuestsLeave();
         clearIsInMap();
         AdventureQuestController.instance().showQuestDialogs(this);
@@ -758,8 +758,6 @@ public class MapStage extends GameStage {
         effect = null; //Reset dungeon effects.
         if (defeated)
             WorldStage.getInstance().resetPlayerLocation();
-        else if (defeatedByBoss)
-            WorldStage.getInstance().defeatedFromBoss();
         Forge.switchScene(GameScene.instance());
         isPlayerLeavingDungeon = false;
         dialogOnlyInput = false;
@@ -768,7 +766,7 @@ public class MapStage extends GameStage {
 
 
     @Override
-    public void setWinner(boolean playerWins, boolean isArena) {
+    public void setWinner(boolean playerWins) {
         isLoadingMatch = false;
         freezeAllEnemyBehaviors = true;
         if (playerWins) {
@@ -807,16 +805,16 @@ public class MapStage extends GameStage {
                 boolean defeated = Current.player().defeated();
                 //If hardcore mode is added, check and redirect to game over screen here
                 if (canFailDungeon && !defeated)
-                    dungeonFailedDialog(true, currentMob.getData().boss && !isArena);
+                    dungeonFailedDialog(true);
                 else
-                    exitDungeon(defeated, currentMob.getData().boss && !isArena);
+                    exitDungeon(defeated);
                 MapStage.this.stop();
                 currentMob = null;
             });
         }
     }
 
-    private void dungeonFailedDialog(boolean exit, boolean defeatedByBoss) {
+    private void dungeonFailedDialog(boolean exit) {
         dialog.getButtonTable().clear();
         dialog.getContentTable().clear();
         dialog.clearListeners();
@@ -836,7 +834,7 @@ public class MapStage extends GameStage {
                 L.skipToTheEnd();
                 super.clicked(event, x, y);
                 if (exit)
-                    exitDungeon(false, defeatedByBoss);
+                    exitDungeon(false);
             }
         });
         dialog.getButtonTable().add(ok).width(240f);

forge-gui-mobile/src/forge/adventure/stage/WorldStage.java

@@ -162,7 +162,7 @@ public class WorldStage extends GameStage implements SaveFileContent {
     }
 
     @Override
-    public void setWinner(boolean playerIsWinner, boolean isArena) {
+    public void setWinner(boolean playerIsWinner) {
         if (playerIsWinner) {
             currentMob.clearCollisionHeight();
             Current.player().win();
@@ -192,13 +192,10 @@ public class WorldStage extends GameStage implements SaveFileContent {
                 boolean defeated = Current.player().defeated();
                 AdventureQuestController.instance().updateQuestsLose(currentMob);
                 AdventureQuestController.instance().showQuestDialogs(MapStage.getInstance());
-                boolean defeatedFromBoss = currentMob.getData().boss && !isArena;
                 WorldStage.this.removeEnemy(currentMob);
                 currentMob = null;
                 if (defeated) {
                     WorldStage.getInstance().resetPlayerLocation();
-                } else if (defeatedFromBoss) {
-                    WorldStage.getInstance().defeatedFromBoss();
                 }
             });
         }

forge-gui-mobile/src/forge/adventure/util/CardUtil.java

@@ -809,11 +809,6 @@ public class CardUtil {
         return generateBoosterPackAsDeck(edition);
     }
 
-    private static PaperCard getReplacement(String missingCard, String replacementCard) {
-        System.err.println(missingCard + " : Not found in the database.\nReplacement card: " + replacementCard);
-        return FModel.getMagicDb().getCommonCards().getCard(replacementCard);
-    }
-
     public static PaperCard getCardByName(String cardName) {
         List<PaperCard> validCards;
         //Faster to ask the CardDB for a card name than it is to search the pool.
@@ -822,10 +817,6 @@ public class CardUtil {
         else
             validCards = FModel.getMagicDb().getCommonCards().getUniqueCardsNoAlt(cardName);
 
-        if (validCards.isEmpty()) {
-            return getReplacement(cardName, "Wastes");
-        }
-
         return validCards.get(Current.world().getRandom().nextInt(validCards.size()));
     }
 
@@ -837,7 +828,7 @@ public class CardUtil {
                 .filter(input -> input.getEdition().equals(edition)).collect(Collectors.toList());
 
         if (validCards.isEmpty()) {
-            System.err.println("Unexpected behavior: tried to call getCardByNameAndEdition for card " + cardName + " from the edition " + edition + ", but didn't find it in the DB. A random existing instance will be returned if found.");
+            System.err.println("Unexpected behavior: tried to call getCardByNameAndEdition for card " + cardName + " from the edition " + edition + ", but didn't find it in the DB. A random existing instance will be returned.");
             return getCardByName(cardName);
         }
 

forge-gui-mobile/src/forge/adventure/util/Current.java

@@ -27,9 +27,8 @@ public class Current {
     public static void setLatestDeck(Deck generateDeck) {
         deck=generateDeck;
     }
-    public static String generateDefeatMessage(boolean hasDied) {
+    public static String generateDefeatMessage() {
-        String key = hasDied ? "lblYouDied" : "lblYouLostTheLastGame";
+        String message = Forge.getLocalizer().getMessage("lblYouDied", player().getName());
-        String message = Forge.getLocalizer().getMessage(key, player().getName());
         ItemData itemData = player().getRandomEquippedItem();
         if (itemData != null) {
             itemData.isCracked = true;

forge-gui-mobile/src/forge/deck/AddBasicLandsDialog.java

@@ -59,7 +59,7 @@ public class AddBasicLandsDialog extends FDialog {
     private final Consumer<CardPool> callback;
 
     private final FLabel lblLandSet = add(new FLabel.Builder().text(Forge.getLocalizer().getMessage("lblLandSet") + ":").font(FSkinFont.get(12)).textColor(FLabel.getInlineLabelColor()).build());
-    private final FComboBox<CardEdition> cbLandSet = add(new FComboBox<>(IterableUtil.filter(StaticData.instance().getSortedEditions(), CardEdition::hasBasicLands)));
+    private final FComboBox<CardEdition> cbLandSet = add(new FComboBox<>(IterableUtil.filter(StaticData.instance().getEditions(), CardEdition.Predicates.hasBasicLands)));
 
     private final FScrollPane scroller = add(new FScrollPane() {
         @Override

forge-gui-mobile/src/forge/deck/FDeckEditor.java

@@ -81,21 +81,13 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
         public boolean allowsCardReplacement() { return hasInfiniteCardPool() || usePlayerInventory(); }
 
         public List<CardEdition> getBasicLandSets(Deck currentDeck) {
-            if(hasInfiniteCardPool())
-                return FModel.getMagicDb().getSortedEditions().stream().filter(CardEdition::hasBasicLands).collect(Collectors.toList());
             return List.of(DeckProxy.getDefaultLandSet(currentDeck));
         }
 
         protected abstract IDeckController getController();
         protected abstract DeckEditorPage[] getInitialPages();
 
-        public DeckSection[] getPrimarySections() {
+        protected DeckSection[] getExtraSections() {
-            if(getGameType() != null)
-                return getGameType().getPrimaryDeckSections().toArray(new DeckSection[0]);
-            return new DeckSection[]{DeckSection.Main, DeckSection.Sideboard};
-        }
-
-        public DeckSection[] getExtraSections() {
             if(getGameType() != null)
                 return getGameType().getSupplimentalDeckSections().toArray(new DeckSection[0]);
             return new DeckSection[]{DeckSection.Attractions, DeckSection.Contraptions};
@@ -152,7 +144,7 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
         ItemManagerConfig catalogConfig = null;
         ItemManagerConfig mainSectionConfig = null;
         ItemManagerConfig sideboardConfig = null;
-        Function<Deck, Collection<CardEdition>> fnGetBasicLandSet = null;
+        Function<Deck, CardEdition> fnGetBasicLandSet = null;
         Supplier<ItemPool<PaperCard>> itemPoolSupplier = null;
         String catalogCaption = null;
 
@@ -204,7 +196,7 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
             this.sideboardConfig = sideboardConfig;
             return this;
         }
-        public GameTypeDeckEditorConfig setBasicLandSetFunction(Function<Deck, Collection<CardEdition>> fnGetBasicLandSet) {
+        public GameTypeDeckEditorConfig setBasicLandSetFunction(Function<Deck, CardEdition> fnGetBasicLandSet) {
             this.fnGetBasicLandSet = fnGetBasicLandSet;
             return this;
         }
@@ -304,21 +296,9 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
         }
 
         @Override
-        public DeckSection[] getPrimarySections() {
+        protected DeckSection[] getExtraSections() {
-            return gameType.getPrimaryDeckSections().toArray(new DeckSection[0]);
-        }
-
-        @Override
-        public DeckSection[] getExtraSections() {
             return gameType.getSupplimentalDeckSections().toArray(new DeckSection[0]);
         }
-
-        @Override
-        public List<CardEdition> getBasicLandSets(Deck currentDeck) {
-            if(this.fnGetBasicLandSet != null)
-                return List.copyOf(fnGetBasicLandSet.apply(currentDeck));
-            return super.getBasicLandSets(currentDeck);
-        }
     }
 
     public static DeckEditorConfig EditorConfigConstructed = new GameTypeDeckEditorConfig(GameType.Constructed,
@@ -368,19 +348,18 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
             .setMainSectionConfig(ItemManagerConfig.QUEST_DECK_EDITOR)
             .setSideboardConfig(ItemManagerConfig.QUEST_DECK_EDITOR)
             .setPlayerInventorySupplier(() -> FModel.getQuest().getCards().getCardpool())
-            .setBasicLandSetFunction(d -> FModel.getQuest().getAvailableLandSets());
+            .setBasicLandSetFunction(d -> FModel.getQuest().getDefaultLandSet());
     public static DeckEditorConfig EditorConfigQuestCommander = new GameTypeDeckEditorConfig(GameType.QuestCommander, DECK_CONTROLLER_QUEST)
             .setCatalogConfig(ItemManagerConfig.QUEST_EDITOR_POOL)
             .setMainSectionConfig(ItemManagerConfig.QUEST_DECK_EDITOR)
             .setSideboardConfig(ItemManagerConfig.QUEST_DECK_EDITOR)
             .setPlayerInventorySupplier(() -> FModel.getQuest().getCards().getCardpool())
-            .setBasicLandSetFunction(d -> FModel.getQuest().getAvailableLandSets());
+            .setBasicLandSetFunction(d -> FModel.getQuest().getDefaultLandSet());
     public static DeckEditorConfig EditorConfigQuestDraft = new GameTypeDeckEditorConfig(GameType.QuestDraft, DECK_CONTROLLER_QUEST_DRAFT);
     public static DeckEditorConfig EditorConfigPlanarConquest = new GameTypeDeckEditorConfig(GameType.PlanarConquest, DECK_CONTROLLER_PLANAR_CONQUEST)
             .setCatalogConfig(ItemManagerConfig.CONQUEST_COLLECTION)
             .setMainSectionConfig(ItemManagerConfig.CONQUEST_DECK_EDITOR)
-            .setPlayerInventorySupplier(ConquestUtil::getAvailablePool)
+            .setPlayerInventorySupplier(ConquestUtil::getAvailablePool);
-            .setBasicLandSetFunction(ConquestUtil::getBasicLandSets);
 
     protected static DeckSectionPage createPageForExtraSection(DeckSection deckSection, DeckEditorConfig editorConfig) {
         CardManager cm = new CardManager(false);
@@ -563,7 +542,7 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
             @Override
             protected void buildMenu() {
                 final Localizer localizer = Forge.getLocalizer();
-                if (allowAddBasic())
+                if (allowsAddBasic())
                     addItem(new FMenuItem(localizer.getMessage("lblAddBasicLands"), FSkinImage.LANDLOGO, e -> showAddBasicLandsDialog()));
                 if (showAddExtraSectionOption()) {
                     addItem(new FMenuItem(localizer.getMessage("lblAddDeckSection"), FSkinImage.CHAOS, e -> {
@@ -579,33 +558,21 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
                         });
                     }));
                 }
-                if (editorConfig.hasInfiniteCardPool() || editorConfig.usePlayerInventory()) {
+                if (editorConfig.getGameType() != null && editorConfig.hasInfiniteCardPool()) {
                     addItem(new FMenuItem(localizer.getMessage("lblImportFromClipboard"), Forge.hdbuttons ? FSkinImage.HDIMPORT : FSkinImage.OPEN, e -> {
-                        FDeckImportDialog dialog = new FDeckImportDialog(deck, FDeckEditor.this.editorConfig);
+                        FDeckImportDialog dialog = new FDeckImportDialog(!deck.isEmpty(), FDeckEditor.this.editorConfig);
-                        if(editorConfig.usePlayerInventory())
-                            dialog.setFreePrintConverter(FDeckEditor.this::supplyPrintForImporter);
-                        dialog.setImportBannedCards(!FModel.getPreferences().getPrefBoolean(FPref.ENFORCE_DECK_LEGALITY));
                         dialog.setCallback(importedDeck -> {
                             if (deck != null && importedDeck.hasName()) {
                                 deck.setName(importedDeck.getName());
                                 setHeaderText(importedDeck.getName());
                             }
-                            switch (dialog.getImportBehavior()) {
+                            if (dialog.createNewDeck()) {
-                                case REPLACE_CURRENT:
+                                for (Entry<DeckSection, CardPool> section : importedDeck) {
-                                    for(DeckSectionPage page : pagesBySection.values()) {
+                                    DeckSectionPage page = getPageForSection(section.getKey());
-                                        if(importedDeck.has(page.deckSection)) {
+                                    if (page != null)
-                                            page.setCards(importedDeck.get(page.deckSection));
+                                        page.setCards(section.getValue());
-                                            if(hiddenExtraSections.contains(page.deckSection))
-                                                showExtraSectionTab(page.deckSection);
                                 }
-                                        else
+                            } else {
-                                            page.setCards(new CardPool());
-                                    }
-                                    break;
-                                case CREATE_NEW:
-                                    deckController.setDeck(importedDeck);
-                                    break;
-                                case MERGE:
                                 for (Entry<DeckSection, CardPool> section : importedDeck) {
                                     DeckSectionPage page = getPageForSection(section.getKey());
                                     if (page != null)
@@ -613,7 +580,6 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
                                 }
                             }
                         });
-                        dialog.initParse();
                         dialog.show();
                         setSelectedPage(getMainDeckPage()); //select main deck page if needed so main deck if visible below dialog
                     }));
@@ -677,20 +643,6 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
         getMainDeckPage().addCards(landsToAdd);
     }
 
-    /**
-     * If a card is missing from a player's inventory while importing a deck, it gets run through here.
-     * Returning a PaperCard will let unlimited copies of that card be used as a substitute. Returning null
-     * will leave the card missing from the import.
-     */
-    protected PaperCard supplyPrintForImporter(PaperCard missingCard) {
-        //Could support dungeons here too? Not that we really use them in the editor...
-        if(!missingCard.isVeryBasicLand())
-            return null;
-        List<CardEdition> basicSets = editorConfig.getBasicLandSets(deck);
-        String setCode = basicSets.isEmpty() ? "JMP" : basicSets.get(0).getCode();
-        return FModel.getMagicDb().fetchCard(missingCard.getCardName(), setCode, null);
-    }
-
     protected boolean shouldEnforceConformity() {
         if(FModel.getPreferences().getPrefBoolean(FPref.ENFORCE_DECK_LEGALITY))
             return true;
@@ -743,9 +695,6 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
             showExtraSectionTab(section);
         if(pagesBySection.containsKey(section))
             setSelectedPage(pagesBySection.get(section));
-        else if(section == DeckSection.Main && pagesBySection.containsKey(mainDeckPage.deckSection))
-            //Tried to switch to the Main page in a Planar or Scheme deck.
-            setSelectedPage(pagesBySection.get(mainDeckPage.deckSection));
     }
 
     public void notifyNewControllerModel() {
@@ -1078,7 +1027,7 @@ public class FDeckEditor extends TabPageScreen<FDeckEditor> {
     protected boolean allowSaveAs() {
         return allowSave() && allowRename();
     }
-    protected boolean allowAddBasic() {
+    protected boolean allowsAddBasic() {
         return !isDrafting();
     }
 

forge-gui-mobile/src/forge/deck/FDeckImportDialog.java

@@ -18,12 +18,11 @@
 package forge.deck;
 
 import java.util.ArrayList;
-import java.util.EnumSet;
 import java.util.List;
 import java.util.function.Consumer;
-import java.util.function.Function;
 
 import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Lists;
 
 import forge.Forge;
 import forge.Graphics;
@@ -32,15 +31,11 @@ import forge.deck.DeckRecognizer.TokenType;
 import forge.game.GameType;
 import forge.gui.FThreads;
 import forge.gui.util.SOptionPane;
-import forge.item.PaperCard;
 import forge.toolbox.FCheckBox;
 import forge.toolbox.FComboBox;
 import forge.toolbox.FDialog;
 import forge.toolbox.FOptionPane;
 import forge.toolbox.FTextArea;
-import forge.util.ItemPool;
-import forge.util.Localizer;
-import org.apache.commons.lang3.StringUtils;
 
 
 public class FDeckImportDialog extends FDialog {
@@ -50,7 +45,7 @@ public class FDeckImportDialog extends FDialog {
     private final FCheckBox newEditionCheck = add(new FCheckBox(Forge.getLocalizer().getMessage("lblImportLatestVersionCard"), false));
     private final FCheckBox dateTimeCheck = add(new FCheckBox(Forge.getLocalizer().getMessage("lblUseOnlySetsReleasedBefore"), false));
     private final FCheckBox smartCardArtCheck = add(new FCheckBox(Forge.getLocalizer().getMessage("lblUseSmartCardArt"), false));
-    private final FCheckBox createNewDeckCheck = add(new FCheckBox(Forge.getLocalizer().getMessage("lblReplaceDeckCheckbox"), false));
+    private final FCheckBox createNewDeckCheck = add(new FCheckBox(Forge.getLocalizer().getMessage("lblNewDeckCheckbox"), false));
 //    private final FCheckBox importInDeck = add(new FCheckBox()
     /*setting onlyCoreExpCheck to false allow the copied cards to pass the check of deck contents
       forge-core\src\main\java\forge\deck\Deck.javaDeck.java starting @ Line 320 which is called by
@@ -62,60 +57,100 @@ public class FDeckImportDialog extends FDialog {
     private final FComboBox<String> monthDropdown = add(new FComboBox<>()); //don't need wrappers since skin can't change while this dialog is open
     private final FComboBox<Integer> yearDropdown = add(new FComboBox<>());
 
-    private boolean showOptions;
+    private final boolean showOptions;
-    private final Deck currentDeck;
+    private final boolean currentDeckIsEmpty;
     private boolean createNewDeckControl;
     private final DeckImportController controller;
-    private final FDeckEditor.DeckEditorConfig editorConfig;
 
     private final static ImmutableList<String> importOrCancel = ImmutableList.of(Forge.getLocalizer().getMessage("lblImport"), Forge.getLocalizer().getMessage("lblCancel"));
 
-    public FDeckImportDialog(final Deck currentDeck, final FDeckEditor.DeckEditorConfig editorConfig) {
+    public FDeckImportDialog(final boolean replacingDeck, final FDeckEditor.DeckEditorConfig editorConfig) {
         super(Forge.getLocalizer().getMessage("lblImportFromClipboard"), 2);
-        boolean usingInventory = editorConfig.usePlayerInventory();
-        boolean replacingDeck = !currentDeck.isEmpty() || usingInventory;
-        this.currentDeck = currentDeck;
-        this.editorConfig = editorConfig;
-        ItemPool<PaperCard> cardPool = editorConfig.getCardPool(false);
         controller = new DeckImportController(dateTimeCheck, monthDropdown, yearDropdown, replacingDeck);
         String contents = Forge.getClipboard().getContents();
         if (contents == null)
             contents = ""; //prevent NPE
         txtInput.setText(contents);
 
+        if (editorConfig.allowsCardReplacement()) {
             GameType gameType = editorConfig.getGameType();
             controller.setGameFormat(gameType);
             List<DeckSection> supportedSections = new ArrayList<>();
-        supportedSections.addAll(List.of(editorConfig.getPrimarySections()));
+            supportedSections.add(DeckSection.Main);
-        supportedSections.addAll(List.of(editorConfig.getExtraSections()));
+            supportedSections.add(DeckSection.Sideboard);
+            if (editorConfig.hasCommander())
+                supportedSections.add(DeckSection.Commander);
+            supportedSections.addAll(Lists.newArrayList(editorConfig.getExtraSections()));
             controller.setAllowedSections(supportedSections);
-        controller.setCurrentDeckInEditor(currentDeck);
+        }
-        if(usingInventory)
-            controller.setPlayerInventory(cardPool);
 
         onlyCoreExpCheck.setSelected(StaticData.instance().isCoreExpansionOnlyFilterSet());
         newEditionCheck.setSelected(StaticData.instance().cardArtPreferenceIsLatest());
         smartCardArtCheck.setSelected(StaticData.instance().isEnabledCardArtSmartSelection());
         createNewDeckCheck.setSelected(replacingDeck);
+        this.currentDeckIsEmpty = !replacingDeck;
         this.createNewDeckControl = replacingDeck;
 
-        if(usingInventory)
+        initButton(0, Forge.getLocalizer().getMessage("lblImport"), e -> FThreads.invokeInBackgroundThread(() -> {
-            controller.setImportBehavior(DeckImportController.ImportBehavior.REPLACE_CURRENT);
+            List<DeckRecognizer.Token> tokens = controller.parseInput(txtInput.getText()); //ensure deck updated based on any changes to options
-        else
-            controller.setImportBehavior(createNewDeckControl ? DeckImportController.ImportBehavior.CREATE_NEW : DeckImportController.ImportBehavior.MERGE);
 
-        initButton(0, Forge.getLocalizer().getMessage("lblImport"), e -> FThreads.invokeInBackgroundThread(this::performImport));
+            if (controller.isSmartCardArtEnabled())
+                tokens = controller.optimiseCardArtInTokens();
+
+            //if there are any cards that cannot be imported, let user know this and give them the option to cancel
+            StringBuilder sb = new StringBuilder();
+            for (DeckRecognizer.Token token : tokens) {
+                if (token.getType() == TokenType.CARD_FROM_NOT_ALLOWED_SET
+                        || token.getType() == TokenType.CARD_FROM_INVALID_SET
+                        || token.getType() == TokenType.UNKNOWN_CARD
+                        || token.getType() == TokenType.UNSUPPORTED_CARD) {
+                    if (sb.length() > 0)
+                        sb.append("\n");
+                    sb.append(token.getQuantity()).append(" ").append(token.getText());
+                }
+            }
+            if (sb.length() > 0) {
+                if (SOptionPane.showOptionDialog(Forge.getLocalizer().getMessage("lblFollowingCardsCannotBeImported") + "\n\n" + sb, Forge.getLocalizer().getMessage("lblImportRemainingCards"), SOptionPane.INFORMATION_ICON, importOrCancel) == 1) {
+                    return;
+                }
+            }
+
+            final Deck deck = controller.accept(); //must accept in background thread in case a dialog is shown
+            if (deck == null) { return; }
+
+            FThreads.invokeInEdtLater(() -> {
+                hide();
+                if (callback != null)
+                    callback.accept(deck);
+            });
+        }));
         initButton(1, Forge.getLocalizer().getMessage("lblCancel"), e -> hide());
 
+        List<DeckRecognizer.Token> tokens = controller.parseInput(txtInput.getText());
+        if (controller.isSmartCardArtEnabled())
+            tokens = controller.optimiseCardArtInTokens();
+        //ensure at least one known card found on clipboard
+        for (DeckRecognizer.Token token : tokens) {
+            if (token.getType() == TokenType.LEGAL_CARD) {
+                showOptions = true;
+
                 dateTimeCheck.setCommand(e -> updateDropDownEnabled());
                 newEditionCheck.setCommand(e -> setArtPreferenceInController());
                 onlyCoreExpCheck.setCommand(e -> setArtPreferenceInController());
                 smartCardArtCheck.setCommand(e -> controller.setSmartCardArtOptimisation(smartCardArtCheck.isSelected()));
                 createNewDeckCheck.setCommand(e -> {
                     createNewDeckControl = createNewDeckCheck.isSelected();
-            controller.setImportBehavior(createNewDeckControl ? DeckImportController.ImportBehavior.CREATE_NEW : DeckImportController.ImportBehavior.MERGE);
+                    controller.setCreateNewDeck(createNewDeckControl);
                 });
-        setShowOptions(false);
+                updateDropDownEnabled();
+                setArtPreferenceInController();
+                return;
+            }
+        }
+
+        showOptions = false;
+        setButtonEnabled(0, false);
+        txtInput.setText(Forge.getLocalizer().getMessage("lblNoKnownCardsOnClipboard"));
     }
 
     private void setArtPreferenceInController() {
@@ -125,66 +160,16 @@ public class FDeckImportDialog extends FDialog {
     }
 
     private void updateDropDownEnabled() {
-        boolean enabled = dateTimeCheck.isSelected() && this.showOptions;
+        boolean enabled = dateTimeCheck.isSelected();
         monthDropdown.setEnabled(enabled);
         yearDropdown.setEnabled(enabled);
     }
 
-    private void setShowOptions(boolean showOptions) {
-        this.showOptions = showOptions;
-        dateTimeCheck.setEnabled(showOptions);
-        newEditionCheck.setEnabled(showOptions);
-        onlyCoreExpCheck.setEnabled(showOptions);
-        newEditionCheck.setEnabled(showOptions);
-        smartCardArtCheck.setEnabled(showOptions);
-        createNewDeckCheck.setEnabled(showOptions);
-        updateDropDownEnabled();
-    }
-
     public void setCallback(Consumer<Deck> callback0){
         callback = callback0;
     }
 
-    public void setFreePrintConverter(Function<PaperCard, PaperCard> freePrintConverter) {
+    public boolean createNewDeck(){ return this.createNewDeckControl; }
-        this.controller.setFreePrintConverter(freePrintConverter);
-    }
-
-    public DeckImportController.ImportBehavior getImportBehavior() {
-        return controller.getImportBehavior();
-    }
-
-    public void setImportBannedCards(boolean importBannedCards) {
-        controller.importBannedAndRestrictedCards(importBannedCards);
-    }
-
-    public void initParse() {
-        boolean usingInventory = editorConfig.usePlayerInventory();
-        List<DeckRecognizer.Token> tokens = controller.parseInput(txtInput.getText());
-        if (usingInventory)
-            tokens = controller.constrainTokensToInventory();
-        else if (controller.isSmartCardArtEnabled())
-            tokens = controller.optimiseCardArtInTokens();
-        //ensure at least one known card found on clipboard
-        for (DeckRecognizer.Token token : tokens) {
-            if (token.getType() == TokenType.LEGAL_CARD || token.getType() == TokenType.FREE_CARD_NOT_IN_INVENTORY) {
-
-                if(usingInventory) {
-                    //Settings aren't compatible with player inventories.
-                    setShowOptions(false);
-                    return;
-                }
-
-                setShowOptions(true);
-
-                updateDropDownEnabled();
-                setArtPreferenceInController();
-                return;
-            }
-        }
-
-        setButtonEnabled(0, false);
-        txtInput.setText(Forge.getLocalizer().getMessage("lblNoKnownCardsOnClipboard"));
-    }
 
     @Override
     public void drawOverlay(Graphics g) {
@@ -217,7 +202,7 @@ public class FDeckImportDialog extends FDialog {
             yearDropdown.setBounds(x + dropDownWidth + fieldPadding, y, dropDownWidth, h);
             y += h + fieldPadding;
 
-            if (!this.currentDeck.isEmpty()){
+            if (!this.currentDeckIsEmpty){
                 smartCardArtCheck.setBounds(x, y, w/2, h);
                 createNewDeckCheck.setBounds(x + w/2, y, w/2, h);
             } else
@@ -237,50 +222,4 @@ public class FDeckImportDialog extends FDialog {
         }
         return y;
     }
-
-    private static final EnumSet<TokenType> MISSING_TOKENS = EnumSet.of(TokenType.CARD_FROM_NOT_ALLOWED_SET,
-            TokenType.CARD_FROM_INVALID_SET, TokenType.UNKNOWN_CARD, TokenType.UNSUPPORTED_CARD,
-            TokenType.WARNING_MESSAGE, TokenType.CARD_NOT_IN_INVENTORY);
-
-    private void performImport() {
-        List<DeckRecognizer.Token> tokens = controller.parseInput(txtInput.getText()); //ensure deck updated based on any changes to options
-
-        if (editorConfig.usePlayerInventory())
-            tokens = controller.constrainTokensToInventory();
-        else if (controller.isSmartCardArtEnabled())
-            tokens = controller.optimiseCardArtInTokens();
-
-        //if there are any cards that cannot be imported, let user know this and give them the option to cancel
-        // Android API StringBuilder isEmpty() is unavailable. https://developer.android.com/reference/java/lang/StringBuilder
-        StringBuilder sb = new StringBuilder();
-        for (DeckRecognizer.Token token : tokens) {
-            if (MISSING_TOKENS.contains(token.getType())) {
-                if (sb.length() != 0)
-                    sb.append("\n");
-                String message = controller.getTokenMessage(token);
-                String statusMessage = controller.getTokenStatusMessage(token);
-                if(!StringUtils.isBlank(statusMessage))
-                    sb.append(String.format("%s - (%s)", message, statusMessage));
-                else
-                    sb.append(statusMessage);
-            }
-        }
-        if (sb.length() != 0) {
-            Localizer localizer = Forge.getLocalizer();
-            if (SOptionPane.showOptionDialog(localizer.getMessage("lblFollowingCardsCannotBeImported") + "\n\n" + sb, localizer.getMessage("lblImportRemainingCards"), SOptionPane.WARNING_ICON, importOrCancel) == 1) {
-                return;
-            }
-        }
-
-        final Deck deck = controller.accept(currentDeck.getName()); //must accept in background thread in case a dialog is shown
-        if (deck == null) {
-            return;
-        }
-
-        FThreads.invokeInEdtLater(() -> {
-            hide();
-            if (callback != null)
-                callback.accept(deck);
-        });
-    }
 }

forge-gui/res/adventure/common/custom_cards/emrakul_presence.txt

@@ -1,10 +0,0 @@
-Name:Emrakul's Presence
-ManaCost:no cost
-Types:Artifact
-T:Mode$ Phase | Phase$ End of Turn | ValidPlayer$ You | TriggerZones$ Command | CheckSVar$ X | SVarCompare$ LT8 | Execute$ TrigDraw | TriggerDescription$ At the beginning of your end step, if you have fewer than eight cards in hand, draw cards equal to the difference.
-SVar:TrigDraw:DB$ Draw | Defined$ You | NumCards$ Difference
-SVar:X:Count$ValidHand Card.YouOwn
-SVar:Difference:Number$8/Minus.X
-T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Command | Execute$ TrigWish | TriggerDescription$ At the beginning of your upkeep, put a random permanent card from your graveyard or exile onto the battlefield.
-SVar:TrigWish:DB$ ChangeZone | Origin$ Graveyard,Exile | Destination$ Battlefield | ChangeType$ Permanent.YouCtrl | Hidden$ True | AtRandom$ True
-Oracle:At the beginning of your upkeep, put a random permanent card from your graveyard or exile onto the battlefield.\nAt the beginning of your end step, if you have fewer than eight cards in hand, draw cards equal to the difference.

forge-gui/res/adventure/common/decks/boss/emrakul.dck

@@ -1,25 +1,19 @@
 [metadata]
 Name=Emrakul
 [Main]
-1 Black Lotus
+4 Black Lotus
-2 Vesuva
+4 Crystal Vein
 4 Eldrazi Temple
-3 Forsaken Monument
+3 Emrakul, the Aeons Torn
-2 It That Betrays
+3 Emrakul, the Promised End
-2 Pathrazer of Ulamog
-2 Void Winnower
-2 Emrakul, the Aeons Torn
-2 Emrakul, the Promised End
 4 Expedition Map
 2 Eye of Ugin
-4 Ancient Tomb
+4 Mana Vault
-1 Strip Mine
-4 All is Dust
 2 Kozilek, Butcher of Truth
 2 Kozilek, the Great Distortion
-1 Mana Crypt
+4 Mana Crypt
-1 Sol Ring
+4 Sol Ring
-3 Titan's Presence
+4 Titan's Presence
 2 Ulamog, the Ceaseless Hunger
 2 Ulamog, the Infinite Gyre
 4 Urza's Mine

forge-gui/res/adventure/common/maps/map/emrakul/emrakul_legacy.tmx

@@ -3,10 +3,6 @@
  <editorsettings>
   <export target="wastetown..tmx" format="tmx"/>
  </editorsettings>
-  <properties>
-   <property name="dungeonEffect">{&quot;startBattleWithCardInCommandZone&quot;: [ &quot;Emrakul's Presence&quot; ]
- }</property>
-  </properties>
  <tileset firstgid="1" source="../../tileset/main.tsx"/>
  <tileset firstgid="10113" source="../../tileset/buildings.tsx"/>
  <layer id="1" name="Background" width="30" height="30">

forge-gui/res/blockdata/blocks.txt

@@ -144,4 +144,3 @@ Tarkir Dragonstorm, 3/6/TDM, TDM
 Final Fantasy, 3/6/FIN, FIN
 Alchemy: Innistrad, 3/6/ISD, YMID
 Edge of Eternities, 3/6/EOE, EOE
-Marvel's Spider-Man, 3/6/SPM, SPM

forge-gui/res/draft/rankings/spm.rnk

@@ -1,233 +0,0 @@
-//Rank|Name|Rarity|Set
-#1|Arachne, Psionic Weaver|R|SPM
-#2|Origin of Spider-Man|R|SPM
-#3|Spectacular Spider-Man|R|SPM
-#4|Silk, Web Weaver|R|SPM
-#5|Rite of Replication|M|SPM
-#6|Skithiryx, the Blight Dragon|M|SPM
-#7|Goblin Bombardment|M|SPM
-#8|Najeela, the Blade-Blossom|M|SPM
-#9|Lizard, Connors's Curse|R|SPM
-#10|Sandman, Shifting Scoundrel|R|SPM
-#11|Biorganic Carapace|R|SPM
-#12|Doctor Octopus, Master Planner|M|SPM
-#13|The Spot, Living Portal|R|SPM
-#14|Agent Venom|R|SPM
-#15|Gwenom, Remorseless|M|SPM
-#16|Miles Morales|M|SPM
-#17|Arana, Heart of the Spider|R|SPM
-#18|Mister Negative|M|SPM
-#19|Scarlet Spider, Ben Reilly|R|SPM
-#20|Symbiote Spider-Man|R|SPM
-#21|Ultimate Green Goblin|R|SPM
-#22|Arasta of the Endless Web|M|SPM
-#23|Mysterio, Master of Illusion|R|SPM
-#24|Villainous Wrath|R|SPM
-#25|Strength of Will|R|SPM
-#26|Iron Spider, Stark Upgrade|R|SPM
-#27|Anti-Venom, Horrifying Healer|M|SPM
-#28|Friendly Neighborhood|R|SPM
-#29|Peter Parker|M|SPM
-#30|With Great Power|R|SPM
-#31|Hydro-Man, Fluid Felon|R|SPM
-#32|Impostor Syndrome|M|SPM
-#33|Behold the Sinister Six!|M|SPM
-#34|Black Cat, Cunning Thief|R|SPM
-#35|Eddie Brock|M|SPM
-#36|Morlun, Devourer of Spiders|R|SPM
-#37|Spider-Punk|R|SPM
-#38|Spinneret and Spiderling|R|SPM
-#39|Kraven's Last Hunt|R|SPM
-#40|Spider-Ham, Peter Porker|R|SPM
-#41|Carnage, Crimson Chaos|R|SPM
-#42|Cheering Crowd|R|SPM
-#43|Cosmic Spider-Man|M|SPM
-#44|Kraven the Hunter|R|SPM
-#45|Mary Jane Watson|R|SPM
-#46|Rhino, Barreling Brute|U|SPM
-#47|Spider-Man 2099|R|SPM
-#48|Mystic Confluence|M|SPM
-#49|Savage Beating|M|SPM
-#50|Silkguard|M|SPM
-#51|Norman Osborn|M|SPM
-#52|Gwen Stacy|M|SPM
-#53|Green Goblin, Revenant|U|SPM
-#54|Morbius the Living Vampire|U|SPM
-#55|SP//Piloted by Peni|U|SPM
-#56|Spider-Woman, Stunning Savior|R|SPM
-#57|Doc Ock's Tentacles|R|SPM
-#58|Silver Sable, Mercenary Leader|U|SPM
-#59|Spectacular Tactics|C|SPM
-#60|Spider-Man, Web-Slinger|C|SPM
-#61|Spider-UK|U|SPM
-#62|Whoosh!|C|SPM
-#63|Scorpion's Sting|C|SPM
-#64|Electro, Assaulting Battery|R|SPM
-#65|J. Jonah Jameson|R|SPM
-#66|Radioactive Spider|R|SPM
-#67|Spiders-Man, Heroic Horde|U|SPM
-#68|Terrific Team-Up|U|SPM
-#69|Gallant Citizen|C|SPM
-#70|Kraven, Proud Predator|U|SPM
-#71|Superior Spider-Man|R|SPM
-#72|Rocket-Powered Goblin Glider|R|SPM
-#73|Urban Retreat|R|SPM
-#74|Vibrant Cityscape|C|SPM
-#75|Oscorp Industries|R|SPM
-#76|Leyline Binding|M|SPM
-#77|Lorthos, the Tidemaker|M|SPM
-#78|Shock MAR|M|SPM
-#79|Arachnogenesis|M|SPM
-#80|Alibou, Ancient Witness|M|SPM
-#81|Daily Bugle Reporters|C|SPM
-#82|Web Up|C|SPM
-#83|Doc Ock, Sinister Scientist|C|SPM
-#84|Madame Web, Clairvoyant|U|SPM
-#85|Spider-Byte, Web Warden|U|SPM
-#86|The Death of Gwen Stacy|R|SPM
-#87|Spider-Man Noir|U|SPM
-#88|The Spot's Portal|U|SPM
-#89|Tombstone, Career Criminal|U|SPM
-#90|Electro's Bolt|C|SPM
-#91|Shadow of the Goblin|R|SPM
-#92|Shock|C|SPM
-#93|Shocker, Unshakable|U|SPM
-#94|Damage Control Crew|U|SPM
-#95|Kapow!|C|SPM
-#96|Scout the City|C|SPM
-#97|Spider-Man, Brooklyn Visionary|C|SPM
-#98|Wall Crawl|U|SPM
-#99|Prowler, Clawed Thief|U|SPM
-#100|Rhino's Rampage|U|SPM
-#101|Scarlet Spider, Kaine|U|SPM
-#102|Spider-Girl, Legacy Hero|U|SPM
-#103|Spider-Man India|U|SPM
-#104|Wraith, Vicious Vigilante|U|SPM
-#105|Clever Impersonator|M|SPM
-#106|Ponder|M|SPM
-#107|Infernal Grasp|M|SPM
-#108|Saw in Half|M|SPM
-#109|Terminate|M|SPM
-#110|Aunt May|U|SPM
-#111|Flash Thompson, Spider-Fan|U|SPM
-#112|Selfless Police Captain|C|SPM
-#113|Wild Pack Squad|C|SPM
-#114|Chameleon, Master of Disguise|U|SPM
-#115|Flying Octobot|U|SPM
-#116|Robotics Mastery|U|SPM
-#117|School Daze|U|SPM
-#118|Secret Identity|U|SPM
-#119|Scorpion, Seething Striker|U|SPM
-#120|Spider-Gwen, Free Spirit|C|SPM
-#121|Spider-Islanders|C|SPM
-#122|Ezekiel Sims, Spider-Totem|U|SPM
-#123|Pictures of Spider-Man|U|SPM
-#124|Pumpkin Bombardment|C|SPM
-#125|Shriek, Treblemaker|U|SPM
-#126|Spider Manifestation|C|SPM
-#127|Path to Exile|M|SPM
-#128|Beetle, Legacy Criminal|C|SPM
-#129|The Clone Saga|R|SPM
-#130|Mysterio's Phantasm|C|SPM
-#131|Prison Break|U|SPM
-#132|Superior Foes of Spider-Man|U|SPM
-#133|Guy in the Chair|C|SPM
-#134|Skyward Spider|C|SPM
-#135|Spider-Bot|C|SPM
-#136|Ominous Asylum|C|SPM
-#137|Savage Mansion|C|SPM
-#138|Sinister Hideout|C|SPM
-#139|Suburban Sanctuary|C|SPM
-#140|University Campus|C|SPM
-#141|Reprieve|M|SPM
-#142|Opposition Agent|M|SPM
-#143|Relentless Assault|M|SPM
-#144|City Pigeon|C|SPM
-#145|Sudden Strike|U|SPM
-#146|Thwip!|C|SPM
-#147|Amazing Acrobatics|C|SPM
-#148|Doc Ock's Henchmen|C|SPM
-#149|Spider-Man No More|C|SPM
-#150|Unstable Experiment|C|SPM
-#151|Common Crook|C|SPM
-#152|Swarm, Being of Bees|C|SPM
-#153|Venom, Evil Unleashed|C|SPM
-#154|Venomized Cat|C|SPM
-#155|Venom's Hunger|C|SPM
-#156|Angry Rabble|C|SPM
-#157|Hobgoblin, Mantled Marauder|U|SPM
-#158|Masked Meower|C|SPM
-#159|Raging Goblinoids|U|SPM
-#160|Romantic Rendezvous|C|SPM
-#161|Stegron the Dinosaur Man|C|SPM
-#162|Taxi Driver|C|SPM
-#163|Wisecrack|U|SPM
-#164|Grow Extra Arms|C|SPM
-#165|Kraven's Cats|C|SPM
-#166|Lurking Lizards|C|SPM
-#167|Professional Wrestler|C|SPM
-#168|Supportive Parents|U|SPM
-#169|Mob Lookout|C|SPM
-#170|Eerie Gravestone|C|SPM
-#171|Living Brain, Mechanical Marvel|U|SPM
-#172|Mechanical Mobster|C|SPM
-#173|Spider-Slayer, Hatred Honed|U|SPM
-#174|Spider-Suit|U|SPM
-#175|Counterspell|M|SPM
-#176|Feed the Swarm|M|SPM
-#177|Thrill of Possibility|M|SPM
-#178|Unexpected Windfall|M|SPM
-#179|Costume Closet|U|SPM
-#180|Starling, Aerial Ally|C|SPM
-#181|Web-Shooters|U|SPM
-#182|Oscorp Research Team|C|SPM
-#183|Inner Demons Gangsters|C|SPM
-#184|Merciless Enforcers|C|SPM
-#185|Risky Research|C|SPM
-#186|Sandman's Quicksand|U|SPM
-#187|Heroes' Hangout|U|SPM
-#188|Spider-Rex, Daring Dino|C|SPM
-#189|Web-Warriors|U|SPM
-#190|Passenger Ferry|C|SPM
-#191|Subway Train|C|SPM
-#192|Vulture, Scheming Scavenger|U|SPM
-#193|Hot Dog Cart|C|SPM
-#194|Interdimensional Web Watch|R|SPM
-#195|Spider-Mobile|U|SPM
-#196|Steel Wrecking Ball|C|SPM
-#197|Rent Is Due|R|SPM
-#198|Hide on the Ceiling|R|SPM
-#199|Lady Octopus, Inspired Inventor|R|SPM
-#200|Alien Symbiosis|U|SPM
-#201|Molten Man, Inferno Incarnate|U|SPM
-#202|Spider-Verse|M|SPM
-#203|Web of Life and Destiny|M|SPM
-#204|Jackal, Genius Geneticist|R|SPM
-#205|Sun-Spider, Nimble Webber|U|SPM
-#206|Bagel and Schmear|C|SPM
-#207|Peter Parker's Camera|R|SPM
-#208|Daily Bugle Building|U|SPM
-#209|Multiversal Passage|R|SPM
-#210|Comeuppance|M|SPM
-#211|Traumatize|M|SPM
-#212|Reanimate|M|SPM
-#213|Heroic Intervention|M|SPM
-#214|News Helicopter|C|SPM
-#215|Parallel Lives|M|SPM
-#216|Hex|M|SPM
-#217|Tangle|M|SPM
-#218|Spider-Sense|R|SPM
-#219|Parker Luck|R|SPM
-#220|The Soul Stone|M|SPM
-#221|Maximum Carnage|R|SPM
-#222|Nine Lives|M|SPM
-#223|Rest in Peace|M|SPM
-#224|Mindbreak Trap|M|SPM
-#225|Winds of Change|M|SPM
-#226|Beast Within|M|SPM
-#227|Hunter's Insight|M|SPM
-#228|Plains|C|SPM
-#229|Island|C|SPM
-#230|Swamp|C|SPM
-#231|Mountain|C|SPM
-#232|Forest|C|SPM

forge-gui/res/editions/Marvel's Spider-Man.txt

@@ -6,66 +6,6 @@ Type=Expansion
 ScryfallCode=SPM
 DoublePick=WhenPodSizeIs4
 RecommendedPodSize=4
-#https://magic.wizards.com/en/news/feature/collecting-marvels-spider-man
-BoosterSlots=Common,Common-Borderless,Uncommon,RareMythic,Land,Wildcard,WildcardFoil
-Booster=6 Common, 1 Common-Borderless, 3 Uncommon, 1 RareMythic, 1 Wildcard, 1 WildcardFoil+, 1 Land
-Prerelease=6 Boosters, 1 RareMythic+
-BoosterBox=30
-
-[Common]
-Base=Common:fromSheet("SPM cards")
-
-[Common-Borderless]
-Base=Common:fromSheet("SPM cards")
-Replace=.0416F fromSheet("SPM borderless")
-
-[Uncommon]
-Base=Uncommon:fromSheet("SPM cards")
-Replace=0.0517 Uncommon:fromSheet("SPM scene cards")
-
-[RareMythic]
-Base=Rare:fromSheet("SPM cards")
-Replace=.117F Mythic:fromSheet("SPM cards")
-Replace=.012F Rare:fromSheet("SPM webslinger")
-Replace=.004F Mythic:fromSheet("SPM webslinger")
-Replace=.021F Rare:fromSheet("SPM panel cards")
-Replace=.004F Mythic:fromSheet("SPM panel cards")
-Replace=.01F Rare:fromSheet("SPM scene cards")
-Replace=.0005F Mythic:fromSheet("SPM scene cards")
-
-[Wildcard]
-Base=Common:fromSheet("SPM cards")
-Replace=0.041F Uncommon:fromSheet("SPM cards")
-Replace=0.209F Rare:fromSheet("SPM cards")
-Replace=0.0029F Mythic:fromSheet("SPM cards")
-Replace=.0012F Rare:fromSheet("SPM webslinger")
-Replace=.0004F Mythic:fromSheet("SPM webslinger")
-Replace=.0021F Rare:fromSheet("SPM panel cards")
-Replace=.0004F Mythic:fromSheet("SPM panel cards")
-Replace=.007F Uncommon:fromSheet("SPM scene cards")
-Replace=.001F Rare:fromSheet("SPM scene cards")
-Replace=.00005F Mythic:fromSheet("SPM scene cards")
-
-[WildcardFoil]
-Base=Common:fromSheet("SPM cards")
-Replace=0.241F Uncommon:fromSheet("SPM cards")
-Replace=0.078F Rare:fromSheet("SPM cards")
-Replace=0.011F Mythic:fromSheet("SPM cards")
-Replace=.0012F Rare:fromSheet("SPM webslinger")
-Replace=.0004F Mythic:fromSheet("SPM webslinger")
-Replace=.0021F Rare:fromSheet("SPM panel cards")
-Replace=.0004F Mythic:fromSheet("SPM panel cards")
-Replace=.007F Uncommon:fromSheet("SPM scene cards")
-Replace=.001F Rare:fromSheet("SPM scene cards")
-Replace=.00005F Mythic:fromSheet("SPM scene cards")
-
-[Land]
-Base=fromSheet("SPM allied lands")
-Replace=0.125F fromSheet("SPM allied lands")+
-Replace=0.20F BasicLand:fromSheet("SPM full art")
-Replace=0.05F BasicLand:fromSheet("SPM full art")+
-Replace=0.20F BasicLand:fromSheet("SPM cards"):!fromSheet("SPM allied lands")
-Replace=0.05F BasicLand:fromSheet("SPM cards"):!fromSheet("SPM allied lands")
 
 [cards]
 1 M Anti-Venom, Horrifying Healer @Néstor Ossandón Leal
@@ -248,28 +188,24 @@ Replace=0.05F BasicLand:fromSheet("SPM cards"):!fromSheet("SPM allied lands")
 178 C Subway Train @Jonas De Ro
 179 U Daily Bugle Building @David Álvarez
 180 R Multiversal Passage @Pablo Mendoza
-181 L Ominous Asylum @Pavel Kolomeyets
+181 C Ominous Asylum @Pavel Kolomeyets
 182 R Oscorp Industries @Bastien Grivet
-183 L Savage Mansion @David Álvarez
+183 C Savage Mansion @David Álvarez
-184 L Sinister Hideout @Pavel Kolomeyets
+184 C Sinister Hideout @Pavel Kolomeyets
-185 L Suburban Sanctuary @David Frasheski
+185 C Suburban Sanctuary @David Frasheski
-186 L University Campus @David Álvarez
+186 C University Campus @David Álvarez
 187 R Urban Retreat @Jonas De Ro
 188 C Vibrant Cityscape @Wei Guan
-194 L Plains @Jonas De Ro
-195 L Island @Jonas De Ro
-196 L Swamp @Jonas De Ro
-197 L Mountain @Jonas De Ro
-198 L Forest @Jonas De Ro
-
-[full art]
 189 L Plains @Sarah Finnigan
 190 L Island @Sarah Finnigan
 191 L Swamp @Sarah Finnigan
 192 L Mountain @Sarah Finnigan
 193 L Forest @Sarah Finnigan
-
+194 L Plains @Jonas De Ro
-[borderless]
+195 L Island @Jonas De Ro
+196 L Swamp @Jonas De Ro
+197 L Mountain @Jonas De Ro
+198 L Forest @Jonas De Ro
 199 U SP//dr, Piloted by Peni @Jim Cheung & Jay David Ramos
 200 M Miles Morales @Jim Cheung & Jay David Ramos
 201 R Spider-Ham, Peter Porker @Jim Cheung & Jay David Ramos
@@ -306,9 +242,6 @@ Replace=0.05F BasicLand:fromSheet("SPM cards"):!fromSheet("SPM allied lands")
 232 M Peter Parker @Jack Kirby & Steve Ditko
 233 M Eddie Brock @Todd McFarlane & Bob Sharen
 234 M Miles Morales @Sara Pichelli & Justin Ponsor
-242 M The Soul Stone @Madeline Boni
-
-[etched]
 235 R Spectacular Spider-Man @Roberta Ingranata
 236 R Spectacular Spider-Man @Roberta Ingranata
 237 R Spectacular Spider-Man @Roberta Ingranata
@@ -316,8 +249,7 @@ Replace=0.05F BasicLand:fromSheet("SPM cards"):!fromSheet("SPM allied lands")
 239 R Spectacular Spider-Man @Roberta Ingranata
 240 R Spectacular Spider-Man @Roberta Ingranata
 241 R Spectacular Spider-Man @Roberta Ingranata
-
+242 M The Soul Stone @Madeline Boni
-[extended art]
 243 M The Soul Stone @Leinil Francis Yu & Sunny Gho
 244 M Anti-Venom, Horrifying Healer @Néstor Ossandón Leal
 245 R Arachne, Psionic Weaver @Steve Argyle
@@ -359,63 +291,10 @@ Replace=0.05F BasicLand:fromSheet("SPM cards"):!fromSheet("SPM allied lands")
 281 R Rocket-Powered Goblin Glider @Pavel Kolomeyets
 282 R Oscorp Industries @Bastien Grivet
 283 R Urban Retreat @Jonas De Ro
-
-[promo]
 284 R Spider-Sense @David Álvarez
 285 R Radioactive Spider @Toni Infante
 286 M Gwenom, Remorseless @Jesper Ejsing
 
-[allied lands]
-1 Ominous Asylum|SPM
-1 Savage Mansion|SPM
-1 Sinister Hideout|SPM
-1 Suburban Sanctuary|SPM
-1 University Campus|SPM
-
-[scene cards]
-1 SP//dr, Piloted by Peni|SPM|[199]
-1 Miles Morales|SPM|[200]
-1 Spider-Ham, Peter Porker|SPM|[201]
-1 Gwen Stacy|SPM|[202]
-1 Web-Warriors|SPM|[203]
-1 Spider-Man Noir|SPM|[204]
-1 Spider-Man 2099|SPM|[205]
-1 Multiversal Passage|SPM|[206]
-1 Spider-Punk|SPM|[207]
-
-[webslinger]
-1 Peter Parker|SPM|[208]
-1 Gwen Stacy|SPM|[209]
-1 Spider-Punk|SPM|[210]
-1 Miles Morales|SPM|[211]
-1 Radioactive Spider|SPM|[212]
-1 Araña, Heart of the Spider|SPM|[213]
-1 Scarlet Spider, Ben Reilly|SPM|[214]
-1 Silk, Web Weaver|SPM|[215]
-1 Spider-Man 2099|SPM|[216]
-1 Symbiote Spider-Man|SPM|[217]
-
-[panel cards]
-1 Origin of Spider-Man|SPM|[218]
-1 The Clone Saga|SPM|[219]
-1 Norman Osborn|SPM|[220]
-1 Behold the Sinister Six!|SPM|[221]
-1 Black Cat, Cunning Thief|SPM|[222]
-1 The Death of Gwen Stacy|SPM|[223]
-1 Eddie Brock|SPM|[224]
-1 Maximum Carnage|SPM|[225]
-1 Kraven's Last Hunt|SPM|[226]
-1 Carnage, Crimson Chaos|SPM|[227]
-1 Doctor Octopus, Master Planner|SPM|[228]
-1 Mary Jane Watson|SPM|[229]
-1 Spider-Woman, Stunning Savior|SPM|[230]
-1 The Spot, Living Portal|SPM|[231]
-
-[classic comic]
-1 Peter Parker|SPM|[232]
-1 Eddie Brock|SPM|[233]
-1 Miles Morales|SPM|[234]
-
 [tokens]
 2 u_3_3_illusion_villain @Anthony Devine
 3 g_2_1_spider_reach @Domenico Cava

forge-gui/res/editions/Through the Omenpaths 1 Bonus Sheet.txt

@@ -6,43 +6,43 @@ Type=Online
 ScryfallCode=OMB
 
 [cards]
-1 R Comeuppance @Igor Krstic
+1 M Comeuppance @
-2 R Leyline Binding @Cristi Balanescu
+2 M Leyline Binding @
-3 R Nine Lives @Paul Scott Canavan
+3 M Nine Lives @
-4 R Path to Exile @Todd Lockwood
+4 M Path to Exile @
-5 U Reprieve @Mariah Tekulve
+5 M Reprieve @
-6 R Rest in Peace @Jarel Threat
+6 M Rest in Peace @
-7 M Wedding Ring @Olena Richards
+7 M Wedding Ring @
-8 M Clever Impersonator @Slawomir Maniak
+8 M Clever Impersonator @
-9 R Counterspell @Gao Yan
+9 M Counterspell @
-10 M Lorthos, the Tidemaker @Kekai Kotaki
+10 M Lorthos, the Tidemaker @
-11 M Mindbreak Trap @Christopher Moeller
+11 M Mindbreak Trap @
-12 R Mystic Confluence @Kieran Yanner
+12 M Mystic Confluence @
-13 C Ponder @Ernanda Souza
+13 M Ponder @
-14 R Rite of Replication @Matt Cavotta
+14 M Rite of Replication @
-15 R Traumatize @Greg Staples
+15 M Traumatize @
-16 C Feed the Swarm @Nino Is
+16 M Feed the Swarm @
-17 R Hex @Michael Sutfin
+17 M Hex @
-18 U Infernal Grasp @Naomi Baker
+18 M Infernal Grasp @
-19 M Opposition Agent @Scott Murphy
+19 M Opposition Agent @
-20 R Reanimate @Johann Bodin
+20 M Reanimate @
-21 R Saw in Half @Alexander Mokhov
+21 M Saw in Half @
-22 M Skithiryx, the Blight Dragon @Chippy
+22 M Skithiryx, the Blight Dragon @
-23 R Goblin Bombardment @Dave Kendall
+23 M Goblin Bombardment @
-24 M Najeela, the Blade-Blossom @Matt Stewart
+24 M Najeela, the Blade-Blossom @
-25 R Relentless Assault @Greg Hildebrandt
+25 M Relentless Assault @
-26 M Savage Beating @Matt Thompson
+26 M Savage Beating @
-27 C Shock @Jon Foster
+27 M Shock @
-28 C Thrill of Possibility @Izzy
+28 M Thrill of Possibility @
-29 C Unexpected Windfall @Lorenzo Mastroianni
+29 M Unexpected Windfall @
-30 U Winds of Change @Adam Rex
+30 M Winds of Change @
-31 R Arachnogenesis @Johannes Voss
+31 M Arachnogenesis @
-32 R Arasta of the Endless Web @Sam Rowan
+32 M Arasta of the Endless Web @
-33 U Beast Within @Jesper Ejsing
+33 M Beast Within @
-34 R Heroic Intervention @James Ryman
+34 M Heroic Intervention @
-35 U Hunter's Insight @Jim Murray
+35 M Hunter's Insight @
-36 M Parallel Lives @Steve Prescott
+36 M Parallel Lives @
-37 R Silkguard @Dan Murayama Scott
+37 M Silkguard @
-38 U Tangle @Néstor Ossandón Leal
+38 M Tangle @
-39 M Alibou, Ancient Witness @Matt Stewart
+39 M Alibou, Ancient Witness @
-40 U Terminate @Wayne Reynolds
+40 M Terminate @

forge-gui/res/languages/de-DE.properties

@@ -2838,7 +2838,6 @@ lblDecklistTitle=Deckliste
 lblSummaryStats=Gesamt-Statistik
 lblDeckSection=Bereich
 lblNewDeckCheckbox=Erzeuge ein neues Deck
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Importiere Karten
 lblCreateNewCmd=Neues Deck
 lblErrNotAllowedCard=Set ist nicht erlaubt in {0}
@@ -2846,7 +2845,6 @@ lblWarnLimitedCard={0} in {1}
 lblErrCardEditionDate=Set verträgt sich nicht mit der Erscheinungsdatum-Option
 lblErrUnsupportedCard=Ist nicht erlaubt in {0}
 lblWarnUnknownCardMsg=Unbekannte oder in Forge nicht unterstützte Karte
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=Aktueller {0}-Bereich enthält {1} mögliche Commander-Karten: {2}
 lblWarnCommandersInSideExtra=Bitte prüfen und, falls nötig, min. eine Karte in den Commander-Bereich verschieben.
 lblWarnDeckSectionNotAllowedInEditor=In {1} ist der {0}-Bereich nicht erlaubt. 
@@ -2938,7 +2936,6 @@ lblCardImportWarning=\nWarnung: Das Deck {0} wird umbenannt in {1}.
 lblConfirmCreateNewDeck=Du bist dabei das neue Deck {0} zu erzeugen. {1}\n\nWillst du fortfahren?\n\n Hinweis: \
   Bitte denk daran den "Save"-Knopf im Deck-Editor zu klicken, um das neue Deck dem Deck-Katalog hinzuzufügen!
 lblNewDeckWarning=\nWarnung: Alle ungesicherten Änderungen am aktuellen Deck {0} werden verlorengehen.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Importiere Karten in aktuelles Deck
 lblNewDeckDialogTitle=Erzeuge neues Deck
 #FNetOverlay.java

forge-gui/res/languages/en-US.properties

@@ -2898,7 +2898,6 @@ lblDecklistTitle=Decklist
 lblSummaryStats=Summary Statistics
 lblDeckSection=Section
 lblNewDeckCheckbox=Create a New Deck
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Import Cards
 lblCreateNewCmd=New Deck
 lblErrNotAllowedCard=Set not allowed in {0}
@@ -2906,7 +2905,6 @@ lblWarnLimitedCard={0} in {1}
 lblErrCardEditionDate=Set not compliant with Release Date option
 lblErrUnsupportedCard=Not allowed in {0}
 lblWarnUnknownCardMsg=Unknown Card or Unsupported in Forge
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=Current {0} Section contains {1} potential Commander Cards: {2}
 lblWarnCommandersInSideExtra=Please check and move one to the Commander Section, in case.
 lblWarnDeckSectionNotAllowedInEditor={0} Section is not allowed in {1}
@@ -3003,7 +3001,6 @@ lblCardImportWarning=\nWarning: The deck {0} will be renamed as {1}.
 lblConfirmCreateNewDeck=You are about to create a new deck {0}. {1}\n\nWould you like to proceed?\n\n Note: \
   Please remember to click on the "Save" button in the Deck Editor to add the new deck to the Catalog!
 lblNewDeckWarning=\nWarning: Any unsaved changes to the current deck {0} will be lost.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Import cards in the Current Deck
 lblNewDeckDialogTitle=Create a New Deck
 #FNetOverlay.java

forge-gui/res/languages/es-ES.properties

@@ -2847,7 +2847,6 @@ lblDecklistTitle=Decklist
 lblSummaryStats=Summary Statistics
 lblDeckSection=Section
 lblNewDeckCheckbox=Create a New Deck
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Import Cards
 lblCreateNewCmd=New Deck
 lblErrNotAllowedCard=Set not allowed in {0}
@@ -2855,7 +2854,6 @@ lblWarnLimitedCard={0} in {1}
 lblErrCardEditionDate=Set not compliant with Release Date option
 lblErrUnsupportedCard=Not allowed in {0}
 lblWarnUnknownCardMsg=Unknown Card or Unsupported in Forge
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=Current {0} Section contains {1} potential Commander Cards: {2}
 lblWarnCommandersInSideExtra=Please check and move one to the Commander Section, in case.
 lblWarnDeckSectionNotAllowedInEditor={0} Section is not allowed in {1}
@@ -2952,7 +2950,6 @@ lblCardImportWarning=\nWarning: The deck {0} will be renamed as {1}.
 lblConfirmCreateNewDeck=You are about to create a new deck {0}. {1}\n\nWould you like to proceed?\n\n Note: \
   Please remember to click on the "Save" button in the Deck Editor to add the new deck to the Catalog!
 lblNewDeckWarning=\nWarning: Any unsaved changes to the current deck {0} will be lost.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Import cards in the Current Deck
 lblNewDeckDialogTitle=Create a New Deck
 #FNetOverlay.java

forge-gui/res/languages/fr-FR.properties

@@ -2840,7 +2840,6 @@ lblDecklistTitle=Liste de deck
 lblSummaryStats=Statistiques récapitulatives
 lblDeckSection=Section
 lblNewDeckCheckbox=Créer un nouveau deck
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Importer des cartes
 lblCreateNewCmd=Nouveau Deck
 lblErrNotAllowedCard=Définir non autorisé dans {0}
@@ -2848,7 +2847,6 @@ lblWarnLimitedCard={0} dans {1}
 lblErrCardEditionDate=Set non conforme avec l'option de date de sortie
 lblErrUnsupportedCard=Non autorisé dans {0}
 lblWarnUnknownCardMsg=Carte inconnue ou non prise en charge dans Forge
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=La section {0} actuelle contient {1} cartes de commandant potentielles : {2}
 lblWarnCommandersInSideExtra=Veuillez vérifier et en déplacer un vers la section Commandant, au cas où.
 lblWarnDeckSectionNotAllowedInEditor={0} La section n'est pas autorisée dans {1}
@@ -2946,7 +2944,6 @@ lblCardImportWarning=\nAttention : Le deck {0} sera renommé en {1}.
 lblConfirmCreateNewDeck=Vous êtes sur le point de créer un nouveau deck {0}. {1}\n\nVoulez-vous continuer ?\n\n Remarque : \
   N'oubliez pas de cliquer sur le bouton "Enregistrer" dans l'éditeur de deck pour ajouter le nouveau deck au catalogue !
 lblNewDeckWarning=\nAttention : Toute modification non enregistrée dans le deck actuel {0} sera perdue.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Importer des cartes dans le Deck actuel
 lblNewDeckDialogTitle=Créer un nouveau deck
 #FNetOverlay.java

forge-gui/res/languages/it-IT.properties

@@ -2836,7 +2836,6 @@ lblDecklistTitle=Lista delle Carte da Importare
 lblSummaryStats=Statistiche Generali
 lblDeckSection=Sezione
 lblNewDeckCheckbox=Crea un nuovo mazzo
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Importa le carte
 lblCreateNewCmd=Nuovo mazzo
 lblErrNotAllowedCard=Edizione non permessa in {0}
@@ -2844,7 +2843,6 @@ lblWarnLimitedCard={0} in {1}
 lblErrCardEditionDate=Edizione non valida secondo l'opzione sulla data di pubblicazione selezionata
 lblErrUnsupportedCard=Non Permesso in {0}
 lblWarnUnknownCardMsg=Carta Sconosciuta, o non supportata in Forge
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=La Sezione {0} contiene {1} potenziali carte Commander: {2}
 lblWarnCommandersInSideExtra=Per favore, controlla e nel caso spostane una nella sezione Commander.
 lblWarnDeckSectionNotAllowedInEditor={0} Sezione non è permessa in {1}
@@ -2944,7 +2942,6 @@ lblCardImportWarning=\nAttenzione: Il mazzo {0} sarà rinominato come {1}.
 lblConfirmCreateNewDeck=Si sta per creare un nuovo mazzo {0}. {1}\n\nSi desidera procedere?\n\n Nota: \
   Non dimenticare di premere il tasto "Salva" una volta importate le carte per aggiungere il nuovo mazzo al catalogo!
 lblNewDeckWarning=\nAttenzione: Qualsiasi modifica non salvata al mazzo corrente {0} sarà persa.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Importa le carte nel mazzo corrente
 lblNewDeckDialogTitle=Crea un nuovo mazzo
 #FNetOverlay.java

forge-gui/res/languages/ja-JP.properties

@@ -2835,7 +2835,6 @@ lblDecklistTitle=Decklist
 lblSummaryStats=Summary Statistics
 lblDeckSection=Section
 lblNewDeckCheckbox=Create a New Deck
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Import Cards
 lblCreateNewCmd=New Deck
 lblErrNotAllowedCard=Set not allowed in {0}
@@ -2843,7 +2842,6 @@ lblWarnLimitedCard={0} in {1}
 lblErrCardEditionDate=Set not compliant with Release Date option
 lblErrUnsupportedCard=Not allowed in {0}
 lblWarnUnknownCardMsg=Unknown Card or Unsupported in Forge
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=Current {0} Section contains {1} potential Commander Cards: {2}
 lblWarnCommandersInSideExtra=Please check and move one to the Commander Section, in case.
 lblWarnDeckSectionNotAllowedInEditor={0} Section is not allowed in {1}
@@ -2940,7 +2938,6 @@ lblCardImportWarning=\nWarning: The deck {0} will be renamed as {1}.
 lblConfirmCreateNewDeck=You are about to create a new deck {0}. {1}\n\nWould you like to proceed?\n\n Note: \
   Please remember to click on the "Save" button in the Deck Editor to add the new deck to the Catalog!
 lblNewDeckWarning=\nWarning: Any unsaved changes to the current deck {0} will be lost.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Import cards in the Current Deck
 lblNewDeckDialogTitle=Create a New Deck
 #FNetOverlay.java

forge-gui/res/languages/pt-BR.properties

@@ -2917,7 +2917,6 @@ lblDecklistTitle=Lista de decks
 lblSummaryStats=Estatísticas Resumidas
 lblDeckSection=Seção
 lblNewDeckCheckbox=Criar um Novo deck
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=Importar Cartas
 lblCreateNewCmd=Novo Deck
 lblErrNotAllowedCard=Coleção não permitida em {0}
@@ -2925,7 +2924,6 @@ lblWarnLimitedCard={0} em {1}
 lblErrCardEditionDate=Coleção não compatível com a opção de Data de Lançamento
 lblErrUnsupportedCard=Não permitido em {0}
 lblWarnUnknownCardMsg=Carta desconhecida ou não suportada no Forge
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=Seção {0} Atual contém {1} Cartas de Comandante em potencial\: {2}
 lblWarnCommandersInSideExtra=Verifique e mova um para a seção do Comandante.
 lblWarnDeckSectionNotAllowedInEditor=Seção {0} não é permitida em {1}
@@ -3014,7 +3012,6 @@ Deseja prosseguir?\n\
  Nota\: Por favor, lembre-se de clicar no botão "Salvar" no Editor do Deck para adicioná-lo ao Catálogo\!
 lblNewDeckWarning=\n\
 Aviso\: Qualquer alteração não salva no deck atual {0} será perdida.
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=Importar cartas no Deck Atual
 lblNewDeckDialogTitle=Criar um Novo deck
 #FNetOverlay.java

forge-gui/res/languages/zh-CN.properties

@@ -2844,7 +2844,6 @@ lblDecklistTitle=套牌列表
 lblSummaryStats=统计摘要
 lblDeckSection=部分
 lblNewDeckCheckbox=创建一个新套牌
-lblReplaceDeckCheckbox=Replace Current Deck
 lblImportCardsCmd=导入牌张
 lblCreateNewCmd=新建套牌
 lblErrNotAllowedCard=系列{0}不被允许
@@ -2852,7 +2851,6 @@ lblWarnLimitedCard={0}中的{1}
 lblErrCardEditionDate=不符合上市日期选项
 lblErrUnsupportedCard={0}不被允许
 lblWarnUnknownCardMsg=未知的牌张或未被forge支持的牌张
-lblWarnNotInInventory=Card not found in inventory
 lblWarnTooManyCommanders=现在{0}部分包含{1}张潜在的指挥官牌张: {2}
 lblWarnCommandersInSideExtra=如果确实是指挥官，请进行进行检查并将其中的一张移动到指挥官区。
 lblWarnDeckSectionNotAllowedInEditor={0}部分中的{1}不被允许
@@ -2930,7 +2928,6 @@ lblCardImportWarning=\n警告：套牌{0}将被重命名为{1}。
 lblConfirmCreateNewDeck=你即将创建一个新套牌{0}。{1}\n\n你想要继续吗？\n\n 注意：请记得点击套牌编辑器中的\"保存按钮\"以\
   将新建的套牌保存到目录中！
 lblNewDeckWarning=\n警告：对于当前套牌{0}的任何未保存更改丢将被丢弃。
-lblConfirmReplaceDeck=This will replace the contents of the current deck ({0}) with the imported cards.\n\nWould you like to proceed?
 lblImportCardsDialogTitle=将牌张导入到当前套牌
 lblNewDeckDialogTitle=创建一个新套牌
 #FNetOverlay.java

forge-gui/res/puzzle/PS_EOE3.pzl

@@ -1,16 +0,0 @@
-[metadata]
-Name:Possibility Storm - Edge of Eternities #03
-URL:https://www.cardforge.org
-Goal:Win
-Turns:1
-Difficulty:Rare
-Description:Win this turn. Your opponent has 10000 life! Deal at least that much damage this turn to win. Ensure your solution satisfies all possible blocks. Good luck!
-[state]
-turn=1
-activeplayer=p0
-activephase=MAIN1
-p0life=-1
-p0hand=Welcome the Darkness;Bloodthirsty Conqueror;Vayne's Treachery;Syr Vondam, Sunstar Exemplar
-p0battlefield=Herald of Eternal Dawn;Jumbo Cactuar;The Masamune;Enduring Tenacity;Plains;Plains;Plains;Swamp;Swamp;Swamp;Forest;Forest
-p1life=10000
-p1battlefield=Zidane, Tantalus Thief;Absolute Virtue|Id:1;Pain for All|AttachedTo:1

forge-gui/src/main/java/forge/deck/DeckImportController.java

@@ -13,25 +13,15 @@ import forge.gui.util.SOptionPane;
 import forge.item.PaperCard;
 import forge.localinstance.properties.ForgePreferences;
 import forge.model.FModel;
-import forge.util.ItemPool;
 import forge.util.Localizer;
-import forge.util.StreamUtil;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.tuple.Pair;
 
 import java.text.DateFormatSymbols;
 import java.util.*;
-import java.util.function.Function;
-import java.util.stream.Collectors;
 
 public class DeckImportController {
-    public enum ImportBehavior {
+    private boolean createNewDeck;
-        MERGE,
-        CREATE_NEW,
-        REPLACE_CURRENT
-    }
-
-    private ImportBehavior importBehavior;
     // Date filter
     private final ICheckBox dateTimeCheck;
     private final IComboBox<String> monthDropdown;
@@ -40,7 +30,7 @@ public class DeckImportController {
     private CardDb.CardArtPreference artPreference;
     private boolean smartCardArt;
     // Block Preference Filter
-    private boolean includeBnRInDeck = false;
+    private boolean inlcludeBnRInDeck = false;
 
     private final List<Token> tokens = new ArrayList<>();
     private final Map<PaperCard, Token> cardsInTokens = new HashMap<>();
@@ -48,14 +38,7 @@ public class DeckImportController {
     private Deck currentDeckInEditor = null;
     private DeckFormat currentDeckFormat;
     private GameFormat currentGameFormat;
-    private GameType currentGameType;
     private final List<DeckSection> allowedSections = new ArrayList<>();
-    private ItemPool<PaperCard> playerInventory;
-    /**
-     * If a free card is missing from a player's inventory (e.g. a basic land), it gets run through this function, which
-     * can handle creation of a usable print.
-     */
-    private Function<PaperCard, PaperCard> freePrintSupplier;
 
     public DeckImportController(ICheckBox dateTimeCheck0,
                                 IComboBox<String> monthDropdown0, IComboBox<Integer> yearDropdown0,
@@ -71,14 +54,13 @@ public class DeckImportController {
          */
         this.currentDeckNotEmpty = currentDeckNotEmpty;
         // this option will control the "new deck" action controlled by UI widget
-        this.importBehavior = ImportBehavior.MERGE;
+        createNewDeck = false;
 
         // Init default parameters
         this.artPreference = StaticData.instance().getCardArtPreference();  // default
         this.smartCardArt = StaticData.instance().isEnabledCardArtSmartSelection();
         this.currentDeckFormat = null;
         this.currentGameFormat = null;
-        this.currentGameType = null;
         fillDateDropdowns();
     }
 
@@ -86,23 +68,13 @@ public class DeckImportController {
         if (gameType == null){
             this.currentGameFormat = null;
             this.currentDeckFormat = null;
-            this.currentGameType = null;
         } else {
             // get the game format with the same name of current game type (if any)
             this.currentDeckFormat = gameType.getDeckFormat();
             this.currentGameFormat = FModel.getFormats().get(gameType.name());
-            this.currentGameType = gameType;
         }
     }
 
-    public void setPlayerInventory(ItemPool<PaperCard> inventory) {
-        this.playerInventory = inventory;
-    }
-
-    public void setFreePrintConverter(Function<PaperCard, PaperCard> freePrintSupplier) {
-        this.freePrintSupplier = freePrintSupplier;
-    }
-
     public void setCurrentDeckInEditor(Deck deckInEditor){
         this.currentDeckInEditor = deckInEditor;
     }
@@ -133,13 +105,11 @@ public class DeckImportController {
         return this.smartCardArt;
     }
 
-    public void setImportBehavior(ImportBehavior importBehavior) {
+    public void setCreateNewDeck(boolean createNewDeck){
-        this.importBehavior = importBehavior;
+        this.createNewDeck = createNewDeck;
     }
 
-    public ImportBehavior getImportBehavior() {
+    public boolean getCreateNewDeck() { return this.createNewDeck; }
-        return importBehavior;
-    }
 
     private void fillDateDropdowns() {
         DateFormatSymbols dfs = new DateFormatSymbols();
@@ -189,10 +159,10 @@ public class DeckImportController {
     }
 
     public void importBannedAndRestrictedCards(boolean includeBannedAndRestricted){
-        this.includeBnRInDeck = includeBannedAndRestricted;
+        this.inlcludeBnRInDeck = includeBannedAndRestricted;
     }
 
-    public boolean importBannedAndRestrictedCards(){ return this.includeBnRInDeck; }
+    public boolean importBannedAndRestrictedCards(){ return this.inlcludeBnRInDeck; }
 
     public List<Token> parseInput(String input) {
         tokens.clear();
@@ -216,7 +186,7 @@ public class DeckImportController {
         if (!this.allowedSections.isEmpty())
             recognizer.setAllowedDeckSections(this.allowedSections);
         // Banned and Restricted Card Policy
-        if (this.includeBnRInDeck)
+        if (this.inlcludeBnRInDeck)
             recognizer.forceImportBannedAndRestrictedCards();
 
         String[] lines = input.split("\n");
@@ -226,13 +196,8 @@ public class DeckImportController {
 
         if (this.currentGameFormatAllowsCommander()) {
             List<Pair<Integer, Token>> commanderTokens = getTokensInSection(DeckSection.Commander);
-            if (commanderTokens.isEmpty()) {
+            if (commanderTokens.isEmpty())  // Check commanders in Sideboard only if the commander section is empty
-                // Check commanders in Sideboard only if the commander section is empty
-                if(!getTokensInSection(DeckSection.Sideboard).isEmpty())
                 checkAndFixCommanderIn(DeckSection.Sideboard);
-                else
-                    checkAndFixCommanderIn(DeckSection.Main);
-            }
             checkAndFixCommanderIn(DeckSection.Commander);
         }
 
@@ -344,7 +309,7 @@ public class DeckImportController {
     }
 
     public boolean currentGameFormatAllowsCommander(){
-        return this.allowedSections.contains(DeckSection.Commander) || this.currentGameType == GameType.PlanarConquest;
+        return this.allowedSections.contains(DeckSection.Commander);
     }
 
     public List<Token> optimiseCardArtInTokens(){
@@ -367,7 +332,12 @@ public class DeckImportController {
             else
                 refTokenMap = tokensPerSectionWithSet;
 
-            List<Token> tokensInSection = refTokenMap.computeIfAbsent(tokenSection, e -> new ArrayList<>());
+            List<Token> tokensInSection = refTokenMap.getOrDefault(tokenSection, null);
+            if (tokensInSection == null) {
+                tokensInSection = new ArrayList<>();
+                tokensInSection.add(token);
+                refTokenMap.put(tokenSection, tokensInSection);
+            } else
                 tokensInSection.add(token);
         }
 
@@ -386,7 +356,7 @@ public class DeckImportController {
 
         Map<DeckSection, CardPool> referencePoolPerSection = new HashMap<>();
 
-        if (this.currentDeckNotEmpty && this.importBehavior == ImportBehavior.MERGE && this.currentDeckInEditor != null){
+        if (this.currentDeckNotEmpty && !this.createNewDeck && this.currentDeckInEditor != null){
             // We will always consider ONLY sections for cards needing art optimisation
             for (DeckSection section : tokensPerSectionWithNoSet.keySet()){
                 CardPool cardsInDeck = this.currentDeckInEditor.get(section);
@@ -466,102 +436,6 @@ public class DeckImportController {
         return tokens;
     }
 
-    public List<Token> constrainTokensToInventory() {
-        if(this.playerInventory == null)
-            return tokens;
-        CardPool availableInventory = new CardPool(this.playerInventory);
-        //Map of tokens to the things we're gonna replace them with.
-        Map<Token, List<Token>> tokenReplacers = new LinkedHashMap<>();
-        //If we're adding to our existing deck, ensure we aren't counting the cards already in it.
-        if(this.importBehavior == ImportBehavior.MERGE && this.currentDeckInEditor != null)
-            availableInventory.removeAll(this.currentDeckInEditor.getAllCardsInASinglePool(true, true));
-        if(this.currentGameType == GameType.PlanarConquest && currentDeckInEditor != null)
-            availableInventory.removeAllFlat(this.currentDeckInEditor.getCommanders());
-        //Step 1: For each token, if it's asking for more copies of a print than we can supply, split the difference out
-        //into a token that's indifferent to the edition. Reduce available inventory accordingly.
-        for (Token token : this.tokens) {
-            if (!token.isCardToken())
-                continue;
-            PaperCard card = token.getCard();
-            int requestedAmount = token.getQuantity();
-            if (card == null)
-                continue;
-            if (token.cardRequestHasNoCode()) {
-                List<Token> list = new ArrayList<>();
-                tokenReplacers.put(token, list);
-                continue;
-            }
-            int available = availableInventory.count(card);
-            if (available <= 0) {
-                List<Token> list = new ArrayList<>();
-                tokenReplacers.put(token, list);
-                continue;
-            }
-            int numTaken = Math.min(requestedAmount, available);
-            availableInventory.remove(card, numTaken);
-            if (available >= requestedAmount)
-                continue;
-
-            List<Token> list = new ArrayList<>();
-            list.add(Token.LegalCard(card, numTaken, token.getTokenSection(), true));
-            tokenReplacers.put(token, list);
-        }
-        if(tokenReplacers.isEmpty())
-            return tokens; //We have every card that was requested.
-        //Step 2: Try to find alternative prints for the ones that do not request an edition.
-        int capacity = tokens.size();
-        for(Map.Entry<Token, List<Token>> tokenReplacer : tokenReplacers.entrySet()) {
-            Token token = tokenReplacer.getKey();
-            DeckSection tokenSection = token.getTokenSection();
-            List<Token> replacementList = tokenReplacer.getValue();
-            PaperCard card = token.getCard();
-            String cardName = card.getName();
-            CardPool substitutes = availableInventory.getFilteredPool(c -> c.getName().equals(cardName));
-            // stream().toList() causes crash on Android 8-13, use Collectors.toList()
-            // ref: https://developer.android.com/reference/java/util/stream/Stream#toList()
-            List<Map.Entry<PaperCard, Integer>> sortedSubstitutes = StreamUtil.stream(substitutes).sorted(Comparator.comparingInt(Map.Entry::getValue)).collect(Collectors.toList());
-            int neededQuantity = token.getQuantity();
-            for(Token found : replacementList) {
-                //If there's an item in the replacement list already it means we've already found some of the needed copies.
-                neededQuantity -= found.getQuantity();
-            }
-            for(int i = 0; i < sortedSubstitutes.size() && neededQuantity > 0; i++) {
-                Map.Entry<PaperCard, Integer> item = sortedSubstitutes.get(i);
-                PaperCard replacement = item.getKey();
-                int toMove = Math.min(neededQuantity, item.getValue());
-                replacementList.add(Token.LegalCard(replacement, toMove, tokenSection, true));
-                availableInventory.remove(replacement, toMove);
-                neededQuantity -= toMove;
-                capacity++;
-            }
-            if(neededQuantity > 0) {
-                PaperCard freePrint = getInfiniteSupplyPrinting(card);
-                if(freePrint != null)
-                    replacementList.add(Token.NotInInventoryFree(freePrint, neededQuantity, tokenSection));
-                else
-                    replacementList.add(Token.NotInInventory(card, neededQuantity, tokenSection));
-                capacity++;
-            }
-        }
-        //Step 3: Apply the replacement list.
-        List<Token> newList = new ArrayList<>(capacity);
-        for(Token t : this.tokens) {
-            if(tokenReplacers.containsKey(t))
-                newList.addAll(tokenReplacers.get(t));
-            else
-                newList.add(t);
-        }
-        this.tokens.clear();
-        this.tokens.addAll(newList);
-        return tokens;
-    }
-
-    private PaperCard getInfiniteSupplyPrinting(PaperCard card) {
-        if(this.freePrintSupplier == null)
-            return null;
-        return freePrintSupplier.apply(card);
-    }
-
     private int countTokens(List<Token> tokensInSection){
         if (tokensInSection == null || tokensInSection.isEmpty())
             return 0;
@@ -613,31 +487,27 @@ public class DeckImportController {
         if (tokens.isEmpty()) { return null; }
 
         String deckName = "";
-        if (currentDeckName != null && !currentDeckName.trim().isEmpty())
+        if (currentDeckName != null && currentDeckName.trim().length() > 0)
             deckName = String.format("\"%s\"", currentDeckName.trim());
 
         String tokenDeckName = getTokenDeckNameIfAny();
-        if (!tokenDeckName.isEmpty())
+        if (tokenDeckName.length() > 0)
             tokenDeckName = String.format("\"%s\"", tokenDeckName);
 
-        if(this.currentDeckNotEmpty) {
+        if (createNewDeck){
-            final String warning;
+            String extraWarning = currentDeckNotEmpty ? localizer.getMessage("lblNewDeckWarning", deckName) : "";
-            final String title;
+            final String warning = localizer.getMessage("lblConfirmCreateNewDeck", tokenDeckName, extraWarning);
-            if (this.importBehavior == ImportBehavior.CREATE_NEW) {
+            if (!SOptionPane.showConfirmDialog(warning, localizer.getMessage("lblNewDeckDialogTitle"),
-                String extraWarning = localizer.getMessage("lblNewDeckWarning", deckName);
+                    localizer.getMessage("lblYes"), localizer.getMessage("lblNo"))) {
-                warning = localizer.getMessage("lblConfirmCreateNewDeck", tokenDeckName, extraWarning);
+                return null;
-                title = localizer.getMessage("lblNewDeckDialogTitle");
+            }
-            } else if (this.importBehavior == ImportBehavior.MERGE){
+        }
-                String extraWarning = (!tokenDeckName.isEmpty() && !tokenDeckName.equals(deckName)) ?
+        else if (this.currentDeckNotEmpty){
+            String extraWarning = (tokenDeckName.length() > 0 && !tokenDeckName.equals(deckName)) ?
                     localizer.getMessage("lblCardImportWarning", deckName, tokenDeckName) : "";
-                warning = localizer.getMessage("lblConfirmCardImport", deckName, extraWarning);
+            final String warning = localizer.getMessage("lblConfirmCardImport", deckName, extraWarning);
-                title = localizer.getMessage("lblImportCardsDialogTitle");
+            if (!SOptionPane.showConfirmDialog(warning,
-            }
+                    localizer.getMessage("lblImportCardsDialogTitle"),
-            else {
-                warning = localizer.getMessage("lblConfirmReplaceDeck", deckName);
-                title = localizer.getMessage("lblNewDeckDialogTitle");
-            }
-            if (!SOptionPane.showConfirmDialog(warning, title,
                     localizer.getMessage("lblYes"), localizer.getMessage("lblNo")))
                 return null;
         }
@@ -646,7 +516,7 @@ public class DeckImportController {
             final TokenType type = t.getType();
             // only Deck Name, legal card and limited card tokens will be analysed!
             if (!t.isTokenForDeck() ||
-                    (type == TokenType.LIMITED_CARD && !this.includeBnRInDeck))
+                    (type == TokenType.LIMITED_CARD && !this.inlcludeBnRInDeck))
                 continue;  // SKIP token
 
             if (type == TokenType.DECK_NAME) {
@@ -677,66 +547,4 @@ public class DeckImportController {
         }
         return "";  // no deck name
     }
-
-    public String getTokenMessage(DeckRecognizer.Token token) {
-        return switch (token.getType()) {
-            case LEGAL_CARD, LIMITED_CARD, CARD_FROM_NOT_ALLOWED_SET, CARD_FROM_INVALID_SET,
-                 CARD_NOT_IN_INVENTORY, FREE_CARD_NOT_IN_INVENTORY ->
-                    String.format("%s x %s %s", token.getQuantity(), token.getText(), getTokenFoilLabel(token));
-            // Card Warning Msgs
-            case UNKNOWN_CARD, UNSUPPORTED_CARD ->
-                    token.getQuantity() > 0 ? String.format("%s x %s", token.getQuantity(), token.getText())
-                            : token.getText();
-            case UNSUPPORTED_DECK_SECTION ->
-                    String.format("%s: %s", Localizer.getInstance().getMessage("lblWarningMsgPrefix"),
-                            Localizer.getInstance()
-                                    .getMessage("lblWarnDeckSectionNotAllowedInEditor", token.getText(),
-                                            this.currentGameType.name()));
-
-            // Special Case of Card moved into another section (e.g. Commander from Sideboard)
-            case WARNING_MESSAGE -> String.format("%s: %s", Localizer.getInstance()
-                    .getMessage("lblWarningMsgPrefix"), token.getText());
-
-            // Placeholders
-            case DECK_SECTION_NAME -> String.format("%s: %s", Localizer.getInstance().getMessage("lblDeckSection"),
-                    token.getText());
-            case CARD_RARITY -> String.format("%s: %s", Localizer.getInstance().getMessage("lblRarity"),
-                    token.getText());
-            case CARD_TYPE, CARD_CMC, MANA_COLOUR, COMMENT, UNKNOWN_TEXT -> token.getText();
-            case DECK_NAME -> String.format("%s: %s", Localizer.getInstance().getMessage("lblDeckName"),
-                    token.getText());
-        };
-    }
-
-    public String getTokenStatusMessage(DeckRecognizer.Token token) {
-        if (token == null)
-            return "";
-
-        final Localizer localizer = Localizer.getInstance();
-        return switch (token.getType()) {
-            case LIMITED_CARD -> String.format("%s: %s", localizer.getMessage("lblWarningMsgPrefix"),
-                    localizer.getMessage("lblWarnLimitedCard",
-                            StringUtils.capitalize(token.getLimitedCardType().name()), getGameFormatLabel()));
-            case CARD_FROM_NOT_ALLOWED_SET ->
-                    localizer.getMessage("lblErrNotAllowedCard", getGameFormatLabel());
-            case CARD_FROM_INVALID_SET -> localizer.getMessage("lblErrCardEditionDate");
-            case UNSUPPORTED_CARD -> localizer.getMessage("lblErrUnsupportedCard", this.currentGameType);
-            case UNKNOWN_CARD -> String.format("%s: %s", localizer.getMessage("lblWarningMsgPrefix"),
-                    localizer.getMessage("lblWarnUnknownCardMsg"));
-            case CARD_NOT_IN_INVENTORY -> localizer.getMessage("lblWarnNotInInventory");
-            default -> "";
-        };
-    }
-
-
-    private String getTokenFoilLabel(DeckRecognizer.Token token) {
-        if (!token.isCardToken())
-            return "";
-        final String foilMarker = "- (Foil)";
-        return token.getCard().isFoil() ? foilMarker : "";
-    }
-
-    private String getGameFormatLabel() {
-        return String.format("\"%s\"", this.getCurrentGameFormatName());
-    }
 }

forge-gui/src/main/java/forge/deck/DeckProxy.java

@@ -774,7 +774,7 @@ public class DeckProxy implements InventoryItem {
 
         for (PaperCard c : deck.getAllCardsInASinglePool().toFlatList()) {
             CardEdition edition = FModel.getMagicDb().getEditions().get(c.getEdition());
-            if (edition == null || !edition.hasBasicLands())
+            if (edition == null)
                 continue;
             availableEditions.add(edition);
         }

forge-gui/src/main/java/forge/gamemodes/limited/BoosterDraft.java

@@ -437,7 +437,7 @@ public class BoosterDraft implements IBoosterDraft {
                 CompletableFuture.allOf(futuresArray).join();
                 futures.clear();
             }
-            // stream().toList() causes crash on Android 8-13, use Collectors.toList()
+            // stream().toList() causes crash on Android, use Collectors.toList()
             customs.addAll(queue.stream().collect(Collectors.toList()));
         }
         return customs;

forge-gui/src/main/java/forge/gamemodes/planarconquest/ConquestData.java

@@ -18,11 +18,15 @@
 package forge.gamemodes.planarconquest;
 
 import java.io.File;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
 import java.util.Map.Entry;
 import java.util.function.Function;
-import java.util.function.Predicate;
-import java.util.stream.Collectors;
 
 import forge.card.CardDb;
 import forge.gamemodes.planarconquest.ConquestPreferences.CQPref;
@@ -195,11 +199,14 @@ public final class ConquestData {
     }
 
     public int getAccessiblePlaneCount() {
-        return (int) FModel.getPlanes().stream().filter(Predicate.not(ConquestPlane::isUnreachable)).count();
+        // TODO: Java 8 stream implementation of filtering
+        int i = 0;
+        for (ConquestPlane plane : FModel.getPlanes()) {
+            if (!plane.isUnreachable()) {
+                i++;
             }
-
+        }
-    public Set<ConquestPlane> getUnlockedPlanes() {
+        return i;
-        return planeDataMap.values().stream().map(ConquestPlaneData::getLocation).map(ConquestLocation::getPlane).collect(Collectors.toSet());
     }
 
     public void unlockPlane(ConquestPlane plane) {
@@ -295,7 +302,7 @@ public final class ConquestData {
                 }
             }
 
-            if (!commandersUsingCard.isEmpty()) {
+            if (commandersUsingCard.length() > 0) {
                 SOptionPane.showMessageDialog(Localizer.getInstance().getMessage("lblCommandersCardCannotBeExiledByCard", CardTranslation.getTranslatedName(card.getName()), commandersUsingCard), title, SOptionPane.INFORMATION_ICON);
                 return false;
             }

forge-gui/src/main/java/forge/gamemodes/planarconquest/ConquestPlane.java

@@ -50,7 +50,6 @@ public class ConquestPlane {
     private FCollection<PaperCard> commanders;
     private ConquestAwardPool awardPool;
     private ConquestEvent[] events;
-    private final Set<CardEdition> editions = new HashSet<>();
 
     private ConquestPlane(String name0, String description0, int regionSize0, boolean unreachable0) {
         name = name0;
@@ -154,10 +153,6 @@ public class ConquestPlane {
         return planeCards;
     }
 
-    public Set<CardEdition> getEditions() {
-        return editions;
-    }
-
     private void ensureRegionsLoaded() {
         if (regions != null) { return; }
 
@@ -198,8 +193,6 @@ public class ConquestPlane {
             if (edition == null)
                 continue;
 
-            editions.add(edition);
-
             for (EditionEntry card : edition.getObtainableCards()) {
                 if (bannedCardSet == null || !bannedCardSet.contains(card.name())) {
                     addCard(commonCards.getCard(card.name(), setCode));

forge-gui/src/main/java/forge/gamemodes/planarconquest/ConquestUtil.java

@@ -1,16 +1,22 @@
 package forge.gamemodes.planarconquest;
 
-import java.util.*;
+import java.util.EnumSet;
+import java.util.List;
+import java.util.Map;
 import java.util.Map.Entry;
+import java.util.Set;
 import java.util.function.Predicate;
-import java.util.stream.Collectors;
 
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
 
-import forge.card.*;
+import forge.card.CardRarity;
+import forge.card.CardRules;
+import forge.card.CardType;
 import forge.card.CardType.CoreType;
+import forge.card.ColorSet;
+import forge.card.MagicColor;
 import forge.card.mana.ManaCostShard;
 import forge.deck.CardPool;
 import forge.deck.Deck;
@@ -137,25 +143,6 @@ public class ConquestUtil {
         return pool;
     }
 
-    public static List<CardEdition> getBasicLandSets(Deck currentDeck) {
-        ConquestData model = FModel.getConquest().getModel();
-        List<ConquestPlane> planes = new ArrayList<>(model.getUnlockedPlanes());
-        ConquestPlane currentPlane = model.getCurrentPlane();
-        //Move the current plane to the front.
-        if(currentPlane != null && planes.contains(currentPlane)) {
-            planes.remove(currentPlane);
-            planes.add(0, currentPlane);
-        }
-        //Move editions of cards already in the deck to the front.
-        Map<CardEdition, Integer> editionStats = currentDeck.getAllCardsInASinglePool().getCardEditionStatistics(true);
-        List<CardEdition> out = planes.stream()
-                .<CardEdition>mapMulti((p, c) -> p.getEditions().forEach(c))
-                .filter(CardEdition::hasBasicLands)
-                .sorted(Comparator.comparing(e -> editionStats.getOrDefault(e, 0)))
-                .collect(Collectors.toList());
-        return out;
-    }
-
     public static ConquestPlane getPlaneByName(String planeName) {
         for (ConquestPlane plane : FModel.getPlanes()) {
             if (plane.getName().equals(planeName)) {
@@ -202,16 +189,19 @@ public class ConquestUtil {
     public static int getShardValue(CardRarity rarity, CQPref baseValuePref) {
         ConquestPreferences prefs = FModel.getConquestPreferences();
         int baseValue = prefs.getPrefInt(baseValuePref);
-        return switch (rarity) {
+        switch (rarity) {
-            case Common -> baseValue;
+        case Common:
-            case Uncommon ->
+            return baseValue;
-                    Math.round((float) baseValue * (float) prefs.getPrefInt(CQPref.AETHER_UNCOMMON_MULTIPLIER));
+        case Uncommon:
-            case Rare, Special ->
+            return Math.round((float)baseValue * (float)prefs.getPrefInt(CQPref.AETHER_UNCOMMON_MULTIPLIER));
-                    Math.round((float) baseValue * (float) prefs.getPrefInt(CQPref.AETHER_RARE_MULTIPLIER));
+        case Rare:
-            case MythicRare ->
+        case Special:
-                    Math.round((float) baseValue * (float) prefs.getPrefInt(CQPref.AETHER_MYTHIC_MULTIPLIER));
+            return Math.round((float)baseValue * (float)prefs.getPrefInt(CQPref.AETHER_RARE_MULTIPLIER));
-            default -> 0;
+        case MythicRare:
-        };
+            return Math.round((float)baseValue * (float)prefs.getPrefInt(CQPref.AETHER_MYTHIC_MULTIPLIER));
+        default:
+            return 0;
+        }
     }
 
     public enum AEtherFilter implements IHasSkinProp {

forge-gui/src/main/java/forge/gamemodes/quest/QuestController.java

@@ -19,7 +19,6 @@ package forge.gamemodes.quest;
 
 import java.io.File;
 import java.util.*;
-import java.util.stream.Collectors;
 
 import com.google.common.collect.Lists;
 import com.google.common.eventbus.Subscribe;
@@ -621,21 +620,17 @@ public class QuestController {
     }
 
     public CardEdition getDefaultLandSet() {
-        List<CardEdition> availableEditions = getAvailableLandSets();
+        List<String> availableEditionCodes = questFormat != null ? questFormat.getAllowedSetCodes() : Lists.newArrayList(FModel.getMagicDb().getEditions().getItemNames());
+        List<CardEdition> availableEditions = new ArrayList<>();
+
+        for (String s : availableEditionCodes) {
+            availableEditions.add(FModel.getMagicDb().getEditions().get(s));
+        }
 
         CardEdition randomLandSet = CardEdition.Predicates.getRandomSetWithAllBasicLands(availableEditions);
         return randomLandSet == null ? FModel.getMagicDb().getEditions().get("ZEN") : randomLandSet;
     }
 
-    public List<CardEdition> getAvailableLandSets() {
-        List<String> availableEditionCodes = questFormat != null ? questFormat.getAllowedSetCodes() : Lists.newArrayList(FModel.getMagicDb().getEditions().getItemNames());
-        CardEdition.Collection editions = FModel.getMagicDb().getEditions();
-        return availableEditionCodes.stream()
-                .map(editions::get)
-                .filter(CardEdition::hasBasicLands)
-                .collect(Collectors.toList());
-    }
-
     public String getCurrentDeck() {
         return model.currentDeck;
     }

forge-gui/src/main/java/forge/itemmanager/AdvancedSearch.java

@@ -57,7 +57,6 @@ public class AdvancedSearch {
             protected String getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<String> getItemValues(PaperCard input) {
                 Set<String> names = new HashSet<>();
@@ -78,7 +77,6 @@ public class AdvancedSearch {
             protected String getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<String> getItemValues(PaperCard input) {
                 Set<String> names = new HashSet<>();
@@ -100,9 +98,20 @@ public class AdvancedSearch {
             protected Keyword getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<Keyword> getItemValues(PaperCard input) {
+                CardSplitType cardSplitType = input.getRules().getSplitType();
+                if (cardSplitType != CardSplitType.None && cardSplitType != CardSplitType.Split) {
+                    Set<Keyword> keywords = new HashSet<>();
+                    if (input.getRules().getOtherPart() != null) {
+                        PaperCard otherPart = FModel.getMagicDb().getCommonCards().getCard(input.getRules().getOtherPart().getName());
+                        if (otherPart != null) {
+                            keywords.addAll(Keyword.getKeywordSet(otherPart));
+                            keywords.addAll(Keyword.getKeywordSet(input));
+                        }
+                    }
+                    return keywords;
+                }
                 return Keyword.getKeywordSet(input);
             }
         }),
@@ -117,7 +126,6 @@ public class AdvancedSearch {
             protected GameFormat getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<GameFormat> getItemValues(PaperCard input) {
                 return FModel.getFormats().getAllFormatsOfCard(input);
@@ -128,7 +136,6 @@ public class AdvancedSearch {
             protected ConquestPlane getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<ConquestPlane> getItemValues(PaperCard input) {
                 return ConquestPlane.getAllPlanesOfCard(input);
@@ -139,7 +146,6 @@ public class AdvancedSearch {
             protected ConquestRegion getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<ConquestRegion> getItemValues(PaperCard input) {
                 return ConquestRegion.getAllRegionsOfCard(input);
@@ -150,7 +156,6 @@ public class AdvancedSearch {
             protected QuestWorld getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<QuestWorld> getItemValues(PaperCard input) {
                 return QuestWorld.getAllQuestWorldsOfCard(input);
@@ -161,7 +166,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(PaperCard input) {
                 return input.getRules().getColor().toEnumSet();
@@ -172,7 +176,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(PaperCard input) {
                 return input.getRules().getColorIdentity().toEnumSet();
@@ -189,7 +192,6 @@ public class AdvancedSearch {
             protected String getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<String> getItemValues(PaperCard input) {
                 final CardType type = input.getRules().getType();
@@ -226,7 +228,6 @@ public class AdvancedSearch {
             protected String getItemValue(PaperCard input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<String> getItemValues(PaperCard input) {
                 CardSplitType cardSplitType = input.getRules().getSplitType();
@@ -293,9 +294,7 @@ public class AdvancedSearch {
             @Override
             protected Boolean getItemValue(PaperCard input) {
                 List<PaperCard> cards = FModel.getMagicDb().getCommonCards().getAllCards(input.getName());
-                if (cards.size() <= 1) {
+                if (cards.size() <= 1) { return true; }
-                    return true;
-                }
 
                 cards.sort(FModel.getMagicDb().getEditions().CARD_EDITION_COMPARATOR);
                 return cards.get(0) == input;
@@ -327,7 +326,6 @@ public class AdvancedSearch {
             protected Keyword getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<Keyword> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -354,7 +352,6 @@ public class AdvancedSearch {
             protected GameFormat getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<GameFormat> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -368,7 +365,6 @@ public class AdvancedSearch {
             protected ConquestPlane getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<ConquestPlane> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -382,7 +378,6 @@ public class AdvancedSearch {
             protected ConquestRegion getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<ConquestRegion> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -396,7 +391,6 @@ public class AdvancedSearch {
             protected QuestWorld getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<QuestWorld> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -410,7 +404,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -424,7 +417,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -447,7 +439,6 @@ public class AdvancedSearch {
             protected String getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<String> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -469,7 +460,6 @@ public class AdvancedSearch {
             protected String getItemValue(InventoryItem input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<String> getItemValues(InventoryItem input) {
                 if (!(input instanceof PaperCard)) {
@@ -535,9 +525,7 @@ public class AdvancedSearch {
             @Override
             protected Boolean getItemValue(InventoryItem input) {
                 List<PaperCard> cards = FModel.getMagicDb().getCommonCards().getAllCards(input.getName());
-                if (cards.size() <= 1) {
+                if (cards.size() <= 1) { return true; }
-                    return true;
-                }
 
                 cards.sort(FModel.getMagicDb().getEditions().CARD_EDITION_COMPARATOR);
                 return cards.get(0) == input;
@@ -593,7 +581,6 @@ public class AdvancedSearch {
             protected GameFormat getItemValue(DeckProxy input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<GameFormat> getItemValues(DeckProxy input) {
                 return input.getExhaustiveFormats();
@@ -604,7 +591,6 @@ public class AdvancedSearch {
             protected QuestWorld getItemValue(DeckProxy input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<QuestWorld> getItemValues(DeckProxy input) {
                 return QuestWorld.getAllQuestWorldsOfDeck(input.getDeck());
@@ -615,7 +601,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(DeckProxy input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(DeckProxy input) {
                 return input.getColor().toEnumSet();
@@ -626,7 +611,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(DeckProxy input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(DeckProxy input) {
                 return input.getColorIdentity().toEnumSet();
@@ -689,7 +673,6 @@ public class AdvancedSearch {
             protected MagicColor.Color getItemValue(ConquestCommander input) {
                 throw new RuntimeException("getItemValues should be called instead");
             }
-
             @Override
             protected Set<MagicColor.Color> getItemValues(ConquestCommander input) {
                 return input.getCard().getRules().getColorIdentity().toEnumSet();
@@ -842,7 +825,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<String> inputs, List<String> values) {
                 if (inputs != null && !inputs.isEmpty() && !values.isEmpty()) {
@@ -864,7 +846,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<String> inputs, List<String> values) {
                 if (inputs != null && !inputs.isEmpty() && !values.isEmpty()) {
@@ -886,7 +867,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<String> inputs, List<String> values) {
                 if (inputs != null && !inputs.isEmpty() && !values.isEmpty()) {
@@ -910,7 +890,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<Object> inputs, List<Object> values) {
                 if (inputs != null && inputs.size() == values.size()) {
@@ -936,7 +915,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<Object> inputs, List<Object> values) {
                 if (inputs != null) {
@@ -961,7 +939,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<Object> inputs, List<Object> values) {
                 if (inputs != null) {
@@ -982,7 +959,6 @@ public class AdvancedSearch {
                 }
                 return false;
             }
-
             @Override
             public boolean apply(Set<Object> inputs, List<Object> values) {
                 if (inputs != null) {
@@ -1001,7 +977,6 @@ public class AdvancedSearch {
             public boolean apply(Object input, List<Object> values) {
                 throw new RuntimeException("shouldn't be called with a single input");
             }
-
             @Override
             public boolean apply(Set<Object> inputs, List<Object> values) {
                 if (inputs != null) {
@@ -1019,7 +994,6 @@ public class AdvancedSearch {
             public boolean apply(Object input, List<Object> values) {
                 throw new RuntimeException("shouldn't be called with a single input");
             }
-
             @Override
             public boolean apply(Set<Object> inputs, List<Object> values) {
                 if (inputs != null) {
@@ -1151,7 +1125,8 @@ public class AdvancedSearch {
             final List<V> values;
             try {
                 values = getValuesFromString(initialValueText, option, operator);
-            } catch (Exception e) {
+            }
+            catch(Exception e) {
                 e.printStackTrace();
                 return null;
             }
@@ -1159,11 +1134,8 @@ public class AdvancedSearch {
         }
 
         protected abstract List<V> getValues(FilterOption option, FilterOperator operator);
-
         protected abstract List<V> getValuesFromString(String valueText, FilterOption option, FilterOperator operator);
-
         protected abstract String getCaption(List<V> values, FilterOption option, FilterOperator operator);
-
         protected abstract V getItemValue(T input);
 
         protected Set<V> getItemValues(T input) { //available for options that have multiple inputs
@@ -1206,13 +1178,12 @@ public class AdvancedSearch {
             String message;
             if (operator.valueCount == FilterValueCount.ONE) {
                 message = option.name + " " + operator.caption + " ?";
-            } else {
+            }
+            else {
                 message = "? " + operator.caption.replace("|", " " + option.name + " ");
             }
             Integer lowerBound = SGuiChoose.getInteger(message, min, max);
-            if (lowerBound == null) {
+            if (lowerBound == null) { return null; }
-                return null;
-            }
 
             final List<Integer> values = new ArrayList<>();
             values.add(lowerBound);
@@ -1224,9 +1195,7 @@ public class AdvancedSearch {
                     upperBoundMin += 2; //if exclusive, ensure it's possible to have numbers in between
                 }
                 Integer upperBound = SGuiChoose.getInteger(message, upperBoundMin, max);
-                if (upperBound == null) {
+                if (upperBound == null) { return null; }
-                    return null;
-                }
 
                 values.add(upperBound);
             }
@@ -1257,9 +1226,7 @@ public class AdvancedSearch {
         protected List<String> getValues(FilterOption option, FilterOperator operator) {
             String message = option.name + " " + operator.caption + " ?";
             String value = SOptionPane.showInputDialog("", message, null, initialInput);
-            if (value == null) {
+            if (value == null) { return null; }
-                return null;
-            }
 
             initialInput = value; //store value as initial input for next time
 
@@ -1286,11 +1253,9 @@ public class AdvancedSearch {
         public CustomListEvaluator(Collection<V> choices0) {
             this(choices0, null, null);
         }
-
         public CustomListEvaluator(Collection<V> choices0, Function<V, String> toShortString0) {
             this(choices0, toShortString0, null);
         }
-
         public CustomListEvaluator(Collection<V> choices0, Function<V, String> toShortString0, Function<V, String> toLongString0) {
             choices = choices0;
             toShortString = toShortString0;
@@ -1385,16 +1350,12 @@ public class AdvancedSearch {
         protected List<Map<String, Integer>> getValues(FilterOption option, FilterOperator operator) {
             String message = option.name + " " + operator.caption + " ?";
             PaperCard card = SGuiChoose.oneOrNone(message, FModel.getMagicDb().getCommonCards().getUniqueCards());
-            if (card == null) {
+            if (card == null) { return null; }
-                return null;
-            }
 
             Integer amount = -1;
             if (operator == FilterOperator.CONTAINS_X_COPIES_OF_CARD) { //prompt for quantity if needed
                 amount = SGuiChoose.getInteger(Localizer.getInstance().getMessage("lblHowManyCopiesOfN", CardTranslation.getTranslatedName(card.getName())), 0, 4);
-                if (amount == null) {
+                if (amount == null) { return null; }
-                    return null;
-                }
             }
 
             Map<String, Integer> map = new HashMap<>();
@@ -1414,7 +1375,8 @@ public class AdvancedSearch {
                 String[] split = valueText.split(" ", 2);
                 amount = Integer.parseInt(split[0]);
                 cardName = split[1];
-            } else
+            }
+            else
                 cardName = valueText;
             Map<String, Integer> map = new HashMap<>();
             map.put(cardName, amount);
@@ -1450,25 +1412,21 @@ public class AdvancedSearch {
                 }
             }
             option = SGuiChoose.oneOrNone(Localizer.getInstance().getMessage("lblSelectAFilterType"), options, defaultOption, null);
-            if (option == null) {
+            if (option == null) { return editFilter; }
-                return editFilter;
         }
-        } else {
+        else {
             option = defaultOption;
         }
 
-        if (option == FilterOption.NONE) {
+        if (option == FilterOption.NONE) { return null; } //allow user to clear filter by selecting "(none)"
-            return null;
-        } //allow user to clear filter by selecting "(none)"
 
         final FilterOperator operator;
         if (option.operatorOptions.length > 1) {
             final FilterOperator defaultOperator = option == defaultOption ? editFilter.operator : null;
             operator = SGuiChoose.oneOrNone(Localizer.getInstance().getMessage("lblSelectOperatorFor", option.name), option.operatorOptions, defaultOperator, null);
-            if (operator == null) {
+            if (operator == null) { return editFilter; }
-                return editFilter;
         }
-        } else {
+        else {
             operator = option.operatorOptions[0];
         }
 
@@ -1482,7 +1440,8 @@ public class AdvancedSearch {
     @SuppressWarnings("unchecked")
     public static <T extends InventoryItem> Filter<T> getFilter(Class<? super T> type, String filterText) {
         String[] words = filterText.split(" ", 3);
-        if (words.length < 2) {
+        if(words.length < 2)
+        {
             System.out.printf("Unable to generate filter from expression '%s'%n", filterText);
             return null;
         }
@@ -1495,7 +1454,8 @@ public class AdvancedSearch {
             System.out.printf("Unable to generate filter from FilterOption '%s'%n", words[0]);
             return null;
         }
-        if (option.type != type) {
+        if(option.type != type)
+        {
             System.out.printf("Unable to generate filter from FilterOption '%s' - filter type '%s' != option type '%s' %n", words[0], type, option.type);
             return null;
         }
@@ -1555,23 +1515,14 @@ public class AdvancedSearch {
 
     public interface IFilterControl<T extends InventoryItem> {
         IButton getBtnNotBeforeParen();
-
         IButton getBtnOpenParen();
-
         IButton getBtnNotAfterParen();
-
         IButton getBtnFilter();
-
         IButton getBtnCloseParen();
-
         IButton getBtnAnd();
-
         IButton getBtnOr();
-
         Filter<T> getFilter();
-
         void setFilter(Filter<T> filter0);
-
         Class<? super T> getGenericType();
     }
 
@@ -1603,18 +1554,23 @@ public class AdvancedSearch {
                 Object piece = iterator.get();
                 if (piece.equals(Operator.OPEN_PAREN)) {
                     predPiece = getPredicatePiece(iterator.next());
-                } else if (piece.equals(Operator.CLOSE_PAREN)) {
+                }
+                else if (piece.equals(Operator.CLOSE_PAREN)) {
                     return pred;
-                } else if (piece.equals(Operator.AND)) {
+                }
+                else if (piece.equals(Operator.AND)) {
                     operator = Operator.AND;
                     continue;
-                } else if (piece.equals(Operator.OR)) {
+                }
+                else if (piece.equals(Operator.OR)) {
                     operator = Operator.OR;
                     continue;
-                } else if (piece.equals(Operator.NOT)) {
+                }
+                else if (piece.equals(Operator.NOT)) {
                     applyNot = !applyNot;
                     continue;
-                } else {
+                }
+                else {
                     predPiece = ((AdvancedSearch.Filter<T>) piece).getPredicate();
                 }
                 if (applyNot) {
@@ -1623,9 +1579,11 @@ public class AdvancedSearch {
                 }
                 if (pred == null) {
                     pred = predPiece;
-                } else if (operator == Operator.AND) {
+                }
+                else if (operator == Operator.AND) {
                     pred = pred.and(predPiece);
-                } else if (operator == Operator.OR) {
+                }
+                else if (operator == Operator.OR) {
                     pred = pred.or(predPiece);
                 }
                 operator = null;
@@ -1668,7 +1626,16 @@ public class AdvancedSearch {
                         control.setFilter(filter);
                         if (filter != null) {
                             control.getBtnFilter().setText(GuiBase.getInterface().encodeSymbols(filter.toString(), false));
-                        } else {
+
+                            if (filter.getOption() == FilterOption.CARD_KEYWORDS) {
+                                //the first time the user selects keywords, preload keywords for all cards
+                                Runnable preloadTask = Keyword.getPreloadTask();
+                                if (preloadTask != null) {
+                                    GuiBase.getInterface().runBackgroundTask(Localizer.getInstance().getMessage("lblLoadingKeywords"), preloadTask);
+                                }
+                            }
+                        }
+                        else {
                             control.getBtnFilter().setText(EMPTY_FILTER_TEXT);
                         }
                         if (onChange != null) {
@@ -1690,15 +1657,14 @@ public class AdvancedSearch {
 
         @SuppressWarnings("unchecked")
         public void updateLabel() {
-            if (label == null) {
+            if (label == null) { return; }
-                return;
-            }
 
             StringBuilder builder = new StringBuilder();
             builder.append("Filter: ");
             if (expression.isEmpty()) {
                 builder.append("(none)");
-            } else {
+            }
+            else {
                 int prevFilterEndIdx = -1;
                 AdvancedSearch.Filter<T> filter, prevFilter = null;
                 for (Object piece : expression) {
@@ -1709,12 +1675,14 @@ public class AdvancedSearch {
                             builder.replace(prevFilterEndIdx, builder.length(), builder.substring(prevFilterEndIdx).toLowerCase());
                             //append only values for filter
                             builder.append(filter.extractValuesFromCaption());
-                        } else {
+                        }
+                        else {
                             builder.append(filter);
                         }
                         prevFilter = filter;
                         prevFilterEndIdx = builder.length();
-                    } else {
+                    }
+                    else {
                         if (piece.equals(Operator.OPEN_PAREN) || piece.equals(Operator.CLOSE_PAREN)) {
                             prevFilter = null; //prevent merging filters with parentheses in between
                         }
@@ -1727,9 +1695,7 @@ public class AdvancedSearch {
         }
 
         public String getTooltip() {
-            if (expression.isEmpty()) {
+            if (expression.isEmpty()) { return ""; }
-                return "";
-            }
 
             StringBuilder builder = new StringBuilder();
             builder.append("Filter:\n");
@@ -1752,9 +1718,7 @@ public class AdvancedSearch {
             expression.clear();
 
             for (IFilterControl<T> control : controls) {
-                if (control.getFilter() == null) {
+                if (control.getFilter() == null) { continue; } //skip any blank filters
-                    continue;
-                } //skip any blank filters
 
                 if (control.getBtnNotBeforeParen().isSelected()) {
                     expression.add(Operator.NOT);
@@ -1773,7 +1737,8 @@ public class AdvancedSearch {
                 }
                 if (control.getBtnAnd().isSelected()) {
                     expression.add(Operator.AND);
-                } else if (control.getBtnOr().isSelected()) {
+                }
+                else if (control.getBtnOr().isSelected()) {
                     expression.add(Operator.OR);
                 }
             }
@@ -1783,16 +1748,13 @@ public class AdvancedSearch {
 
         private class ExpressionIterator {
             private int index;
-
             private boolean hasNext() {
                 return index < expression.size();
             }
-
             private ExpressionIterator next() {
                 index++;
                 return this;
             }
-
             private Object get() {
                 return expression.get(index);
             }

forge-gui/src/main/java/forge/itemmanager/SFilterUtil.java

@@ -217,8 +217,7 @@ public class SFilterUtil {
             }
             entry.append(ch);
         }
-        // Android API StringBuilder isEmpty() is unavailable. https://developer.android.com/reference/java/lang/StringBuilder
+       if (entry.length() != 0) { // Android API isEmpty() is unavailable. https://developer.android.com/reference/java/lang/StringBuilder
-       if (entry.length() != 0) {
             splitText.add(entry.toString());
         }
         return splitText;

forge-gui/tools/RankingScraper.py

@@ -3,7 +3,7 @@ import json
 import requests
 
 
-def draftsimRankings(edition='SPM', extra=None):
+def draftsimRankings(edition='FIN', extra=None):
 	edition = edition.upper()
 	url1 = 'https://draftsim.com/generated/%s/' % (edition)
 	url2 = '%s' % edition