Commit Graph

2908 Commits

Author SHA1 Message Date
Agetian
3d2289d3ba - Removed a line that was never used (in CardFactory). 2017-02-06 16:39:38 +00:00
Hanmac
aa6504c966 CardFactoryUtil: fixed Renown Trigger 2017-02-05 12:48:35 +00:00
Agetian
8e91a396d9 - Using the copyState method of copying over card states. 2017-02-05 12:41:25 +00:00
Agetian
a45335791d - Committing a temporary version of getLKICopy that does not break visuals of many cards in many different circumstances (may need further improvement). 2017-02-05 12:37:49 +00:00
Hanmac
603b803b04 CardUtil: getLKICopy should not update the View 2017-02-05 10:11:33 +00:00
Hanmac
a0a053246b ChangeZoneEffect: make it work if no Origin is used (because it does have multiple)
ChangeZoneAi: some more tweaks and make above change possible
2017-02-04 17:14:00 +00:00
Hanmac
b31d270111 CardUtil: LKI should not update the view 2017-02-04 09:01:05 +00:00
Hanmac
b9421739f8 TokenEffect: fixed order when Token get its abilities to fix Evolve Trigger 2017-02-04 08:42:21 +00:00
Agetian
d429906bcd - Somewhat cleaner fix related to the previous commit. 2017-02-04 07:29:32 +00:00
Agetian
d57c1be193 - Fixed a logic error in LANDS_PRODUCING_MANA card predicate. 2017-02-04 07:27:23 +00:00
Hanmac
31d2148d37 CardUtil: LKICopy: copy all States, not just the current one. needed to get the CMC of a Transformed card right 2017-02-04 06:18:28 +00:00
Hanmac
673d455703 GameAction: clearETBCounters if it does enter the battlefield or not 2017-02-02 18:46:28 +00:00
Agetian
6df567e07d - Reverted the previous change, committed a correct fix for description generation for Sidar Kondo of Jamuraa. 2017-02-02 14:45:11 +00:00
Agetian
4b0fb9ef57 - Fixed description generation for CantBlock. 2017-02-02 14:31:16 +00:00
Agetian
1a96eb8a96 - Fixed Bloodthirst hard-crashing Forge (and updated Bloodthirst cards to account for the change, consistent with other similar parametric keywords). 2017-02-02 08:18:41 +00:00
Hanmac
faa1e000df Card: add EtbCounter functions: that does handle ETB counter effects with Replacements better 2017-02-02 06:08:42 +00:00
Agetian
d5534f40ea - Simple one-line implementation of getTriggeringAbility 2017-01-31 09:15:39 +00:00
Agetian
4cbd24d2db - Fixed logic in getTriggeringAbility that caused infinite loops in certain conditions. 2017-01-31 09:02:54 +00:00
Hanmac
5d55a66a6c CardFactoryUtil & Card: make etbCounter abilities different. they do not add a keyword anymore for the ability to remove it
the Replacement Effect is now Secondary and Card itself does do the Description of the Keywords
2017-01-31 05:44:43 +00:00
Agetian
c12d530b65 - Committed a previously missing predicate. 2017-01-30 13:37:11 +00:00
Agetian
40b05f7ad4 - NPE prevention in SpellAbilityRestriction (prevents Jhoira of the Ghitu Avatar crashing) 2017-01-30 09:11:29 +00:00
Agetian
4803c757ee [maven-release-plugin] prepare for next development iteration 2017-01-29 19:47:52 +00:00
Agetian
63809ef5ec [maven-release-plugin] prepare release forge-1.5.59 2017-01-29 19:47:46 +00:00
Hanmac
9847da099a Champion of Lambholt: make it working as it should.
Description bit ugly but can't be helped for now.
2017-01-29 18:58:55 +00:00
Hanmac
e630fafb22 CountersPutOrRemoveEffect: refactor to use better methods
CountersPutOrRemoveAI: use better logic to check when its good to remove a counter and when not
PlayerController: add chooseBinary with Params, use it for AddOrRemove. no need for chooseAndRemoveOrPutCounter
2017-01-29 14:44:43 +00:00
Agetian
9470f60554 - One more minor CardFactoryUtil mistype fix. 2017-01-29 12:54:45 +00:00
Agetian
5a8d2811c3 - A little correction in CardFactoryUtil. 2017-01-29 10:09:35 +00:00
Agetian
a40b5966f5 - Fixed a NPE in TriggerCrewed. 2017-01-29 04:48:21 +00:00
Agetian
a0ba7c2c31 - Crewing a vehicle should keep the vehicle's supertypes in order to obey Legendary restrictions. 2017-01-29 04:35:56 +00:00
Hanmac
a6aa647ef0 PlayerController: remove old chooseCounterType in use of new one 2017-01-28 15:23:43 +00:00
Hanmac
4b06eaf490 CountersRemove Effect and AI: update to new scripting
make the AI use of RemoveCounter abilities
2017-01-28 14:43:06 +00:00
Agetian
ae4e7c252a - More precise ChangeTargetsEffect replacement deduction for the purpose of DividedAsYouChoose 2017-01-28 14:11:22 +00:00
Hanmac
7bc472b4c3 CardPredicates: add hasLessCounter for x > 0 && x <= n 2017-01-28 14:08:39 +00:00
Agetian
465831930d - Reverting 33452, looks like it's impossible to retarget from the same SA to Spellskite twice (since the number of targets shouldn't change). 2017-01-28 11:02:40 +00:00
Agetian
677fadaa3a - More advanced Spellskite AI logic allowing the AI to retarget spells with multiple targets.
- Improved retargeting spells with DividedOnAllocation (may still be imprecise in certain corner cases and for certain AF ChangeTargets variants, consider improving).
2017-01-28 08:56:21 +00:00
Agetian
7226ab7b3d - Attempting to fix PlayEffect nagging the player to pick a card to play even if he refuses an optional effect once (e.g. AER Expertises).
- Maybe there's a better way to write the condition, please take a look when possible (note that Chandra, Pyromaster is a good test for something that needs to work well with the change in mind).
2017-01-26 14:43:11 +00:00
Agetian
63134e06c1 - Combine CostPayLife costs (e.g. prevents Cumulative Upkeep partial payment shenanigans) 2017-01-26 07:12:53 +00:00
Agetian
c3c4d0f098 - Better fix for the morphDown ability. 2017-01-25 15:52:27 +00:00
Agetian
7352b7aec0 - Improved AI for Bomat Courier (this logic can also be used for other potential cards that require you to discard your hand and that then refill your hand from exile; may be expanded to other zones too if necessary). 2017-01-23 16:34:33 +00:00
pfps
8b4bfbaae4 Show static abilities for instants and sorceries that are NOT secondary instead of those that are 2017-01-23 16:01:29 +00:00
Agetian
5c6a184720 - Morph ability should not be playable without paying its mana cost. Is there a better way of detecting "without paying its mana cost" except judging by description? 2017-01-23 14:41:57 +00:00
Agetian
e5acf1fa15 - Implemented some rudimentary mana ritual AI.
- Marked Dark Ritual as AI-playable. Other similar cards can probably now also use AI ManaRitual for this purpose.
2017-01-23 11:41:51 +00:00
Agetian
80281cd576 - Partially reverting 33309 (breaks trigger-related stuff). 2017-01-22 17:03:19 +00:00
Hanmac
1218fd3619 CardFactory: make Planeswalker use of ReplaceEffect for damage and fixed missing Reference 2017-01-22 14:39:38 +00:00
Hanmac
b62dad0793 PlayEffect: remove isEncoded because its not needed anymore 2017-01-22 10:51:36 +00:00
Hanmac
8a59cf3b33 EncodeEffect: don't activate if host is a Token (copy of spell) 2017-01-22 10:08:28 +00:00
Agetian
0ef430763b - Fixed Spellskite crashing upon trying to retarget a SA with DividedAsYouChoose. 2017-01-22 09:41:40 +00:00
Agetian
13793ecf6f - Fixed logic in CostPayEnergy (fixes e.g. Confiscation Coup). 2017-01-22 04:23:44 +00:00
Agetian
13c92798d8 - Fixed the name of the activating player not appearing in the AF Cipher description.
- Still need to somehow fix the fact that "...<player> chooses the card to encode" part appears in the stack description of the copied spell (it shouldn't).
2017-01-21 19:37:26 +00:00
Agetian
9b25ce3cc6 - Fixed logic in CombatUtil#canBlock 2017-01-21 17:53:21 +00:00