implement basic checkstyle configuration

Remove all unused or redundant imports Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
2025-11-11 08:16:23 +00:00 · 2018-09-11 17:35:03 -06:00
parent 9e0a4ded01
commit fc62a41e46
33 changed files with 195 additions and 64 deletions
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd">
+
+<!--
+  Checkstyle is very configurable.
+  http://checkstyle.sf.net (or in your downloaded distribution).
+-->
+
+<module name="Checker">
+    <module name="TreeWalker">
+
+        <module name="RedundantImport"/>
+        <module name="UnusedImports">
+            <!-- <property name="processJavadoc" value="false"/> -->
+        </module>
+
+    </module>
+
+</module>
--- a/forge-ai/pom.xml
+++ b/forge-ai/pom.xml
@@ -29,4 +29,31 @@
            <version>3.6.1</version>
        </dependency>
    </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+                <executions>
+                    <execution>
+                        <id>checkstyle-validation</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <configLocation>../checkstyle.xml</configLocation>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <encoding>UTF-8</encoding>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>true</failsOnError>
+                            <failOnViolation>true</failOnViolation>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 </project>
--- a/forge-ai/src/main/java/forge/ai/ComputerUtilCost.java
+++ b/forge-ai/src/main/java/forge/ai/ComputerUtilCost.java
@@ -5,7 +5,6 @@ import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import forge.ai.ability.AnimateAi;
 import forge.card.ColorSet;
-import forge.game.GameActionUtil;
 import forge.game.ability.AbilityUtils;
 import forge.game.card.Card;
 import forge.game.card.CardCollection;
--- a/forge-core/pom.xml
+++ b/forge-core/pom.xml
@@ -24,4 +24,31 @@
            <version>3.7</version>
        </dependency>
    </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+                <executions>
+                    <execution>
+                        <id>checkstyle-validation</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <configLocation>../checkstyle.xml</configLocation>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <encoding>UTF-8</encoding>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>true</failsOnError>
+                            <failOnViolation>true</failOnViolation>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 </project>
--- a/forge-core/src/main/java/forge/deck/Deck.java
+++ b/forge-core/src/main/java/forge/deck/Deck.java
@@ -24,7 +24,6 @@ import forge.StaticData;
 import forge.card.CardDb;
 import forge.item.IPaperCard;
 import forge.item.PaperCard;
-import forge.util.ItemPool;

 import java.util.*;
 import java.util.Map.Entry;
--- a/forge-game/pom.xml
+++ b/forge-game/pom.xml
@@ -31,4 +31,31 @@
            <type>jar</type>
        </dependency>
    </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+                <executions>
+                    <execution>
+                        <id>checkstyle-validation</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <configLocation>../checkstyle.xml</configLocation>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <encoding>UTF-8</encoding>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>true</failsOnError>
+                            <failOnViolation>true</failOnViolation>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 </project>
--- a/forge-game/src/main/java/forge/game/player/PlayerView.java
+++ b/forge-game/src/main/java/forge/game/player/PlayerView.java
@@ -11,7 +11,6 @@ import forge.util.TextUtil;
 import org.apache.commons.lang3.StringUtils;

 import com.google.common.base.MoreObjects;
-import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableMultiset;
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
--- a/forge-game/src/main/java/forge/game/trigger/TriggerSpellAbilityCast.java
+++ b/forge-game/src/main/java/forge/game/trigger/TriggerSpellAbilityCast.java
@@ -34,7 +34,6 @@ import forge.game.spellability.OptionalCost;
 import forge.game.spellability.SpellAbility;
 import forge.game.spellability.SpellAbilityStackInstance;
 import forge.game.spellability.TargetChoices;
-import forge.game.staticability.StaticAbility;
 import forge.game.zone.ZoneType;
 import forge.util.Expressions;

--- a/forge-gui-android/pom.xml
+++ b/forge-gui-android/pom.xml
@@ -36,6 +36,28 @@
                    <target>1.8</target>
                </configuration>
            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+                <executions>
+                    <execution>
+                        <id>checkstyle-validation</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <configLocation>../checkstyle.xml</configLocation>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <encoding>UTF-8</encoding>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>true</failsOnError>
+                            <failOnViolation>true</failOnViolation>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
        </plugins>
        <resources>
            <resource>
--- a/forge-gui-desktop/pom.xml
+++ b/forge-gui-desktop/pom.xml
@@ -153,6 +153,28 @@
 				</executions>
 			</plugin>

+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<version>3.0.0</version>
+				<executions>
+					<execution>
+						<id>checkstyle-validation</id>
+						<phase>validate</phase>
+						<configuration>
+							<configLocation>../checkstyle.xml</configLocation>
+							<includeTestSourceDirectory>true</includeTestSourceDirectory>
+							<encoding>UTF-8</encoding>
+							<consoleOutput>true</consoleOutput>
+							<failsOnError>true</failsOnError>
+							<failOnViolation>true</failOnViolation>
+						</configuration>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
 		</plugins>
 	</build>

--- a/forge-gui-desktop/src/main/java/forge/gui/framework/SLayoutIO.java
+++ b/forge-gui-desktop/src/main/java/forge/gui/framework/SLayoutIO.java
@@ -28,7 +28,6 @@ import javax.xml.stream.events.XMLEvent;

 import forge.FThreads;
 import forge.Singletons;
-import forge.error.BugReporter;
 import forge.gui.SOverlayUtils;
 import forge.properties.FileLocation;
 import forge.properties.ForgeConstants;
--- a/forge-gui-desktop/src/main/java/forge/itemmanager/CardManager.java
+++ b/forge-gui-desktop/src/main/java/forge/itemmanager/CardManager.java
@@ -12,8 +12,6 @@ import forge.screens.home.quest.DialogChooseSets;
 import forge.screens.match.controllers.CDetailPicture;

 import javax.swing.*;
-import java.util.ArrayList;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map.Entry;
--- a/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CBrawlDecks.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CBrawlDecks.java
@@ -4,8 +4,6 @@ import forge.deck.DeckProxy;
 import forge.gui.framework.ICDoc;
 import forge.itemmanager.ItemManagerConfig;
 import forge.screens.deckeditor.views.VBrawlDecks;
-import forge.screens.deckeditor.views.VCommanderDecks;
-import forge.screens.deckeditor.views.VTinyLeadersDecks;

 /**
 * Controls the "Commander Decks" panel in the deck editor UI.
--- a/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CCommanderDecks.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CCommanderDecks.java
@@ -3,7 +3,6 @@ package forge.screens.deckeditor.controllers;
 import forge.deck.DeckProxy;
 import forge.gui.framework.ICDoc;
 import forge.itemmanager.ItemManagerConfig;
-import forge.screens.deckeditor.views.VAllDecks;
 import forge.screens.deckeditor.views.VCommanderDecks;

 /**
--- a/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CEditorConstructed.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CEditorConstructed.java
@@ -38,9 +38,7 @@ import forge.screens.deckeditor.SEditorIO;
 import forge.screens.match.controllers.CDetailPicture;
 import forge.toolbox.FComboBox;
 import forge.util.ItemPool;
-import sun.font.FontConfigManager;

-import javax.swing.*;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 import java.util.ArrayList;
--- a/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CEditorQuestLimited.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CEditorQuestLimited.java
@@ -20,7 +20,6 @@ package forge.screens.deckeditor.controllers;
 import com.google.common.base.Function;
 import com.google.common.base.Supplier;
 import forge.UiCommand;
-import forge.deck.CardPool;
 import forge.deck.Deck;
 import forge.deck.DeckGroup;
 import forge.deck.DeckSection;
--- a/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CTinyLeadersDecks.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/deckeditor/controllers/CTinyLeadersDecks.java
@@ -3,7 +3,6 @@ package forge.screens.deckeditor.controllers;
 import forge.deck.DeckProxy;
 import forge.gui.framework.ICDoc;
 import forge.itemmanager.ItemManagerConfig;
-import forge.screens.deckeditor.views.VCommanderDecks;
 import forge.screens.deckeditor.views.VTinyLeadersDecks;

 /**
--- a/forge-gui-desktop/src/main/java/forge/screens/home/PlayerPanel.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/home/PlayerPanel.java
@@ -35,7 +35,6 @@ import forge.model.FModel;
 import forge.properties.ForgePreferences;
 import forge.properties.ForgePreferences.FPref;
 import forge.screens.deckeditor.CDeckEditorUI;
-import forge.screens.deckeditor.controllers.CEditorCommander;
 import forge.screens.deckeditor.controllers.CEditorVariant;
 import forge.screens.home.sanctioned.AvatarSelector;
 import forge.toolbox.FCheckBox;
--- a/forge-gui-desktop/src/main/java/forge/screens/home/quest/DialogChooseFormats.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/home/quest/DialogChooseFormats.java
@@ -1,12 +1,10 @@
 package forge.screens.home.quest;

 import forge.assets.FSkinProp;
-import forge.card.CardEdition;
 import forge.game.GameFormat;
 import forge.gui.SOverlayUtils;
 import forge.model.FModel;
 import forge.toolbox.*;
-import forge.util.TextUtil;
 import net.miginfocom.swing.MigLayout;

 import javax.swing.*;
--- a/forge-gui-desktop/src/main/java/forge/screens/match/CMatchUI.java
+++ b/forge-gui-desktop/src/main/java/forge/screens/match/CMatchUI.java
@@ -28,7 +28,6 @@ import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.concurrent.atomic.AtomicReference;
-import java.util.prefs.Preferences;

 import javax.swing.JMenu;
 import javax.swing.JPopupMenu;
--- a/forge-gui-desktop/src/test/java/forge/planarconquestgenerate/PlanarConquestCommanderGeneraterGA.java
+++ b/forge-gui-desktop/src/test/java/forge/planarconquestgenerate/PlanarConquestCommanderGeneraterGA.java
@@ -6,7 +6,6 @@ import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
 import forge.GuiBase;
 import forge.GuiDesktop;
-import forge.LobbyPlayer;
 import forge.StaticData;
 import forge.card.CardRulesPredicates;
 import forge.deck.*;
@@ -14,27 +13,15 @@ import forge.deck.io.DeckStorage;
 import forge.game.GameFormat;
 import forge.game.GameRules;
 import forge.game.GameType;
-import forge.game.Match;
-import forge.game.player.RegisteredPlayer;
 import forge.item.PaperCard;
 import forge.limited.CardRanker;
 import forge.model.FModel;
-import forge.player.GamePlayerUtil;
 import forge.properties.ForgeConstants;
 import forge.properties.ForgePreferences;
-import forge.tournament.system.AbstractTournament;
-import forge.tournament.system.TournamentPairing;
-import forge.tournament.system.TournamentPlayer;
-import forge.tournament.system.TournamentSwiss;
-import forge.util.AbstractGeneticAlgorithm;
-import forge.util.MyRandom;
-import forge.util.TextUtil;
-import forge.view.SimulateMatch;

 import java.io.File;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Map;

 public class PlanarConquestCommanderGeneraterGA extends PlanarConquestGeneraterGA {

--- a/forge-gui-desktop/src/test/java/forge/planarconquestgenerate/PlanarConquestGeneraterGAStandard.java
+++ b/forge-gui-desktop/src/test/java/forge/planarconquestgenerate/PlanarConquestGeneraterGAStandard.java
@@ -1,40 +1,19 @@
 package forge.planarconquestgenerate;

 import com.google.common.base.Function;
-import com.google.common.base.Predicates;
-import com.google.common.collect.Iterables;
-import com.google.common.collect.Lists;
 import forge.GuiBase;
 import forge.GuiDesktop;
-import forge.LobbyPlayer;
-import forge.StaticData;
-import forge.card.CardRulesPredicates;
 import forge.deck.*;
 import forge.deck.io.DeckStorage;
 import forge.game.GameFormat;
 import forge.game.GameRules;
 import forge.game.GameType;
-import forge.game.Match;
-import forge.game.player.RegisteredPlayer;
 import forge.item.PaperCard;
-import forge.limited.CardRanker;
 import forge.model.FModel;
-import forge.player.GamePlayerUtil;
 import forge.properties.ForgeConstants;
 import forge.properties.ForgePreferences;
-import forge.tournament.system.AbstractTournament;
-import forge.tournament.system.TournamentPairing;
-import forge.tournament.system.TournamentPlayer;
-import forge.tournament.system.TournamentSwiss;
-import forge.util.AbstractGeneticAlgorithm;
-import forge.util.MyRandom;
-import forge.util.TextUtil;
-import forge.view.SimulateMatch;
-
 import java.io.File;
-import java.util.ArrayList;
 import java.util.List;
-import java.util.Map;

 public class PlanarConquestGeneraterGAStandard extends PlanarConquestGeneraterGA {

--- a/forge-gui-mobile-dev/pom.xml
+++ b/forge-gui-mobile-dev/pom.xml
@@ -52,6 +52,28 @@
          </executions>
      </plugin>

+        <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-checkstyle-plugin</artifactId>
+            <version>3.0.0</version>
+            <executions>
+                <execution>
+                    <id>checkstyle-validation</id>
+                    <phase>validate</phase>
+                    <configuration>
+                        <configLocation>../checkstyle.xml</configLocation>
+                        <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                        <encoding>UTF-8</encoding>
+                        <consoleOutput>true</consoleOutput>
+                        <failsOnError>true</failsOnError>
+                        <failOnViolation>true</failOnViolation>
+                    </configuration>
+                    <goals>
+                        <goal>check</goal>
+                    </goals>
+                </execution>
+            </executions>
+        </plugin>
    </plugins>
  </build>

--- a/forge-gui/pom.xml
+++ b/forge-gui/pom.xml
@@ -78,4 +78,31 @@
            <version>1.7.22</version>
        </dependency>
    </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+                <executions>
+                    <execution>
+                        <id>checkstyle-validation</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <configLocation>../checkstyle.xml</configLocation>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <encoding>UTF-8</encoding>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>true</failsOnError>
+                            <failOnViolation>true</failOnViolation>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 </project>
--- a/forge-gui/src/main/java/forge/card/CardReaderExperiments.java
+++ b/forge-gui/src/main/java/forge/card/CardReaderExperiments.java
@@ -1,7 +1,6 @@
 package forge.card;

 import forge.CardStorageReader;
-import forge.card.CardRules;
 import forge.properties.ForgeConstants;
 import forge.util.FileUtil;

--- a/forge-gui/src/main/java/forge/deck/CardArchetypeLDAGenerator.java
+++ b/forge-gui/src/main/java/forge/deck/CardArchetypeLDAGenerator.java
@@ -3,11 +3,9 @@ package forge.deck;
 import forge.StaticData;
 import forge.deck.io.Archetype;
 import forge.deck.io.CardThemedLDAIO;
-import forge.game.GameFormat;
 import forge.model.FModel;
 import org.apache.commons.lang3.tuple.Pair;

-import java.io.File;
 import java.util.*;

 /**
--- a/forge-gui/src/main/java/forge/deck/CardRelationMatrixGenerator.java
+++ b/forge-gui/src/main/java/forge/deck/CardRelationMatrixGenerator.java
@@ -6,7 +6,6 @@ import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
 import forge.card.CardRules;
 import forge.card.CardRulesPredicates;
-import forge.deck.io.CardThemedLDAIO;
 import forge.deck.io.CardThemedMatrixIO;
 import forge.deck.io.DeckStorage;
 import forge.game.GameFormat;
--- a/forge-gui/src/main/java/forge/deck/DeckGeneratorTheme.java
+++ b/forge-gui/src/main/java/forge/deck/DeckGeneratorTheme.java
@@ -17,7 +17,6 @@
 */
 package forge.deck;

-import forge.deck.CardPool;
 import forge.deck.generation.DeckGeneratorBase;
 import forge.deck.generation.IDeckGenPool;
 import forge.properties.ForgeConstants;
--- a/forge-gui/src/main/java/forge/deck/DeckgenUtil.java
+++ b/forge-gui/src/main/java/forge/deck/DeckgenUtil.java
@@ -35,7 +35,6 @@ import forge.util.gui.SOptionPane;
 import forge.util.storage.IStorage;
 import org.apache.commons.lang3.tuple.Pair;

-import java.awt.print.Paper;
 import java.util.*;

 /** 
--- a/forge-gui/src/main/java/forge/deck/io/CardThemedLDAIO.java
+++ b/forge-gui/src/main/java/forge/deck/io/CardThemedLDAIO.java
@@ -1,12 +1,10 @@
 package forge.deck.io;

 import forge.game.GameFormat;
-import forge.item.PaperCard;
 import forge.properties.ForgeConstants;
 import org.apache.commons.lang3.tuple.Pair;

 import java.io.*;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;

--- a/forge-gui/src/main/java/forge/error/BugReporter.java
+++ b/forge-gui/src/main/java/forge/error/BugReporter.java
@@ -30,7 +30,6 @@ import forge.model.FModel;
 import forge.properties.ForgePreferences;
 import forge.util.gui.SOptionPane;
 import io.sentry.Sentry;
-import io.sentry.event.Breadcrumb;
 import io.sentry.event.BreadcrumbBuilder;

 /**
--- a/forge-gui/src/main/java/forge/limited/CustomLimited.java
+++ b/forge-gui/src/main/java/forge/limited/CustomLimited.java
@@ -18,10 +18,8 @@
 package forge.limited;

 import forge.card.CardEdition;
-import forge.deck.CardPool;
 import forge.deck.Deck;
 import forge.deck.DeckBase;
-import forge.deck.DeckSection;
 import forge.item.PaperCard;
 import forge.item.SealedProduct;
 import forge.model.FModel;
--- a/forge-gui/src/main/java/forge/player/PlayerControllerHuman.java
+++ b/forge-gui/src/main/java/forge/player/PlayerControllerHuman.java
@@ -18,7 +18,6 @@ import forge.control.FControlGamePlayback;
 import forge.deck.CardPool;
 import forge.deck.Deck;
 import forge.deck.DeckSection;
-import forge.error.BugReporter;
 import forge.events.UiEventNextGameDecision;
 import forge.game.*;
 import forge.game.ability.AbilityFactory;