external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-20 12:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

TapsForMana corner cases with Piracy affecting wrong player (#1497)

Browse Source
This commit is contained in:
tool4ever
2022-09-08 08:01:14 +00:00
committed by GitHub
parent 6df0a4771d
commit 38f8e784b1
14 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
forge-game/src/main/java/forge/game/card/CardView.java
View File

@@ -456,7 +456,7 @@ public class CardView extends GameEntityView {
return get(TrackableProperty.Remembered);
}
void updateRemembered(Card c) {
if (c.getRemembered() == null || Iterables.size(c.getRemembered()) == 0) {
if (c.getRemembered() == null || Iterables.isEmpty(c.getRemembered())) {
set(TrackableProperty.Remembered, null);
return;
}

2
forge-gui/res/cardsfolder/b/bubbling_muck.txt
View File

@@ -3,6 +3,6 @@ ManaCost:B
Types:Sorcery
A:SP$ Effect | Triggers$ SwampTrigger | SpellDescription$ Until end of turn, whenever a player taps a Swamp for mana, that player adds an additional {B}.
SVar:SwampTrigger:Mode$ TapsForMana | ValidCard$ Swamp | Execute$ TrigMana | Static$ True | TriggerDescription$ Whenever a player taps a Swamp for mana, that player adds an additional {B}.
SVar:TrigMana:DB$ Mana | Produced$ B | Amount$ 1 | Defined$ TriggeredPlayer
SVar:TrigMana:DB$ Mana | Produced$ B | Amount$ 1 | Defined$ TriggeredActivator
AI:RemoveDeck:All
Oracle:Until end of turn, whenever a player taps a Swamp for mana, that player adds an additional {B}.

2
forge-gui/res/cardsfolder/b/burning_earth.txt
View File

@@ -2,6 +2,6 @@ Name:Burning Earth
ManaCost:3 R
Types:Enchantment
T:Mode$ TapsForMana | ValidCard$ Land.nonBasic | Execute$ TrigDmg | TriggerZones$ Battlefield | TriggerDescription$ Whenever a player taps a nonbasic land for mana, CARDNAME deals 1 damage to that player.
SVar:TrigDmg:DB$ DealDamage | Defined$ TriggeredCardController | NumDmg$ 1
SVar:TrigDmg:DB$ DealDamage | Defined$ TriggeredActivator | NumDmg$ 1
AI:RemoveDeck:Random
Oracle:Whenever a player taps a nonbasic land for mana, Burning Earth deals 1 damage to that player.

2
forge-gui/res/cardsfolder/f/forbidden_orchard.txt
View File

@@ -2,6 +2,6 @@ Name:Forbidden Orchard
ManaCost:no cost
Types:Land
A:AB$ Mana | Cost$ T | Produced$ Any | SpellDescription$ Add one mana of any color.
T:Mode$ TapsForMana | ValidCard$ Card.Self | Execute$ TrigToken | TriggerDescription$ Whenever you tap CARDNAME for mana, target opponent creates a 1/1 colorless Spirit creature token.
T:Mode$ TapsForMana | ValidCard$ Card.Self | Activator$ You | Execute$ TrigToken | TriggerDescription$ Whenever you tap CARDNAME for mana, target opponent creates a 1/1 colorless Spirit creature token.
SVar:TrigToken:DB$ Token | ValidTgts$ Opponent | TokenAmount$ 1 | TokenScript$ c_1_1_spirit | TokenOwner$ Targeted
Oracle:{T}: Add one mana of any color.\nWhenever you tap Forbidden Orchard for mana, target opponent creates a 1/1 colorless Spirit creature token.

2
forge-gui/res/cardsfolder/g/gauntlet_of_might.txt
View File

@@ -3,7 +3,7 @@ ManaCost:4
Types:Artifact
S:Mode$ Continuous | Affected$ Creature.Red | AddPower$ 1 | AddToughness$ 1 | Description$ Red creatures get +1/+1.
T:Mode$ TapsForMana | ValidCard$ Mountain | Execute$ TrigMana | TriggerZones$ Battlefield | Static$ True | TriggerDescription$ Whenever a Mountain is tapped for mana, its controller adds an additional {R}.
SVar:TrigMana:DB$ Mana | Produced$ R | Amount$ 1 | Defined$ TriggeredPlayer
SVar:TrigMana:DB$ Mana | Produced$ R | Amount$ 1 | Defined$ TriggeredCardController
AI:RemoveDeck:Random
DeckNeeds:Color$Red
Oracle:Red creatures get +1/+1.\nWhenever a Mountain is tapped for mana, its controller adds an additional {R}.

2
forge-gui/res/cardsfolder/g/gauntlet_of_power.txt
View File

@@ -5,5 +5,5 @@ K:ETBReplacement:Other:ChooseColor
SVar:ChooseColor:DB$ ChooseColor | Defined$ You | AILogic$ MostProminentInComputerDeck | SpellDescription$ As CARDNAME enters the battlefield, choose a color.
S:Mode$ Continuous | Affected$ Creature.ChosenColor | AddPower$ 1 | AddToughness$ 1 | Description$ Creatures of the chosen color get +1/+1.
T:Mode$ TapsForMana | ValidCard$ Land.Basic | Produced$ ChosenColor | Execute$ TrigMana | TriggerZones$ Battlefield | Static$ True | TriggerDescription$ Whenever a basic land is tapped for mana of the chosen color, its controller adds an additional one mana of that color.
SVar:TrigMana:DB$ Mana | Produced$ Chosen | Amount$ 1 | Defined$ TriggeredPlayer
SVar:TrigMana:DB$ Mana | Produced$ Chosen | Amount$ 1 | Defined$ TriggeredCardController
Oracle:As Gauntlet of Power enters the battlefield, choose a color.\nCreatures of the chosen color get +1/+1.\nWhenever a basic land is tapped for mana of the chosen color, its controller adds an additional one mana of that color.

2
forge-gui/res/cardsfolder/h/high_tide.txt
View File

@@ -3,6 +3,6 @@ ManaCost:U
Types:Instant
A:SP$ Effect | Triggers$ IslandTrigger | SpellDescription$ Until end of turn, whenever a player taps an Island for mana, that player adds an additional {U}.
SVar:IslandTrigger:Mode$ TapsForMana | ValidCard$ Island | Execute$ TrigMana | Static$ True | TriggerDescription$ Whenever a player taps an Island for mana, that player adds an additional {U}.
SVar:TrigMana:DB$ Mana | Produced$ U | Amount$ 1 | Defined$ TriggeredPlayer
SVar:TrigMana:DB$ Mana | Produced$ U | Amount$ 1 | Defined$ TriggeredActivator
AI:RemoveDeck:All
Oracle:Until end of turn, whenever a player taps an Island for mana, that player adds an additional {U}.

2
forge-gui/res/cardsfolder/m/manabarbs.txt
View File

@@ -2,6 +2,6 @@ Name:Manabarbs
ManaCost:3 R
Types:Enchantment
T:Mode$ TapsForMana | ValidCard$ Land | TriggerZones$ Battlefield | Execute$ TrigDamage | TriggerDescription$ Whenever a player taps a land for mana, CARDNAME deals 1 damage to that player.
SVar:TrigDamage:DB$ DealDamage | Defined$ TriggeredPlayer | NumDmg$ 1
SVar:TrigDamage:DB$ DealDamage | Defined$ TriggeredActivator | NumDmg$ 1
AI:RemoveDeck:Random
Oracle:Whenever a player taps a land for mana, Manabarbs deals 1 damage to that player.

2
forge-gui/res/cardsfolder/o/overabundance.txt
View File

@@ -2,7 +2,7 @@ Name:Overabundance
ManaCost:1 R G
Types:Enchantment
T:Mode$ TapsForMana | ValidCard$ Land | Execute$ TrigDmg | TriggerZones$ Battlefield | Static$ True | TriggerDescription$ Whenever a player taps a land for mana, that player adds one mana of any type that land produced, and CARDNAME deals 1 damage to the player.
SVar:TrigDmg:DB$ DealDamage | Defined$ TriggeredCardController | NumDmg$ 1 | SubAbility$ DBMana
SVar:TrigDmg:DB$ DealDamage | Defined$ TriggeredActivator | NumDmg$ 1 | SubAbility$ DBMana
SVar:DBMana:DB$ ManaReflected | ColorOrType$ Type | ReflectProperty$ Produced | Defined$ TriggeredActivator
AI:RemoveDeck:Random
Oracle:Whenever a player taps a land for mana, that player adds one mana of any type that land produced, and Overabundance deals 1 damage to the player.

2
forge-gui/res/cardsfolder/s/sanctimony.txt
View File

@@ -1,7 +1,7 @@
Name:Sanctimony
ManaCost:1 W
Types:Enchantment
T:Mode$ TapsForMana | ValidCard$ Mountain.OppCtrl | TriggerZones$ Battlefield | Execute$ TrigGainLife | OptionalDecider$ You | TriggerDescription$ Whenever an opponent taps a Mountain for mana, you may gain 1 life.
T:Mode$ TapsForMana | ValidCard$ Mountain | Activator$ Opponent | TriggerZones$ Battlefield | Execute$ TrigGainLife | OptionalDecider$ You | TriggerDescription$ Whenever an opponent taps a Mountain for mana, you may gain 1 life.
SVar:TrigGainLife:DB$ GainLife | Defined$ You | LifeAmount$ 1
AI:RemoveDeck:Random
Oracle:Whenever an opponent taps a Mountain for mana, you may gain 1 life.

2
forge-gui/res/cardsfolder/s/scald.txt
View File

@@ -2,6 +2,6 @@ Name:Scald
ManaCost:1 R
Types:Enchantment
T:Mode$ TapsForMana | ValidCard$ Island | TriggerZones$ Battlefield | Execute$ TrigDealDamage | TriggerDescription$ Whenever a player taps an Island for mana, CARDNAME deals 1 damage to that player.
SVar:TrigDealDamage:DB$ DealDamage | Defined$ TriggeredCardController | NumDmg$ 1
SVar:TrigDealDamage:DB$ DealDamage | Defined$ TriggeredActivator | NumDmg$ 1
AI:RemoveDeck:Random
Oracle:Whenever a player taps an Island for mana, Scald deals 1 damage to that player.

2
forge-gui/res/cardsfolder/t/treasure_nabber.txt
View File

@@ -2,6 +2,6 @@ Name:Treasure Nabber
ManaCost:2 R
Types:Creature Goblin Rogue
PT:3/2
T:Mode$ TapsForMana | ValidCard$ Artifact.OppCtrl | TriggerZones$ Battlefield | Execute$ TrigControl | TriggerDescription$ Whenever an opponent taps an artifact for mana, gain control of that artifact until the end of your next turn.
T:Mode$ TapsForMana | ValidCard$ Artifact | Activator$ Opponent | TriggerZones$ Battlefield | Execute$ TrigControl | TriggerDescription$ Whenever an opponent taps an artifact for mana, gain control of that artifact until the end of your next turn.
SVar:TrigControl:DB$ GainControl | Defined$ TriggeredCard | LoseControl$ UntilTheEndOfYourNextTurn
Oracle:Whenever an opponent taps an artifact for mana, gain control of that artifact until the end of your next turn.

2
forge-gui/res/cardsfolder/v/vernal_bloom.txt
View File

@@ -2,6 +2,6 @@ Name:Vernal Bloom
ManaCost:3 G
Types:Enchantment
T:Mode$ TapsForMana | ValidCard$ Forest | Execute$ TrigMana | TriggerZones$ Battlefield | Static$ True | TriggerDescription$ Whenever a Forest is tapped for mana, its controller adds an additional {G}.
SVar:TrigMana:DB$ Mana | Produced$ G | Amount$ 1 | Defined$ TriggeredPlayer
SVar:TrigMana:DB$ Mana | Produced$ G | Amount$ 1 | Defined$ TriggeredCardController
AI:RemoveDeck:Random
Oracle:Whenever a Forest is tapped for mana, its controller adds an additional {G}.

2
forge-gui/res/cardsfolder/z/zhur_taa_druid.txt
View File

@@ -3,6 +3,6 @@ ManaCost:R G
Types:Creature Human Druid
PT:1/1
A:AB$ Mana | Cost$ T | Produced$ G | SpellDescription$ Add {G}.
T:Mode$ TapsForMana | ValidCard$ Card.Self | TriggerZones$ Battlefield | Execute$ TrigDmg | TriggerDescription$ Whenever you tap CARDNAME for mana, it deals 1 damage to each opponent.
T:Mode$ TapsForMana | ValidCard$ Card.Self | Activator$ You | TriggerZones$ Battlefield | Execute$ TrigDmg | TriggerDescription$ Whenever you tap CARDNAME for mana, it deals 1 damage to each opponent.
SVar:TrigDmg:DB$ DealDamage | NumDmg$ 1 | Defined$ Player.Opponent
Oracle:{T}: Add {G}.\nWhenever you tap Zhur-Taa Druid for mana, it deals 1 damage to each opponent.