external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-19 20:28:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Java doesn't shortcircuit &=

Browse Source
This commit is contained in:
Chris H
2024-03-28 17:40:31 -04:00
parent 96f1178d68
commit 2c04b08ae8
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
forge-gui/src/main/java/forge/player/HumanPlaySpellAbility.java
View File

@@ -163,14 +163,11 @@ public class HumanPlaySpellAbility {
// is only executed or evaluated if the first argument does not suffice to determine the value of the expression
// because of Selective Snare do announceType first
// We need to split up this super conditional to know WHY somethings prequisites failed.
// Failing because there's no legal targets is different than failing because the player canceled paying costs
boolean preCostRequisites = announceType() && announceValuesLikeX();
preCostRequisites &= ability.checkRestrictions(human);
preCostRequisites &= (!mayChooseTargets || ability.setupTargets());
preCostRequisites &= ability.canCastTiming(human);
preCostRequisites &= ability.isLegalAfterStack();
boolean preCostRequisites = announceType() && announceValuesLikeX() &&
ability.checkRestrictions(human) &&
(!mayChooseTargets || ability.setupTargets()) &&
ability.canCastTiming(human) &&
ability.isLegalAfterStack();
final boolean prerequisitesMet = preCostRequisites && (isFree || payment.payCost(new HumanCostDecision(controller, human, ability, ability.isTrigger())));