ryan/mozjpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Due to the way in which the configure script silently falls back to a non-SIMD build if SIMD can't be enabled, we accidentally released iOS ARM v7 and v7s binaries in 1.3.0 that did not contain NEON SIMD code, because gas-preprocessor.pl wasn't in the PATH. In order to prevent this from happening again, specifying --with-simd now has the effect of forcing a SIMD build, and if this argument is specified, any issues encountered while enabling SIMD are treated as fatal.

Browse Source 
git-svn-id: svn+ssh://svn.code.sf.net/p/libjpeg-turbo/code/trunk@1037 632fc199-4ca6-4c93-a231-07263d6284db
This commit is contained in:
DRC
2013-09-25 04:36:44 +00:00
parent 27df2a4c03
commit 8ca34d4b33
1 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
configure.ac
View File

@@ -400,6 +400,10 @@ fi
AC_ARG_WITH([simd], AC_ARG_WITH([simd],
AC_HELP_STRING([--without-simd], [Do not include SIMD extensions])) AC_HELP_STRING([--without-simd], [Do not include SIMD extensions]))
if test "x${with_simd}" != "xno"; then if test "x${with_simd}" != "xno"; then
require_simd=no
if test "x${with_simd}" = "xyes"; then
require_simd=yes
fi
# Check if we're on a supported CPU # Check if we're on a supported CPU
AC_MSG_CHECKING([if we have SIMD optimisations for cpu type]) AC_MSG_CHECKING([if we have SIMD optimisations for cpu type])
case "$host_cpu" in case "$host_cpu" in
@@ -420,8 +424,12 @@ if test "x${with_simd}" != "xno"; then
[AC_MSG_RESULT([yes]) [AC_MSG_RESULT([yes])
simd_arch=arm], simd_arch=arm],
[AC_MSG_RESULT([no]) [AC_MSG_RESULT([no])
with_simd=no with_simd=no])
AC_MSG_WARN([SIMD support can't be enabled. Performance will suffer.])]) if test "x${require_simd}" = "xyes" -a "x${with_simd}" = "xno"; then
AC_MSG_ERROR([SIMD support can't be enabled.])
else
AC_MSG_WARN([SIMD support can't be enabled. Performance will suffer.])
fi
;; ;;
mipsel*) mipsel*)
AC_MSG_RESULT([yes (mipsel)]) AC_MSG_RESULT([yes (mipsel)])
@@ -430,13 +438,21 @@ if test "x${with_simd}" != "xno"; then
[AC_MSG_RESULT([yes]) [AC_MSG_RESULT([yes])
simd_arch=mipsel], simd_arch=mipsel],
[AC_MSG_RESULT([no]) [AC_MSG_RESULT([no])
with_simd=no with_simd=no])
AC_MSG_WARN([SIMD support can't be enabled. Performance will suffer.])]) if test "x${require_simd}" = "xyes" -a "x${with_simd}" = "xno"; then
AC_MSG_ERROR([SIMD support can't be enabled.])
else
AC_MSG_WARN([SIMD support can't be enabled. Performance will suffer.])
fi
;; ;;
*) *)
AC_MSG_RESULT([no ("$host_cpu")]) AC_MSG_RESULT([no ("$host_cpu")])
AC_MSG_WARN([SIMD support not available for this CPU. Performance will suffer.])
with_simd=no; with_simd=no;
if test "x${require_simd}" = "xyes" -a "x${with_simd}" = "xno"; then
AC_MSG_ERROR([SIMD support not available for this CPU.])
else
AC_MSG_WARN([SIMD support not available for this CPU. Performance will suffer.])
fi
;; ;;
esac esac