external-repos/squoosh
1
0
Fork 1
mirror of https://github.com/GoogleChromeLabs/squoosh.git synced 2025-11-14 17:49:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix <range-input disabled> (#195)

Browse Source 
* Fix .disabled property reflection for range-input (only attribute worked previously)

* Revert "Fix .disabled property reflection for range-input (only attribute worked previously)"

This reverts commit f5964635b2.

* Fix reflection

* Use hasAttribute()
This commit is contained in:
Jason Miller
2018-10-20 06:51:30 -05:00
committed by Jake Archibald
parent 49b40b1c3e
commit a79f95b305
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/custom-els/RangeInput/index.ts
View File

@@ -80,10 +80,12 @@ class RangeInputElement extends HTMLElement {
private _reflectAttributes() { private _reflectAttributes() {
this._ignoreChange = true; this._ignoreChange = true;
for (const attributeName in REFLECTED_ATTRIBUTES) { for (const attributeName of REFLECTED_ATTRIBUTES) {
const attributeValue = this._input.getAttribute(attributeName); if (this._input.hasAttribute(attributeName)) {
if (attributeValue === null) continue; this.setAttribute(attributeName, this._input.getAttribute(attributeName)!);
this.setAttribute(attributeName, attributeValue); } else {
this.removeAttribute(attributeName);
}
} }
this._ignoreChange = false; this._ignoreChange = false;
} }