external-repos/squoosh
1
0
Fork 1
mirror of https://github.com/GoogleChromeLabs/squoosh.git synced 2025-11-15 01:59:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent both sides sharing a download URL. (#369)

Browse Source
This commit is contained in:
Jake Archibald
2018-12-12 12:51:06 +00:00
committed by GitHub
parent 593ad62cbb
commit 3245987113
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/components/compress/index.tsx
View File

@@ -160,7 +160,7 @@ function stateForNewSourceData(state: State, newSource: SourceImage): State {
for (const i of [0, 1]) { for (const i of [0, 1]) {
// Ditch previous encodings // Ditch previous encodings
const downloadUrl = state.sides[i].downloadUrl; const downloadUrl = state.sides[i].downloadUrl;
if (downloadUrl) URL.revokeObjectURL(downloadUrl!); if (downloadUrl) URL.revokeObjectURL(downloadUrl);
newState = cleanMerge(state, `sides.${i}`, { newState = cleanMerge(state, `sides.${i}`, {
preprocessed: undefined, preprocessed: undefined,
@@ -319,9 +319,14 @@ export default class Compress extends Component<Props, State> {
private async onCopyToOtherClick(index: 0 | 1) { private async onCopyToOtherClick(index: 0 | 1) {
const otherIndex = (index + 1) % 2; const otherIndex = (index + 1) % 2;
const oldSettings = this.state.sides[otherIndex]; const oldSettings = this.state.sides[otherIndex];
const newSettings = { ...this.state.sides[index] };
// Create a new object URL for the new settings. This avoids both sides sharing a URL, which
// means it can be safely revoked without impacting the other side.
if (newSettings.file) newSettings.downloadUrl = URL.createObjectURL(newSettings.file);
this.setState({ this.setState({
sides: cleanSet(this.state.sides, otherIndex, this.state.sides[index]), sides: cleanSet(this.state.sides, otherIndex, newSettings),
}); });
const result = await this.props.showSnack('Settings copied across', { const result = await this.props.showSnack('Settings copied across', {