Compare commits

..

557 Commits

Author SHA1 Message Date
Hans Mackowiak
c32b84b40c Update EffectAi.java 2025-07-30 11:19:02 +02:00
Hans Mackowiak
6962c2cf99 EffectAi: first try of generic cantAttack and cantBlock 2025-07-30 11:14:11 +02:00
Hans Mackowiak
b7ec60863a ~ start of DetainAi 2025-07-30 11:14:11 +02:00
Hans Mackowiak
239cf3ece7 more hidden keywords to effects 2025-07-30 11:14:11 +02:00
Hans Mackowiak
06781fb6ff moved another part to EffectEffect 2025-07-30 11:14:11 +02:00
Hans Mackowiak
a85f00043b Add DetainEffect 2025-07-30 11:14:11 +02:00
tool4ever
dde58be5a6 Clean up redundant "AI" from function names (#8243) 2025-07-30 07:44:17 +00:00
lemtom
1ad4fda3e6 16x16 avatars for every enemy (#8206)
* 16x16 avatars for every enemy

* 16x16 death knight

* 16x16 zombie poisoner

---------

Co-authored-by: Agetian <stavdev@mail.ru>
2025-07-30 07:50:51 +03:00
shenshinoman
b78ef7b010 Updating the "InsectShop" shop icon to a newly provided one from the community. Icon provided by coby_cat from the discord. (Also updated the GIMP XCF project file to match the current png. So as to ensure those using GIMP to edit these are up to date.) (#8227) 2025-07-30 07:50:41 +03:00
Renato Filipe Vidal Santos
d1776ce37a Add files via upload (#8205) 2025-07-30 07:50:32 +03:00
tool4ever
415e247f6c Cleanup API handling Part 2 (#8241)
* Improve entrypoints

* Consolidate AtOppEOT
2025-07-29 19:12:52 +00:00
tool4ever
ca4a934e0f Cleanup API handling (#8238)
* Remove obsolete branch

* Merge ward logic

* Convert Fatal Push logic

* Streamline condition handling!

* Consolidate AIPlayForSub logic

* call preventRunAwayActivations earlier in Template

* Consolidate some logic

* Update LifeGainAi.java

* Update SurveilAi.java

---------

Co-authored-by: tool4EvEr <tool4EvEr@>
Co-authored-by: Hans Mackowiak <hanmac@gmx.de>
2025-07-29 16:11:03 +02:00
tool4ever
f5e96bc756 Streamline logic so canPlay always before canPay (#8234) 2025-07-29 07:35:18 +00:00
Chris H
7428b7420a Update dyadrine_synthesis_amalgam.txt (#8232) 2025-07-29 06:56:26 +02:00
kevlahnota
761d7848ef Merge pull request #8233 from kevlahnota/master2
fix SwingImageFetcher filename
2025-07-29 10:46:29 +08:00
Anthony Calosa
e9fc7899cd fix SwingImageFetcher filename 2025-07-29 10:44:57 +08:00
Chris H
df40fd5cb3 Convert checkApiLogic to AiAbilityDecision 2025-07-28 15:43:50 -04:00
Chris H
dce3b4b142 Thoguht i fixed this one already 2025-07-28 15:43:50 -04:00
Chris H
b20110edb4 Code review updatse 2025-07-28 15:43:50 -04:00
Chris H
4a05a66bc0 Update forge-ai/src/main/java/forge/ai/ability/VentureAi.java
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-07-28 15:43:50 -04:00
Chris H
39acc78fad Convert AiAbilityDecision to a record 2025-07-28 15:43:50 -04:00
Chris H
a0c58e2a1d Convert booleans to AiAbilityDecision objects to aid in decision making 2025-07-28 15:43:50 -04:00
Hans Mackowiak
c46ceca140 Update count_on_luck.txt
Remove wrong PT
2025-07-28 15:45:59 +02:00
tool4ever
4db0b6a67f Trigger fix (#8226) 2025-07-28 10:17:18 +02:00
tool4ever
38f6b699c6 Fix ward calculation when same card is targeted multiple times (#8222)
Co-authored-by: tool4EvEr <tool4EvEr@>
2025-07-28 07:36:36 +03:00
Paul Hammerton
9d80f4e78f Merge pull request #8221 from paulsnoops/edition-updates
Edition updates: TLA
2025-07-27 10:14:33 +01:00
Paul Hammerton
7dc95f8540 Edition updates: TLA 2025-07-27 10:13:32 +01:00
tool4ever
723ad5fe7c Update loyal_unicorn.txt 2025-07-27 08:17:56 +00:00
tool4ever
94aac494ea Update loyal_unicorn.txt 2025-07-27 08:17:25 +00:00
tool4ever
3e6b7af61f Update shaun_and_rebecca_agents.txt 2025-07-27 07:13:01 +00:00
Fulgur14
1574a88255 Create kravens_last_hunt.txt (#8220) 2025-07-27 07:11:39 +00:00
Renato Filipe Vidal Santos
2e2fea9182 SPM: 8 cards 2025-07-26 20:24:30 +00:00
kevlahnota
55549f1e70 Merge pull request #8218 from kevlahnota/master2
fix DualListBox Scrollbounds width and height
2025-07-26 21:56:21 +08:00
Anthony Calosa
71e97146ed fix DualListBox Scrollbounds width and height 2025-07-26 21:55:17 +08:00
tool4ever
35e4e580fa Cleanup duplicated field (#8217) 2025-07-26 12:09:09 +00:00
tool4ever
baab31d2e2 Rework Shared Fate (#8215) 2025-07-26 10:04:17 +00:00
Paul Hammerton
3f1295d9e4 Merge pull request #8216 from paulsnoops/edition-updates
Edition updates: SPM
2025-07-26 10:58:59 +01:00
Paul Hammerton
d759cc4e94 Merge pull request #8210 from Card-Forge/fix-cardrules-paths
Assign paths to CardRules so we can report where issues come from
2025-07-26 10:58:38 +01:00
Paul Hammerton
4c941df647 Friendly Neighborhood 2025-07-26 10:56:19 +01:00
Paul Hammerton
1f39ad4e91 Edition updates: SPM 2025-07-26 10:47:44 +01:00
Fulgur14
194e1d3356 Friendly Neighborhood (SPM) and its token (#8214) 2025-07-26 08:11:56 +00:00
Chris H
0aa8c933d8 Assign paths to CardRules so we can report where issues come from 2025-07-25 21:56:08 -04:00
Chris H
cf11802fbe Revert "Some handling for the 4 Arena cards that are no longer associated to …"
This reverts commit 7ccb925d76.
2025-07-25 21:25:22 -04:00
Chris H
2703cbc4c9 Restore revision versions 2025-07-25 19:54:42 -04:00
GitHub Actions
b87f3bd00b [maven-release-plugin] prepare for next development iteration 2025-07-25 19:54:42 -04:00
GitHub Actions
a1227167ea [maven-release-plugin] prepare release forge-2.0.05 2025-07-25 19:54:42 -04:00
Chris H
7ccb925d76 Some handling for the 4 Arena cards that are no longer associated to an edition file (#8207) 2025-07-25 19:10:12 -04:00
kevlahnota
beedd17cfe Update SFilterUtil.java
crash fix for Android
2025-07-26 07:07:55 +08:00
kevlahnota
332fa94dab Merge pull request #8065 from Eradev/BetterImageFetcherError
Better image fetcher error
2025-07-26 06:57:40 +08:00
kevlahnota
ae4b5be29f Merge pull request #8008 from Eradev/7859-DisplayTextTooltip
Allow the display of the placeholder in shops and reward windows.
2025-07-26 06:57:27 +08:00
Paul Hammerton
cc4a417c0a Merge pull request #8204 from paulsnoops/edition-updates
Edition updates: PF25, PH23, PLG24, PW25
2025-07-25 19:12:25 +01:00
Paul Hammerton
8a6e03e172 Edition updates: PF25, PH23, PLG24, PW25 2025-07-25 19:09:57 +01:00
Chris H
3ff0c740c4 Update orbital_plunge.txt (#8203) 2025-07-25 18:07:08 +00:00
Eradev
82f8a8f30b Merge remote-tracking branch 'origin/master' into BetterImageFetcherError 2025-07-25 12:37:44 -04:00
kevlahnota
2f7c315822 Merge pull request #8201 from kevlahnota/master2
try to fix dispose to clear more resource
2025-07-25 22:46:33 +08:00
Anthony Calosa
89b9c050a8 try to fix dispose to clear more resource 2025-07-25 22:41:31 +08:00
tool4ever
eb70e21f3d Update merieke_ri_berit.txt 2025-07-25 14:11:59 +00:00
Matthew Scott Krafczyk
ab2b06500b Better Games In Match Selection (#8098)
* Add GamesInMatch combo box selection to booster draft page

Also updated combo box default to be seeded with the stored preferences

* Working comboboxes for desktop version

* Working linked buttons on Mobile

* Add binder classes for preferences and other Model components

* Move to pref binders for mobile GUI
2025-07-25 14:07:19 +00:00
Hans Mackowiak
79845eff1d Update mystic_decree.txt
update Islandwalk to Landwalk:Island
2025-07-25 14:24:24 +02:00
Eradev
9d1b935643 Advanced filtering using the search box (#8077)
* Allow search by type and cmc

* Allow colon and added aliases to cmc

* Support negate

* Extract parser function into its own file

* Support for "!"

* Colors test

* Color search

* Oracle text

* Numeric p/t search

* Set search + fixes

* Typo

* Rarity check

* Loyalty

* Cleanup

* Case ignore for kw

* Support for "or"

* Rename method

* Support parentheses

* Add cases for l

* Cleanup

* Use PaperCardPredicates.printedInSet

* Fix in set to remove conjured cards

* Use func

* Remove redundant check
2025-07-25 11:06:40 +03:00
Fulgur14
ad0c81e984 Update alchemax_slayer_bots.txt (#8198)
* Update alchemax_slayer_bots.txt

* Update TypeLists.txt
2025-07-25 09:25:14 +02:00
Renato Filipe Vidal Santos
e86f4e80cb Spectacular Spider-Man: fixing typos 2025-07-25 05:06:08 +00:00
tool4ever
af4a6de809 Refactor Offering (#8199) 2025-07-25 05:02:57 +00:00
tool4ever
0d0fdd3c0b Update samis_curiosity.txt 2025-07-25 04:05:30 +00:00
Renato Filipe Vidal Santos
de4dcb19cf Quick cleanup: 2025-07-24 2025-07-25 03:54:46 +00:00
kevlahnota
cfcbbb5c21 Update README.md 2025-07-25 09:56:51 +08:00
kevlahnota
6d11361725 Merge pull request #8197 from kevlahnota/master2
refactor planechase BG fetcher
2025-07-25 09:18:02 +08:00
Anthony Calosa
924d9f57a6 minor cleanup 2025-07-25 09:10:32 +08:00
Anthony Calosa
8c5dfb61e7 refactor planechase fetcher 2025-07-25 08:44:21 +08:00
Renato Filipe Vidal Santos
895c5c1e65 SPM: 4 cards (#8194) 2025-07-24 19:14:47 +00:00
tool4ever
e64faa3cf2 Update patchwork_crawler.txt 2025-07-24 18:53:33 +00:00
Paul Hammerton
11815a4cf2 Merge pull request #8195 from paulsnoops/edition-updates
Edition updates: PURL, SPM
2025-07-24 18:51:37 +01:00
Paul Hammerton
d903e4d80d Edition updates: PURL, SPM 2025-07-24 18:47:54 +01:00
kevlahnota
6530515e98 Merge pull request #8193 from kevlahnota/master2
fix planechase bg download
2025-07-25 00:47:20 +08:00
kevlahnota
28711aa669 Merge pull request #8191 from Card-Forge/mkm-crash-fix
Update Murders at Karlov Manor.txt
2025-07-25 00:42:55 +08:00
Anthony Calosa
f3b2192dd2 fix planechase bg download 2025-07-25 00:36:42 +08:00
kevlahnota
d6451ae486 Update Murders at Karlov Manor.txt
fix crash sealed
2025-07-24 23:06:41 +08:00
tool4ever
a78c648e77 Fix Offering being an AltCost (#8190) 2025-07-24 14:33:51 +00:00
Fulgur14
b1afd28556 20 SPM/SPE cards plus Katara (July 24th, Batch 5) (#8184) 2025-07-24 12:45:53 +00:00
Fulgur14
82f5e17705 10 SPM/SPE cards (July 24th, Batch 4) (#8182) 2025-07-24 12:43:27 +00:00
Fulgur14
15e955576f 10 SPM/SPE cards (July 24th, Batch 1) (#8179) 2025-07-24 12:42:08 +00:00
Fulgur14
23b0fa09d9 10 SPM/SPE cards (July 24th, Batch 3) (#8181) 2025-07-24 12:36:18 +00:00
Fulgur14
34e31e7e29 11 SPM/SPE cards (July 24th, Batch 2) (#8180) 2025-07-24 12:34:54 +00:00
tool4ever
bd6ea12cc6 Update coercive_recruiter.txt 2025-07-24 10:10:47 +00:00
Fulgur14
10fa3f7f22 Removing RemoveIntrinsicAbilities$ (#8188) 2025-07-24 11:38:41 +02:00
kevlahnota
462b183548 Merge pull request #8187 from kevlahnota/master2
invert PT Box color
2025-07-24 16:13:21 +08:00
Paul Hammerton
4b5bf6fef4 Update Edge of Eternities.txt 2025-07-24 09:12:08 +01:00
Anthony Calosa
1f28e46e06 invert PT Box color 2025-07-24 15:58:03 +08:00
Paul Hammerton
990e515cb9 Merge pull request #8183 from paulsnoops/paulsnoops-patch-1
Edition updates: SLD, SPE, SPM
2025-07-24 08:26:37 +01:00
Paul Hammerton
6ee86f9762 Update Secret Lair Drop Series.txt 2025-07-24 08:25:02 +01:00
Paul Hammerton
41dfb3488c Create Marvel's Spider-Man.txt 2025-07-24 08:21:45 +01:00
Paul Hammerton
f61e1cd435 Edition updates: SPE, SPM 2025-07-24 08:17:29 +01:00
Fulgur14
1627503248 Origin of Spider-Man (SPM) (#8176) 2025-07-24 07:31:04 +02:00
kevlahnota
4c87c8a1ff update renderer for Spacecraft PT (#8178)
* update renderer for Spacecraft PT
2025-07-24 12:20:00 +08:00
kevlahnota
8036d4a553 Merge pull request #8175 from tool4ever/scpt
Basic renderer support for Spacecraft PT
2025-07-24 07:39:10 +08:00
kevlahnota
a9f18bbf48 Merge pull request #8177 from kevlahnota/newMaster
remove isNyx check
2025-07-24 07:35:40 +08:00
Anthony Calosa
64738f58d6 remove isNyx check 2025-07-24 07:33:42 +08:00
tool4ever
f426e9f236 Update plasma_bolt.txt 2025-07-23 21:29:25 +00:00
tool4EvEr
234237b43a Basic renderer support for Spacecraft PT 2025-07-23 19:11:47 +02:00
tool4ever
854d6640d1 Fix PlayEffect skipping some checks (e.g. split second on AI) (#8162) 2025-07-23 16:26:27 +00:00
Hans Mackowiak
c6514e0183 Update CopyPermanentEffect.java 2025-07-23 17:49:23 +02:00
Hans Mackowiak
9164e76f44 CopyPermanentEffect: fix DefinedName TokenKey 2025-07-23 17:49:23 +02:00
Hans Mackowiak
5cf155fb94 CardFactory: fix Squad TokenNames
Can be used for WH40K token

But FalloutToken need a fallback to Copy?
2025-07-23 17:49:06 +02:00
Renato Filipe Vidal Santos
11be569f35 Rename rukarumal_biologist.txt to rukarumel_biologist.txt (#8173) 2025-07-23 17:37:19 +02:00
kevlahnota
00412f6418 Merge pull request #8171 from kevlahnota/newMaster
QOL Groupby CardType Land
2025-07-23 22:13:43 +08:00
Anthony Calosa
c66e4a08e6 QOL Groupby CardType Land 2025-07-23 22:12:26 +08:00
kevlahnota
c22934f4af Merge pull request #8170 from kevlahnota/newMaster
fix Summon: Choco/Mog not importing
2025-07-23 21:27:46 +08:00
Anthony Calosa
2792c57405 fix Summon: Choco/Mog not importing 2025-07-23 21:26:19 +08:00
Eradev
e3637586d6 Revert "Add g_1_1_insect_flying token"
This reverts commit 0d2d01060d.
2025-07-23 06:53:50 +02:00
Hans Mackowiak
5787dfbca5 Update Edge of Eternities Commander.txt
Fix Insect Token
2025-07-23 06:31:31 +02:00
Fulgur14
9b80408bc6 Token wording update (July 2025 Comprehensive Rules) (#8160)
* Token wording update (July 2025 Comprehensive Rules)

* Update c_a_food_sac.txt

* Update c_a_treasure_sac.txt

* Update c_a_gold_sac.txt

* Update c_e_shard_draw.txt

* Update c_a_clue_draw.txt

* Update incubator_c_0_0_a_phyrexian.txt

* Update role_wicked.txt

* Update c_a_map_sac_explore.txt

* Update c_a_junk_sac_exileplay.txt

* Update c_a_blood_draw.txt

* Update elegy_acolyte.txt

* Update systems_override.txt

* Update survey_mechan.txt
2025-07-22 22:42:15 -04:00
Eradev
073f32c1c9 Update CM2 2025-07-22 21:42:36 -04:00
Eradev
6564e76aad Update CMR 2025-07-22 21:42:36 -04:00
Eradev
35563fe834 Update M21 2025-07-22 21:42:36 -04:00
Eradev
9b46581289 Update M20 2025-07-22 21:42:36 -04:00
Eradev
dbde27bc88 Update PM20 2025-07-22 21:42:36 -04:00
Eradev
b37c280bf8 Update M19 2025-07-22 21:42:36 -04:00
Eradev
643fc2106b Update CNS 2025-07-22 21:42:36 -04:00
Eradev
48496cfbbc Update CN2 2025-07-22 21:42:36 -04:00
Eradev
3022129fb5 Update CON 2025-07-22 21:42:36 -04:00
Eradev
5d0a7b5ef9 Update CM1 2025-07-22 21:42:36 -04:00
Eradev
fa1557c775 Update CMD 2025-07-22 21:42:36 -04:00
Eradev
cb47a9c4be Update CMM 2025-07-22 21:42:36 -04:00
Eradev
9e2ab76be3 Update CLB 2025-07-22 21:42:36 -04:00
Eradev
90c8f8e332 Germ token as Phyrexian Germ token has been printed 2025-07-22 21:42:36 -04:00
Eradev
63397dee07 Update CC2 2025-07-22 21:42:36 -04:00
Eradev
a602b1bdf2 Update CMA 2025-07-22 21:42:36 -04:00
Eradev
8653a26d38 Update CM2 2025-07-22 21:42:36 -04:00
Eradev
8ea5ac97a2 Upcate C19 2025-07-22 21:42:36 -04:00
Eradev
d72d36a8b9 Update C18 2025-07-22 21:42:36 -04:00
Eradev
664ce69993 Update C16 2025-07-22 21:42:36 -04:00
Eradev
93bca202bf Update C14 2025-07-22 21:42:36 -04:00
Eradev
72641e000b Update CSP 2025-07-22 21:42:36 -04:00
Eradev
36696f9b1b Update CST 2025-07-22 21:42:36 -04:00
Eradev
83bfe2a524 Update 6ED 2025-07-22 21:42:36 -04:00
Eradev
827a02563b Update CHR 2025-07-22 21:42:36 -04:00
Eradev
f06acf88f9 Update PCSP 2025-07-22 21:42:36 -04:00
Eradev
0f78751ce3 Update CHK 2025-07-22 21:42:36 -04:00
Eradev
c9fbd579b6 Update PCEL 2025-07-22 21:42:36 -04:00
Eradev
4e12f73444 Update BOK 2025-07-22 21:42:36 -04:00
Eradev
22f4a250e4 Update BBD 2025-07-22 21:42:36 -04:00
Eradev
ed6966b570 Update BFZ 2025-07-22 21:42:36 -04:00
Eradev
14c6794ee3 Update APC 2025-07-22 21:42:01 -04:00
Eradev
9494321965 Update E01 2025-07-22 21:42:01 -04:00
Eradev
34d009a458 Update ARN 2025-07-22 21:42:01 -04:00
Eradev
ac5128d133 Update ACR 2025-07-22 21:42:01 -04:00
Eradev
12c487f7b8 Update PAVR 2025-07-22 21:42:01 -04:00
Eradev
285417275d Update AVR 2025-07-22 21:42:01 -04:00
Eradev
f2db114cb6 Update APC 2025-07-22 21:42:01 -04:00
Eradev
87226d9bd9 Update ATH 2025-07-22 21:42:01 -04:00
Eradev
a644a4c7bc Update ATQ 2025-07-22 21:42:01 -04:00
Eradev
462bdf19b9 Update MPS_AKH 2025-07-22 21:42:01 -04:00
Eradev
3d9bb1f437 Update PAKH 2025-07-22 21:42:01 -04:00
Eradev
485d2dbaf8 Update ALL 2025-07-22 21:42:01 -04:00
Eradev
8f8abdbab9 Update YOTJ 2025-07-22 21:42:01 -04:00
Eradev
7ebe74e57c Update PARB 2025-07-22 21:42:01 -04:00
Eradev
b45153bee8 Update DFT 2025-07-22 21:42:01 -04:00
Eradev
55c4d4240f Update AER 2025-07-22 21:42:01 -04:00
Eradev
0d2d01060d Add g_1_1_insect_flying token 2025-07-22 21:41:36 -04:00
kevlahnota
f84237f25b Merge pull request #8163 from Drecon84/master
Re-adding item to New Game+ Adventure
2025-07-23 06:38:09 +08:00
kevlahnota
07cff6f9a9 Merge pull request #8164 from kevlahnota/newMaster
update SettingsScene landscape checkbox
2025-07-23 06:35:49 +08:00
Anthony Calosa
9f7852e76f update SettingsScene landscape checkbox 2025-07-23 06:29:58 +08:00
Drecon84
943d6edabd Re-adding item to New Game+ Adventure
When I put in the code to delete quest items on a new game+ I forgot to re-add the colorless rune in case you start without the main quest (you get it as part of the main quest). This fixes that.
2025-07-22 21:06:58 +02:00
Matthew Krafczyk
800b88911a Fix draft slot definitions 2025-07-22 14:07:03 -04:00
Matthew Krafczyk
dccbd9912d Small mistakes correction 2025-07-22 14:07:03 -04:00
Matthew Krafczyk
b5f696756e Fix EOS set name 2025-07-22 14:07:03 -04:00
Matthew Krafczyk
9ff528029a Fix draft ranking set codes 2025-07-22 14:07:03 -04:00
Matthew Krafczyk
44046b475b Add EOE to blocks 2025-07-22 14:07:03 -04:00
Matthew Krafczyk
65959f9089 Draft definitions for EOE 2025-07-22 14:07:03 -04:00
Paul Hammerton
94d87039e3 Merge pull request #8161 from paulsnoops/update-draft-ranking
Update draft rankings: DFT, FIN, PIO, TDM
2025-07-22 18:23:49 +01:00
Paul Hammerton
d3a13d4515 Update draft rankings 2025-07-22 18:14:19 +01:00
kevlahnota
b63bee045f Merge pull request #8157 from kevlahnota/newMaster
Prevents crashes when calculating soft buttons bar height
2025-07-22 19:21:24 +08:00
Anthony Calosa
977d46bca5 Prevents crashes when calculating soft buttons bar height 2025-07-22 19:17:57 +08:00
Hans Mackowiak
8293d4de63 Update Edge of Eternities.txt
Add Emblem
2025-07-22 10:41:06 +02:00
Renato Filipe Vidal Santos
94feb1b63b Add files via upload 2025-07-22 09:37:14 +02:00
Renato Filipe Vidal Santos
e37dac6cbe Update giott_king_of_the_dwarves.txt 2025-07-22 09:36:51 +02:00
tool4ever
c7b98bc578 Restore some fixes (#8154) 2025-07-22 06:18:36 +00:00
tool4ever
7d4369fdca Cast after warping only for owner (#8148)
* Cast after warping only for owner

* give effect to owner

---------

Co-authored-by: tool4EvEr <tool4EvEr@>
2025-07-22 08:23:57 +03:00
kevlahnota
28cb9f9d7d Merge pull request #8152 from kevlahnota/newMaster
fix CardRules setColorID reset
2025-07-22 11:21:02 +08:00
Anthony Calosa
94e3c71809 fix CardRules setColorID reset 2025-07-22 11:19:26 +08:00
Chris H
5dd6a5b45a Revert "Consolidate some PlayEffect logic (#8133)"
This reverts commit 514d40aefd.
2025-07-21 22:03:17 -04:00
kevlahnota
e486f846d8 Merge pull request #8150 from kevlahnota/newMaster
update some dialog translation, KeyBoardDialog
2025-07-22 09:27:00 +08:00
kevlahnota
e7793764a6 Merge pull request #8146 from Drecon84/master
Fix for red castle
2025-07-22 09:01:43 +08:00
Anthony Calosa
5aea2e5bbe update some dialog translation, KeyBoardDialog 2025-07-22 08:58:12 +08:00
Paul Hammerton
f52410f2f8 Merge pull request #8149 from paulsnoops/eoe-historic-bans
EOE Historic bans
2025-07-21 22:00:06 +01:00
Paul Hammerton
53e2f199cc EOE Historic bans 2025-07-21 21:55:48 +01:00
Drecon84
f86e9a56d1 Merge branch 'Card-Forge:master' into master 2025-07-21 20:26:34 +02:00
tool4ever
31ebe48bf3 Update diplomatic_relations.txt 2025-07-21 17:15:09 +02:00
Drecon84
ff963b2cb9 Fix for red castle
Hard mode didn't have the defeat dialogue because it spawned a different version of Lathliss without the defeat code.
2025-07-21 16:45:41 +02:00
kevlahnota
9a6ebce85a Increase MemoryStack
should prevent Out of stack space when exporting the large inventory of cards to clipboard, though not tested for the whole card database
2025-07-21 22:22:48 +08:00
kevlahnota
eb5e37e3de Merge pull request #8145 from kevlahnota/newMaster
fix Rewarded Deck dialogs
2025-07-21 18:42:22 +08:00
Anthony Calosa
92b96aea75 fix Rewarded Deck dialogs 2025-07-21 18:37:07 +08:00
kevlahnota
0f4c0488d5 Merge pull request #8144 from kevlahnota/newMaster
adjust playersprite spawn point on new game
2025-07-21 17:17:10 +08:00
Anthony Calosa
6879089149 adjust playersprite spawn point on new game 2025-07-21 17:10:05 +08:00
tool4ever
3e2eb86bd4 Update dockworker_drone.txt 2025-07-21 07:53:47 +02:00
tool4ever
84ff75c9cf Update frontline_war_rager.txt 2025-07-21 07:52:30 +02:00
tool4ever
9d3605ee96 RepeatEach refactoring (#8139)
* RepeatEach cleanup

* RepeatEach cleanup

---------

Co-authored-by: tool4EvEr <tool4EvEr@>
2025-07-21 07:22:40 +03:00
Chris H
83cd6b7291 Update wheel_of_sun_and_moon.txt 2025-07-21 06:18:20 +02:00
tool4ever
514d40aefd Consolidate some PlayEffect logic (#8133)
* Fix potential GUI lock if game ends during RepeatEffect

* Fix casting Feast of Blood from PlayEffect without creatures in play
2025-07-20 10:35:03 +00:00
Northmoc
31cca02d8d Flavor for Equip 2025-07-20 09:30:00 +02:00
Hans Mackowiak
5fbd2f9552 Devour: better keyword 2025-07-20 07:45:35 +02:00
Eradev
7ee0431a2f Fix Territorial Bruntar 2025-07-20 06:41:11 +02:00
Eradev
0786403fff Support code2 and alias in sheets (#8009)
* LF

* Support for Code2 and Aliases in sheets

* Support for Code2 and Aliases in sheets

* TryConvertingName

* Revert changes

* Update CardEdition.java

* Wrong check
2025-07-20 07:37:04 +03:00
Renato Filipe Vidal Santos
4f7dbfbc80 Add files via upload (#8004) 2025-07-20 07:36:45 +03:00
Eradev
6caf02fc77 Update Arena sets (#8000)
* Update ANB

* Add XANA

* Update ANA

* Add OANA

* Update G18
2025-07-20 07:36:17 +03:00
Chris Dietsch
9dedc9ecfa Update ISSUES.txt (#8129) 2025-07-20 07:35:23 +03:00
lemtom
b62434616a New 16x16 sprites and avatars for planeswalkers &c. (#8048)
* New sprites that fit established aesthetic

* Adjustments

* Remove downscale + fix wrong pixel on Sorin

---------

Co-authored-by: Agetian <stavdev@mail.ru>
2025-07-20 07:35:14 +03:00
Eradev
ad8f3ea06f Fix Lobelia 2025-07-19 22:09:08 -04:00
Renato Filipe Vidal Santos
dbed505282 Quick cleanup: 2025-07-19, pass 2 2025-07-19 20:18:24 +00:00
Renato Filipe Vidal Santos
1468746045 Quick cleanup: 2025-07-18, pass 3 (again) (#8124) 2025-07-19 14:44:09 +00:00
Paul Hammerton
6841b31849 Merge pull request #8125 from paulsnoops/eoe-sections
EOE Edition Sections
2025-07-19 15:19:37 +01:00
Paul Hammerton
a151dff3c5 EOE Edition Sections 2025-07-19 15:15:48 +01:00
Paul Hammerton
90f6e2b17f Migrate EOE card scripts 2025-07-19 14:28:57 +02:00
Renato Filipe Vidal Santos
7b1e96410f Add files via upload (#8119) 2025-07-19 11:29:28 +00:00
Paul Hammerton
7ecf619b94 Merge pull request #8122 from paulsnoops/decode-transmissions-name
Fix Decode Transmissions name
2025-07-19 12:10:23 +01:00
Paul Hammerton
b1d8b6fd5c Fix Decode Transmissions name 2025-07-19 12:08:15 +01:00
Paul Hammerton
a15a990730 Merge pull request #8121 from paulsnoops/eoe-formats
EOE Formats update
2025-07-19 12:01:51 +01:00
Paul Hammerton
7402aab2a8 EOE Formats update 2025-07-19 11:53:16 +01:00
Paul Hammerton
2a68427c82 Merge pull request #8120 from paulsnoops/edition-updates
Edition updates: EOC, EOE, EOS, SCH
2025-07-19 11:24:04 +01:00
Paul Hammerton
14dd9721e3 SCH 2025-07-19 11:20:46 +01:00
Paul Hammerton
6115eaf6da EOE 2025-07-19 11:11:42 +01:00
Paul Hammerton
b4922ce353 EOS 2025-07-19 11:06:39 +01:00
Paul Hammerton
0fb37bf2d4 DRAFT: Edition updates 2025-07-19 11:02:20 +01:00
Eradev
8ce5272e95 More console commands (#8096) 2025-07-19 08:33:43 +00:00
Fulgur14
08135545da Final EOE batch (part 4) (#8112) 2025-07-19 07:57:37 +00:00
Fulgur14
3cdbb8f1dd Final EOE batch (part 3) (#8106) 2025-07-19 07:57:24 +00:00
Fulgur14
4f662a5651 Final EOE batch (part 2) (#8105) 2025-07-19 07:56:02 +00:00
Fulgur14
0e0811a1ac Final EOE batch (part 1) (#8103) 2025-07-19 07:51:55 +00:00
Renato Filipe Vidal Santos
71882fe83c EOE: Memorial Vault (#8108) 2025-07-18 20:32:30 +00:00
Northmoc
fce67b847c moxite_refinery.txt and support (#7997) 2025-07-18 14:48:48 +02:00
Renato Filipe Vidal Santos
2ff0c6b92d Add files via upload (#8102) 2025-07-18 12:10:30 +02:00
Paul Hammerton
b27b8b7ba5 Merge pull request #8101 from paulsnoops/master
Edition updates: EOE, EOS, SLD
2025-07-18 10:16:14 +01:00
Paul Hammerton
f889abd57a Update Secret Lair Drop Series.txt 2025-07-18 10:11:28 +01:00
Paul Hammerton
1d2852fff6 Update Edge of Eternities Stellar Sights.txt 2025-07-18 10:03:29 +01:00
Paul Hammerton
48247f7d3b Edition updates 2025-07-18 09:58:56 +01:00
Eradev
d3e6932a23 Fix Dionus' power (#8100) 2025-07-18 10:40:10 +02:00
Renato Filipe Vidal Santos
e4d3e061d1 Quick cleanup: 2025-07-18 (#8099) 2025-07-18 09:32:27 +02:00
Eradev
e57708543a Back to quest list button fix (#8094) 2025-07-18 09:32:11 +02:00
Renato Filipe Vidal Santos
69e2f90c8d EOE: 2 cards (#8097) 2025-07-18 05:49:37 +00:00
shenshinoman
655d01114c Cleaning up Innistrad structure (#8058)
* Cleaning up the file structure to move all Innistrad maps under the Innistrad folder, as well as some minor logic change to Shandalar Old Border's config.json to make maintenance easier. (By setting the desired sets in allowedEditions, we no longer have to restrict every new edition as it comes in.)

Finally, added block info for Alchemy: Innistrad, so it should start being available in events as well.

* Cleaning up the file structure to move all Innistrad maps under the Innistrad folder, as well as some minor logic change to Shandalar Old Border's config.json to make maintenance easier. (By setting all the desired sets to be viewed in allowedEditions, it will only shows those, and we no longer have to restrict every new edition as it comes in.) Also fixed a bug making the "Ghost Town" not work in Shandalar Old Border

Finally, added block info for Alchemy: Innistrad, so it should start being available in events as well.

* Update Adventure - Guardian Gladiolus.dck

---------

Co-authored-by: Hans Mackowiak <hanmac@gmx.de>
2025-07-17 17:29:54 -04:00
Eradev
0d40508e69 Remove conjured cards from rewards 2025-07-17 17:12:11 -04:00
Fulgur14
b785a84dca Mm'menon, Uthros Exile and Pull Through the Weft (EOE) (#8093) 2025-07-17 19:16:32 +00:00
tool4ever
14af90cd27 Henzie day: fix copied spell gaining Blitz (#8092) 2025-07-17 18:57:07 +00:00
Fulgur14
0278918886 Blade of the Swarm (EOE) (#8090) 2025-07-17 17:20:27 +00:00
Fulgur14
b44738cda3 5 EOE cards (July 17th) (#8089) 2025-07-17 16:23:48 +00:00
Fulgur14
ddbe2d6051 3 EOE cards (July 17th) (#8087) 2025-07-17 16:22:30 +00:00
loud1990
a15ebe86db Cleaned up mechan_assembler and weftstalker_ardent triggerzones (#8088) 2025-07-17 16:32:05 +02:00
kevlahnota
16225d2894 Merge pull request #8086 from kevlahnota/newMaster
fix enter key and textfield keypress collision
2025-07-17 20:03:17 +08:00
Anthony Calosa
b4c87a198a fix enter key and textfield keypress collision 2025-07-17 20:02:06 +08:00
Eradev
38da204607 Try to use current set when creating a card from an effect (#8080)
* Fix CardDb fallback
2025-07-17 11:20:15 +00:00
kevlahnota
dbe410f8af Merge pull request #8084 from kevlahnota/newMaster
fix GamePad mapping
2025-07-17 19:18:49 +08:00
Anthony Calosa
b05eb4eed3 fix GamePad mapping 2025-07-17 19:17:36 +08:00
kevlahnota
02201c4527 Merge pull request #8083 from kevlahnota/newMaster
update keybinding for NewGameScene
2025-07-17 19:03:30 +08:00
Anthony Calosa
6536d39969 update keybinding for NewGameScene 2025-07-17 18:59:59 +08:00
Paul Hammerton
c9b41c2b81 Merge pull request #8082 from paulsnoops/paulsnoops-patch-1
Edition updates: EOE, EOS, SPG
2025-07-17 08:38:22 +01:00
Paul Hammerton
74e587a8a0 Update Special Guests.txt 2025-07-17 08:35:13 +01:00
Paul Hammerton
a751ad186e Update Edge of Eternities Stellar Sights.txt 2025-07-17 08:33:26 +01:00
Paul Hammerton
bae41478d9 Edition updates 2025-07-17 08:27:08 +01:00
Renato Filipe Vidal Santos
10dbafbe8c EOE: 4 cards (#8079) 2025-07-16 19:54:02 +00:00
Fulgur14
504946f72a Pinnacle Kill-Ship (EOE) (#8078) 2025-07-16 19:29:48 +00:00
Valensior
e45ae205ac Dauntless Scrapbot [EOE] (#8076) 2025-07-16 18:30:05 +00:00
Fulgur14
4a5969157d 6 EOE cards (July 16th) (#8075) 2025-07-16 17:55:38 +00:00
Fulgur14
bdda4d50f7 Create steelswarm_operator.txt (#8074) 2025-07-16 14:16:42 +00:00
tool4ever
f565943d8d Fix cost syntax (#8073) 2025-07-16 13:02:47 +00:00
Fulgur14
3158c0b1d9 Hymn of the Faller (EOE) (#8072) 2025-07-16 12:57:18 +00:00
Fulgur14
4346d83582 Update atmospheric_greenhouse.txt (#8071) 2025-07-16 06:58:57 +00:00
Fulgur14
7e016f4ca5 6 EOE cards (July 15th) (#8067) 2025-07-16 06:25:09 +00:00
Valensior
38242d0226 [EOE] Atmospheric Greenhouse & Cryogen Relic (#8064) 2025-07-16 07:58:11 +02:00
Eradev
b565095136 Stop spamming key is malformed. 2025-07-15 15:14:06 -04:00
Eradev
93b5fd5f3e Early stop if file exists. Display missing file location. 2025-07-15 15:07:37 -04:00
Eradev
8ca03c1f50 Set output as error 2025-07-15 15:06:36 -04:00
Hans Mackowiak
f5204b89fb lf 2025-07-15 19:53:49 +02:00
Fulgur14
b9dc63b3df Devastating Onslaught (EOE) (#8062) 2025-07-15 17:29:35 +00:00
Valensior
86910302dc Update famished_worldsire.txt (#8063) 2025-07-15 17:20:32 +00:00
Fulgur14
a0cca65075 3 EOE cards (July 15th) (#8060) 2025-07-15 16:56:40 +00:00
Fulgur14
0cc2c3b275 World Shaper EOC Commander Deck (#8011) 2025-07-15 17:22:43 +02:00
Eradev
2cb4856dc7 Daily EOE Update (2025-07-14) (#8006) 2025-07-15 17:22:16 +02:00
Fulgur14
88a53226a2 Create station_monitor.txt (#8057) 2025-07-15 16:49:09 +02:00
Fulgur14
1d42ab50c7 Desculpting Blast (EOE) (#8055) 2025-07-15 15:09:33 +02:00
Fulgur14
cf10851c78 Create meltstrider_eulogist.txt (#8054) 2025-07-15 14:56:05 +02:00
Fulgur14
c1727ffb3f Quantum Riddler (EOE) (#8047) 2025-07-15 13:58:55 +02:00
Fulgur14
43d79c024e Warp/Void EOE scripts, part 3 (#8041) 2025-07-15 12:14:50 +02:00
Fulgur14
3fcf200a86 Warp/Void card scripts, part 4 (#8045) 2025-07-15 11:40:25 +02:00
Fulgur14
8bc5588342 Warp/Void EOE scripts, part 2 (#8039) 2025-07-15 10:28:27 +02:00
Fulgur14
ab27b613e3 Warp/Void EOE scripts, Part 1 (#8038) 2025-07-15 10:25:33 +02:00
tool4ever
c6816dbe74 Close Encounter and support (#8040) 2025-07-15 09:25:32 +02:00
Eradev
41e43a8441 Change PHJ to JP1 (#8044) 2025-07-15 09:23:42 +02:00
Eradev
ff91114f39 Merge branch 'master' into 7859-DisplayTextTooltip 2025-07-14 22:00:22 -04:00
Eradev
b3951555a1 Remove tokens 2025-07-14 20:37:12 -04:00
Eradev
f3a68e940e Update tokens 2025-07-14 20:37:12 -04:00
Eradev
1d646753f2 J21 Update 2025-07-14 20:37:12 -04:00
tool4ever
b293700b13 Fix more MustBlockAi trigger misses (#8037) 2025-07-14 19:03:47 +00:00
Hans Mackowiak
ea2e0fa3e6 Keyword: Warp (#7914)
* Keyword: Warp

* Add Timeline Culler

* Player: remove revolt variable

* AbilityUtils: add Void Modifier

* Improve logic

* Fix import

---------

Co-authored-by: TRT <>
2025-07-14 21:03:36 +02:00
Eradev
bad55a173d Planar Conquest fixes (#8033)
* Only add commanders once. Fix REPRINT_SET_TYPES check.

* Cards.txt example

* Update Rhox Faithmender

---------

Co-authored-by: Agetian <stavdev@mail.ru>
2025-07-14 19:37:01 +03:00
tool4ever
69538f248d Fix MustBlockAi leaving stuff tapped (#8036) 2025-07-14 16:31:30 +00:00
Agetian
c2f4736f08 AI hint for Olivia's Wrath (#8035)
* - Add puzzles PS_TDM4-5, PS_FIN1-3.

* - Add AI hint for Olivia's Wrath.
2025-07-14 19:28:07 +03:00
Eradev
9aa142ba5a Update S00 (#8030)
Co-authored-by: Agetian <stavdev@mail.ru>
2025-07-14 18:57:48 +03:00
Eradev
f4aba94a18 Fix token generation in puzzles (#8031)
* Fix token generation

---------

Co-authored-by: Hans Mackowiak <hanmac@gmx.de>
2025-07-14 15:23:49 +02:00
kevlahnota
910c06b4d2 Merge pull request #8032 from kevlahnota/newMaster
add restart dialog on World selectbox
2025-07-14 20:44:44 +08:00
Anthony Calosa
490a9b1693 add restart dialog on World selectbox 2025-07-14 20:38:36 +08:00
tool4ever
f6a8705849 Update genestealer_patriarch.txt
Closes #8029
2025-07-14 13:24:42 +02:00
kevlahnota
df2f1105c1 Merge pull request #8023 from kevlahnota/newMaster
update libs for LibGDX 1.13.5
2025-07-14 05:36:38 +08:00
Renato Filipe Vidal Santos
acaf683166 EOE: 2 cards (#8028) 2025-07-13 18:43:19 +00:00
tool4ever
1c6b256268 Fix Spacecraft type collision (#8024) 2025-07-13 18:39:06 +00:00
Agetian
d59ec1527d - Add puzzles PS_TDM4-5, PS_FIN1-3. (#8027) 2025-07-13 20:22:14 +03:00
Anthony Calosa
4b6e46ab7d update libs for LibGDX 1.13.5
update gdx-controllers
2025-07-13 22:27:01 +08:00
Renato Filipe Vidal Santos
68b949bdbf EOE: 3 cards 2025-07-13 14:25:48 +00:00
Fulgur14
a49cc1db97 Update Adventure - Guardian Gladiolus.dck 2025-07-13 10:00:16 -04:00
Simisays
701cc31e1c Update config.json (#8019) 2025-07-13 12:37:22 +03:00
kevlahnota
8832920a4d Merge pull request #8020 from kevlahnota/newMaster
revert TextraTypist
2025-07-13 17:21:07 +08:00
Anthony Calosa
d044d0dc65 revert TextraTypist 2025-07-13 17:12:00 +08:00
Hans Mackowiak
e7427bb180 lf 2025-07-13 10:27:30 +02:00
Fulgur14
989acaa7d4 Lightstall Inquisitor (EOE) (#8018) 2025-07-13 08:19:17 +00:00
tool4ever
6351ea2593 Update lara_croft_tomb_raider.txt 2025-07-13 07:29:29 +00:00
tool4ever
1a586f07d1 Update fraying_sanity.txt 2025-07-13 07:26:42 +00:00
tool4ever
69ec802299 Update ravenous_trap.txt 2025-07-13 07:25:57 +00:00
Hans Mackowiak
817b72f67f lf 2025-07-13 09:10:45 +02:00
Fulgur14
cf1398606b 2 EOE cards (13th July) (#8017) 2025-07-13 07:01:56 +00:00
Fulgur14
31d733aacb Update scouring_swarm.txt (#8014) 2025-07-13 06:11:13 +00:00
kevlahnota
77544f855b Merge pull request #8016 from kevlahnota/newMaster
minor cleanup
2025-07-13 13:44:59 +08:00
Anthony Calosa
1be4880776 fix overlayLabel background 2025-07-13 13:39:53 +08:00
Anthony Calosa
ff39f82099 minor cleanup 2025-07-13 12:52:53 +08:00
shenshinoman
200e509cda Adding extra Planes to Adventure mode and providing an easy method to swap between them. (#7932)
* updating local project

* updating local project

* updating local project

* updating local project

* Update Config.java

updating the file with the better change made by Jetz

* Merge remote-tracking branch 'origin/master'

* Merge remote-tracking branch 'origin/master'

* Merge remote-tracking branch 'origin/master'

* Merge remote-tracking branch 'origin/master'
2025-07-12 21:21:25 -04:00
tool4ever
6a70c6705d Update orims_thunder.txt 2025-07-12 20:52:09 +00:00
kevlahnota
6749e5de7e fix crash (#8013)
* fix illegalargument TextButtonStyles
2025-07-12 23:48:35 +08:00
Eradev
9b83c7eeec Disable the art in the text version 2025-07-12 08:52:15 -04:00
kevlahnota
1c8f7eccbe Update RewardActor (#8012)
* add sell icon

* update RewardActor
2025-07-12 20:03:25 +08:00
kevlahnota
13c98c68e9 update TextraTypist (#8010)
* update TextraTypist

* use pixelmana atlas

* fix variable init
2025-07-12 18:43:03 +08:00
Hans Mackowiak
d492cff553 lf 2025-07-12 10:25:13 +02:00
Fulgur14
875bd54c21 Attempt at Eumidian Wastewaker 2025-07-12 08:13:03 +00:00
Eradev
9825bebb75 Merge branch 'master' into 7859-DisplayTextTooltip 2025-07-11 21:57:48 -04:00
Fulgur14
f2ab574a3b Weftwalking and Monoist Circuit-Feeder (EOE) (#8007) 2025-07-11 19:22:40 +00:00
Eradev
94babc2c53 Fix display 2025-07-11 13:34:13 -04:00
Jetz
4e42963033 Add fantasyBlock support for allowedJumpstart 2025-07-11 12:16:25 -04:00
Jetz
6fec40522e Use code instead of name for filtering drafts 2025-07-11 12:16:25 -04:00
Jetz
eea9890f9d Change allowedJumpstart to override default selection. 2025-07-11 12:16:25 -04:00
Jetz
89d1cffc12 Add allowedJumpstart support to config. 2025-07-11 12:16:25 -04:00
Jetz
40f168bf1e Add restrictedEvents support to config. 2025-07-11 12:16:25 -04:00
Jetz
891a098d2a Per-plane configs 2025-07-11 12:16:25 -04:00
Fulgur14
b6c0d86945 Sami's Curiosity (EOE) (#8005) 2025-07-11 15:29:53 +00:00
Eradev
2cb69c2d6e Allow display of text in tooltip in shops 2025-07-11 11:29:32 -04:00
Eradev
9a96760061 LF 2025-07-11 11:27:12 -04:00
Renato Filipe Vidal Santos
d4a484522e YTDM: 13 more cards (#7486) 2025-07-11 14:59:15 +00:00
Fulgur14
7a24b5cd0c 4 EOE cards (10th July) (#7990)
* Support The Dominion Bracelet
2025-07-11 13:45:04 +00:00
Fulgur14
c0e34799c8 5 EOE cards (11th July) (#8003) 2025-07-11 13:17:22 +00:00
Fulgur14
964d500414 9 EOC + 3 EOE cards (#7991) 2025-07-11 11:19:38 +00:00
Fulgur14
e2949b66fc Create kavaron_harrier.txt (#7999) 2025-07-11 08:34:35 +00:00
Paul Hammerton
06fcb531cd Merge pull request #7993 from Eradev/UpdateEOE20250710
Edge of Eternities Daily Update
2025-07-11 09:15:55 +01:00
Fulgur14
923b12caa0 Hemosymbic Mite (EOE) (#7998) 2025-07-11 08:02:50 +02:00
Chris H
69d75489e7 Fix Bands with other for humans 2025-07-10 22:47:36 -04:00
Eradev
9e985ff471 Edge of Eternities Daily Update 2025-07-10 14:19:52 -04:00
Hans Mackowiak
47390abf3b Update susur_secundi_void_altar.txt
fix Svar SusurDraw
2025-07-10 14:43:04 +02:00
tool4ever
59484f30b5 Fix Keepers (#7988)
* Fix Keepers

* Fix Keepers

---------

Co-authored-by: TRT <>
2025-07-10 15:14:26 +03:00
Eradev
e36701a9f3 Fix Klement, Knowledge Acolyte (#7987) 2025-07-10 12:52:53 +02:00
tool4ever
03b6567993 Fix Seek the Beast for Adventures (again) (#7986) 2025-07-10 11:31:33 +02:00
Eradev
56ef1a1df5 Encode token url (#7983)
* Update 40K

* Apply UTF-8 encoding to tokens too
2025-07-10 10:35:49 +02:00
Fulgur14
6d4af69c19 9 EOC cards (#7982) 2025-07-10 10:31:29 +02:00
Paul Hammerton
b8bd9d92a7 Merge pull request #7985 from Card-Forge/paulsnoops-patch-1
Edition updates: EOC, EOE, EOS, SPG
2025-07-10 09:29:06 +01:00
Paul Hammerton
6a4018f206 oops lands 2025-07-10 09:25:59 +01:00
Paul Hammerton
986b44af43 Update Edge of Eternities.txt 2025-07-10 09:22:46 +01:00
Paul Hammerton
64e6dbad13 ooops space 2025-07-10 09:17:54 +01:00
Paul Hammerton
2e559effcb Update Edge of Eternities Commander.txt 2025-07-10 09:17:15 +01:00
Paul Hammerton
d02f755fa7 Update Edge of Eternities Stellar Sights.txt 2025-07-10 09:14:53 +01:00
Paul Hammerton
17ffda684f Edition updates: EOC, EOE, EOS, SPG 2025-07-10 09:09:35 +01:00
Fulgur14
d6cd2f35ff 2 EOE cards (#7984) 2025-07-10 10:03:45 +02:00
tool4ever
81bba70548 Update monstrous_vortex.txt 2025-07-10 08:49:55 +02:00
Fulgur14
831a2d23e4 7 EOE cards (#7980) 2025-07-10 07:54:13 +02:00
Hans Mackowiak
a0f15cdcb1 lf 2025-07-09 21:04:57 +02:00
tool4ever
e882bd8264 The Eternity Elevator not allowed as Commander (#7978) 2025-07-09 11:45:47 +02:00
Eradev
7101d638c6 Update PRM, TD0, TD1, EOE, EOC (#7976) 2025-07-09 10:58:14 +02:00
Fulgur14
865e3dd783 Update octavia_living_thesis.txt 2025-07-09 10:12:24 +02:00
Fulgur14
b1c992db26 Adagia and Kavaron (EOE) (#7974) 2025-07-09 10:07:42 +02:00
Fulgur14
58f79ae6c0 18 EOE + 2 EOC cards (#7971) 2025-07-09 09:40:02 +02:00
Eradev
fd5af3c93e Fix Meld cards in FIN (#7973) 2025-07-09 05:39:48 +00:00
tool4ever
127d0fced6 Dyadrine, Synthesis Amalgam and support (#7970)
Co-authored-by: tool4EvEr <tool4EvEr@>
2025-07-09 07:28:04 +03:00
Eradev
6526d736bf Prefer random token from set (#7961)
* Prefer random token from set

* Aoivd the array cost

* Forgot import

* ImageUtil

* Fix some tokens
2025-07-09 07:21:09 +08:00
Eradev
cc4a43f0a2 Fix typo (#7955)
* Fix typo

* Support old save files
2025-07-09 07:20:16 +08:00
Fulgur14
286ade792f 12 EOE cards (#7967) 2025-07-08 18:45:18 +00:00
Fulgur14
e681775f47 Update frenzied_baloth.txt (#7969) 2025-07-08 18:38:28 +00:00
Fulgur14
67a9a2c34a 10 EOE cards (#7963) 2025-07-08 18:20:35 +00:00
Eradev
88c0cc00bc Missing emblems + Core sets update (#7966) 2025-07-08 17:51:41 +00:00
kevlahnota
f16f153448 Merge pull request #7968 from Card-Forge/kevlahnota-fix-Rug-of-Smothering
Fix Crash for Rug of Smothering
2025-07-08 22:03:50 +08:00
kevlahnota
1f93dcf5db Update uthros_scanship.txt
- closes #7965
2025-07-08 22:02:44 +08:00
kevlahnota
783fff300d Update AbilityUtils.java 2025-07-08 21:29:53 +08:00
kevlahnota
935e4a00d5 Fix Crash for Rug of Smothering
TriggeredActivator not defined on AbilityUtils calculateAmount, hence produces ClassCastException.
2025-07-08 21:03:39 +08:00
Eradev
6986b5a53d Replace unsupported cards + fix Theros (#7964) 2025-07-08 11:25:20 +02:00
Eradev
e6ed31e9d9 Change Elemental Resonance so it targets CMC>0 (#7962) 2025-07-08 09:26:19 +02:00
Eradev
288c845116 Remove deprecated between to us of (#7951) 2025-07-08 08:39:50 +03:00
Eradev
597222dbf5 Non-alchemy sets cleanup (#7954) 2025-07-08 08:39:17 +03:00
tool4ever
cea6eeabba Update gonti_lord_of_luxury.txt 2025-07-07 15:17:51 +00:00
Eradev
8475456c0b Add missing radiation token (#7948) 2025-07-07 08:51:41 +00:00
Fulgur14
651caccd71 Dawnsire, Sunstar Dreadnought (EOE) (#7958) 2025-07-07 06:18:15 +00:00
kevlahnota
8e9fb8570e Merge pull request #7957 from Eradev/FixEncodingAndroidCompatible
Encode collector number + fallback
2025-07-07 12:55:15 +08:00
Eradev
5a183a6042 Merge branch 'master' into FixEncodingAndroidCompatible 2025-07-07 00:14:02 -04:00
kevlahnota
67e6a7aa1a Merge pull request #7953 from kevlahnota/master2
fix W and S keys for TextField input
2025-07-07 12:09:28 +08:00
Anthony Calosa
b76c67f309 fix comment 2025-07-07 12:08:10 +08:00
Anthony Calosa
99c6b6d815 add comment 2025-07-07 12:06:35 +08:00
Eradev
cadc39699d Encode collector number + fallback 2025-07-07 00:05:37 -04:00
Chris H
8c06aab7b3 Revert "Encode UTF-8 symbols in collector number (#7923)"
This reverts commit fb69f245da.
2025-07-06 22:19:43 -04:00
Anthony Calosa
25c59cd5dd add KeyBinding ispressed condition 2025-07-07 09:37:03 +08:00
Anthony Calosa
9825239e43 fix W and S keys for TextField input 2025-07-07 06:00:04 +08:00
Eradev
fb69f245da Encode UTF-8 symbols in collector number (#7923)
* Fix black star in URL
2025-07-05 22:26:14 +02:00
Robin Woodby
7ef8dddc2a Remove unused import 2025-07-05 14:40:22 -04:00
Robin Woodby
2abcae84b1 Fix issue where card counts from additional printings were ignored 2025-07-05 14:40:22 -04:00
Robin Woodby
b4beb6c182 Remove unnecessary fully qualified names for java.util data structures 2025-07-05 14:40:22 -04:00
Robin Woodby
786d14663b Add copy collection to clipboard button to adventure mode deck editor
Includes translations
2025-07-05 14:40:22 -04:00
tool4ever
f8269e69c4 Fix Rest in Peace making merged cards disappear (#7946)
---------

Co-authored-by: tool4EvEr <tool4EvEr@>
2025-07-05 17:50:40 +02:00
tool4ever
29274d0acf StackInstance cleanup (#7947)
Co-authored-by: tool4EvEr <tool4EvEr@>
2025-07-05 18:15:55 +03:00
Hans Mackowiak
d6b925f171 move file 2025-07-05 17:01:18 +02:00
Hans Mackowiak
f1f18d1823 lf 2025-07-05 17:00:01 +02:00
tool4ever
03ff2147db True-Name Nemesis crashes on "$" Player name (#7944) 2025-07-05 08:54:14 +00:00
Fulgur14
c66a72806d 6 more leaked EOE cards (#7931) 2025-07-05 08:45:51 +00:00
Fulgur14
e89f2cbac0 Two cards from EOE uncommon leaks that I can actually read (#7895) 2025-07-05 08:34:04 +00:00
tool4ever
d831530c50 Tapestry Warden and support (#7943) 2025-07-05 08:31:38 +00:00
Fulgur14
9fe18c2af8 Evendo and Susur Secundi (#7942) 2025-07-05 08:25:45 +00:00
Fulgur14
fe4ff7ac0f 4 EOE leaks (#7941) 2025-07-05 07:26:04 +00:00
Cees Timmerman
a8ca3d8188 Fix 7937: Offspring token key malformed (#7938) 2025-07-05 07:00:06 +00:00
tool4ever
3b9867c537 Fix updateTarget (#7927)
* Fix meld exiling missing half
2025-07-05 06:58:26 +00:00
Fulgur14
01d22c26f4 Create terrasymbiosis.txt (#7936) 2025-07-04 17:03:28 +00:00
kevlahnota
e8f7fe5a95 Merge pull request #7933 from kevlahnota/master2
fix rounded borders for tokens since it gets the full bordered image …
2025-07-04 23:05:21 +08:00
Anthony Calosa
bd0b8fbc65 minor refactor 2025-07-04 22:45:50 +08:00
Anthony Calosa
05e20b4e92 Merge branch 'master' into master2 2025-07-04 22:39:20 +08:00
Anthony Calosa
716d58ad4b faster implementation 2025-07-04 22:28:51 +08:00
Anthony Calosa
ca12ad529a add comment 2025-07-04 21:58:20 +08:00
Anthony Calosa
6eea82706d better name 2025-07-04 21:52:56 +08:00
Anthony Calosa
d69d005ce0 update remaining checks 2025-07-04 21:27:25 +08:00
Anthony Calosa
b98b322dfe move check 2025-07-04 20:33:57 +08:00
Anthony Calosa
e73e72d150 update view check 2025-07-04 20:10:54 +08:00
Anthony Calosa
8cabc244f7 fix rounded borders for tokens since it gets the full bordered image on scryfall by default now 2025-07-04 19:32:50 +08:00
Fulgur14
4f04e5cc13 Infinite Guideline Station (EOE leak) (#7928) 2025-07-04 10:57:41 +02:00
Agetian
bcf9d2585d - Update LDA data for Standard and Modern (Final Fantasy). (#7926) 2025-07-03 21:42:02 +03:00
Fulgur14
e03b07f940 Create command_bridge.txt (#7924) 2025-07-03 16:45:45 +00:00
Eradev
a45c6aa37e Fix kavu deck (#7919)
* FIx Kavu Deck (C11 -> CMD)

* Whitespaces
2025-07-03 07:00:33 +00:00
Agetian
dd672945f2 - Update LDA data for Standard and Modern (Final Fantasy). (#7918) 2025-07-02 21:25:41 +03:00
Fulgur14
e634be4273 Embrace Oblivion (EOE) 2025-07-02 15:55:41 +00:00
Simisays
9acf5bee41 update (#7916) 2025-07-02 18:25:54 +03:00
tool4ever
1e3297ab64 Update spirit_sisters_call.txt
Closes #7912
2025-07-01 22:11:06 +00:00
Simisays
58df290c8e Adventure church map fix (#7911)
* update

* item name fix
2025-07-01 20:17:40 +03:00
tool4ever
e2075886b1 Update celes_rune_knight.txt 2025-07-01 07:42:42 +02:00
Chris H
ad53abc75a Update snapshot-both-pc-android.yml 2025-06-30 18:38:46 -04:00
Chris H
a599c318dd Update snapshot-both-pc-android.yml 2025-06-30 18:35:51 -04:00
Chris H
14e2a0c5e2 Update snapshot-both-pc-android.yml 2025-06-30 18:28:51 -04:00
Chris H
2ae3efc12e Fix The Brothers War landscape book 2025-06-30 16:48:09 -04:00
tool4ever
fb18134c12 Update merieke_ri_berit.txt
Fix missing trigger when destroyed
2025-06-30 21:13:47 +02:00
Paul Hammerton
2215a101a3 Merge pull request #7906 from paulsnoops/b-a-r-30-june-2025
Banned and Restricted Announcement for June 30, 2025
2025-06-30 18:19:22 +01:00
Paul Hammerton
4df2fe7ac5 Banned and Restricted Announcement for June 30, 2025 2025-06-30 18:08:25 +01:00
Chris H
c24369d1ec Update snapshot-both-pc-android.yml 2025-06-29 12:38:59 -07:00
kevlahnota
41eb86029a Update README.md
Add note to Android installation
2025-06-29 19:52:01 +08:00
Hans Mackowiak
357026ce66 ~ lf 2025-06-28 17:03:26 +02:00
Paul Hammerton
9b558cb069 Merge pull request #7901 from paulsnoops/edition-updates
Edition updates: EOE, EOS, PA1, SLD, TLA & Add Sonic, PA1 to formats
2025-06-28 09:15:11 +01:00
Paul Hammerton
303020ca75 Edition updates: EOE, EOS, PA1, SLD, TLA & Add Sonic, PA1 to formats 2025-06-28 09:10:28 +01:00
Fulgur14
b900abcc71 Sonic the Hedgehog and the rest of his Secret Lair (#7898) 2025-06-28 09:01:20 +02:00
tool4ever
c4ba6df6e9 Update rootwise_survivor.txt 2025-06-28 08:26:08 +02:00
tool4ever
cc4a507799 Update ghouls_night_out.txt
Closes #7900
2025-06-28 08:24:26 +02:00
tool4ever
d8de8ec696 Update professor_hojo.txt 2025-06-27 22:48:18 +02:00
tool4ever
e6563814e8 Amplify: fix only revealing hardcoded types (#7896) 2025-06-27 17:32:52 +02:00
Eradev
016d51669f Better DesecrationDemon sac check. (#7880)
* Better DesecrationDemon sac check.

* Fix var.

---------

Co-authored-by: Agetian <stavdev@mail.ru>
2025-06-27 06:58:49 +03:00
Jacob Arbib
f19828b2ec Add Duration handling to TextBoxExchangeEffect and added Exchange of Words (#7890) 2025-06-26 17:08:36 +00:00
Hans Mackowiak
36fc87c2a1 ~ lf 2025-06-26 07:03:38 +02:00
tool4ever
4322bddabf Fix NPE by defeating Invasion of Ikoria while controlling Henzie (#7893) 2025-06-25 19:59:27 +00:00
Fulgur14
c128a9d4ba Alpharael, Dreaming Acolyte (EOE) (#7891) 2025-06-25 17:53:25 +00:00
Chris H
2feeffc95c Update jenova_ancient_calamity.txt (#7892) 2025-06-25 17:42:20 +00:00
Hans Mackowiak
53de238a7e Update EnemySprite.java
Fix Android not having stream().toList()
2025-06-25 17:25:46 +02:00
Cees Timmerman
c207e74369 Fix Meld art download (#7858) (#7884)
* Fix Meld art download (#7858)

---------

Co-authored-by: tool4ever <therealtoolkit@hotmail.com>
Co-authored-by: Hans Mackowiak <hanmac@gmx.de>
Co-authored-by: Agetian <stavdev@mail.ru>
2025-06-25 10:18:43 +02:00
tool4ever
04ca02a77a Update fiery_gambit.txt
Fix collision
Closes #7886
2025-06-22 22:21:28 +02:00
Hans Mackowiak
6ff89c71b6 Add Spacecraft (#7885)
* Add Spacecraft

---------

Co-authored-by: tool4ever <therealtoolkit@hotmail.com>
2025-06-22 11:03:52 +02:00
Hans Mackowiak
d7c6a8e53e ~ lf 2025-06-22 10:09:00 +02:00
kevlahnota
150741a443 Merge pull request #7883 from Card-Forge/keybind-hud-android-fix
Fix Android Keybind for Adventure Mode Console toggle
2025-06-22 09:01:36 +08:00
kevlahnota
460f322c44 Update KeyBinding.java
remove duplicates, update back key binding
2025-06-21 22:49:58 +08:00
kevlahnota
ef5d35fe38 Update GameHUD.java
update console ZIndex
2025-06-21 22:46:25 +08:00
kevlahnota
16044556b5 Update Console.java
exit command for console
2025-06-21 22:43:40 +08:00
Paul Hammerton
81d5079468 Merge pull request #7882 from paulsnoops/editionupdates
Edition updates: EOE, PSPL
2025-06-21 11:04:48 +01:00
Paul Hammerton
edc4b22cbc Edition updates: EOE, PSPL 2025-06-21 11:01:04 +01:00
Cees Timmerman
c01dfd4740 Fix Meld art download (#7858) 2025-06-21 11:52:08 +02:00
Paul Hammerton
53a4a46d1f Merge pull request #7881 from paulsnoops/edition-updates
Edition updates: EOC, EOE, EOS, PF25, PJSC, PPRO, SLD, TLA
2025-06-21 10:03:39 +01:00
Paul Hammerton
d61e7e7102 PPRO 2025-06-21 09:59:24 +01:00
Paul Hammerton
17f4df9293 Edition updates: EOC, EOE, EOS, PF25, PJSC, SLD, TLA 2025-06-21 09:55:08 +01:00
Fulgur14
24071582bb 3 EOE cards + 2 EOC cards (#7875) 2025-06-21 07:24:52 +00:00
Eradev
5754466a0d Fix Triplicate Titans tokens ids 2025-06-21 08:27:56 +02:00
Fulgur14
a18eda92b7 Harmonious Grovestrider (EOE) (#7873) 2025-06-20 21:05:18 +00:00
Fulgur14
11d0a8f2fe Create tezzeret_cruel_captain.txt (#7870) 2025-06-20 21:05:10 +00:00
Cees Timmerman
2b8b386882 Fix ConcurrentModificationException (#7865) (#7867)
* Fix ConcurrentModificationException (#7865)

* Update CostPayment.java
2025-06-20 07:33:32 +02:00
Hans Mackowiak
45a5027451 Update kuja_genome_sorcerer_trance_kuja_fate_defied.txt
Closes #7869
2025-06-20 07:32:18 +02:00
Hans Mackowiak
2cb72f55f3 Update Modern Horizons 3.txt
Closes #7864
2025-06-19 10:12:05 +02:00
jpvorenk
fa27fbab46 fix null pointer on draft refresh (#7863) 2025-06-17 21:36:29 -04:00
EfourC
87821fe287 Adventure: Made tooltips instant and reduced size (#7787)
* Made adventure reward tooltips instant and adjusted their size on Desktop

* Moved RewardTooltipManager to be an internal class of RewardActor.
2025-06-16 20:40:08 -04:00
Seth Milliken
cee4bcd867 card: correct sundown pass mana order (#7855)
* card: correct sundown pass mana order
2025-06-15 10:28:23 +02:00
tool4ever
b9cc4c18a8 Update yuna_grand_summoner.txt 2025-06-14 21:56:29 +02:00
EfourC
4577e61940 Corrected height of buttons for disabled Auto and Quck save slots, and adjusted font color. 2025-06-14 13:59:24 -04:00
EfourC
9ac6147a98 Made the autoSell buttons for rewards semi-transparent unless selected and fixed transparency carrying over to other Actors in a batch. Also made small adjustment to card flipping speed to be a little more snappy and fit the sound effect better. 2025-06-14 13:54:14 -04:00
Chris H
74d4ea8a78 Replace each card in a slot individually instead of replacing the whole slot at once. (Fixes higher rates of replacements) (#7854) 2025-06-14 18:02:54 +03:00
Robin Woodby
e2f4c7f872 Autofocus the first dialog option on desktop with keyboard input
Previously, autofocus only worked with gamepads connected.
2025-06-14 10:33:41 -04:00
Robin Woodby
07db8e5a94 Allow ESC to dismiss console in addition to android back button 2025-06-14 10:33:41 -04:00
Robin Woodby
ed7fb03b9c Fix issue where eventTouchUp is firing before keyUp in GameHUD 2025-06-14 10:33:41 -04:00
Robin Woodby
f0ebc3e6a0 Remove redundant call to openMenu causing flickering 2025-06-14 10:33:41 -04:00
Robin Woodby
f2570b4cef Update adventure mode deck editor to support ESC key to go back. 2025-06-14 10:33:41 -04:00
Robin Woodby
97e1939021 Fix enter key not working to save/load in menus 2025-06-14 10:33:41 -04:00
Robin Woodby
bebb894f3e Fix setText call for done button on rewards page 2025-06-14 10:33:41 -04:00
Robin Woodby
288c533c91 Revert reward scene done button text to check mark except for shop
This way translation when loading from file works for "Done"
2025-06-14 10:33:41 -04:00
Robin Woodby
6891f9a5d5 Change back button to esc in shop and reward screens for consistency 2025-06-14 10:33:41 -04:00
Simisays
37a62eed6b Update crypt.tmx (#7853) 2025-06-14 16:40:25 +03:00
MD200210
3ee6b0e58d Details Labels and Zooming on Adventure World Map (#7840)
* Details Button on Adventure Map.
Zooming on Adventure Map

* no Wildcard Import
2025-06-13 07:12:28 +03:00
Robin Woodby
7e6f772345 Update forge-ai description to be more specific and less redundant 2025-06-11 21:05:20 -04:00
Robin Woodby
ef28173b65 Add missing module descriptions in contributing docs 2025-06-11 21:05:20 -04:00
Robin Woodby
a26614c6b6 Remove double spaces and fix typos 2025-06-11 21:05:20 -04:00
Chris H
ee00293e48 Update rydias_return.txt 2025-06-11 16:21:50 -04:00
MatthiasD
ce977387e6 Fix Update Symbols 2025-06-11 16:00:52 -04:00
MD200210
8cc45dbbd8 Fix Cid (#7842) 2025-06-11 17:47:29 +02:00
MatthiasD
851a4c104c Update and change FCA 2025-06-11 16:28:49 +02:00
45ddf3fded Fix: Update getCommander method to enable StorageImmediatelySerialized subfolders 2025-06-11 09:09:10 -04:00
tool4ever
cb538f4026 Update depth_defiler.txt (#7829) 2025-06-09 10:36:34 +02:00
EfourC
6bd6db3c16 Adventure: AccountingLabel animation update 2025-06-08 21:57:07 -04:00
Chris H
6af3940ffb Update queen_brahne.txt 2025-06-08 21:43:34 -04:00
Renato Filipe Vidal Santos
66c864c8d7 Cleanup: DBCleanup (#7822) 2025-06-08 21:32:18 +03:00
rwalters
15354dd8e8 Fix ff limited cards (#7819)
* Fixing the power and toughness of two cards relevant in limited

---------

Co-authored-by: Agetian <stavdev@mail.ru>
2025-06-08 08:37:56 +03:00
Renato Filipe Vidal Santos
215070fe3f Update blot_out.txt 2025-06-07 12:59:12 +02:00
Renato Filipe Vidal Santos
ed73883e80 Update overtaker.txt (#7815) 2025-06-07 12:59:25 +03:00
Renato Filipe Vidal Santos
df85ebc0aa Update ayula_queen_among_bears.txt (#7812)
* Update ayula_queen_among_bears.txt

* Update rampaging_yao_guai.txt

* Update ulvenwald_bear.txt

* Update rampaging_yao_guai.txt
2025-06-07 10:43:33 +03:00
Hans Mackowiak
885a6af943 Update shambling_cieth.txt
Closes #7810
2025-06-06 17:50:13 +02:00
Renato Filipe Vidal Santos
94820d4782 Update tranquil_frillback.txt 2025-06-06 17:05:11 +02:00
Renato Filipe Vidal Santos
7f044e5ac3 Update wicked_slumber.txt 2025-06-06 15:11:59 +02:00
Renato Filipe Vidal Santos
1284f23620 Update primeval_bounty.txt (#7807) 2025-06-06 12:34:37 +02:00
Agetian
bdcc8acdc4 Add Final Fantasy achievements by Marek14 (#7806)
* - Add FIN achievements by Marek14.

* - Minor tweak.
2025-06-06 10:21:44 +03:00
Chris H
73a9dfcf43 Automate patch version increment 2025-06-05 23:37:40 -04:00
GitHub Actions
7a277ce283 [maven-release-plugin] prepare for next development iteration 2025-06-05 23:37:40 -04:00
GitHub Actions
f8b3f9dd30 [maven-release-plugin] prepare release forge-2.0.04 2025-06-05 23:37:40 -04:00
Chris H
840f3ea96c Automate patch version increment 2025-06-05 22:45:57 -04:00
Chris H
51929434be Update flatten to work with full release 2025-06-05 22:45:57 -04:00
gsonnier333
3ec480afa4 fixed weapons_vendor.txt power/toughness 2025-06-05 21:21:27 -04:00
Chris H
3d19e9e444 Update summon_g_f_ifrit.txt 2025-06-05 21:21:14 -04:00
Renato Filipe Vidal Santos
6d987791f7 Fixing Animate Dead and similar effects) 2025-06-05 14:25:08 +02:00
Renato Filipe Vidal Santos
7b7da00c22 Incidental fixes: 2025-06-05 2025-06-05 08:54:38 +02:00
tool4ever
34791bd892 Update stangg.txt 2025-06-05 08:53:38 +02:00
Renato Filipe Vidal Santos
e6bcd1be72 Add files via upload 2025-06-04 20:33:46 -04:00
Paul Hammerton
4cac354983 Merge pull request #7794 from paulsnoops/fin-formats
Add Final Fantasy to formats
2025-06-04 18:11:13 +01:00
Paul Hammerton
042f7f77a9 Add Final Fantasy to formats 2025-06-04 18:06:21 +01:00
Hans Mackowiak
5fbb1dd0cd Update summon_leviathan.txt
Fix Draw
2025-06-04 08:55:00 +02:00
Hans Mackowiak
bb14dfc00e Update summon_leviathan.txt
Closes #7784
2025-06-04 07:20:24 +02:00
Renato Filipe Vidal Santos
f83cc4ccfa Update fin.rnk 2025-06-03 11:05:10 -04:00
tool4ever
d0d6835a5d Update zodiark_umbral_god.txt 2025-06-03 13:24:17 +00:00
tool4EvEr
104bc8fc55 SpellAbility: set CardState inside constructor 2025-06-03 13:26:25 +02:00
SprinkleMeTimbers
057dd867a8 Adventure: added support for dynamic deck count (#7669)
* Added: utility method for adding an integer selecting combo-box.

* Added: Adventure now supports dynamic amount of decks

* Tweaked: lowered max deck count to 20.

* Added: dynamic deck count can't ever be higher than the maximum in current version.
2025-06-03 13:17:30 +03:00
Chris H
9eed8f5095 Update some names in fin rankings (#7776) 2025-06-03 13:17:18 +03:00
Chris H
1f62be9773 Migrate FIN upcoming (#7777) 2025-06-03 10:13:01 +00:00
Hans Mackowiak
7a46f92059 Update CardState updateSpellAbilities only when not inPlay (#7780)
* Fix copy order
2025-06-03 10:12:35 +00:00
tool4EvEr
cfa79b9676 attachAuraOnIndirectETB: fix missing activator 2025-06-03 09:54:37 +02:00
tool4ever
c0a63fa15b Fix Dark Depths triggering vs. Blood Moon (#7768) 2025-06-03 08:07:10 +02:00
Renato Filipe Vidal Santos
c61537ae16 Add files via upload 2025-06-02 23:44:22 -04:00
Renato Filipe Vidal Santos
3871095b92 Add files via upload 2025-06-02 23:44:22 -04:00
Simisays
dee846da49 Update cave_bigzombie.tmx 2025-06-02 22:08:08 -04:00
Jason Vorenkamp
2477553d13 fix incorrect resource name 2025-06-02 21:46:37 -04:00
Renato Filipe Vidal Santos
c9df7d7f8e Cleaning upcoming: 2025-06-02 2025-06-02 16:02:17 +00:00
rwalters
53cb093f9e (Adventure) Fix draft scene transition (#7666)
* Fixing an issue in which touching the space the map occupies outside of the world map does not allow the player to move (very relevant on maps with content in the top left corner)

* Fixing a bug in which the transition screen's non-blocking of the start match button can be clicked multiple times, which results in a crash when the match ends
2025-06-02 10:24:50 -04:00
MD200210
28e86970dc Added Draft Info (#7764)
* FIN Draft Info

(cherry picked from commit ad0385617b26391efa2b866157eea674ea850e1e)

* Correction

* Correction

* Correction
2025-06-02 10:24:10 -04:00
Chris H
f847fc1669 Fix sketchbooks that are missing colons in the name 2025-06-02 07:22:26 -04:00
Hans Mackowiak
f3df55177a CardState: fix Android not having stream().toList(); Closes #7761 2025-06-02 07:10:26 +02:00
Chris H
be6f345127 Hotfix PaperCard edition issues 2025-06-01 22:50:58 -04:00
2930 changed files with 188647 additions and 8530 deletions

View File

@@ -81,7 +81,7 @@ jobs:
export _JAVA_OPTIONS="-Xmx2g"
d=$(date +%m.%d)
# build only desktop and only try to move desktop files
mvn -U -B clean -P windows-linux install -e -T 1C release:clean release:prepare release:perform -DskipTests
mvn -U -B clean -P windows-linux install -DskipTests -Dskip.flatten=true -e -T 1C release:clean release:prepare release:perform
mkdir izpack
# move bz2 and jar from work dir to izpack dir
mv /home/runner/work/forge/forge/forge-installer/*/*.{bz2,jar} izpack/
@@ -128,6 +128,44 @@ jobs:
removeArtifacts: true
makeLatest: true
- name: 🔧 Install XML tools
run: sudo apt-get install -y libxml2-utils
- name: 🔼 Bump versionCode in root POM
id: bump_version
run: |
cd /home/runner/work/forge/forge/
current_version=$(xmllint --xpath "//*[local-name()='versionCode']/text()" pom.xml)
echo "Current versionCode: $current_version"
IFS='.' read -r major minor patch <<< "${current_version}"
new_patch=$(printf "%02d" $((10#$patch + 1)))
new_version="${major}.${minor}.${new_patch}"
sed -i -E "s|<versionCode>.*</versionCode>|<versionCode>${new_version}</versionCode>|" pom.xml
echo "version_code=${new_version}" >> $GITHUB_OUTPUT
- name: ♻️ Restore {revision} in child POMs
run: |
find . -name pom.xml ! -path "./pom.xml" | while read -r pom; do
sed -i -E 's|<version>2\.0+\.[0-9]+(-SNAPSHOT)?</version>|<version>${revision}</version>|' "$pom"
done
- name: 💾 Commit restored {revision}
run: |
# Add only pom.xml files
find . -name pom.xml -exec git add {} \;
# Commit if there are changes
if git diff --cached --quiet; then
echo "No pom.xml changes to commit."
else
git commit -m "Restore POM files for preparation of next release" || echo "No changes to commit"
git push
fi
- name: Send failure notification to Discord
if: failure() # This step runs only if the job fails
run: |

View File

@@ -6,7 +6,7 @@ Dev instructions here: [Getting Started](https://github.com/Card-Forge/forge/wik
## Requirements / Tools
- you favourite Java IDE (IntelliJ, Eclipse, VSCodium, Emacs, Vi...)
- your favourite Java IDE (IntelliJ, Eclipse, VSCodium, Emacs, Vi...)
- Java JDK 17 or later
- Git
- Git client (optional)
@@ -28,7 +28,6 @@ Dev instructions here: [Getting Started](https://github.com/Card-Forge/forge/wik
IntelliJ is the recommended IDE for Forge development. Quick start guide for [setting up the Forge project within IntelliJ](https://github.com/Card-Forge/forge/wiki/IntelliJ-setup).
## Eclipse
Eclipse includes Maven integration so a separate install is not necessary. For other IDEs, your mileage may vary.
@@ -124,10 +123,11 @@ TBD
SNAPSHOT builds can be built via the Maven integration in Eclipse.
1) Create a Maven build for the forge top-level project. Right-click on the forge project. Run as.. > Maven build...
1. Create a Maven build for the forge top-level project. Right-click on the forge project. Run as.. > Maven build...
- On the Main tab, set Goals: clean install, set Profiles: windows-linux
2) Run forge Maven build. If everything built, you should see "BUILD SUCCESS" in the Console View.
2. Run forge Maven build. If everything built, you should see "BUILD SUCCESS" in the Console View.
The resulting snapshot will be found at: forge-gui-desktop/target/forge-gui-desktop-[version]-SNAPSHOT
@@ -158,13 +158,19 @@ The platform-specific projects are:
#### forge-ai
The forge-ai project contains the computer opponent logic for gameplay. It includes decision-making algorithms for specific abilities, cards and turn phases.
#### forge-core
The forge-core project contains the core game engine, card mechanics, rules engine, and fundamental game logic. It includes the implementation of Magic: The Gathering rules, card interactions, and the game state management system.
#### forge-game
The forge-game project handles the game session management, player interactions, and game flow control. It includes implementations for multiplayer support, game modes, matchmaking, and game state persistence. This module bridges the core game engine with the user interface and networking components.
#### forge-gui
The forge-gui project includes the scripting resource definitions in the res/ path.
The forge-gui project contains the user interface components and rendering logic for the game. It includes the main game window, card displays, player interactions, and the scripting resource definitions in the res/ path.
#### forge-gui-android

View File

@@ -32,6 +32,7 @@ Join the **Forge community** on [Discord](https://discord.gg/HcPJNyD66a)!
4. **Java Requirement:** Ensure you have **Java 17 or later** installed.
### 📱 Android Installation
- _(Note: **Android 11** is the minimum requirements with at least **6GB RAM** to run smoothly. You need to enable **"Install unknown apps"** for Forge to initialize and update itself)_
- Download the **APK** from the [Snapshot Build](https://github.com/Card-Forge/forge/releases/tag/daily-snapshots). On the first launch, Forge will automatically download all necessary assets.
---
@@ -46,11 +47,13 @@ Embark on a thrilling single-player journey where you can:
- Challenge diverse AI opponents.
- Collect cards and items to boost your abilities.
![Adventure Mode](https://downloads.cardforge.org/images/site/adventure-mode.png "Adventure Mode")
<img width="1282" height="752" alt="Shandalar World" src="https://github.com/user-attachments/assets/9af31471-d688-442f-9418-9807d8635b72" />
### 🔍 Quest Modes
Engage in focused gameplay without the overworld exploration—perfect for quick sessions!
<img width="1282" height="752" alt="Quest Duels" src="https://github.com/user-attachments/assets/b9613b1c-e8c3-4320-8044-6922c519aad4" />
### 🤖 AI Formats
Test your skills against AI in multiple formats:
- **Sealed**
@@ -60,6 +63,8 @@ Test your skills against AI in multiple formats:
For comprehensive gameplay instructions, visit our [Gameplay Guide](https://github.com/Card-Forge/forge/wiki/Gameplay-Guide).
<img width="1282" height="752" alt="Sealed" src="https://github.com/user-attachments/assets/ae603dbd-4421-4753-a333-87cb0a28d772" />
---
## 💬 Support & Community

View File

@@ -0,0 +1,9 @@
package forge.ai;
public record AiAbilityDecision(int rating, AiPlayDecision decision) {
private static int MIN_RATING = 30;
public boolean willingToPlay() {
return rating > MIN_RATING && decision.willingToPlay();
}
}

View File

@@ -145,13 +145,15 @@ public class AiAttackController {
sa.setActivatingPlayer(defender);
if (sa.isCrew() && !ComputerUtilCost.checkTapTypeCost(defender, sa.getPayCosts(), c, sa, tappedDefenders)) {
continue;
} else if (!ComputerUtilCost.canPayCost(sa, defender, false) || !sa.getRestrictions().checkOtherRestrictions(c, sa, defender)) {
}
if (!ComputerUtilCost.canPayCost(sa, defender, false) || !sa.getRestrictions().checkOtherRestrictions(c, sa, defender)) {
continue;
}
Card animatedCopy = AnimateAi.becomeAnimated(c, sa);
if (animatedCopy.isCreature()) {
// TODO imprecise, only works 100% for colorless mana
int saCMC = sa.getPayCosts() != null && sa.getPayCosts().hasManaCost() ?
sa.getPayCosts().getTotalMana().getCMC() : 0; // FIXME: imprecise, only works 100% for colorless mana
sa.getPayCosts().getTotalMana().getCMC() : 0;
if (totalMana - manaReserved >= saCMC) {
manaReserved += saCMC;
defenders.add(animatedCopy);

View File

@@ -911,56 +911,14 @@ public class AiController {
}
}
int oldCMC = -1;
boolean xCost = sa.costHasX() || host.hasKeyword(Keyword.STRIVE) || sa.getApi() == ApiType.Charm;
if (!xCost) {
if (!ComputerUtilCost.canPayCost(sa, player, sa.isTrigger())) {
// for most costs, it's OK to check if they can be paid early in order to avoid running a heavy API check
// when the AI won't even be able to play the spell in the first place (even if it could afford it)
return AiPlayDecision.CantAfford;
}
// TODO check for Reduce too, e.g. Battlefield Thaumaturge could make it castable
if (!sa.getAllTargetChoices().isEmpty()) {
oldCMC = CostAdjustment.adjust(sa.getPayCosts(), sa, false).getTotalMana().getCMC();
}
}
AiPlayDecision canPlay = canPlaySa(sa); // this is the "heaviest" check, which also sets up targets, defines X, etc.
// this is the "heaviest" check, which also sets up targets, defines X, etc.
AiPlayDecision canPlay = canPlaySa(sa);
if (canPlay != AiPlayDecision.WillPlay) {
return canPlay;
}
// Account for possible Ward after the spell is fully targeted
// TODO: ideally, this should be done while targeting, so that a different target can be preferred if the best
// one is warded and can't be paid for. (currently it will be stuck with the target until it could pay)
if (!sa.isSpell() || sa.isCounterableBy(null)) {
for (TargetChoices tc : sa.getAllTargetChoices()) {
for (Card tgt : tc.getTargetCards()) {
// TODO some older cards don't use the keyword, so check for trigger instead
if (tgt.hasKeyword(Keyword.WARD) && tgt.isInPlay() && tgt.getController().isOpponentOf(host.getController())) {
Cost wardCost = ComputerUtilCard.getTotalWardCost(tgt);
if (wardCost.hasManaCost()) {
xCost |= wardCost.getTotalMana().getCMC() > 0;
}
SpellAbilityAi topAI = new SpellAbilityAi() {};
if (!topAI.willPayCosts(player, sa, wardCost, host)) {
return AiPlayDecision.CostNotAcceptable;
}
}
}
}
}
// check if some target raised cost
if (!xCost && oldCMC > -1) {
int finalCMC = CostAdjustment.adjust(sa.getPayCosts(), sa, false).getTotalMana().getCMC();
if (finalCMC > oldCMC) {
xCost = true;
}
}
if (xCost && !ComputerUtilCost.canPayCost(sa, player, sa.isTrigger())) {
if (!ComputerUtilCost.canPayCost(sa, player, sa.isTrigger())) {
// for dependent costs with X, e.g. Repeal, which require a valid target to be specified before a decision can be made
// on whether the cost can be paid, this can only be checked late after canPlaySa has been run (or the AI will misplay)
return AiPlayDecision.CantAfford;
@@ -973,8 +931,6 @@ public class AiController {
return AiPlayDecision.CantAfford;
}
// if we got here, looks like we can play the final cost and we could properly set up and target the API and
// are willing to play the SA
return AiPlayDecision.WillPlay;
}
@@ -1017,7 +973,7 @@ public class AiController {
Sentry.setExtra("Card", card.getName());
Sentry.setExtra("SA", sa.toString());
boolean canPlay = SpellApiToAi.Converter.get(sa).canPlayAIWithSubs(player, sa);
boolean canPlay = SpellApiToAi.Converter.get(sa).canPlayWithSubs(player, sa).willingToPlay();
// remove added extra
Sentry.removeExtra("Card");
@@ -1395,9 +1351,9 @@ public class AiController {
if (spell instanceof SpellApiBased) {
boolean chance = false;
if (withoutPayingManaCost) {
chance = SpellApiToAi.Converter.get(spell).doTriggerNoCostWithSubs(player, spell, mandatory);
chance = SpellApiToAi.Converter.get(spell).doTriggerNoCostWithSubs(player, spell, mandatory).willingToPlay();
} else {
chance = SpellApiToAi.Converter.get(spell).doTriggerAI(player, spell, mandatory);
chance = SpellApiToAi.Converter.get(spell).doTrigger(player, spell, mandatory);
}
if (!chance) {
return AiPlayDecision.TargetingFailed;
@@ -1804,9 +1760,9 @@ public class AiController {
for (int i = 0; i < numToExile; i++) {
Card chosen = null;
for (final Card c : grave) { // Exile noncreatures first in
// case we can revive. Might wanna do some additional
// checking here for Flashback and the like.
for (final Card c : grave) {
// Exile noncreatures first in case we can revive
// Might wanna do some additional checking here for Flashback and the like
if (!c.isCreature()) {
chosen = c;
break;
@@ -1827,12 +1783,12 @@ public class AiController {
return toExile;
}
public boolean doTrigger(SpellAbility spell, boolean mandatory) {
if (spell instanceof WrappedAbility)
return doTrigger(((WrappedAbility) spell).getWrappedAbility(), mandatory);
if (spell.getApi() != null)
return SpellApiToAi.Converter.get(spell).doTriggerAI(player, spell, mandatory);
if (spell.getPayCosts() == Cost.Zero && !spell.usesTargeting()) {
public boolean doTrigger(SpellAbility sa, boolean mandatory) {
if (sa instanceof WrappedAbility)
return doTrigger(((WrappedAbility) sa).getWrappedAbility(), mandatory);
if (sa.getApi() != null)
return SpellApiToAi.Converter.get(sa).doTrigger(player, sa, mandatory);
if (sa.getPayCosts() == Cost.Zero && !sa.usesTargeting()) {
// For non-converted triggers (such as Cumulative Upkeep) that don't have costs or targets to worry about
return true;
}

View File

@@ -767,6 +767,12 @@ public class AiCostDecision extends CostDecisionMakerBase {
public PaymentDecision visit(CostRemoveCounter cost) {
final String amount = cost.getAmount();
final String type = cost.getType();
final GameEntityCounterTable counterTable = new GameEntityCounterTable();
// TODO Help AI filter card with most useless counters and put those counters in countertable for things like
// Moxite Refinery, similar to CostRemoveAnyCounter
// Probably a lot of that decision making can be re-used or pulled out for both PaymentDecisions to use
if (cost.counter == null) return null;
int c;
@@ -795,7 +801,8 @@ public class AiCostDecision extends CostDecisionMakerBase {
}
for (Card card : typeList) {
if (card.getCounters(cost.counter) >= c) {
return PaymentDecision.card(card, c);
counterTable.put(null, card, cost.counter, c);
return PaymentDecision.counters(counterTable);
}
}
return null;
@@ -806,7 +813,8 @@ public class AiCostDecision extends CostDecisionMakerBase {
return null;
}
return PaymentDecision.card(source, c);
counterTable.put(null, source, cost.counter, c);
return PaymentDecision.counters(counterTable);
}
@Override

View File

@@ -1,21 +1,52 @@
package forge.ai;
public enum AiPlayDecision {
// Play decision reasons
WillPlay,
MandatoryPlay,
PlayToEmptyHand,
ImpactCombat,
ResponseToStackResolve,
AddBoardPresence,
Removal,
Tempo,
CardAdvantage,
// Play later decisions
WaitForCombat,
WaitForMain2,
WaitForEndOfTurn,
StackNotEmpty,
AnotherTime,
// Don't play decision reasons,
CantPlaySa,
CantPlayAi,
CantAfford,
CantAffordX,
WaitForMain2,
AnotherTime,
DoesntImpactCombat,
DoesntImpactGame,
MissingLogic,
MissingNeededCards,
TimingRestrictions,
MissingPhaseRestrictions,
ConditionsNotMet,
NeedsToPlayCriteriaNotMet,
StopRunawayActivations,
TargetingFailed,
CostNotAcceptable,
LifeInDanger,
WouldDestroyLegend,
WouldDestroyOtherPlaneswalker,
WouldBecomeZeroToughnessCreature,
WouldDestroyWorldEnchantment,
BadEtbEffects,
CurseEffects
CurseEffects;
public boolean willingToPlay() {
return switch (this) {
case WillPlay, MandatoryPlay, PlayToEmptyHand, AddBoardPresence, ImpactCombat, ResponseToStackResolve, Removal, Tempo, CardAdvantage -> true;
default -> false;
};
}
}

View File

@@ -864,7 +864,7 @@ public class ComputerUtil {
// Run non-mandatory trigger.
// These checks only work if the Executing SpellAbility is an Ability_Sub.
if ((exSA instanceof AbilitySub) && !SpellApiToAi.Converter.get(exSA).doTriggerAI(ai, exSA, false)) {
if ((exSA instanceof AbilitySub) && !SpellApiToAi.Converter.get(exSA).doTrigger(ai, exSA, false)) {
// AI would not run this trigger if given the chance
return sacrificed;
}
@@ -1385,13 +1385,14 @@ public class ComputerUtil {
// returns true if the AI should stop using the ability
public static boolean preventRunAwayActivations(final SpellAbility sa) {
int activations = sa.getActivationsThisTurn();
if (!sa.isIntrinsic()) {
return MyRandom.getRandom().nextFloat() >= .95; // Abilities created by static abilities have no memory
if (!sa.isActivatedAbility()) {
return false;
}
if (activations < 10) { //10 activations per turn should still be acceptable
int activations = sa.getActivationsThisTurn();
//10 activations should still be acceptable
if (activations < 10) {
return false;
}
@@ -2736,7 +2737,7 @@ public class ComputerUtil {
return safeCards;
}
public static Card getKilledByTargeting(final SpellAbility sa, CardCollectionView validCards) {
public static Card getKilledByTargeting(final SpellAbility sa, Iterable<Card> validCards) {
CardCollection killables = CardLists.filter(validCards, c -> c.getController() != sa.getActivatingPlayer() && c.getSVar("Targeting").equals("Dies"));
return ComputerUtilCard.getBestCreatureAI(killables);
}

View File

@@ -345,6 +345,10 @@ public class ComputerUtilAbility {
if (source.hasSVar("AIPriorityModifier")) {
p += Integer.parseInt(source.getSVar("AIPriorityModifier"));
}
// try to use it before it's gone
if (source.isInPlay() && source.hasSVar("EndOfTurnLeavePlay")) {
p += 1;
}
if (ComputerUtilCard.isCardRemAIDeck(sa.getOriginalHost() != null ? sa.getOriginalHost() : source)) {
p -= 10;
}

View File

@@ -1819,18 +1819,18 @@ public class ComputerUtilCard {
* @param sa Pump* or CounterPut*
* @return
*/
public static boolean canPumpAgainstRemoval(Player ai, SpellAbility sa) {
public static AiAbilityDecision canPumpAgainstRemoval(Player ai, SpellAbility sa) {
final List<GameObject> objects = ComputerUtil.predictThreatenedObjects(sa.getActivatingPlayer(), sa, true);
if (!sa.usesTargeting()) {
final List<Card> cards = AbilityUtils.getDefinedCards(sa.getHostCard(), sa.getParam("Defined"), sa);
for (final Card card : cards) {
if (objects.contains(card)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.ResponseToStackResolve);
}
}
// For pumps without targeting restrictions, just return immediately until this is fleshed out.
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
CardCollection threatenedTargets = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
@@ -1849,11 +1849,11 @@ public class ComputerUtilCard {
}
if (!sa.isTargetNumberValid()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.ResponseToStackResolve);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
public static boolean isUselessCreature(Player ai, Card c) {

View File

@@ -5,6 +5,7 @@ import java.util.List;
import java.util.Set;
import java.util.function.Predicate;
import forge.game.GameObject;
import org.apache.commons.lang3.ObjectUtils;
import org.apache.commons.lang3.StringUtils;
@@ -139,11 +140,13 @@ public class ComputerUtilCost {
if (type.equals("CARDNAME")) {
if (source.getAbilityText().contains("Bloodrush")) {
continue;
} else if (ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN, ai)
}
if (ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN, ai)
&& !ai.isUnlimitedHandSize() && ai.getCardsIn(ZoneType.Hand).size() > ai.getMaxHandSize()) {
// Better do something than just discard stuff
return true;
}
return false;
}
typeList = CardLists.getValidCards(hand, type, source.getController(), source, sa);
if (typeList.size() > ai.getMaxHandSize()) {
@@ -248,11 +251,7 @@ public class ComputerUtilCost {
// Does the AI want to use Sacrifice All?
return false;
} else {
Integer c = part.convertAmount();
if (c == null) {
c = part.getAbilityAmount(sourceAbility);
}
int c = part.getAbilityAmount(sourceAbility);
final AiController aic = ((PlayerControllerAi)ai.getController()).getAi();
CardCollectionView choices = aic.chooseSacrificeType(part.getType(), sourceAbility, effect, c, exclude);
if (choices != null) {
@@ -522,13 +521,12 @@ public class ComputerUtilCost {
sa.setActivatingPlayer(player); // complaints on NPE had came before this line was added.
}
boolean cannotBeCountered = false;
// Check for stuff like Nether Void
int extraManaNeeded = 0;
if (!effect) {
boolean cannotBeCountered = !sa.isCounterableBy(null);
if (sa instanceof Spell) {
cannotBeCountered = !sa.isCounterableBy(null);
for (Card c : player.getGame().getCardsIn(ZoneType.Battlefield)) {
final String snem = c.getSVar("AI_SpellsNeedExtraMana");
if (!StringUtils.isBlank(snem)) {
@@ -578,12 +576,24 @@ public class ComputerUtilCost {
}
}
// Ward - will be accounted for when rechecking a targeted ability
if (!sa.isTrigger() && (!sa.isSpell() || !cannotBeCountered)) {
// Account for possible Ward after the spell is fully targeted
// TODO: ideally, this should be done while targeting, so that a different target can be preferred if the best
// one is warded and can't be paid for. (currently it will be stuck with the target until it could pay)
if (!sa.isTrigger() && !cannotBeCountered) {
Set<GameObject> distinctObjects = Sets.newHashSet();
for (TargetChoices tc : sa.getAllTargetChoices()) {
for (Card tgt : tc.getTargetCards()) {
if (!distinctObjects.add(tgt)) {
continue;
}
// TODO some older cards don't use the keyword, so check for trigger instead
if (tgt.hasKeyword(Keyword.WARD) && tgt.isInPlay() && tgt.getController().isOpponentOf(sa.getHostCard().getController())) {
Cost wardCost = ComputerUtilCard.getTotalWardCost(tgt);
// don't use API converter since it might have special part logic not meant for Ward cost
SpellAbilityAi topAI = new SpellAbilityAi() {};
if (!topAI.willPayCosts(player, sa, wardCost, sa.getHostCard())) {
return false;
}
if (wardCost.hasManaCost()) {
extraManaNeeded += wardCost.getTotalMana().getCMC();
}
@@ -607,6 +617,7 @@ public class ComputerUtilCost {
}
}
// TODO both of these call CostAdjustment.adjust, try to reuse instead
return ComputerUtilMana.canPayManaCost(cost, sa, player, extraManaNeeded, effect)
&& CostPayment.canPayAdditionalCosts(cost, sa, effect, player);
}

View File

@@ -226,7 +226,7 @@ public class ComputerUtilMana {
}
public static SpellAbility chooseManaAbility(ManaCostBeingPaid cost, SpellAbility sa, Player ai, ManaCostShard toPay,
Collection<SpellAbility> saList, boolean checkCosts) {
Collection<SpellAbility> maList, boolean checkCosts) {
Card saHost = sa.getHostCard();
// CastTotalManaSpent (AIPreference:ManaFrom$Type or AIManaPref$ Type)
@@ -240,12 +240,12 @@ public class ComputerUtilMana {
manaSourceType = sa.getParam("AIManaPref");
}
if (manaSourceType != "") {
List<SpellAbility> filteredList = Lists.newArrayList(saList);
List<SpellAbility> filteredList = Lists.newArrayList(maList);
switch (manaSourceType) {
case "Snow":
filteredList.sort((ab1, ab2) -> ab1.getHostCard() != null && ab1.getHostCard().isSnow()
&& ab2.getHostCard() != null && !ab2.getHostCard().isSnow() ? -1 : 1);
saList = filteredList;
maList = filteredList;
break;
case "Treasure":
// Try to spend only one Treasure if possible
@@ -253,22 +253,22 @@ public class ComputerUtilMana {
&& ab2.getHostCard() != null && !ab2.getHostCard().getType().hasSubtype("Treasure") ? -1 : 1);
SpellAbility first = filteredList.get(0);
if (first.getHostCard() != null && first.getHostCard().getType().hasSubtype("Treasure")) {
saList.remove(first);
maList.remove(first);
List<SpellAbility> updatedList = Lists.newArrayList();
updatedList.add(first);
updatedList.addAll(saList);
saList = updatedList;
updatedList.addAll(maList);
maList = updatedList;
}
break;
case "TreasureMax":
// Ok to spend as many Treasures as possible
filteredList.sort((ab1, ab2) -> ab1.getHostCard() != null && ab1.getHostCard().getType().hasSubtype("Treasure")
&& ab2.getHostCard() != null && !ab2.getHostCard().getType().hasSubtype("Treasure") ? -1 : 1);
saList = filteredList;
maList = filteredList;
break;
case "NotSameCard":
String hostName = sa.getHostCard().getName();
saList = filteredList.stream()
maList = filteredList.stream()
.filter(saPay -> !saPay.getHostCard().getName().equals(hostName))
.collect(Collectors.toList());
break;
@@ -277,7 +277,7 @@ public class ComputerUtilMana {
}
}
for (final SpellAbility ma : saList) {
for (final SpellAbility ma : maList) {
// this rarely seems like a good idea
if (ma.getHostCard() == saHost) {
continue;
@@ -336,7 +336,7 @@ public class ComputerUtilMana {
// Deprioritize Cavern of Souls, try to pay generic mana with it instead to use the NoCounter ability
continue;
} else if (toPay == ManaCostShard.GENERIC || toPay == ManaCostShard.X) {
for (SpellAbility ab : saList) {
for (SpellAbility ab : maList) {
if (ab.isManaAbility() && ab.getManaPart().isAnyMana() && ab.hasParam("AddsNoCounter")) {
if (!ab.getHostCard().isTapped()) {
paymentChoice = ab;
@@ -590,12 +590,12 @@ public class ComputerUtilMana {
while (!cost.isPaid()) {
toPay = getNextShardToPay(cost, sourcesForShards);
Collection<SpellAbility> saList = sourcesForShards.get(toPay);
if (saList == null) {
Collection<SpellAbility> maList = sourcesForShards.get(toPay);
if (maList == null) {
break;
}
SpellAbility saPayment = chooseManaAbility(cost, sa, ai, toPay, saList, true);
SpellAbility saPayment = chooseManaAbility(cost, sa, ai, toPay, maList, true);
if (saPayment == null) {
boolean lifeInsteadOfBlack = toPay.isBlack() && ai.hasKeyword("PayLifeInsteadOf:B");
if ((!toPay.isPhyrexian() && !lifeInsteadOfBlack) || !ai.canPayLife(2, false, sa)) {
@@ -666,6 +666,7 @@ public class ComputerUtilMana {
return true;
}
int phyLifeToPay = 2;
boolean purePhyrexian = cost.containsOnlyPhyrexianMana();
boolean hasConverge = sa.getHostCard().hasConverge();
ListMultimap<ManaCostShard, SpellAbility> sourcesForShards = getSourcesForShards(cost, sa, ai, test, checkPlayable, hasConverge);
@@ -693,13 +694,12 @@ public class ComputerUtilMana {
}
if (sourcesForShards == null && !purePhyrexian) {
break; // no mana abilities to use for paying
// no mana abilities to use for paying
break;
}
toPay = getNextShardToPay(cost, sourcesForShards);
boolean lifeInsteadOfBlack = toPay.isBlack() && ai.hasKeyword("PayLifeInsteadOf:B");
Collection<SpellAbility> saList = null;
if (hasConverge &&
(toPay == ManaCostShard.GENERIC || toPay == ManaCostShard.X)) {
@@ -752,9 +752,14 @@ public class ComputerUtilMana {
}
if (saPayment == null) {
if ((!toPay.isPhyrexian() && !lifeInsteadOfBlack) || !ai.canPayLife(2, false, sa)
|| (ai.getLife() <= 2 && !ai.cantLoseForZeroOrLessLife())) {
break; // cannot pay
boolean lifeInsteadOfBlack = toPay.isBlack() && ai.hasKeyword("PayLifeInsteadOf:B");
if ((!toPay.isPhyrexian() && !lifeInsteadOfBlack) || !ai.canPayLife(phyLifeToPay, false, sa)
|| (ai.getLife() <= phyLifeToPay && !ai.cantLoseForZeroOrLessLife())) {
// cannot pay
break;
}
if (test) {
phyLifeToPay += 2;
}
if (sa.hasParam("AIPhyrexianPayment")) {
@@ -958,7 +963,6 @@ public class ComputerUtilMana {
if (checkCosts) {
// Check if AI can still play this mana ability
ma.setActivatingPlayer(ai);
// if the AI can't pay the additional costs skip the mana ability
if (!CostPayment.canPayAdditionalCosts(ma.getPayCosts(), ma, false)) {
return false;
} else if (ma.getRestrictions() != null && ma.getRestrictions().isInstantSpeed()) {
@@ -976,9 +980,10 @@ public class ComputerUtilMana {
continue;
}
if ("Any".equals(s) || ai.getManaPool().canPayForShardWithColor(toPay, ManaAtom.fromName(s)))
if ("Any".equals(s) || ai.getManaPool().canPayForShardWithColor(toPay, ManaAtom.fromName(s))){
return true;
}
}
return false;
}
@@ -1503,7 +1508,7 @@ public class ComputerUtilMana {
AbilitySub sub = m.getSubAbility();
// We really shouldn't be hardcoding names here. ChkDrawback should just return true for them
if (sub != null && !card.getName().equals("Pristine Talisman") && !card.getName().equals("Zhur-Taa Druid")) {
if (!SpellApiToAi.Converter.get(sub).chkDrawbackWithSubs(ai, sub)) {
if (!SpellApiToAi.Converter.get(sub).chkDrawbackWithSubs(ai, sub).willingToPlay()) {
continue;
}
needsLimitedResources = true; // TODO: check for good drawbacks (gainLife)
@@ -1583,7 +1588,7 @@ public class ComputerUtilMana {
// don't use abilities with dangerous drawbacks
AbilitySub sub = m.getSubAbility();
if (sub != null) {
if (!SpellApiToAi.Converter.get(sub).chkDrawbackWithSubs(ai, sub)) {
if (!SpellApiToAi.Converter.get(sub).chkDrawbackWithSubs(ai, sub).willingToPlay()) {
continue;
}
}

View File

@@ -1263,7 +1263,7 @@ public abstract class GameState {
} else if (cardinfo[0].startsWith("T:")) {
String tokenStr = cardinfo[0].substring(2);
PaperToken token = StaticData.instance().getAllTokens().getToken(tokenStr,
setCode != null ? setCode : CardEdition.UNKNOWN.getName());
setCode != null ? setCode : CardEdition.UNKNOWN_CODE);
if (token == null) {
System.err.println("ERROR: Tried to create a non-existent token named " + cardinfo[0] + " when loading game state!");
continue;

View File

@@ -214,7 +214,7 @@ public class SpecialAiLogic {
}
// A logic for cards that say "Sacrifice a creature: put X +1/+1 counters on CARDNAME" (e.g. Falkenrath Aristocrat)
public static boolean doAristocratWithCountersLogic(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision doAristocratWithCountersLogic(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
final String logic = sa.getParam("AILogic"); // should not even get here unless there's an Aristocrats logic applied
final boolean isDeclareBlockers = ai.getGame().getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS);
@@ -222,14 +222,14 @@ public class SpecialAiLogic {
final int numOtherCreats = Math.max(0, ai.getCreaturesInPlay().size() - 1);
if (numOtherCreats == 0) {
// Cut short if there's nothing to sac at all
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
// Check if the standard Aristocrats logic applies first (if in the right conditions for it)
final boolean isThreatened = ComputerUtil.predictThreatenedObjects(ai, null, true).contains(source);
if (isDeclareBlockers || isThreatened) {
if (doAristocratLogic(ai, sa)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -247,7 +247,7 @@ public class SpecialAiLogic {
if (countersSa == null) {
// Shouldn't get here if there is no PutCounter subability (wrong AI logic specified?)
System.err.println("Warning: AILogic AristocratCounters was specified on " + source + ", but there was no PutCounter SA in chain!");
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
final Game game = ai.getGame();
@@ -263,7 +263,7 @@ public class SpecialAiLogic {
relevantCreats.remove(source);
if (relevantCreats.isEmpty()) {
// No relevant creatures to sac
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
int numCtrs = AbilityUtils.calculateAmount(source, countersSa.getParam("CounterNum"), countersSa);
@@ -287,16 +287,20 @@ public class SpecialAiLogic {
|| (combat.isAttacking(card) && combat.isBlocked(card) && ComputerUtilCombat.combatantWouldBeDestroyed(ai, card, combat))
);
if (!forcedSacTgts.isEmpty()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
final int numCreatsToSac = Math.max(0, (lethalDmg - source.getNetCombatDamage()) / numCtrs);
if (defTappedOut || numCreatsToSac < relevantCreats.size() / 2) {
return source.getNetCombatDamage() < lethalDmg
&& source.getNetCombatDamage() + relevantCreats.size() * numCtrs >= lethalDmg;
if (source.getNetCombatDamage() < lethalDmg
&& source.getNetCombatDamage() + relevantCreats.size() * numCtrs >= lethalDmg) {
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// We have already attacked. Thus, see if we have a creature to sac that is worse to lose
@@ -309,7 +313,7 @@ public class SpecialAiLogic {
);
if (sacTgts.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
final boolean sourceCantDie = ComputerUtilCombat.combatantCantBeDestroyed(ai, source);
@@ -317,7 +321,10 @@ public class SpecialAiLogic {
final int DefP = sourceCantDie ? 0 : Aggregates.sum(combat.getBlockers(source), Card::getNetPower);
// Make sure we don't over-sacrifice, only sac until we can survive and kill a creature
return source.getNetToughness() - source.getDamage() <= DefP || source.getNetCombatDamage() < minDefT;
if (source.getNetToughness() - source.getDamage() <= DefP || source.getNetCombatDamage() < minDefT) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// We can't deal lethal, check if there's any sac fodder than can be used for other circumstances
@@ -329,7 +336,11 @@ public class SpecialAiLogic {
|| ComputerUtil.predictThreatenedObjects(ai, null, true).contains(card)
);
return !sacFodder.isEmpty();
if (sacFodder.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -360,10 +371,10 @@ public class SpecialAiLogic {
// FIXME: We're emulating the UnlessCost on the SA to run the proper checks.
// This is hacky, but it works. Perhaps a cleaner way exists?
sa.getMapParams().put("UnlessCost", falseSub.getParam("UnlessCost"));
willPlay = SpellApiToAi.Converter.get(ApiType.Counter).canPlayAIWithSubs(ai, sa);
willPlay = SpellApiToAi.Converter.get(ApiType.Counter).canPlayWithSubs(ai, sa).willingToPlay();
sa.getMapParams().remove("UnlessCost");
} else {
willPlay = SpellApiToAi.Converter.get(ApiType.Counter).canPlayAIWithSubs(ai, sa);
willPlay = SpellApiToAi.Converter.get(ApiType.Counter).canPlayWithSubs(ai, sa).willingToPlay();
}
return willPlay;
}

View File

@@ -78,16 +78,17 @@ public class SpecialCardAi {
// Arena and Magus of the Arena
public static class Arena {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
final Game game = ai.getGame();
// TODO This is basically removal, so we may want to play this at other times
if (!game.getPhaseHandler().is(PhaseType.END_OF_TURN) || game.getPhaseHandler().getNextTurn() != ai) {
return false; // at opponent's EOT only, to conserve mana
return new AiAbilityDecision(0, AiPlayDecision.WaitForEndOfTurn);
}
CardCollection aiCreatures = ai.getCreaturesInPlay();
if (aiCreatures.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
for (Player opp : ai.getOpponents()) {
@@ -111,11 +112,11 @@ public class SpecialCardAi {
if (canKillAll) {
sa.getTargets().clear();
sa.getTargets().add(aiCreature);
return true;
return new AiAbilityDecision(100, AiPlayDecision.Removal);
}
}
}
return sa.isTargetNumberValid();
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -203,7 +204,7 @@ public class SpecialCardAi {
// Chain of Acid
public static class ChainOfAcid {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
List<Card> AiLandsOnly = CardLists.filter(ai.getCardsIn(ZoneType.Battlefield),
CardPredicates.LANDS);
List<Card> OppPerms = CardLists.filter(ai.getOpponents().getCardsIn(ZoneType.Battlefield),
@@ -213,13 +214,22 @@ public class SpecialCardAi {
// which it can only distinguish by their CMC, considering >CMC higher value).
// Currently ensures that the AI will still have lands provided that the human player goes to
// destroy all the AI's lands in order (to avoid manalock).
return !OppPerms.isEmpty() && AiLandsOnly.size() > OppPerms.size() + 2;
if (!OppPerms.isEmpty() && AiLandsOnly.size() > OppPerms.size() + 2) {
// If there are enough lands, target the worst non-creature permanent of the opponent
Card worstOppPerm = ComputerUtilCard.getWorstAI(OppPerms);
if (worstOppPerm != null) {
sa.resetTargets();
sa.getTargets().add(worstOppPerm);
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
// Chain of Smog
public static class ChainOfSmog {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
if (ai.getCardsIn(ZoneType.Hand).isEmpty()) {
// to avoid failure to add to stack, provide a legal target opponent first (choosing random at this point)
// TODO: this makes the AI target opponents with 0 cards in hand, but bailing from here causes a
@@ -235,10 +245,10 @@ public class SpecialCardAi {
sa.getParent().resetTargets();
sa.getParent().getTargets().add(targOpp);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@@ -359,18 +369,28 @@ public class SpecialCardAi {
private static final int demonSacThreshold = Integer.MAX_VALUE; // if we're in dire conditions, sac everything from worst to best hoping to find an answer
public static boolean considerSacrificingCreature(final Player ai, final SpellAbility sa) {
Card c = sa.getHostCard();
// Only check for sacrifice if it's the owner's turn, and it can attack.
// TODO: Maybe check if sacrificing a creature allows AI to kill the opponent with the rest on their turn?
if (!CombatUtil.canAttack(c) ||
!ai.getGame().getPhaseHandler().isPlayerTurn(sa.getActivatingPlayer())) {
return false;
}
CardCollection flyingCreatures = CardLists.filter(ai.getCardsIn(ZoneType.Battlefield),
CardPredicates.UNTAPPED.and(
CardPredicates.hasKeyword(Keyword.FLYING).or(CardPredicates.hasKeyword(Keyword.REACH))));
boolean hasUsefulBlocker = false;
for (Card c : flyingCreatures) {
if (!ComputerUtilCard.isUselessCreature(ai, c)) {
for (Card fc : flyingCreatures) {
if (!ComputerUtilCard.isUselessCreature(ai, fc)) {
hasUsefulBlocker = true;
break;
}
}
return ai.getLife() <= sa.getHostCard().getNetPower() && !hasUsefulBlocker;
return ai.getLife() <= c.getNetPower() && !hasUsefulBlocker;
}
public static int getSacThreshold() {
@@ -380,7 +400,7 @@ public class SpecialCardAi {
// Donate
public static class Donate {
public static boolean considerTargetingOpponent(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision considerTargetingOpponent(final Player ai, final SpellAbility sa) {
final Card donateTarget = ComputerUtil.getCardPreference(ai, sa.getHostCard(), "DonateMe", CardLists.filter(
ai.getCardsIn(ZoneType.Battlefield).threadSafeIterable(), CardPredicates.hasSVar("DonateMe")));
if (donateTarget != null) {
@@ -390,7 +410,7 @@ public class SpecialCardAi {
// All opponents have hexproof or something like that
if (Iterables.isEmpty(oppList)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// filter for player who does not have donate target already
@@ -408,31 +428,30 @@ public class SpecialCardAi {
if (opp != null) {
sa.resetTargets();
sa.getTargets().add(opp);
return true;
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// No targets found to donate, so do nothing.
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
public static boolean considerDonatingPermanent(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision considerDonatingPermanent(final Player ai, final SpellAbility sa) {
Card donateTarget = ComputerUtil.getCardPreference(ai, sa.getHostCard(), "DonateMe", CardLists.filter(ai.getCardsIn(ZoneType.Battlefield).threadSafeIterable(), CardPredicates.hasSVar("DonateMe")));
if (donateTarget != null) {
sa.resetTargets();
sa.getTargets().add(donateTarget);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// Should never get here because targetOpponent, called before targetPermanentToDonate, should already have made the AI bail
System.err.println("Warning: Donate AI failed at SpecialCardAi.Donate#targetPermanentToDonate despite successfully targeting an opponent first.");
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
// Electrostatic Pummeler
public static class ElectrostaticPummeler {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
Game game = ai.getGame();
Combat combat = game.getCombat();
@@ -445,13 +464,13 @@ public class SpecialCardAi {
if (saTop.getApi() == ApiType.DealDamage || saTop.getApi() == ApiType.DamageAll) {
int dmg = AbilityUtils.calculateAmount(saTop.getHostCard(), saTop.getParam("NumDmg"), saTop);
if (source.getNetToughness() - source.getDamage() <= dmg && predictedPT.getRight() - source.getDamage() > dmg)
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
// Do not activate if damage will be prevented
if (source.staticDamagePrevention(predictedPT.getLeft(), 0, source, true) == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactGame);
}
// Activate Electrostatic Pummeler's pump only as a combat trick
@@ -460,14 +479,14 @@ public class SpecialCardAi {
// We'll try to deal lethal trample/unblocked damage, so remember the card for attack
// and wait until declare blockers step.
AiCardMemory.rememberCard(ai, source, AiCardMemory.MemorySet.MANDATORY_ATTACKERS);
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (!game.getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
if (combat == null || !(combat.isAttacking(source) || combat.isBlocking(source))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
boolean isBlocking = combat.isBlocking(source);
@@ -492,11 +511,11 @@ public class SpecialCardAi {
}
if (totalDamageToPW >= oppT + loyalty) {
// Already enough damage to take care of the planeswalker
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
if ((unblocked || canTrample) && predictedPT.getLeft() >= oppT + loyalty) {
// Can pump to kill the planeswalker, go for it
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
}
@@ -517,31 +536,31 @@ public class SpecialCardAi {
// We can deal a lot of damage (either a lot of damage directly to the opponent,
// or kill the blocker(s) and damage the opponent at the same time, so go for it
AiCardMemory.rememberCard(ai, source, AiCardMemory.MemorySet.MANDATORY_ATTACKERS);
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
}
if (predictedPT.getRight() - source.getDamage() <= oppP && oppHasFirstStrike && !cantDie) {
// Can't survive first strike or double strike, don't pump
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
if (predictedPT.getLeft() < oppT && (!cantDie || predictedPT.getRight() - source.getDamage() <= oppP)) {
// Can't pump enough to kill the blockers and survive, don't pump
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
if (source.getNetCombatDamage() > oppT && source.getNetToughness() > oppP) {
// Already enough to kill the blockers and survive, don't overpump
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
if (oppCantDie && !source.hasKeyword(Keyword.TRAMPLE) && !source.isWitherDamage()
&& predictedPT.getLeft() <= oppT) {
// Can't kill or cripple anyone, as well as can't Trample over, so don't pump
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
// If we got here, it should be a favorable combat pump, resulting in at least one
// opposing creature dying, and hopefully with the Pummeler surviving combat.
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
public static boolean predictOverwhelmingDamage(final Player ai, final SpellAbility sa) {
@@ -618,15 +637,15 @@ public class SpecialCardAi {
// Fell the Mighty
public static class FellTheMighty {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
CardCollection aiList = ai.getCreaturesInPlay();
if (aiList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
CardLists.sortByPowerAsc(aiList);
Card lowest = aiList.get(0);
if (!sa.canTarget(lowest)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
CardCollection oppList = CardLists.filter(ai.getGame().getCardsIn(ZoneType.Battlefield),
@@ -636,9 +655,9 @@ public class SpecialCardAi {
if (ComputerUtilCard.evaluateCreatureList(oppList) > 200) {
sa.resetTargets();
sa.getTargets().add(lowest);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@@ -673,25 +692,25 @@ public class SpecialCardAi {
// Gideon Blackblade
public static class GideonBlackblade {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
sa.resetTargets();
CardCollectionView otb = CardLists.filter(ai.getCardsIn(ZoneType.Battlefield), CardPredicates.isTargetableBy(sa));
if (!otb.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestAI(otb));
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
// Goblin Polka Band
public static class GoblinPolkaBand {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
int maxPotentialTgts = ai.getOpponents().getCreaturesInPlay().filter(CardPredicates.UNTAPPED).size();
int maxPotentialPayment = ComputerUtilMana.determineLeftoverMana(sa, ai, "R", false);
int numTgts = Math.min(maxPotentialPayment, maxPotentialTgts);
if (numTgts == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// Set Announce
@@ -701,7 +720,7 @@ public class SpecialCardAi {
List<GameEntity> validTgts = sa.getTargetRestrictions().getAllCandidates(sa, true);
sa.resetTargets();
sa.getTargets().addAll(Aggregates.random(validTgts, numTgts));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -910,12 +929,12 @@ public class SpecialCardAi {
// Living Death (and other similar cards using AILogic LivingDeath or AILogic ReanimateAll)
public static class LivingDeath {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
// if there's another reanimator card currently suspended, don't cast a new one until the previous
// one resolves, otherwise the reanimation attempt will be ruined (e.g. Living End)
for (Card ex : ai.getCardsIn(ZoneType.Exile)) {
if (ex.hasSVar("IsReanimatorCard") && ex.getCounters(CounterEnumType.TIME) > 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -926,7 +945,7 @@ public class SpecialCardAi {
if (aiCreaturesInGY.isEmpty()) {
// nothing in graveyard, so cut short
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
for (Card c : ai.getCreaturesInPlay()) {
@@ -958,17 +977,30 @@ public class SpecialCardAi {
}
// if we get more value out of this than our opponent does (hopefully), go for it
return (aiGraveyardPower - aiBattlefieldPower) > (oppGraveyardPower - oppBattlefieldPower + threshold);
if ((aiGraveyardPower - aiBattlefieldPower) > (oppGraveyardPower - oppBattlefieldPower + threshold)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// Maze's End
public static class MazesEnd {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
PhaseHandler ph = ai.getGame().getPhaseHandler();
CardCollection availableGates = CardLists.filter(ai.getCardsIn(ZoneType.Library), CardPredicates.isType("Gate"));
return ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn() == ai && !availableGates.isEmpty();
if (ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn() == ai && !availableGates.isEmpty()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (availableGates.isEmpty()) {
// No gates available, so don't activate Maze's End
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
public static Card considerCardToGet(final Player ai, final SpellAbility sa)
@@ -1032,29 +1064,33 @@ public class SpecialCardAi {
return exiledWith == null || (tgt != null && ComputerUtilCard.evaluateCreature(tgt) > ComputerUtilCard.evaluateCreature(exiledWith));
}
public static boolean considerCopy(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision considerCopy(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
final Card exiledWith = source.getImprintedCards().isEmpty() ? null : source.getImprintedCards().getFirst();
if (exiledWith == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
// We want to either be able to attack with the creature, or keep it until our opponent's end of turn as a
// potential blocker
return ComputerUtilCard.doesSpecifiedCreatureAttackAI(ai, exiledWith)
if (ComputerUtilCard.doesSpecifiedCreatureAttackAI(ai, exiledWith)
|| (ai.getGame().getPhaseHandler().getPlayerTurn().isOpponentOf(ai) && ai.getGame().getCombat() != null
&& !ai.getGame().getCombat().getAttackers().isEmpty());
&& !ai.getGame().getCombat().getAttackers().isEmpty())) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// Momir Vig, Simic Visionary Avatar
public static class MomirVigAvatar {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
Card source = sa.getHostCard();
if (source.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.MAIN1)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
// In MoJhoSto, prefer Jhoira sorcery ability from time to time
@@ -1065,7 +1101,7 @@ public class SpecialCardAi {
int numLandsForJhoira = aic.getIntProperty(AiProps.MOJHOSTO_NUM_LANDS_TO_ACTIVATE_JHOIRA);
if (ai.getLandsInPlay().size() >= numLandsForJhoira && MyRandom.percentTrue(chanceToPrefJhoira)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
}
@@ -1074,7 +1110,7 @@ public class SpecialCardAi {
// Some basic strategy for Momir
if (tokenSize < 2) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
if (tokenSize > 11) {
@@ -1083,7 +1119,7 @@ public class SpecialCardAi {
sa.setXManaCostPaid(tokenSize);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -1122,13 +1158,13 @@ public class SpecialCardAi {
// Necropotence
public static class Necropotence {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
Game game = ai.getGame();
int computerHandSize = ai.getZone(ZoneType.Hand).size();
int maxHandSize = ai.getMaxHandSize();
if (ai.getCardsIn(ZoneType.Library).isEmpty()) {
return false; // nothing to draw from the library
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (ai.getCardsIn(ZoneType.Battlefield).anyMatch(CardPredicates.nameEquals("Yawgmoth's Bargain"))) {
@@ -1136,7 +1172,7 @@ public class SpecialCardAi {
// TODO: in presence of bad effects which deal damage when a card is drawn, probably better to prefer Necropotence instead?
// (not sure how to detect the presence of such effects yet)
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
PhaseHandler ph = game.getPhaseHandler();
@@ -1158,23 +1194,33 @@ public class SpecialCardAi {
// We're in a situation when we have nothing castable in hand, something needs to be done
if (!blackViseOTB) {
// exile-loot +1 card when at max hand size, hoping to get a workable spell or land
return computerHandSize + exiledWithNecro - 1 == maxHandSize;
if (computerHandSize + exiledWithNecro - 1 == maxHandSize) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// Loot to 7 in presence of Black Vise, hoping to find what to do
// NOTE: can still currently get theoretically locked with 7 uncastable spells. Loot to 8 instead?
return computerHandSize + exiledWithNecro <= maxHandSize;
if (computerHandSize + exiledWithNecro <= maxHandSize) {
// Loot to 7, hoping to find something playable
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// Loot to 8, hoping to find something playable
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else if (blackViseOTB && computerHandSize + exiledWithNecro - 1 >= 4) {
// try not to overdraw in presence of Black Vise
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (computerHandSize + exiledWithNecro - 1 >= maxHandSize) {
// Only draw until we reach max hand size
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (!ph.isPlayerTurn(ai) || !ph.is(PhaseType.MAIN2)) {
// Only activate in AI's own turn (sans the exception above)
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -1294,7 +1340,7 @@ public class SpecialCardAi {
}
}
public static boolean considerSecondTarget(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision considerSecondTarget(final Player ai, final SpellAbility sa) {
Card firstTgt = sa.getParent().getTargetCard();
CardCollection candidates = ai.getOpponents().getCardsIn(ZoneType.Battlefield).filter(
CardPredicates.sharesCardTypeWith(firstTgt).and(CardPredicates.isTargetableBy(sa)));
@@ -1302,23 +1348,25 @@ public class SpecialCardAi {
if (secondTgt != null) {
sa.resetTargets();
sa.getTargets().add(secondTgt);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// Price of Progress
public static class PriceOfProgress {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
// Don't play in early game - opponent likely still has lands to play
if (ai.getGame().getPhaseHandler().getTurn() < 10) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
int aiLands = CardLists.filter(ai.getCardsIn(ZoneType.Battlefield), CardPredicates.NONBASIC_LANDS).size();
// TODO Better if we actually calculate the true damage
boolean willDieToPCasting = (ai.getLife() <= aiLands * 2);
if (!willDieToPCasting) {
boolean hasBridge = false;
for (Card c : ai.getCardsIn(ZoneType.Battlefield)) {
// Do we have a card in play that makes us want to empty out hand?
@@ -1330,61 +1378,75 @@ public class SpecialCardAi {
// Do if we need to lose cards to activate Ensnaring Bridge or Cursed Scroll
// even if suboptimal play, but don't waste the card too early even then!
if ((hasBridge) && (ai.getGame().getPhaseHandler().getTurn() >= 10)) {
return true;
if (hasBridge) {
return new AiAbilityDecision(100, AiPlayDecision.PlayToEmptyHand);
}
}
boolean willPlay = true;
for (Player opp : ai.getOpponents()) {
int oppLands = CardLists.filter(opp.getCardsIn(ZoneType.Battlefield), CardPredicates.NONBASIC_LANDS).size();
// Don't if no enemy nonbasic lands
if (oppLands == 0) {
willPlay = false;
continue;
}
// Always if enemy would die and we don't!
// TODO : predict actual damage instead of assuming it'll be 2*lands
// Don't if we lose, unless we lose anyway to unblocked creatures next turn
if ((ai.getLife() <= aiLands * 2) &&
if (willDieToPCasting &&
(!(ComputerUtil.aiLifeInDanger(ai, true, 0)) && ((ai.getOpponentsSmallestLifeTotal()) <= oppLands * 2))) {
return false;
willPlay = false;
}
// Do if we can win
if ((ai.getOpponentsSmallestLifeTotal()) <= oppLands * 2) {
return true;
if (opp.getLife() <= oppLands * 2) {
return new AiAbilityDecision(1000, AiPlayDecision.WillPlay);
}
// Don't if we'd lose a larger percentage of our remaining life than enemy
if ((aiLands / ((double) ai.getLife())) >
(oppLands / ((double) ai.getOpponentsSmallestLifeTotal()))) {
return false;
}
// Don't if no enemy nonbasic lands
if (oppLands == 0) {
return false;
willPlay = false;
}
// Don't if loss is equal in percentage but we lose more points
if (((aiLands / ((double) ai.getLife())) == (oppLands / ((double) ai.getOpponentsSmallestLifeTotal())))
&& (aiLands > oppLands)) {
return false;
willPlay = false;
}
}
return true;
if (willPlay) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// Sarkhan the Mad
public static class SarkhanTheMad {
public static boolean considerDig(final Player ai, final SpellAbility sa) {
return sa.getHostCard().getCounters(CounterEnumType.LOYALTY) == 1;
public static AiAbilityDecision considerDig(final Player ai, final SpellAbility sa) {
if (sa.getHostCard().getCounters(CounterEnumType.LOYALTY) == 1) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
public static boolean considerMakeDragon(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision considerMakeDragon(final Player ai, final SpellAbility sa) {
// TODO: expand this logic to make the AI force the opponent to sacrifice a big threat bigger than a 5/5 flier?
CardCollection creatures = ai.getCreaturesInPlay();
boolean hasValidTgt = !CardLists.filter(creatures, t -> t.getNetPower() < 5 && t.getNetToughness() < 5).isEmpty();
if (hasValidTgt) {
Card worstCreature = ComputerUtilCard.getWorstCreatureAI(creatures);
sa.getTargets().add(worstCreature);
return true;
return new AiAbilityDecision(100, AiPlayDecision.AddBoardPresence);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
public static boolean considerUltimate(final Player ai, final SpellAbility sa, final Player weakestOpp) {
int minLife = weakestOpp.getLife();
@@ -1440,7 +1502,7 @@ public class SpecialCardAi {
// Sorin, Vengeful Bloodlord
public static class SorinVengefulBloodlord {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
int loyalty = sa.getHostCard().getCounters(CounterEnumType.LOYALTY);
CardCollection creaturesToGet = CardLists.filter(ai.getCardsIn(ZoneType.Graveyard),
CardPredicates.CREATURES
@@ -1454,7 +1516,7 @@ public class SpecialCardAi {
CardLists.sortByCmcDesc(creaturesToGet);
if (creaturesToGet.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// pick the best creature that will stay on the battlefield
@@ -1470,10 +1532,10 @@ public class SpecialCardAi {
sa.resetTargets();
sa.getTargets().add(best);
sa.setXManaCostPaid(best.getCMC());
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@@ -1587,23 +1649,27 @@ public class SpecialCardAi {
// The One Ring
public static class TheOneRing {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
if (!ai.canLoseLife() || ai.cantLoseForZeroOrLessLife()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
AiController aic = ((PlayerControllerAi) ai.getController()).getAi();
int lifeInDanger = aic.getIntProperty(AiProps.AI_IN_DANGER_THRESHOLD);
int numCtrs = sa.getHostCard().getCounters(CounterEnumType.BURDEN);
return ai.getLife() > numCtrs + 1 && ai.getLife() > lifeInDanger
&& ai.getMaxHandSize() >= ai.getCardsIn(ZoneType.Hand).size() + numCtrs + 1;
if (ai.getLife() > numCtrs + 1 && ai.getLife() > lifeInDanger
&& ai.getMaxHandSize() >= ai.getCardsIn(ZoneType.Hand).size() + numCtrs + 1) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.LifeInDanger);
}
}
// The Scarab God
public static class TheScarabGod {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
Card bestOppCreat = ComputerUtilCard.getBestAI(CardLists.filter(ai.getOpponents().getCardsIn(ZoneType.Graveyard), CardPredicates.CREATURES));
Card worstOwnCreat = ComputerUtilCard.getWorstAI(CardLists.filter(ai.getCardsIn(ZoneType.Graveyard), CardPredicates.CREATURES));
@@ -1614,13 +1680,19 @@ public class SpecialCardAi {
sa.getTargets().add(worstOwnCreat);
}
return sa.getTargets().size() > 0;
if (!sa.getTargets().isEmpty()) {
// If we have a target, we can play this ability
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// No valid targets, can't play this ability
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
}
// Timetwister
public static class Timetwister {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
final int aiHandSize = ai.getCardsIn(ZoneType.Hand).size();
int maxOppHandSize = 0;
@@ -1634,7 +1706,14 @@ public class SpecialCardAi {
}
// use in case we're getting low on cards or if we're significantly behind our opponent in cards in hand
return aiHandSize < HAND_SIZE_THRESHOLD || maxOppHandSize - aiHandSize > HAND_SIZE_THRESHOLD;
if (aiHandSize < HAND_SIZE_THRESHOLD || maxOppHandSize - aiHandSize > HAND_SIZE_THRESHOLD) {
// if the AI has less than 3 cards in hand or the opponent has more than 3 cards in hand than the AI
// then the AI is willing to play this ability
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// otherwise, don't play this ability
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -1695,12 +1774,12 @@ public class SpecialCardAi {
// Volrath's Shapeshifter
public static class VolrathsShapeshifter {
public static boolean consider(final Player ai, final SpellAbility sa) {
public static AiAbilityDecision consider(final Player ai, final SpellAbility sa) {
PhaseHandler ph = ai.getGame().getPhaseHandler();
if (ph.getPhase().isBefore(PhaseType.COMBAT_BEGIN)) {
// try not to do this too early to at least attempt to avoid situations where the AI
// would cast a spell which would ruin the shapeshifting
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
CardCollectionView aiGY = ai.getCardsIn(ZoneType.Graveyard);
@@ -1716,11 +1795,15 @@ public class SpecialCardAi {
if (topGY == null
|| !topGY.isCreature()
|| ComputerUtilCard.evaluateCreature(creatHand) > ComputerUtilCard.evaluateCreature(topGY) + 80) {
return numCreatsInHand > 1 || !ComputerUtilMana.canPayManaCost(creatHand.getSpellPermanent(), ai, 0, false);
if ( numCreatsInHand > 1 || !ComputerUtilMana.canPayManaCost(creatHand.getSpellPermanent(), ai, 0, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
public static CardCollection targetBestCreature(final Player ai, final SpellAbility sa) {

View File

@@ -39,70 +39,75 @@ import forge.util.collect.FCollectionView;
*/
public abstract class SpellAbilityAi {
public final boolean canPlayAIWithSubs(final Player aiPlayer, final SpellAbility sa) {
if (!canPlayAI(aiPlayer, sa)) {
return false;
public final AiAbilityDecision canPlayWithSubs(final Player aiPlayer, final SpellAbility sa) {
AiAbilityDecision decision = canPlay(aiPlayer, sa);
if (!decision.willingToPlay() && !"PlayForSub".equals(sa.getParam("AILogic"))) {
return decision;
}
final AbilitySub subAb = sa.getSubAbility();
return subAb == null || chkDrawbackWithSubs(aiPlayer, subAb);
if (subAb == null) {
return decision;
}
return chkDrawbackWithSubs(aiPlayer, subAb);
}
/**
* Handles the AI decision to play a "main" SpellAbility
*/
protected boolean canPlayAI(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
if (sa.getRestrictions() != null && !sa.getRestrictions().canPlay(source, sa)) {
return false;
protected AiAbilityDecision canPlay(final Player ai, final SpellAbility sa) {
if (sa.getRestrictions() != null && !sa.getRestrictions().canPlay(sa.getHostCard(), sa)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
return canPlayWithoutRestrict(ai, sa);
}
protected boolean canPlayWithoutRestrict(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision canPlayWithoutRestrict(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
final Cost cost = sa.getPayCosts();
if (sa.hasParam("AICheckCanPlayWithDefinedX")) {
// FIXME: can this somehow be simplified without the need for an extra AI hint?
sa.setXManaCostPaid(ComputerUtilCost.getMaxXValue(sa, ai, false));
}
if (!checkConditions(ai, sa, sa.getConditions())) {
SpellAbility sub = sa.getSubAbility();
if (sub != null && !checkConditions(ai, sub, sub.getConditions())) {
return false;
}
}
if (sa.hasParam("AILogic")) {
final String logic = sa.getParam("AILogic");
final boolean alwaysOnDiscard = "AlwaysOnDiscard".equals(logic) && ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN, ai)
&& !ai.isUnlimitedHandSize() && ai.getCardsIn(ZoneType.Hand).size() > ai.getMaxHandSize();
if (!checkAiLogic(ai, sa, logic)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (!alwaysOnDiscard && !checkPhaseRestrictions(ai, sa, ai.getGame().getPhaseHandler(), logic)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingPhaseRestrictions);
}
} else if (!checkPhaseRestrictions(ai, sa, ai.getGame().getPhaseHandler())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingPhaseRestrictions);
} else if (ComputerUtil.preventRunAwayActivations(sa)) {
return new AiAbilityDecision(0, AiPlayDecision.StopRunawayActivations);
}
if (!checkApiLogic(ai, sa)) {
return false;
AiAbilityDecision decision = checkApiLogic(ai, sa);
if (!decision.willingToPlay()) {
return decision;
}
// needs to be after API logic because needs to check possible X Cost?
// needs to be after API logic because needs to check possible X Cost
if (cost != null && !willPayCosts(ai, sa, cost, source)) {
return false;
}
return true;
return new AiAbilityDecision(0, AiPlayDecision.CostNotAcceptable);
}
protected boolean checkConditions(final Player ai, final SpellAbility sa, SpellAbilityCondition con) {
// for cards like Figure of Destiny
// (it's unlikely many valid effect would work like this -
// and while in theory AI could turn some conditions true in response that's far too advanced as default)
if (!checkConditions(ai, sa)) {
SpellAbility sub = sa.getSubAbility();
if (sub == null || !checkConditions(ai, sub)) {
return new AiAbilityDecision(0, AiPlayDecision.NeedsToPlayCriteriaNotMet);
}
}
return decision;
}
protected boolean checkConditions(final Player ai, final SpellAbility sa) {
// copy it to disable some checks that the AI need to check extra
con = (SpellAbilityCondition) con.copy();
SpellAbilityCondition con = (SpellAbilityCondition) sa.getConditions().copy();
// if manaspent, check if AI can pay the colored mana as cost
if (!con.getManaSpent().isEmpty()) {
@@ -116,40 +121,6 @@ public abstract class SpellAbilityAi {
return con.areMet(sa);
}
/**
* Checks if the AI will play a SpellAbility with the specified AiLogic
*/
protected boolean checkAiLogic(final Player ai, final SpellAbility sa, final String aiLogic) {
if (aiLogic.equals("CheckCondition")) {
SpellAbility saCopy = sa.copy();
saCopy.setActivatingPlayer(ai);
return saCopy.metConditions();
}
return !("Never".equals(aiLogic));
}
/**
* Checks if the AI is willing to pay for additional costs
* <p>
* Evaluated costs are: life, discard, sacrifice and counter-removal
*/
protected boolean willPayCosts(final Player ai, final SpellAbility sa, final Cost cost, final Card source) {
if (!ComputerUtilCost.checkLifeCost(ai, cost, source, 4, sa)) {
return false;
}
if (!ComputerUtilCost.checkDiscardCost(ai, cost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkSacrificeCost(ai, cost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkRemoveCounterCost(cost, source, sa)) {
return false;
}
return true;
}
/**
* Checks if the AI will play a SpellAbility based on its phase restrictions
*/
@@ -159,19 +130,38 @@ public abstract class SpellAbilityAi {
protected boolean checkPhaseRestrictions(final Player ai, final SpellAbility sa, final PhaseHandler ph,
final String logic) {
if (logic.equals("AtOppEOT")) {
return ph.getNextTurn() == ai && ph.is(PhaseType.END_OF_TURN);
}
return checkPhaseRestrictions(ai, sa, ph);
}
/**
* Checks if the AI will play a SpellAbility with the specified AiLogic
*/
protected boolean checkAiLogic(final Player ai, final SpellAbility sa, final String aiLogic) {
if ("Never".equals(aiLogic)) {
return false;
}
if (!"Once".equals(aiLogic)) {
return !AiCardMemory.isRememberedCard(ai, sa.getHostCard(), AiCardMemory.MemorySet.ACTIVATED_THIS_TURN);
}
return true;
}
/**
* The rest of the logic not covered by the canPlayAI template is defined here
*/
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false; // prevent infinite loop
}
return MyRandom.getRandom().nextFloat() < .8f; // random success
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
if (MyRandom.getRandom().nextFloat() < .8f) {
// 80% chance to play the ability
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public final boolean doTriggerAI(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
public final boolean doTrigger(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
// this evaluation order is currently intentional as it does more stuff that helps avoiding some crashes
if (!ComputerUtilCost.canPayCost(sa, aiPlayer, true) && !mandatory) {
return false;
@@ -183,28 +173,48 @@ public abstract class SpellAbilityAi {
return sa.isTargetNumberValid();
}
return doTriggerNoCostWithSubs(aiPlayer, sa, mandatory);
return doTriggerNoCostWithSubs(aiPlayer, sa, mandatory).willingToPlay();
}
public final boolean doTriggerNoCostWithSubs(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
if (!doTriggerAINoCost(aiPlayer, sa, mandatory) && !"Always".equals(sa.getParam("AILogic"))) {
return false;
public final AiAbilityDecision doTriggerNoCostWithSubs(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
AiAbilityDecision decision = doTriggerNoCost(aiPlayer, sa, mandatory);
if (!decision.willingToPlay() && !"Always".equals(sa.getParam("AILogic"))) {
return decision;
}
final AbilitySub subAb = sa.getSubAbility();
return subAb == null || chkDrawbackWithSubs(aiPlayer, subAb) || mandatory;
if (subAb == null) {
if (decision.willingToPlay()) {
return decision;
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
decision = chkDrawbackWithSubs(aiPlayer, subAb);
if (decision.willingToPlay()) {
return decision;
}
if (mandatory) {
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/**
* Handles the AI decision to play a triggered SpellAbility
*/
protected boolean doTriggerAINoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
if (canPlayWithoutRestrict(aiPlayer, sa) && (!mandatory || sa.isTargetNumberValid())) {
return true;
protected AiAbilityDecision doTriggerNoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
AiAbilityDecision decision = canPlayWithoutRestrict(aiPlayer, sa);
if (decision.willingToPlay() && (!mandatory || sa.isTargetNumberValid())) {
// This is a weird check. Why do we care if its not mandatory if we WANT to do it?
return decision;
}
// not mandatory, short way out
if (!mandatory) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// invalid target might prevent it
@@ -220,82 +230,13 @@ public abstract class SpellAbilityAi {
if (sa.canTarget(p)) {
sa.resetTargets();
sa.getTargets().add(p);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
return true;
}
/**
* Handles the AI decision to play a sub-SpellAbility
*/
public boolean chkAIDrawback(final SpellAbility sa, final Player aiPlayer) {
// sub-SpellAbility might use targets too
if (sa.usesTargeting()) {
// no Candidates, no adding to Stack
if (!sa.getTargetRestrictions().hasCandidates(sa)) {
return false;
}
// but if it does, it should override this function
System.err.println("Warning: default (ie. inherited from base class) implementation of chkAIDrawback is used by " + sa.getHostCard().getName() + " for " + this.getClass().getName() + ". Consider declaring an overloaded method");
return false;
}
return true;
}
/**
* <p>
* isSorcerySpeed.
* </p>
*
* @param sa
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
protected static boolean isSorcerySpeed(final SpellAbility sa, Player ai) {
return (sa.getRootAbility().isSpell() && sa.getHostCard().isSorcery())
|| (sa.getRootAbility().isActivatedAbility() && sa.getRootAbility().getRestrictions().isSorcerySpeed())
|| (sa.getRootAbility().isAdventure() && sa.getHostCard().getState(CardStateName.Secondary).getType().isSorcery())
|| (sa.isPwAbility() && !sa.withFlash(sa.getHostCard(), ai));
}
/**
* <p>
* playReusable.
* </p>
*
* @param sa
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
protected static boolean playReusable(final Player ai, final SpellAbility sa) {
PhaseHandler phase = ai.getGame().getPhaseHandler();
// TODO probably also consider if winter orb or similar are out
if (sa instanceof AbilitySub) {
return true; // This is only true for Drawbacks and triggers
}
if (!sa.getPayCosts().isReusuableResource()) {
return false;
}
if (ComputerUtil.playImmediately(ai, sa)) {
return true;
}
if (sa.isPwAbility() && phase.is(PhaseType.MAIN2)) {
return true;
}
if (sa.isSpell() && !sa.isBuyback()) {
return false;
}
return phase.is(PhaseType.END_OF_TURN) && phase.getNextTurn().equals(ai);
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/**
@@ -304,9 +245,35 @@ public abstract class SpellAbilityAi {
* @param ab
* @return
*/
public boolean chkDrawbackWithSubs(Player aiPlayer, AbilitySub ab) {
public AiAbilityDecision chkDrawbackWithSubs(Player aiPlayer, AbilitySub ab) {
final AbilitySub subAb = ab.getSubAbility();
return SpellApiToAi.Converter.get(ab).chkAIDrawback(ab, aiPlayer) && (subAb == null || chkDrawbackWithSubs(aiPlayer, subAb));
AiAbilityDecision decision = SpellApiToAi.Converter.get(ab).chkDrawback(ab, aiPlayer);
if (!decision.willingToPlay()) {
return decision;
}
if (subAb == null) {
return decision;
}
return chkDrawbackWithSubs(aiPlayer, subAb);
}
/**
* Handles the AI decision to play a sub-SpellAbility
*/
public AiAbilityDecision chkDrawback(final SpellAbility sa, final Player aiPlayer) {
// sub-SpellAbility might use targets too
if (sa.usesTargeting()) {
// no Candidates, no adding to Stack
if (!sa.getTargetRestrictions().hasCandidates(sa)) {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// but if it does, it should override this function
System.err.println("Warning: default (ie. inherited from base class) implementation of chkAIDrawback is used by " + sa.getHostCard().getName() + " for " + this.getClass().getName() + ". Consider declaring an overloaded method");
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public boolean confirmAction(Player player, SpellAbility sa, PlayerActionConfirmMode mode, String message, Map<String, Object> params) {
@@ -314,25 +281,6 @@ public abstract class SpellAbilityAi {
return true;
}
public boolean willPayUnlessCost(SpellAbility sa, Player payer, Cost cost, boolean alreadyPaid, FCollectionView<Player> payers) {
final Card source = sa.getHostCard();
final String aiLogic = sa.getParam("UnlessAI");
boolean payNever = "Never".equals(aiLogic);
boolean isMine = sa.getActivatingPlayer().equals(payer);
if (payNever) { return false; }
// AI will only pay when it's not already payed and only opponents abilities
if (alreadyPaid || (payers.size() > 1 && isMine)) {
return false;
}
return ComputerUtilCost.checkLifeCost(payer, cost, source, 4, sa)
&& ComputerUtilCost.checkDamageCost(payer, cost, source, 4, sa)
&& (isMine || ComputerUtilCost.checkSacrificeCost(payer, cost, source, sa))
&& (isMine || ComputerUtilCost.checkDiscardCost(payer, cost, source, sa));
}
@SuppressWarnings("unchecked")
public <T extends GameEntity> T chooseSingleEntity(Player ai, SpellAbility sa, Collection<T> options, boolean isOptional, Player targetedPlayer, Map<String, Object> params) {
boolean hasPlayer = false;
@@ -412,6 +360,46 @@ public abstract class SpellAbilityAi {
return MyRandom.getRandom().nextBoolean();
}
/**
* Checks if the AI is willing to pay for additional costs
* <p>
* Evaluated costs are: life, discard, sacrifice and counter-removal
*/
protected boolean willPayCosts(final Player ai, final SpellAbility sa, final Cost cost, final Card source) {
if (!ComputerUtilCost.checkLifeCost(ai, cost, source, 4, sa)) {
return false;
}
if (!ComputerUtilCost.checkDiscardCost(ai, cost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkSacrificeCost(ai, cost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkRemoveCounterCost(cost, source, sa)) {
return false;
}
return true;
}
public boolean willPayUnlessCost(SpellAbility sa, Player payer, Cost cost, boolean alreadyPaid, FCollectionView<Player> payers) {
final Card source = sa.getHostCard();
final String aiLogic = sa.getParam("UnlessAI");
boolean payNever = "Never".equals(aiLogic);
boolean isMine = sa.getActivatingPlayer().equals(payer);
if (payNever) { return false; }
// AI will only pay when it's not already payed and only opponents abilities
if (alreadyPaid || (payers.size() > 1 && isMine)) {
return false;
}
return ComputerUtilCost.checkLifeCost(payer, cost, source, 4, sa)
&& ComputerUtilCost.checkDamageCost(payer, cost, source, 4, sa)
&& (isMine || ComputerUtilCost.checkSacrificeCost(payer, cost, source, sa))
&& (isMine || ComputerUtilCost.checkDiscardCost(payer, cost, source, sa));
}
public List<OptionalCostValue> chooseOptionalCosts(SpellAbility chosen, Player player, List<OptionalCostValue> optionalCostValues) {
List<OptionalCostValue> chosenOptCosts = Lists.newArrayList();
Cost costSoFar = chosen.getPayCosts().copy();
@@ -421,14 +409,14 @@ public abstract class SpellAbilityAi {
Cost fullCost = opt.getCost().copy().add(costSoFar);
SpellAbility fullCostSa = chosen.copyWithDefinedCost(fullCost);
// Playability check for Kicker
if (opt.getType() == OptionalCost.Kicker1 || opt.getType() == OptionalCost.Kicker2) {
SpellAbility kickedSaCopy = fullCostSa.copy();
kickedSaCopy.addOptionalCost(opt.getType());
Card copy = CardCopyService.getLKICopy(chosen.getHostCard());
copy.setCastSA(kickedSaCopy);
if (ComputerUtilCard.checkNeedsToPlayReqs(copy, kickedSaCopy) != AiPlayDecision.WillPlay) {
continue; // don't choose kickers we don't want to play
// don't choose kickers we don't want to play
continue;
}
}
@@ -440,4 +428,56 @@ public abstract class SpellAbilityAi {
return chosenOptCosts;
}
/**
* <p>
* isSorcerySpeed.
* </p>
*
* @param sa
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
protected static boolean isSorcerySpeed(final SpellAbility sa, Player ai) {
return (sa.getRootAbility().isSpell() && sa.getHostCard().isSorcery())
|| (sa.getRootAbility().isActivatedAbility() && sa.getRootAbility().getRestrictions().isSorcerySpeed())
|| (sa.getRootAbility().isAdventure() && sa.getHostCard().getState(CardStateName.Secondary).getType().isSorcery())
|| (sa.isPwAbility() && !sa.withFlash(sa.getHostCard(), ai));
}
/**
* <p>
* playReusable.
* </p>
*
* @param sa
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
protected static boolean playReusable(final Player ai, final SpellAbility sa) {
PhaseHandler phase = ai.getGame().getPhaseHandler();
// TODO probably also consider if winter orb or similar are out
if (sa instanceof AbilitySub) {
return true; // This is only true for Drawbacks and triggers
}
if (!sa.getPayCosts().isReusuableResource()) {
return false;
}
if (ComputerUtil.playImmediately(ai, sa)) {
return true;
}
if (sa.isPwAbility() && phase.is(PhaseType.MAIN2)) {
return true;
}
if (sa.isSpell() && !sa.isBuyback()) {
return false;
}
return phase.is(PhaseType.END_OF_TURN) && phase.getNextTurn().equals(ai);
}
}

View File

@@ -77,6 +77,7 @@ public enum SpellApiToAi {
.put(ApiType.DelayedTrigger, DelayedTriggerAi.class)
.put(ApiType.Destroy, DestroyAi.class)
.put(ApiType.DestroyAll, DestroyAllAi.class)
.put(ApiType.Detain, DetainAi.class)
.put(ApiType.Dig, DigAi.class)
.put(ApiType.DigMultiple, DigMultipleAi.class)
.put(ApiType.DigUntil, DigUntilAi.class)

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
@@ -8,7 +10,6 @@ import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.spellability.TargetRestrictions;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
import java.util.List;
import java.util.Map;
@@ -16,78 +17,69 @@ import java.util.Map;
public class ActivateAbilityAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
// AI cannot use this properly until he can use SAs during Humans turn
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Card source = sa.getHostCard();
final Player opp = ai.getStrongestOpponent();
List<Card> list = CardLists.getType(opp.getCardsIn(ZoneType.Battlefield), sa.getParamOrDefault("Type", "Card"));
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
if (!sa.usesTargeting()) {
final List<Player> defined = AbilityUtils.getDefinedPlayers(source, sa.getParam("Defined"), sa);
if (!defined.contains(opp)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
} else {
sa.resetTargets();
if (sa.canTarget(opp)) {
sa.getTargets().add(opp);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
boolean randomReturn = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
return randomReturn;
return super.checkApiLogic(ai, sa);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Player opp = ai.getStrongestOpponent();
final TargetRestrictions tgt = sa.getTargetRestrictions();
final Card source = sa.getHostCard();
if (null == tgt) {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
final List<Player> defined = AbilityUtils.getDefinedPlayers(source, sa.getParam("Defined"), sa);
return defined.contains(opp);
if (defined.contains(opp)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
sa.resetTargets();
sa.getTargets().add(opp);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
// AI cannot use this properly until he can use SAs during Humans turn
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
final Card source = sa.getHostCard();
boolean randomReturn = true;
if (!sa.usesTargeting()) {
final List<Player> defined = AbilityUtils.getDefinedPlayers(source, sa.getParam("Defined"), sa);
if (defined.contains(ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
sa.resetTargets();
sa.getTargets().add(ai.getWeakestOpponent());
}
return randomReturn;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
@@ -11,8 +13,8 @@ import forge.game.spellability.SpellAbility;
public class AddPhaseAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return false;
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -17,6 +17,8 @@
*/
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.ability.AbilityUtils;
import forge.game.player.Player;
@@ -38,7 +40,7 @@ import java.util.List;
public class AddTurnAi extends SpellAbilityAi {
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
PlayerCollection targetableOpps = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
Player opp = targetableOpps.min(PlayerPredicates.compareByLife());
@@ -56,32 +58,32 @@ public class AddTurnAi extends SpellAbilityAi {
if (!sa.getTargetRestrictions().isMinTargetsChosen(sa.getHostCard(), sa) && opp != null) {
sa.getTargets().add(opp);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
final List<Player> tgtPlayers = AbilityUtils.getDefinedPlayers(sa.getHostCard(), sa.getParam("Defined"), sa);
for (final Player p : tgtPlayers) {
if (p.isOpponentOf(ai) && !mandatory) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// TODO: improve ai for Sage of Hours
return StringUtils.isNumeric(sa.getParam("NumTurns"));
// not sure if the AI should be playing with cards that give the
// Human more turns.
if (!StringUtils.isNumeric(sa.getParam("NumTurns"))) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return doTriggerAINoCost(aiPlayer, sa, false);
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -1,30 +1,23 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.card.CardLists;
import forge.game.card.CardPredicates;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.zone.ZoneType;
public class AdvanceCrankAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
int nextSprocket = (ai.getCrankCounter() % 3) + 1;
int crankCount = CardLists.count(ai.getCardsIn(ZoneType.Battlefield), CardPredicates.isContraptionOnSprocket(nextSprocket));
//Could evaluate whether we actually want to crank those, but this is probably fine for now.
if(crankCount < 2)
return false;
return super.canPlayAI(ai, sa);
if (crankCount < 2) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return super.canPlay(ai, sa);
}
@Override
protected boolean checkPhaseRestrictions(Player ai, SpellAbility sa, PhaseHandler ph, String logic) {
if(logic.equals("AtOppEOT"))
return ph.getNextTurn() == ai && ph.is(PhaseType.END_OF_TURN);
return super.checkPhaseRestrictions(ai, sa, ph, logic);
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
@@ -16,7 +18,7 @@ import java.util.Map;
public class AlterAttributeAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
final Card source = sa.getHostCard();
boolean activate = Boolean.parseBoolean(sa.getParamOrDefault("Activate", "true"));
String[] attributes = sa.getParam("Attributes").split(",");
@@ -24,7 +26,7 @@ public class AlterAttributeAi extends SpellAbilityAi {
if (sa.usesTargeting()) {
// TODO add targeting logic
// needed for Suspected
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
final List<Card> defined = AbilityUtils.getDefinedCards(source, sa.getParam("Defined"), sa);
@@ -36,7 +38,7 @@ public class AlterAttributeAi extends SpellAbilityAi {
case "Solved":
// there is currently no effect that would un-solve something
if (!c.isSolved() && activate) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
break;
case "Suspect":
@@ -44,21 +46,21 @@ public class AlterAttributeAi extends SpellAbilityAi {
// is Suspected good or bad?
// currently Suspected is better
if (!activate) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
case "Saddle":
case "Saddled":
// AI should not try to Saddle again?
if (c.isSaddled()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override

View File

@@ -1,6 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.player.PlayerActionConfirmMode;
@@ -13,8 +14,8 @@ public class AlwaysPlayAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return true;
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override

View File

@@ -3,6 +3,8 @@ package forge.ai.ability;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.Game;
@@ -19,24 +21,28 @@ import java.util.Map;
public class AmassAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, final SpellAbility sa) {
CardCollection aiArmies = CardLists.getType(ai.getCardsIn(ZoneType.Battlefield), "Army");
Card host = sa.getHostCard();
final Game game = ai.getGame();
if (!aiArmies.isEmpty()) {
return aiArmies.anyMatch(CardPredicates.canReceiveCounters(CounterEnumType.P1P1));
if (aiArmies.anyMatch(CardPredicates.canReceiveCounters(CounterEnumType.P1P1))) {
// If AI has an Army that can receive counters, play the ability
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// AI has Armies but none can receive counters, so don't play
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactGame);
}
}
final String type = sa.getParam("Type");
StringBuilder sb = new StringBuilder("b_0_0_");
sb.append(sa.getOriginalParam("Type").toLowerCase()).append("_army");
final String tokenScript = sb.toString();
final String tokenScript = "b_0_0_" + sa.getOriginalParam("Type").toLowerCase() + "_army";
final int amount = AbilityUtils.calculateAmount(host, sa.getParamOrDefault("Num", "1"), sa);
Card token = TokenInfo.getProtoType(tokenScript, sa, ai, false);
if (token == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
token.setController(ai, 0);
@@ -63,7 +69,11 @@ public class AmassAi extends SpellAbilityAi {
//reset static abilities
game.getAction().checkStaticAbilities(false);
return result;
if (result) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@Override
@@ -82,8 +92,12 @@ public class AmassAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return mandatory || checkApiLogic(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
return checkApiLogic(ai, sa);
}
@Override

View File

@@ -142,21 +142,20 @@ public class AnimateAi extends SpellAbilityAi {
}
@Override
protected boolean checkApiLogic(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
final Card source = sa.getHostCard();
final Game game = aiPlayer.getGame();
final PhaseHandler ph = game.getPhaseHandler();
if (!sa.metConditions() && sa.getSubAbility() == null) {
return false; // what is this for?
}
if (!game.getStack().isEmpty() && game.getStack().peekAbility().getApi() == ApiType.Sacrifice) {
// Should I animate a card before i have to sacrifice something better?
if (!isAnimatedThisTurn(aiPlayer, source)) {
rememberAnimatedThisTurn(aiPlayer, source);
return true; // interrupt sacrifice
return new AiAbilityDecision(100, AiPlayDecision.ResponseToStackResolve);
}
}
if (!ComputerUtilCost.checkTapTypeCost(aiPlayer, sa.getPayCosts(), source, sa, new CardCollection())) {
return false; // prevent crewing with equal or better creatures
return new AiAbilityDecision(0, AiPlayDecision.CostNotAcceptable);
}
if (sa.costHasManaX() && sa.getSVar("X").equals("Count$xPaid")) {
@@ -202,16 +201,16 @@ public class AnimateAi extends SpellAbilityAi {
if (!isSorcerySpeed(sa, aiPlayer) && !"Permanent".equals(sa.getParam("Duration"))) {
if (sa.isCrew() && c.isCreature()) {
// Do not try to crew a vehicle which is already a creature
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
Card animatedCopy = becomeAnimated(c, sa);
if (ph.isPlayerTurn(aiPlayer)
&& !ComputerUtilCard.doesSpecifiedCreatureAttackAI(aiPlayer, animatedCopy)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
if (ph.getPlayerTurn().isOpponentOf(aiPlayer)
&& !ComputerUtilCard.doesSpecifiedCreatureBlock(aiPlayer, animatedCopy)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.DoesntImpactCombat);
}
// also check if maybe there are static effects applied to the animated copy that would matter
// (e.g. Myth Realized)
@@ -227,8 +226,9 @@ public class AnimateAi extends SpellAbilityAi {
}
if (bFlag) {
rememberAnimatedThisTurn(aiPlayer, sa.getHostCard());
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return bFlag; // All of the defined stuff is animated, not very useful
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else {
sa.resetTargets();
return animateTgtAI(sa);
@@ -237,35 +237,38 @@ public class AnimateAi extends SpellAbilityAi {
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
if (sa.usesTargeting()) {
sa.resetTargets();
return animateTgtAI(sa);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
AiAbilityDecision decision;
if (sa.usesTargeting()) {
if(animateTgtAI(sa))
return true;
else if (!mandatory)
return false;
decision = animateTgtAI(sa);
if (decision.willingToPlay()) {
return decision;
} else if (!mandatory) {
return decision;
}
else {
// fallback if animate is mandatory
sa.resetTargets();
List<Card> list = CardUtil.getValidCardsToTarget(sa);
if (list.isEmpty()) {
return false;
return decision;
}
Card toAnimate = ComputerUtilCard.getWorstAI(list);
rememberAnimatedThisTurn(aiPlayer, toAnimate);
sa.getTargets().add(toAnimate);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
@@ -273,7 +276,7 @@ public class AnimateAi extends SpellAbilityAi {
return player.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.MAIN2);
}
private boolean animateTgtAI(final SpellAbility sa) {
private AiAbilityDecision animateTgtAI(final SpellAbility sa) {
final Player ai = sa.getActivatingPlayer();
final PhaseHandler ph = ai.getGame().getPhaseHandler();
final String logic = sa.getParamOrDefault("AILogic", "");
@@ -295,7 +298,7 @@ public class AnimateAi extends SpellAbilityAi {
// list is empty, no possible targets
if (list.isEmpty() && !alwaysActivatePWAbility) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// something is used for animate into creature
@@ -362,7 +365,7 @@ public class AnimateAi extends SpellAbilityAi {
// data is empty, no good targets
if (data.isEmpty() && !alwaysActivatePWAbility) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// get the best creature to be animated
@@ -385,13 +388,13 @@ public class AnimateAi extends SpellAbilityAi {
holdAnimatedTillMain2(ai, worst);
if (!ComputerUtilMana.canPayManaCost(sa, ai, 0, sa.isTrigger())) {
releaseHeldTillMain2(ai, worst);
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
}
rememberAnimatedThisTurn(ai, worst);
sa.getTargets().add(worst);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (logic.equals("SetPT")) {
@@ -403,7 +406,7 @@ public class AnimateAi extends SpellAbilityAi {
&& (buffed.getNetPower() - worst.getNetPower() >= 3 || !ComputerUtilCard.doesCreatureAttackAI(ai, worst))) {
sa.getTargets().add(worst);
rememberAnimatedThisTurn(ai, worst);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -415,7 +418,7 @@ public class AnimateAi extends SpellAbilityAi {
boolean isValuableAttacker = ph.is(PhaseType.MAIN1, ai) && ComputerUtilCard.doesSpecifiedCreatureAttackAI(ai, animated);
boolean isValuableBlocker = combat != null && combat.getDefendingPlayers().contains(ai) && ComputerUtilCard.doesSpecifiedCreatureBlock(ai, animated);
if (isValuableAttacker || isValuableBlocker)
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
@@ -425,7 +428,7 @@ public class AnimateAi extends SpellAbilityAi {
if(worst != null) {
sa.getTargets().add(worst);
rememberAnimatedThisTurn(ai, worst);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -435,7 +438,7 @@ public class AnimateAi extends SpellAbilityAi {
if(best != null) {
sa.getTargets().add(best);
rememberAnimatedThisTurn(ai, best);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -443,7 +446,7 @@ public class AnimateAi extends SpellAbilityAi {
// two are the only things
// that animate a target. Those can just use AI:RemoveDeck:All until
// this can do a reasonably good job of picking a good target
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
public static Card becomeAnimated(final Card card, final SpellAbility sa) {

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.card.Card;
@@ -9,24 +11,30 @@ import forge.game.spellability.SpellAbility;
public class AnimateAllAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
String logic = sa.getParamOrDefault("AILogic", "");
if ("CreatureAdvantage".equals(logic) && !aiPlayer.getCreaturesInPlay().isEmpty()) {
// TODO: improve this or implement a better logic for abilities like Oko, the Trickster ultimate
for (Card c : aiPlayer.getCreaturesInPlay()) {
if (ComputerUtilCard.doesCreatureAttackAI(aiPlayer, c)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
return "Always".equals(logic);
} // end animateAllCanPlayAI()
if ("Always".equals(logic)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(aiPlayer, sa);
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(aiPlayer, sa);
}
}

View File

@@ -1,13 +1,13 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCost;
import forge.ai.SpellAbilityAi;
import forge.game.GameEntity;
import forge.game.ability.ApiType;
import forge.game.card.Card;
import forge.game.card.CardCollectionView;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.zone.ZoneType;
@@ -16,30 +16,32 @@ import java.util.List;
public class AssembleContraptionAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
//Pulls double duty as the OpenAttraction API. Same logic; usually good to do as long as we have the appropriate cards.
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
CardCollectionView deck = getDeck(ai, sa);
if(deck.isEmpty())
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
if(!super.canPlayAI(ai, sa))
return false;
AiAbilityDecision superDecision = super.canPlay(ai, sa);
if (!superDecision.willingToPlay())
return superDecision;
if ("X".equals(sa.getParam("Amount")) && sa.getSVar("X").equals("Count$xPaid")) {
int xPay = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
xPay = Math.max(xPay, deck.size());
if (xPay == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
sa.getRootAbility().setXManaCostPaid(xPay);
}
if(sa.hasParam("DefinedContraption") && sa.usesTargeting()) {
return getGoodReassembleTarget(ai, sa) != null;
if (getGoodReassembleTarget(ai, sa) == null) {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private static CardCollectionView getDeck(Player ai, SpellAbility sa) {
@@ -48,11 +50,11 @@ public class AssembleContraptionAi extends SpellAbilityAi {
}
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
if ("X".equals(sa.getParam("Amount")) && sa.getSVar("X").equals("Count$xPaid")) {
int xPay = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
if (xPay == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.getRootAbility().setXManaCostPaid(xPay);
}
@@ -62,7 +64,7 @@ public class AssembleContraptionAi extends SpellAbilityAi {
if(target != null)
sa.getTargets().add(target);
else
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return super.checkApiLogic(ai, sa);
@@ -84,26 +86,16 @@ public class AssembleContraptionAi extends SpellAbilityAi {
}
@Override
protected boolean checkPhaseRestrictions(Player ai, SpellAbility sa, PhaseHandler ph, String logic) {
if(logic.equals("AtOppEOT"))
return ph.getNextTurn() == ai && ph.is(PhaseType.END_OF_TURN);
return super.checkPhaseRestrictions(ai, sa, ph);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
if(getDeck(aiPlayer, sa).isEmpty())
return false;
return super.chkAIDrawback(sa, aiPlayer);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if(!mandatory && getDeck(aiPlayer, sa).isEmpty())
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
return super.doTriggerNoCost(aiPlayer, sa, mandatory);
}
return super.doTriggerAINoCost(aiPlayer, sa, mandatory);
@Override
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
if(getDeck(aiPlayer, sa).isEmpty())
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
return super.chkDrawback(sa, aiPlayer);
}
}

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
@@ -10,11 +12,11 @@ import java.util.Map;
public class AssignGroupAi extends SpellAbilityAi {
protected boolean canPlayAI(Player ai, SpellAbility sa) {
@Override
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
// TODO: Currently this AI relies on the card-specific limiting hints (NeedsToPlay / NeedsToPlayVar),
// otherwise the AI considers the card playable.
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public SpellAbility chooseSingleSpellAbility(Player player, SpellAbility sa, List<SpellAbility> spells, Map<String, Object> params) {

View File

@@ -45,24 +45,14 @@ public class AttachAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
// TODO: improve this so that the AI can use a flash aura buff as a means of killing opposing creatures
// and gaining card advantage
if (source.hasKeyword("MayFlashSac") && !ai.canCastSorcery()) {
return false;
}
if (abCost != null) {
// AI currently disabled for these costs
if (!ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
}
return new AiAbilityDecision(0, AiPlayDecision.TimingRestrictions);
}
if (source.isAura() && sa.isSpell() && !source.ignoreLegendRule() && ai.isCardInPlay(source.getName())) {
@@ -70,20 +60,16 @@ public class AttachAi extends SpellAbilityAi {
// TODO: Add some extra checks for where the AI may want to cast a replacement aura
// on another creature and keep it when the original enchanted creature is useless
return false;
}
// prevent run-away activations - first time will always return true
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WouldDestroyLegend);
}
// Attach spells always have a target
final TargetRestrictions tgt = sa.getTargetRestrictions();
if (tgt != null) {
sa.resetTargets();
if (!attachPreference(sa, tgt, false)) {
return false;
AiAbilityDecision attachDecision = attachPreference(sa, tgt, false);
if (!attachDecision.willingToPlay()) {
return attachDecision;
}
}
@@ -94,7 +80,7 @@ public class AttachAi extends SpellAbilityAi {
}
if ((source.hasKeyword(Keyword.FLASH) || (!ai.canCastSorcery() && sa.canCastTiming(ai)))
&& source.isAura() && advancedFlash && !doAdvancedFlashAuraLogic(ai, sa, sa.getTargetCard())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (abCost.getTotalMana().countX() > 0 && sa.getSVar("X").equals("Count$xPaid")) {
@@ -102,7 +88,7 @@ public class AttachAi extends SpellAbilityAi {
final int xPay = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
if (xPay == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
sa.setXManaCostPaid(xPay);
@@ -112,10 +98,10 @@ public class AttachAi extends SpellAbilityAi {
final SpellAbility effectExile = AbilityFactory.getAbility(source.getSVar("TrigExile"), source);
effectExile.setActivatingPlayer(ai);
final List<Card> targets = CardUtil.getValidCardsToTarget(effectExile);
return !targets.isEmpty();
return !targets.isEmpty() ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private boolean doAdvancedFlashAuraLogic(Player ai, SpellAbility sa, Card attachTarget) {
@@ -955,9 +941,8 @@ public class AttachAi extends SpellAbilityAi {
* @return true, if successful
*/
@Override
protected boolean doTriggerAINoCost(final Player ai, final SpellAbility sa, final boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(final Player ai, final SpellAbility sa, final boolean mandatory) {
final Card card = sa.getHostCard();
// Check if there are any valid targets
List<GameObject> targets = new ArrayList<>();
final TargetRestrictions tgt = sa.getTargetRestrictions();
if (tgt == null) {
@@ -969,23 +954,43 @@ public class AttachAi extends SpellAbilityAi {
if (!mandatory && card.isEquipment() && !targets.isEmpty()) {
Card newTarget = (Card) targets.get(0);
//don't equip human creatures
if (newTarget.getController().isOpponentOf(ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
//don't equip a worse creature
if (card.isEquipping()) {
Card oldTarget = card.getEquipping();
if (ComputerUtilCard.evaluateCreature(oldTarget) > ComputerUtilCard.evaluateCreature(newTarget)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// don't equip creatures that don't gain anything
return !card.hasSVar("NonStackingAttachEffect") || !newTarget.isEquippedBy(card.getName());
boolean stacking = !card.hasSVar("NonStackingAttachEffect") || !newTarget.isEquippedBy(card.getName());
if (!stacking) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return true;
@Override
public AiAbilityDecision chkDrawback(final SpellAbility sa, final Player ai) {
if (sa.isTrigger() && sa.usesTargeting()) {
CardCollection targetables = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
CardCollection source = AbilityUtils.getDefinedCards(sa.getHostCard(), sa.getParam("Object"), sa);
Card tgt = attachGeneralAI(ai, sa, targetables, !sa.getRootAbility().isOptionalTrigger(), source.getFirst(), null);
if (tgt != null) {
sa.resetTargets();
sa.getTargets().add(tgt);
}
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else if ("Remembered".equals(sa.getParam("Defined")) && sa.getParent() != null
&& sa.getParent().getApi() == ApiType.Token && sa.getParent().hasParam("RememberTokens")) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
private static boolean isAuraSpell(final SpellAbility sa) {
@@ -1005,13 +1010,13 @@ public class AttachAi extends SpellAbilityAi {
* the mandatory
* @return true, if successful
*/
private static boolean attachPreference(final SpellAbility sa, final TargetRestrictions tgt, final boolean mandatory) {
private static AiAbilityDecision attachPreference(final SpellAbility sa, final TargetRestrictions tgt, final boolean mandatory) {
GameObject o;
boolean spellCanTargetPlayer = false;
if (isAuraSpell(sa)) {
Card source = sa.getHostCard();
if (!source.hasKeyword(Keyword.ENCHANT)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
for (KeywordInterface ki : source.getKeywords(Keyword.ENCHANT)) {
String ko = ki.getOriginal();
@@ -1036,11 +1041,11 @@ public class AttachAi extends SpellAbilityAi {
}
if (o == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
sa.getTargets().add(o);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/**
@@ -1692,25 +1697,6 @@ public class AttachAi extends SpellAbilityAi {
return chosen;
}
@Override
public boolean chkAIDrawback(final SpellAbility sa, final Player ai) {
// TODO for targeting optional Halvar trigger, needs to be coordinated with PumpAi to make it playable
if (sa.isTrigger() && sa.usesTargeting()) {
CardCollection targetables = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
CardCollection source = AbilityUtils.getDefinedCards(sa.getHostCard(), sa.getParam("Object"), sa);
Card tgt = attachGeneralAI(ai, sa, targetables, !sa.getRootAbility().isOptionalTrigger(), source.getFirst(), null);
if (tgt != null) {
sa.resetTargets();
sa.getTargets().add(tgt);
}
return sa.isTargetNumberValid();
} else if ("Remembered".equals(sa.getParam("Defined")) && sa.getParent() != null
&& sa.getParent().getApi() == ApiType.Token && sa.getParent().hasParam("RememberTokens")) {
// Living Weapon or similar
return true;
}
return false;
}
@Override
public boolean confirmAction(Player player, SpellAbility sa, PlayerActionConfirmMode mode, String message, Map<String, Object> params) {

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.card.CardCollectionView;
import forge.game.card.CardLists;
@@ -11,7 +13,7 @@ import forge.util.MyRandom;
public class BalanceAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
String logic = sa.getParam("AILogic");
int diff = 0;
Player opp = aiPlayer.getWeakestOpponent();
@@ -37,7 +39,7 @@ public class BalanceAi extends SpellAbilityAi {
if (diff < 0) {
// Don't sacrifice permanents even if opponent has a ton of cards in hand
return false;
return new AiAbilityDecision(0, forge.ai.AiPlayDecision.CantPlayAi);
}
final CardCollectionView humHand = opp.getCardsIn(ZoneType.Hand);
@@ -45,6 +47,7 @@ public class BalanceAi extends SpellAbilityAi {
diff += 0.5 * (humHand.size() - compHand.size());
// Larger differential == more chance to actually cast this spell
return diff > 2 && MyRandom.getRandom().nextInt(100) < diff*10;
boolean willPlay = diff > 2 && MyRandom.getRandom().nextInt(100) < diff*10;
return new AiAbilityDecision(willPlay ? 100 : 0, willPlay ? forge.ai.AiPlayDecision.WillPlay : AiPlayDecision.StopRunawayActivations);
}
}

View File

@@ -1,6 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.Game;
@@ -16,14 +17,14 @@ import forge.game.zone.ZoneType;
public class BecomesBlockedAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
final Card source = sa.getHostCard();
final TargetRestrictions tgt = sa.getTargetRestrictions();
final Game game = aiPlayer.getGame();
if (!game.getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS)
|| !game.getPhaseHandler().getPlayerTurn().isOpponentOf(aiPlayer)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (tgt != null) {
@@ -36,35 +37,31 @@ public class BecomesBlockedAi extends SpellAbilityAi {
Card choice = null;
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
choice = ComputerUtilCard.getBestCreatureAI(list);
if (choice == null) { // can't find anything left
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
list.remove(choice);
sa.getTargets().add(choice);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
// TODO - implement AI
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
boolean chance;
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
// TODO - implement AI
chance = false;
return chance;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiAttackController;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.Game;
@@ -10,14 +12,13 @@ import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.spellability.TargetRestrictions;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
import java.util.List;
public class BidLifeAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
final Card source = sa.getHostCard();
final Game game = source.getGame();
TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -26,31 +27,31 @@ public class BidLifeAi extends SpellAbilityAi {
if (tgt.canTgtCreature()) {
List<Card> list = CardLists.getTargetableCards(AiAttackController.choosePreferredDefenderPlayer(aiPlayer).getCardsIn(ZoneType.Battlefield), sa);
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
Card c = ComputerUtilCard.getBestCreatureAI(list);
if (sa.canTarget(c)) {
sa.getTargets().add(c);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else if (tgt.getZone().contains(ZoneType.Stack)) {
if (game.getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final SpellAbility topSA = game.getStack().peekAbility();
if (!topSA.isCounterableBy(sa) || aiPlayer.equals(topSA.getActivatingPlayer())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.canTargetSpellAbility(topSA)) {
sa.getTargets().add(topSA);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
}
boolean chance = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
return chance;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -17,6 +17,8 @@
*/
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.card.Card;
@@ -46,9 +48,9 @@ public final class BondAi extends SpellAbilityAi {
* @return a boolean.
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return true;
} // end bondCanPlayAI()
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected Card chooseSingleCard(Player ai, SpellAbility sa, Iterable<Card> options, boolean isOptional, Player targetedPlayer, Map<String, Object> params) {
@@ -56,7 +58,7 @@ public final class BondAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
return true;
protected AiAbilityDecision doTriggerNoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpecialAiLogic;
import forge.ai.SpecialCardAi;
@@ -21,16 +23,18 @@ public class BranchAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
final String aiLogic = sa.getParamOrDefault("AILogic", "");
if ("GrislySigil".equals(aiLogic)) {
return SpecialCardAi.GrislySigil.consider(aiPlayer, sa);
boolean result = SpecialCardAi.GrislySigil.consider(aiPlayer, sa);
return new AiAbilityDecision(result ? 100 : 0, result ? AiPlayDecision.WillPlay : AiPlayDecision.CantPlayAi);
} else if ("BranchCounter".equals(aiLogic)) {
return SpecialAiLogic.doBranchCounterspellLogic(aiPlayer, sa); // Bring the Ending, Anticognition (hacky implementation)
boolean result = SpecialAiLogic.doBranchCounterspellLogic(aiPlayer, sa);
return new AiAbilityDecision(result ? 100 : 0, result ? AiPlayDecision.WillPlay : AiPlayDecision.CantPlayAi);
} else if ("TgtAttacker".equals(aiLogic)) {
final Combat combat = aiPlayer.getGame().getCombat();
if (combat == null || combat.getAttackingPlayer() != aiPlayer) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final CardCollection attackers = combat.getAttackers();
@@ -45,16 +49,20 @@ public class BranchAi extends SpellAbilityAi {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(attackers));
}
return sa.isTargetNumberValid();
return new AiAbilityDecision(sa.isTargetNumberValid() ? 100 : 0, sa.isTargetNumberValid() ? AiPlayDecision.WillPlay : AiPlayDecision.CantPlayAi);
}
// TODO: expand for other cases where the AI is needed to make a decision on a branch
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return canPlayAI(aiPlayer, sa) || mandatory;
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
AiAbilityDecision decision = canPlay(aiPlayer, sa);
if (decision.willingToPlay() || mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
@@ -10,15 +12,15 @@ public class CannotPlayAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return false;
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#chkAIDrawback(java.util.Map, forge.card.spellability.SpellAbility, forge.game.player.Player)
*/
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
return canPlayAI(aiPlayer, sa);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.GameEntity;
import forge.game.player.Player;
@@ -15,34 +17,36 @@ public class ChangeCombatantsAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
// TODO: Extend this if possible for cards that have this as an activated ability
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(aiPlayer, sa);
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#chkAIDrawback(java.util.Map, forge.card.spellability.SpellAbility, forge.game.player.Player)
*/
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
final String logic = sa.getParamOrDefault("AILogic", "");
if (logic.equals("WeakestOppExceptCtrl")) {
PlayerCollection targetableOpps = aiPlayer.getOpponents();
targetableOpps.remove(sa.getHostCard().getController());
if (targetableOpps.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return true;
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
@@ -63,4 +67,3 @@ public class ChangeCombatantsAi extends SpellAbilityAi {
return (T)weakestTargetableOpp;
}
}

View File

@@ -1,9 +1,6 @@
package forge.ai.ability;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilAbility;
import forge.ai.ComputerUtilMana;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.card.mana.ManaCost;
import forge.game.Game;
import forge.game.card.Card;
@@ -21,7 +18,7 @@ public class ChangeTargetsAi extends SpellAbilityAi {
* forge.game.spellability.SpellAbility)
*/
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Game game = sa.getHostCard().getGame();
final SpellAbility topSa = game.getStack().isEmpty() ? null
: ComputerUtilAbility.getTopSpellAbilityOnStack(game, sa);
@@ -32,47 +29,50 @@ public class ChangeTargetsAi extends SpellAbilityAi {
// The AI can't otherwise play this ability, but should at least not
// miss mandatory activations (e.g. triggers).
return sa.isMandatory();
if (sa.isMandatory()) {
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
private boolean doSpellMagnet(SpellAbility sa, SpellAbility topSa, Player aiPlayer) {
private AiAbilityDecision doSpellMagnet(SpellAbility sa, SpellAbility topSa, Player aiPlayer) {
// For cards like Spellskite that retarget spells to itself
if (topSa == null) {
// nothing on stack, so nothing to target
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final TargetChoices topTargets = topSa.getTargets();
final Card topHost = topSa.getHostCard();
if (sa.getTargets().size() != 0 && sa.isTrigger()) {
if (!sa.getTargets().isEmpty() && sa.isTrigger()) {
// something was already chosen before (e.g. in response to a trigger - Mizzium Meddler), so just proceed
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (!topSa.usesTargeting() || topTargets.getTargetCards().contains(sa.getHostCard())) {
// if this does not target at all or already targets host, no need to redirect it again
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
for (Card tgt : topTargets.getTargetCards()) {
if (ComputerUtilAbility.getAbilitySourceName(sa).equals(tgt.getName()) && tgt.getController().equals(aiPlayer)) {
// We are already targeting at least one card with the same name (e.g. in presence of 2+ Spellskites),
// no need to retarget again to another one
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (topHost != null && !topHost.getController().isOpponentOf(aiPlayer)) {
// make sure not to redirect our own abilities
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (!topSa.canTarget(sa.getHostCard())) {
// don't try targeting it if we can't legally target the host card with it in the first place
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (!sa.canTarget(topSa)) {
// don't try retargeting a spell that the current card can't legally retarget (e.g. Muck Drubb + Lightning Bolt to the face)
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.getPayCosts().getCostMana() != null && sa.getPayCosts().getCostMana().getMana().hasPhyrexian()) {
@@ -85,22 +85,22 @@ public class ChangeTargetsAi extends SpellAbilityAi {
if (potentialDmg != -1 && potentialDmg <= payDamage && !canPay
&& topTargets.contains(aiPlayer)) {
// do not pay Phyrexian mana if the spell is a damaging one but it deals less damage or the same damage as we'll pay life
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
Card firstCard = topTargets.getFirstTargetedCard();
// if we're not the target don't intervene unless we can steal a buff
if (firstCard != null && !aiPlayer.equals(firstCard.getController()) && !topHost.getController().equals(firstCard.getController()) && !topHost.getController().getAllies().contains(firstCard.getController())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
Player firstPlayer = topTargets.getFirstTargetedPlayer();
if (firstPlayer != null && !aiPlayer.equals(firstPlayer)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.resetTargets();
sa.getTargets().add(topSa);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -46,6 +46,30 @@ public class ChangeZoneAi extends SpellAbilityAi {
private static CardCollection multipleCardsToChoose = new CardCollection();
protected boolean willPayCosts(Player ai, SpellAbility sa, Cost cost, Card source) {
if (sa.isHidden()) {
if (!ComputerUtilCost.checkSacrificeCost(ai, cost, source, sa)
&& !"Battlefield".equals(sa.getParam("Destination")) && !source.isLand()) {
return false;
}
if (!ComputerUtilCost.checkLifeCost(ai, cost, source, 4, sa)) {
return false;
}
if (!ComputerUtilCost.checkDiscardCost(ai, cost, source, sa)) {
for (final CostPart part : cost.getCostParts()) {
if (part instanceof CostDiscard) {
CostDiscard cd = (CostDiscard) part;
// this is mainly for typecycling
if (!cd.payCostFromSource() || !ComputerUtil.isWorseThanDraw(ai, source)) {
return false;
}
}
}
}
return true;
}
if (sa.isCraft()) {
CardCollection payingCards = new CardCollection();
int needed = 0;
@@ -129,14 +153,12 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
@Override
protected boolean checkApiLogic(Player aiPlayer, SpellAbility sa) {
// Checks for "return true" unlike checkAiLogic()
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
multipleCardsToChoose.clear();
String aiLogic = sa.getParam("AILogic");
if (aiLogic != null) {
if (aiLogic.equals("Always")) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (aiLogic.startsWith("SacAndUpgrade")) { // Birthing Pod, Natural Order, etc.
return doSacAndUpgradeLogic(aiPlayer, sa);
} else if (aiLogic.startsWith("SacAndRetFromGrave")) { // Recurring Nightmare, etc.
@@ -156,10 +178,18 @@ public class ChangeZoneAi extends SpellAbilityAi {
} else if (aiLogic.equals("MazesEnd")) {
return SpecialCardAi.MazesEnd.consider(aiPlayer, sa);
} else if (aiLogic.equals("Pongify")) {
return sa.isTargetNumberValid(); // Pre-targeted in checkAiLogic
if (sa.isTargetNumberValid()) {
// Pre-targeted in checkAiLogic
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (aiLogic.equals("ReturnCastable")) {
return !sa.getHostCard().getExiledCards().isEmpty()
&& ComputerUtilMana.canPayManaCost(sa.getHostCard().getExiledCards().getFirst().getFirstSpellAbility(), aiPlayer, 0, false);
if (!sa.getHostCard().getExiledCards().isEmpty()
&& ComputerUtilMana.canPayManaCost(sa.getHostCard().getExiledCards().getFirst().getFirstSpellAbility(), aiPlayer, 0, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (sa.isHidden()) {
@@ -178,7 +208,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* @return a boolean.
*/
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
if (sa.isHidden()) {
return hiddenOriginPlayDrawbackAI(aiPlayer, sa);
}
@@ -197,7 +227,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* @return a boolean.
*/
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
String aiLogic = sa.getParamOrDefault("AILogic", "");
if (sa.isReplacementAbility() && "Command".equals(sa.getParam("Destination")) && "ReplacedCard".equals(sa.getParam("Defined"))) {
@@ -206,10 +236,10 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
if ("Always".equals(aiLogic)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if ("IfNotBuffed".equals(aiLogic)) {
if (ComputerUtilCard.isUselessCreature(aiPlayer, sa.getHostCard())) {
return true; // debuffed by opponent's auras to the level that it becomes useless
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
int delta = 0;
for (Card enc : sa.getHostCard().getEnchantedBy()) {
@@ -219,9 +249,17 @@ public class ChangeZoneAi extends SpellAbilityAi {
delta++;
}
}
return delta <= 0;
if (delta <= 0) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("SaviorOfOllenbock".equals(aiLogic)) {
return SpecialCardAi.SaviorOfOllenbock.consider(aiPlayer, sa);
if (SpecialCardAi.SaviorOfOllenbock.consider(aiPlayer, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (sa.isHidden()) {
@@ -250,7 +288,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
private static boolean hiddenOriginCanPlayAI(final Player ai, final SpellAbility sa) {
private static AiAbilityDecision hiddenOriginCanPlayAI(final Player ai, final SpellAbility sa) {
// Fetching should occur fairly often as it helps cast more spells, and
// have access to more mana
final Cost abCost = sa.getPayCosts();
@@ -267,44 +305,21 @@ public class ChangeZoneAi extends SpellAbilityAi {
} catch (IllegalArgumentException ex) {
// This happens when Origin is something like
// "Graveyard,Library" (Doomsday)
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
final String destination = sa.getParam("Destination");
if (abCost != null) {
// AI currently disabled for these costs
if (!ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa)
&& !(destination.equals("Battlefield") && !source.isLand())) {
return false;
}
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
}
if (!ComputerUtilCost.checkDiscardCost(ai, abCost, source, sa)) {
for (final CostPart part : abCost.getCostParts()) {
if (part instanceof CostDiscard) {
CostDiscard cd = (CostDiscard) part;
// this is mainly for typecycling
if (!cd.payCostFromSource() || !ComputerUtil.isWorseThanDraw(ai, source)) {
return false;
}
}
}
}
if (sa.isNinjutsu()) {
if (!source.ignoreLegendRule() && ai.isCardInPlay(source.getName())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WouldDestroyLegend);
}
if (ai.getGame().getPhaseHandler().getPhase().isAfter(PhaseType.COMBAT_DAMAGE)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
if (ai.getGame().getCombat() == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
List<Card> attackers = ai.getGame().getCombat().getUnblockedAttackers();
boolean lowerCMC = false;
@@ -315,26 +330,9 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
}
if (!lowerCMC) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// don't play if the conditions aren't met, unless it would trigger a beneficial sub-condition
if (!activateForCost && !sa.metConditions()) {
final AbilitySub abSub = sa.getSubAbility();
if (abSub != null && !sa.isWrapper() && "True".equals(source.getSVar("AIPlayForSub"))) {
if (!abSub.metConditions()) {
return false;
}
} else {
return false;
}
}
// prevent run-away activations - first time will always return true
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
Iterable<Player> pDefined = Lists.newArrayList(source.getController());
final TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -347,7 +345,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
sa.getTargets().add(ai);
}
if (!sa.isTargetNumberValid()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
pDefined = sa.getTargets().getTargetPlayers();
} else {
@@ -391,12 +389,12 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
if (!activateForCost && list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if ("Atarka's Command".equals(sourceName)
&& (list.size() < 2 || ai.getLandsPlayedThisTurn() < 1)) {
// be strict on playing lands off charms
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
String num = sa.getParamOrDefault("ChangeNum", "1");
@@ -404,55 +402,65 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (sa.getSVar("X").equals("Count$xPaid")) {
// Set PayX here to maximum value.
int xPay = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
if (xPay == 0) return false;
if (xPay == 0) {
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
xPay = Math.min(xPay, list.size());
sa.setXManaCostPaid(xPay);
} else {
// Figure out the X amount, bail if it's zero (nothing will change zone).
int xValue = AbilityUtils.calculateAmount(source, "X", sa);
if (xValue == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
}
}
if (sourceName.equals("Temur Sabertooth")) {
// activated bounce + pump
if (ComputerUtilCard.shouldPumpCard(ai, sa.getSubAbility(), source, 0, 0, Arrays.asList("Indestructible")) ||
ComputerUtilCard.canPumpAgainstRemoval(ai, sa.getSubAbility())) {
boolean pumpDecision = ComputerUtilCard.shouldPumpCard(ai, sa.getSubAbility(), source, 0, 0, Arrays.asList("Indestructible"));
AiAbilityDecision saveDecision = ComputerUtilCard.canPumpAgainstRemoval(ai, sa.getSubAbility());
if (pumpDecision || saveDecision.willingToPlay()) {
for (Card c : list) {
if (ComputerUtilCard.evaluateCreature(c) < ComputerUtilCard.evaluateCreature(source)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.ResponseToStackResolve);
}
}
}
return canBouncePermanent(ai, sa, list) != null;
if (canBouncePermanent(ai, sa, list) != null) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (ComputerUtil.playImmediately(ai, sa)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// don't use fetching to top of library/graveyard before main2
if (ai.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.MAIN2)
&& !sa.hasParam("ActivationPhases")) {
if (!destination.equals("Battlefield") && !destination.equals("Hand")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Only tutor something in main1 if hand is almost empty
if (ai.getCardsIn(ZoneType.Hand).size() > 1 && destination.equals("Hand")
&& !aiLogic.equals("AnyMainPhase")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (ComputerUtil.waitForBlocking(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
final AbilitySub subAb = sa.getSubAbility();
return subAb == null || SpellApiToAi.Converter.get(subAb).chkDrawbackWithSubs(ai, subAb);
if (subAb == null) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return SpellApiToAi.Converter.get(subAb).chkDrawbackWithSubs(ai, subAb);
}
/**
@@ -464,7 +472,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
private static boolean hiddenOriginPlayDrawbackAI(final Player aiPlayer, final SpellAbility sa) {
private static AiAbilityDecision hiddenOriginPlayDrawbackAI(final Player aiPlayer, final SpellAbility sa) {
// if putting cards from hand to library and parent is drawing cards
// make sure this will actually do something:
final TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -476,11 +484,11 @@ public class ChangeZoneAi extends SpellAbilityAi {
} else if (!isCurse && sa.canTarget(aiPlayer)) {
sa.getTargets().add(aiPlayer);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/**
@@ -494,7 +502,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* a boolean.
* @return a boolean.
*/
private static boolean hiddenTriggerAI(final Player ai, final SpellAbility sa, final boolean mandatory) {
private static AiAbilityDecision hiddenTriggerAI(final Player ai, final SpellAbility sa, final boolean mandatory) {
// Fetching should occur fairly often as it helps cast more spells, and
// have access to more mana
@@ -507,7 +515,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* to make sub-optimal choices (waste bounce) than to make obvious mistakes
* (bounce useful permanent).
*/
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -545,15 +553,15 @@ public class ChangeZoneAi extends SpellAbilityAi {
pDefined = sa.getTargets().getTargetPlayers();
if (Iterables.isEmpty(pDefined)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
pDefined = AbilityUtils.getDefinedPlayers(sa.getHostCard(), sa.getParam("Defined"), sa);
}
@@ -567,10 +575,10 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// *********** Utility functions for Hidden ********************
@@ -673,7 +681,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
private static boolean knownOriginCanPlayAI(final Player ai, final SpellAbility sa) {
private static AiAbilityDecision knownOriginCanPlayAI(final Player ai, final SpellAbility sa) {
// Retrieve either this card, or target Cards in Graveyard
final List<ZoneType> origin = Lists.newArrayList();
@@ -685,20 +693,16 @@ public class ChangeZoneAi extends SpellAbilityAi {
final ZoneType destination = ZoneType.smartValueOf(sa.getParam("Destination"));
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
if (sa.usesTargeting()) {
if (!isPreferredTarget(ai, sa, false, false)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
// non-targeted retrieval
final List<Card> retrieval = sa.knownDetermineDefined(sa.getParam("Defined"));
if (retrieval == null || retrieval.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// return this card from graveyard: cards like Hammer of Bogardan
@@ -709,7 +713,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
// (dying or losing control of)
if (origin.contains(ZoneType.Battlefield)) {
if (ai.getGame().getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final AbilitySub abSub = sa.getSubAbility();
@@ -722,7 +726,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (!(destination.equals(ZoneType.Exile)
&& (subApi == ApiType.DelayedTrigger || subApi == ApiType.ChangeZone || "DelayedBlink".equals(sa.getParam("AILogic"))))
&& !destination.equals(ZoneType.Hand)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final List<GameObject> objects = ComputerUtil.predictThreatenedObjects(ai, sa);
@@ -734,13 +738,13 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
}
if (!contains) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (destination == ZoneType.Battlefield) {
if (ComputerUtil.isETBprevented(retrieval.get(0))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// predict whether something may put a ETBing creature below zero toughness
@@ -750,7 +754,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
final Card copy = CardCopyService.getLKICopy(c);
ComputerUtilCard.applyStaticContPT(c.getGame(), copy, null);
if (copy.getNetToughness() <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -764,13 +768,17 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
}
if (nothingWillReturn) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
final AbilitySub subAb = sa.getSubAbility();
return subAb == null || SpellApiToAi.Converter.get(subAb).chkDrawbackWithSubs(ai, subAb);
if (subAb == null) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return SpellApiToAi.Converter.get(subAb).chkDrawbackWithSubs(ai, subAb);
}
/*
@@ -784,7 +792,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
protected boolean checkPhaseRestrictions(Player ai, SpellAbility sa, PhaseHandler ph) {
String aiLogic = sa.getParamOrDefault("AILogic", "");
if (aiLogic.equals("SurvivalOfTheFittest") || aiLogic.equals("AtOppEOT")) {
if (aiLogic.equals("SurvivalOfTheFittest")) {
return ph.getNextTurn().equals(ai) && ph.is(PhaseType.END_OF_TURN);
} else if (aiLogic.equals("Main1") && ph.is(PhaseType.MAIN1, ai)) {
return true;
@@ -843,16 +851,26 @@ public class ChangeZoneAi extends SpellAbilityAi {
* a {@link forge.game.spellability.SpellAbility} object.
* @return a boolean.
*/
private static boolean knownOriginPlayDrawbackAI(final Player aiPlayer, final SpellAbility sa) {
private static AiAbilityDecision knownOriginPlayDrawbackAI(final Player aiPlayer, final SpellAbility sa) {
if ("MimicVat".equals(sa.getParam("AILogic"))) {
return SpecialCardAi.MimicVat.considerExile(aiPlayer, sa);
if (SpecialCardAi.MimicVat.considerExile(aiPlayer, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (!sa.usesTargeting()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return isPreferredTarget(aiPlayer, sa, false, true);
if (!isPreferredTarget(aiPlayer, sa, false, true)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else {
// if we are here, we have a target
// so we can play the ability
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
/**
@@ -1493,7 +1511,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
}
}
if (choice == null) { // can't find anything left
if (sa.getTargets().size() == 0 || sa.getTargets().size() < tgt.getMinTargets(sa.getHostCard(), sa)) {
if (sa.getTargets().isEmpty() || sa.getTargets().size() < tgt.getMinTargets(sa.getHostCard(), sa)) {
sa.resetTargets();
return false;
}
@@ -1521,13 +1539,21 @@ public class ChangeZoneAi extends SpellAbilityAi {
* a boolean.
* @return a boolean.
*/
private static boolean knownOriginTriggerAI(final Player ai, final SpellAbility sa, final boolean mandatory) {
private static AiAbilityDecision knownOriginTriggerAI(final Player ai, final SpellAbility sa, final boolean mandatory) {
final String logic = sa.getParamOrDefault("AILogic", "");
if ("DeathgorgeScavenger".equals(logic)) {
return SpecialCardAi.DeathgorgeScavenger.consider(ai, sa);
if (SpecialCardAi.DeathgorgeScavenger.consider(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("ExtraplanarLens".equals(logic)) {
return SpecialCardAi.ExtraplanarLens.consider(ai, sa);
if (SpecialCardAi.ExtraplanarLens.consider(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("ExileCombatThreat".equals(logic)) {
return doExileCombatThreatLogic(ai, sa);
}
@@ -1539,14 +1565,27 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (!list.isEmpty()) {
final Card attachedTo = list.get(0);
// This code is for the Dragon auras
return !attachedTo.getController().isOpponentOf(ai);
if (!attachedTo.getController().isOpponentOf(ai)) {
// If the AI is not the controller of the attachedTo card, then it is not a valid target.
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// If the AI is the controller of the attachedTo card, then it is a valid target.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
} else if (isPreferredTarget(ai, sa, mandatory, true)) {
// do nothing
} else return isUnpreferredTarget(ai, sa, mandatory);
} else {
if (isUnpreferredTarget(ai, sa, mandatory)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// If the AI is not the controller of the attachedTo card, then it is not a valid target.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public static Card chooseCardToHiddenOriginChangeZone(ZoneType destination, List<ZoneType> origin, SpellAbility sa, CardCollection fetchList, Player player, final Player decider) {
@@ -1777,7 +1816,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
return super.chooseSingleAttackableEntity(ai, sa, options, params);
}
private boolean doSacAndReturnFromGraveLogic(final Player ai, final SpellAbility sa) {
private AiAbilityDecision doSacAndReturnFromGraveLogic(final Player ai, final SpellAbility sa) {
Card source = sa.getHostCard();
String definedSac = StringUtils.split(source.getSVar("AIPreference"), "$")[1];
@@ -1796,14 +1835,14 @@ public class ChangeZoneAi extends SpellAbilityAi {
sa.resetTargets();
sa.getTargets().add(bestRet);
source.setSVar("AIPreferenceOverride", "Creature.cmcEQ" + worstSac.getCMC());
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
private boolean doSacAndUpgradeLogic(final Player ai, final SpellAbility sa) {
private AiAbilityDecision doSacAndUpgradeLogic(final Player ai, final SpellAbility sa) {
Card source = sa.getHostCard();
PhaseHandler ph = ai.getGame().getPhaseHandler();
String logic = sa.getParam("AILogic");
@@ -1811,7 +1850,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (!ph.is(PhaseType.MAIN2)) {
// Should be given a chance to cast other spells as well as to use a previously upgraded creature
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
String definedSac = StringUtils.split(source.getSVar("AIPreference"), "$")[1];
@@ -1850,15 +1889,14 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (!listGoal.isEmpty()) {
// make sure we're upgrading sacCMC->goalCMC
source.setSVar("AIPreferenceOverride", "Creature.cmcEQ" + sacCMC);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
// no candidates to upgrade
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
public boolean doReturnCommanderLogic(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision doReturnCommanderLogic(SpellAbility sa, Player aiPlayer) {
@SuppressWarnings("unchecked")
Map<AbilityKey, Object> originalParams = (Map<AbilityKey, Object>)sa.getReplacingObject(AbilityKey.OriginalParams);
SpellAbility causeSa = (SpellAbility)originalParams.get(AbilityKey.Cause);
@@ -1867,13 +1905,13 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (Objects.equals(ZoneType.Hand, destination)) {
// If the commander is being moved to your hand, don't replace since its easier to cast it again
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Squee, the Immortal: easier to recast it (the call below has to be "contains" since SA is an intrinsic effect)
if (sa.getHostCard().getName().contains("Squee, the Immortal") &&
(destination == ZoneType.Graveyard || destination == ZoneType.Exile)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (causeSa != null && (causeSub = causeSa.getSubAbility()) != null) {
@@ -1882,28 +1920,38 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (subApi == ApiType.ChangeZone && "Exile".equals(causeSub.getParam("Origin"))
&& "Battlefield".equals(causeSub.getParam("Destination"))) {
// A blink effect implemented using ChangeZone API
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else // This is an intrinsic effect that blinks the card (e.g. Obzedat, Ghost Council), no need to
// return the commander to the Command zone.
if (subApi == ApiType.DelayedTrigger) {
SpellAbility exec = causeSub.getAdditionalAbility("Execute");
if (exec != null && exec.getApi() == ApiType.ChangeZone) {
// A blink effect implemented using a delayed trigger
return !"Exile".equals(exec.getParam("Origin")) || !"Battlefield".equals(exec.getParam("Destination"));
if (!"Exile".equals(exec.getParam("Origin")) || !"Battlefield".equals(exec.getParam("Destination"))) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
if (causeSa.getHostCard() == null || !causeSa.getHostCard().equals(sa.getReplacingObject(AbilityKey.Card))
|| !causeSa.getActivatingPlayer().equals(aiPlayer)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else return causeSa.getHostCard() == null || !causeSa.getHostCard().equals(sa.getReplacingObject(AbilityKey.Card))
|| !causeSa.getActivatingPlayer().equals(aiPlayer);
}
// Normally we want the commander back in Command zone to recast him later
return true;
// Normally we want the commander back in Command zone to recast it later
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public static boolean doExileCombatThreatLogic(final Player aiPlayer, final SpellAbility sa) {
public static AiAbilityDecision doExileCombatThreatLogic(final Player aiPlayer, final SpellAbility sa) {
final Combat combat = aiPlayer.getGame().getCombat();
if (combat == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
Card choice = null;
@@ -1938,9 +1986,9 @@ public class ChangeZoneAi extends SpellAbilityAi {
if (choice != null) {
sa.getTargets().add(choice);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
public static Card doExilePreferenceLogic(final Player aiPlayer, final SpellAbility sa, CardCollection fetchList) {

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.*;
import forge.game.Game;
import forge.game.ability.AbilityUtils;
@@ -19,7 +21,7 @@ import java.util.Map;
public class ChangeZoneAllAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
// Change Zone All, can be any type moving from one zone to another
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
@@ -32,14 +34,14 @@ public class ChangeZoneAllAi extends SpellAbilityAi {
if (abCost != null) {
// AI currently disabled for these costs
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CostNotAcceptable);
}
if (!ComputerUtilCost.checkDiscardCost(ai, abCost, source, sa)) {
boolean aiLogicAllowsDiscard = aiLogic.startsWith("DiscardAll");
if (!aiLogicAllowsDiscard) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CostNotAcceptable);
}
}
}
@@ -59,31 +61,29 @@ public class ChangeZoneAllAi extends SpellAbilityAi {
// Ugin AI: always try to sweep before considering +1
if (sourceName.equals("Ugin, the Spirit Dragon")) {
return SpecialCardAi.UginTheSpiritDragon.considerPWAbilityPriority(ai, sa, origin, oppType, computerType);
boolean result = SpecialCardAi.UginTheSpiritDragon.considerPWAbilityPriority(ai, sa, origin, oppType, computerType);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
oppType = AbilityUtils.filterListByType(oppType, sa.getParam("ChangeType"), sa);
computerType = AbilityUtils.filterListByType(computerType, sa.getParam("ChangeType"), sa);
if ("LivingDeath".equals(aiLogic)) {
// Living Death AI
return SpecialCardAi.LivingDeath.consider(ai, sa);
} else if ("Timetwister".equals(aiLogic)) {
// Timetwister AI
return SpecialCardAi.Timetwister.consider(ai, sa);
} else if ("RetDiscardedThisTurn".equals(aiLogic)) {
// e.g. Shadow of the Grave
return ai.getDiscardedThisTurn().size() > 0 && ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN);
boolean result = !ai.getDiscardedThisTurn().isEmpty() && ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if ("ExileGraveyards".equals(aiLogic)) {
for (Player opp : ai.getOpponents()) {
CardCollectionView cardsGY = opp.getCardsIn(ZoneType.Graveyard);
CardCollection creats = CardLists.filter(cardsGY, CardPredicates.CREATURES);
if (opp.hasDelirium() || opp.hasThreshold() || creats.size() >= 5) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if ("ManifestCreatsFromGraveyard".equals(aiLogic)) {
PlayerCollection players = ai.getOpponents();
players.add(ai);
@@ -98,68 +98,48 @@ public class ChangeZoneAllAi extends SpellAbilityAi {
bestTgt = player;
}
}
if (bestTgt != null) {
sa.resetTargets();
sa.getTargets().add(bestTgt);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// TODO improve restrictions on when the AI would want to use this
// spBounceAll has some AI we can compare to.
if (origin.equals(ZoneType.Hand) || origin.equals(ZoneType.Library)) {
if (!sa.usesTargeting()) {
// TODO: improve logic for non-targeted SAs of this type (most are currently AI:RemoveDeck:All, e.g. Memory Jar)
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// search targetable Opponents
final PlayerCollection oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
// get the one with the most handsize
Player oppTarget = oppList.max(PlayerPredicates.compareByZoneSize(origin));
// set the target
if (!oppTarget.getCardsIn(ZoneType.Hand).isEmpty()) {
sa.resetTargets();
sa.getTargets().add(oppTarget);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
}
} else if (origin.equals(ZoneType.Battlefield)) {
// this statement is assuming the AI is trying to use this spell offensively
// if the AI is using it defensively, then something else needs to occur
// if only creatures are affected evaluate both lists and pass only
// if human creatures are more valuable
if (sa.usesTargeting()) {
// search targetable Opponents
final PlayerCollection oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
// get the one with the most in graveyard
// zone is visible so evaluate which would be hurt the most
Player oppTarget = oppList.max(PlayerPredicates.compareByZoneSize(origin));
// set the target
if (oppTarget.getCardsIn(ZoneType.Graveyard).isEmpty()) {
sa.resetTargets();
sa.getTargets().add(oppTarget);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
computerType = new CardCollection();
}
int creatureEvalThreshold = 200; // value difference (in evaluateCreatureList units)
int nonCreatureEvalThreshold = 3; // CMC difference
if (ai.getController().isAI()) {
@@ -181,103 +161,80 @@ public class ChangeZoneAllAi extends SpellAbilityAi {
&& game.getPhaseHandler().getPlayerTurn().isOpponentOf(ai)) {
// Life is in serious danger, return all creatures from the battlefield to wherever
// so they don't deal lethal damage
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
if ((ComputerUtilCard.evaluateCreatureList(computerType) + creatureEvalThreshold) >= ComputerUtilCard
.evaluateCreatureList(oppType)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} // mass zone change for non-creatures: evaluate both lists by CMC and pass only if human
// permanents are more valuable
else if ((ComputerUtilCard.evaluatePermanentList(computerType) + nonCreatureEvalThreshold) >= ComputerUtilCard
} else if ((ComputerUtilCard.evaluatePermanentList(computerType) + nonCreatureEvalThreshold) >= ComputerUtilCard
.evaluatePermanentList(oppType)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Don't cast during main1?
if (game.getPhaseHandler().is(PhaseType.MAIN1, ai) && !aiLogic.equals("Main1")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TimingRestrictions);
}
} else if (origin.equals(ZoneType.Graveyard)) {
if (sa.usesTargeting()) {
// search targetable Opponents
final PlayerCollection oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
// get the one with the most in graveyard
// zone is visible so evaluate which would be hurt the most
Player oppTarget = Collections.max(oppList, AiPlayerPredicates.compareByZoneValue(sa.getParam("ChangeType"), origin, sa));
// set the target
if (!oppTarget.getCardsIn(ZoneType.Graveyard).isEmpty()) {
sa.resetTargets();
sa.getTargets().add(oppTarget);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
} else if (destination.equals(ZoneType.Library) && "Card.YouOwn".equals(sa.getParam("ChangeType"))) {
return (ai.getCardsIn(ZoneType.Graveyard).size() > ai.getCardsIn(ZoneType.Library).size())
boolean result = (ai.getCardsIn(ZoneType.Graveyard).size() > ai.getCardsIn(ZoneType.Library).size())
&& !ComputerUtil.isPlayingReanimator(ai);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (origin.equals(ZoneType.Exile)) {
if (aiLogic.startsWith("DiscardAllAndRetExiled")) {
int numExiledWithSrc = CardLists.filter(ai.getCardsIn(ZoneType.Exile), CardPredicates.isExiledWith(source)).size();
int curHandSize = ai.getCardsIn(ZoneType.Hand).size();
// minimum card advantage unless the hand will be fully reloaded
int minAdv = aiLogic.contains(".minAdv") ? Integer.parseInt(aiLogic.substring(aiLogic.indexOf(".minAdv") + 7)) : 0;
boolean noDiscard = aiLogic.contains(".noDiscard");
if (numExiledWithSrc > curHandSize || (noDiscard && numExiledWithSrc > 0)) {
if (ComputerUtil.predictThreatenedObjects(ai, sa, true).contains(source)) {
// Try to gain some card advantage if the card will die anyway
// TODO: ideally, should evaluate the hand value and not discard good hands to it
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return (curHandSize + minAdv - 1 < numExiledWithSrc) || (!noDiscard && numExiledWithSrc >= ai.getMaxHandSize());
boolean result = (curHandSize + minAdv - 1 < numExiledWithSrc) || (!noDiscard && numExiledWithSrc >= ai.getMaxHandSize());
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (origin.equals(ZoneType.Stack)) {
// TODO
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (destination.equals(ZoneType.Battlefield)) {
if (sa.hasParam("GainControl")) {
// Check if the cards are valuable enough
if (CardLists.getNotType(oppType, "Creature").isEmpty() && CardLists.getNotType(computerType, "Creature").isEmpty()) {
if ((ComputerUtilCard.evaluateCreatureList(computerType) + ComputerUtilCard
.evaluateCreatureList(oppType)) < 400) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} // otherwise evaluate both lists by CMC and pass only if human
// permanents are less valuable
else if ((ComputerUtilCard.evaluatePermanentList(computerType) + ComputerUtilCard
} else if ((ComputerUtilCard.evaluatePermanentList(computerType) + ComputerUtilCard
.evaluatePermanentList(oppType)) < 6) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// don't activate if human gets more back than AI does
if (CardLists.getNotType(oppType, "Creature").isEmpty() && CardLists.getNotType(computerType, "Creature").isEmpty()) {
if (ComputerUtilCard.evaluateCreatureList(computerType) <= (ComputerUtilCard
.evaluateCreatureList(oppType) + 100)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} // otherwise evaluate both lists by CMC and pass only if human
// permanents are less valuable
else if (ComputerUtilCard.evaluatePermanentList(computerType) <= (ComputerUtilCard
} else if (ComputerUtilCard.evaluatePermanentList(computerType) <= (ComputerUtilCard
.evaluatePermanentList(oppType) + 2)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return (((MyRandom.getRandom().nextFloat() < .8) || sa.isTrigger()) && chance);
boolean result = ((MyRandom.getRandom().nextFloat() < .8) || sa.isTrigger()) && chance;
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/**
@@ -292,11 +249,11 @@ public class ChangeZoneAllAi extends SpellAbilityAi {
* @return a boolean.
*/
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
// if putting cards from hand to library and parent is drawing cards
// make sure this will actually do something:
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/* (non-Javadoc)
@@ -328,127 +285,92 @@ public class ChangeZoneAllAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, final SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, final SpellAbility sa, boolean mandatory) {
// Change Zone All, can be any type moving from one zone to another
final ZoneType destination = ZoneType.smartValueOf(sa.getParam("Destination"));
final ZoneType origin = ZoneType.listValueOf(sa.getParam("Origin")).get(0);
if (ComputerUtilAbility.getAbilitySourceName(sa).equals("Profaner of the Dead")) {
// TODO: this is a stub to prevent the AI from crashing the game when, for instance, playing the opponent's
// Profaner from exile without paying its mana cost. Otherwise the card is marked AI:RemoveDeck:All and
// there is no specific AI to support playing it in a smarter way. Feel free to expand.
return ai.getOpponents().getCardsIn(origin).anyMatch(CardPredicates.CREATURES);
boolean result = ai.getOpponents().getCardsIn(origin).anyMatch(CardPredicates.CREATURES);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
CardCollectionView humanType = ai.getOpponents().getCardsIn(origin);
humanType = AbilityUtils.filterListByType(humanType, sa.getParam("ChangeType"), sa);
CardCollectionView computerType = ai.getCardsIn(origin);
computerType = AbilityUtils.filterListByType(computerType, sa.getParam("ChangeType"), sa);
// TODO improve restrictions on when the AI would want to use this
// spBounceAll has some AI we can compare to.
if (origin.equals(ZoneType.Hand) || origin.equals(ZoneType.Library)) {
if (sa.usesTargeting()) {
// search targetable Opponents
final PlayerCollection oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
if (mandatory && !sa.isTargetNumberValid() && sa.canTarget(ai)) {
sa.resetTargets();
sa.getTargets().add(ai);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
// get the one with the most handsize
Player oppTarget = oppList.max(PlayerPredicates.compareByZoneSize(origin));
// set the target
if (!oppTarget.getCardsIn(ZoneType.Hand).isEmpty() || mandatory) {
sa.resetTargets();
sa.getTargets().add(oppTarget);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
}
} else if (origin.equals(ZoneType.Battlefield)) {
// if mandatory, no need to evaluate
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// this statement is assuming the AI is trying to use this spell offensively
// if the AI is using it defensively, then something else needs to occur
// if only creatures are affected evaluate both lists and pass only
// if human creatures are more valuable
if (CardLists.getNotType(humanType, "Creature").isEmpty() && CardLists.getNotType(computerType, "Creature").isEmpty()) {
if (ComputerUtilCard.evaluateCreatureList(computerType) >= ComputerUtilCard.evaluateCreatureList(humanType)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} // otherwise evaluate both lists by CMC and pass only if human
// permanents are more valuable
else if (ComputerUtilCard.evaluatePermanentList(computerType) >= ComputerUtilCard.evaluatePermanentList(humanType)) {
return false;
} else if (ComputerUtilCard.evaluatePermanentList(computerType) >= ComputerUtilCard.evaluatePermanentList(humanType)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (origin.equals(ZoneType.Graveyard)) {
if (sa.usesTargeting()) {
// search targetable Opponents
final PlayerCollection oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
if (mandatory && !sa.isTargetNumberValid() && sa.canTarget(ai)) {
sa.resetTargets();
sa.getTargets().add(ai);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return sa.isTargetNumberValid();
return sa.isTargetNumberValid() ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
// get the one with the most in graveyard
// zone is visible so evaluate which would be hurt the most
Player oppTarget = oppList.max(
AiPlayerPredicates.compareByZoneValue(sa.getParam("ChangeType"), origin, sa));
// set the target
if (!oppTarget.getCardsIn(ZoneType.Graveyard).isEmpty() || mandatory) {
sa.resetTargets();
sa.getTargets().add(oppTarget);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
}
} else if (origin.equals(ZoneType.Exile)) {
} else if (origin.equals(ZoneType.Stack)) {
// currently only exists indirectly (e.g. Summary Dismissal via PlayAi)
}
if (destination.equals(ZoneType.Battlefield)) {
// if mandatory, no need to evaluate
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (sa.hasParam("GainControl")) {
// Check if the cards are valuable enough
if (CardLists.getNotType(humanType, "Creature").isEmpty() && CardLists.getNotType(computerType, "Creature").isEmpty()) {
return (ComputerUtilCard.evaluateCreatureList(computerType) + ComputerUtilCard.evaluateCreatureList(humanType)) >= 1;
} // otherwise evaluate both lists by CMC and pass only if human
// permanents are less valuable
return (ComputerUtilCard.evaluatePermanentList(computerType) + ComputerUtilCard
boolean result = (ComputerUtilCard.evaluateCreatureList(computerType) + ComputerUtilCard.evaluateCreatureList(humanType)) >= 1;
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
boolean result = (ComputerUtilCard.evaluatePermanentList(computerType) + ComputerUtilCard
.evaluatePermanentList(humanType)) >= 1;
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// don't activate if human gets more back than AI does
if (CardLists.getNotType(humanType, "Creature").isEmpty() && CardLists.getNotType(computerType, "Creature").isEmpty()) {
return ComputerUtilCard.evaluateCreatureList(computerType) > ComputerUtilCard.evaluateCreatureList(humanType);
} // otherwise evaluate both lists by CMC and pass only if human
// permanents are less valuable
return ComputerUtilCard.evaluatePermanentList(computerType) > ComputerUtilCard.evaluatePermanentList(humanType);
boolean result = ComputerUtilCard.evaluateCreatureList(computerType) > ComputerUtilCard.evaluateCreatureList(humanType);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
boolean result = ComputerUtilCard.evaluatePermanentList(computerType) > ComputerUtilCard.evaluatePermanentList(humanType);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -18,7 +18,7 @@ import java.util.Map;
public class CharmAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Card source = sa.getHostCard();
List<AbilitySub> choices = CharmEffect.makePossibleOptions(sa);
@@ -70,10 +70,10 @@ public class CharmAi extends SpellAbilityAi {
// Set minimum choices for triggers where chooseMultipleOptionsAi() returns null
chosenList = chooseOptionsAi(sa, choices, ai, true, num, min);
if (chosenList.isEmpty() && min != 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -81,7 +81,7 @@ public class CharmAi extends SpellAbilityAi {
sa.setChosenList(chosenList);
if (choiceForOpp) {
return true;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.isSpell()) {
@@ -90,7 +90,11 @@ public class CharmAi extends SpellAbilityAi {
}
// prevent run-away activations - first time will always return true
return MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
if (MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn())) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
private List<AbilitySub> chooseOptionsAi(SpellAbility sa, List<AbilitySub> choices, final Player ai, boolean isTrigger, int num, int min) {
@@ -276,10 +280,10 @@ public class CharmAi extends SpellAbilityAi {
}
@Override
public boolean chkDrawbackWithSubs(Player aiPlayer, AbilitySub ab) {
public AiAbilityDecision chkDrawbackWithSubs(Player aiPlayer, AbilitySub ab) {
// choices were already targeted
if (ab.getRootAbility().getChosenList() != null) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return super.chkDrawbackWithSubs(aiPlayer, ab);
}

View File

@@ -7,7 +7,6 @@ import forge.game.Game;
import forge.game.card.*;
import forge.game.combat.Combat;
import forge.game.keyword.Keyword;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.player.PlayerPredicates;
@@ -26,19 +25,19 @@ public class ChooseCardAi extends SpellAbilityAi {
* The rest of the logic not covered by the canPlayAI template is defined here
*/
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
if (sa.usesTargeting()) {
sa.resetTargets();
// search targetable Opponents
final List<Player> oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.getTargets().add(Iterables.getFirst(oppList, null));
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/**
@@ -135,23 +134,14 @@ public class ChooseCardAi extends SpellAbilityAi {
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
if (sa.hasParam("AILogic") && !checkAiLogic(ai, sa, sa.getParam("AILogic"))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return checkApiLogic(ai, sa);
}
protected boolean checkPhaseRestrictions(Player ai, SpellAbility sa, PhaseHandler ph) {
String aiLogic = sa.getParamOrDefault("AILogic", "");
if (aiLogic.equals("AtOppEOT")) {
return ph.getNextTurn().equals(ai) && ph.is(PhaseType.END_OF_TURN);
}
return super.checkPhaseRestrictions(ai, sa, ph);
}
/* (non-Javadoc)
* @see forge.card.ability.SpellAbilityAi#chooseSingleCard(forge.card.spellability.SpellAbility, java.util.List, boolean)
*/

View File

@@ -22,16 +22,20 @@ import java.util.Map;
public class ChooseCardNameAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
if (sa.hasParam("AILogic")) {
// Don't tap creatures that may be able to block
if (ComputerUtil.waitForBlocking(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
String logic = sa.getParam("AILogic");
if (logic.equals("CursedScroll")) {
return SpecialCardAi.CursedScroll.consider(ai, sa);
if (SpecialCardAi.CursedScroll.consider(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
final TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -43,13 +47,13 @@ public class ChooseCardNameAi extends SpellAbilityAi {
sa.getTargets().add(ai);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
String aiLogic = sa.getParamOrDefault("AILogic", "");
if ("PithingNeedle".equals(aiLogic)) {
// Make sure theres something in play worth Needlings.
@@ -57,18 +61,29 @@ public class ChooseCardNameAi extends SpellAbilityAi {
CardCollection oppPerms = CardLists.getValidCards(ai.getOpponents().getCardsIn(ZoneType.Battlefield), "Card.OppCtrl+hasNonManaActivatedAbility", ai, sa.getHostCard(), sa);
if (oppPerms.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
Card card = ComputerUtilCard.getBestPlaneswalkerAI(oppPerms);
if (card != null) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// 5 percent chance to cast per opposing card with a non mana ability
return MyRandom.getRandom().nextFloat() <= .05 * oppPerms.size();
if (MyRandom.getRandom().nextFloat() <= .05 * oppPerms.size()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (mandatory) {
// If mandatory, then we will play it.
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// If not mandatory, then we won't play it.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return mandatory;
}
/* (non-Javadoc)
* @see forge.card.ability.SpellAbilityAi#chooseSingleCard(forge.card.spellability.SpellAbility, java.util.List, boolean)

View File

@@ -11,40 +11,45 @@ import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
public class ChooseColorAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Game game = ai.getGame();
final String sourceName = ComputerUtilAbility.getAbilitySourceName(sa);
final PhaseHandler ph = game.getPhaseHandler();
if (!sa.hasParam("AILogic")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingLogic);
}
final String logic = sa.getParam("AILogic");
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
if ("Nykthos, Shrine to Nyx".equals(sourceName)) {
return SpecialCardAi.NykthosShrineToNyx.consider(ai, sa);
if (SpecialCardAi.NykthosShrineToNyx.consider(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if ("Oona, Queen of the Fae".equals(sourceName)) {
if (ph.isPlayerTurn(ai) || ph.getPhase().isBefore(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
// Set PayX here to maximum value.
sa.setXManaCostPaid(ComputerUtilCost.getMaxXValue(sa, ai, false));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if ("Addle".equals(sourceName)) {
return !ph.getPhase().isBefore(PhaseType.COMBAT_DECLARE_ATTACKERS) && !ai.getWeakestOpponent().getCardsIn(ZoneType.Hand).isEmpty();
// TODO Why is this not in the AI logic?
// Why are we specifying the weakest opponent?
if (!ph.getPhase().isBefore(PhaseType.COMBAT_DECLARE_ATTACKERS) && !ai.getWeakestOpponent().getCardsIn(ZoneType.Hand).isEmpty()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
}
if (logic.equals("MostExcessOpponentControls")) {
@@ -54,10 +59,10 @@ public class ChooseColorAi extends SpellAbilityAi {
int excess = ComputerUtilCard.evaluatePermanentList(opplist) - ComputerUtilCard.evaluatePermanentList(ailist);
if (excess > 4) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("MostProminentInComputerDeck")) {
if ("Astral Cornucopia".equals(sourceName)) {
// activate in Main 2 hoping that the extra mana surplus will make a difference
@@ -65,22 +70,28 @@ public class ChooseColorAi extends SpellAbilityAi {
CardCollectionView permanents = CardLists.filter(ai.getCardsIn(ZoneType.Hand),
CardPredicates.NONLAND_PERMANENTS);
return permanents.size() > 0 && ph.is(PhaseType.MAIN2, ai);
if (!permanents.isEmpty() && ph.is(PhaseType.MAIN2, ai)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
}
} else if (logic.equals("HighestDevotionToColor")) {
// currently only works more or less reliably in Main2 to cast own spells
if (!ph.is(PhaseType.MAIN2, ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
}
boolean chance = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
return chance;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(ai, sa);
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.Direction;
import forge.game.Game;
@@ -18,11 +20,11 @@ public class ChooseDirectionAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
final String logic = sa.getParam("AILogic");
final Game game = sa.getActivatingPlayer().getGame();
if (logic == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingLogic);
} else {
if ("Aminatou".equals(logic)) {
CardCollection all = CardLists.filter(game.getCardsIn(ZoneType.Battlefield), CardPredicates.NONLAND_PERMANENTS);
@@ -33,19 +35,24 @@ public class ChooseDirectionAi extends SpellAbilityAi {
CardCollection right = CardLists.filterControlledBy(all, game.getNextPlayerAfter(ai, Direction.Right));
int leftValue = Aggregates.sum(left, Card::getCMC);
int rightValue = Aggregates.sum(right, Card::getCMC);
return aiValue <= leftValue && aiValue <= rightValue;
if (aiValue <= leftValue && aiValue <= rightValue) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return true;
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
return canPlayAI(ai, sa);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
return canPlay(ai, sa);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(ai, sa);
}
}

View File

@@ -1,17 +1,18 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiAttackController;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.util.MyRandom;
public class ChooseEvenOddAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
if (!sa.hasParam("AILogic")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingLogic);
}
if (sa.usesTargeting()) {
sa.resetTargets();
@@ -19,16 +20,17 @@ public class ChooseEvenOddAi extends SpellAbilityAi {
if (sa.canTarget(opp)) {
sa.getTargets().add(opp);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
boolean chance = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
return chance;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(ai, sa);
}
}

View File

@@ -7,7 +7,6 @@ import forge.game.Game;
import forge.game.card.Card;
import forge.game.card.CardCollectionView;
import forge.game.cost.Cost;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.AbilitySub;
@@ -20,7 +19,6 @@ import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
public class ChooseGenericAi extends SpellAbilityAi {
@Override
@@ -29,13 +27,10 @@ public class ChooseGenericAi extends SpellAbilityAi {
return true;
} else if ("Pump".equals(aiLogic) || "BestOption".equals(aiLogic)) {
for (AbilitySub sb : sa.getAdditionalAbilityList("Choices")) {
if (SpellApiToAi.Converter.get(sb).canPlayAIWithSubs(ai, sb)) {
if (SpellApiToAi.Converter.get(sb).canPlayWithSubs(ai, sb).willingToPlay()) {
return true;
}
}
} else if ("AtOppEOT".equals(aiLogic)) {
PhaseHandler ph = ai.getGame().getPhaseHandler();
return ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn() == ai;
} else if ("Always".equals(aiLogic)) {
return true;
}
@@ -43,35 +38,46 @@ public class ChooseGenericAi extends SpellAbilityAi {
}
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
return sa.hasParam("AILogic");
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
if (sa.hasParam("AILogic")) {
// This is equivilant to what was here before but feels bad
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#chkAIDrawback(java.util.Map, forge.card.spellability.SpellAbility, forge.game.player.Player)
*/
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
return sa.isTrigger() ? doTriggerAINoCost(aiPlayer, sa, sa.isMandatory()) : checkApiLogic(aiPlayer, sa);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
AiAbilityDecision decision;
if (sa.isTrigger()) {
decision = doTriggerNoCost(aiPlayer, sa, sa.isMandatory());
} else {
decision = checkApiLogic(aiPlayer, sa);
}
return decision;
}
@Override
protected boolean doTriggerAINoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
if ("CombustibleGearhulk".equals(sa.getParam("AILogic")) || "SoulEcho".equals(sa.getParam("AILogic"))) {
for (final Player p : aiPlayer.getOpponents()) {
if (p.canBeTargetedBy(sa)) {
sa.resetTargets();
sa.getTargets().add(p);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return true; // perhaps the opponent(s) had Sigarda, Heron's Grace or another effect giving hexproof in play, still play the creature as 6/6
return new AiAbilityDecision(100, AiPlayDecision.WillPlay); // perhaps the opponent(s) had Sigarda, Heron's Grace or another effect giving hexproof in play, still play the creature as 6/6
}
if (ComputerUtilAbility.getAbilitySourceName(sa).equals("Deathmist Raptor")) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return super.doTriggerAINoCost(aiPlayer, sa, mandatory);
return super.doTriggerNoCost(aiPlayer, sa, mandatory);
}
@Override
@@ -262,7 +268,7 @@ public class ChooseGenericAi extends SpellAbilityAi {
List<SpellAbility> filtered = Lists.newArrayList();
// filter first for the spells which can be done
for (SpellAbility sp : spells) {
if (SpellApiToAi.Converter.get(sp).canPlayAIWithSubs(player, sp)) {
if (SpellApiToAi.Converter.get(sp).canPlayWithSubs(player, sp).willingToPlay()) {
filtered.add(sp);
}
}

View File

@@ -1,21 +1,18 @@
package forge.ai.ability;
import forge.ai.AiAttackController;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.ability.AbilityUtils;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.util.MyRandom;
public class ChooseNumberAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
String aiLogic = sa.getParamOrDefault("AILogic", "");
if (aiLogic.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingLogic);
} else if (aiLogic.equals("SweepCreatures")) {
int maxChoiceLimit = AbilityUtils.calculateAmount(sa.getHostCard(), sa.getParam("Max"), sa);
int ownCreatureCount = aiPlayer.getCreaturesInPlay().size();
@@ -30,17 +27,24 @@ public class ChooseNumberAi extends SpellAbilityAi {
}
if (refOpp == null) {
return false; // no opponent has any creatures
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
int evalAI = ComputerUtilCard.evaluateCreatureList(aiPlayer.getCreaturesInPlay());
int evalOpp = ComputerUtilCard.evaluateCreatureList(refOpp.getCreaturesInPlay());
if (aiPlayer.getLifeLostLastTurn() + aiPlayer.getLifeLostThisTurn() == 0 && evalAI > evalOpp) {
return false; // we're not pressured and our stuff seems better, don't do it yet
// we're not pressured and our stuff seems better, don't do it yet
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
return ownCreatureCount > oppMaxCreatureCount + 2 || ownCreatureCount < Math.min(oppMaxCreatureCount, maxChoiceLimit);
if (ownCreatureCount > oppMaxCreatureCount + 2 || ownCreatureCount < Math.min(oppMaxCreatureCount, maxChoiceLimit)) {
// we have more creatures than the opponent, or we have less than the opponent but more than the max choice limit
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// we have less creatures than the opponent and less than the max choice limit
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (sa.usesTargeting()) {
@@ -49,16 +53,18 @@ public class ChooseNumberAi extends SpellAbilityAi {
if (sa.canTarget(opp)) {
sa.getTargets().add(opp);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
boolean chance = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
return chance;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} {
return canPlay(ai, sa);
}
}
}

View File

@@ -2,6 +2,8 @@ package forge.ai.ability;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtil;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
@@ -15,18 +17,18 @@ import java.util.Map;
public class ChoosePlayerAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
return true;
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
return canPlayAI(ai, sa);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
return canPlay(ai, sa);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return canPlayAI(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
return canPlay(ai, sa);
}
@Override

View File

@@ -1,10 +1,7 @@
package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.AiAttackController;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilCombat;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.GameObject;
import forge.game.ability.AbilityUtils;
@@ -14,7 +11,6 @@ import forge.game.card.CardCollectionView;
import forge.game.card.CardLists;
import forge.game.card.CardPredicates;
import forge.game.combat.Combat;
import forge.game.cost.Cost;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
@@ -32,21 +28,13 @@ public class ChooseSourceAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(final Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, SpellAbility sa) {
// TODO: AI Support! Currently this is copied from AF ChooseCard.
// When implementing AI, I believe AI also needs to be made aware of the damage sources chosen
// to be prevented (e.g. so the AI doesn't attack with a creature that will not deal any damage
// to the player because a CoP was pre-activated on it - unless, of course, there's another
// possible reason to attack with that creature).
final Card host = sa.getHostCard();
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
if (abCost != null) {
if (!willPayCosts(ai, sa, abCost, source)) {
return false;
}
}
if (sa.usesTargeting()) {
sa.resetTargets();
@@ -54,7 +42,7 @@ public class ChooseSourceAi extends SpellAbilityAi {
if (sa.canTarget(opp)) {
sa.getTargets().add(opp);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
if (sa.hasParam("AILogic")) {
@@ -63,11 +51,11 @@ public class ChooseSourceAi extends SpellAbilityAi {
if (!game.getStack().isEmpty()) {
final SpellAbility topStack = game.getStack().peekAbility();
if (sa.hasParam("Choices") && !topStack.matchesValid(topStack.getHostCard(), sa.getParam("Choices").split(","))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
final ApiType threatApi = topStack.getApi();
if (threatApi != ApiType.DealDamage && threatApi != ApiType.DamageAll) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
final Card threatSource = topStack.getHostCard();
@@ -79,13 +67,17 @@ public class ChooseSourceAi extends SpellAbilityAi {
}
if (!objects.contains(ai) || topStack.hasParam("NoPrevention")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
int dmg = AbilityUtils.calculateAmount(threatSource, topStack.getParam("NumDmg"), topStack);
return ComputerUtilCombat.predictDamageTo(ai, dmg, threatSource, false) > 0;
if (ComputerUtilCombat.predictDamageTo(ai, dmg, threatSource, false) > 0) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (game.getPhaseHandler().getPhase() != PhaseType.COMBAT_DECLARE_BLOCKERS) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
CardCollectionView choices = game.getCardsIn(ZoneType.Battlefield);
if (sa.hasParam("Choices")) {
@@ -98,11 +90,13 @@ public class ChooseSourceAi extends SpellAbilityAi {
}
return ComputerUtilCombat.damageIfUnblocked(c, ai, combat, true) > 0;
});
return !choices.isEmpty();
if (choices.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override

View File

@@ -21,23 +21,37 @@ import java.util.Set;
public class ChooseTypeAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
String aiLogic = sa.getParamOrDefault("AILogic", "");
if (aiLogic.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingLogic);
} else if ("MostProminentComputerControls".equals(aiLogic)) {
if (ComputerUtilAbility.getAbilitySourceName(sa).equals("Mirror Entity Avatar")) {
return doMirrorEntityLogic(aiPlayer, sa);
if (doMirrorEntityLogic(aiPlayer, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return !chooseType(sa, aiPlayer.getCardsIn(ZoneType.Battlefield)).isEmpty();
} else if ("MostProminentComputerControlsOrOwns".equals(aiLogic)) {
return !chooseType(sa, aiPlayer.getCardsIn(Arrays.asList(ZoneType.Hand, ZoneType.Battlefield))).isEmpty();
} else if ("MostProminentOppControls".equals(aiLogic)) {
return !chooseType(sa, aiPlayer.getOpponents().getCardsIn(ZoneType.Battlefield)).isEmpty();
}
return doTriggerAINoCost(aiPlayer, sa, false);
if (!chooseType(sa, aiPlayer.getCardsIn(ZoneType.Battlefield)).isEmpty()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("MostProminentComputerControlsOrOwns".equals(aiLogic)) {
return !chooseType(sa, aiPlayer.getCardsIn(Arrays.asList(ZoneType.Hand, ZoneType.Battlefield))).isEmpty()
? new AiAbilityDecision(100, AiPlayDecision.WillPlay)
: new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if ("MostProminentOppControls".equals(aiLogic)) {
return !chooseType(sa, aiPlayer.getOpponents().getCardsIn(ZoneType.Battlefield)).isEmpty()
? new AiAbilityDecision(100, AiPlayDecision.WillPlay)
: new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return doTriggerNoCost(aiPlayer, sa, false);
}
private boolean doMirrorEntityLogic(Player aiPlayer, SpellAbility sa) {
@@ -101,7 +115,7 @@ public class ChooseTypeAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
boolean isCurse = sa.isCurse();
if (sa.usesTargeting()) {
@@ -133,16 +147,16 @@ public class ChooseTypeAi extends SpellAbilityAi {
}
if (!sa.isTargetNumberValid()) {
return false; // nothing to target?
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
for (final Player p : AbilityUtils.getDefinedPlayers(sa.getHostCard(), sa.getParam("Defined"), sa)) {
if (p.isOpponentOf(ai) && !mandatory && !isCurse) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private String chooseType(SpellAbility sa, CardCollectionView cards) {

View File

@@ -2,6 +2,8 @@ package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.card.Card;
@@ -22,14 +24,15 @@ public class ClashAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#doTriggerAINoCost(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility, boolean)
*/
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
boolean legalAction = true;
if (sa.usesTargeting()) {
legalAction = selectTarget(aiPlayer, sa);
}
return legalAction;
return legalAction ? new AiAbilityDecision(100, AiPlayDecision.WillPlay)
: new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
/*
@@ -39,14 +42,17 @@ public class ClashAi extends SpellAbilityAi {
* forge.game.spellability.SpellAbility)
*/
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
boolean legalAction = true;
if (sa.usesTargeting()) {
legalAction = selectTarget(ai, sa);
if (!legalAction) {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
return legalAction;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/*
@@ -104,7 +110,6 @@ public class ClashAi extends SpellAbilityAi {
}
}
return sa.getTargets().size() > 0;
return !sa.getTargets().isEmpty();
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.ai.SpellApiToAi;
import forge.game.ability.AbilityUtils;
@@ -12,7 +14,8 @@ import forge.game.trigger.TriggerType;
public class ClassLevelUpAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
// TODO does leveling up affect combat? Otherwise wait for Main2
Card host = sa.getHostCard();
final int level = host.getClassLevel() + 1;
for (StaticAbility stAb : host.getStaticAbilities()) {
@@ -25,12 +28,12 @@ public class ClassLevelUpAi extends SpellAbilityAi {
continue;
}
SpellAbility effect = t.ensureAbility();
if (!SpellApiToAi.Converter.get(effect).doTriggerAI(aiPlayer, effect, false)) {
return false;
if (!SpellApiToAi.Converter.get(effect).doTrigger(aiPlayer, effect, false)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.Game;
@@ -18,7 +20,7 @@ import java.util.Map;
public class CloneAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
final Card source = sa.getHostCard();
final Game game = source.getGame();
@@ -37,7 +39,7 @@ public class CloneAi extends SpellAbilityAi {
// "Can I use this to block something?"
if (!checkPhaseRestrictions(ai, sa, game.getPhaseHandler())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingPhaseRestrictions);
}
PhaseHandler phase = game.getPhaseHandler();
@@ -66,18 +68,19 @@ public class CloneAi extends SpellAbilityAi {
}
if (!bFlag) { // All of the defined stuff is cloned, not very useful
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
} else {
sa.resetTargets();
useAbility &= cloneTgtAI(sa);
}
return useAbility;
return useAbility ? new AiAbilityDecision(100, AiPlayDecision.WillPlay)
: new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} // end cloneCanPlayAI()
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
// AI should only activate this during Human's turn
boolean chance = true;
@@ -85,11 +88,12 @@ public class CloneAi extends SpellAbilityAi {
chance = cloneTgtAI(sa);
}
return chance;
return chance ? new AiAbilityDecision(100, AiPlayDecision.WillPlay)
: new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
Card host = sa.getHostCard();
boolean chance = true;
@@ -111,7 +115,11 @@ public class CloneAi extends SpellAbilityAi {
// Eventually, we can call the trigger of ETB abilities with
// not mandatory as part of the checks to cast something
return chance || mandatory;
if (mandatory || chance) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/**

View File

@@ -1,9 +1,6 @@
package forge.ai.ability;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilMana;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
import forge.game.card.CardCollection;
@@ -14,16 +11,16 @@ import forge.game.zone.ZoneType;
public class ConniveAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
if (!ai.canDraw()) {
return false; // can't draw anything
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
Card host = sa.getHostCard();
final int num = AbilityUtils.calculateAmount(host, sa.getParamOrDefault("ConniveNum", "1"), sa);
if (num == 0) {
return false; // Won't do anything
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
CardCollection list = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
@@ -41,7 +38,7 @@ public class ConniveAi extends SpellAbilityAi {
sa.resetTargets();
while (sa.canAddMoreTarget()) {
if ((list.isEmpty() && sa.isTargetNumberValid() && !sa.getTargets().isEmpty())) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (list.isEmpty()) {
@@ -53,7 +50,7 @@ public class ConniveAi extends SpellAbilityAi {
if (list.isEmpty()) {
// Not mandatory, or the the list was regenerated and is still empty,
// so return whether or not we found enough targets
return sa.isTargetNumberValid();
return new AiAbilityDecision(sa.isTargetNumberValid() ? 100 : 0, sa.isTargetNumberValid() ? AiPlayDecision.WillPlay : AiPlayDecision.CantPlayAi);
}
Card choice = ComputerUtilCard.getBestCreatureAI(list);
@@ -66,13 +63,17 @@ public class ConniveAi extends SpellAbilityAi {
list.clear();
}
}
return !sa.getTargets().isEmpty() && sa.isTargetNumberValid();
if (!sa.getTargets().isEmpty() && sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (!ai.canDraw() && !mandatory) {
return false; // can't draw anything
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
boolean preferred = true;
@@ -85,7 +86,7 @@ public class ConniveAi extends SpellAbilityAi {
while (sa.canAddMoreTarget()) {
if (mandatory) {
if ((list.isEmpty() || !preferred) && sa.isTargetNumberValid()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (list.isEmpty() && preferred) {
@@ -98,14 +99,13 @@ public class ConniveAi extends SpellAbilityAi {
// Still an empty list, but we have to choose something (mandatory); expand targeting to
// include AI's own cards to see if there's anything targetable (e.g. Plague Belcher).
list = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
preferred = false;
}
}
if (list.isEmpty()) {
// Not mandatory, or the the list was regenerated and is still empty,
// so return whether or not we found enough targets
return sa.isTargetNumberValid();
return new AiAbilityDecision(sa.isTargetNumberValid() ? 100 : 0, sa.isTargetNumberValid() ? AiPlayDecision.WillPlay : AiPlayDecision.CantPlayAi);
}
Card choice = ComputerUtilCard.getBestCreatureAI(list);
@@ -118,7 +118,10 @@ public class ConniveAi extends SpellAbilityAi {
list.clear();
}
}
return true;
return new AiAbilityDecision(
sa.isTargetNumberValid() && !sa.getTargets().isEmpty() ? 100 : 0,
sa.isTargetNumberValid() ? AiPlayDecision.WillPlay : AiPlayDecision.TargetingFailed
);
}
}

View File

@@ -1,9 +1,7 @@
package forge.ai.ability;
import com.google.common.collect.Lists;
import forge.ai.ComputerUtilCard;
import forge.ai.SpecialCardAi;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
import forge.game.card.CardCollection;
@@ -13,7 +11,6 @@ import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.spellability.TargetRestrictions;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
public class ControlExchangeAi extends SpellAbilityAi {
@@ -21,7 +18,7 @@ public class ControlExchangeAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, final SpellAbility sa) {
Card object1 = null;
Card object2 = null;
final TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -41,35 +38,40 @@ public class ControlExchangeAi extends SpellAbilityAi {
sa.getTargets().add(object2);
}
if (object1 == null || object2 == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (ComputerUtilCard.evaluateCreature(object1) > ComputerUtilCard.evaluateCreature(object2) + 40) {
sa.getTargets().add(object1);
return MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (!sa.usesTargeting()) {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
if (mandatory) {
return chkAIDrawback(sa, aiPlayer) || sa.isTargetNumberValid();
AiAbilityDecision decision = chkDrawback(sa, aiPlayer);
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return decision;
} else {
return canPlayAI(aiPlayer, sa);
return canPlay(aiPlayer, sa);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
if (!sa.usesTargeting()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
final TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -90,7 +92,7 @@ public class ControlExchangeAi extends SpellAbilityAi {
list = CardLists.getTargetableCards(list, sa);
if (list.isEmpty())
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
Card best = ComputerUtilCard.getBestAI(list);
@@ -106,7 +108,7 @@ public class ControlExchangeAi extends SpellAbilityAi {
// Defined card is better than this one, try to avoid trade
if (!best.equals(realBest)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@@ -115,10 +117,10 @@ public class ControlExchangeAi extends SpellAbilityAi {
return doTrigTwoTargetsLogic(aiPlayer, sa, best);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private boolean doTrigTwoTargetsLogic(Player ai, SpellAbility sa, Card bestFirstTgt) {
private AiAbilityDecision doTrigTwoTargetsLogic(Player ai, SpellAbility sa, Card bestFirstTgt) {
final TargetRestrictions tgt = sa.getTargetRestrictions();
final int creatureThreshold = 100; // TODO: make this configurable from the AI profile
final int nonCreatureThreshold = 2;
@@ -130,30 +132,30 @@ public class ControlExchangeAi extends SpellAbilityAi {
list = CardLists.getTargetableCards(list, sa);
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
Card aiWorst = ComputerUtilCard.getWorstAI(list);
if (aiWorst == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (aiWorst != bestFirstTgt) {
if (bestFirstTgt.isCreature() && aiWorst.isCreature()) {
if ((ComputerUtilCard.evaluateCreature(bestFirstTgt) > ComputerUtilCard.evaluateCreature(aiWorst) + creatureThreshold) || sa.isMandatory()) {
sa.getTargets().add(aiWorst);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
// TODO: compare non-creatures by CMC - can be improved, at least shouldn't give control of things like the Power Nine
if ((bestFirstTgt.getCMC() > aiWorst.getCMC() + nonCreatureThreshold) || sa.isMandatory()) {
sa.getTargets().add(aiWorst);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
sa.clearTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -65,7 +65,7 @@ import java.util.Map;
*/
public class ControlGainAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision canPlay(final Player ai, final SpellAbility sa) {
final List<String> lose = Lists.newArrayList();
if (sa.hasParam("LoseControl")) {
@@ -81,22 +81,30 @@ public class ControlGainAi extends SpellAbilityAi {
if (sa.hasParam("AllValid")) {
CardCollectionView tgtCards = opponents.getCardsIn(ZoneType.Battlefield);
tgtCards = AbilityUtils.filterListByType(tgtCards, sa.getParam("AllValid"), sa);
return !tgtCards.isEmpty();
if (tgtCards.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
return true;
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
sa.resetTargets();
if (sa.hasParam("TargetingPlayer")) {
Player targetingPlayer = AbilityUtils.getDefinedPlayers(sa.getHostCard(), sa.getParam("TargetingPlayer"), sa).get(0);
sa.setTargetingPlayer(targetingPlayer);
return targetingPlayer.getController().chooseTargetsFor(sa);
if (targetingPlayer.getController().chooseTargetsFor(sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
if (tgt.canOnlyTgtOpponent()) {
List<Player> oppList = opponents.filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (tgt.isRandomTarget()) {
@@ -111,12 +119,12 @@ public class ControlGainAi extends SpellAbilityAi {
if (lose.contains("EOT")
&& game.getPhaseHandler().getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS)
&& !sa.isTrigger()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.hasParam("Defined")) {
// no need to target, we'll pick up the target from Defined
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
CardCollection list = opponents.getCardsIn(ZoneType.Battlefield);
@@ -165,7 +173,7 @@ public class ControlGainAi extends SpellAbilityAi {
});
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
int creatures = 0, artifacts = 0, planeswalkers = 0, lands = 0, enchantments = 0;
@@ -194,7 +202,7 @@ public class ControlGainAi extends SpellAbilityAi {
if (list.isEmpty()) {
if ((sa.getTargets().size() < tgt.getMinTargets(sa.getHostCard(), sa)) || (sa.getTargets().size() == 0)) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -257,39 +265,41 @@ public class ControlGainAi extends SpellAbilityAi {
}
}
return true;
return new AiAbilityDecision(
sa.isTargetNumberValid() ? 100 : 0,
sa.isTargetNumberValid() ? AiPlayDecision.WillPlay : AiPlayDecision.TargetingFailed);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (!sa.usesTargeting()) {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
if (sa.hasParam("TargetingPlayer") || (!this.canPlayAI(ai, sa) && mandatory)) {
if (sa.hasParam("TargetingPlayer") || (mandatory && !this.canPlay(ai, sa).willingToPlay())) {
if (sa.getTargetRestrictions().canOnlyTgtOpponent()) {
List<Player> oppList = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
if (oppList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
sa.getTargets().add(Aggregates.random(oppList));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
List<Card> list = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
sa.getTargets().add(ComputerUtilCard.getWorstAI(list));
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, final Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, final Player ai) {
final Game game = ai.getGame();
// Special card logic that is processed elsewhere
@@ -305,7 +315,7 @@ public class ControlGainAi extends SpellAbilityAi {
CardCollectionView tgtCards = ai.getOpponents().getCardsIn(ZoneType.Battlefield);
tgtCards = AbilityUtils.filterListByType(tgtCards, sa.getParam("AllValid"), sa);
if (tgtCards.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
}
final List<String> lose = Lists.newArrayList();
@@ -314,10 +324,14 @@ public class ControlGainAi extends SpellAbilityAi {
lose.addAll(Lists.newArrayList(sa.getParam("LoseControl").split(",")));
}
return !lose.contains("EOT")
|| !game.getPhaseHandler().getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS);
if (lose.contains("EOT")
&& game.getPhaseHandler().getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
} else {
return this.canPlayAI(ai, sa);
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
return this.canPlay(ai, sa);
}
}

View File

@@ -18,6 +18,8 @@
package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.card.Card;
@@ -41,24 +43,22 @@ import java.util.Map;
*/
public class ControlGainVariantAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision canPlay(final Player ai, final SpellAbility sa) {
String logic = sa.getParam("AILogic");
if ("GainControlOwns".equals(logic)) {
List<Card> list = CardLists.filter(ai.getGame().getCardsIn(ZoneType.Battlefield), crd -> crd.isCreature() && !crd.getController().equals(crd.getOwner()));
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
for (final Card c : list) {
if (ai.equals(c.getController())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override

View File

@@ -22,45 +22,52 @@ import java.util.function.Predicate;
public class CopyPermanentAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
Card source = sa.getHostCard();
PhaseHandler ph = aiPlayer.getGame().getPhaseHandler();
String aiLogic = sa.getParamOrDefault("AILogic", "");
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
if ("MomirAvatar".equals(aiLogic)) {
return SpecialCardAi.MomirVigAvatar.consider(aiPlayer, sa);
} else if ("MimicVat".equals(aiLogic)) {
return SpecialCardAi.MimicVat.considerCopy(aiPlayer, sa);
} else if ("AtEOT".equals(aiLogic)) {
return ph.is(PhaseType.END_OF_TURN);
} else if ("AtOppEOT".equals(aiLogic)) {
return ph.is(PhaseType.END_OF_TURN) && ph.getPlayerTurn() != aiPlayer;
} else if ("DuplicatePerms".equals(aiLogic)) {
if (ph.is(PhaseType.END_OF_TURN)) {
if (ph.getPlayerTurn() == aiPlayer) {
// If it's the AI's turn, it can activate at EOT
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// If it's not the AI's turn, it can't activate at EOT
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// Not at EOT phase
return new AiAbilityDecision(0, AiPlayDecision.WaitForEndOfTurn);
}
} if ("DuplicatePerms".equals(aiLogic)) {
final List<Card> valid = AbilityUtils.getDefinedCards(source, sa.getParam("Defined"), sa);
if (valid.size() < 2) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
}
if (sa.hasParam("AtEOT") && !ph.is(PhaseType.MAIN1)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
if (sa.hasParam("Defined")) {
// If there needs to be an imprinted card, don't activate the ability if nothing was imprinted yet (e.g. Mimic Vat)
if (sa.getParam("Defined").equals("Imprinted.ExiledWithSource") && source.getImprintedCards().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
}
if (sa.isEmbalm() || sa.isEternalize()) {
// E.g. Vizier of Many Faces: check to make sure it makes sense to make the token now
if (ComputerUtilCard.checkNeedsToPlayReqs(sa.getHostCard(), sa) != AiPlayDecision.WillPlay) {
return false;
AiPlayDecision decision = ComputerUtilCard.checkNeedsToPlayReqs(sa.getHostCard(), sa);
if (decision != AiPlayDecision.WillPlay) {
return new AiAbilityDecision(0, decision);
}
}
@@ -75,37 +82,45 @@ public class CopyPermanentAi extends SpellAbilityAi {
sa.resetTargets();
Player targetingPlayer = AbilityUtils.getDefinedPlayers(source, sa.getParam("TargetingPlayer"), sa).get(0);
sa.setTargetingPlayer(targetingPlayer);
return targetingPlayer.getController().chooseTargetsFor(sa);
if (targetingPlayer.getController().chooseTargetsFor(sa)) {
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (sa.usesTargeting() && sa.getTargetRestrictions().canTgtPlayer()) {
if (!sa.isCurse()) {
if (sa.canTarget(aiPlayer)) {
sa.getTargets().add(aiPlayer);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
for (Player p : aiPlayer.getYourTeam()) {
if (sa.canTarget(p)) {
sa.getTargets().add(p);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
for (Player p : aiPlayer.getOpponents()) {
if (sa.canTarget(p)) {
sa.getTargets().add(p);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
return doTriggerAINoCost(aiPlayer, sa, false);
return doTriggerNoCost(aiPlayer, sa, false);
}
}
@Override
protected boolean doTriggerAINoCost(final Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(final Player aiPlayer, SpellAbility sa, boolean mandatory) {
final Card host = sa.getHostCard();
final Player activator = sa.getActivatingPlayer();
final Game game = host.getGame();
@@ -128,13 +143,13 @@ public class CopyPermanentAi extends SpellAbilityAi {
//Nothing to target
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
CardCollection betterList = CardLists.filter(list, CardPredicates.isRemAIDeck().negate());
if (betterList.isEmpty()) {
if (!mandatory) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
list = betterList;
@@ -146,7 +161,7 @@ public class CopyPermanentAi extends SpellAbilityAi {
if (felidarGuardian.size() > 0) {
// can copy a Felidar Guardian and combo off, so let's do it
sa.getTargets().add(felidarGuardian.get(0));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -155,9 +170,9 @@ public class CopyPermanentAi extends SpellAbilityAi {
list = CardLists.canSubsequentlyTarget(list, sa);
if (list.isEmpty()) {
if (!sa.isTargetNumberValid() || sa.getTargets().size() == 0) {
if (!sa.isTargetNumberValid() || sa.getTargets().isEmpty()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -177,9 +192,9 @@ public class CopyPermanentAi extends SpellAbilityAi {
}
if (choice == null) { // can't find anything left
if (!sa.isTargetNumberValid() || sa.getTargets().size() == 0) {
if (!sa.isTargetNumberValid() || sa.getTargets().isEmpty()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -194,20 +209,22 @@ public class CopyPermanentAi extends SpellAbilityAi {
choices = CardLists.getValidCards(choices, sa.getParam("Choices"), activator, host, sa);
Collection<Card> betterChoices = getBetterOptions(aiPlayer, sa, choices, !mandatory);
if (betterChoices.isEmpty()) {
return mandatory;
}
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// if no targeting, it should always be ok
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
}
if ("TriggeredCardController".equals(sa.getParam("Controller"))) {
Card trigCard = (Card)sa.getTriggeringObject(AbilityKey.Card);
if (!mandatory && trigCard != null && trigCard.getController().isOpponentOf(aiPlayer)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/* (non-Javadoc)

View File

@@ -17,14 +17,15 @@ import java.util.Map;
public class CopySpellAbilityAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player aiPlayer, SpellAbility sa) {
Game game = aiPlayer.getGame();
int chance = ((PlayerControllerAi)aiPlayer.getController()).getAi().getIntProperty(AiProps.CHANCE_TO_COPY_OWN_SPELL_WHILE_ON_STACK);
int diff = ((PlayerControllerAi)aiPlayer.getController()).getAi().getIntProperty(AiProps.ALWAYS_COPY_SPELL_IF_CMC_DIFF);
String logic = sa.getParamOrDefault("AILogic", "");
if (game.getStack().isEmpty()) {
return sa.isMandatory() || "Always".equals(logic);
boolean result = sa.isMandatory() || "Always".equals(logic);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final SpellAbility top = game.getStack().peekAbility();
@@ -42,46 +43,39 @@ public class CopySpellAbilityAi extends SpellAbilityAi {
if (!MyRandom.percentTrue(chance)
&& !"AlwaysIfViable".equals(logic)
&& !"OnceIfViable".equals(logic)
&& !"AlwaysCopyActivatedAbilities".equals(logic)) {
return false;
}
if ("OnceIfViable".equals(logic)) {
if (AiCardMemory.isRememberedCard(aiPlayer, sa.getHostCard(), AiCardMemory.MemorySet.ACTIVATED_THIS_TURN)) {
return false;
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.usesTargeting()) {
// Filter AI-specific targets if provided
if ("OnlyOwned".equals(sa.getParam("AITgts"))) {
if (!top.getActivatingPlayer().equals(aiPlayer)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (top.isWrapper() || top.isActivatedAbility()) {
// Shouldn't even try with triggered or wrapped abilities at this time, will crash
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (top.getApi() == ApiType.CopySpellAbility) {
// Don't try to copy a copy ability, too complex for the AI to handle
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (top.getApi() == ApiType.Mana) {
// would lead to Stack Overflow by trying to play this again
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (top.getApi() == ApiType.DestroyAll || top.getApi() == ApiType.SacrificeAll || top.getApi() == ApiType.ChangeZoneAll || top.getApi() == ApiType.TapAll || top.getApi() == ApiType.UnattachAll) {
if (!top.usesTargeting() || top.getActivatingPlayer().equals(aiPlayer)) {
// If we activated a mass removal / mass tap / mass bounce / etc. spell, or if the opponent activated it but
// it can't be retargeted, no reason to copy this spell since it'll probably do the same thing and is useless as a copy
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (top.hasParam("ConditionManaSpent") || top.getHostCard().hasSVar("AINoCopy")) {
// Mana spent is not copied, so these spells generally do nothing when copied.
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (ComputerUtilCard.isCardRemAIDeck(top.getHostCard())) {
// Don't try to copy anything you can't understand how to handle
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// A copy is necessary to properly test the SA before targeting the copied spell, otherwise the copy SA will fizzle.
@@ -100,31 +94,49 @@ public class CopySpellAbilityAi extends SpellAbilityAi {
if (decision == AiPlayDecision.WillPlay) {
sa.getTargets().add(top);
AiCardMemory.rememberCard(aiPlayer, sa.getHostCard(), AiCardMemory.MemorySet.ACTIVATED_THIS_TURN);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, decision);
}
}
// the AI should not miss mandatory activations
return sa.isMandatory() || "Always".equals(logic);
boolean result = sa.isMandatory() || "Always".equals(logic);
return result ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
// the AI should not miss mandatory activations (e.g. Precursor Golem trigger)
String logic = sa.getParamOrDefault("AILogic", "");
return mandatory || logic.contains("Always"); // this includes logic like AlwaysIfViable
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (logic.contains("Always")) {
// If the logic is "Always" or "AlwaysIfViable", we will always play this ability
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
public boolean chkAIDrawback(final SpellAbility sa, final Player aiPlayer) {
public AiAbilityDecision chkDrawback(final SpellAbility sa, final Player aiPlayer) {
if ("ChainOfSmog".equals(sa.getParam("AILogic"))) {
return SpecialCardAi.ChainOfSmog.consider(aiPlayer, sa);
} else if ("ChainOfAcid".equals(sa.getParam("AILogic"))) {
return SpecialCardAi.ChainOfAcid.consider(aiPlayer, sa);
}
return canPlayAI(aiPlayer, sa) || (sa.isMandatory() && super.chkAIDrawback(sa, aiPlayer));
}
AiAbilityDecision decision = canPlay(aiPlayer, sa);
if (!decision.willingToPlay()) {
if (sa.isMandatory()) {
return super.chkDrawback(sa, aiPlayer);
}
}
return decision;
}
@Override
@@ -138,7 +150,7 @@ public class CopySpellAbilityAi extends SpellAbilityAi {
// Chain of Acid requires special attention here since otherwise the AI will confirm the copy and then
// run into the necessity of confirming a mandatory Destroy, thus destroying all of its own permanents.
if ("ChainOfAcid".equals(sa.getParam("AILogic"))) {
return SpecialCardAi.ChainOfAcid.consider(player, sa);
return SpecialCardAi.ChainOfAcid.consider(player, sa).willingToPlay();
}
return true;

View File

@@ -26,13 +26,11 @@ import forge.game.zone.ZoneType;
import forge.util.MyRandom;
import forge.util.collect.FCollectionView;
public class CounterAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
boolean toReturn = true;
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
final String sourceName = ComputerUtilAbility.getAbilitySourceName(sa);
final Game game = ai.getGame();
@@ -40,22 +38,12 @@ public class CounterAi extends SpellAbilityAi {
SpellAbility tgtSA = null;
if (game.getStack().isEmpty()) {
return false;
}
if (abCost != null) {
// AI currently disabled for these costs
if (!ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
}
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if ("Force of Will".equals(sourceName)) {
if (!SpecialCardAi.ForceOfWill.consider(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -63,19 +51,19 @@ public class CounterAi extends SpellAbilityAi {
final SpellAbility topSA = ComputerUtilAbility.getTopSpellAbilityOnStack(game, sa);
if ((topSA.isSpell() && !topSA.isCounterableBy(sa)) || ai.getYourTeam().contains(topSA.getActivatingPlayer())) {
// might as well check for player's friendliness
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (sa.hasParam("ConditionWouldDestroy") && !CounterEffect.checkForConditionWouldDestroy(sa, topSA)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
// check if the top ability on the stack corresponds to the AI-specific targeting declaration, if provided
if (sa.hasParam("AITgts") && (topSA.getHostCard() == null
|| !topSA.getHostCard().isValid(sa.getParam("AITgts"), sa.getActivatingPlayer(), source, sa))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (sa.hasParam("CounterNoManaSpell") && topSA.getTotalManaSpent() > 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (sa.hasParam("UnlessCost") && "TargetedController".equals(sa.getParamOrDefault("UnlessPayer", "TargetedController"))) {
@@ -84,7 +72,7 @@ public class CounterAi extends SpellAbilityAi {
CostDiscard discardCost = unlessCost.getCostPartByType(CostDiscard.class);
if ("Hand".equals(discardCost.getType())) {
if (topSA.getActivatingPlayer().getCardsIn(ZoneType.Hand).size() < 2) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -100,10 +88,11 @@ public class CounterAi extends SpellAbilityAi {
tgtCMC += topSA.getPayCosts().getTotalMana().countX() > 0 ? 3 : 0; // TODO: somehow determine the value of X paid and account for it?
}
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
return false;
// This spell doesn't target. Must be a "Coutner All" or "Counter trigger" type of ability.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
String unlessCost = sa.hasParam("UnlessCost") ? sa.getParam("UnlessCost").trim() : null;
@@ -122,13 +111,13 @@ public class CounterAi extends SpellAbilityAi {
}
if (toPay == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
if (toPay <= usableManaSources) {
// If this is a reusable Resource, feel free to play it most of the time
if (!playReusable(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
}
@@ -147,15 +136,15 @@ public class CounterAi extends SpellAbilityAi {
if (sa.hasParam("AILogic")) {
String logic = sa.getParam("AILogic");
if ("Never".equals(logic)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.startsWith("MinCMC.")) { // TODO fix Daze and fold into AITgts
int minCMC = Integer.parseInt(logic.substring(7));
if (tgtCMC < minCMC) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("NullBrooch".equals(logic)) {
if (!SpecialCardAi.NullBrooch.consider(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -234,40 +223,40 @@ public class CounterAi extends SpellAbilityAi {
}
if (dontCounter) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return toReturn;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
return doTriggerAINoCost(aiPlayer, sa, true);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
return doTriggerNoCost(aiPlayer, sa, true);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Game game = ai.getGame();
if (sa.usesTargeting()) {
if (game.getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
sa.resetTargets();
if (mandatory && !sa.canAddMoreTarget()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
Pair<SpellAbility, Boolean> pair = chooseTargetSpellAbility(game, sa, ai, mandatory);
SpellAbility tgtSA = pair.getLeft();
if (tgtSA == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
sa.getTargets().add(tgtSA);
if (!mandatory && !pair.getRight()) {
// If not mandatory and not preferred, bail out after setting target
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
String unlessCost = sa.hasParam("UnlessCost") ? sa.getParam("UnlessCost").trim() : null;
@@ -288,14 +277,13 @@ public class CounterAi extends SpellAbilityAi {
if (!mandatory) {
if (toPay == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
if (toPay <= usableManaSources) {
// If this is a reusable Resource, feel free to play it most
// of the time
// If this is a reusable Resource, feel free to play it most of the time
if (!playReusable(ai,sa) || (MyRandom.getRandom().nextFloat() < .4)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
}
}
@@ -312,7 +300,7 @@ public class CounterAi extends SpellAbilityAi {
// force the Human into making decisions)
// But really it should be more picky about how it counters things
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public Pair<SpellAbility, Boolean> chooseTargetSpellAbility(Game game, SpellAbility sa, Player ai, boolean mandatory) {
@@ -362,11 +350,11 @@ public class CounterAi extends SpellAbilityAi {
@Override
public boolean willPayUnlessCost(SpellAbility sa, Player payer, Cost cost, boolean alreadyPaid, FCollectionView<Player> payers) {
// ward or human misplay
final Card source = sa.getHostCard();
final Game game = source.getGame();
List<SpellAbility> spells = AbilityUtils.getDefinedSpellAbilities(source, sa.getParamOrDefault("Defined", "Targeted"), sa);
for (SpellAbility toBeCountered : spells) {
// ward or human misplay
if (!toBeCountered.isCounterableBy(sa)) {
return false;
}
@@ -381,7 +369,7 @@ public class CounterAi extends SpellAbilityAi {
}
// no reason to pay if we don't plan to confirm
if (toBeCountered.isOptionalTrigger() && !SpellApiToAi.Converter.get(toBeCountered).doTriggerNoCostWithSubs(payer, toBeCountered, false)) {
if (toBeCountered.isOptionalTrigger() && !SpellApiToAi.Converter.get(toBeCountered).doTriggerNoCostWithSubs(payer, toBeCountered, false).willingToPlay()) {
return false;
}
// TODO check hasFizzled

View File

@@ -45,13 +45,13 @@ public abstract class CountersAi extends SpellAbilityAi {
* </p>
*
* @param list
* a {@link forge.CardList} object.
* a {@link CardCollectionView} object.
* @param type
* a {@link java.lang.String} object.
* a {@link String} object.
* @param amount
* a int.
* @param newParam TODO
* @return a {@link forge.game.card.Card} object.
* @param ai a {@link Player} object.
* @return a {@link Card} object.
*/
public static Card chooseCursedTarget(final CardCollectionView list, final String type, final int amount, final Player ai) {
Card choice;
@@ -65,7 +65,7 @@ public abstract class CountersAi extends SpellAbilityAi {
// try to kill the best killable creature, or reduce the best one
// but try not to target a Undying Creature
final List<Card> killable = CardLists.getNotKeyword(CardLists.filterToughness(list, amount), Keyword.UNDYING);
if (killable.size() > 0) {
if (!killable.isEmpty()) {
choice = ComputerUtilCard.getBestCreatureAI(killable);
} else {
choice = ComputerUtilCard.getBestCreatureAI(list);
@@ -83,10 +83,10 @@ public abstract class CountersAi extends SpellAbilityAi {
* </p>
*
* @param list
* a {@link forge.CardList} object.
* a {@link CardCollectionView} object.
* @param type
* a {@link java.lang.String} object.
* @return a {@link forge.game.card.Card} object.
* a {@link String} object.
* @return a {@link Card} object.
*/
public static Card chooseBoonTarget(final CardCollectionView list, final String type) {
Card choice = null;

View File

@@ -1,9 +1,7 @@
package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.ability.AbilityUtils;
import forge.game.card.*;
@@ -21,19 +19,25 @@ import java.util.Map;
public class CountersMoveAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
AiAbilityDecision decision = new AiAbilityDecision(100, AiPlayDecision.WillPlay);
if (sa.usesTargeting()) {
sa.resetTargets();
if (!moveTgtAI(ai, sa)) {
return false;
decision = moveTgtAI(ai, sa);
if (!decision.willingToPlay()) {
return decision;
}
}
if (!playReusable(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return MyRandom.getRandom().nextFloat() < .8f; // random success
if (MyRandom.getRandom().nextFloat() < .8f) {
return decision;
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
@@ -109,12 +113,13 @@ public class CountersMoveAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(final Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(final Player ai, SpellAbility sa, boolean mandatory) {
if (sa.usesTargeting()) {
sa.resetTargets();
if (!moveTgtAI(ai, sa) && !mandatory) {
return false;
AiAbilityDecision decision = moveTgtAI(ai, sa);
if (!decision.willingToPlay() && !mandatory) {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (!sa.isTargetNumberValid() && mandatory) {
@@ -122,18 +127,18 @@ public class CountersMoveAi extends SpellAbilityAi {
List<Card> tgtCards = CardLists.getTargetableCards(game.getCardsIn(ZoneType.Battlefield), sa);
if (tgtCards.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
final Card card = ComputerUtilCard.getWorstAI(tgtCards);
sa.getTargets().add(card);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// no target Probably something like Graft
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
final Card host = sa.getHostCard();
@@ -145,7 +150,7 @@ public class CountersMoveAi extends SpellAbilityAi {
final List<Card> destCards = AbilityUtils.getDefinedCards(host, sa.getParam("Defined"), sa);
if (srcCards.isEmpty() || destCards.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
final Card src = srcCards.get(0);
@@ -153,21 +158,21 @@ public class CountersMoveAi extends SpellAbilityAi {
// for such Trigger, do not move counter to another players creature
if (!dest.getController().equals(ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (ComputerUtilCard.isUselessCreature(ai, dest)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (dest.hasSVar("EndOfTurnLeavePlay")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (cType != null) {
if (!dest.canReceiveCounters(cType)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final int amount = calcAmount(sa, cType);
int a = src.getCounters(cType);
if (a < amount) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final Card srcCopy = CardCopyService.getLKICopy(src);
@@ -181,27 +186,31 @@ public class CountersMoveAi extends SpellAbilityAi {
int newEval = ComputerUtilCard.evaluateCreature(srcCopy) + ComputerUtilCard.evaluateCreature(destCopy);
if (newEval < oldEval) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
// check for some specific AI preferences
if ("DontMoveCounterIfLethal".equals(sa.getParam("AILogic"))) {
return !cType.is(CounterEnumType.P1P1) || src.getNetToughness() - src.getTempToughnessBoost() - 1 > 0;
if (!cType.is(CounterEnumType.P1P1) || src.getNetToughness() - src.getTempToughnessBoost() - 1 > 0) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// no target
return true;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
if (sa.usesTargeting()) {
sa.resetTargets();
return moveTgtAI(ai, sa);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private static int calcAmount(final SpellAbility sa, final CounterType cType) {
@@ -226,7 +235,7 @@ public class CountersMoveAi extends SpellAbilityAi {
return amount;
}
private boolean moveTgtAI(final Player ai, final SpellAbility sa) {
private AiAbilityDecision moveTgtAI(final Player ai, final SpellAbility sa) {
final Card host = sa.getHostCard();
final Game game = ai.getGame();
final String type = sa.getParam("CounterType");
@@ -244,7 +253,7 @@ public class CountersMoveAi extends SpellAbilityAi {
if (destCards.isEmpty()) {
// something went wrong
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
final Card dest = destCards.get(0);
@@ -253,7 +262,7 @@ public class CountersMoveAi extends SpellAbilityAi {
tgtCards.remove(dest);
if (cType != null && !dest.canReceiveCounters(cType)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// prefered logic for this: try to steal counter
@@ -285,7 +294,7 @@ public class CountersMoveAi extends SpellAbilityAi {
if (card != null) {
sa.getTargets().add(card);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -329,14 +338,14 @@ public class CountersMoveAi extends SpellAbilityAi {
if (card != null) {
sa.getTargets().add(card);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else if (sa.getMaxTargets() == 2) {
// TODO
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// SA uses target for Defined
// Source => Targeted
@@ -344,12 +353,12 @@ public class CountersMoveAi extends SpellAbilityAi {
if (srcCards.isEmpty()) {
// something went wrong
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
final Card src = srcCards.get(0);
if (cType != null && src.getCounters(cType) <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
Card lkiWithCounters = CardCopyService.getLKICopy(src);
@@ -402,14 +411,14 @@ public class CountersMoveAi extends SpellAbilityAi {
if (card != null) {
sa.getTargets().add(card);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
final boolean isMandatoryTrigger = (sa.isTrigger() && !sa.isOptionalTrigger())
|| (sa.getRootAbility().isTrigger() && !sa.getRootAbility().isOptionalTrigger());
if (!isMandatoryTrigger) {
// no good target
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@@ -439,10 +448,10 @@ public class CountersMoveAi extends SpellAbilityAi {
if (card != null) {
sa.getTargets().add(card);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}

View File

@@ -1,9 +1,7 @@
package forge.ai.ability;
import com.google.common.collect.Lists;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCost;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.ability.AbilityUtils;
import forge.game.card.*;
@@ -21,7 +19,7 @@ import java.util.Map;
public class CountersMultiplyAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final CounterType counterType = getCounterType(sa);
if (!sa.usesTargeting()) {
@@ -53,7 +51,7 @@ public class CountersMultiplyAi extends SpellAbilityAi {
});
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
} else {
return setTargets(ai, sa);
@@ -85,24 +83,27 @@ public class CountersMultiplyAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (!sa.usesTargeting()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (setTargets(ai, sa)) {
return true;
AiAbilityDecision decision = setTargets(ai, sa);
if (decision.willingToPlay()) {
return decision;
} else if (mandatory) {
CardCollection list = CardLists.getTargetableCards(ai.getGame().getCardsIn(ZoneType.Battlefield), sa);
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
Card safeMatch = list.stream()
.filter(CardPredicates.hasCounters().negate())
.findFirst().orElse(null);
sa.getTargets().add(safeMatch == null ? list.getFirst() : safeMatch);
return true;
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
return mandatory;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
private CounterType getCounterType(SpellAbility sa) {
@@ -117,7 +118,7 @@ public class CountersMultiplyAi extends SpellAbilityAi {
return null;
}
private boolean setTargets(Player ai, SpellAbility sa) {
private AiAbilityDecision setTargets(Player ai, SpellAbility sa) {
final CounterType counterType = getCounterType(sa);
final Game game = ai.getGame();
@@ -173,10 +174,10 @@ public class CountersMultiplyAi extends SpellAbilityAi {
// targeting does failed
if (!sa.isTargetNumberValid() || sa.getTargets().size() == 0) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private void addTargetsByCounterType(final Player ai, final SpellAbility sa, final CardCollection list,

View File

@@ -16,7 +16,7 @@ import java.util.Map;
public class CountersProliferateAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final List<Card> cperms = Lists.newArrayList();
boolean allyExpOrEnergy = false;
@@ -68,25 +68,34 @@ public class CountersProliferateAi extends SpellAbilityAi {
}));
}
return !cperms.isEmpty() || !hperms.isEmpty() || opponentPoison || allyExpOrEnergy;
if (!cperms.isEmpty() || !hperms.isEmpty() || opponentPoison || allyExpOrEnergy) {
// AI will play it if there are any counters to proliferate
// or if there are no counters, but AI has experience or energy counters
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
boolean chance = true;
// TODO Make sure Human has poison counters or there are some counters
// we want to proliferate
return chance;
return new AiAbilityDecision(
chance ? 100 : 0,
chance ? AiPlayDecision.WillPlay : AiPlayDecision.CantPlayAi
);
}
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#chkAIDrawback(java.util.Map, forge.card.spellability.SpellAbility, forge.game.player.Player)
*/
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
if ("Always".equals(sa.getParam("AILogic"))) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return checkApiLogic(ai, sa);

View File

@@ -53,8 +53,7 @@ public class CountersPutAi extends CountersAi {
// disable moving counters (unless a specialized AI logic supports it)
for (final CostPart part : cost.getCostParts()) {
if (part instanceof CostRemoveCounter) {
final CostRemoveCounter remCounter = (CostRemoveCounter) part;
if (part instanceof CostRemoveCounter remCounter) {
final CounterType counterType = remCounter.counter;
if (counterType.getName().equals(type) && !aiLogic.startsWith("MoveCounter")) {
return false;
@@ -98,7 +97,7 @@ public class CountersPutAi extends CountersAi {
}
}
if (sa.hasParam("LevelUp")) {
if (sa.isKeyword(Keyword.LEVEL_UP)) {
// creatures enchanted by curse auras have low priority
if (ph.getPhase().isBefore(PhaseType.MAIN2)) {
for (Card aura : source.getEnchantedBy()) {
@@ -119,7 +118,7 @@ public class CountersPutAi extends CountersAi {
}
@Override
protected boolean checkApiLogic(Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, final SpellAbility sa) {
// AI needs to be expanded, since this function can be pretty complex
// based on what the expected targets could be
final Cost abCost = sa.getPayCosts();
@@ -160,7 +159,7 @@ public class CountersPutAi extends CountersAi {
PlayerCollection poisonList = oppList.filter(PlayerPredicates.hasCounter(CounterEnumType.POISON, 9));
if (!poisonList.isEmpty()) {
sa.getTargets().add(poisonList.max(PlayerPredicates.compareByLife()));
return true;
return new AiAbilityDecision(1000, AiPlayDecision.WillPlay);
}
}
@@ -176,7 +175,7 @@ public class CountersPutAi extends CountersAi {
Card best = ComputerUtilCard.getBestAI(oppCreatM1);
if (best != null) {
sa.getTargets().add(best);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
CardCollection aiCreat = CardLists.getTargetableCards(ai.getCreaturesInPlay(), sa);
@@ -196,7 +195,7 @@ public class CountersPutAi extends CountersAi {
best = ComputerUtilCard.getBestAI(aiCreat);
if (best != null) {
sa.getTargets().add(best);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -205,28 +204,22 @@ public class CountersPutAi extends CountersAi {
if (!ai.getCounters().isEmpty()) {
if (!eachExisting || ai.getPoisonCounters() < 5) {
sa.getTargets().add(ai);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
if ("Never".equals(logic)) {
return false;
} else if ("AlwaysWithNoTgt".equals(logic)) {
return true;
if ("AlwaysWithNoTgt".equals(logic)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if ("AristocratCounters".equals(logic)) {
return SpecialAiLogic.doAristocratWithCountersLogic(ai, sa);
} else if ("PayEnergy".equals(logic)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if ("PayEnergyConservatively".equals(logic)) {
boolean onlyInCombat = ai.getController().isAI()
&& ((PlayerControllerAi) ai.getController()).getAi().getBooleanProperty(AiProps.CONSERVATIVE_ENERGY_PAYMENT_ONLY_IN_COMBAT);
@@ -235,10 +228,10 @@ public class CountersPutAi extends CountersAi {
if (playAggro) {
// aggro profiles ignore conservative play for this AI logic
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (ph.inCombat() && source != null) {
if (ai.getGame().getCombat().isAttacking(source) && !onlyDefensive) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
} else if (ai.getGame().getCombat().isBlocking(source)) {
// when blocking, consider this if it's possible to save the blocker and/or kill at least one attacker
CardCollection blocked = ai.getGame().getCombat().getAttackersBlockedBy(source);
@@ -248,28 +241,28 @@ public class CountersPutAi extends CountersAi {
int numActivations = ai.getCounters(CounterEnumType.ENERGY) / sa.getPayCosts().getCostEnergy().convertAmount();
if (source.getNetToughness() + numActivations > totBlkPower
|| source.getNetPower() + numActivations >= totBlkToughness) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
}
} else if (sa.getSubAbility() != null
&& "Self".equals(sa.getSubAbility().getParam("Defined"))
&& sa.getSubAbility().getParamOrDefault("KW", "").contains("Hexproof")
&& !AiCardMemory.isRememberedCard(ai, source, AiCardMemory.MemorySet.ANIMATED_THIS_TURN)) {
&& !AiCardMemory.isRememberedCard(ai, source, AiCardMemory.MemorySet.ACTIVATED_THIS_TURN)) {
// Bristling Hydra: save from death using a ping activation
if (ComputerUtil.predictThreatenedObjects(sa.getActivatingPlayer(), sa).contains(source)) {
AiCardMemory.rememberCard(ai, source, AiCardMemory.MemorySet.ACTIVATED_THIS_TURN);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else if (ai.getCounters(CounterEnumType.ENERGY) > ComputerUtilCard.getMaxSAEnergyCostOnBattlefield(ai) + sa.getPayCosts().getCostEnergy().convertAmount()) {
// outside of combat, this logic only works if the relevant AI profile option is enabled
// and if there is enough energy saved
if (!onlyInCombat) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
} else if (logic.equals("MarkOppCreature")) {
if (!ph.is(PhaseType.END_OF_TURN)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForEndOfTurn);
}
Predicate<Card> predicate = CardPredicates.hasCounter(CounterType.getType(type));
@@ -281,12 +274,12 @@ public class CountersPutAi extends CountersAi {
Card bestCreat = ComputerUtilCard.getBestCreatureAI(oppCreats);
sa.resetTargets();
sa.getTargets().add(bestCreat);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else if (logic.equals("CheckDFC")) {
// for cards like Ludevic's Test Subject
if (!source.canTransform(null)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (logic.startsWith("MoveCounter")) {
return doMoveCounterLogic(ai, sa, ph);
@@ -295,8 +288,15 @@ public class CountersPutAi extends CountersAi {
if (willActivate && ph.getPhase().isBefore(PhaseType.MAIN2)) {
// don't use this for mana until after combat
AiCardMemory.rememberCard(ai, source, AiCardMemory.MemorySet.HELD_MANA_SOURCES_FOR_MAIN2);
return new AiAbilityDecision(25, AiPlayDecision.WaitForMain2);
}
return willActivate;
if (willActivate) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (logic.equals("ChargeToBestCMC")) {
return doChargeToCMCLogic(ai, sa);
} else if (logic.equals("ChargeToBestOppControlledCMC")) {
@@ -305,15 +305,11 @@ public class CountersPutAi extends CountersAi {
return SpecialCardAi.TheOneRing.consider(ai, sa);
}
if (!sa.metConditions() && sa.getSubAbility() == null) {
return false;
}
if (sourceName.equals("Feat of Resistance")) { // sub-ability should take precedence
CardCollection prot = ProtectAi.getProtectCreatures(ai, sa.getSubAbility());
if (!prot.isEmpty()) {
sa.getTargets().add(prot.get(0));
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
}
@@ -321,13 +317,13 @@ public class CountersPutAi extends CountersAi {
CardCollection creatsYouCtrl = ai.getCreaturesInPlay();
List<Card> leastToughness = Aggregates.listWithMin(creatsYouCtrl, Card::getNetToughness);
if (leastToughness.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
// TODO If Creature that would be Bolstered for some reason is useless, also return False
}
if (sa.hasParam("Monstrosity") && source.isMonstrous()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// TODO handle proper calculation of X values based on Cost
@@ -342,7 +338,7 @@ public class CountersPutAi extends CountersAi {
Combat combat = game.getCombat();
if (!source.canReceiveCounters(CounterType.get(CounterEnumType.P1P1)) || source.getCounters(CounterEnumType.P1P1) > 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (combat != null && ph.is(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
return doCombatAdaptLogic(source, amount, combat);
}
@@ -369,12 +365,12 @@ public class CountersPutAi extends CountersAi {
// This will "rewind" clockwork cards when they fall to 50% power or below, consider improving
if (curCtrs > Math.ceil(maxCtrs / 2.0)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
amount = Math.min(amount, maxCtrs - curCtrs);
if (amount <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -386,14 +382,14 @@ public class CountersPutAi extends CountersAi {
.mapToInt(Card::getCMC)
.max().orElse(0);
if (amount > 0 && ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
// don't use it if no counters to add
if (amount <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if ("Polukranos".equals(logic)) {
@@ -420,20 +416,14 @@ public class CountersPutAi extends CountersAi {
}
}
if (!canSurvive) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
found = true;
break;
}
if (!found) {
return false;
}
}
if ("AtOppEOT".equals(logic)) {
if (ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn().equals(ai)) {
return true;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -444,17 +434,19 @@ public class CountersPutAi extends CountersAi {
if (!ai.getGame().getStack().isEmpty() && !isSorcerySpeed(sa, ai)) {
// only evaluates case where all tokens are placed on a single target
if (sa.getMinTargets() < 2) {
if (ComputerUtilCard.canPumpAgainstRemoval(ai, sa)) {
AiAbilityDecision decision = ComputerUtilCard.canPumpAgainstRemoval(ai, sa);
if (decision.willingToPlay()) {
Card c = sa.getTargetCard();
if (sa.getTargets().size() > 1) {
sa.resetTargets();
sa.getTargets().add(c);
}
sa.addDividedAllocation(c, amount);
return true;
return decision;
} else {
if (!hasSacCost) { // for Sacrifice costs, evaluate further to see if it's worth using the ability before the card dies
return false;
if (!hasSacCost) {
// for Sacrifice costs, evaluate further to see if it's worth using the ability before the card dies
return decision;
}
}
}
@@ -498,7 +490,7 @@ public class CountersPutAi extends CountersAi {
}
if (list.size() < sa.getTargetRestrictions().getMinTargets(source, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// Activate +Loyalty planeswalker abilities even if they have no target (e.g. Vivien of the Arkbow),
@@ -507,9 +499,9 @@ public class CountersPutAi extends CountersAi {
&& sa.isPwAbility()
&& sa.getPayCosts().hasOnlySpecificCostType(CostPutCounter.class)
&& sa.isTargetNumberValid()
&& sa.getTargets().size() == 0
&& sa.getTargets().isEmpty()
&& ai.getGame().getPhaseHandler().is(PhaseType.MAIN2, ai)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (sourceName.equals("Abzan Charm")) {
@@ -531,11 +523,11 @@ public class CountersPutAi extends CountersAi {
}
}
if (left == 0) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
sa.resetTargets();
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// target loop
@@ -543,7 +535,7 @@ public class CountersPutAi extends CountersAi {
if (list.isEmpty()) {
if (!sa.isTargetNumberValid() || sa.getTargets().isEmpty()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -575,10 +567,9 @@ public class CountersPutAi extends CountersAi {
// check if other choice will already be played
increasesCharmOutcome = !choices.get(0).getTargets().isEmpty();
}
if (!source.isSpell() || increasesCharmOutcome // does not cost a card or can buff charm for no expense
if (source != null && !source.isSpell() || increasesCharmOutcome // does not cost a card or can buff charm for no expense
|| ph.getTurn() - source.getTurnInZone() >= source.getGame().getPlayers().size() * 2) {
if (abCost == null || abCost == Cost.Zero
|| (ph.is(PhaseType.END_OF_TURN) && ph.getPlayerTurn().isOpponentOf(ai))) {
if (abCost == Cost.Zero || ph.is(PhaseType.END_OF_TURN) && ph.getPlayerTurn().isOpponentOf(ai)) {
// only use at opponent EOT unless it is free
choice = chooseBoonTarget(list, type);
}
@@ -592,7 +583,7 @@ public class CountersPutAi extends CountersAi {
if (choice == null) { // can't find anything left
if (!sa.isTargetNumberValid() || sa.getTargets().isEmpty()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -608,14 +599,14 @@ public class CountersPutAi extends CountersAi {
choice = null;
}
if (sa.getTargets().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
final List<Card> cards = AbilityUtils.getDefinedCards(source, sa.getParam("Defined"), sa);
// Don't activate Curse abilities on my cards and non-curse abilities
// on my opponents
if (cards.isEmpty() || (cards.get(0).getController().isOpponentOf(ai) && !sa.isCurse())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
final int currCounters = cards.get(0).getCounters(CounterType.get(type));
@@ -623,51 +614,50 @@ public class CountersPutAi extends CountersAi {
// activating this ability.
if (!(type.equals("P1P1") || type.equals("M1M1") || type.equals("ICE")) && (MyRandom.getRandom().nextFloat() < (.1 * currCounters))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Instant +1/+1
if (type.equals("P1P1") && !isSorcerySpeed(sa, ai)) {
if (!hasSacCost && !(ph.getNextTurn() == ai && ph.is(PhaseType.END_OF_TURN) && abCost.isReusuableResource())) {
return false; // only if next turn and cost is reusable
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// Useless since the card already has the keyword (or for another reason)
if (ComputerUtil.isUselessCounter(CounterType.get(type), cards.get(0))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
boolean immediately = ComputerUtil.playImmediately(ai, sa);
if (abCost != null && !ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa, immediately)) {
return false;
if (!ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa, immediately)) {
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if (immediately) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (!type.equals("P1P1") && !type.equals("M1M1") && !sa.hasParam("ActivationPhases")) {
// Don't use non P1P1/M1M1 counters before main 2 if possible
if (ph.getPhase().isBefore(PhaseType.MAIN2) && !ComputerUtil.castSpellInMain1(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
if (ph.isPlayerTurn(ai) && !isSorcerySpeed(sa, ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
}
if (ComputerUtil.waitForBlocking(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(final SpellAbility sa, Player ai) {
boolean chance = true;
public AiAbilityDecision chkDrawback(final SpellAbility sa, Player ai) {
final Game game = ai.getGame();
Card choice = null;
final String type = sa.getParam("CounterType");
@@ -701,9 +691,9 @@ public class CountersPutAi extends CountersAi {
while (sa.canAddMoreTarget()) {
if (list.isEmpty()) {
if (!sa.isTargetNumberValid()
|| sa.getTargets().size() == 0) {
|| sa.getTargets().isEmpty()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
break;
}
@@ -724,9 +714,9 @@ public class CountersPutAi extends CountersAi {
}
if (choice == null) { // can't find anything left
if ((!sa.isTargetNumberValid()) || (sa.getTargets().size() == 0)) {
if ((!sa.isTargetNumberValid()) || (sa.getTargets().isEmpty())) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -741,11 +731,11 @@ public class CountersPutAi extends CountersAi {
}
}
return chance;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final SpellAbility root = sa.getRootAbility();
final Card source = sa.getHostCard();
final String aiLogic = sa.getParamOrDefault("AILogic", "");
@@ -770,9 +760,28 @@ public class CountersPutAi extends CountersAi {
}
if ("ChargeToBestCMC".equals(aiLogic)) {
return doChargeToCMCLogic(ai, sa) || mandatory;
AiAbilityDecision decision = doChargeToCMCLogic(ai, sa);
if (decision.willingToPlay()) {
// If the AI logic is to charge to best CMC, we can return true
// if the logic was successfully applied or if it's mandatory.
return decision;
} else if (mandatory) {
// If the logic was not applied and it's mandatory, we return false.
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
} else {
// If the logic was not applied and it's not mandatory, we return false.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("ChargeToBestOppControlledCMC".equals(aiLogic)) {
return doChargeToOppCtrlCMCLogic(ai, sa) || mandatory;
AiAbilityDecision decision = doChargeToOppCtrlCMCLogic(ai, sa);
if (decision.willingToPlay()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (mandatory) {
// If the logic was not applied and it's mandatory, we return false.
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (!sa.usesTargeting()) {
@@ -801,7 +810,7 @@ public class CountersPutAi extends CountersAi {
sa.getTargetRestrictions().getAllCandidates(sa, true, true), Player.class));
if (playerList.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// try to choose player with less creatures
@@ -817,8 +826,9 @@ public class CountersPutAi extends CountersAi {
if (type.equals("P1P1")) {
nPump = amount;
}
if (FightAi.canFightAi(ai, sa, nPump, nPump)) {
return true;
AiAbilityDecision decision = FightAi.canFightAi(ai, sa, nPump, nPump);
if (decision.willingToPlay()) {
return decision;
}
}
@@ -839,7 +849,7 @@ public class CountersPutAi extends CountersAi {
if (mandatory) {
// When things are mandatory, gotta handle a little differently
if ((list.isEmpty() || !preferred) && sa.isTargetNumberValid()) {
return true;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (list.isEmpty() && preferred) {
@@ -859,7 +869,9 @@ public class CountersPutAi extends CountersAi {
if (list.isEmpty()) {
// Not mandatory, or the the list was regenerated and is still empty,
// so return whether or not we found enough targets
return sa.isTargetNumberValid();
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
Card choice = null;
@@ -912,7 +924,7 @@ public class CountersPutAi extends CountersAi {
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
@@ -1120,7 +1132,7 @@ public class CountersPutAi extends CountersAi {
return Iterables.getFirst(options, null);
}
private boolean doMoveCounterLogic(final Player ai, SpellAbility sa, PhaseHandler ph) {
private AiAbilityDecision doMoveCounterLogic(final Player ai, SpellAbility sa, PhaseHandler ph) {
// Spikes (Tempest)
// Try not to do it unless at the end of opponent's turn or the creature is threatened
@@ -1133,7 +1145,7 @@ public class CountersPutAi extends CountersAi {
|| (combat.isBlocking(source) && ComputerUtilCombat.blockerWouldBeDestroyed(ai, source, combat) && !ComputerUtilCombat.willKillAtLeastOne(ai, source, combat))));
if (!(threatened || (ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn() == ai))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
CardCollection targets = CardLists.getTargetableCards(ai.getCreaturesInPlay(), sa);
@@ -1151,45 +1163,45 @@ public class CountersPutAi extends CountersAi {
if (bestTgt != null) {
sa.getTargets().add(bestTgt);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
private boolean doCombatAdaptLogic(Card source, int amount, Combat combat) {
private AiAbilityDecision doCombatAdaptLogic(Card source, int amount, Combat combat) {
if (combat.isAttacking(source)) {
if (!combat.isBlocked(source)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
for (Card blockedBy : combat.getBlockers(source)) {
if (blockedBy.getNetToughness() > source.getNetPower()
&& blockedBy.getNetToughness() <= source.getNetPower() + amount) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
int totBlkPower = Aggregates.sum(combat.getBlockers(source), Card::getNetPower);
if (source.getNetToughness() <= totBlkPower
&& source.getNetToughness() + amount > totBlkPower) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
}
} else if (combat.isBlocking(source)) {
for (Card blocked : combat.getAttackersBlockedBy(source)) {
if (blocked.getNetToughness() > source.getNetPower()
&& blocked.getNetToughness() <= source.getNetPower() + amount) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.ImpactCombat);
}
}
int totAtkPower = Aggregates.sum(combat.getAttackersBlockedBy(source), Card::getNetPower);
if (source.getNetToughness() <= totAtkPower
&& source.getNetToughness() + amount > totAtkPower) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
@@ -1200,7 +1212,7 @@ public class CountersPutAi extends CountersAi {
return max;
}
private boolean doChargeToCMCLogic(Player ai, SpellAbility sa) {
private AiAbilityDecision doChargeToCMCLogic(Player ai, SpellAbility sa) {
Card source = sa.getHostCard();
CardCollectionView ownLib = CardLists.filter(ai.getCardsIn(ZoneType.Library), CardPredicates.CREATURES);
int numCtrs = source.getCounters(CounterEnumType.CHARGE);
@@ -1215,10 +1227,16 @@ public class CountersPutAi extends CountersAi {
optimalCMC = cmc;
}
}
return numCtrs < optimalCMC;
if (numCtrs < optimalCMC) {
// If the AI has less counters than the optimal CMC, it should play the ability.
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// If the AI has enough counters or more than the optimal CMC, it should not play the ability.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
private boolean doChargeToOppCtrlCMCLogic(Player ai, SpellAbility sa) {
private AiAbilityDecision doChargeToOppCtrlCMCLogic(Player ai, SpellAbility sa) {
Card source = sa.getHostCard();
CardCollectionView oppInPlay = CardLists.filter(ai.getOpponents().getCardsIn(ZoneType.Battlefield), CardPredicates.NONLAND_PERMANENTS);
int numCtrs = source.getCounters(CounterEnumType.CHARGE);
@@ -1232,6 +1250,12 @@ public class CountersPutAi extends CountersAi {
optimalCMC = cmc;
}
}
return numCtrs < optimalCMC;
if (numCtrs < optimalCMC) {
// If the AI has less counters than the optimal CMC, it should play the ability.
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// If the AI has enough counters or more than the optimal CMC, it should not play the ability.
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}

View File

@@ -1,12 +1,13 @@
package forge.ai.ability;
import com.google.common.collect.Lists;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCost;
import forge.ai.SpellAbilityAi;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
import forge.game.card.CardLists;
import forge.game.cost.Cost;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
@@ -15,17 +16,15 @@ import forge.game.spellability.AbilitySub;
import forge.game.spellability.SpellAbility;
import forge.game.spellability.TargetRestrictions;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
import java.util.List;
import java.util.Map;
public class CountersPutAllAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
// AI needs to be expanded, since this function can be pretty complex
// based on what the expected targets could be
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
List<Card> hList;
List<Card> cList;
@@ -44,28 +43,9 @@ public class CountersPutAllAi extends SpellAbilityAi {
cList = CardLists.getValidCards(ai.getCardsIn(ZoneType.Battlefield), valid, source.getController(), source, sa);
}
if (abCost != null) {
// AI currently disabled for these costs
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 8, sa)) {
return false;
}
if (!ComputerUtilCost.checkDiscardCost(ai, abCost, source, sa)) {
return false;
}
if (!ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa)) {
return false;
}
}
if (logic.equals("AtEOTOrBlock")) {
if (!ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN) && !ai.getGame().getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
return false;
}
} else if (logic.equals("AtOppEOT")) {
if (!(ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN) && ai.getGame().getPhaseHandler().getNextTurn() == ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
}
@@ -88,26 +68,23 @@ public class CountersPutAllAi extends SpellAbilityAi {
amount = AbilityUtils.calculateAmount(source, amountStr, sa);
}
// prevent run-away activations - first time will always return true
boolean chance = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
if (curse) {
if (type.equals("M1M1")) {
final List<Card> killable = CardLists.filter(hList, c -> c.getNetToughness() <= amount);
if (!(killable.size() > 2)) {
return false;
if (killable.size() <= 2) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// make sure compy doesn't harm his stuff more than human's
// stuff
if (cList.size() > hList.size()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
// human has more things that will benefit, don't play
if (hList.size() >= cList.size()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
//Check for cards that could profit from the ability
@@ -125,21 +102,21 @@ public class CountersPutAllAi extends SpellAbilityAi {
}
}
if (!combatants) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
if (playReusable(ai, sa)) {
return chance;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return ((MyRandom.getRandom().nextFloat() < .6667) && chance);
return super.checkApiLogic(ai, sa);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
return canPlayAI(ai, sa);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
return canPlay(ai, sa);
}
/* (non-Javadoc)
* @see forge.card.ability.SpellAbilityAi#confirmAction(forge.game.player.Player, forge.card.spellability.SpellAbility, forge.game.player.PlayerActionConfirmMode, java.lang.String)
@@ -150,7 +127,7 @@ public class CountersPutAllAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
if (sa.usesTargeting()) {
List<Player> players = Lists.newArrayList();
if (!sa.isCurse()) {
@@ -168,11 +145,23 @@ public class CountersPutAllAi extends SpellAbilityAi {
preferred = (sa.isCurse() && p.isOpponentOf(aiPlayer)) || (!sa.isCurse() && p == aiPlayer);
sa.resetTargets();
sa.getTargets().add(p);
return preferred || mandatory;
if (preferred) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
}
return mandatory || canPlayAI(aiPlayer, sa);
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(aiPlayer, sa);
}
}

View File

@@ -18,9 +18,7 @@
package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.ability.AbilityUtils;
import forge.game.card.*;
@@ -52,9 +50,13 @@ public class CountersPutOrRemoveAi extends SpellAbilityAi {
* forge.game.spellability.SpellAbility)
*/
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
if (sa.usesTargeting()) {
return doTgt(ai, sa, false);
if (doTgt(ai, sa, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
return super.checkApiLogic(ai, sa);
}
@@ -180,11 +182,27 @@ public class CountersPutOrRemoveAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (sa.usesTargeting()) {
return doTgt(ai, sa, mandatory);
if (doTgt(ai, sa, mandatory)) {
// if we can target, then we can play it
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
// if we can't target, then we can't play it
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (mandatory) {
// if mandatory, just play it
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
// if not mandatory, check if we can play it
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return mandatory;
}
/*

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import com.google.common.collect.Iterables;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilCost;
@@ -23,14 +25,6 @@ import java.util.function.Predicate;
public class CountersRemoveAi extends SpellAbilityAi {
@Override
protected boolean canPlayWithoutRestrict(final Player ai, final SpellAbility sa) {
if ("Always".equals(sa.getParam("AILogic"))) {
return true;
}
return super.canPlayWithoutRestrict(ai, sa);
}
/*
* (non-Javadoc)
*
@@ -48,24 +42,6 @@ public class CountersRemoveAi extends SpellAbilityAi {
return super.checkPhaseRestrictions(ai, sa, ph);
}
/*
* (non-Javadoc)
*
* @see
* forge.ai.SpellAbilityAi#checkPhaseRestrictions(forge.game.player.Player,
* forge.game.spellability.SpellAbility, forge.game.phase.PhaseHandler,
* java.lang.String)
*/
@Override
protected boolean checkPhaseRestrictions(Player ai, SpellAbility sa, PhaseHandler ph, String logic) {
if ("EndOfOpponentsTurn".equals(logic)) {
if (!ph.is(PhaseType.END_OF_TURN) || !ph.getNextTurn().equals(ai)) {
return false;
}
}
return super.checkPhaseRestrictions(ai, sa, ph, logic);
}
/*
* (non-Javadoc)
*
@@ -73,7 +49,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
* forge.game.spellability.SpellAbility)
*/
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final String type = sa.getParam("CounterType");
if (sa.usesTargeting()) {
@@ -83,14 +59,14 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!type.matches("Any") && !type.matches("All")) {
final int currCounters = sa.getHostCard().getCounters(CounterType.getType(type));
if (currCounters < 1) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
return super.checkApiLogic(ai, sa);
}
private boolean doTgt(Player ai, SpellAbility sa, boolean mandatory) {
private AiAbilityDecision doTgt(Player ai, SpellAbility sa, boolean mandatory) {
final Card source = sa.getHostCard();
final Game game = ai.getGame();
@@ -103,7 +79,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
CardCollection list = CardLists.getTargetableCards(game.getCardsIn(tgt.getZone()), sa);
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// Filter AI-specific targets if provided
@@ -121,7 +97,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
CardPredicates.hasCounter(CounterEnumType.ICE, 3));
if (!depthsList.isEmpty()) {
sa.getTargets().add(depthsList.getFirst());
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -134,7 +110,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!planeswalkerList.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestPlaneswalkerAI(planeswalkerList));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else if (type.matches("Any")) {
// variable amount for Hex Parasite
@@ -144,7 +120,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
final int manaLeft = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
if (manaLeft == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
amount = manaLeft;
xPay = true;
@@ -166,7 +142,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (xPay) {
sa.setXManaCostPaid(ice);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
@@ -185,7 +161,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (xPay) {
sa.setXManaCostPaid(best.getCurrentLoyalty());
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// some rules only for amount = 1
@@ -202,7 +178,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!aiM1M1List.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(aiM1M1List));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// do as P1P1 part
@@ -211,7 +187,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!aiUndyingList.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(aiUndyingList));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// TODO stun counters with canRemoveCounters check
@@ -222,7 +198,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
CardPredicates.hasCounter(CounterEnumType.P1P1));
if (!oppP1P1List.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(oppP1P1List));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// fallback to remove any counter from opponent
@@ -234,7 +210,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
for (final CounterType aType : best.getCounters().keySet()) {
if (!ComputerUtil.isNegativeCounter(aType, best)) {
sa.getTargets().add(best);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
@@ -255,7 +231,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!aiList.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(aiList));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else if (type.equals("P1P1")) {
// no special amount for that one yet
@@ -273,7 +249,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
}
if (!aiList.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(aiList));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -287,7 +263,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!oppList.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getWorstCreatureAI(oppList));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
} else if (type.equals("TIME")) {
@@ -298,7 +274,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
final int manaLeft = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
if (manaLeft == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
amount = manaLeft;
xPay = true;
@@ -316,7 +292,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (xPay) {
sa.setXManaCostPaid(timeCount);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
if (mandatory) {
@@ -325,7 +301,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
CardCollection adaptCreats = CardLists.filter(list, CardPredicates.hasKeyword(Keyword.ADAPT));
if (!adaptCreats.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getWorstAI(adaptCreats));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// Outlast nice target
@@ -336,26 +312,27 @@ public class CountersRemoveAi extends SpellAbilityAi {
if (!betterTargets.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getWorstAI(betterTargets));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
sa.getTargets().add(ComputerUtilCard.getWorstAI(outlastCreats));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
sa.getTargets().add(ComputerUtilCard.getWorstAI(list));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (sa.usesTargeting()) {
return doTgt(aiPlayer, sa, mandatory);
}
return mandatory;
return mandatory ? new AiAbilityDecision(100, AiPlayDecision.MandatoryPlay)
: new AiAbilityDecision(0, AiPlayDecision.CantPlaySa);
}
/*
@@ -369,8 +346,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
GameEntity target = (GameEntity) params.get("Target");
CounterType type = (CounterType) params.get("CounterType");
if (target instanceof Card) {
Card targetCard = (Card) target;
if (target instanceof Card targetCard) {
if (targetCard.getController().isOpponentOf(player)) {
return !ComputerUtil.isNegativeCounter(type, targetCard) ? max : min;
} else {
@@ -381,8 +357,7 @@ public class CountersRemoveAi extends SpellAbilityAi {
return ComputerUtil.isNegativeCounter(type, targetCard) ? max : min;
}
} else if (target instanceof Player) {
Player targetPlayer = (Player) target;
} else if (target instanceof Player targetPlayer) {
if (targetPlayer.isOpponentOf(player)) {
return !type.is(CounterEnumType.POISON) ? max : min;
} else {

View File

@@ -11,32 +11,27 @@ import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
import java.util.function.Predicate;
public class DamageAllAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
// AI needs to be expanded, since this function can be pretty complex
// based on what the expected targets could be
final Card source = sa.getHostCard();
// prevent run-away activations - first time will always return true
if (MyRandom.getRandom().nextFloat() > Math.pow(.9, sa.getActivationsThisTurn())) {
return false;
}
// abCost stuff that should probably be centralized...
final Cost abCost = sa.getPayCosts();
if (abCost != null) {
// AI currently disabled for some costs
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
}
// wait until stack is empty (prevents duplicate kills)
if (!ai.getGame().getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.StackNotEmpty);
}
int x = -1;
@@ -51,11 +46,15 @@ public class DamageAllAi extends SpellAbilityAi {
if (x == -1) {
if (determineOppToKill(ai, sa, source, dmg) != null) {
// we already know we can kill a player, so go for it
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// look for other value in this (damaging creatures or
// creatures + player, e.g. Pestilence, etc.)
return evaluateDamageAll(ai, sa, source, dmg) > 0;
if (evaluateDamageAll(ai, sa, source, dmg) > 0) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
int best = -1, best_x = -1;
Player bestOpp = determineOppToKill(ai, sa, source, x);
@@ -81,9 +80,9 @@ public class DamageAllAi extends SpellAbilityAi {
if (sa.getSVar(damage).equals("Count$xPaid")) {
sa.setXManaCostPaid(best_x);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -185,7 +184,7 @@ public class DamageAllAi extends SpellAbilityAi {
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
final Card source = sa.getHostCard();
final String validP = sa.getParamOrDefault("ValidPlayers", "");
@@ -211,21 +210,21 @@ public class DamageAllAi extends SpellAbilityAi {
}
// Don't get yourself killed
if (validP.equals("Player") && (ai.getLife() <= ComputerUtilCombat.predictDamageTo(ai, dmg, source, false))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// if we can kill human, do it
if ((validP.equals("Player") || validP.equals("Opponent") || validP.contains("Targeted"))
&& (enemy.getLife() <= ComputerUtilCombat.predictDamageTo(enemy, dmg, source, false))) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (!computerList.isEmpty() && ComputerUtilCard.evaluateCreatureList(computerList) > ComputerUtilCard
.evaluateCreatureList(humanList)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/**
@@ -258,7 +257,7 @@ public class DamageAllAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Card source = sa.getHostCard();
final String validP = sa.getParamOrDefault("ValidPlayers", "");
@@ -287,24 +286,24 @@ public class DamageAllAi extends SpellAbilityAi {
// If it's not mandatory check a few things
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// Don't get yourself killed
if (validP.equals("Player") && (ai.getLife() <= ComputerUtilCombat.predictDamageTo(ai, dmg, source, false))) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// if we can kill human, do it
if ((validP.equals("Player") || validP.contains("Opponent") || validP.contains("Targeted"))
&& (enemy.getLife() <= ComputerUtilCombat.predictDamageTo(enemy, dmg, source, false))) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (!computerList.isEmpty() && ComputerUtilCard.evaluateCreatureList(computerList) + 50 >= ComputerUtilCard
.evaluateCreatureList(humanList)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -38,7 +38,7 @@ import java.util.Map;
public class DamageDealAi extends DamageAiBase {
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
final SpellAbility root = sa.getRootAbility();
final String damage = sa.getParam("NumDmg");
Card source = sa.getHostCard();
@@ -65,15 +65,19 @@ public class DamageDealAi extends DamageAiBase {
continue; // in case the calculation gets messed up somewhere
}
root.setSVar("EnergyToPay", "Number$" + dmg);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.getSVar(damage).equals("Count$xPaid")) {
// Life Drain
if ("XLifeDrain".equals(logic)) {
return doXLifeDrainLogic(ai, sa);
if (doXLifeDrainLogic(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// Set PayX here to maximum value.
@@ -83,11 +87,15 @@ public class DamageDealAi extends DamageAiBase {
dmg--; // the card will be spent casting the spell, so actual damage is 1 less
}
}
return damageTargetAI(ai, sa, dmg, true);
if (damageTargetAI(ai, sa, dmg, true)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
final String sourceName = ComputerUtilAbility.getAbilitySourceName(sa);
@@ -108,7 +116,7 @@ public class DamageDealAi extends DamageAiBase {
boolean inDanger = ComputerUtil.aiLifeInDanger(ai, false, 0);
boolean isLethal = sa.usesTargeting() && sa.getTargetRestrictions().canTgtPlayer() && dmg >= ai.getWeakestOpponent().getLife() && !ai.getWeakestOpponent().cantLoseForZeroOrLessLife();
if (dmg < threshold && ai.getGame().getPhaseHandler().getTurn() / 2 < threshold && !inDanger && !isLethal) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -134,10 +142,10 @@ public class DamageDealAi extends DamageAiBase {
if (shouldTgtP(ai, sa, maxDmg, false)) {
sa.resetTargets();
sa.getTargets().add(maxDamaged);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
}
@@ -154,7 +162,7 @@ public class DamageDealAi extends DamageAiBase {
if (ai.getGame().getPhaseHandler().isPlayerTurn(ai) && ai.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
for (Card potentialAtkr : ai.getCreaturesInPlay()) {
if (ComputerUtilCard.doesCreatureAttackAI(ai, potentialAtkr)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -175,16 +183,24 @@ public class DamageDealAi extends DamageAiBase {
* Mostly used to ping the player with remaining counters. The issue with
* stacked effects might appear here.
*/
return damageTargetAI(ai, sa, n, true);
if (damageTargetAI(ai, sa, n, true)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
/*
* Only ping when stack is clear to avoid hassle of evaluating stacked effects
* like protection/pumps or over-killing target.
*/
return ai.getGame().getStack().isEmpty() && damageTargetAI(ai, sa, n, false);
if (ai.getGame().getStack().isEmpty() && damageTargetAI(ai, sa, n, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.StackNotEmpty);
}
}
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if ("NinThePainArtist".equals(logic)) {
// Make sure not to mana lock ourselves + make the opponent draw cards into an immediate discard
@@ -193,11 +209,15 @@ public class DamageDealAi extends DamageAiBase {
if (doTarget) {
Card tgt = sa.getTargetCard();
if (tgt != null) {
return ai.getGame().getPhaseHandler().getPlayerTurn() == tgt.getController();
if (ai.getGame().getPhaseHandler().getPlayerTurn() == tgt.getController()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.WaitForEndOfTurn);
}
}
}
return false;
}
return new AiAbilityDecision(0, AiPlayDecision.WaitForEndOfTurn);
}
if (sourceName.equals("Sorin, Grim Nemesis")) {
@@ -209,35 +229,35 @@ public class DamageDealAi extends DamageAiBase {
continue; // in case the calculation gets messed up somewhere
}
sa.setXManaCostPaid(dmg);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (dmg <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// temporarily disabled until better AI
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if (!ComputerUtilCost.checkSacrificeCost(ai, abCost, source, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if (!ComputerUtilCost.checkRemoveCounterCost(abCost, source, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if ("DiscardLands".equals(sa.getParam("AILogic")) && !ComputerUtilCost.checkDiscardCost(ai, abCost, source, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Try to chain damage/debuff effects
@@ -248,13 +268,13 @@ public class DamageDealAi extends DamageAiBase {
int extraDmg = chainDmg.getValue();
boolean willTargetIfChained = damageTargetAI(ai, sa, dmg + extraDmg, false);
if (!willTargetIfChained) {
return false; // won't play it even in chain
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed); // won't play it even in chain
} else if (willTargetIfChained && chainDmg.getKey().getApi() == ApiType.Pump && sa.getTargets().isTargetingAnyPlayer()) {
// we're trying to chain a pump spell to a damage spell targeting a player, that won't work
// so run an additional check to ensure that we want to cast the current spell separately
sa.resetTargets();
if (!damageTargetAI(ai, sa, dmg, false)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
// we are about to decide to play this damage spell; if there's something chained to it, reserve mana for
@@ -264,7 +284,7 @@ public class DamageDealAi extends DamageAiBase {
}
} else if (!damageTargetAI(ai, sa, dmg, false)) {
// simple targeting when there is no spell chaining plan
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if ((damage.equals("X") && sa.getSVar(damage).equals("Count$xPaid")) ||
@@ -288,10 +308,12 @@ public class DamageDealAi extends DamageAiBase {
if ("DiscardCMCX".equals(sa.getParam("AILogic"))) {
final int cmc = sa.getXManaCostPaid();
return ai.getZone(ZoneType.Hand).contains(CardPredicates.hasCMC(cmc));
if (!ai.getZone(ZoneType.Hand).contains(CardPredicates.hasCMC(cmc))) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/**
@@ -932,14 +954,14 @@ public class DamageDealAi extends DamageAiBase {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Card source = sa.getHostCard();
final String damage = sa.getParam("NumDmg");
int dmg = calculateDamageAmount(sa, source, damage);
// Remove all damage
if (sa.hasParam("Remove")) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (damage.equals("X") && sa.getSVar(damage).equals("Count$xPaid")) {
@@ -950,10 +972,18 @@ public class DamageDealAi extends DamageAiBase {
if (!sa.usesTargeting()) {
// If it's not mandatory check a few things
return mandatory || damageChooseNontargeted(ai, sa, dmg);
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (damageChooseNontargeted(ai, sa, dmg)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
if (!damageChoosingTargets(ai, sa, sa.getTargetRestrictions(), dmg, mandatory, true) && !mandatory) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (damage.equals("X") && sa.getSVar(damage).equals("Count$xPaid") && !sa.isDividedAsYouChoose()) {
@@ -976,7 +1006,7 @@ public class DamageDealAi extends DamageAiBase {
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private static int calculateDamageAmount(SpellAbility sa, Card source, String damage) {

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpecialCardAi;
import forge.game.ability.AbilityUtils;
import forge.game.player.Player;
@@ -14,7 +16,7 @@ public class DamageEachAi extends DamageAiBase {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
final String logic = sa.getParam("AILogic");
PlayerCollection targetableOpps = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
@@ -22,30 +24,41 @@ public class DamageEachAi extends DamageAiBase {
if (sa.usesTargeting() && weakestOpp != null) {
if ("MadSarkhanUltimate".equals(logic) && !SpecialCardAi.SarkhanTheMad.considerUltimate(ai, sa, weakestOpp)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.resetTargets();
if (weakestOpp.canLoseLife() && !weakestOpp.cantLoseForZeroOrLessLife()) {
sa.getTargets().add(weakestOpp);
return weakestOpp.canLoseLife() && !weakestOpp.cantLoseForZeroOrLessLife();
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
final String damage = sa.getParam("NumDmg");
final int iDmg = AbilityUtils.calculateAmount(sa.getHostCard(), damage, sa);
return shouldTgtP(ai, sa, iDmg, false);
if (shouldTgtP(ai, sa, iDmg, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
// check AI life before playing this drawback?
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#doTriggerAINoCost(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility, boolean)
*/
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
return mandatory || canPlayAI(ai, sa);
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(ai, sa);
}
}

View File

@@ -1,15 +1,11 @@
package forge.ai.ability;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilCombat;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.GameObject;
import forge.game.ability.AbilityUtils;
import forge.game.card.*;
import forge.game.combat.Combat;
import forge.game.cost.Cost;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
@@ -24,18 +20,12 @@ import java.util.List;
public class DamagePreventAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Card hostCard = sa.getHostCard();
final Game game = ai.getGame();
final Combat combat = game.getCombat();
boolean chance = false;
final Cost cost = sa.getPayCosts();
if (!willPayCosts(ai, sa, cost, hostCard)) {
return false;
}
final TargetRestrictions tgt = sa.getTargetRestrictions();
if (tgt == null) {
// As far as I can tell these Defined Cards will only have one of them
@@ -70,7 +60,7 @@ public class DamagePreventAi extends SpellAbilityAi {
chance = flag;
} else { // if nothing on the stack, and it's not declare
// blockers. no need to prevent
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} // non-targeted
@@ -120,7 +110,7 @@ public class DamagePreventAi extends SpellAbilityAi {
targetables = CardLists.getTargetableCards(targetables, sa);
if (targetables.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
final CardCollection combatants = CardLists.filter(targetables, CardPredicates.CREATURES);
ComputerUtilCard.sortByEvaluateCreature(combatants);
@@ -137,11 +127,15 @@ public class DamagePreventAi extends SpellAbilityAi {
sa.addDividedAllocation(sa.getTargets().get(0), AbilityUtils.calculateAmount(hostCard, sa.getParam("Amount"), sa));
}
return chance;
if (chance) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
boolean chance = false;
final TargetRestrictions tgt = sa.getTargetRestrictions();
if (tgt == null) {
@@ -151,7 +145,11 @@ public class DamagePreventAi extends SpellAbilityAi {
chance = preventDamageMandatoryTarget(ai, sa, mandatory);
}
return chance;
if (chance) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.StopRunawayActivations);
}
}
/**

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
@@ -11,24 +13,34 @@ import java.util.Map;
public class DayTimeAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
PhaseHandler ph = aiPlayer.getGame().getPhaseHandler();
if ((sa.getHostCard().isCreature() && sa.getPayCosts().hasTapCost()) || sa.getPayCosts().hasManaCost()) {
// If it involves a cost that may put us at a disadvantage, better activate before own turn if possible
if (!isSorcerySpeed(sa, aiPlayer)) {
return ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn() == aiPlayer;
if (ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn() == aiPlayer) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return ph.is(PhaseType.MAIN2, aiPlayer); // Give other things a chance to be cast (e.g. Celestus)
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
} else {
if (ph.is(PhaseType.MAIN2, aiPlayer)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return true; // TODO: more logic if it's ever a bad idea to trigger this (when non-mandatory)
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override

View File

@@ -1,10 +1,7 @@
package forge.ai.ability;
import com.google.common.collect.Lists;
import forge.ai.AiAttackController;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilCost;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
@@ -26,27 +23,27 @@ import java.util.List;
public class DebuffAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision canPlay(final Player ai, final SpellAbility sa) {
// if there is no target and host card isn't in play, don't activate
final Card source = sa.getHostCard();
final Game game = ai.getGame();
if (!sa.usesTargeting() && !source.isInPlay()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final Cost cost = sa.getPayCosts();
// temporarily disabled until AI is improved
if (!ComputerUtilCost.checkCreatureSacrificeCost(ai, cost, source, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if (!ComputerUtilCost.checkLifeCost(ai, cost, source, 40, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
if (!ComputerUtilCost.checkRemoveCounterCost(cost, source, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAfford);
}
final PhaseHandler ph = game.getPhaseHandler();
@@ -58,7 +55,7 @@ public class DebuffAi extends SpellAbilityAi {
// Instant-speed pumps should not be cast outside of combat when the
// stack is empty, unless there are specific activation phase requirements
if (!isSorcerySpeed(sa, ai) && !sa.hasParam("ActivationPhases")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.AnotherTime);
}
}
@@ -66,7 +63,7 @@ public class DebuffAi extends SpellAbilityAi {
List<Card> cards = AbilityUtils.getDefinedCards(source, sa.getParam("Defined"), sa);
final Combat combat = game.getCombat();
return cards.stream().anyMatch(c -> {
if (cards.stream().anyMatch(c -> {
if (c.getController().equals(sa.getActivatingPlayer()) || combat == null)
return false;
@@ -75,21 +72,34 @@ public class DebuffAi extends SpellAbilityAi {
}
// don't add duplicate negative keywords
return sa.hasParam("Keywords") && c.hasAnyKeyword(Arrays.asList(sa.getParam("Keywords").split(" & ")));
});
})) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return debuffTgtAI(ai, sa, sa.hasParam("Keywords") ? Arrays.asList(sa.getParam("Keywords").split(" & ")) : null, false);
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
if (debuffTgtAI(ai, sa, sa.hasParam("Keywords") ? Arrays.asList(sa.getParam("Keywords").split(" & ")) : null, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
if (!sa.usesTargeting()) {
// TODO - copied from AF_Pump.pumpDrawbackAI() - what should be here?
} else {
return debuffTgtAI(ai, sa, sa.hasParam("Keywords") ? Arrays.asList(sa.getParam("Keywords").split(" & ")) : null, false);
if (debuffTgtAI(ai, sa, sa.hasParam("Keywords") ? Arrays.asList(sa.getParam("Keywords").split(" & ")) : null, false)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} // debuffDrawbackAI()
/**
@@ -234,18 +244,24 @@ public class DebuffAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final List<String> kws = sa.hasParam("Keywords") ? Arrays.asList(sa.getParam("Keywords").split(" & ")) : new ArrayList<>();
if (!sa.usesTargeting()) {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
return debuffTgtAI(ai, sa, kws, mandatory);
if (debuffTgtAI(ai, sa, kws, mandatory)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -15,43 +15,56 @@ import forge.game.zone.ZoneType;
public class DelayedTriggerAi extends SpellAbilityAi {
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
if ("Always".equals(sa.getParam("AILogic"))) {
// TODO: improve ai
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
SpellAbility trigsa = sa.getAdditionalAbility("Execute");
if (trigsa == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
trigsa.setActivatingPlayer(ai);
if (trigsa instanceof AbilitySub) {
return SpellApiToAi.Converter.get(trigsa).chkDrawbackWithSubs(ai, (AbilitySub)trigsa);
} else {
return AiPlayDecision.WillPlay == ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
AiPlayDecision decision = ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
if (decision == AiPlayDecision.WillPlay) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
SpellAbility trigsa = sa.getAdditionalAbility("Execute");
if (trigsa == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
AiController aic = ((PlayerControllerAi)ai.getController()).getAi();
trigsa.setActivatingPlayer(ai);
if (!sa.hasParam("OptionalDecider")) {
return aic.doTrigger(trigsa, true);
if (aic.doTrigger(trigsa, true)) {
// If the trigger is mandatory, we can play it
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return aic.doTrigger(trigsa, !sa.getParam("OptionalDecider").equals("You"));
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
if (aic.doTrigger(trigsa, !sa.getParam("OptionalDecider").equals("You"))) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
// Card-specific logic
String logic = sa.getParamOrDefault("AILogic", "");
if (logic.equals("SpellCopy")) {
@@ -90,9 +103,9 @@ public class DelayedTriggerAi extends SpellAbilityAi {
});
if (count == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (logic.equals("NarsetRebound")) {
// should be done in Main2, but it might broke for other cards
//if (phase.getPhase().isBefore(PhaseType.MAIN2)) {
@@ -125,10 +138,10 @@ public class DelayedTriggerAi extends SpellAbilityAi {
});
if (count == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (logic.equals("SaveCreature")) {
CardCollection ownCreatures = ai.getCreaturesInPlay();
@@ -142,19 +155,25 @@ public class DelayedTriggerAi extends SpellAbilityAi {
if (!ownCreatures.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestAI(ownCreatures));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// Generic logic
SpellAbility trigsa = sa.getAdditionalAbility("Execute");
if (trigsa == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
trigsa.setActivatingPlayer(ai);
return AiPlayDecision.WillPlay == ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
AiPlayDecision decision = ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
if (decision == AiPlayDecision.WillPlay) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}

View File

@@ -20,7 +20,7 @@ import forge.util.collect.FCollectionView;
public class DestroyAi extends SpellAbilityAi {
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
return checkApiLogic(ai, sa);
}
@@ -103,17 +103,13 @@ public class DestroyAi extends SpellAbilityAi {
}
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
final boolean noRegen = sa.hasParam("NoRegen");
final String logic = sa.getParam("AILogic");
CardCollection list;
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
// Targeting
if (sa.usesTargeting()) {
// If there's X in payment costs and it's tied to targeting, make sure we set the XManaCostPaid first
@@ -125,7 +121,7 @@ public class DestroyAi extends SpellAbilityAi {
// Assume there where already enough targets chosen by AI Logic Above
if (sa.hasParam("AILogic") && !sa.canAddMoreTarget() && sa.isTargetNumberValid()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// reset targets before AI Logic part
@@ -145,23 +141,22 @@ public class DestroyAi extends SpellAbilityAi {
if (maxTargets == 0) {
// can't afford X or otherwise target anything
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantAffordX);
}
if (sa.hasParam("TargetingPlayer")) {
Player targetingPlayer = AbilityUtils.getDefinedPlayers(source, sa.getParam("TargetingPlayer"), sa).get(0);
sa.setTargetingPlayer(targetingPlayer);
return targetingPlayer.getController().chooseTargetsFor(sa);
if (targetingPlayer.getController().chooseTargetsFor(sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
// AI doesn't destroy own cards if it isn't defined in AI logic
list = CardLists.getTargetableCards(ai.getOpponents().getCardsIn(ZoneType.Battlefield), sa);
if ("FatalPush".equals(logic)) {
final int cmcMax = ai.hasRevolt() ? 4 : 2;
list = CardLists.filter(list, CardPredicates.lessCMC(cmcMax));
}
// Filter AI-specific targets if provided
list = ComputerUtil.filterAITgts(sa, ai, list, true);
list = CardLists.getNotKeyword(list, Keyword.INDESTRUCTIBLE);
@@ -206,7 +201,7 @@ public class DestroyAi extends SpellAbilityAi {
// Try to avoid targeting creatures that are dead on board
list = ComputerUtil.filterCreaturesThatWillDieThisTurn(ai, list, sa);
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
// target loop
@@ -221,7 +216,7 @@ public class DestroyAi extends SpellAbilityAi {
if (list.isEmpty()) {
if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -235,7 +230,7 @@ public class DestroyAi extends SpellAbilityAi {
if ("OppDestroyYours".equals(logic)) {
Card aiBest = ComputerUtilCard.getBestCreatureAI(ai.getCreaturesInPlay());
if (ComputerUtilCard.evaluateCreature(aiBest) > ComputerUtilCard.evaluateCreature(choice) - 40) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else if (CardLists.getNotType(list, "Land").isEmpty()) {
@@ -244,7 +239,7 @@ public class DestroyAi extends SpellAbilityAi {
if ("LandForLand".equals(logic) || "GhostQuarter".equals(logic)) {
// Strip Mine, Wasteland - cut short if the relevant logic fails
if (!doLandForLandRemovalLogic(sa, ai, choice, logic)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
@@ -254,14 +249,14 @@ public class DestroyAi extends SpellAbilityAi {
//option to hold removal instead only applies for single targeted removal
if (!sa.isTrigger() && sa.getMaxTargets() == 1) {
if (choice == null || !ComputerUtilCard.useRemovalNow(sa, choice, 0, ZoneType.Graveyard)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
if (choice == null) { // can't find anything left
if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
// TODO is this good enough? for up to amounts?
break;
@@ -298,22 +293,22 @@ public class DestroyAi extends SpellAbilityAi {
|| !source.getGame().getPhaseHandler().isPlayerTurn(ai)
|| ai.getLife() <= 5)) {
// Basic ai logic for Lethal Vapors
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if ("Always".equals(logic)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (list.isEmpty()
|| !CardLists.filterControlledBy(list, ai).isEmpty()
|| CardLists.getNotKeyword(list, Keyword.INDESTRUCTIBLE).isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final boolean noRegen = sa.hasParam("NoRegen");
if (sa.usesTargeting()) {
sa.resetTargets();
@@ -321,7 +316,7 @@ public class DestroyAi extends SpellAbilityAi {
CardCollection list = CardLists.getTargetableCards(ai.getGame().getCardsIn(ZoneType.Battlefield), sa);
if (list.isEmpty() || list.size() < sa.getMinTargets()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Try to avoid targeting creatures that are dead on board
@@ -349,7 +344,7 @@ public class DestroyAi extends SpellAbilityAi {
list.removeAll(preferred);
if (preferred.isEmpty() && !mandatory) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
while (sa.canAddMoreTarget()) {
@@ -357,12 +352,12 @@ public class DestroyAi extends SpellAbilityAi {
if (!sa.isMinTargetChosen()) {
if (!mandatory) {
sa.resetTargets();
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
} else {
break;
}
} else {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
Card c = ComputerUtilCard.getBestAI(preferred);
@@ -397,9 +392,18 @@ public class DestroyAi extends SpellAbilityAi {
}
}
return sa.isTargetNumberValid();
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return mandatory;
sa.resetTargets();
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
} else {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}

View File

@@ -23,38 +23,23 @@ public class DestroyAllAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#doTriggerAINoCost(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility, boolean)
*/
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return doMassRemovalLogic(ai, sa);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
return doMassRemovalLogic(aiPlayer, sa);
}
@Override
protected boolean canPlayAI(final Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, SpellAbility sa) {
// AI needs to be expanded, since this function can be pretty complex
// based on what the expected targets could be
final Cost abCost = sa.getPayCosts();
final Card source = sa.getHostCard();
if (abCost != null) {
// AI currently disabled for some costs
if (!ComputerUtilCost.checkLifeCost(ai, abCost, source, 4, sa)) {
return false;
}
}
// prevent run-away activations - first time will always return true
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
final String aiLogic = sa.getParamOrDefault("AILogic", "");
if ("FellTheMighty".equals(aiLogic)) {
@@ -64,7 +49,7 @@ public class DestroyAllAi extends SpellAbilityAi {
return doMassRemovalLogic(ai, sa);
}
public static boolean doMassRemovalLogic(Player ai, SpellAbility sa) {
public static AiAbilityDecision doMassRemovalLogic(Player ai, SpellAbility sa) {
final Card source = sa.getHostCard();
final String logic = sa.getParamOrDefault("AILogic", "");
@@ -72,7 +57,7 @@ public class DestroyAllAi extends SpellAbilityAi {
final int CREATURE_EVAL_THRESHOLD = 200 / (!sa.usesTargeting() ? ai.getOpponents().size() : 1);
if (logic.equals("Always")) {
return true; // e.g. Tetzimoc, Primal Death, where we want to cast the permanent even if the removal trigger does nothing
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
String valid = sa.getParamOrDefault("ValidCards", "");
@@ -92,7 +77,7 @@ public class DestroyAllAi extends SpellAbilityAi {
opplist = CardLists.filter(opplist, predicate);
ailist = CardLists.filter(ailist, predicate);
if (opplist.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.usesTargeting()) {
@@ -101,7 +86,7 @@ public class DestroyAllAi extends SpellAbilityAi {
sa.getTargets().add(opponent);
ailist.clear();
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -110,30 +95,35 @@ public class DestroyAllAi extends SpellAbilityAi {
int numAiCanSave = Math.min(CardLists.count(ai.getCreaturesInPlay(), CardPredicates.isColor(MagicColor.WHITE).and(CardPredicates.UNTAPPED)) * 2, ailist.size());
int numOppsCanSave = Math.min(CardLists.count(ai.getOpponents().getCreaturesInPlay(), CardPredicates.isColor(MagicColor.WHITE).and(CardPredicates.UNTAPPED)) * 2, opplist.size());
return numOppsCanSave < opplist.size() && (ailist.size() - numAiCanSave < opplist.size() - numOppsCanSave);
if (numOppsCanSave < opplist.size() && (ailist.size() - numAiCanSave < opplist.size() - numOppsCanSave)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (numAiCanSave < ailist.size() && (opplist.size() - numOppsCanSave < ailist.size() - numAiCanSave)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// If effect is destroying creatures and AI is about to lose, activate effect anyway no matter what!
if ((!CardLists.getType(opplist, "Creature").isEmpty()) && (ai.getGame().getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS))
&& (ai.getGame().getCombat() != null && ComputerUtilCombat.lifeInSeriousDanger(ai, ai.getGame().getCombat()))) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// If effect is destroying creatures and AI is about to get low on life, activate effect anyway if difference in lost permanents not very much
if ((!CardLists.getType(opplist, "Creature").isEmpty()) && (ai.getGame().getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS))
&& (ai.getGame().getCombat() != null && ComputerUtilCombat.lifeInDanger(ai, ai.getGame().getCombat()))
&& ((ComputerUtilCard.evaluatePermanentList(ailist) - 6) >= ComputerUtilCard.evaluatePermanentList(opplist))) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// if only creatures are affected evaluate both lists and pass only if human creatures are more valuable
if (CardLists.getNotType(opplist, "Creature").isEmpty() && CardLists.getNotType(ailist, "Creature").isEmpty()) {
if (ComputerUtilCard.evaluateCreatureList(ailist) + CREATURE_EVAL_THRESHOLD < ComputerUtilCard.evaluateCreatureList(opplist)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (ai.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.MAIN2)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForMain2);
}
// test whether the human can kill the ai next turn
@@ -146,39 +136,42 @@ public class DestroyAllAi extends SpellAbilityAi {
}
}
if (!containsAttacker) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
AiBlockController block = new AiBlockController(ai, false);
block.assignBlockersForCombat(combat);
if (ComputerUtilCombat.lifeInSeriousDanger(ai, combat)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} // only lands involved
else if (CardLists.getNotType(opplist, "Land").isEmpty() && CardLists.getNotType(ailist, "Land").isEmpty()) {
if (ai.isCardInPlay("Crucible of Worlds") && !opponent.isCardInPlay("Crucible of Worlds")) {
return true;
// TODO Should care about any land recursion, not just Crucible of Worlds
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// evaluate the situation with creatures on the battlefield separately, as that's where the AI typically makes mistakes
CardCollection aiCreatures = ai.getCreaturesInPlay();
CardCollection oppCreatures = opponent.getCreaturesInPlay();
if (!oppCreatures.isEmpty()) {
if (ComputerUtilCard.evaluateCreatureList(aiCreatures) < ComputerUtilCard.evaluateCreatureList(oppCreatures) + CREATURE_EVAL_THRESHOLD) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// check if the AI would lose more lands than the opponent would
if (ComputerUtilCard.evaluatePermanentList(ailist) > ComputerUtilCard.evaluatePermanentList(opplist) + 1) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} // otherwise evaluate both lists by CMC and pass only if human permanents are more valuable
else if ((ComputerUtilCard.evaluatePermanentList(ailist) + 3) >= ComputerUtilCard.evaluatePermanentList(opplist)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}

View File

@@ -0,0 +1,119 @@
package forge.ai.ability;
import java.util.List;
import java.util.function.Predicate;
import forge.ai.AiAttackController;
import forge.ai.ComputerUtil;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.Game;
import forge.game.card.Card;
import forge.game.card.CardCollection;
import forge.game.card.CardLists;
import forge.game.card.CardPredicates;
import forge.game.combat.CombatUtil;
import forge.game.phase.PhaseHandler;
import forge.game.phase.PhaseType;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.game.zone.ZoneType;
public class DetainAi extends SpellAbilityAi {
Predicate<Card> CREATURE_OR_TAP_ABILITY = c -> {
if (c.isCreature()) {
return true;
}
for (final SpellAbility sa : c.getSpellAbilities()) {
if (sa.isAbility() && sa.getPayCosts().hasTapCost()) {
return true;
}
}
return false;
};
protected boolean prefTargeting(final Player ai, final Card source, final SpellAbility sa, final boolean mandatory) {
final Game game = ai.getGame();
CardCollection list = CardLists.getTargetableCards(ai.getOpponents().getCardsIn(ZoneType.Battlefield), sa);
list = CardLists.filter(list, CREATURE_OR_TAP_ABILITY);
// Filter AI-specific targets if provided
list = ComputerUtil.filterAITgts(sa, ai, list, true);
if (list.isEmpty()) {
return false;
}
while (sa.canAddMoreTarget()) {
Card choice = null;
if (list.isEmpty()) {
if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
if (!mandatory) {
sa.resetTargets();
}
return false;
}
}
PhaseHandler phase = game.getPhaseHandler();
final Player opp = AiAttackController.choosePreferredDefenderPlayer(ai);
Card primeTarget = ComputerUtil.getKilledByTargeting(sa, list);
if (primeTarget != null) {
choice = primeTarget;
} else if (phase.isPlayerTurn(ai) && phase.getPhase().isBefore(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
// Tap creatures possible blockers before combat during AI's turn.
List<Card> attackers;
if (phase.getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
//Combat has already started
attackers = game.getCombat().getAttackers();
} else {
attackers = CardLists.filter(ai.getCreaturesInPlay(), c -> CombatUtil.canAttack(c, opp));
attackers.remove(source);
}
List<Card> creatureList = CardLists.filter(list, CardPredicates.possibleBlockerForAtLeastOne(attackers));
// TODO check if own creature would be forced to attack and we want to keep it alive
if (!attackers.isEmpty() && !creatureList.isEmpty()) {
choice = ComputerUtilCard.getBestCreatureAI(creatureList);
} else if (sa.isTrigger() || ComputerUtil.castSpellInMain1(ai, sa)) {
choice = ComputerUtilCard.getMostExpensivePermanentAI(list);
}
} else if (phase.isPlayerTurn(opp)
&& phase.getPhase().isBefore(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
// Tap creatures possible blockers before combat during AI's turn.
if (list.anyMatch(CardPredicates.CREATURES)) {
List<Card> creatureList = CardLists.filter(list, c -> c.isCreature() && CombatUtil.canAttack(c, opp));
choice = ComputerUtilCard.getBestCreatureAI(creatureList);
} else { // no creatures available
choice = ComputerUtilCard.getMostExpensivePermanentAI(list);
}
} else {
choice = ComputerUtilCard.getMostExpensivePermanentAI(list);
}
if (choice == null) { // can't find anything left
if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
if (!mandatory) {
sa.resetTargets();
}
return false;
} else {
if (!ComputerUtil.shouldCastLessThanMax(ai, source)) {
return false;
}
break;
}
}
list.remove(choice);
sa.getTargets().add(choice);
}
return true;
}
}

View File

@@ -20,26 +20,21 @@ import forge.util.TextUtil;
import java.util.Map;
public class DigAi extends SpellAbilityAi {
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Game game = ai.getGame();
Player opp = AiAttackController.choosePreferredDefenderPlayer(ai);
final Card host = sa.getHostCard();
Player libraryOwner = ai;
if (!willPayCosts(ai, sa, sa.getPayCosts(), host)) {
return false;
}
if (sa.usesTargeting()) {
sa.resetTargets();
if (!sa.canTarget(opp)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.getTargets().add(opp);
libraryOwner = opp;
@@ -47,29 +42,21 @@ public class DigAi extends SpellAbilityAi {
// return false if nothing to dig into
if (libraryOwner.getCardsIn(ZoneType.Library).isEmpty()) {
return false;
}
if ("Never".equals(sa.getParam("AILogic"))) {
return false;
} else if ("AtOppEOT".equals(sa.getParam("AILogic"))) {
if (!(game.getPhaseHandler().getNextTurn() == ai && game.getPhaseHandler().is(PhaseType.END_OF_TURN))) {
return false;
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// don't deck yourself
if (sa.hasParam("DestinationZone2") && !"Library".equals(sa.getParam("DestinationZone2"))) {
int numToDig = AbilityUtils.calculateAmount(host, sa.getParam("DigNum"), sa);
if (libraryOwner == ai && ai.getCardsIn(ZoneType.Library).size() <= numToDig + 2) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// Don't use draw abilities before main 2 if possible
if (game.getPhaseHandler().getPhase().isBefore(PhaseType.MAIN2) && !sa.hasParam("ActivationPhases")
&& !sa.hasParam("DestinationZone") && !ComputerUtil.castSpellInMain1(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final String num = sa.getParam("DigNum");
@@ -87,14 +74,14 @@ public class DigAi extends SpellAbilityAi {
int numCards = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger()) - manaToSave;
if (numCards <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
root.setXManaCostPaid(numCards);
}
}
if (playReusable(ai, sa)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if ((!game.getPhaseHandler().getNextTurn().equals(ai)
@@ -102,24 +89,24 @@ public class DigAi extends SpellAbilityAi {
&& !sa.hasParam("PlayerTurn") && !isSorcerySpeed(sa, ai)
&& (ai.getCardsIn(ZoneType.Hand).size() > 1 || game.getPhaseHandler().getPhase().isBefore(PhaseType.DRAW))
&& !ComputerUtil.activateForCost(sa, ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if ("MadSarkhanDigDmg".equals(sa.getParam("AILogic"))) {
return SpecialCardAi.SarkhanTheMad.considerDig(ai, sa);
}
return !ComputerUtil.preventRunAwayActivations(sa);
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) {
// TODO: improve this check in ways that may be specific to a subability
return canPlayAI(aiPlayer, sa);
return canPlay(aiPlayer, sa);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final SpellAbility root = sa.getRootAbility();
PlayerCollection targetableOpps = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
Player opp = targetableOpps.min(PlayerPredicates.compareByLife());
@@ -137,12 +124,16 @@ public class DigAi extends SpellAbilityAi {
int manaToSave = Integer.parseInt(TextUtil.split(sa.getParam("AILogic"), '.')[1]);
int numCards = ComputerUtilCost.getMaxXValue(sa, ai, true) - manaToSave;
if (numCards <= 0) {
return mandatory;
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(100, AiPlayDecision.CantPlayAi);
}
}
root.setXManaCostPaid(numCards);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
@@ -203,8 +194,6 @@ public class DigAi extends SpellAbilityAi {
public boolean confirmAction(Player player, SpellAbility sa, PlayerActionConfirmMode mode, String message, Map<String, Object> params) {
Card topc = player.getZone(ZoneType.Library).get(0);
// AI actions for individual cards (until this AI can be generalized)
if (sa.getHostCard() != null) {
if (ComputerUtilAbility.getAbilitySourceName(sa).equals("Explorer's Scope")) {
// for Explorer's Scope, always put a land on the battlefield tapped
// (TODO: might not always be a good idea, e.g. when a land ETBing can have detrimental effects)
@@ -212,7 +201,6 @@ public class DigAi extends SpellAbilityAi {
} else if ("AlwaysConfirm".equals(sa.getParam("AILogic"))) {
return true;
}
}
// looks like perfect code for Delver of Secrets, but what about other cards?
return topc.isInstant() || topc.isSorcery();

View File

@@ -1,8 +1,6 @@
package forge.ai.ability;
import forge.ai.AiAttackController;
import forge.ai.ComputerUtil;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
@@ -14,13 +12,12 @@ import forge.game.zone.ZoneType;
import java.util.Map;
public class DigMultipleAi extends SpellAbilityAi {
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Game game = ai.getGame();
Player opp = AiAttackController.choosePreferredDefenderPlayer(ai);
final Card host = sa.getHostCard();
@@ -29,7 +26,7 @@ public class DigMultipleAi extends SpellAbilityAi {
if (sa.usesTargeting()) {
sa.resetTargets();
if (!opp.canBeTargetedBy(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.getTargets().add(opp);
libraryOwner = opp;
@@ -37,33 +34,29 @@ public class DigMultipleAi extends SpellAbilityAi {
// return false if nothing to dig into
if (libraryOwner.getCardsIn(ZoneType.Library).isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if ("Never".equals(sa.getParam("AILogic"))) {
return false;
} else if ("AtOppEOT".equals(sa.getParam("AILogic"))) {
if (!(game.getPhaseHandler().getNextTurn() == ai && game.getPhaseHandler().is(PhaseType.END_OF_TURN))) {
return false;
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// don't deck yourself
if (sa.hasParam("DestinationZone2") && !"Library".equals(sa.getParam("DestinationZone2"))) {
int numToDig = AbilityUtils.calculateAmount(host, sa.getParam("DigNum"), sa);
if (libraryOwner == ai && ai.getCardsIn(ZoneType.Library).size() <= numToDig + 2) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// Don't use draw abilities before main 2 if possible
if (game.getPhaseHandler().getPhase().isBefore(PhaseType.MAIN2) && !sa.hasParam("ActivationPhases")
&& !sa.hasParam("DestinationZone") && !ComputerUtil.castSpellInMain1(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (playReusable(ai, sa)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if ((!game.getPhaseHandler().getNextTurn().equals(ai)
@@ -71,14 +64,14 @@ public class DigMultipleAi extends SpellAbilityAi {
&& !sa.hasParam("PlayerTurn") && !isSorcerySpeed(sa, ai)
&& (ai.getCardsIn(ZoneType.Hand).size() > 1 || game.getPhaseHandler().getPhase().isBefore(PhaseType.DRAW))
&& !ComputerUtil.activateForCost(sa, ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return !ComputerUtil.preventRunAwayActivations(sa);
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Player opp = AiAttackController.choosePreferredDefenderPlayer(ai);
if (sa.usesTargeting()) {
sa.resetTargets();
@@ -89,7 +82,7 @@ public class DigMultipleAi extends SpellAbilityAi {
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/* (non-Javadoc)

View File

@@ -1,8 +1,6 @@
package forge.ai.ability;
import forge.ai.AiAttackController;
import forge.ai.ComputerUtilCost;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.card.Card;
import forge.game.card.CardLists;
import forge.game.card.CardPredicates;
@@ -11,7 +9,6 @@ import forge.game.player.Player;
import forge.game.player.PlayerActionConfirmMode;
import forge.game.spellability.SpellAbility;
import forge.game.zone.ZoneType;
import forge.util.MyRandom;
import java.util.List;
import java.util.Map;
@@ -19,7 +16,7 @@ import java.util.Map;
public class DigUntilAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
Card source = sa.getHostCard();
final String logic = sa.getParamOrDefault("AILogic", "");
double chance = .4; // 40 percent chance with instant speed stuff
@@ -42,7 +39,7 @@ public class DigUntilAi extends SpellAbilityAi {
// material in the library after using it several times.
// TODO: maybe this should happen for any DigUntil SA with RevealedDestination$ Graveyard?
if (ai.getCardsIn(ZoneType.Library).size() < 20) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if ("Land.Basic".equals(sa.getParam("Valid"))
&& ai.getZone(ZoneType.Hand).contains(CardPredicates.LANDS_PRODUCING_MANA)) {
@@ -52,7 +49,7 @@ public class DigUntilAi extends SpellAbilityAi {
// This is important for Replenish/Living Death type decks
if (!ai.getGame().getPhaseHandler().is(PhaseType.END_OF_TURN)
&& !ai.getGame().getPhaseHandler().isPlayerTurn(ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -60,7 +57,7 @@ public class DigUntilAi extends SpellAbilityAi {
if (sa.usesTargeting()) {
sa.resetTargets();
if (!sa.canTarget(opp)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.getTargets().add(opp);
libraryOwner = opp;
@@ -68,7 +65,7 @@ public class DigUntilAi extends SpellAbilityAi {
if (sa.hasParam("Valid")) {
final String valid = sa.getParam("Valid");
if (CardLists.getValidCards(ai.getCardsIn(ZoneType.Library), valid, source.getController(), source, sa).isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -80,7 +77,7 @@ public class DigUntilAi extends SpellAbilityAi {
if (root.getXManaCostPaid() == null) {
int numCards = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
if (numCards <= 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
root.setXManaCostPaid(numCards);
}
@@ -88,15 +85,14 @@ public class DigUntilAi extends SpellAbilityAi {
// return false if nothing to dig into
if (libraryOwner.getCardsIn(ZoneType.Library).isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final boolean randomReturn = MyRandom.getRandom().nextFloat() <= Math.pow(chance, sa.getActivationsThisTurn() + 1);
return randomReturn;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (sa.usesTargeting()) {
sa.resetTargets();
if (sa.isCurse()) {
@@ -116,7 +112,7 @@ public class DigUntilAi extends SpellAbilityAi {
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/* (non-Javadoc)

View File

@@ -26,31 +26,29 @@ import forge.util.collect.FCollectionView;
public class DiscardAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
final Card source = sa.getHostCard();
final String sourceName = ComputerUtilAbility.getAbilitySourceName(sa);
final Cost abCost = sa.getPayCosts();
final String aiLogic = sa.getParamOrDefault("AILogic", "");
// temporarily disabled until better AI
if (!willPayCosts(ai, sa, abCost, source)) {
return false;
}
if ("Chandra, Flamecaller".equals(sourceName)) {
final int hand = ai.getCardsIn(ZoneType.Hand).size();
return MyRandom.getRandom().nextFloat() < (1.0 / (1 + hand));
if (MyRandom.getRandom().nextFloat() < (1.0 / (1 + hand))) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
if (aiLogic.equals("VolrathsShapeshifter")) {
return SpecialCardAi.VolrathsShapeshifter.consider(ai, sa);
}
final boolean humanHasHand = ai.getWeakestOpponent().getCardsIn(ZoneType.Hand).size() > 0;
final boolean humanHasHand = !ai.getWeakestOpponent().getCardsIn(ZoneType.Hand).isEmpty();
if (sa.usesTargeting()) {
if (!discardTargetAI(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
// TODO: Add appropriate restrictions
@@ -64,7 +62,7 @@ public class DiscardAi extends SpellAbilityAi {
} else {
// defined to the human, so that's fine as long the human has cards
if (!humanHasHand) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
@@ -78,12 +76,12 @@ public class DiscardAi extends SpellAbilityAi {
final int cardsToDiscard = Math.min(ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger()), ai.getWeakestOpponent()
.getCardsIn(ZoneType.Hand).size());
if (cardsToDiscard < 1) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.setXManaCostPaid(cardsToDiscard);
} else {
if (AbilityUtils.calculateAmount(source, sa.getParam("NumCards"), sa) < 1) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -113,7 +111,7 @@ public class DiscardAi extends SpellAbilityAi {
}
}
if (numDiscard == 0) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -121,27 +119,25 @@ public class DiscardAi extends SpellAbilityAi {
// Don't use discard abilities before main 2 if possible
if (ai.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.MAIN2)
&& !sa.hasParam("ActivationPhases") && !aiLogic.startsWith("AnyPhase")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (aiLogic.equals("AnyPhaseIfFavored")) {
if (ai.getGame().getCombat() != null) {
if (ai.getCardsIn(ZoneType.Hand).size() < ai.getGame().getCombat().getDefenderPlayerByAttacker(source).getCardsIn(ZoneType.Hand).size()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
// Don't tap creatures that may be able to block
if (ComputerUtil.waitForBlocking(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
boolean randomReturn = MyRandom.getRandom().nextFloat() <= Math.pow(0.9, sa.getActivationsThisTurn());
// some other variables here, like handsize vs. maxHandSize
return randomReturn;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
private boolean discardTargetAI(final Player ai, final SpellAbility sa) {
@@ -166,7 +162,7 @@ public class DiscardAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (sa.usesTargeting()) {
PlayerCollection targetableOpps = ai.getOpponents().filter(PlayerPredicates.isTargetableBy(sa));
Player opp = targetableOpps.min(PlayerPredicates.compareByLife());
@@ -176,7 +172,7 @@ public class DiscardAi extends SpellAbilityAi {
} else if (mandatory && sa.canTarget(ai)) {
sa.getTargets().add(ai);
} else {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
@@ -184,7 +180,7 @@ public class DiscardAi extends SpellAbilityAi {
if ("AtLeast2".equals(sa.getParam("AILogic"))) {
final List<Player> players = AbilityUtils.getDefinedPlayers(sa.getHostCard(), sa.getParam("Defined"), sa);
if (players.isEmpty() || players.get(0).getCardsIn(ZoneType.Hand).size() < 2) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
@@ -196,18 +192,22 @@ public class DiscardAi extends SpellAbilityAi {
}
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
// Drawback AI improvements
// if parent draws cards, make sure cards in hand + cards drawn > 0
if (sa.usesTargeting()) {
return discardTargetAI(ai, sa);
if (discardTargetAI(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
// TODO: check for some extra things
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public boolean confirmAction(Player player, SpellAbility sa, PlayerActionConfirmMode mode, String message, Map<String, Object> params) {

View File

@@ -1,9 +1,6 @@
package forge.ai.ability;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtil;
import forge.ai.PlayerControllerAi;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
import forge.game.player.Player;
@@ -16,12 +13,8 @@ import java.util.Map;
public class DiscoverAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false; // prevent infinite loop
}
return true;
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/**
@@ -36,8 +29,12 @@ public class DiscoverAi extends SpellAbilityAi {
* @return a boolean.
*/
@Override
protected boolean doTriggerAINoCost(final Player ai, final SpellAbility sa, final boolean mandatory) {
return mandatory || checkApiLogic(ai, sa);
protected AiAbilityDecision doTriggerNoCost(final Player ai, final SpellAbility sa, final boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return checkApiLogic(ai, sa);
}
@Override

View File

@@ -1,23 +1,23 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.ability.AbilityUtils;
import forge.game.card.Card;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
import forge.util.MyRandom;
import java.util.List;
public class DrainManaAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
// AI cannot use this properly until he can use SAs during Humans turn
final Card source = sa.getHostCard();
final Player opp = ai.getWeakestOpponent();
boolean randomReturn = MyRandom.getRandom().nextFloat() <= Math.pow(.6667, sa.getActivationsThisTurn());
if (!sa.usesTargeting()) {
// assume we are looking to tap human's stuff
@@ -25,56 +25,58 @@ public class DrainManaAi extends SpellAbilityAi {
final List<Player> defined = AbilityUtils.getDefinedPlayers(source, sa.getParam("Defined"), sa);
if (!defined.contains(opp)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
sa.resetTargets();
sa.getTargets().add(opp);
}
return randomReturn;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Player opp = ai.getWeakestOpponent();
final Card source = sa.getHostCard();
if (!sa.usesTargeting()) {
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
final List<Player> defined = AbilityUtils.getDefinedPlayers(source, sa.getParam("Defined"), sa);
return defined.contains(opp);
if (defined.contains(opp)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else {
sa.resetTargets();
sa.getTargets().add(opp);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
// AI cannot use this properly until he can use SAs during Humans turn
final Card source = sa.getHostCard();
boolean randomReturn = true;
if (!sa.usesTargeting()) {
final List<Player> defined = AbilityUtils.getDefinedPlayers(source, sa.getParam("Defined"), sa);
if (defined.contains(ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
sa.resetTargets();
sa.getTargets().add(ai.getWeakestOpponent());
}
return randomReturn;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -42,43 +42,41 @@ public class DrawAi extends SpellAbilityAi {
* @see forge.ai.SpellAbilityAi#checkApiLogic(forge.game.player.Player, forge.game.spellability.SpellAbility)
*/
@Override
protected boolean checkApiLogic(Player ai, SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(Player ai, SpellAbility sa) {
if (!targetAI(ai, sa, false)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (sa.usesTargeting()) {
final Player player = sa.getTargets().getFirstTargetedPlayer();
if (player != null && player.isOpponentOf(ai)) {
return true;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
// prevent run-away activations - first time will always return true
if (ComputerUtil.preventRunAwayActivations(sa)) {
return false;
}
if (ComputerUtil.playImmediately(ai, sa)) {
return true;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Don't tap creatures that may be able to block
if (ComputerUtil.waitForBlocking(sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.WaitForCombat);
}
if (!canLoot(ai, sa)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (ComputerUtilCost.isSacrificeSelfCost(sa.getPayCosts())) {
// Canopy lands and other cards that sacrifice themselves to draw cards
return ai.getCardsIn(ZoneType.Hand).isEmpty()
|| (sa.getHostCard().isLand() && ai.getLandsInPlay().size() >= 5); // TODO: make this configurable in the AI profile
if (ai.getCardsIn(ZoneType.Hand).isEmpty()
|| (sa.getHostCard().isLand() && ai.getLandsInPlay().size() >= 5)) {
// TODO: make this configurable in the AI profile
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return true;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
/*
@@ -161,8 +159,6 @@ public class DrawAi extends SpellAbilityAi {
// LifeLessThan logic presupposes activation as soon as possible in an
// attempt to save the AI from dying
return true;
} else if (logic.equals("AtOppEOT")) {
return ph.is(PhaseType.END_OF_TURN) && ph.getNextTurn().equals(ai);
} else if (logic.equals("RespondToOwnActivation")) {
return !ai.getGame().getStack().isEmpty() && ai.getGame().getStack().peekAbility().getHostCard().equals(sa.getHostCard());
} else if ((!ph.getNextTurn().equals(ai) || ph.getPhase().isBefore(PhaseType.END_OF_TURN))
@@ -175,8 +171,12 @@ public class DrawAi extends SpellAbilityAi {
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
return targetAI(ai, sa, sa.isTrigger() && sa.getHostCard().isInPlay());
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
if (targetAI(ai, sa, sa.isTrigger() && sa.getHostCard().isInPlay())) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
/**
@@ -534,12 +534,16 @@ public class DrawAi extends SpellAbilityAi {
} // drawTargetAI()
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (!mandatory && !willPayCosts(ai, sa, sa.getPayCosts(), sa.getHostCard())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return targetAI(ai, sa, mandatory);
if (targetAI(ai, sa, mandatory)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
/* (non-Javadoc)

View File

@@ -23,8 +23,10 @@ import forge.game.replacement.ReplacementType;
import forge.game.spellability.SpellAbility;
import forge.game.spellability.SpellAbilityStackInstance;
import forge.game.spellability.TargetRestrictions;
import forge.game.staticability.StaticAbilityMode;
import forge.game.zone.MagicStack;
import forge.game.zone.ZoneType;
import forge.util.FileSection;
import forge.util.MyRandom;
import forge.util.TextUtil;
import forge.util.collect.FCollectionView;
@@ -35,22 +37,22 @@ import java.util.Map;
public class EffectAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(final Player ai,final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
final Game game = ai.getGame();
final PhaseHandler phase = game.getPhaseHandler();
boolean randomReturn = MyRandom.getRandom().nextFloat() <= .6667;
String logic = "";
if (sa.hasParam("AILogic")) {
logic = sa.getParam("AILogic");
final PhaseHandler phase = game.getPhaseHandler();
if (logic.equals("BeginningOfOppTurn")) {
if (!phase.getPlayerTurn().isOpponentOf(ai) || phase.getPhase().isAfter(PhaseType.DRAW)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
randomReturn = true;
} else if (logic.equals("EndOfOppTurn")) {
if (!phase.getPlayerTurn().isOpponentOf(ai) || phase.getPhase().isBefore(PhaseType.END_OF_TURN)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
randomReturn = true;
} else if (logic.equals("KeepOppCreatsLandsTapped")) {
@@ -64,20 +66,20 @@ public class EffectAi extends SpellAbilityAi {
worthHolding = true;
}
if (!worthHolding) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
randomReturn = true;
}
} else if (logic.equals("RestrictBlocking")) {
if (!phase.isPlayerTurn(ai) || phase.getPhase().isBefore(PhaseType.COMBAT_BEGIN)
|| phase.getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.getPayCosts().getTotalMana().countX() > 0 && sa.getHostCard().getSVar("X").equals("Count$xPaid")) {
// Set PayX here to half the remaining mana to allow for Main 2 and other combat shenanigans.
final int xPay = ComputerUtilMana.determineLeftoverMana(sa, ai, sa.isTrigger()) / 2;
if (xPay == 0) { return false; }
if (xPay == 0) { return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi); }
sa.setXManaCostPaid(xPay);
}
@@ -90,23 +92,27 @@ public class EffectAi extends SpellAbilityAi {
int potentialDmg = 0;
List<Card> currentAttackers = new ArrayList<>();
if (possibleBlockers.isEmpty()) { return false; }
if (possibleBlockers.isEmpty()) { return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi); }
for (final Card creat : possibleAttackers) {
if (CombatUtil.canAttack(creat, opp) && possibleBlockers.size() > 1) {
potentialDmg += creat.getCurrentPower();
if (potentialDmg >= oppLife) { return true; }
if (potentialDmg >= oppLife) { return new AiAbilityDecision(100, AiPlayDecision.WillPlay); }
}
if (combat != null && combat.isAttacking(creat)) {
currentAttackers.add(creat);
}
}
return currentAttackers.size() > possibleBlockers.size();
if (currentAttackers.size() > possibleBlockers.size()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (logic.equals("Fog")) {
FogAi fogAi = new FogAi();
if (!fogAi.canPlayAI(ai, sa)) {
return false;
if (!fogAi.canPlay(ai, sa).willingToPlay()) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final TargetRestrictions tgt = sa.getTargetRestrictions();
@@ -124,14 +130,14 @@ public class EffectAi extends SpellAbilityAi {
}
if (!canTgt) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else {
List<Card> list = game.getCombat().getAttackers();
list = CardLists.getTargetableCards(list, sa);
Card target = ComputerUtilCard.getBestCreatureAI(list);
if (target == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.getTargets().add(target);
}
@@ -139,7 +145,7 @@ public class EffectAi extends SpellAbilityAi {
randomReturn = true;
} else if (logic.equals("ChainVeil")) {
if (!phase.isPlayerTurn(ai) || !phase.getPhase().equals(PhaseType.MAIN2) || ai.getPlaneswalkersInPlay().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
randomReturn = true;
} else if (logic.equals("WillCastCreature") && ai.isAI()) {
@@ -150,17 +156,17 @@ public class EffectAi extends SpellAbilityAi {
randomReturn = true;
} else if (logic.equals("Main1")) {
if (phase.getPhase().isBefore(PhaseType.MAIN1)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
randomReturn = true;
} else if (logic.equals("Main2")) {
if (phase.getPhase().isBefore(PhaseType.MAIN2)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
randomReturn = true;
} else if (logic.equals("Evasion")) {
if (!phase.isPlayerTurn(ai)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
boolean shouldPlay = false;
@@ -185,10 +191,10 @@ public class EffectAi extends SpellAbilityAi {
break;
}
return shouldPlay;
return shouldPlay ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("RedirectSpellDamageFromPlayer")) {
if (game.getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
boolean threatened = false;
for (final SpellAbilityStackInstance stackInst : game.getStack()) {
@@ -204,7 +210,7 @@ public class EffectAi extends SpellAbilityAi {
randomReturn = threatened;
} else if (logic.equals("Prevent")) { // prevent burn spell from opponent
if (game.getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final SpellAbility saTop = game.getStack().peekAbility();
final Card host = saTop.getHostCard();
@@ -215,10 +221,10 @@ public class EffectAi extends SpellAbilityAi {
final ApiType type = saTop.getApi();
if (type == ApiType.DealDamage || type == ApiType.DamageAll) { // burn spell
sa.getTargets().add(saTop);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("NoGain")) {
// basic logic to cancel GainLife on stack
if (!game.getStack().isEmpty()) {
@@ -228,14 +234,14 @@ public class EffectAi extends SpellAbilityAi {
while (topStack != null) {
if (topStack.getApi() == ApiType.GainLife) {
if ("You".equals(topStack.getParam("Defined")) || topStack.isTargeting(activator) || (!topStack.usesTargeting() && !topStack.hasParam("Defined"))) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else if (topStack.getApi() == ApiType.DealDamage && topStack.getHostCard().hasKeyword(Keyword.LIFELINK)) {
Card host = topStack.getHostCard();
for (GameEntity target : topStack.getTargets().getTargetEntities()) {
if (ComputerUtilCombat.predictDamageTo(target,
AbilityUtils.calculateAmount(host, topStack.getParam("NumDmg"), topStack), host, false) > 0) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
@@ -249,11 +255,11 @@ public class EffectAi extends SpellAbilityAi {
final Player attackingPlayer = combat.getAttackingPlayer();
if (attackingPlayer.isOpponentOf(ai) && attackingPlayer.canGainLife()) {
if (ComputerUtilCombat.checkAttackerLifelinkDamage(combat) > 0) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("NonCastCreature")) {
// TODO: add support for more cases with more convoluted API setups
if (!game.getStack().isEmpty()) {
@@ -265,11 +271,11 @@ public class EffectAi extends SpellAbilityAi {
boolean reanimator = "true".equalsIgnoreCase(topStack.getSVar("IsReanimatorCard"));
if (changeZone && (toBattlefield || reanimator)) {
if ("Creature".equals(topStack.getParam("ChangeType")) || topStack.getParamOrDefault("Defined", "").contains("Creature"))
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("Fight")) {
return FightAi.canFightAi(ai, sa, 0,0);
} else if (logic.equals("Pump")) {
@@ -281,45 +287,44 @@ public class EffectAi extends SpellAbilityAi {
}
if (!options.isEmpty() && phase.isPlayerTurn(ai) && phase.getPhase().isBefore(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(options));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("Burn")) {
// for DamageDeal sub-abilities (eg. Wild Slash, Skullcrack)
SpellAbility burn = sa.getSubAbility();
return SpellApiToAi.Converter.get(burn).canPlayAIWithSubs(ai, burn);
return SpellApiToAi.Converter.get(burn).canPlayWithSubs(ai, burn).willingToPlay() ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("YawgmothsWill")) {
return SpecialCardAi.YawgmothsWill.consider(ai, sa);
return SpecialCardAi.YawgmothsWill.consider(ai, sa) ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.startsWith("NeedCreatures")) {
if (ai.getCreaturesInPlay().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (logic.contains(":")) {
String[] k = logic.split(":");
int i = Integer.parseInt(k[1]);
return ai.getCreaturesInPlay().size() >= i;
return ai.getCreaturesInPlay().size() >= i ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (logic.equals("ReplaySpell")) {
CardCollection list = CardLists.getValidCards(game.getCardsIn(ZoneType.Graveyard), sa.getTargetRestrictions().getValidTgts(), ai, sa.getHostCard(), sa);
if (!ComputerUtil.targetPlayableSpellCard(ai, list, sa, false, false)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (logic.equals("PeaceTalks")) {
Player nextPlayer = game.getNextPlayerAfter(ai);
// If opponent doesn't have creatures, preventing attacks don't mean as much
if (nextPlayer.getCreaturesInPlay().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Only cast Peace Talks after you attack just in case you have creatures
if (!phase.is(PhaseType.MAIN2)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Create a pseudo combat and see if my life is in danger
return randomReturn;
return randomReturn ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("Bribe")) {
Card host = sa.getHostCard();
Combat combat = game.getCombat();
@@ -327,9 +332,9 @@ public class EffectAi extends SpellAbilityAi {
&& phase.is(PhaseType.COMBAT_DECLARE_BLOCKERS)
&& !AiCardMemory.isRememberedCard(ai, host, AiCardMemory.MemorySet.ACTIVATED_THIS_TURN)) {
AiCardMemory.rememberCard(ai, host, AiCardMemory.MemorySet.ACTIVATED_THIS_TURN); // ideally needs once per combat or something
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (logic.equals("CantRegenerate")) {
if (sa.usesTargeting()) {
CardCollection list = CardLists.getTargetableCards(ai.getOpponents().getCardsIn(ZoneType.Battlefield), sa);
@@ -350,19 +355,19 @@ public class EffectAi extends SpellAbilityAi {
});
if (list.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// TODO check Stack for Effects that would destroy the selected card?
sa.getTargets().add(ComputerUtilCard.getBestAI(list));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if (sa.getParent() != null) {
// sub ability should be okay
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else if ("Self".equals(sa.getParam("RememberObjects"))) {
// the ones affecting itself are Nimbus cards, were opponent can activate this effect
Card host = sa.getHostCard();
if (!host.canBeDestroyed()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
Map<AbilityKey, Object> runParams = AbilityKey.mapFromAffected(sa.getHostCard());
@@ -370,18 +375,130 @@ public class EffectAi extends SpellAbilityAi {
List<ReplacementEffect> repDestroyList = game.getReplacementHandler().getReplacementList(ReplacementType.Destroy, runParams, ReplacementLayer.Other);
// no Destroy Replacement, or one non-Regeneration one like Totem-Armor
if (repDestroyList.isEmpty() || repDestroyList.stream().anyMatch(CardTraitPredicates.hasParam("Regeneration").negate())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (cantRegenerateCheckCombat(host) || cantRegenerateCheckStack(host)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
} else if (sa.hasParam("RememberObjects")) { //generic
boolean cantAttack = false;
boolean cantBlock = false;
boolean cantActivate = false;
String duraction = sa.getParam("Duration");
String matchStr = "Card.IsRemembered";
for (String st : sa.getParam("StaticAbilities").split(",")) {
Map<String, String> params = FileSection.parseToMap(sa.getSVar(st), FileSection.DOLLAR_SIGN_KV_SEPARATOR);
List<StaticAbilityMode> modes = StaticAbilityMode.listValueOf(params.get("Mode"));
if (modes.contains(StaticAbilityMode.CantAttack) && matchStr.equals(params.get("ValidCard"))) {
cantAttack = true;
}
if (modes.contains(StaticAbilityMode.CantBlock) && matchStr.equals(params.get("ValidCard"))) {
cantBlock = true;
}
if (modes.contains(StaticAbilityMode.CantBlockBy) && matchStr.equals(params.get("ValidBlocker"))) {
cantBlock = true;
}
if (modes.contains(StaticAbilityMode.CantBeActivated) && matchStr.equals(params.get("ValidCard"))) {
cantActivate = true;
}
}
// TODO add more cases later
if (!cantAttack && !cantBlock && !cantActivate) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (cantBlock && duraction == null && phase.isPlayerTurn(ai) && !phase.getPhase().isBefore(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.usesTargeting()) {
final Player opp = AiAttackController.choosePreferredDefenderPlayer(ai);
CardCollection list = new CardCollection(CardUtil.getValidCardsToTarget(sa));
list = ComputerUtil.filterAITgts(sa, ai, list, true);
if (list.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
List<Card> oppCreatures = CardLists.filterAsList(list, c -> {
return c.isCreature() && c.getController().isOpponentOf(ai);
});
List<Card> oppWithAbilities = CardLists.filterAsList(list, c -> {
return !c.isCreature() && c.getController().isOpponentOf(ai) && c.getSpellAbilities().anyMatch(SpellAbility::isActivatedAbility);
});
if (cantAttack || cantBlock) {
if (oppCreatures.isEmpty()) {
if (!cantActivate || oppWithAbilities.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}
while (sa.canAddMoreTarget()) {
Card choice = null;
if (cantAttack && cantBlock && !oppCreatures.isEmpty()) {
Card primeTarget = ComputerUtil.getKilledByTargeting(sa, oppCreatures);
if (primeTarget != null) {
choice = primeTarget;
} else if (phase.isPlayerTurn(ai) && phase.getPhase().isBefore(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
// Tap creatures possible blockers before combat during AI's turn.
List<Card> attackers;
if (phase.getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
//Combat has already started
attackers = game.getCombat().getAttackers();
} else {
attackers = CardLists.filter(ai.getCreaturesInPlay(), c -> CombatUtil.canAttack(c, opp));
}
List<Card> creatureList = CardLists.filter(list, CardPredicates.possibleBlockerForAtLeastOne(attackers));
// TODO check if own creature would be forced to attack and we want to keep it alive
if (!attackers.isEmpty() && !creatureList.isEmpty()) {
choice = ComputerUtilCard.getBestCreatureAI(creatureList);
} else if (sa.isTrigger() || ComputerUtil.castSpellInMain1(ai, sa)) {
choice = ComputerUtilCard.getMostExpensivePermanentAI(list);
}
}
} // TODO add logic to tap non creatures with activated abilities if cantActivate is true
if (choice == null) { // can't find anything left
if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
sa.resetTargets();
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else {
if (!ComputerUtil.shouldCastLessThanMax(ai, sa.getHostCard())) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
break;
}
}
list.remove(choice);
oppCreatures.remove(choice);
sa.getTargets().add(choice);
}
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else { //no AILogic
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if ("False".equals(sa.getParam("Stackable"))) {
@@ -390,7 +507,7 @@ public class EffectAi extends SpellAbilityAi {
name = sa.getHostCard().getName() + "'s Effect";
}
if (sa.getActivatingPlayer().isCardInCommand(name)) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@@ -406,20 +523,20 @@ public class EffectAi extends SpellAbilityAi {
break;
}
}
return canTgt;
return canTgt ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else {
sa.getTargets().add(ai);
}
}
return randomReturn;
return randomReturn ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(final Player aiPlayer, final SpellAbility sa, final boolean mandatory) {
if (sa.hasParam("AILogic")) {
if (canPlayAI(aiPlayer, sa)) {
return true; // if false, fall through further to do the mandatory stuff
if (canPlay(aiPlayer, sa).willingToPlay()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
@@ -431,7 +548,7 @@ public class EffectAi extends SpellAbilityAi {
if (!oppPerms.isEmpty()) {
sa.resetTargets();
sa.getTargets().add(ComputerUtilCard.getBestAI(oppPerms));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (mandatory) {
@@ -441,14 +558,14 @@ public class EffectAi extends SpellAbilityAi {
if (!aiPerms.isEmpty()) {
sa.resetTargets();
sa.getTargets().add(ComputerUtilCard.getWorstAI(aiPerms));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return super.doTriggerAINoCost(aiPlayer, sa, mandatory);
return super.doTriggerNoCost(aiPlayer, sa, mandatory);
}
protected boolean cantRegenerateCheckCombat(Card host) {

View File

@@ -17,9 +17,7 @@
*/
package forge.ai.ability;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilCombat;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.card.Card;
import forge.game.card.CardLists;
import forge.game.combat.CombatUtil;
@@ -45,19 +43,17 @@ public final class EncodeAi extends SpellAbilityAi {
* </p>
* @param sa
* a {@link forge.game.spellability.SpellAbility} object.
* @param af
* a {@link forge.game.ability.AbilityFactory} object.
*
* @return a boolean.
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return true;
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
return true;
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
/*

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
@@ -12,18 +14,22 @@ import forge.game.spellability.SpellAbility;
public class EndTurnAi extends SpellAbilityAi {
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return mandatory;
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player aiPlayer) { return false; }
public AiAbilityDecision chkDrawback(SpellAbility sa, Player aiPlayer) { return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi); }
/* (non-Javadoc)
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
return false;
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -2,6 +2,8 @@ package forge.ai.ability;
import com.google.common.collect.Sets;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.ability.AbilityUtils;
@@ -22,19 +24,19 @@ public class EndureAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
// Support for possible targeted Endure (e.g. target creature endures X)
if (sa.usesTargeting()) {
Card bestCreature = ComputerUtilCard.getBestCreatureAI(aiPlayer.getCardsIn(ZoneType.Battlefield));
if (bestCreature == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.resetTargets();
sa.getTargets().add(bestCreature);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public static boolean shouldPutCounters(Player ai, SpellAbility sa) {
@@ -121,7 +123,7 @@ public class EndureAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
// Support for possible targeted Endure (e.g. target creature endures X)
if (sa.usesTargeting()) {
CardCollection list = CardLists.getValidCards(aiPlayer.getGame().getCardsIn(ZoneType.Battlefield),
@@ -129,12 +131,16 @@ public class EndureAi extends SpellAbilityAi {
if (!list.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(list));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
return canPlayAI(aiPlayer, sa) || mandatory;
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(aiPlayer, sa);
}
}

View File

@@ -15,19 +15,19 @@ public class ExploreAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
// Explore with a target (e.g. Enter the Unknown)
if (sa.usesTargeting()) {
Card bestCreature = ComputerUtilCard.getBestCreatureAI(aiPlayer.getCardsIn(ZoneType.Battlefield));
if (bestCreature == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.resetTargets();
sa.getTargets().add(bestCreature);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
public static boolean shouldPutInGraveyard(Card topCard, Player ai) {
@@ -64,19 +64,23 @@ public class ExploreAi extends SpellAbilityAi {
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (sa.usesTargeting()) {
CardCollection list = CardLists.getValidCards(aiPlayer.getGame().getCardsIn(ZoneType.Battlefield),
sa.getTargetRestrictions().getValidTgts(), aiPlayer, sa.getHostCard(), sa);
if (!list.isEmpty()) {
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(list));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
return canPlayAI(aiPlayer, sa) || mandatory;
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(aiPlayer, sa);
}
}

View File

@@ -24,13 +24,13 @@ public class FightAi extends SpellAbilityAi {
}
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
sa.resetTargets();
final Card source = sa.getHostCard();
// everything is defined or targeted above, can't do anything there unless a specific logic is set
if (sa.hasParam("Defined") && !sa.usesTargeting()) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// Get creature lists
@@ -42,8 +42,10 @@ public class FightAi extends SpellAbilityAi {
// Filter MustTarget requirements
StaticAbilityMustTarget.filterMustTargetCards(ai, humCreatures, sa);
if (humCreatures.isEmpty())
return false; //prevent IndexOutOfBoundsException on MOJHOSTO variant
//prevent IndexOutOfBoundsException on MOJHOSTO variant
if (humCreatures.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
// assumes the triggered card belongs to the ai
if (sa.hasParam("Defined")) {
@@ -54,7 +56,7 @@ public class FightAi extends SpellAbilityAi {
}
}
if (fighter1List.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
Card fighter1 = fighter1List.get(0);
for (Card humanCreature : humCreatures) {
@@ -62,10 +64,11 @@ public class FightAi extends SpellAbilityAi {
&& !canKill(humanCreature, fighter1, 0)) {
// todo: check min/max targets; see if we picked the best matchup
sa.getTargets().add(humanCreature);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false; // bail at this point, otherwise the AI will overtarget and waste the activation
// bail at this point, otherwise the AI will overtarget and waste the activation
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
if (sa.hasParam("TargetsFromDifferentZone")) {
@@ -77,12 +80,12 @@ public class FightAi extends SpellAbilityAi {
// todo: check min/max targets; see if we picked the best matchup
sa.getTargets().add(humanCreature);
sa.getTargets().add(aiCreature);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
for (Card creature1 : humCreatures) {
for (Card creature2 : humCreatures) {
@@ -97,42 +100,52 @@ public class FightAi extends SpellAbilityAi {
// todo: check min/max targets; see if we picked the best matchup
sa.getTargets().add(creature1);
sa.getTargets().add(creature2);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
@Override
public boolean chkAIDrawback(final SpellAbility sa, final Player aiPlayer) {
public AiAbilityDecision chkDrawback(final SpellAbility sa, final Player aiPlayer) {
if ("Always".equals(sa.getParam("AILogic"))) {
return true; // e.g. Hunt the Weak, the AI logic was already checked through canFightAi
return new AiAbilityDecision(100, AiPlayDecision.WillPlay); // e.g. Hunt the Weak, the AI logic was already checked through canFightAi
}
return checkApiLogic(aiPlayer, sa);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final String aiLogic = sa.getParamOrDefault("AILogic", "");
if (aiLogic.equals("Grothama")) {
return mandatory ? true : SpecialCardAi.GrothamaAllDevouring.consider(ai, sa);
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
if (checkApiLogic(ai, sa)) {
return true;
if (SpecialCardAi.GrothamaAllDevouring.consider(ai, sa)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
AiAbilityDecision decision = checkApiLogic(ai, sa);
if (decision.willingToPlay()) {
return decision;
}
if (!mandatory) {
return false;
return decision;
}
// if mandatory, we have to play it, so we will try to make a good trade or no trade
//try to make a good trade or no trade
final Card source = sa.getHostCard();
List<Card> humCreatures = ai.getOpponents().getCreaturesInPlay();
humCreatures = CardLists.getTargetableCards(humCreatures, sa);
if (humCreatures.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
//assumes the triggered card belongs to the ai
if (sa.hasParam("Defined")) {
@@ -141,19 +154,19 @@ public class FightAi extends SpellAbilityAi {
if (canKill(aiCreature, humanCreature, 0)
&& ComputerUtilCard.evaluateCreature(humanCreature) > ComputerUtilCard.evaluateCreature(aiCreature)) {
sa.getTargets().add(humanCreature);
return true;
return new AiAbilityDecision(100, AiPlayDecision.MandatoryPlay);
}
}
for (Card humanCreature : humCreatures) {
if (!canKill(humanCreature, aiCreature, 0)) {
sa.getTargets().add(humanCreature);
return true;
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
}
sa.getTargets().add(humCreatures.get(0));
return true;
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
return true;
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
/**
@@ -164,7 +177,7 @@ public class FightAi extends SpellAbilityAi {
* @param power bonus to power
* @return true if fight effect should be played, false otherwise
*/
public static boolean canFightAi(final Player ai, final SpellAbility sa, int power, int toughness) {
public static AiAbilityDecision canFightAi(final Player ai, final SpellAbility sa, int power, int toughness) {
final Card source = sa.getHostCard();
final String sourceName = ComputerUtilAbility.getAbilitySourceName(sa);
AbilitySub tgtFight = sa.getSubAbility();
@@ -196,7 +209,7 @@ public class FightAi extends SpellAbilityAi {
ComputerUtilCard.sortByEvaluateCreature(aiCreatures);
ComputerUtilCard.sortByEvaluateCreature(humCreatures);
if (humCreatures.isEmpty() || aiCreatures.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
}
// Evaluate creature pairs
for (Card humanCreature : humCreatures) {
@@ -226,7 +239,7 @@ public class FightAi extends SpellAbilityAi {
tgtFight.resetTargets();
tgtFight.getTargets().add(humanCreature);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
// Other cards that use AILogic PowerDmg and a single target
@@ -236,7 +249,7 @@ public class FightAi extends SpellAbilityAi {
tgtFight.resetTargets();
tgtFight.getTargets().add(humanCreature);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
} else {
@@ -249,12 +262,12 @@ public class FightAi extends SpellAbilityAi {
sa.getTargets().add(aiCreature);
tgtFight.resetTargets();
tgtFight.getTargets().add(humanCreature);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
/**

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtil;
import forge.ai.SpellAbilityAi;
import forge.game.card.Card;
@@ -13,52 +15,56 @@ public class FlipACoinAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
if (sa.hasParam("AILogic")) {
String ailogic = sa.getParam("AILogic");
if (ailogic.equals("Never")) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (ailogic.equals("PhaseOut")) {
if (!ComputerUtil.predictThreatenedObjects(sa.getActivatingPlayer(), sa).contains(sa.getHostCard())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
} else if (ailogic.equals("Bangchuckers")) {
if (ai.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.END_OF_TURN) ) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.resetTargets();
for (Player o : ai.getOpponents()) {
if (sa.canTarget(o) && o.canLoseLife() && !o.cantLoseForZeroOrLessLife()) {
sa.getTargets().add(o);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
for (Card c : ai.getOpponents().getCreaturesInPlay()) {
if (sa.canTarget(c)) {
sa.getTargets().add(c);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
} else if (ailogic.equals("KillOrcs")) {
if (ai.getGame().getPhaseHandler().getPhase().isBefore(PhaseType.END_OF_TURN) ) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
sa.resetTargets();
for (Card c : ai.getOpponents().getCreaturesInPlay()) {
if (sa.canTarget(c)) {
sa.getTargets().add(c);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
return sa.isTargetNumberValid();
if (sa.isTargetNumberValid()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
}
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
return canPlayAI(ai, sa);
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
return canPlay(ai, sa);
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.card.CardCollectionView;
import forge.game.card.CardLists;
@@ -14,26 +16,43 @@ import java.util.Map;
public class FlipOntoBattlefieldAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player aiPlayer, SpellAbility sa) {
PhaseHandler ph = sa.getHostCard().getGame().getPhaseHandler();
String logic = sa.getParamOrDefault("AILogic", "");
if (!isSorcerySpeed(sa, aiPlayer) && sa.getPayCosts().hasManaCost()) {
return ph.is(PhaseType.END_OF_TURN);
if (ph.is(PhaseType.END_OF_TURN)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.WaitForEndOfTurn);
}
}
if ("DamageCreatures".equals(logic)) {
int maxToughness = Integer.parseInt(sa.getSubAbility().getParam("NumDmg"));
CardCollectionView rightToughness = CardLists.filter(aiPlayer.getOpponents().getCreaturesInPlay(), card -> card.getNetToughness() <= maxToughness && card.canBeDestroyed());
return !rightToughness.isEmpty();
if (rightToughness.isEmpty()) {
return new AiAbilityDecision(0, AiPlayDecision.MissingNeededCards);
} else {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
return !aiPlayer.getOpponents().getCardsIn(ZoneType.Battlefield).isEmpty();
if (!aiPlayer.getOpponents().getCardsIn(ZoneType.Battlefield).isEmpty()) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return canPlayAI(aiPlayer, sa) || mandatory;
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
if (mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return canPlay(aiPlayer, sa);
}
@Override

View File

@@ -22,36 +22,36 @@ public class FogAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
final Game game = ai.getGame();
final Card hostCard = sa.getHostCard();
final Combat combat = game.getCombat();
// Don't cast it, if the effect is already in place
if (game.getReplacementHandler().isPreventCombatDamageThisTurn()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// TODO Test if we can even Fog successfully
if (handleMemoryCheck(ai, sa)) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
// Only cast when Stack is empty, so Human uses spells/abilities first
if (!game.getStack().isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// TODO Only cast outside of combat if I won't be able to cast inside of combat
if (combat == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// AI should only activate this during Opponents Declare Blockers phase
if (!game.getPhaseHandler().getPlayerTurn().isOpponentOf(ai) ||
!game.getPhaseHandler().is(PhaseType.COMBAT_DECLARE_BLOCKERS)) {
// TODO Be careful of effects that don't let you cast spells during combat
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
int remainingLife = ComputerUtilCombat.lifeThatWouldRemain(ai, combat);
@@ -61,28 +61,32 @@ public class FogAi extends SpellAbilityAi {
int fogs = countAvailableFogs(ai);
if (fogs > 2 && dmg > 2) {
// Playing a fog deck. If you got them play them.
return true;
return new AiAbilityDecision(100, AiPlayDecision.Tempo);
}
if (dmg > 2 &&
hostCard.hasKeyword(Keyword.BUYBACK) &&
CardLists.count(ai.getCardsIn(ZoneType.Battlefield), Card::isLand) > 3) {
// Constant mists sacrifices a land to buyback. But if AI is running it, they are probably ok sacrificing some lands
return true;
return new AiAbilityDecision(100, AiPlayDecision.Tempo);
}
if ("SeriousDamage".equals(sa.getParam("AILogic"))) {
if (dmg > ai.getLife() / 4) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.Tempo);
} else if (dmg >= 5) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.Tempo);
} else if (ai.getLife() < ai.getStartingLife() / 3) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.Tempo);
}
}
// TODO Compare to poison counters?
// Cast it if life is in danger
return ComputerUtilCombat.lifeInDanger(ai, game.getCombat());
if (ComputerUtilCombat.lifeInDanger(ai, game.getCombat())) {
return new AiAbilityDecision(100, AiPlayDecision.Tempo);
} else {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
private boolean handleMemoryCheck(Player ai, SpellAbility sa) {
@@ -137,7 +141,7 @@ public class FogAi extends SpellAbilityAi {
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
// AI should only activate this during Human's turn
boolean chance;
final Game game = ai.getGame();
@@ -149,11 +153,15 @@ public class FogAi extends SpellAbilityAi {
chance = game.getPhaseHandler().getPhase().isAfter(PhaseType.COMBAT_DAMAGE);
}
return chance;
if (chance) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
final Game game = aiPlayer.getGame();
boolean chance;
if (game.getPhaseHandler().isPlayerTurn(sa.getActivatingPlayer().getWeakestOpponent())) {
@@ -162,6 +170,10 @@ public class FogAi extends SpellAbilityAi {
chance = game.getPhaseHandler().getPhase().isAfter(PhaseType.COMBAT_DAMAGE);
}
return chance || mandatory;
if (mandatory || chance) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

View File

@@ -1,15 +1,17 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
public class GameLossAi extends SpellAbilityAi {
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
final Player opp = ai.getStrongestOpponent();
if (opp.cantLose()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// Only one SA Lose the Game card right now, which is Door to Nothingness
@@ -17,14 +19,14 @@ public class GameLossAi extends SpellAbilityAi {
if (sa.usesTargeting() && sa.canTarget(opp)) {
sa.resetTargets();
sa.getTargets().add(opp);
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
Player loser = ai;
// Phage the Untouchable
@@ -33,7 +35,7 @@ public class GameLossAi extends SpellAbilityAi {
}
if (!mandatory && (loser == ai || loser.cantLose())) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (sa.usesTargeting() && sa.canTarget(loser)) {
@@ -41,6 +43,6 @@ public class GameLossAi extends SpellAbilityAi {
sa.getTargets().add(loser);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -1,6 +1,8 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.SpellAbilityAi;
import forge.game.player.Player;
import forge.game.spellability.SpellAbility;
@@ -10,20 +12,25 @@ public class GameWinAi extends SpellAbilityAi {
* @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
*/
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
return !ai.cantWin();
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
if (ai.cantWin()) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// If the AI can win the game, it should play this ability.
// This is a special case where the AI should always play the ability if it can win.
// TODO Check conditions are met on card (e.g. Coalition Victory)
// TODO Consider likelihood of SA getting countered
return new AiAbilityDecision(10000, AiPlayDecision.WillPlay);
// In general, don't return true.
// But this card wins the game, I can make an exception for that
}
@Override
protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return true;
protected AiAbilityDecision doTriggerNoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -1,8 +1,6 @@
package forge.ai.ability;
import forge.ai.ComputerUtilCard;
import forge.ai.ComputerUtilCombat;
import forge.ai.SpellAbilityAi;
import forge.ai.*;
import forge.game.Game;
import forge.game.card.Card;
import forge.game.card.CardCollection;
@@ -16,7 +14,7 @@ import java.util.List;
public class GoadAi extends SpellAbilityAi {
@Override
protected boolean checkApiLogic(final Player ai, final SpellAbility sa) {
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
final Card source = sa.getHostCard();
final Game game = source.getGame();
@@ -26,7 +24,7 @@ public class GoadAi extends SpellAbilityAi {
List<Card> list = CardLists.getTargetableCards(game.getCardsIn(ZoneType.Battlefield), sa);
if (list.isEmpty())
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
if (game.getPlayers().size() > 2) {
// use this part only in multiplayer
@@ -52,7 +50,7 @@ public class GoadAi extends SpellAbilityAi {
if (!betterList.isEmpty()) {
list = betterList;
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(list));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
} else {
// single Player, goaded creature would attack ai
@@ -73,49 +71,52 @@ public class GoadAi extends SpellAbilityAi {
if (!betterList.isEmpty()) {
list = betterList;
sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(list));
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}
// AI does not find a good creature to goad.
// because if it would goad a creature it would attack AI.
// AI might not have enough information to block it
return false;
return new AiAbilityDecision(0, AiPlayDecision.TargetingFailed);
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
if (checkApiLogic(ai, sa)) {
return true;
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
AiAbilityDecision decision = checkApiLogic(ai, sa);
if (decision.willingToPlay()) {
return decision;
}
if (!mandatory) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
// mandatory play, so we have to play it
if (sa.usesTargeting()) {
if (sa.getTargetRestrictions().canTgtPlayer()) {
for (Player opp : ai.getOpponents()) {
if (sa.canTarget(opp)) {
sa.getTargets().add(opp);
return true;
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
}
if (sa.canTarget(ai)) {
sa.getTargets().add(ai);
return true;
return new AiAbilityDecision(50, AiPlayDecision.MandatoryPlay);
}
} else {
List<Card> list = CardLists.getTargetableCards(ai.getGame().getCardsIn(ZoneType.Battlefield), sa);
if (list.isEmpty())
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
sa.getTargets().add(ComputerUtilCard.getWorstCreatureAI(list));
return true;
return new AiAbilityDecision(30, AiPlayDecision.MandatoryPlay);
}
}
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
}

View File

@@ -1,5 +1,7 @@
package forge.ai.ability;
import forge.ai.AiAbilityDecision;
import forge.ai.AiPlayDecision;
import forge.ai.ComputerUtilCard;
import forge.ai.SpellAbilityAi;
import forge.game.Game;
@@ -15,7 +17,7 @@ import java.util.List;
public class HauntAi extends SpellAbilityAi {
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
final Card card = sa.getHostCard();
final Game game = ai.getGame();
if (sa.usesTargeting() && !card.isToken()) {
@@ -24,12 +26,12 @@ public class HauntAi extends SpellAbilityAi {
// nothing to haunt
if (creats.isEmpty()) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
final List<Card> oppCreats = CardLists.filterControlledBy(creats, ai.getOpponents());
sa.getTargets().add(ComputerUtilCard.getWorstCreatureAI(oppCreats.isEmpty() ? creats : oppCreats));
}
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
}

View File

@@ -10,60 +10,65 @@ public class ImmediateTriggerAi extends SpellAbilityAi {
// TODO: this class is largely reused from DelayedTriggerAi, consider updating
@Override
public boolean chkAIDrawback(SpellAbility sa, Player ai) {
public AiAbilityDecision chkDrawback(SpellAbility sa, Player ai) {
String logic = sa.getParamOrDefault("AILogic", "");
if (logic.equals("Always")) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
SpellAbility trigsa = sa.getAdditionalAbility("Execute");
if (trigsa == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
trigsa.setActivatingPlayer(ai);
if (trigsa instanceof AbilitySub) {
return SpellApiToAi.Converter.get(trigsa).chkDrawbackWithSubs(ai, (AbilitySub)trigsa);
} else {
return AiPlayDecision.WillPlay == ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
}
AiPlayDecision decision = ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
if (decision == AiPlayDecision.WillPlay) {
return new AiAbilityDecision(100, decision);
}
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean doTriggerAINoCost(Player ai, SpellAbility sa, boolean mandatory) {
protected AiAbilityDecision doTriggerNoCost(Player ai, SpellAbility sa, boolean mandatory) {
// always add to stack, targeting happens after payment
if (mandatory) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
SpellAbility trigsa = sa.getAdditionalAbility("Execute");
if (trigsa == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
AiController aic = ((PlayerControllerAi)ai.getController()).getAi();
trigsa.setActivatingPlayer(ai);
return aic.doTrigger(trigsa, !"You".equals(sa.getParamOrDefault("OptionalDecider", "You")));
return aic.doTrigger(trigsa, !"You".equals(sa.getParamOrDefault("OptionalDecider", "You"))) ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
@Override
protected boolean canPlayAI(Player ai, SpellAbility sa) {
protected AiAbilityDecision canPlay(Player ai, SpellAbility sa) {
String logic = sa.getParamOrDefault("AILogic", "");
if (logic.equals("Always")) {
return true;
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}
SpellAbility trigsa = sa.getAdditionalAbility("Execute");
if (trigsa == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
if (logic.equals("WeakerCreature")) {
Card ownCreature = ComputerUtilCard.getWorstCreatureAI(ai.getCreaturesInPlay());
if (ownCreature == null) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
int eval = ComputerUtilCard.evaluateCreature(ownCreature);
@@ -75,12 +80,12 @@ public class ImmediateTriggerAi extends SpellAbilityAi {
}
}
if (!foundWorse) {
return false;
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}
trigsa.setActivatingPlayer(ai);
return AiPlayDecision.WillPlay == ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa);
return ((PlayerControllerAi)ai.getController()).getAi().canPlaySa(trigsa) == AiPlayDecision.WillPlay ? new AiAbilityDecision(100, AiPlayDecision.WillPlay) : new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}
}

Some files were not shown because too many files have changed in this diff Show More