Bestow as Static Effect

.github/workflows/maven-publish.yml

@@ -2,21 +2,10 @@ name: Publish Desktop Forge
 
 on:
   workflow_dispatch:
-    inputs:
-      debug_enabled:
-        type: boolean
-        description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)'
-        required: false
-        default: false
-      release_android:
-        type: boolean
-        description: 'Also try to release android build'
-        required: false
-        default: false
 
 jobs:
   build:
-    if: github.repository_owner == 'Card-Forge'
+
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -43,132 +32,10 @@ jobs:
         run: |
           git config user.email "actions@github.com"
           git config user.name "GitHub Actions"
-
+      - name: Build/Install/Publish to GitHub Packages Apache Maven
-      - name: Install old maven (3.8.1)
-        run: |
-          curl -o apache-maven-3.8.1-bin.tar.gz https://archive.apache.org/dist/maven/maven-3/3.8.1/binaries/apache-maven-3.8.1-bin.tar.gz
-          tar xf apache-maven-3.8.1-bin.tar.gz
-          export PATH=$PWD/apache-maven-3.8.1/bin:$PATH
-          export MAVEN_HOME=$PWD/apache-maven-3.8.1
-          mvn --version    
-
-      - name: Setup tmate session
-        uses: mxschmitt/action-tmate@v3
-        if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
-
-      - name: Setup android requirements
-        if: ${{ github.event_name == 'workflow_dispatch' && inputs.release_android }}
-        run: |
-          JAVA_HOME=${JAVA_HOME_17_X64} ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager --sdk_root=$ANDROID_SDK_ROOT --install "build-tools;35.0.0" "platform-tools" "platforms;android-35"
-          cd forge-gui-android
-          echo "${{ secrets.FORGE_KEYSTORE }}" > forge.keystore.asc
-          gpg -d --passphrase "${{ secrets.FORGE_KEYSTORE_PASSPHRASE }}" --batch forge.keystore.asc > forge.keystore
-          cd -
-          mkdir  -p ~/.m2/repository/com/simpligility/maven/plugins/android-maven-plugin/4.6.2
-          cd ~/.m2/repository/com/simpligility/maven/plugins/android-maven-plugin/4.6.2
-          curl -L -o android-maven-plugin-4.6.2.jar https://github.com/Card-Forge/android-maven-plugin/releases/download/4.6.2/android-maven-plugin-4.6.2.jar
-          curl -L -o android-maven-plugin-4.6.2.pom https://github.com/Card-Forge/android-maven-plugin/releases/download/4.6.2/android-maven-plugin-4.6.2.pom
-          cd -
-          mvn install -Dmaven.test.skip=true
-          mvn dependency:tree
-          
-
-      - name: Build/Install/Publish Desktop to GitHub Packages Apache Maven
-        if: ${{ github.event_name == 'workflow_dispatch' && !inputs.release_android }}
         run: |
           export DISPLAY=":1"
           Xvfb :1 -screen 0 800x600x8 &
-          export _JAVA_OPTIONS="-Xmx2g"
+          mvn -U -B clean -P windows-linux install release:clean release:prepare release:perform -T 1C -Dcardforge-repo.username=${{ secrets.FTP_USERNAME }} -Dcardforge-repo.password=${{ secrets.FTP_PASSWORD }}
-          d=$(date +%m.%d)
-          # build only desktop and only try to move desktop files
-          mvn -U -B clean -P windows-linux install -DskipTests -Dskip.flatten=true -e -T 1C release:clean release:prepare release:perform
-          mkdir izpack
-          # move bz2 and jar from work dir to izpack dir
-          mv /home/runner/work/forge/forge/forge-installer/*/*.{bz2,jar} izpack/
-          # move desktop build.txt and version.txt to izpack
-          mv /home/runner/work/forge/forge/forge-gui-desktop/target/classes/*.txt izpack/
-          cd izpack
-          ls
-          echo "GIT_TAG=`echo $(git describe --tags --abbrev=0)`" >> $GITHUB_ENV
         env:
           GITHUB_TOKEN: ${{ github.token }}
-
-      - name: Build/Install/Publish Desktop+Android to GitHub Packages Apache Maven
-        if: ${{ github.event_name == 'workflow_dispatch' && inputs.release_android }}
-        run: |
-          export DISPLAY=":1"
-          Xvfb :1 -screen 0 800x600x8 &
-          export _JAVA_OPTIONS="-Xmx2g"
-          d=$(date +%m.%d)
-          # build both desktop and android
-          mvn -U -B clean -P windows-linux,android-release-build install -e -Dcardforge-repo.username=${{ secrets.FTP_USERNAME }} -Dcardforge-repo.password=${{ secrets.FTP_PASSWORD }} -Dandroid.sdk.path=/usr/local/lib/android/sdk -Dandroid.buildToolsVersion=35.0.0
-          mkdir izpack
-          # move bz2 and jar from work dir to izpack dir
-          mv /home/runner/work/forge/forge/forge-installer/*/*.{bz2,jar} izpack/
-          # move desktop build.txt and version.txt to izpack
-          mv /home/runner/work/forge/forge/forge-gui-desktop/target/classes/*.txt izpack/
-          # move android apk and assets.zip
-          mv /home/runner/work/forge/forge/forge-gui-android/target/*-signed-aligned.apk izpack/
-          mv /home/runner/work/forge/forge/forge-gui-android/target/assets.zip izpack/
-          cd izpack
-          ls
-          echo "GIT_TAG=`echo $(git describe --tags --abbrev=0)`" >> $GITHUB_ENV
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
-
-      - name: Upload snapshot to GitHub Prerelease
-        uses: ncipollo/release-action@v1
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          name: Release ${{ env.GIT_TAG }}
-          tag: ${{ env.GIT_TAG }}
-          artifacts: izpack/*
-          allowUpdates: true
-          removeArtifacts: true
-          makeLatest: true
-
-      - name: 🔧 Install XML tools
-        run: sudo apt-get install -y libxml2-utils
-
-      - name: 🔼 Bump versionCode in root POM
-        id: bump_version
-        run: |
-          cd /home/runner/work/forge/forge/
-          
-          current_version=$(xmllint --xpath "//*[local-name()='versionCode']/text()" pom.xml)
-          echo "Current versionCode: $current_version"
-
-          IFS='.' read -r major minor patch <<< "${current_version}"
-          new_patch=$(printf "%02d" $((10#$patch + 1)))
-          new_version="${major}.${minor}.${new_patch}"
-
-          sed -i -E "s|<versionCode>.*</versionCode>|<versionCode>${new_version}</versionCode>|" pom.xml
-
-          echo "version_code=${new_version}" >> $GITHUB_OUTPUT
-          
-      - name: ♻️ Restore {revision} in child POMs
-        run: |
-          find . -name pom.xml ! -path "./pom.xml" | while read -r pom; do
-            sed -i -E 's|<version>2\.0+\.[0-9]+(-SNAPSHOT)?</version>|<version>${revision}</version>|' "$pom"
-          done
-
-      - name: 💾 Commit restored {revision}
-        run: |
-          # Add only pom.xml files
-          find . -name pom.xml -exec git add {} \;
-
-          # Commit if there are changes
-          if git diff --cached --quiet; then
-            echo "No pom.xml changes to commit."
-          else
-            git commit -m "Restore POM files for preparation of next release" || echo "No changes to commit"
-            git push
-          fi
-
-      - name: Send failure notification to Discord
-        if: failure() # This step runs only if the job fails
-        run: |
-          curl -X POST -H "Content-Type: application/json" \
-          -d "{\"content\": \"🔴 Release Build Failed in branch: \`${{ github.ref_name }}\` by \`${{ github.actor }}\`.\nCheck logs: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}" \
-          ${{ secrets.DISCORD_AUTOMATION_WEBHOOK }}

.github/workflows/snapshot-both-pc-android.yml

@@ -8,9 +8,6 @@ on:
         description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)'
         required: false
         default: false
-  schedule:
-    # * is a special character in YAML so you have to quote this string
-    - cron:  '00 18 * * *'
 
 jobs:
   build:
@@ -112,21 +109,16 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ github.token }}
 
-      - name: Upload snapshot to GitHub Prerelease
+      - name: 📂 Sync files
-        uses: ncipollo/release-action@v1
+        uses: SamKirkland/FTP-Deploy-Action@v4.3.4
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          name: Daily Snapshot
+          server: ftp.cardforge.org
-          tag: daily-snapshots
+          username: ${{ secrets.FTP_USERNAME }}
-          prerelease: true
+          password: ${{ secrets.FTP_PASSWORD }}
-          artifacts: izpack/*
+          local-dir: izpack/
-          allowUpdates: true
+          server-dir: downloads/dailysnapshots/
-          removeArtifacts: true
+          state-name: .ftp-deploy-both-sync-state.json
-
+          exclude: |
-      - name: Send failure notification to Discord
+            *.pom
-        if: failure() # This step runs only if the job fails
+            *.repositories
-        run: |
+            *.xml
-          curl -X POST -H "Content-Type: application/json" \
-          -d "{\"content\": \"🔴 Snapshot Build Failed in branch: \`${{ github.ref_name }}\` by \`${{ github.actor }}\`.\nCheck logs: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}" \
-          ${{ secrets.DISCORD_AUTOMATION_WEBHOOK }}

.github/workflows/snapshots-android.yml

@@ -13,6 +13,10 @@ on:
         #  description: 'Upload the completed Android package'
         #  required: false
         #  default: true
+  schedule:
+    # * is a special character in YAML so you have to quote this string
+    - cron:  '00 19 * * *'
+          
 
 jobs:
   build:

.github/workflows/snapshots-pc.yml

@@ -8,6 +8,9 @@ on:
         description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)'
         required: false
         default: false
+  schedule:
+    # * is a special character in YAML so you have to quote this string
+    - cron:  '30 18 * * *'
 
 jobs:
   build:

CONTRIBUTING.md

@@ -6,7 +6,7 @@ Dev instructions here: [Getting Started](https://github.com/Card-Forge/forge/wik
 
 ## Requirements / Tools
 
-- your favourite Java IDE (IntelliJ, Eclipse, VSCodium, Emacs, Vi...)
+- you favourite Java IDE (IntelliJ, Eclipse, VSCodium, Emacs, Vi...)
 - Java JDK 17 or later
 - Git
 - Git client (optional)
@@ -22,41 +22,42 @@ Dev instructions here: [Getting Started](https://github.com/Card-Forge/forge/wik
 
 - Clone your forked project to your local machine
 
-- Go to the project location on your machine. Run Maven to download all dependencies and build a snapshot. Example for Windows & Linux: `mvn -U -B clean -P windows-linux install`
+- Go to the project location on your machine.  Run Maven to download all dependencies and build a snapshot.  Example for Windows & Linux: `mvn -U -B clean -P windows-linux install`
 
 ## IntelliJ
 
 IntelliJ is the recommended IDE for Forge development. Quick start guide for [setting up the Forge project within IntelliJ](https://github.com/Card-Forge/forge/wiki/IntelliJ-setup).
 
+
 ## Eclipse
 
-Eclipse includes Maven integration so a separate install is not necessary. For other IDEs, your mileage may vary.
+Eclipse includes Maven integration so a separate install is not necessary.  For other IDEs, your mileage may vary.
 At this time, Eclipse is not the recommended IDE for Forge development.
 
 ### Project Setup
 
-- Follow the instructions for cloning from GitHub. You'll need to setup an account and your SSH key.
+- Follow the instructions for cloning from GitHub.  You'll need to setup an account and your SSH key.
 
-  If you are on a Windows machine you can use Putty with TortoiseGit for SSH keys. Run puttygen.exe to generate the key -- save the private key and export
+  If you are on a Windows machine you can use Putty with TortoiseGit for SSH keys.  Run puttygen.exe to generate the key -- save the private key and export
-  the OpenSSH public key. If you just leave the dialog open, you can copy and paste the key from it to your GitHub profile under
+  the OpenSSH public key.  If you just leave the dialog open, you can copy and paste the key from it to your GitHub profile under
-  "SSH keys". Run pageant.exe and add the private key generated earlier. TortoiseGit will use this for accessing GitHub.
+  "SSH keys".  Run pageant.exe and add the private key generated earlier.  TortoiseGit will use this for accessing GitHub.
 
 - Fork the Forge git repo to your GitHub account.
 
 - Clone your forked repo to your local machine.
 
-- Make sure the Java SDK is installed -- not just the JRE. Java 17 or newer required. If you execute `java -version` at the shell or command prompt, it should report version 17 or later.
+- Make sure the Java SDK is installed -- not just the JRE.  Java 17 or newer required.  If you execute `java -version` at the shell or command prompt, it should report version 17 or later.
 
-- Install Eclipse 2021-12 or later for Java. Launch it.
+- Install Eclipse 2021-12 or later for Java.  Launch it.
 
-- Create a workspace. Go to the workbench. Right-click inside of Package Explorer > Import... > Maven > Existing Maven Projects > Navigate to root path of the local forge repo and
+- Create a workspace.  Go to the workbench.  Right-click inside of Package Explorer > Import... > Maven > Existing Maven Projects > Navigate to root path of the local forge repo and
   ensure everything is checked > Finish.
 
-- Let Eclipse run through building the project. You may be prompted for resolving any missing Maven plugins -- accept the ones offered. You may see errors appear in the "Problems" tab. These should
+- Let Eclipse run through building the project.  You may be prompted for resolving any missing Maven plugins -- accept the ones offered.  You may see errors appear in the "Problems" tab.  These should
-  be automatically resolved as plug-ins are installed and Eclipse continues the build process. If this is the first time for some plug-in installs, Eclipse may prompt you to restart. Do so. Be patient
+  be automatically resolved as plug-ins are installed and Eclipse continues the build process.  If this is the first time for some plug-in installs, Eclipse may prompt you to restart.  Do so.  Be patient
   for this first time through.
 
-- Once everything builds, all errors should disappear. You can now advance to Project launch.
+- Once everything builds, all errors should disappear.  You can now advance to Project launch.
 
 ### Project Launch
 
@@ -66,15 +67,15 @@ This is the standard configuration used for releasing to Windows / Linux / MacOS
 
 - Right-click on forge-gui-desktop > Run As... > Java Application > "Main - forge.view" > Ok
 
-- The familiar Forge splash screen, etc. should appear. Enjoy!
+- The familiar Forge splash screen, etc. should appear.  Enjoy!
 
 #### Mobile (Desktop dev)
 
-This is the configuration used for doing mobile development using the Windows / Linux / MacOS front-end. Knowledge of libgdx is helpful here.
+This is the configuration used for doing mobile development using the Windows / Linux / MacOS front-end.  Knowledge of libgdx is helpful here.
 
 - Right-click on forge-gui-mobile-dev > Run As... > Java Application > "Main - forge.app" > Ok.
 
-- A view similar to a mobile phone should appear. Enjoy!
+- A view similar to a mobile phone should appear.  Enjoy!
 
 ### Eclipse / Android SDK Integration
 
@@ -98,7 +99,7 @@ TBD
 
 #### Android Platform
 
-In Intellij, if the SDK Manager is not already running, go to Tools > Android > Android SDK Manager. Install the following options / versions:
+In Intellij, if the SDK Manager is not already running, go to Tools > Android > Android SDK Manager.  Install the following options / versions:
 
 - Android SDK Build-tools 35.0.0
 - Android 15 (API 35) SDK Platform
@@ -123,11 +124,10 @@ TBD
 
 SNAPSHOT builds can be built via the Maven integration in Eclipse.
 
-1. Create a Maven build for the forge top-level project. Right-click on the forge project. Run as.. > Maven build...
+1) Create a Maven build for the forge top-level project.  Right-click on the forge project.  Run as.. > Maven build...
-
    - On the Main tab, set Goals: clean install, set Profiles: windows-linux
 
-2. Run forge Maven build. If everything built, you should see "BUILD SUCCESS" in the Console View.
+2) Run forge Maven build.  If everything built, you should see "BUILD SUCCESS" in the Console View.
 
 The resulting snapshot will be found at: forge-gui-desktop/target/forge-gui-desktop-[version]-SNAPSHOT
 
@@ -141,7 +141,7 @@ Card scripting resources are found in the forge-gui/res/ path.
 
 ### Project Hierarchy
 
-Forge is divided into 4 primary projects with additional projects that target specific platform releases. The primary projects are:
+Forge is divided into 4 primary projects with additional projects that target specific platform releases.  The primary projects are:
 
 - forge-ai
 - forge-core
@@ -158,38 +158,32 @@ The platform-specific projects are:
 
 #### forge-ai
 
-The forge-ai project contains the computer opponent logic for gameplay. It includes decision-making algorithms for specific abilities, cards and turn phases.
-
 #### forge-core
 
-The forge-core project contains the core game engine, card mechanics, rules engine, and fundamental game logic. It includes the implementation of Magic: The Gathering rules, card interactions, and the game state management system.
-
 #### forge-game
 
-The forge-game project handles the game session management, player interactions, and game flow control. It includes implementations for multiplayer support, game modes, matchmaking, and game state persistence. This module bridges the core game engine with the user interface and networking components.
-
 #### forge-gui
 
-The forge-gui project contains the user interface components and rendering logic for the game. It includes the main game window, card displays, player interactions, and the scripting resource definitions in the res/ path.
+The forge-gui project includes the scripting resource definitions in the res/ path.
 
 #### forge-gui-android
 
-Libgdx-based backend targeting Android. Requires Android SDK and relies on forge-gui-mobile for GUI logic.
+Libgdx-based backend targeting Android.  Requires Android SDK and relies on forge-gui-mobile for GUI logic.
 
 #### forge-gui-desktop
 
 Java Swing based GUI targeting desktop machines.
 
-Screen layout and game logic revolving around the GUI is found here. For example, the overlay arrows (when enabled) that indicate attackers and blockers, or the targets of the stack are defined and drawn by this.
+Screen layout and game logic revolving around the GUI is found here.  For example, the overlay arrows (when enabled) that indicate attackers and blockers, or the targets of the stack are defined and drawn by this.
 
 #### forge-gui-ios
 
-Libgdx-based backend targeting iOS. Relies on forge-gui-mobile for GUI logic.
+Libgdx-based backend targeting iOS.  Relies on forge-gui-mobile for GUI logic.
 
 #### forge-gui-mobile
 
-Mobile GUI game logic utilizing [libgdx](https://libgdx.badlogicgames.com/) library. Screen layout and game logic revolving around the GUI for the mobile platforms is found here.
+Mobile GUI game logic utilizing [libgdx](https://libgdx.badlogicgames.com/) library.  Screen layout and game logic revolving around the GUI for the mobile platforms is found here.
 
 #### forge-gui-mobile-dev
 
-Libgdx backend for desktop development for mobile backends. Utilizes LWJGL. Relies on forge-gui-mobile for GUI logic.
+Libgdx backend for desktop development for mobile backends.  Utilizes LWJGL.  Relies on forge-gui-mobile for GUI logic.

README.md

@@ -26,14 +26,13 @@ Join the **Forge community** on [Discord](https://discord.gg/HcPJNyD66a)!
 
 ### 📥 Desktop Installation
 1. **Latest Releases:** Download the latest version [here](https://github.com/Card-Forge/forge/releases/latest).
-2. **Snapshot Build:** For the latest development version, grab the `forge-gui-desktop` tarball from our [Snapshot Build](https://github.com/Card-Forge/forge/releases/tag/daily-snapshots).
+2. **Snapshot Build:** For the latest development version, grab the `forge-gui-desktop` tarball from our [Snapshot Build](https://downloads.cardforge.org/dailysnapshots/).
    - **Tip:** Extract to a new folder to prevent version conflicts.
 3. **User Data Management:** Previous players’ data is preserved during upgrades.
 4. **Java Requirement:** Ensure you have **Java 17 or later** installed.
 
 ### 📱 Android Installation
-- _(Note: **Android 11** is the minimum requirements with at least **6GB RAM** to run smoothly. You need to enable **"Install unknown apps"** for Forge to initialize and update itself)_
+- Download the **APK** from the [Snapshot Build](https://downloads.cardforge.org/dailysnapshots/). On the first launch, Forge will automatically download all necessary assets.
-- Download the **APK** from the [Snapshot Build](https://github.com/Card-Forge/forge/releases/tag/daily-snapshots). On the first launch, Forge will automatically download all necessary assets.
 
 ---
 

forge-ai/src/main/java/forge/ai/AiAttackController.java

@@ -37,7 +37,6 @@ import forge.game.spellability.SpellAbility;
 import forge.game.spellability.SpellAbilityPredicates;
 import forge.game.staticability.StaticAbility;
 import forge.game.staticability.StaticAbilityAssignCombatDamageAsUnblocked;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.trigger.Trigger;
 import forge.game.trigger.TriggerType;
 import forge.game.zone.ZoneType;
@@ -1588,7 +1587,7 @@ public class AiAttackController {
             // but there are no creatures it can target, no need to exert with it
             boolean missTarget = false;
             for (StaticAbility st : c.getStaticAbilities()) {
-                if (!st.checkMode(StaticAbilityMode.OptionalAttackCost)) {
+                if (!"OptionalAttackCost".equals(st.getParam("Mode"))) {
                     continue;
                 }
                 SpellAbility sa = st.getPayingTrigSA();

forge-ai/src/main/java/forge/ai/AiController.java

@@ -54,7 +54,6 @@ import forge.game.replacement.ReplacementType;
 import forge.game.spellability.*;
 import forge.game.staticability.StaticAbility;
 import forge.game.staticability.StaticAbilityDisableTriggers;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.staticability.StaticAbilityMustTarget;
 import forge.game.trigger.Trigger;
 import forge.game.trigger.TriggerType;
@@ -69,10 +68,8 @@ import java.util.*;
 import java.util.function.Function;
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
+import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 
@@ -295,7 +292,7 @@ public class AiController {
             }
 
             // can't fetch partner isn't problematic
-            if (tr.isKeyword(Keyword.PARTNER)) {
+            if (tr.getKeyword() != null && tr.getKeyword().getOriginal().startsWith("Partner")) {
                 continue;
             }
 
@@ -692,6 +689,7 @@ public class AiController {
                         }
                     }
 
+
                     // TODO handle fetchlands and what they can fetch for
                     // determine new color pips
                     int[] card_counts = new int[6]; // in WUBRGC order
@@ -1130,7 +1128,7 @@ public class AiController {
         // Memory Crystal-like effects need special handling
         for (Card c : game.getCardsIn(ZoneType.Battlefield)) {
             for (StaticAbility s : c.getStaticAbilities()) {
-                if (s.checkMode(StaticAbilityMode.ReduceCost)
+                if ("ReduceCost".equals(s.getParam("Mode"))
                         && "Spell.Buyback".equals(s.getParam("ValidSpell"))) {
                     neededMana -= AbilityUtils.calculateAmount(c, s.getParam("Amount"), s);
                 }
@@ -1710,8 +1708,7 @@ public class AiController {
             Sentry.captureMessage(ex.getMessage() + "\nAssertionError [verifyTransitivity]: " + assertex);
         }
 
-        final ExecutorService executor = Executors.newSingleThreadExecutor();
+        CompletableFuture<SpellAbility> future = CompletableFuture.supplyAsync(() -> {
-        Future<SpellAbility> future = executor.submit(() -> {
             //avoid ComputerUtil.aiLifeInDanger in loops as it slows down a lot.. call this outside loops will generally be fast...
             boolean isLifeInDanger = useLivingEnd && ComputerUtil.aiLifeInDanger(player, true, 0);
             for (final SpellAbility sa : ComputerUtilAbility.getOriginalAndAltCostAbilities(all, player)) {
@@ -1791,9 +1788,11 @@ public class AiController {
 
         // instead of computing all available concurrently just add a simple timeout depending on the user prefs
         try {
-            return future.get(game.getAITimeout(), TimeUnit.SECONDS);
+            if (game.AI_CAN_USE_TIMEOUT)
+                return future.completeOnTimeout(null, game.getAITimeout(), TimeUnit.SECONDS).get();
+            else
+                return future.get(game.getAITimeout(), TimeUnit.SECONDS);
         } catch (InterruptedException | ExecutionException | TimeoutException e) {
-            future.cancel(true);
             return null;
         }
     }
@@ -2369,7 +2368,7 @@ public class AiController {
 
     // TODO move to more common place
     public static <T extends TriggerReplacementBase> List<T> filterList(List<T> input, Function<SpellAbility, Object> pred, Object value) {
-        return filterList(input, trb -> trb.ensureAbility() != null && pred.apply(trb.ensureAbility()) == value);
+        return filterList(input, trb -> pred.apply(trb.ensureAbility()) == value);
     }
 
     public static List<SpellAbility> filterListByApi(List<SpellAbility> input, ApiType type) {

forge-ai/src/main/java/forge/ai/AiCostDecision.java

@@ -46,14 +46,6 @@ public class AiCostDecision extends CostDecisionMakerBase {
         return PaymentDecision.number(c);
     }
 
-    @Override
-    public PaymentDecision visit(CostBehold cost) {
-        final String type = cost.getType();
-        CardCollectionView hand = player.getCardsIn(cost.getRevealFrom());
-        hand = CardLists.getValidCards(hand, type.split(";"), player, source, ability);
-        return hand.isEmpty() ? null : PaymentDecision.card(getBestCreatureAI(hand));
-    }
-
     @Override
     public PaymentDecision visit(CostChooseColor cost) {
         int c = cost.getAbilityAmount(ability);

forge-ai/src/main/java/forge/ai/ComputerUtil.java

@@ -48,7 +48,6 @@ import forge.game.spellability.SpellAbility;
 import forge.game.spellability.SpellAbilityStackInstance;
 import forge.game.spellability.TargetRestrictions;
 import forge.game.staticability.StaticAbility;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.trigger.Trigger;
 import forge.game.trigger.TriggerType;
 import forge.game.trigger.WrappedAbility;
@@ -1100,11 +1099,6 @@ public class ComputerUtil {
             }
         }
 
-        // if AI has no speed, play start your engines on Main1
-        if (ai.noSpeed() && cardState.hasKeyword(Keyword.START_YOUR_ENGINES)) {
-            return true;
-        }
-
         // cast Blitz in main 1 if the creature attacks
         if (sa.isBlitz() && ComputerUtilCard.doesSpecifiedCreatureAttackAI(ai, card)) {
             return true;
@@ -1459,14 +1453,15 @@ public class ComputerUtil {
         // check for Continuous abilities that grant Haste
         for (final Card c : all) {
             for (StaticAbility stAb : c.getStaticAbilities()) {
-                if (stAb.checkMode(StaticAbilityMode.Continuous) && stAb.hasParam("AddKeyword")
+                Map<String, String> params = stAb.getMapParams();
-                        && stAb.getParam("AddKeyword").contains("Haste")) {
+                if ("Continuous".equals(params.get("Mode")) && params.containsKey("AddKeyword")
+                        && params.get("AddKeyword").contains("Haste")) {
 
                     if (c.isEquipment() && c.getEquipping() == null) {
                         return true;
                     }
 
-                    final String affected = stAb.getParam("Affected");
+                    final String affected = params.get("Affected");
                     if (affected.contains("Creature.YouCtrl")
                             || affected.contains("Other+YouCtrl")) {
                         return true;
@@ -1519,10 +1514,11 @@ public class ComputerUtil {
 
             for (final Card c : opp) {
                 for (StaticAbility stAb : c.getStaticAbilities()) {
-                    if (stAb.checkMode(StaticAbilityMode.Continuous) && stAb.hasParam("AddKeyword")
+                    Map<String, String> params = stAb.getMapParams();
-                            && stAb.getParam("AddKeyword").contains("Haste")) {
+                    if ("Continuous".equals(params.get("Mode")) && params.containsKey("AddKeyword")
+                            && params.get("AddKeyword").contains("Haste")) {
 
-                        final ArrayList<String> affected = Lists.newArrayList(stAb.getParam("Affected").split(","));
+                        final ArrayList<String> affected = Lists.newArrayList(params.get("Affected").split(","));
                         if (affected.contains("Creature")) {
                             return true;
                         }
@@ -2428,7 +2424,7 @@ public class ComputerUtil {
                 // Are we picking a type to reduce costs for that type?
                 boolean reducingCost = false;
                 for (StaticAbility s : sa.getHostCard().getStaticAbilities()) {
-                    if (s.checkMode(StaticAbilityMode.ReduceCost) && "Card.ChosenType".equals(s.getParam("ValidCard"))) {
+                    if ("ReduceCost".equals(s.getParam("Mode")) && "Card.ChosenType".equals(s.getParam("ValidCard"))) {
                         reducingCost = true;
                         break;
                     }
@@ -2890,7 +2886,7 @@ public class ComputerUtil {
                 // Iceberg does use Ice as Storage
                 || (type.is(CounterEnumType.ICE) && !"Iceberg".equals(c.getName()))
                 // some lands does use Depletion as Storage Counter
-                || (type.is(CounterEnumType.DEPLETION) && c.getReplacementEffects().anyMatch(r -> r.getMode().equals(ReplacementType.Untap) && r.getLayer().equals(ReplacementLayer.CantHappen)))
+                || (type.is(CounterEnumType.DEPLETION) && c.hasKeyword("CARDNAME doesn't untap during your untap step."))
                 // treat Time Counters on suspended Cards as Bad,
                 // and also on Chronozoa
                 || (type.is(CounterEnumType.TIME) && (!c.isInPlay() || "Chronozoa".equals(c.getName())))

forge-ai/src/main/java/forge/ai/ComputerUtilCard.java

@@ -48,7 +48,6 @@ import forge.game.replacement.ReplacementEffect;
 import forge.game.replacement.ReplacementLayer;
 import forge.game.spellability.SpellAbility;
 import forge.game.staticability.StaticAbility;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.trigger.Trigger;
 import forge.game.zone.MagicStack;
 import forge.game.zone.ZoneType;
@@ -692,8 +691,6 @@ public class ComputerUtilCard {
     public static boolean canBeBlockedProfitably(final Player ai, Card attacker, boolean checkingOther) {
         AiBlockController aiBlk = new AiBlockController(ai, checkingOther);
         Combat combat = new Combat(ai);
-        // avoid removing original attacker
-        attacker.setCombatLKI(null);
         combat.addAttacker(attacker, ai);
         final List<Card> attackers = Lists.newArrayList(attacker);
         aiBlk.assignBlockersGivenAttackers(combat, attackers);
@@ -1214,7 +1211,8 @@ public class ComputerUtilCard {
                 // if this thing is both owned and controlled by an opponent and it has a continuous ability,
                 // assume it either benefits the player or disrupts the opponent
                 for (final StaticAbility stAb : c.getStaticAbilities()) {
-                    if (stAb.checkMode(StaticAbilityMode.Continuous) && stAb.isIntrinsic()) {
+                    final Map<String, String> params = stAb.getMapParams();
+                    if (params.get("Mode").equals("Continuous") && stAb.isIntrinsic()) {
                         priority = true;
                         break;
                     }
@@ -1245,16 +1243,17 @@ public class ComputerUtilCard {
             }
         } else {
             for (final StaticAbility stAb : c.getStaticAbilities()) {
+                final Map<String, String> params = stAb.getMapParams();
                 //continuous buffs
-                if (stAb.checkMode(StaticAbilityMode.Continuous) && "Creature.YouCtrl".equals(stAb.getParam("Affected"))) {
+                if (params.get("Mode").equals("Continuous") && "Creature.YouCtrl".equals(params.get("Affected"))) {
                     int bonusPT = 0;
-                    if (stAb.hasParam("AddPower")) {
+                    if (params.containsKey("AddPower")) {
-                        bonusPT += AbilityUtils.calculateAmount(c, stAb.getParam("AddPower"), stAb);
+                        bonusPT += AbilityUtils.calculateAmount(c, params.get("AddPower"), stAb);
                     }
-                    if (stAb.hasParam("AddToughness")) {
+                    if (params.containsKey("AddToughness")) {
-                        bonusPT += AbilityUtils.calculateAmount(c, stAb.getParam("AddPower"), stAb);
+                        bonusPT += AbilityUtils.calculateAmount(c, params.get("AddPower"), stAb);
                     }
-                    String kws = stAb.getParam("AddKeyword");
+                    String kws = params.get("AddKeyword");
                     if (kws != null) {
                         bonusPT += 4 * (1 + StringUtils.countMatches(kws, "&")); //treat each added keyword as a +2/+2 for now
                     }
@@ -1785,7 +1784,7 @@ public class ComputerUtilCard {
             // remove old boost that might be copied
             for (final StaticAbility stAb : c.getStaticAbilities()) {
                 vCard.removePTBoost(c.getLayerTimestamp(), stAb.getId());
-                if (!stAb.checkMode(StaticAbilityMode.Continuous)) {
+                if (!stAb.checkMode("Continuous")) {
                     continue;
                 }
                 if (!stAb.hasParam("Affected")) {
@@ -1863,7 +1862,7 @@ public class ComputerUtilCard {
         if (!c.isCreature()) {
             return false;
         }
-        if (c.hasKeyword("CARDNAME can't attack or block.") || (c.isTapped() && !c.canUntap(ai, true)) || (c.getOwner() == ai && ai.getOpponents().contains(c.getController()))) {
+        if (c.hasKeyword("CARDNAME can't attack or block.") || (c.hasKeyword("CARDNAME doesn't untap during your untap step.") && c.isTapped()) || (c.getOwner() == ai && ai.getOpponents().contains(c.getController()))) {
             return true;
         }
         return false;

forge-ai/src/main/java/forge/ai/ComputerUtilCombat.java

@@ -31,7 +31,7 @@ import forge.game.combat.Combat;
 import forge.game.combat.CombatUtil;
 import forge.game.cost.CostPayment;
 import forge.game.keyword.Keyword;
-import forge.game.phase.PhaseType;
+import forge.game.phase.Untap;
 import forge.game.player.Player;
 import forge.game.replacement.ReplacementEffect;
 import forge.game.replacement.ReplacementLayer;
@@ -39,7 +39,6 @@ import forge.game.replacement.ReplacementType;
 import forge.game.spellability.SpellAbility;
 import forge.game.staticability.StaticAbility;
 import forge.game.staticability.StaticAbilityAssignCombatDamageAsUnblocked;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.staticability.StaticAbilityMustAttack;
 import forge.game.trigger.Trigger;
 import forge.game.trigger.TriggerType;
@@ -102,7 +101,7 @@ public class ComputerUtilCombat {
             return false;
         }
 
-        if (attacker.getGame().getReplacementHandler().wouldPhaseBeSkipped(attacker.getController(), PhaseType.COMBAT_BEGIN)) {
+        if (attacker.getGame().getReplacementHandler().wouldPhaseBeSkipped(attacker.getController(), "BeginCombat")) {
             return false;
         }
 
@@ -119,7 +118,7 @@ public class ComputerUtilCombat {
         //        || (attacker.hasKeyword(Keyword.FADING) && attacker.getCounters(CounterEnumType.FADE) == 0)
         //        || attacker.hasSVar("EndOfTurnLeavePlay"));
         // The creature won't untap next turn
-        return !attacker.isTapped() || (attacker.getCounters(CounterEnumType.STUN) == 0 && attacker.canUntap(attacker.getController(), true));
+        return !attacker.isTapped() || (attacker.getCounters(CounterEnumType.STUN) == 0 && Untap.canUntap(attacker));
     }
 
     /**
@@ -215,7 +214,7 @@ public class ComputerUtilCombat {
         int damage = attacker.getNetCombatDamage();
         int poison = 0;
         damage += predictPowerBonusOfAttacker(attacker, null, null, false);
-        if (attacker.isInfectDamage(attacked)) {
+        if (attacker.hasKeyword(Keyword.INFECT)) {
             int pd = predictDamageTo(attacked, damage, attacker, true);
             // opponent can always order it so that he gets 0
             if (pd == 1 && attacker.getController().getOpponents().getCardsIn(ZoneType.Battlefield).anyMatch(CardPredicates.nameEquals("Vorinclex, Monstrous Raider"))) {
@@ -358,7 +357,7 @@ public class ComputerUtilCombat {
             } else if (attacker.hasKeyword(Keyword.TRAMPLE)) {
                 int trampleDamage = getAttack(attacker) - totalShieldDamage(attacker, blockers);
                 if (trampleDamage > 0) {
-                    if (attacker.isInfectDamage(ai)) {
+                    if (attacker.hasKeyword(Keyword.INFECT)) {
                         poison += trampleDamage;
                     }
                     poison += predictExtraPoisonWithDamage(attacker, ai, trampleDamage);
@@ -901,7 +900,7 @@ public class ComputerUtilCombat {
         final CardCollectionView cardList = CardCollection.combine(game.getCardsIn(ZoneType.Battlefield), game.getCardsIn(ZoneType.Command));
         for (final Card card : cardList) {
             for (final StaticAbility stAb : card.getStaticAbilities()) {
-                if (!stAb.checkMode(StaticAbilityMode.Continuous)) {
+                if (!stAb.checkMode("Continuous")) {
                     continue;
                 }
                 if (!stAb.hasParam("Affected") || !stAb.getParam("Affected").contains("blocking")) {
@@ -1197,7 +1196,7 @@ public class ComputerUtilCombat {
             final CardCollectionView cardList = CardCollection.combine(game.getCardsIn(ZoneType.Battlefield), game.getCardsIn(ZoneType.Command));
             for (final Card card : cardList) {
                 for (final StaticAbility stAb : card.getStaticAbilities()) {
-                    if (!stAb.checkMode(StaticAbilityMode.Continuous)) {
+                    if (!stAb.checkMode("Continuous")) {
                         continue;
                     }
                     if (!stAb.hasParam("Affected") || !stAb.getParam("Affected").contains("attacking")) {
@@ -1388,7 +1387,7 @@ public class ComputerUtilCombat {
             final CardCollectionView cardList = game.getCardsIn(ZoneType.Battlefield);
             for (final Card card : cardList) {
                 for (final StaticAbility stAb : card.getStaticAbilities()) {
-                    if (!stAb.checkMode(StaticAbilityMode.Continuous)) {
+                    if (!"Continuous".equals(stAb.getParam("Mode"))) {
                         continue;
                     }
                     if (!stAb.hasParam("Affected")) {
@@ -1735,7 +1734,6 @@ public class ComputerUtilCombat {
         final int attackerLife = getDamageToKill(attacker, false)
                 + predictToughnessBonusOfAttacker(attacker, blocker, combat, withoutAbilities, withoutAttackerStaticAbilities);
 
-        // AI should be less worried about Deathtouch
         if (blocker.hasDoubleStrike()) {
             if (defenderDamage > 0 && (hasKeyword(blocker, "Deathtouch", withoutAbilities, combat) || attacker.hasSVar("DestroyWhenDamaged"))) {
                 return true;
@@ -1965,7 +1963,6 @@ public class ComputerUtilCombat {
         final int attackerLife = getDamageToKill(attacker, false)
                 + predictToughnessBonusOfAttacker(attacker, blocker, combat, withoutAbilities, withoutAttackerStaticAbilities);
 
-        // AI should be less worried about deathtouch
         if (attacker.hasDoubleStrike()) {
             if (attackerDamage >= defenderLife) {
                 return true;

forge-ai/src/main/java/forge/ai/ComputerUtilCost.java

@@ -608,7 +608,7 @@ public class ComputerUtilCost {
         }
 
         return ComputerUtilMana.canPayManaCost(cost, sa, player, extraManaNeeded, effect)
-                && CostPayment.canPayAdditionalCosts(cost, sa, effect, player);
+                && CostPayment.canPayAdditionalCosts(cost, sa, effect);
     }
 
     public static Set<String> getAvailableManaColors(Player ai, Card additionalLand) {

forge-ai/src/main/java/forge/ai/ComputerUtilMana.java

@@ -158,7 +158,7 @@ public class ComputerUtilMana {
                 }
 
                 // Mana abilities on the same card
-                String shardMana = shard.toShortString();
+                String shardMana = shard.toString().replaceAll("\\{", "").replaceAll("\\}", "");
 
                 boolean payWithAb1 = ability1.getManaPart().mana(ability1).contains(shardMana);
                 boolean payWithAb2 = ability2.getManaPart().mana(ability2).contains(shardMana);
@@ -642,28 +642,24 @@ public class ComputerUtilMana {
         List<SpellAbility> paymentList = Lists.newArrayList();
         final ManaPool manapool = ai.getManaPool();
 
-        // Apply color/type conversion matrix if necessary (already done via autopay)
+        // Apply the color/type conversion matrix if necessary
-        if (ai.getControllingPlayer() == null) {
+        manapool.restoreColorReplacements();
-            manapool.restoreColorReplacements();
+        CardPlayOption mayPlay = sa.getMayPlayOption();
-            CardPlayOption mayPlay = sa.getMayPlayOption();
+        if (!effect) {
-            if (!effect) {
+            if (sa.isSpell() && mayPlay != null) {
-                if (sa.isSpell() && mayPlay != null) {
+                mayPlay.applyManaConvert(manapool);
-                    mayPlay.applyManaConvert(manapool);
+            } else if (sa.isActivatedAbility() && sa.getGrantorStatic() != null && sa.getGrantorStatic().hasParam("ManaConversion")) {
-                } else if (sa.isActivatedAbility() && sa.getGrantorStatic() != null && sa.getGrantorStatic().hasParam("ManaConversion")) {
+                AbilityUtils.applyManaColorConversion(manapool, sa.getGrantorStatic().getParam("ManaConversion"));
-                    AbilityUtils.applyManaColorConversion(manapool, sa.getGrantorStatic().getParam("ManaConversion"));
-                }
             }
-            if (sa.hasParam("ManaConversion")) {
-                AbilityUtils.applyManaColorConversion(manapool, sa.getParam("ManaConversion"));
-            }
-            StaticAbilityManaConvert.manaConvert(manapool, ai, sa.getHostCard(), effect && !sa.isCastFromPlayEffect() ? null : sa);
         }
+        if (sa.hasParam("ManaConversion")) {
+            AbilityUtils.applyManaColorConversion(manapool, sa.getParam("ManaConversion"));
+        }
+        StaticAbilityManaConvert.manaConvert(manapool, ai, sa.getHostCard(), effect && !sa.isCastFromPlayEffect() ? null : sa);
 
-        // not worth checking if it makes sense to not spend floating first
         if (manapool.payManaCostFromPool(cost, sa, test, manaSpentToPay)) {
             CostPayment.handleOfferings(sa, test, cost.isPaid());
-            // paid all from floating mana
+            return true;    // paid all from floating mana
-            return true;
         }
 
         boolean purePhyrexian = cost.containsOnlyPhyrexianMana();

forge-ai/src/main/java/forge/ai/CreatureEvaluator.java

@@ -160,6 +160,12 @@ public class CreatureEvaluator implements Function<Card, Integer> {
             value += addValue(20, "protection");
         }
 
+        for (final SpellAbility sa : c.getSpellAbilities()) {
+            if (sa.isAbility()) {
+                value += addValue(evaluateSpellAbility(sa), "sa: " + sa);
+            }
+        }
+
         // paired creatures are more valuable because they grant a bonus to the other creature
         if (c.isPaired()) {
             value += addValue(14, "paired");
@@ -207,7 +213,11 @@ public class CreatureEvaluator implements Function<Card, Integer> {
             value += addValue(1, "untapped");
         }
 
-        if (!c.canUntap(c.getController(), true)) {
+        if (!c.getManaAbilities().isEmpty()) {
+            value += addValue(10, "manadork");
+        }
+
+        if (c.hasKeyword("CARDNAME doesn't untap during your untap step.")) {
             if (c.isTapped()) {
                 value = addValue(50 + (c.getCMC() * 5), "tapped-useless"); // reset everything - useless
             } else {
@@ -216,17 +226,6 @@ public class CreatureEvaluator implements Function<Card, Integer> {
         } else {
             value -= subValue(10 * c.getCounters(CounterEnumType.STUN), "stunned");
         }
-
-        for (final SpellAbility sa : c.getSpellAbilities()) {
-            if (sa.isAbility()) {
-                value += addValue(evaluateSpellAbility(sa), "sa: " + sa);
-            }
-        }
-
-        if (!c.getManaAbilities().isEmpty()) {
-            value += addValue(10, "manadork");
-        }
-
         // use scaling because the creature is only available halfway
         if (c.hasKeyword(Keyword.PHASING)) {
             value -= subValue(Math.max(20, value / 2), "phasing");

forge-ai/src/main/java/forge/ai/GameState.java

@@ -13,7 +13,6 @@ import forge.card.mana.ManaAtom;
 import forge.game.Game;
 import forge.game.GameEntity;
 import forge.game.ability.AbilityFactory;
-import forge.game.ability.ApiType;
 import forge.game.ability.effects.DetachedCardEffect;
 import forge.game.card.*;
 import forge.game.card.token.TokenInfo;
@@ -1306,10 +1305,10 @@ public abstract class GameState {
                 } else if (info.startsWith("FaceDown")) {
                     c.turnFaceDown(true);
                     if (info.endsWith("Manifested")) {
-                        c.setManifested(new SpellAbility.EmptySa(ApiType.Manifest, c));
+                        c.setManifested(true);
                     }
                     if (info.endsWith("Cloaked")) {
-                        c.setCloaked(new SpellAbility.EmptySa(ApiType.Cloak, c));
+                        c.setCloaked(true);
                     }
                 } else if (info.startsWith("Transformed")) {
                     c.setState(CardStateName.Transformed, true);
@@ -1409,7 +1408,7 @@ public abstract class GameState {
                 } else if (info.equals("Foretold")) {
                     c.setForetold(true);
                     c.turnFaceDown(true);
-                    c.addMayLookFaceDownExile(c.getOwner());
+                    c.addMayLookTemp(c.getOwner());
                 } else if (info.equals("ForetoldThisTurn")) {
                     c.setTurnInZone(turn);
                 } else if (info.equals("IsToken")) {

forge-ai/src/main/java/forge/ai/PlayerControllerAi.java

@@ -15,7 +15,6 @@ import forge.game.*;
 import forge.game.ability.AbilityUtils;
 import forge.game.ability.ApiType;
 import forge.game.ability.effects.CharmEffect;
-import forge.game.ability.effects.RollDiceEffect;
 import forge.game.card.*;
 import forge.game.combat.Combat;
 import forge.game.cost.Cost;
@@ -746,30 +745,6 @@ public class PlayerControllerAi extends PlayerController {
         return Aggregates.random(rolls);
     }
 
-    @Override
-    public List<Integer> chooseDiceToReroll(List<Integer> rolls) {
-        //TODO create AI logic for this
-        return new ArrayList<>();
-    }
-
-    @Override
-    public Integer chooseRollToModify(List<Integer> rolls) {
-        //TODO create AI logic for this
-        return Aggregates.random(rolls);
-    }
-
-    @Override
-    public RollDiceEffect.DieRollResult chooseRollToSwap(List<RollDiceEffect.DieRollResult> rolls) {
-        //TODO create AI logic for this
-        return Aggregates.random(rolls);
-    }
-
-    @Override
-    public String chooseRollSwapValue(List<String> swapChoices, Integer currentResult, int power, int toughness) {
-        //TODO create AI logic for this
-        return Aggregates.random(swapChoices);
-    }
-
     @Override
     public boolean mulliganKeepHand(Player firstPlayer, int cardsToReturn)  {
         return !ComputerUtil.wantMulligan(player, cardsToReturn);
@@ -1232,11 +1207,6 @@ public class PlayerControllerAi extends PlayerController {
         return false;
     }
 
-    public boolean payCostDuringRoll(final Cost cost, final SpellAbility sa, final FCollectionView<Player> allPayers) {
-        // TODO logic for AI to pay rerolls and modification costs
-        return false;
-    }
-
     @Override
     public void orderAndPlaySimultaneousSa(List<SpellAbility> activePlayerSAs) {
         for (final SpellAbility sa : getAi().orderPlaySa(activePlayerSAs)) {
@@ -1419,11 +1389,11 @@ public class PlayerControllerAi extends PlayerController {
                 oppLibrary = CardLists.getValidCards(oppLibrary, valid, source.getController(), source, sa);
             }
 
-            if (source != null && source.getState(CardStateName.Original).hasKeyword(Keyword.HIDDEN_AGENDA)) {
+            if (source != null && source.getState(CardStateName.Original).hasIntrinsicKeyword("Hidden agenda")) {
                 // If any Conspiracies are present, try not to choose the same name twice
                 // (otherwise the AI will spam the same name)
                 for (Card consp : player.getCardsIn(ZoneType.Command)) {
-                    if (consp.getState(CardStateName.Original).hasKeyword(Keyword.HIDDEN_AGENDA)) {
+                    if (consp.getState(CardStateName.Original).hasIntrinsicKeyword("Hidden agenda")) {
                         String chosenName = consp.getNamedCard();
                         if (!chosenName.isEmpty()) {
                             aiLibrary = CardLists.filter(aiLibrary, CardPredicates.nameNotEquals(chosenName));

forge-ai/src/main/java/forge/ai/SpecialCardAi.java

@@ -359,28 +359,18 @@ public class SpecialCardAi {
         private static final int demonSacThreshold = Integer.MAX_VALUE; // if we're in dire conditions, sac everything from worst to best hoping to find an answer
 
         public static boolean considerSacrificingCreature(final Player ai, final SpellAbility sa) {
-            Card c = sa.getHostCard();
-
-            // Only check for sacrifice if it's the owner's turn, and it can attack.
-            // TODO: Maybe check if sacrificing a creature allows AI to kill the opponent with the rest on their turn?
-            if (!CombatUtil.canAttack(c) ||
-                !ai.getGame().getPhaseHandler().isPlayerTurn(sa.getActivatingPlayer())) {
-                return false;
-            }
-
             CardCollection flyingCreatures = CardLists.filter(ai.getCardsIn(ZoneType.Battlefield),
-                CardPredicates.UNTAPPED.and(
+                    CardPredicates.UNTAPPED.and(
-                    CardPredicates.hasKeyword(Keyword.FLYING).or(CardPredicates.hasKeyword(Keyword.REACH))));
+                            CardPredicates.hasKeyword(Keyword.FLYING).or(CardPredicates.hasKeyword(Keyword.REACH))));
             boolean hasUsefulBlocker = false;
 
-            for (Card fc : flyingCreatures) {
+            for (Card c : flyingCreatures) {
-                if (!ComputerUtilCard.isUselessCreature(ai, fc)) {
+                if (!ComputerUtilCard.isUselessCreature(ai, c)) {
                     hasUsefulBlocker = true;
-                    break;
                 }
             }
 
-            return ai.getLife() <= c.getNetPower() && !hasUsefulBlocker;
+            return ai.getLife() <= sa.getHostCard().getNetPower() && !hasUsefulBlocker;
         }
         
         public static int getSacThreshold() {
@@ -1479,7 +1469,6 @@ public class SpecialCardAi {
             if (best != null) {
                 sa.resetTargets();
                 sa.getTargets().add(best);
-                sa.setXManaCostPaid(best.getCMC());
                 return true;
             }
 

forge-ai/src/main/java/forge/ai/SpellAbilityAi.java

@@ -4,6 +4,8 @@ import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 
+import org.apache.commons.lang3.ObjectUtils;
+
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
 
@@ -51,13 +53,18 @@ public abstract class SpellAbilityAi {
      * Handles the AI decision to play a "main" SpellAbility
      */
     protected boolean canPlayAI(final Player ai, final SpellAbility sa) {
-        final Card source = sa.getHostCard();
+        Card source = sa.getHostCard();
+        try {
+            source = ObjectUtils.firstNonNull(sa.getAlternateHost(source), source);
 
-        if (sa.getRestrictions() != null && !sa.getRestrictions().canPlay(source, sa)) {
+            if (sa.getRestrictions() != null && !sa.getRestrictions().canPlay(source, sa)) {
-            return false;
+                return false;
+            }
+
+            return canPlayWithoutRestrict(ai, sa);
+        } finally {
+            sa.undoAlternateHost(source);
         }
-
-        return canPlayWithoutRestrict(ai, sa);
     }
 
     protected boolean canPlayWithoutRestrict(final Player ai, final SpellAbility sa) {
@@ -258,7 +265,7 @@ public abstract class SpellAbilityAi {
     protected static boolean isSorcerySpeed(final SpellAbility sa, Player ai) {
         return (sa.getRootAbility().isSpell() && sa.getHostCard().isSorcery())
             || (sa.getRootAbility().isActivatedAbility() && sa.getRootAbility().getRestrictions().isSorcerySpeed())
-            || (sa.getRootAbility().isAdventure() && sa.getHostCard().getState(CardStateName.Secondary).getType().isSorcery())
+            || (sa.getRootAbility().isAdventure() && sa.getHostCard().getState(CardStateName.Adventure).getType().isSorcery())
             || (sa.isPwAbility() && !sa.withFlash(sa.getHostCard(), ai));
     }
 

forge-ai/src/main/java/forge/ai/SpellApiToAi.java

@@ -88,7 +88,6 @@ public enum SpellApiToAi {
             .put(ApiType.EachDamage, DamageEachAi.class)
             .put(ApiType.Effect, EffectAi.class)
             .put(ApiType.Encode, EncodeAi.class)
-            .put(ApiType.Endure, EndureAi.class)
             .put(ApiType.EndCombatPhase, EndTurnAi.class)
             .put(ApiType.EndTurn, EndTurnAi.class)
             .put(ApiType.ExchangeLife, LifeExchangeAi.class)

forge-ai/src/main/java/forge/ai/ability/AnimateAi.java

@@ -24,7 +24,6 @@ import forge.game.spellability.SpellAbility;
 import forge.game.staticability.StaticAbility;
 import forge.game.staticability.StaticAbilityContinuous;
 import forge.game.staticability.StaticAbilityLayer;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.zone.ZoneType;
 import forge.util.FileSection;
 import forge.util.collect.FCollectionView;
@@ -563,7 +562,7 @@ public class AnimateAi extends SpellAbilityAi {
         CardTraitChanges traits = card.getChangedCardTraits().get(timestamp, 0);
         if (traits != null) {
             for (StaticAbility stAb : traits.getStaticAbilities()) {
-                if (stAb.checkMode(StaticAbilityMode.Continuous)) {
+                if ("Continuous".equals(stAb.getParam("Mode"))) {
                     for (final StaticAbilityLayer layer : stAb.getLayers()) {
                         StaticAbilityContinuous.applyContinuousAbility(stAb, new CardCollection(card), layer);
                     }

forge-ai/src/main/java/forge/ai/ability/AttachAi.java

@@ -15,23 +15,20 @@ import forge.game.cost.Cost;
 import forge.game.cost.CostPart;
 import forge.game.cost.CostSacrifice;
 import forge.game.keyword.Keyword;
-import forge.game.keyword.KeywordInterface;
 import forge.game.phase.PhaseHandler;
 import forge.game.phase.PhaseType;
 import forge.game.player.Player;
 import forge.game.player.PlayerActionConfirmMode;
-import forge.game.replacement.ReplacementLayer;
-import forge.game.replacement.ReplacementType;
 import forge.game.spellability.SpellAbility;
 import forge.game.spellability.TargetRestrictions;
 import forge.game.staticability.StaticAbility;
 import forge.game.staticability.StaticAbilityCantAttackBlock;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.trigger.Trigger;
 import forge.game.trigger.TriggerType;
 import forge.game.zone.ZoneType;
 import forge.util.Aggregates;
 import forge.util.MyRandom;
+import org.apache.commons.lang3.ObjectUtils;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -75,7 +72,7 @@ public class AttachAi extends SpellAbilityAi {
 
         // prevent run-away activations - first time will always return true
         if (ComputerUtil.preventRunAwayActivations(sa)) {
-            return false;
+        	return false;
         }
 
         // Attach spells always have a target
@@ -133,7 +130,7 @@ public class AttachAi extends SpellAbilityAi {
         int power = 0, toughness = 0;
         List<String> keywords = Lists.newArrayList();
         for (StaticAbility stAb : source.getStaticAbilities()) {
-            if (stAb.checkMode(StaticAbilityMode.Continuous)) {
+            if ("Continuous".equals(stAb.getParam("Mode"))) {
                 if (stAb.hasParam("AddPower")) {
                     power += AbilityUtils.calculateAmount(source, stAb.getParam("AddPower"), stAb);
                 }
@@ -310,8 +307,9 @@ public class AttachAi extends SpellAbilityAi {
         String type = "";
 
         for (final StaticAbility stAb : attachSource.getStaticAbilities()) {
-            if (stAb.checkMode(StaticAbilityMode.Continuous) && stAb.hasParam("AddType")) {
+            final Map<String, String> stab = stAb.getMapParams();
-                type = stAb.getParam("AddType");
+            if (stab.get("Mode").equals("Continuous") && stab.containsKey("AddType")) {
+                type = stab.get("AddType");
             }
         }
 
@@ -373,39 +371,9 @@ public class AttachAi extends SpellAbilityAi {
      */
     private static Card attachAIKeepTappedPreference(final SpellAbility sa, final List<Card> list, final boolean mandatory, final Card attachSource) {
         // AI For Cards like Paralyzing Grasp and Glimmerdust Nap
-
-        // check for ETB Trigger
-        boolean tapETB = isAuraSpell(sa) && attachSource.getTriggers().anyMatch(t -> {
-            if (t.getMode() != TriggerType.ChangesZone) {
-                return false;
-            }
-
-            if (!ZoneType.Battlefield.toString().equals(t.getParam("Destination"))) {
-                return false;
-            }
-
-            if (t.hasParam("ValidCard") && !t.getParam("ValidCard").contains("Self")) {
-                return false;
-            }
-
-            SpellAbility tSa = t.ensureAbility();
-            if (tSa == null) {
-                return false;
-            }
-
-            if (!ApiType.Tap.equals(tSa.getApi())) {
-                return false;
-            }
-            if (!"Enchanted".equals(tSa.getParam("Defined"))) {
-                return false;
-            }
-
-            return true;
-        });
-
         final List<Card> prefList = CardLists.filter(list, c -> {
             // Don't do Untapped Vigilance cards
-            if (!tapETB && c.isCreature() && c.hasKeyword(Keyword.VIGILANCE) && c.isUntapped()) {
+            if (c.isCreature() && c.hasKeyword(Keyword.VIGILANCE) && c.isUntapped()) {
                 return false;
             }
 
@@ -420,9 +388,20 @@ public class AttachAi extends SpellAbilityAi {
                     return false;
                 }
             }
-            // already affected
+
-            if (!c.canUntap(c.getController(), true)) {
+            if (!c.isEnchanted()) {
-                return false;
+                return true;
+            }
+
+            final Iterable<Card> auras = c.getEnchantedBy();
+            for (Card aura : auras) {
+                SpellAbility auraSA = aura.getSpells().get(0);
+                if (auraSA.getApi() == ApiType.Attach) {
+                    if ("KeepTapped".equals(auraSA.getParam("AILogic"))) {
+                        // Don't attach multiple KeepTapped Auras to one card
+                        return false;
+                    }
+                }
             }
 
             return true;
@@ -507,29 +486,29 @@ public class AttachAi extends SpellAbilityAi {
      */
     private static Card attachAIAnimatePreference(final SpellAbility sa, final List<Card> list, final boolean mandatory,
             final Card attachSource) {
-        if (list.isEmpty()) {
+    	if (list.isEmpty()) {
-            return null;
+    		return null;
-        }
+    	}
-        Card card = null;
+    	Card card = null;
         // AI For choosing a Card to Animate.
         List<Card> betterList = CardLists.getNotType(list, "Creature");
         if (ComputerUtilAbility.getAbilitySourceName(sa).equals("Animate Artifact")) {
             betterList = CardLists.filter(betterList, c -> c.getCMC() > 0);
             card = ComputerUtilCard.getMostExpensivePermanentAI(betterList);
         } else {
-            List<Card> evenBetterList = CardLists.filter(betterList, c -> c.hasKeyword(Keyword.INDESTRUCTIBLE) || c.hasKeyword(Keyword.HEXPROOF));
+        	List<Card> evenBetterList = CardLists.filter(betterList, c -> c.hasKeyword(Keyword.INDESTRUCTIBLE) || c.hasKeyword(Keyword.HEXPROOF));
-            if (!evenBetterList.isEmpty()) {
+        	if (!evenBetterList.isEmpty()) {
-                betterList = evenBetterList;
+        		betterList = evenBetterList;
-            }
+        	}
-            evenBetterList = CardLists.filter(betterList, CardPredicates.UNTAPPED);
+        	evenBetterList = CardLists.filter(betterList, CardPredicates.UNTAPPED);
-            if (!evenBetterList.isEmpty()) {
+        	if (!evenBetterList.isEmpty()) {
-                betterList = evenBetterList;
+        		betterList = evenBetterList;
-            }
+        	}
-            evenBetterList = CardLists.filter(betterList, c -> c.getTurnInZone() != c.getGame().getPhaseHandler().getTurn());
+        	evenBetterList = CardLists.filter(betterList, c -> c.getTurnInZone() != c.getGame().getPhaseHandler().getTurn());
-            if (!evenBetterList.isEmpty()) {
+        	if (!evenBetterList.isEmpty()) {
-                betterList = evenBetterList;
+        		betterList = evenBetterList;
-            }
+        	}
-            evenBetterList = CardLists.filter(betterList, c -> {
+        	evenBetterList = CardLists.filter(betterList, c -> {
                 for (final SpellAbility sa1 : c.getSpellAbilities()) {
                     if (sa1.isAbility() && sa1.getPayCosts().hasTapCost()) {
                         return false;
@@ -537,10 +516,10 @@ public class AttachAi extends SpellAbilityAi {
                 }
                 return true;
             });
-            if (!evenBetterList.isEmpty()) {
+        	if (!evenBetterList.isEmpty()) {
-                betterList = evenBetterList;
+        		betterList = evenBetterList;
-            }
+        	}
-            card = ComputerUtilCard.getWorstAI(betterList);
+        	card = ComputerUtilCard.getWorstAI(betterList);
         }
 
 
@@ -570,46 +549,28 @@ public class AttachAi extends SpellAbilityAi {
             final Card attachSource) {
         // AI For choosing a Card to Animate.
         final Player ai = sa.getActivatingPlayer();
-        Card attachSourceLki = null;
+        final Card attachSourceLki = CardCopyService.getLKICopy(attachSource);
-        for (Trigger t : attachSource.getTriggers()) {
-            if (!t.getMode().equals(TriggerType.ChangesZone)) {
-                continue;
-            }
-            if (!"Battlefield".equals(t.getParam("Destination"))) {
-                continue;
-            }
-            if (!"Card.Self".equals(t.getParam("ValidCard"))) {
-                continue;
-            }
-            SpellAbility trigSa = t.ensureAbility();
-            SpellAbility animateSa = trigSa.findSubAbilityByType(ApiType.Animate);
-            if (animateSa == null) {
-                continue;
-            }
-            animateSa.setActivatingPlayer(sa.getActivatingPlayer());
-            attachSourceLki = AnimateAi.becomeAnimated(attachSource, animateSa);
-        }
-        if (attachSourceLki == null) {
-            return null;
-        }
         attachSourceLki.setLastKnownZone(ai.getZone(ZoneType.Battlefield));
-        final Card finalAttachSourceLki = attachSourceLki;
+        // Suppress original attach Spell to replace it with another
+        attachSourceLki.getFirstAttachSpell().setSuppressed(true);
 
+        //TODO for Reanimate Auras i need the new Attach Spell, in later versions it might be part of the Enchant Keyword
+        attachSourceLki.addSpellAbility(AbilityFactory.getAbility(attachSourceLki, "NewAttach"));
         List<Card> betterList = CardLists.filter(list, c -> {
             final Card lki = CardCopyService.getLKICopy(c);
             // need to fake it as if lki would be on the battlefield
             lki.setLastKnownZone(ai.getZone(ZoneType.Battlefield));
 
             // Reanimate Auras use "Enchant creature put onto the battlefield with CARDNAME" with Remembered
-            finalAttachSourceLki.clearRemembered();
+            attachSourceLki.clearRemembered();
-            finalAttachSourceLki.addRemembered(lki);
+            attachSourceLki.addRemembered(lki);
 
             // need to check what the cards would be on the battlefield
             // do not attach yet, that would cause Events
             CardCollection preList = new CardCollection(lki);
-            preList.add(finalAttachSourceLki);
+            preList.add(attachSourceLki);
             c.getGame().getAction().checkStaticAbilities(false, Sets.newHashSet(preList), preList);
-            boolean result = lki.canBeAttached(finalAttachSourceLki, null);
+            boolean result = lki.canBeAttached(attachSourceLki, null);
 
             //reset static abilities
             c.getGame().getAction().checkStaticAbilities(false);
@@ -834,45 +795,27 @@ public class AttachAi extends SpellAbilityAi {
         int totPower = 0;
         final List<String> keywords = new ArrayList<>();
 
-        boolean cantAttack = false;
-        boolean cantBlock = false;
-
         for (final StaticAbility stAbility : attachSource.getStaticAbilities()) {
-            if (stAbility.checkMode(StaticAbilityMode.CantAttack)) {
+            final Map<String, String> stabMap = stAbility.getMapParams();
-                String valid = stAbility.getParam("ValidCard");
-                if (valid.contains(stCheck) || valid.contains("AttachedBy")) {
-                    cantAttack = true;
-                }
-            } else if (stAbility.checkMode(StaticAbilityMode.CantBlock)) {
-                String valid = stAbility.getParam("ValidCard");
-                if (valid.contains(stCheck) || valid.contains("AttachedBy")) {
-                    cantBlock = true;
-                }
-            } else if (stAbility.checkMode(StaticAbilityMode.CantBlockBy)) {
-                String valid = stAbility.getParam("ValidBlocker");
-                if (valid.contains(stCheck) || valid.contains("AttachedBy")) {
-                    cantBlock = true;
-                }
-            }
 
-            if (!stAbility.checkMode(StaticAbilityMode.Continuous)) {
+            if (!stabMap.get("Mode").equals("Continuous")) {
                 continue;
             }
 
-            final String affected = stAbility.getParam("Affected");
+            final String affected = stabMap.get("Affected");
 
             if (affected == null) {
                 continue;
             }
             if ((affected.contains(stCheck) || affected.contains("AttachedBy"))) {
-                totToughness += AbilityUtils.calculateAmount(attachSource, stAbility.getParam("AddToughness"), sa);
+                totToughness += AbilityUtils.calculateAmount(attachSource, stabMap.get("AddToughness"), sa);
-                totPower += AbilityUtils.calculateAmount(attachSource, stAbility.getParam("AddPower"), sa);
+                totPower += AbilityUtils.calculateAmount(attachSource, stabMap.get("AddPower"), sa);
 
-                String kws = stAbility.getParam("AddKeyword");
+                String kws = stabMap.get("AddKeyword");
                 if (kws != null) {
                     keywords.addAll(Arrays.asList(kws.split(" & ")));
                 }
-                kws = stAbility.getParam("AddHiddenKeyword");
+                kws = stabMap.get("AddHiddenKeyword");
                 if (kws != null) {
                     keywords.addAll(Arrays.asList(kws.split(" & ")));
                 }
@@ -908,12 +851,6 @@ public class AttachAi extends SpellAbilityAi {
             prefList = CardLists.filter(prefList, c -> c.getNetPower() > 0 && ComputerUtilCombat.canAttackNextTurn(c));
         }
 
-        if (cantAttack) {
-            prefList = CardLists.filter(prefList, c -> c.isCreature() && ComputerUtilCombat.canAttackNextTurn(c));
-        } else if (cantBlock) { // TODO better can block filter?
-            prefList = CardLists.filter(prefList, c -> c.isCreature() && !ComputerUtilCard.isUselessCreature(ai, c));
-        }
-
         //some auras aren't useful in multiples
         if (attachSource.hasSVar("NonStackingAttachEffect")) {
             prefList = CardLists.filter(prefList,
@@ -988,10 +925,6 @@ public class AttachAi extends SpellAbilityAi {
         return true;
     }
 
-    private static boolean isAuraSpell(final SpellAbility sa) {
-        return sa.isSpell() && sa.getHostCard().isAura();
-    }
-
     /**
      * Attach preference.
      *
@@ -1007,23 +940,7 @@ public class AttachAi extends SpellAbilityAi {
      */
     private static boolean attachPreference(final SpellAbility sa, final TargetRestrictions tgt, final boolean mandatory) {
         GameObject o;
-        boolean spellCanTargetPlayer = false;
+        if (tgt.canTgtPlayer()) {
-        if (isAuraSpell(sa)) {
-            Card source = sa.getHostCard();
-            if (!source.hasKeyword(Keyword.ENCHANT)) {
-                return false;
-            }
-            for (KeywordInterface ki : source.getKeywords(Keyword.ENCHANT)) {
-                String ko = ki.getOriginal();
-                String m[] = ko.split(":");
-                String v = m[1];
-                if (v.contains("Player") || v.contains("Opponent")) {
-                    spellCanTargetPlayer = true;
-                    break;
-                }
-            }
-        }
-        if (tgt.canTgtPlayer() && (!isAuraSpell(sa) || spellCanTargetPlayer)) {
             List<Player> targetable = new ArrayList<>();
             for (final Player player : sa.getHostCard().getGame().getPlayers()) {
                 if (sa.canTarget(player)) {
@@ -1088,8 +1005,9 @@ public class AttachAi extends SpellAbilityAi {
         CardCollection toRemove = new CardCollection();
         for (Trigger t : attachSource.getTriggers()) {
             if (t.getMode() == TriggerType.ChangesZone) {
-                if ("Card.Self".equals(t.getParam("ValidCard"))
+                final Map<String, String> params = t.getMapParams();
-                        && "Battlefield".equals(t.getParam("Destination"))) {
+                if ("Card.Self".equals(params.get("ValidCard"))
+                        && "Battlefield".equals(params.get("Destination"))) {
                     SpellAbility trigSa = t.ensureAbility();
                     if (trigSa != null && trigSa.getApi() == ApiType.DealDamage && "Enchanted".equals(trigSa.getParam("Defined"))) {
                         for (Card target : list) {
@@ -1126,17 +1044,17 @@ public class AttachAi extends SpellAbilityAi {
                 // Probably want to "weight" the list by amount of Enchantments and
                 // choose the "lightest"
 
-                List<Card> betterList = CardLists.filter(magnetList, c -> CombatUtil.canAttack(c, ai.getWeakestOpponent()));
+            	List<Card> betterList = CardLists.filter(magnetList, c -> CombatUtil.canAttack(c, ai.getWeakestOpponent()));
-                if (!betterList.isEmpty()) {
+            	if (!betterList.isEmpty()) {
-                    return ComputerUtilCard.getBestAI(betterList);
+            		return ComputerUtilCard.getBestAI(betterList);
-                }
+            	}
 
-                // Magnet List should not be attached when they are useless
+            	// Magnet List should not be attached when they are useless
-                betterList = CardLists.filter(magnetList, c -> !ComputerUtilCard.isUselessCreature(ai, c));
+            	betterList = CardLists.filter(magnetList, c -> !ComputerUtilCard.isUselessCreature(ai, c));
 
-                if (!betterList.isEmpty()) {
+            	if (!betterList.isEmpty()) {
-                    return ComputerUtilCard.getBestAI(betterList);
+            		return ComputerUtilCard.getBestAI(betterList);
-                }
+            	}
 
                 //return ComputerUtilCard.getBestAI(magnetList);
             }
@@ -1149,27 +1067,29 @@ public class AttachAi extends SpellAbilityAi {
         boolean grantingExtraBlock = false;
 
         for (final StaticAbility stAbility : attachSource.getStaticAbilities()) {
-            if (!stAbility.checkMode(StaticAbilityMode.Continuous)) {
+            final Map<String, String> stabMap = stAbility.getMapParams();
+
+            if (!"Continuous".equals(stabMap.get("Mode"))) {
                 continue;
             }
 
-            final String affected = stAbility.getParam("Affected");
+            final String affected = stabMap.get("Affected");
 
             if (affected == null) {
                 continue;
             }
             if (affected.contains(stCheck) || affected.contains("AttachedBy")) {
-                totToughness += AbilityUtils.calculateAmount(attachSource, stAbility.getParam("AddToughness"), stAbility);
+                totToughness += AbilityUtils.calculateAmount(attachSource, stabMap.get("AddToughness"), stAbility);
-                totPower += AbilityUtils.calculateAmount(attachSource, stAbility.getParam("AddPower"), stAbility);
+                totPower += AbilityUtils.calculateAmount(attachSource, stabMap.get("AddPower"), stAbility);
 
-                grantingAbilities |= stAbility.hasParam("AddAbility");
+                grantingAbilities |= stabMap.containsKey("AddAbility");
-                grantingExtraBlock |= stAbility.hasParam("CanBlockAmount") || stAbility.hasParam("CanBlockAny");
+                grantingExtraBlock |= stabMap.containsKey("CanBlockAmount") || stabMap.containsKey("CanBlockAny");
 
-                String kws = stAbility.getParam("AddKeyword");
+                String kws = stabMap.get("AddKeyword");
                 if (kws != null) {
                     keywords.addAll(Arrays.asList(kws.split(" & ")));
                 }
-                kws = stAbility.getParam("AddHiddenKeyword");
+                kws = stabMap.get("AddHiddenKeyword");
                 if (kws != null) {
                     keywords.addAll(Arrays.asList(kws.split(" & ")));
                 }
@@ -1223,13 +1143,13 @@ public class AttachAi extends SpellAbilityAi {
         prefList = ComputerUtil.getSafeTargets(ai, sa, prefList);
 
         if (attachSource.isAura()) {
-            if (!attachSource.getName().equals("Daybreak Coronet")) {
+        	if (!attachSource.getName().equals("Daybreak Coronet")) {
-                // TODO For Auras like Rancor, that aren't as likely to lead to
+	            // TODO For Auras like Rancor, that aren't as likely to lead to
-                // card disadvantage, this check should be skipped
+	            // card disadvantage, this check should be skipped
-                prefList = CardLists.filter(prefList, c -> !c.isEnchanted() || c.hasKeyword(Keyword.HEXPROOF));
+	            prefList = CardLists.filter(prefList, c -> !c.isEnchanted() || c.hasKeyword(Keyword.HEXPROOF));
-            }
+        	}
 
-            // should not attach Auras to creatures that does leave the play
+        	// should not attach Auras to creatures that does leave the play
             prefList = CardLists.filter(prefList, c -> !c.hasSVar("EndOfTurnLeavePlay"));
         }
 
@@ -1238,15 +1158,10 @@ public class AttachAi extends SpellAbilityAi {
         // TODO Somehow test for definitive advantage (e.g. opponent low on health, AI is attacking)
         // to be able to deal the final blow with an enchanted vehicle like that
         boolean canOnlyTargetCreatures = true;
-        if (attachSource.isAura()) {
+        for (String valid : ObjectUtils.firstNonNull(attachSource.getFirstAttachSpell(), sa).getTargetRestrictions().getValidTgts()) {
-            for (KeywordInterface ki : attachSource.getKeywords(Keyword.ENCHANT)) {
+            if (!valid.startsWith("Creature")) {
-                String o = ki.getOriginal();
+                canOnlyTargetCreatures = false;
-                String m[] = o.split(":");
+                break;
-                String v = m[1];
-                if (!v.startsWith("Creature")) {
-                    canOnlyTargetCreatures = false;
-                    break;
-                }
             }
         }
         if (canOnlyTargetCreatures && (attachSource.isAura() || attachSource.isEquipment())) {
@@ -1257,7 +1172,7 @@ public class AttachAi extends SpellAbilityAi {
             // Probably prefer to Enchant Creatures that Can Attack
             // Filter out creatures that can't Attack or have Defender
             if (keywords.isEmpty()) {
-                final int powerBonus = totPower;
+            	final int powerBonus = totPower;
                 prefList = CardLists.filter(prefList, c -> {
                     if (!c.isCreature()) {
                         return true;
@@ -1472,6 +1387,8 @@ public class AttachAi extends SpellAbilityAi {
             c = attachAICuriosityPreference(sa, prefList, mandatory, attachSource);
         } else if ("ChangeType".equals(logic)) {
             c = attachAIChangeTypePreference(sa, prefList, mandatory, attachSource);
+        } else if ("KeepTapped".equals(logic)) {
+            c = attachAIKeepTappedPreference(sa, prefList, mandatory, attachSource);
         } else if ("Animate".equals(logic)) {
             c = attachAIAnimatePreference(sa, prefList, mandatory, attachSource);
         } else if ("Reanimate".equals(logic)) {
@@ -1482,12 +1399,6 @@ public class AttachAi extends SpellAbilityAi {
             c = attachAIHighestEvaluationPreference(prefList);
         }
 
-        if (isAuraSpell(sa)) {
-            if (attachSource.getReplacementEffects().anyMatch(re -> re.getMode().equals(ReplacementType.Untap) && re.getLayer().equals(ReplacementLayer.CantHappen))) {
-                c = attachAIKeepTappedPreference(sa, prefList, mandatory, attachSource);
-            }
-        }
-
         // Consider exceptional cases which break the normal evaluation rules
         if (!isUsefulAttachAction(ai, c, sa)) {
             return null;
@@ -1640,6 +1551,8 @@ public class AttachAi extends SpellAbilityAi {
         } else if (keyword.endsWith("Prevent all combat damage that would be dealt to and dealt by CARDNAME.")
                 || keyword.endsWith("Prevent all damage that would be dealt to and dealt by CARDNAME.")) {
             return card.getNetCombatDamage() >= 2 && ComputerUtilCombat.canAttackNextTurn(card);
+        } else if (keyword.endsWith("CARDNAME doesn't untap during your untap step.")) {
+            return !card.isUntapped();
         }
         return true;
     }

forge-ai/src/main/java/forge/ai/ability/ChangeZoneAi.java

@@ -22,6 +22,7 @@ import forge.game.player.Player;
 import forge.game.player.PlayerActionConfirmMode;
 import forge.game.spellability.AbilitySub;
 import forge.game.spellability.SpellAbility;
+import forge.game.spellability.SpellAbilityStackInstance;
 import forge.game.spellability.TargetRestrictions;
 import forge.game.staticability.StaticAbilityMustTarget;
 import forge.game.zone.ZoneType;
@@ -137,6 +138,8 @@ public class ChangeZoneAi extends SpellAbilityAi {
         if (aiLogic != null) {
             if (aiLogic.equals("Always")) {
                 return true;
+            } else if (aiLogic.startsWith("ExileSpell")) {
+                return doExileSpellLogic(aiPlayer, sa);
             } else if (aiLogic.startsWith("SacAndUpgrade")) { // Birthing Pod, Natural Order, etc.
                 return doSacAndUpgradeLogic(aiPlayer, sa);
             } else if (aiLogic.startsWith("SacAndRetFromGrave")) { // Recurring Nightmare, etc.
@@ -875,10 +878,6 @@ public class ChangeZoneAi extends SpellAbilityAi {
             origin.addAll(ZoneType.listValueOf(sa.getParam("TgtZone")));
         }
 
-        if (origin.contains(ZoneType.Stack) && doExileSpellLogic(ai, sa, mandatory)) {
-            return true;
-        }
-
         final ZoneType destination = ZoneType.smartValueOf(sa.getParam("Destination"));
         final Game game = ai.getGame();
 
@@ -903,6 +902,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
         }
         CardCollection list = CardLists.getTargetableCards(game.getCardsIn(origin), sa);
 
+        // Filter AI-specific targets if provided
         list = ComputerUtil.filterAITgts(sa, ai, list, true);
         if (sa.hasParam("AITgtsOnlyBetterThanSelf")) {
             list = CardLists.filter(list, card -> ComputerUtilCard.evaluateCreature(card) > ComputerUtilCard.evaluateCreature(source) + 30);
@@ -914,9 +914,6 @@ public class ChangeZoneAi extends SpellAbilityAi {
         if (sa.isSpell()) {
             list.remove(source); // spells can't target their own source, because it's actually in the stack zone
         }
-
-        // list = CardLists.canSubsequentlyTarget(list, sa);
-
         if (sa.hasParam("AttachedTo")) {
             list = CardLists.filter(list, c -> {
                 for (Card card : game.getCardsIn(ZoneType.Battlefield)) {
@@ -1285,9 +1282,7 @@ public class ChangeZoneAi extends SpellAbilityAi {
             }
 
             list.remove(choice);
-            if (sa.canTarget(choice)) {
+            sa.getTargets().add(choice);
-                sa.getTargets().add(choice);
-            }
         }
 
         // Honor the Single Zone restriction. For now, simply remove targets that do not belong to the same zone as the first targeted card.
@@ -1453,9 +1448,6 @@ public class ChangeZoneAi extends SpellAbilityAi {
             // AI Targeting
             Card choice = null;
 
-            // Filter out cards TargetsForEachPlayer
-            list = CardLists.canSubsequentlyTarget(list, sa);
-
             if (!list.isEmpty()) {
                 Card mostExpensivePermanent = ComputerUtilCard.getMostExpensivePermanentAI(list);
                 if (mostExpensivePermanent.isCreature()
@@ -2069,24 +2061,31 @@ public class ChangeZoneAi extends SpellAbilityAi {
         }
     }
 
-    private static boolean doExileSpellLogic(final Player ai, final SpellAbility sa, final boolean mandatory) {
+    private boolean doExileSpellLogic(final Player aiPlayer, final SpellAbility sa) {
-        List<ApiType> dangerousApi = null;
+        String aiLogic = sa.getParamOrDefault("AILogic", "");
-        CardCollection spells = new CardCollection(ai.getGame().getStackZone().getCards());
+        SpellAbilityStackInstance top = aiPlayer.getGame().getStack().peek();
-        Collections.reverse(spells);
+        List<ApiType> dangerousApi = Arrays.asList(ApiType.DealDamage, ApiType.DamageAll, ApiType.Destroy, ApiType.DestroyAll, ApiType.Sacrifice, ApiType.SacrificeAll);
-        if (!mandatory && !spells.isEmpty()) {
+        int manaCost = 0;
-            spells = spells.subList(0, 1);
+        int minCost = 0;
-            spells = ComputerUtil.filterAITgts(sa, ai, spells, true);
+
-            dangerousApi = Arrays.asList(ApiType.DealDamage, ApiType.DamageAll, ApiType.Destroy, ApiType.DestroyAll, ApiType.Sacrifice, ApiType.SacrificeAll);
+        if (aiLogic.contains(".")) {
+            minCost = Integer.parseInt(aiLogic.substring(aiLogic.indexOf(".") + 1));
         }
 
-        for (Card c : spells) {
+        if (top != null) {
-            SpellAbility topSA = ai.getGame().getStack().getSpellMatchingHost(c);
+            SpellAbility topSA = top.getSpellAbility();
-            if (topSA != null && (dangerousApi == null ||
+            if (topSA != null) {
-                    (dangerousApi.contains(topSA.getApi()) && topSA.getActivatingPlayer().isOpponentOf(ai)))
+                if (topSA.getPayCosts().hasManaCost()) {
-                    && sa.canTarget(topSA)) {
+                    manaCost = topSA.getPayCosts().getTotalMana().getCMC();
-                sa.resetTargets();
+                }
-                sa.getTargets().add(topSA);
+
-                return sa.isTargetNumberValid();
+                if ((manaCost >= minCost || dangerousApi.contains(topSA.getApi()))
+                        && topSA.getActivatingPlayer().isOpponentOf(aiPlayer)
+                        && sa.canTargetSpellAbility(topSA)) {
+                    sa.resetTargets();
+                    sa.getTargets().add(topSA);
+                    return sa.isTargetNumberValid();
+                }
             }
         }
         return false;

forge-ai/src/main/java/forge/ai/ability/ChooseGenericAi.java

@@ -161,10 +161,10 @@ public class ChooseGenericAi extends SpellAbilityAi {
                 }
             }
             // FatespinnerSkipDraw,FatespinnerSkipMain,FatespinnerSkipCombat
-            if (game.getReplacementHandler().wouldPhaseBeSkipped(player, PhaseType.DRAW)) {
+            if (game.getReplacementHandler().wouldPhaseBeSkipped(player, "Draw")) {
                 return skipDraw;
             }
-            if (game.getReplacementHandler().wouldPhaseBeSkipped(player, PhaseType.COMBAT_BEGIN)) {
+            if (game.getReplacementHandler().wouldPhaseBeSkipped(player, "BeginCombat")) {
                 return skipCombat;
             }
 

forge-ai/src/main/java/forge/ai/ability/CloakAi.java

@@ -14,7 +14,7 @@ public class CloakAi extends ManifestBaseAi {
         // (e.g. Grafdigger's Cage)
         Card topCopy = CardCopyService.getLKICopy(card);
         topCopy.turnFaceDownNoUpdate();
-        topCopy.setCloaked(sa);
+        topCopy.setCloaked(true);
 
         if (ComputerUtil.isETBprevented(topCopy)) {
             return false;

forge-ai/src/main/java/forge/ai/ability/ConniveAi.java

@@ -4,7 +4,6 @@ import forge.ai.ComputerUtil;
 import forge.ai.ComputerUtilCard;
 import forge.ai.ComputerUtilMana;
 import forge.ai.SpellAbilityAi;
-import forge.game.ability.AbilityUtils;
 import forge.game.card.Card;
 import forge.game.card.CardCollection;
 import forge.game.card.CardLists;
@@ -19,13 +18,6 @@ public class ConniveAi extends SpellAbilityAi {
             return false; // can't draw anything
         }
 
-        Card host = sa.getHostCard();
-
-        final int num = AbilityUtils.calculateAmount(host, sa.getParamOrDefault("ConniveNum", "1"), sa);
-        if (num == 0) {
-            return false; // Won't do anything
-        }
-
         CardCollection list = CardLists.getTargetableCards(ai.getCardsIn(ZoneType.Battlefield), sa);
 
         // Filter AI-specific targets if provided

forge-ai/src/main/java/forge/ai/ability/ControlGainAi.java

@@ -205,9 +205,6 @@ public class ControlGainAi extends SpellAbilityAi {
             while (t == null) {
                 // filter by MustTarget requirement
                 CardCollection originalList = new CardCollection(list);
-
-                list = CardLists.canSubsequentlyTarget(list, sa);
-
                 boolean mustTargetFiltered = StaticAbilityMustTarget.filterMustTargetCards(ai, list, sa);
 
                 if (planeswalkers > 0) {

forge-ai/src/main/java/forge/ai/ability/CopyPermanentAi.java

@@ -152,8 +152,6 @@ public class CopyPermanentAi extends SpellAbilityAi {
 
             // target loop
             while (sa.canAddMoreTarget()) {
-                list = CardLists.canSubsequentlyTarget(list, sa);
-
                 if (list.isEmpty()) {
                     if (!sa.isTargetNumberValid() || sa.getTargets().size() == 0) {
                         sa.resetTargets();

forge-ai/src/main/java/forge/ai/ability/DamageDealAi.java

@@ -95,7 +95,7 @@ public class DamageDealAi extends DamageAiBase {
         final String damage = sa.getParam("NumDmg");
         int dmg = calculateDamageAmount(sa, source, damage);
 
-        if (damage.equals("X") || (dmg == 0 && source.getSVar("X").equals("Count$xPaid"))) {
+        if (damage.equals("X") || source.getSVar("X").equals("Count$xPaid")) {
             if (sa.getSVar("X").equals("Count$xPaid") || sa.getSVar(damage).equals("Count$xPaid")) {
                 dmg = ComputerUtilCost.getMaxXValue(sa, ai, sa.isTrigger());
 

forge-ai/src/main/java/forge/ai/ability/DestroyAi.java

@@ -216,8 +216,6 @@ public class DestroyAi extends SpellAbilityAi {
                 CardCollection originalList = new CardCollection(list);
                 boolean mustTargetFiltered = StaticAbilityMustTarget.filterMustTargetCards(ai, list, sa);
 
-                list = CardLists.canSubsequentlyTarget(list, sa);
-
                 if (list.isEmpty()) {
                     if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
                         sa.resetTargets();
@@ -277,7 +275,6 @@ public class DestroyAi extends SpellAbilityAi {
                                 choice = aura;
                             }
                         }
-                        // TODO What about stolen permanents we're getting back at the end of the turn?
                     }
                 }
 
@@ -287,9 +284,7 @@ public class DestroyAi extends SpellAbilityAi {
                 }
 
                 list.remove(choice);
-                if (sa.canTarget(choice)) {
+                sa.getTargets().add(choice);
-                    sa.getTargets().add(choice);
-                }
             }
         } else if (sa.hasParam("Defined")) {
             list = AbilityUtils.getDefinedCards(source, sa.getParam("Defined"), sa);
@@ -366,10 +361,7 @@ public class DestroyAi extends SpellAbilityAi {
                     }
                 } else {
                     Card c = ComputerUtilCard.getBestAI(preferred);
-
+                    sa.getTargets().add(c);
-                    if (sa.canTarget(c)) {
-                        sa.getTargets().add(c);
-                    }
                     preferred.remove(c);
                 }
             }
@@ -390,9 +382,7 @@ public class DestroyAi extends SpellAbilityAi {
                     } else {
                         c = ComputerUtilCard.getCheapestPermanentAI(list, sa, false);
                     }
-                    if (sa.canTarget(c)) {
+                    sa.getTargets().add(c);
-                        sa.getTargets().add(c);
-                    }
                     list.remove(c);
                 }
             }

forge-ai/src/main/java/forge/ai/ability/DrawAi.java

@@ -515,17 +515,12 @@ public class DrawAi extends SpellAbilityAi {
                 return false;
             }
 
-            if ((computerHandSize + numCards > computerMaxHandSize)) {
+            if ((computerHandSize + numCards > computerMaxHandSize)
+                    && game.getPhaseHandler().isPlayerTurn(ai)
+                    && !sa.isTrigger()
+                    && !assumeSafeX) {
                 // Don't draw too many cards and then risk discarding cards at EOT
-                 if (game.getPhaseHandler().isPlayerTurn(ai)
+                if (!drawback) {
-                        && !sa.isTrigger()
-                        && !assumeSafeX
-                        && !drawback) {
-                     return false;
-                 }
-
-                if (computerHandSize > computerMaxHandSize) {
-                    // Don't make my hand size get too big if already at max
                     return false;
                 }
             }

forge-ai/src/main/java/forge/ai/ability/EndureAi.java

@@ -1,140 +0,0 @@
-package forge.ai.ability;
-
-import com.google.common.collect.Sets;
-
-import forge.ai.ComputerUtilCard;
-import forge.ai.SpellAbilityAi;
-import forge.game.ability.AbilityUtils;
-import forge.game.Game;
-import forge.game.card.*;
-import forge.game.card.token.TokenInfo;
-import forge.game.combat.Combat;
-import forge.game.combat.CombatUtil;
-import forge.game.player.Player;
-import forge.game.player.PlayerActionConfirmMode;
-import forge.game.spellability.SpellAbility;
-import forge.game.zone.ZoneType;
-
-import java.util.Map;
-
-public class EndureAi extends SpellAbilityAi {
-    /* (non-Javadoc)
-     * @see forge.card.abilityfactory.SpellAiLogic#canPlayAI(forge.game.player.Player, java.util.Map, forge.card.spellability.SpellAbility)
-     */
-    @Override
-    protected boolean canPlayAI(Player aiPlayer, SpellAbility sa) {
-        // Support for possible targeted Endure (e.g. target creature endures X)
-        if (sa.usesTargeting()) {
-            Card bestCreature = ComputerUtilCard.getBestCreatureAI(aiPlayer.getCardsIn(ZoneType.Battlefield));
-            if (bestCreature == null) {
-                return false;
-            }
-
-            sa.resetTargets();
-            sa.getTargets().add(bestCreature);
-        }
-
-        return true;
-    }
-
-    public static boolean shouldPutCounters(Player ai, SpellAbility sa) {
-        // TODO: adapted from Fabricate AI in TokenAi, maybe can be refactored to a single method
-        final Card source = sa.getHostCard();
-        final Game game = source.getGame();
-        final String num = sa.getParamOrDefault("Num", "1");
-        final int amount = AbilityUtils.calculateAmount(source, num, sa);
-
-        // if host would leave the play or if host is useless, create the token
-        if (source.hasSVar("EndOfTurnLeavePlay") || ComputerUtilCard.isUselessCreature(ai, source)) {
-            return false;
-        }
-
-        // need a copy for one with extra +1/+1 counter boost,
-        // without causing triggers to run
-        final Card copy = CardCopyService.getLKICopy(source);
-        copy.setCounters(CounterEnumType.P1P1, copy.getCounters(CounterEnumType.P1P1) + amount);
-        copy.setZone(source.getZone());
-
-        // if host would put into the battlefield attacking
-        Combat combat = source.getGame().getCombat();
-        if (combat != null && combat.isAttacking(source)) {
-            final Player defender = combat.getDefenderPlayerByAttacker(source);
-            return defender.canLoseLife() && !ComputerUtilCard.canBeBlockedProfitably(defender, copy, true);
-        }
-
-        // if the host has haste and can attack
-        if (CombatUtil.canAttack(copy)) {
-            for (final Player opp : ai.getOpponents()) {
-                if (CombatUtil.canAttack(copy, opp) &&
-                        opp.canLoseLife() &&
-                        !ComputerUtilCard.canBeBlockedProfitably(opp, copy, true))
-                    return true;
-            }
-        }
-
-        // TODO check for trigger to turn token ETB into +1/+1 counter for host
-        // TODO check for trigger to turn token ETB into damage or life loss for opponent
-        // in these cases token might be preferred even if they would not survive
-
-        // evaluate creature with counters
-        int evalCounter = ComputerUtilCard.evaluateCreature(copy);
-
-        // spawn the token so it's possible to evaluate it
-        final Card token = TokenInfo.getProtoType("w_x_x_spirit", sa, ai, false);
-
-        token.setController(ai, 0);
-        token.setLastKnownZone(ai.getZone(ZoneType.Battlefield));
-        token.setTokenSpawningAbility(sa);
-
-        // evaluate the generated token
-        token.setBasePowerString(num);
-        token.setBasePower(amount);
-        token.setBaseToughnessString(num);
-        token.setBaseToughness(amount);
-
-        boolean result = true;
-
-        // need to check what the cards would be on the battlefield
-        // do not attach yet, that would cause Events
-        CardCollection preList = new CardCollection(token);
-        game.getAction().checkStaticAbilities(false, Sets.newHashSet(token), preList);
-
-        // token would not survive
-        if (!token.isCreature() || token.getNetToughness() < 1) {
-            result = false;
-        }
-
-        if (result) {
-            int evalToken = ComputerUtilCard.evaluateCreature(token);
-            result = evalToken < evalCounter;
-        }
-
-        //reset static abilities
-        game.getAction().checkStaticAbilities(false);
-
-        return result;
-    }
-
-    @Override
-    public boolean confirmAction(Player player, SpellAbility sa, PlayerActionConfirmMode mode, String message, Map<String, Object> params) {
-        return shouldPutCounters(player, sa);
-    }
-
-    @Override
-    protected boolean doTriggerAINoCost(Player aiPlayer, SpellAbility sa, boolean mandatory) {
-        // Support for possible targeted Endure (e.g. target creature endures X)
-        if (sa.usesTargeting()) {
-            CardCollection list = CardLists.getValidCards(aiPlayer.getGame().getCardsIn(ZoneType.Battlefield),
-                    sa.getTargetRestrictions().getValidTgts(), aiPlayer, sa.getHostCard(), sa);
-
-            if (!list.isEmpty()) {
-                sa.getTargets().add(ComputerUtilCard.getBestCreatureAI(list));
-                return true;
-            }
-
-            return false;
-        }
-
-        return canPlayAI(aiPlayer, sa) || mandatory;
-    }
-}

forge-ai/src/main/java/forge/ai/ability/ManifestAi.java

@@ -14,7 +14,7 @@ public class ManifestAi extends ManifestBaseAi {
         // (e.g. Grafdigger's Cage)
         Card topCopy = CardCopyService.getLKICopy(card);
         topCopy.turnFaceDownNoUpdate();
-        topCopy.setManifested(sa);
+        topCopy.setManifested(true);
 
         if (ComputerUtil.isETBprevented(topCopy)) {
             return false;

forge-ai/src/main/java/forge/ai/ability/PermanentCreatureAi.java

@@ -14,7 +14,6 @@ import forge.game.phase.PhaseType;
 import forge.game.player.Player;
 import forge.game.spellability.SpellAbility;
 import forge.game.staticability.StaticAbility;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.zone.ZoneType;
 import forge.util.MyRandom;
 import org.apache.commons.lang3.StringUtils;
@@ -48,7 +47,7 @@ public class PermanentCreatureAi extends PermanentAi {
         if (sa.isDash()) {
             //only checks that the dashed creature will attack
             if (ph.isPlayerTurn(ai) && ph.getPhase().isBefore(PhaseType.COMBAT_DECLARE_ATTACKERS)) {
-                if (game.getReplacementHandler().wouldPhaseBeSkipped(ai, PhaseType.COMBAT_BEGIN))
+                if (game.getReplacementHandler().wouldPhaseBeSkipped(ai, "BeginCombat"))
                     return false;
                 if (ComputerUtilCost.canPayCost(sa.getHostCard().getSpellPermanent(), ai, false)) {
                     //do not dash if creature can be played normally
@@ -71,7 +70,7 @@ public class PermanentCreatureAi extends PermanentAi {
         // after attacking
         if (card.hasSVar("EndOfTurnLeavePlay")
                 && (!ph.isPlayerTurn(ai) || ph.getPhase().isAfter(PhaseType.COMBAT_DECLARE_ATTACKERS)
-                || game.getReplacementHandler().wouldPhaseBeSkipped(ai, PhaseType.COMBAT_BEGIN))) {
+                || game.getReplacementHandler().wouldPhaseBeSkipped(ai, "BeginCombat"))) {
             // AiPlayDecision.AnotherTime
             return false;
         }
@@ -155,7 +154,7 @@ public class PermanentCreatureAi extends PermanentAi {
         boolean canCastAtOppTurn = true;
         for (Card c : ai.getGame().getCardsIn(ZoneType.Battlefield)) {
             for (StaticAbility s : c.getStaticAbilities()) {
-                if (s.checkMode(StaticAbilityMode.CantBeCast) && StringUtils.contains(s.getParam("Activator"), "NonActive")
+                if ("CantBeCast".equals(s.getParam("Mode")) && StringUtils.contains(s.getParam("Activator"), "NonActive")
                         && (!s.getParam("Activator").startsWith("You") || c.getController().equals(ai))) {
                     canCastAtOppTurn = false;
                     break;

forge-ai/src/main/java/forge/ai/ability/PumpAi.java

@@ -542,8 +542,6 @@ public class PumpAi extends PumpAiBase {
             Card t = null;
             // boolean goodt = false;
 
-            list = CardLists.canSubsequentlyTarget(list, sa);
-
             if (list.isEmpty()) {
                 if (!sa.isMinTargetChosen() || sa.isZeroTargets()) {
                     if (mandatory || ComputerUtil.activateForCost(sa, ai)) {

forge-ai/src/main/java/forge/ai/ability/PumpAiBase.java

@@ -10,6 +10,7 @@ import forge.game.combat.CombatUtil;
 import forge.game.keyword.Keyword;
 import forge.game.phase.PhaseHandler;
 import forge.game.phase.PhaseType;
+import forge.game.phase.Untap;
 import forge.game.player.Player;
 import forge.game.spellability.SpellAbility;
 import forge.game.zone.ZoneType;
@@ -136,7 +137,7 @@ public abstract class PumpAiBase extends SpellAbilityAi {
             return CombatUtil.canBlockAtLeastOne(card, attackers);
         } else if (keyword.endsWith("This card doesn't untap during your next untap step.")) {
             return !ph.getPhase().isBefore(PhaseType.MAIN2) && !card.isUntapped() && ph.isPlayerTurn(ai)
-                    && card.canUntap(card.getController(), true);
+                    && Untap.canUntap(card);
         } else if (keyword.endsWith("Prevent all combat damage that would be dealt by CARDNAME.")
                 || keyword.endsWith("Prevent all damage that would be dealt by CARDNAME.")) {
             if (ph.isPlayerTurn(ai) && (!(CombatUtil.canBlock(card) || combat != null && combat.isBlocking(card))

forge-ai/src/main/java/forge/ai/ability/SetStateAi.java

@@ -6,7 +6,6 @@ import forge.ai.SpellAbilityAi;
 import forge.card.CardStateName;
 import forge.game.ability.AbilityUtils;
 import forge.game.card.*;
-import forge.game.keyword.Keyword;
 import forge.game.phase.PhaseHandler;
 import forge.game.phase.PhaseType;
 import forge.game.player.Player;
@@ -143,7 +142,7 @@ public class SetStateAi extends SpellAbilityAi {
                 return false;
             }
             // hidden agenda
-            if (card.getState(CardStateName.Original).hasKeyword(Keyword.HIDDEN_AGENDA)
+            if (card.getState(CardStateName.Original).hasIntrinsicKeyword("Hidden agenda")
                     && card.isInZone(ZoneType.Command)) {
                 String chosenName = card.getNamedCard();
                 for (Card cast : ai.getGame().getStack().getSpellsCastThisTurn()) {

forge-ai/src/main/java/forge/ai/ability/TokenAi.java

@@ -206,8 +206,7 @@ public class TokenAi extends SpellAbilityAi {
                 && game.getPhaseHandler().getPlayerTurn().isOpponentOf(ai)
                 && game.getCombat() != null
                 && !game.getCombat().getAttackers().isEmpty()
-                && alwaysOnOppAttack
+                && alwaysOnOppAttack) {
-                && actualToken.isCreature()) {
             for (Card attacker : game.getCombat().getAttackers()) {
                 if (CombatUtil.canBlock(attacker, actualToken)) {
                     return true;
@@ -367,7 +366,8 @@ public class TokenAi extends SpellAbilityAi {
     }
 
     private boolean tgtRoleAura(final Player ai, final SpellAbility sa, final Card tok, final boolean mandatory) {
-        boolean isCurse = "Curse".equals(sa.getParam("AILogic")) || "Curse".equals(tok.getSVar("AttachAILogic"));
+        boolean isCurse = "Curse".equals(sa.getParam("AILogic")) ||
+                tok.getFirstAttachSpell().getParamOrDefault("AILogic", "").equals("Curse");
         List<Card> tgts = CardUtil.getValidCardsToTarget(sa);
 
         // look for card without role from ai

forge-ai/src/main/java/forge/ai/ability/UntapAi.java

@@ -16,6 +16,7 @@ import forge.game.cost.CostTap;
 import forge.game.mana.ManaCostBeingPaid;
 import forge.game.phase.PhaseHandler;
 import forge.game.phase.PhaseType;
+import forge.game.phase.Untap;
 import forge.game.player.Player;
 import forge.game.player.PlayerCollection;
 import forge.game.spellability.SpellAbility;
@@ -337,7 +338,7 @@ public class UntapAi extends SpellAbilityAi {
         }
 
         // See if there's anything to untap that is tapped and that doesn't untap during the next untap step by itself
-        CardCollection noAutoUntap = CardLists.filter(untapList, c -> !c.canUntap(c.getController(), true));
+        CardCollection noAutoUntap = CardLists.filter(untapList, Untap.CANUNTAP.negate());
         if (!noAutoUntap.isEmpty()) {
             return ComputerUtilCard.getBestAI(noAutoUntap);
         }

forge-ai/src/main/java/forge/ai/simulation/GameCopier.java

@@ -96,7 +96,7 @@ public class GameCopier {
             newPlayer.setLandsPlayedThisTurn(origPlayer.getLandsPlayedThisTurn());
             newPlayer.setCounters(Maps.newHashMap(origPlayer.getCounters()));
             newPlayer.setSpeed(origPlayer.getSpeed());
-            newPlayer.setBlessing(origPlayer.hasBlessing(), null);
+            newPlayer.setBlessing(origPlayer.hasBlessing());
             newPlayer.setRevolt(origPlayer.hasRevolt());
             newPlayer.setDescended(origPlayer.getDescended());
             newPlayer.setLibrarySearched(origPlayer.getLibrarySearched());
@@ -373,10 +373,10 @@ public class GameCopier {
             if (c.isFaceDown()) {
                 newCard.turnFaceDown(true);
                 if (c.isManifested()) {
-                    newCard.setManifested(c.getManifestedSA());
+                    newCard.setManifested(true);
                 }
                 if (c.isCloaked()) {
-                    newCard.setCloaked(c.getCloakedSA());
+                    newCard.setCloaked(true);
                 }
             }
             if (c.isMonstrous()) {

forge-core/src/main/java/forge/ImageKeys.java

@@ -23,14 +23,10 @@ public final class ImageKeys {
 
     public static final String HIDDEN_CARD           = "hidden";
     public static final String MORPH_IMAGE           = "morph";
+    public static final String DISGUISED_IMAGE       = "disguised";
     public static final String MANIFEST_IMAGE        = "manifest";
     public static final String CLOAKED_IMAGE         = "cloaked";
     public static final String FORETELL_IMAGE        = "foretell";
-    public static final String BLESSING_IMAGE        = "blessing";
-    public static final String INITIATIVE_IMAGE      = "initiative";
-    public static final String MONARCH_IMAGE         = "monarch";
-    public static final String THE_RING_IMAGE        = "the_ring";
-    public static final String RADIATION_IMAGE       = "radiation";
 
     public static final String BACKFACE_POSTFIX  = "$alt";
     public static final String SPECFACE_W = "$wspec";
@@ -39,9 +35,6 @@ public final class ImageKeys {
     public static final String SPECFACE_R = "$rspec";
     public static final String SPECFACE_G = "$gspec";
 
-    private static final String URL_SCRYFALL = "https://api.scryfall.com";
-    public static final String URL_PIC_SCRYFALL_DOWNLOAD = URL_SCRYFALL + "/cards/";
-
     private static String CACHE_CARD_PICS_DIR, CACHE_TOKEN_PICS_DIR, CACHE_ICON_PICS_DIR, CACHE_BOOSTER_PICS_DIR,
         CACHE_FATPACK_PICS_DIR, CACHE_BOOSTERBOX_PICS_DIR, CACHE_PRECON_PICS_DIR, CACHE_TOURNAMENTPACK_PICS_DIR;
     public static String ADVENTURE_CARD_PICS_DIR;
@@ -105,18 +98,8 @@ public final class ImageKeys {
 
         final String dir;
         final String filename;
-        String[] tempdata = null;
         if (key.startsWith(ImageKeys.TOKEN_PREFIX)) {
-            tempdata = key.substring(ImageKeys.TOKEN_PREFIX.length()).split("\\|");
+            filename = key.substring(ImageKeys.TOKEN_PREFIX.length());
-            String tokenname = tempdata[0];
-            if (tempdata.length > 1) {
-                tokenname += "_" + tempdata[1];
-            }
-            if (tempdata.length > 2) {
-                tokenname += "_" + tempdata[2];
-            }
-            filename = tokenname;
-
             dir = CACHE_TOKEN_PICS_DIR;
         } else if (key.startsWith(ImageKeys.ICON_PREFIX)) {
             filename = key.substring(ImageKeys.ICON_PREFIX.length());
@@ -157,30 +140,6 @@ public final class ImageKeys {
                 cachedCards.put(filename, file);
                 return file;
             }
-            if (dir.equals(CACHE_TOKEN_PICS_DIR)) {
-                String setlessFilename = tempdata[0];
-                String setCode = tempdata.length > 1 ? tempdata[1] : "";
-                String collectorNumber = tempdata.length > 2 ? tempdata[2] : "";
-                if (!setCode.isEmpty()) {
-                    if (!collectorNumber.isEmpty()) {
-                        file = findFile(dir, setCode + "/" + collectorNumber + "_" + setlessFilename);
-                        if (file != null) {
-                            cachedCards.put(filename, file);
-                            return file;
-                        }
-                    }
-                    file = findFile(dir, setCode + "/" + setlessFilename);
-                    if (file != null) {
-                        cachedCards.put(filename, file);
-                        return file;
-                    }
-                }
-                file = findFile(dir, setlessFilename);
-                if (file != null) {
-                    cachedCards.put(filename, file);
-                    return file;
-                }
-            }
 
             // AE -> Ae and Ae -> AE for older cards with different file names
             // on case-sensitive file systems
@@ -262,7 +221,39 @@ public final class ImageKeys {
                     return file;
                 }
             }
-            if (filename.contains("/")) {
+            if (dir.equals(CACHE_TOKEN_PICS_DIR)) {
+                int index = filename.lastIndexOf('_');
+                if (index != -1) {
+                    String setlessFilename = filename.substring(0, index);
+                    String setCode = filename.substring(index + 1);
+                    // try with upper case set
+                    file = findFile(dir, setlessFilename + "_" + setCode.toUpperCase());
+                    if (file != null) {
+                        cachedCards.put(filename, file);
+                        return file;
+                    }
+                    // try with lower case set
+                    file = findFile(dir, setlessFilename + "_" + setCode.toLowerCase());
+                    if (file != null) {
+                        cachedCards.put(filename, file);
+                        return file;
+                    }
+                    // try without set name
+                    file = findFile(dir, setlessFilename);
+                    if (file != null) {
+                        cachedCards.put(filename, file);
+                        return file;
+                    }
+                    // if there's an art variant try without it
+                    if (setlessFilename.matches(".*[0-9]*$")) {
+                        file = findFile(dir, setlessFilename.replaceAll("[0-9]*$", ""));
+                        if (file != null) {
+                            cachedCards.put(filename, file);
+                            return file;
+                        }
+                    }
+                }
+            } else if (filename.contains("/")) {
                 String setlessFilename = filename.substring(filename.indexOf('/') + 1);
                 file = findFile(dir, setlessFilename);
                 if (file != null) {

forge-core/src/main/java/forge/StaticData.java

@@ -95,12 +95,12 @@ public class StaticData {
             if (!loadNonLegalCards) {
                 for (CardEdition e : editions) {
                     if (e.getType() == CardEdition.Type.FUNNY || e.getBorderColor() == CardEdition.BorderColor.SILVER) {
-                        List<CardEdition.EditionEntry> eternalCards = e.getFunnyEternalCards();
+                        List<CardEdition.CardInSet> eternalCards = e.getFunnyEternalCards();
 
-                        for (CardEdition.EditionEntry cis : e.getAllCardsInSet()) {
+                        for (CardEdition.CardInSet cis : e.getAllCardsInSet()) {
                             if (eternalCards.contains(cis))
                                 continue;
-                            funnyCards.add(cis.name());
+                            funnyCards.add(cis.name);
                         }
                     }
                 }
@@ -217,9 +217,6 @@ public class StaticData {
     }
 
     public CardEdition getCardEdition(String setCode) {
-        if (CardEdition.UNKNOWN_CODE.equals(setCode)) {
-            return CardEdition.UNKNOWN;
-        }
         CardEdition edition = this.editions.get(setCode);
         return edition;
     }
@@ -251,15 +248,6 @@ public class StaticData {
         }
     }
 
-    /**
-     * Retrieve a PaperCard by looking at all available card databases for any matching print.
-     * @param cardName The name of the card
-     * @return PaperCard instance found in one of the available CardDb databases, or <code>null</code> if not found.
-     */
-    public PaperCard fetchCard(final String cardName) {
-        return fetchCard(cardName, null, null);
-    }
-
     /**
      * Retrieve a PaperCard by looking at all available card databases;
      * @param cardName The name of the card
@@ -790,11 +778,11 @@ public class StaticData {
 
             Map<String, Pair<Boolean, Integer>> cardCount = new HashMap<>();
             List<CompletableFuture<?>> futures = new ArrayList<>();
-            for (CardEdition.EditionEntry c : e.getAllCardsInSet()) {
+            for (CardEdition.CardInSet c : e.getAllCardsInSet()) {
-                if (cardCount.containsKey(c.name())) {
+                if (cardCount.containsKey(c.name)) {
-                    cardCount.put(c.name(), Pair.of(c.collectorNumber() != null && c.collectorNumber().startsWith("F"), cardCount.get(c.name()).getRight() + 1));
+                    cardCount.put(c.name, Pair.of(c.collectorNumber != null && c.collectorNumber.startsWith("F"), cardCount.get(c.name).getRight() + 1));
                 } else {
-                    cardCount.put(c.name(), Pair.of(c.collectorNumber() != null && c.collectorNumber().startsWith("F"), 1));
+                    cardCount.put(c.name, Pair.of(c.collectorNumber != null && c.collectorNumber.startsWith("F"), 1));
                 }
             }
 
@@ -856,9 +844,9 @@ public class StaticData {
             futures.clear();
 
             // TODO: Audit token images here...
-            for(Map.Entry<String, Collection<CardEdition.EditionEntry>> tokenEntry : e.getTokens().asMap().entrySet()) {
+            for(Map.Entry<String, Integer> tokenEntry : e.getTokens().entrySet()) {
                 final String name = tokenEntry.getKey();
-                final int artIndex = tokenEntry.getValue().size();
+                final int artIndex = tokenEntry.getValue();
                 try {
                     PaperToken token = getAllTokens().getToken(name, e.getCode());
                     if (token == null) {
@@ -995,23 +983,4 @@ public class StaticData {
         }
         return false;
     }
-    public String getOtherImageKey(String name, String set) {
-        if (this.editions.get(set) != null) {
-            String realSetCode = this.editions.get(set).getOtherSet(name);
-            if (realSetCode != null) {
-                CardEdition.EditionEntry ee = this.editions.get(realSetCode).findOther(name);
-                if (ee != null) { // TODO add collector Number and new ImageKey format
-                    return ImageKeys.getTokenKey(String.format("%s|%s|%s", name, realSetCode, ee.collectorNumber()));
-                }
-            }
-        }
-        for (CardEdition e : this.editions) {
-            CardEdition.EditionEntry ee = e.findOther(name);
-            if (ee != null) { // TODO add collector Number and new ImageKey format
-                return ImageKeys.getTokenKey(String.format("%s|%s|%s", name, e.getCode(), ee.collectorNumber()));
-            }
-        }
-        // final fallback
-        return ImageKeys.getTokenKey(name);
-    }
 }

forge-core/src/main/java/forge/card/CardDb.java

@@ -22,7 +22,7 @@ import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Multimaps;
 import forge.StaticData;
-import forge.card.CardEdition.EditionEntry;
+import forge.card.CardEdition.CardInSet;
 import forge.card.CardEdition.Type;
 import forge.deck.generation.IDeckGenPool;
 import forge.item.IPaperCard;
@@ -42,8 +42,7 @@ import java.util.stream.Stream;
 public final class CardDb implements ICardDatabase, IDeckGenPool {
     public final static String foilSuffix = "+";
     public final static char NameSetSeparator = '|';
-    public final static String FlagPrefix = "#";
+    public final static String colorIDPrefix = "#";
-    public static final String FlagSeparator = "\t";
     private final String exlcudedCardName = "Concentrate";
     private final String exlcudedCardSet = "DS0";
 
@@ -94,19 +93,19 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         public int artIndex;
         public boolean isFoil;
         public String collectorNumber;
-        public Map<String, String> flags;
+        public Set<String> colorID;
 
         private CardRequest(String name, String edition, int artIndex, boolean isFoil, String collectorNumber) {
             this(name, edition, artIndex, isFoil, collectorNumber, null);
         }
 
-        private CardRequest(String name, String edition, int artIndex, boolean isFoil, String collectorNumber, Map<String, String> flags) {
+        private CardRequest(String name, String edition, int artIndex, boolean isFoil, String collectorNumber, Set<String> colorID) {
             cardName = name;
             this.edition = edition;
             this.artIndex = artIndex;
             this.isFoil = isFoil;
             this.collectorNumber = collectorNumber;
-            this.flags = flags;
+            this.colorID = colorID;
         }
 
         public static boolean isFoilCardName(final String cardName){
@@ -121,8 +120,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         }
 
         public static String compose(String cardName, String setCode) {
-            if(setCode == null || StringUtils.isBlank(setCode) || setCode.equals(CardEdition.UNKNOWN_CODE))
+            setCode = setCode != null ? setCode : "";
-                setCode = "";
             cardName = cardName != null ? cardName : "";
             if (cardName.indexOf(NameSetSeparator) != -1)
                 // If cardName is another RequestString, just get card name and forget about the rest.
@@ -136,36 +134,16 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
             return requestInfo + NameSetSeparator + artIndex;
         }
 
-        public static String compose(String cardName, String setCode, String collectorNumber) {
+        public static String compose(String cardName, String setCode, int artIndex, Set<String> colorID) {
-            String requestInfo = compose(cardName, setCode);
-            // CollectorNumber will be wrapped in square brackets
-            collectorNumber = preprocessCollectorNumber(collectorNumber);
-            return requestInfo + NameSetSeparator + collectorNumber;
-        }
-
-        public static String compose(String cardName, String setCode, int artIndex, Map<String, String> flags) {
             String requestInfo = compose(cardName, setCode);
             artIndex = Math.max(artIndex, IPaperCard.DEFAULT_ART_INDEX);
-            if(flags == null)
+            String cid = colorID == null ? "" : NameSetSeparator +
-                return requestInfo + NameSetSeparator + artIndex;
+                colorID.toString().replace("[", colorIDPrefix).replace(", ", colorIDPrefix).replace("]", "");
-            return requestInfo + NameSetSeparator + artIndex + getFlagSegment(flags);
+            return requestInfo + NameSetSeparator + artIndex + cid;
         }
 
-        public static String compose(String cardName, String setCode, String collectorNumber, Map<String, String> flags) {
+        public static String compose(String cardName, String setCode, String collectorNumber) {
             String requestInfo = compose(cardName, setCode);
-            collectorNumber = preprocessCollectorNumber(collectorNumber);
-            if(flags == null || flags.isEmpty())
-                return requestInfo + NameSetSeparator + collectorNumber;
-            return requestInfo + NameSetSeparator + collectorNumber + getFlagSegment(flags);
-        }
-
-        public static String compose(PaperCard card) {
-            String name = compose(card.getName(), card.isFoil());
-            return compose(name, card.getEdition(), card.getCollectorNumber(), card.getMarkedFlags().toMap());
-        }
-
-        public static String compose(String cardName, String setCode, int artIndex, String collectorNumber) {
-            String requestInfo = compose(cardName, setCode, artIndex);
             // CollectorNumber will be wrapped in square brackets
             collectorNumber = preprocessCollectorNumber(collectorNumber);
             return requestInfo + NameSetSeparator + collectorNumber;
@@ -182,21 +160,19 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
             return collectorNumber;
         }
 
-        private static String getFlagSegment(Map<String, String> flags) {
+        public static String compose(String cardName, String setCode, int artIndex, String collectorNumber) {
-            if(flags == null)
+            String requestInfo = compose(cardName, setCode, artIndex);
-                return "";
+            // CollectorNumber will be wrapped in square brackets
-            String flagText = flags.entrySet().stream()
+            collectorNumber = preprocessCollectorNumber(collectorNumber);
-                    .map(e -> e.getKey() + "=" + e.getValue())
+            return requestInfo + NameSetSeparator + collectorNumber;
-                    .collect(Collectors.joining(FlagSeparator));
-            return NameSetSeparator + FlagPrefix + "{" + flagText + "}";
         }
 
         private static boolean isCollectorNumber(String s) {
             return s.startsWith("[") && s.endsWith("]");
         }
 
-        private static boolean isFlagSegment(String s) {
+        private static boolean isColorIDString(String s) {
-            return s.startsWith(FlagPrefix);
+            return s.startsWith(colorIDPrefix);
         }
 
         private static boolean isArtIndex(String s) {
@@ -225,36 +201,44 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                 return null;
 
             String[] info = TextUtil.split(reqInfo, NameSetSeparator);
-            int index = 1;
+            int setPos;
+            int artPos;
+            int cNrPos;
+            int clrPos;
+            if (info.length >= 4) { // name|set|artIndex|[collNr]
+                setPos = isSetCode(info[1]) ? 1 : -1;
+                artPos = isArtIndex(info[2]) ? 2 : -1;
+                cNrPos = isCollectorNumber(info[3]) ? 3 : -1;
+                int pos = cNrPos > 0 ? -1 : 3;
+                clrPos = pos > 0 ? isColorIDString(info[pos]) ? pos : -1 : -1;
+            } else if (info.length == 3) { // name|set|artIndex (or CollNr)
+                setPos = isSetCode(info[1]) ? 1 : -1;
+                artPos = isArtIndex(info[2]) ? 2 : -1;
+                cNrPos = isCollectorNumber(info[2]) ? 2 : -1;
+                int pos = cNrPos > 0 ? -1 : 2;
+                clrPos = pos > 0 ? isColorIDString(info[pos]) ? pos : -1 : -1;
+            } else if (info.length == 2) { // name|set (or artIndex, even if not possible via compose)
+                setPos = isSetCode(info[1]) ? 1 : -1;
+                artPos = isArtIndex(info[1]) ? 1 : -1;
+                cNrPos = -1;
+                clrPos = -1;
+            } else {
+                setPos = -1;
+                artPos = -1;
+                cNrPos = -1;
+                clrPos = -1;
+            }
             String cardName = info[0];
             boolean isFoil = false;
-            int artIndex = IPaperCard.NO_ART_INDEX;
-            String setCode = null;
-            String collectorNumber = IPaperCard.NO_COLLECTOR_NUMBER;
-            Map<String, String> flags = null;
             if (isFoilCardName(cardName)) {
                 cardName = cardName.substring(0, cardName.length() - foilSuffix.length());
                 isFoil = true;
             }
-
+            int artIndex = artPos > 0 ? Integer.parseInt(info[artPos]) : IPaperCard.NO_ART_INDEX;  // default: no art index
-            if(info.length > index && isSetCode(info[index])) {
+            String collectorNumber = cNrPos > 0 ? info[cNrPos].substring(1, info[cNrPos].length() - 1) : IPaperCard.NO_COLLECTOR_NUMBER;
-                setCode = info[index];
+            String setCode = setPos > 0 ? info[setPos] : null;
-                index++;
+            Set<String> colorID = clrPos > 0 ? Arrays.stream(info[clrPos].substring(1).split(colorIDPrefix)).collect(Collectors.toSet()) : null;
-            }
+            if (setCode != null && setCode.equals(CardEdition.UNKNOWN.getCode())) {  // ???
-            if(info.length > index && isArtIndex(info[index])) {
-                artIndex = Integer.parseInt(info[index]);
-                index++;
-            }
-            if(info.length > index && isCollectorNumber(info[index])) {
-                collectorNumber = info[index].substring(1, info[index].length() - 1);
-                index++;
-            }
-            if (info.length > index && isFlagSegment(info[index])) {
-                String flagText = info[index].substring(FlagPrefix.length());
-                flags = parseRequestFlags(flagText);
-            }
-
-            if (CardEdition.UNKNOWN_CODE.equals(setCode)) {  // ???
                 setCode = null;
             }
             if (setCode == null) {
@@ -269,29 +253,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
             // finally, check whether any between artIndex and CollectorNumber has been set
             if (collectorNumber.equals(IPaperCard.NO_COLLECTOR_NUMBER) && artIndex == IPaperCard.NO_ART_INDEX)
                 artIndex = IPaperCard.DEFAULT_ART_INDEX;
-            return new CardRequest(cardName, setCode, artIndex, isFoil, collectorNumber, flags);
+            return new CardRequest(cardName, setCode, artIndex, isFoil, collectorNumber, colorID);
-        }
-
-        private static Map<String, String> parseRequestFlags(String flagText) {
-            flagText = flagText.trim();
-            if(flagText.isEmpty())
-                return null;
-            if(!flagText.startsWith("{")) {
-                //Legacy form for marked colors. They'll be of the form "W#B#R"
-                Map<String, String> flags = new HashMap<>();
-                String normalizedColorString = ColorSet.fromNames(flagText.split(FlagPrefix)).toString();
-                flags.put("markedColors", String.join("", normalizedColorString));
-                return flags;
-            }
-            flagText = flagText.substring(1, flagText.length() - 1); //Trim the braces.
-            //List of flags, a series of "key=value" text broken up by tabs.
-            return Arrays.stream(flagText.split(FlagSeparator))
-                    .map(f -> f.split("=", 2))
-                    .filter(f -> f.length > 0)
-                    .collect(Collectors.toMap(
-                            entry -> entry[0],
-                            entry -> entry.length > 1 ? entry[1] : "true" //If there's no '=' in the entry, treat it as a boolean flag.
-                    ));
         }
     }
 
@@ -332,27 +294,27 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         }
     }
 
-    private void addSetCard(CardEdition e, EditionEntry cis, CardRules cr) {
+    private void addSetCard(CardEdition e, CardInSet cis, CardRules cr) {
         int artIdx = IPaperCard.DEFAULT_ART_INDEX;
-        String key = e.getCode() + "/" + cis.name();
+        String key = e.getCode() + "/" + cis.name;
         if (artIds.containsKey(key)) {
             artIdx = artIds.get(key) + 1;
         }
 
         artIds.put(key, artIdx);
-        addCard(new PaperCard(cr, e.getCode(), cis.rarity(), artIdx, false, cis.collectorNumber(), cis.artistName(), cis.functionalVariantName()));
+        addCard(new PaperCard(cr, e.getCode(), cis.rarity, artIdx, false, cis.collectorNumber, cis.artistName, cis.functionalVariantName));
     }
 
     private boolean addFromSetByName(String cardName, CardEdition ed, CardRules cr) {
-        List<EditionEntry> cardsInSet = ed.getCardInSet(cardName);  // empty collection if not present
+        List<CardInSet> cardsInSet = ed.getCardInSet(cardName);  // empty collection if not present
         if (cr.hasFunctionalVariants()) {
-            cardsInSet = cardsInSet.stream().filter(c -> StringUtils.isEmpty(c.functionalVariantName())
+            cardsInSet = cardsInSet.stream().filter(c -> StringUtils.isEmpty(c.functionalVariantName)
-                    || cr.getSupportedFunctionalVariants().contains(c.functionalVariantName())
+                    || cr.getSupportedFunctionalVariants().contains(c.functionalVariantName)
             ).collect(Collectors.toList());
         }
         if (cardsInSet.isEmpty())
             return false;
-        for (EditionEntry cis : cardsInSet) {
+        for (CardInSet cis : cardsInSet) {
             addSetCard(ed, cis, cr);
         }
         return true;
@@ -397,15 +359,15 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                 upcomingSet = e;
             }
 
-            for (CardEdition.EditionEntry cis : e.getAllCardsInSet()) {
+            for (CardEdition.CardInSet cis : e.getAllCardsInSet()) {
-                CardRules cr = rulesByName.get(cis.name());
+                CardRules cr = rulesByName.get(cis.name);
                 if (cr == null) {
-                    missingCards.add(cis.name());
+                    missingCards.add(cis.name);
                     continue;
                 }
                 if (cr.hasFunctionalVariants()) {
-                    if (StringUtils.isNotEmpty(cis.functionalVariantName())
+                    if (StringUtils.isNotEmpty(cis.functionalVariantName)
-                        && !cr.getSupportedFunctionalVariants().contains(cis.functionalVariantName())) {
+                        && !cr.getSupportedFunctionalVariants().contains(cis.functionalVariantName)) {
                         //Supported card, unsupported variant.
                         //Could note the card as missing but since these are often un-cards,
                         //it's likely absent because it does something out of scope.
@@ -444,7 +406,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                         addCard(new PaperCard(cr, upcomingSet.getCode(), CardRarity.Unknown));
                     } else if (enableUnknownCards && !this.filtered.contains(cr.getName())) {
                         System.err.println("The card " + cr.getName() + " was not assigned to any set. Adding it to UNKNOWN set... to fix see res/editions/ folder. ");
-                        addCard(new PaperCard(cr, CardEdition.UNKNOWN_CODE, CardRarity.Special));
+                        addCard(new PaperCard(cr, CardEdition.UNKNOWN.getCode(), CardRarity.Special));
                     }
                 } else {
                     System.err.println("The custom card " + cr.getName() + " was not assigned to any set. Adding it to custom USER set, and will try to load custom art from USER edition.");
@@ -463,8 +425,8 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
             lang = new LangEnglish();
         }
         // for now just check Universes Within
-        for (EditionEntry cis : editions.get("SLX").getCards()) {
+        for (CardInSet cis : editions.get("SLX").getCards()) {
-            String orgName = alternateName.get(cis.name());
+            String orgName = alternateName.get(cis.name);
             if (orgName != null) {
                 // found original (beyond) print
                 CardRules org = getRules(orgName);
@@ -494,7 +456,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                 CardRules within = new CardRules(new ICardFace[] { renamedMain, renamedOther, null, null, null, null, null }, org.getSplitType(), org.getAiHints());
                 // so workshop can edit same script
                 within.setNormalizedName(org.getNormalizedName());
-                rulesByName.put(cis.name(), within);
+                rulesByName.put(cis.name, within);
             }
         }
     }
@@ -630,15 +592,15 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
     }
 
     @Override
-    public PaperCard getCard(final String cardName, String setCode, int artIndex, Map<String, String> flags) {
+    public PaperCard getCard(final String cardName, String setCode, int artIndex, String collectorNumber) {
-        String reqInfo = CardRequest.compose(cardName, setCode, artIndex, flags);
+        String reqInfo = CardRequest.compose(cardName, setCode, artIndex, collectorNumber);
         CardRequest request = CardRequest.fromString(reqInfo);
         return tryGetCard(request);
     }
 
     @Override
-    public PaperCard getCard(final String cardName, String setCode, String collectorNumber, Map<String, String> flags) {
+    public PaperCard getCard(final String cardName, String setCode, int artIndex, Set<String> colorID) {
-        String reqInfo = CardRequest.compose(cardName, setCode, collectorNumber, flags);
+        String reqInfo = CardRequest.compose(cardName, setCode, artIndex, colorID);
         CardRequest request = CardRequest.fromString(reqInfo);
         return tryGetCard(request);
     }
@@ -649,17 +611,14 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
             return null;
         // 1. First off, try using all possible search parameters, to narrow down the actual cards looked for.
         String reqEditionCode = request.edition;
-        if (reqEditionCode != null && !reqEditionCode.isEmpty()) {
+        if (reqEditionCode != null && reqEditionCode.length() > 0) {
             // This get is robust even against expansion aliases (e.g. TE and TMP both valid for Tempest) -
             // MOST of the extensions have two short codes, 141 out of 221 (so far)
             // ALSO: Set Code are always UpperCase
             CardEdition edition = editions.get(reqEditionCode.toUpperCase());
 
-            PaperCard cardFromSet = this.getCardFromSet(request.cardName, edition, request.artIndex, request.collectorNumber, request.isFoil);
+            return this.getCardFromSet(request.cardName, edition, request.artIndex,
-            if(cardFromSet != null && request.flags != null)
+                    request.collectorNumber, request.isFoil, request.colorID);
-                cardFromSet = cardFromSet.copyWithFlags(request.flags);
-
-            return cardFromSet;
         }
 
         // 2. Card lookup in edition with specified filter didn't work.
@@ -702,6 +661,11 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
 
     @Override
     public PaperCard getCardFromSet(String cardName, CardEdition edition, int artIndex, String collectorNumber, boolean isFoil) {
+        return getCardFromSet(cardName, edition, artIndex, collectorNumber, isFoil, null);
+    }
+
+    @Override
+    public PaperCard getCardFromSet(String cardName, CardEdition edition, int artIndex, String collectorNumber, boolean isFoil, Set<String> colorID) {
         if (edition == null || cardName == null)  // preview cards
             return null;  // No cards will be returned
 
@@ -710,18 +674,18 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         cardName = cardNameRequest.cardName;
         isFoil = isFoil || cardNameRequest.isFoil;
 
-        String code1 = edition.getCode(), code2 = edition.getCode2();
+        List<PaperCard> candidates = getAllCards(cardName, c -> {
-
+            boolean artIndexFilter = true;
-        Predicate<PaperCard> filter = (c) -> {
+            boolean collectorNumberFilter = true;
-            String ed = c.getEdition();
+            boolean setFilter = c.getEdition().equalsIgnoreCase(edition.getCode()) ||
-            return ed.equalsIgnoreCase(code1) || ed.equalsIgnoreCase(code2);
+                    c.getEdition().equalsIgnoreCase(edition.getCode2());
-        };
+            if (artIndex > 0)
-        if (artIndex > 0)
+                artIndexFilter = (c.getArtIndex() == artIndex);
-            filter = filter.and((c) -> artIndex == c.getArtIndex());
+            if ((collectorNumber != null) && (collectorNumber.length() > 0)
-        if (collectorNumber != null && !collectorNumber.isEmpty() && !collectorNumber.equals(IPaperCard.NO_COLLECTOR_NUMBER))
+                    && !(collectorNumber.equals(IPaperCard.NO_COLLECTOR_NUMBER)))
-            filter = filter.and((c) -> collectorNumber.equals(c.getCollectorNumber()));
+                collectorNumberFilter = (c.getCollectorNumber().equals(collectorNumber));
-
+            return setFilter && artIndexFilter && collectorNumberFilter;
-        List<PaperCard> candidates = getAllCards(cardName, filter);
+        });
         if (candidates.isEmpty())
             return null;
 
@@ -735,7 +699,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         while (!candidate.hasImage() && candidatesIterator.hasNext())
             candidate = candidatesIterator.next();
         candidate = candidate.hasImage() ? candidate : firstCandidate;
-        return isFoil ? candidate.getFoiled() : candidate;
+        return isFoil ? candidate.getFoiled().getColorIDVersion(colorID) : candidate.getColorIDVersion(colorID);
     }
 
     /*
@@ -778,6 +742,11 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         return this.tryToGetCardFromEditions(cardInfo, artPreference, artIndex, filter);
     }
 
+    @Override
+    public PaperCard getCardFromEditions(final String cardInfo, final CardArtPreference artPreference, int artIndex, Set<String> colorID) {
+        return this.tryToGetCardFromEditions(cardInfo, artPreference, artIndex, null, false, null, colorID);
+    }
+
     /*
      * ===============================================
      * 4. SPECIALISED CARD LOOKUP BASED ON
@@ -851,7 +820,12 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
     }
 
     private PaperCard tryToGetCardFromEditions(String cardInfo, CardArtPreference artPreference, int artIndex,
-                                               Date releaseDate, boolean releasedBeforeFlag, Predicate<PaperCard> filter) {
+                                               Date releaseDate, boolean releasedBeforeFlag, Predicate<PaperCard> filter){
+        return this.tryToGetCardFromEditions(cardInfo, artPreference, artIndex, releaseDate, releasedBeforeFlag, filter, null);
+    }
+
+    private PaperCard tryToGetCardFromEditions(String cardInfo, CardArtPreference artPreference, int artIndex,
+                                               Date releaseDate, boolean releasedBeforeFlag, Predicate<PaperCard> filter, Set<String> colorID){
         if (cardInfo == null)
             return null;
         final CardRequest cr = CardRequest.fromString(cardInfo);
@@ -891,7 +865,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         for (PaperCard card : cards) {
             String setCode = card.getEdition();
             CardEdition ed;
-            if (setCode.equals(CardEdition.UNKNOWN_CODE))
+            if (setCode.equals(CardEdition.UNKNOWN.getCode()))
                 ed = CardEdition.UNKNOWN;
             else
                 ed = editions.get(card.getEdition());
@@ -932,7 +906,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         }
         candidate = candidate.hasImage() ? candidate : firstCandidate;
         //If any, we're sure that at least one candidate is always returned despite it having any image
-        return cr.isFoil ? candidate.getFoiled() : candidate;
+        return cr.isFoil ? candidate.getFoiled().getColorIDVersion(colorID) : candidate.getColorIDVersion(colorID);
     }
 
     @Override
@@ -1043,7 +1017,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
     public static final Predicate<PaperCard> EDITION_NON_PROMO = paperCard -> {
         String code = paperCard.getEdition();
         CardEdition edition = StaticData.instance().getCardEdition(code);
-        if(edition == null && code.equals(CardEdition.UNKNOWN_CODE))
+        if(edition == null && code.equals("???"))
             return true;
         return edition != null && edition.getType() != Type.PROMO;
     };
@@ -1051,7 +1025,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
     public static final Predicate<PaperCard> EDITION_NON_REPRINT = paperCard -> {
         String code = paperCard.getEdition();
         CardEdition edition = StaticData.instance().getCardEdition(code);
-        if(edition == null && code.equals(CardEdition.UNKNOWN_CODE))
+        if(edition == null && code.equals("???"))
             return true;
         return edition != null && Type.REPRINT_SET_TYPES.contains(edition.getType());
     };
@@ -1107,8 +1081,8 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
     public Collection<PaperCard> getAllCards(CardEdition edition) {
         List<PaperCard> cards = Lists.newArrayList();
 
-        for (EditionEntry cis : edition.getAllCardsInSet()) {
+        for (CardInSet cis : edition.getAllCardsInSet()) {
-            PaperCard card = this.getCard(cis.name(), edition.getCode());
+            PaperCard card = this.getCard(cis.name, edition.getCode());
             if (card == null) {
                 // Just in case the card is listed in the edition file but Forge doesn't support it
                 continue;
@@ -1152,6 +1126,29 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                 .anyMatch(rarity::equals);
     }
 
+    public StringBuilder appendCardToStringBuilder(PaperCard card, StringBuilder sb) {
+        final boolean hasBadSetInfo = card.getEdition().equals(CardEdition.UNKNOWN.getCode()) || StringUtils.isBlank(card.getEdition());
+        sb.append(card.getName());
+        if (card.isFoil()) {
+            sb.append(CardDb.foilSuffix);
+        }
+
+        if (!hasBadSetInfo) {
+            int artCount = getArtCount(card.getName(), card.getEdition(), card.getFunctionalVariant());
+            sb.append(CardDb.NameSetSeparator).append(card.getEdition());
+            if (artCount >= IPaperCard.DEFAULT_ART_INDEX) {
+                sb.append(CardDb.NameSetSeparator).append(card.getArtIndex()); // indexes start at 1 to match image file name conventions
+            }
+            if (card.getColorID() != null) {
+                sb.append(CardDb.NameSetSeparator);
+                for (String color : card.getColorID())
+                    sb.append(CardDb.colorIDPrefix).append(color);
+            }
+        }
+
+        return sb;
+    }
+
     public PaperCard createUnsupportedCard(String cardRequest) {
         CardRequest request = CardRequest.fromString(cardRequest);
         CardEdition cardEdition = CardEdition.UNKNOWN;
@@ -1160,10 +1157,10 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         // May iterate over editions and find out if there is any card named 'cardRequest' but not implemented with Forge script.
         if (StringUtils.isBlank(request.edition)) {
             for (CardEdition edition : editions) {
-                for (EditionEntry cardInSet : edition.getAllCardsInSet()) {
+                for (CardInSet cardInSet : edition.getAllCardsInSet()) {
-                    if (cardInSet.name().equals(request.cardName)) {
+                    if (cardInSet.name.equals(request.cardName)) {
                         cardEdition = edition;
-                        cardRarity = cardInSet.rarity();
+                        cardRarity = cardInSet.rarity;
                         break;
                     }
                 }
@@ -1174,9 +1171,9 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
         } else {
             cardEdition = editions.get(request.edition);
             if (cardEdition != null) {
-                for (EditionEntry cardInSet : cardEdition.getAllCardsInSet()) {
+                for (CardInSet cardInSet : cardEdition.getAllCardsInSet()) {
-                    if (cardInSet.name().equals(request.cardName)) {
+                    if (cardInSet.name.equals(request.cardName)) {
-                        cardRarity = cardInSet.rarity();
+                        cardRarity = cardInSet.rarity;
                         break;
                     }
                 }
@@ -1227,9 +1224,9 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                 // @leriomaggio: DONE! re-using here the same strategy implemented for lazy-loading!
                 for (CardEdition e : editions.getOrderedEditions()) {
                     int artIdx = IPaperCard.DEFAULT_ART_INDEX;
-                    for (EditionEntry cis : e.getCardInSet(cardName))
+                    for (CardInSet cis : e.getCardInSet(cardName))
-                        paperCards.add(new PaperCard(rules, e.getCode(), cis.rarity(), artIdx++, false,
+                        paperCards.add(new PaperCard(rules, e.getCode(), cis.rarity, artIdx++, false,
-                                                     cis.collectorNumber(), cis.artistName(), cis.functionalVariantName()));
+                                                     cis.collectorNumber, cis.artistName, cis.functionalVariantName));
                 }
             } else {
                 String lastEdition = null;
@@ -1243,17 +1240,17 @@ public final class CardDb implements ICardDatabase, IDeckGenPool {
                     if (ed == null) {
                         continue;
                     }
-                    List<EditionEntry> cardsInSet = ed.getCardInSet(cardName);
+                    List<CardInSet> cardsInSet = ed.getCardInSet(cardName);
                     if (cardsInSet.isEmpty())
                         continue;
                     int cardInSetIndex = Math.max(artIdx-1, 0); // make sure doesn't go below zero
-                    EditionEntry cds = cardsInSet.get(cardInSetIndex);  // use ArtIndex to get the right Coll. Number
+                    CardInSet cds = cardsInSet.get(cardInSetIndex);  // use ArtIndex to get the right Coll. Number
                     paperCards.add(new PaperCard(rules, lastEdition, tuple.getValue(), artIdx++, false,
-                                                 cds.collectorNumber(), cds.artistName(), cds.functionalVariantName()));
+                                                 cds.collectorNumber, cds.artistName, cds.functionalVariantName));
                 }
             }
             if (paperCards.isEmpty()) {
-                paperCards.add(new PaperCard(rules, CardEdition.UNKNOWN_CODE, CardRarity.Special));
+                paperCards.add(new PaperCard(rules, CardEdition.UNKNOWN.getCode(), CardRarity.Special));
             }
             // 2. add them to db
             for (PaperCard paperCard : paperCards) {

forge-core/src/main/java/forge/card/CardEdition.java

@@ -18,7 +18,6 @@
 package forge.card;
 
 import com.google.common.collect.*;
-
 import forge.StaticData;
 import forge.card.CardDb.CardArtPreference;
 import forge.deck.CardPool;
@@ -166,49 +165,20 @@ public final class CardEdition implements Comparable<CardEdition> {
         }
     }
 
-    private static final Map<String, String> sortableCollNumberLookup = new HashMap<>();
+    public static class CardInSet implements Comparable<CardInSet> {
-    /**
+        public final CardRarity rarity;
-     * This method implements the main strategy to allow for natural ordering of collectorNumber
+        public final String collectorNumber;
-     * (i.e. "1" < "10"), overloading the default lexicographic order (i.e. "10" < "1").
+        public final String name;
-     * Any non-numerical parts in the input collectorNumber will be also accounted for, and attached to the
+        public final String artistName;
-     * resulting sorting key, accordingly.
+        public final String functionalVariantName;
-     *
-     * @param collectorNumber: Input collectorNumber tro transform in a Sorting Key
-     * @return A 5-digits zero-padded collector number + any non-numerical parts attached.
-     */
-    public static String getSortableCollectorNumber(final String collectorNumber){
-        String inputCollNumber = collectorNumber;
-        if (collectorNumber == null || collectorNumber.isEmpty())
-            inputCollNumber = "50000";  // very big number of 5 digits to have them in last positions
 
-        String matchedCollNr = sortableCollNumberLookup.getOrDefault(inputCollNumber, null);
+        public CardInSet(final String name, final String collectorNumber, final CardRarity rarity, final String artistName, final String functionalVariantName) {
-        if (matchedCollNr != null)
+            this.name = name;
-            return  matchedCollNr;
+            this.collectorNumber = collectorNumber;
-
+            this.rarity = rarity;
-        // Now, for proper sorting, let's zero-pad the collector number (if integer)
+            this.artistName = artistName;
-        int collNr;
+            this.functionalVariantName = functionalVariantName;
-        String sortableCollNr;
-        try {
-            collNr = Integer.parseInt(inputCollNumber);
-            sortableCollNr = String.format("%05d", collNr);
-        } catch (NumberFormatException ex) {
-            String nonNumSub = inputCollNumber.replaceAll("[0-9]", "");
-            String onlyNumSub = inputCollNumber.replaceAll("[^0-9]", "");
-            try {
-                collNr = Integer.parseInt(onlyNumSub);
-            } catch (NumberFormatException exon) {
-                collNr = 0; // this is the case of ONLY-letters collector numbers
-            }
-            if ((collNr > 0) && (inputCollNumber.startsWith(onlyNumSub))) // e.g. 12a, 37+, 2018f,
-                sortableCollNr = String.format("%05d", collNr) + nonNumSub;
-            else // e.g. WS6, S1
-                sortableCollNr = nonNumSub + String.format("%05d", collNr);
         }
-        sortableCollNumberLookup.put(inputCollNumber, sortableCollNr);
-        return sortableCollNr;
-    }
-
-    public record EditionEntry(String name, String collectorNumber, CardRarity rarity, String artistName, String functionalVariantName) implements Comparable<EditionEntry> {
 
         public String toString() {
             StringBuilder sb = new StringBuilder();
@@ -216,7 +186,7 @@ public final class CardEdition implements Comparable<CardEdition> {
                 sb.append(collectorNumber);
                 sb.append(' ');
             }
-            if (rarity != CardRarity.Unknown && rarity != CardRarity.Token) {
+            if (rarity != CardRarity.Unknown) {
                 sb.append(rarity);
                 sb.append(' ');
             }
@@ -232,8 +202,50 @@ public final class CardEdition implements Comparable<CardEdition> {
             return sb.toString();
         }
 
+        private static final Map<String, String> sortableCollNumberLookup = new HashMap<>();
+        /**
+         * This method implements the main strategy to allow for natural ordering of collectorNumber
+         * (i.e. "1" < "10"), overloading the default lexicographic order (i.e. "10" < "1").
+         * Any non-numerical parts in the input collectorNumber will be also accounted for, and attached to the
+         * resulting sorting key, accordingly.
+         *
+         * @param collectorNumber: Input collectorNumber tro transform in a Sorting Key
+         * @return A 5-digits zero-padded collector number + any non-numerical parts attached.
+         */
+        public static String getSortableCollectorNumber(final String collectorNumber){
+            String inputCollNumber = collectorNumber;
+            if (collectorNumber == null || collectorNumber.isEmpty())
+                inputCollNumber = "50000";  // very big number of 5 digits to have them in last positions
+
+            String matchedCollNr = sortableCollNumberLookup.getOrDefault(inputCollNumber, null);
+            if (matchedCollNr != null)
+                return  matchedCollNr;
+
+            // Now, for proper sorting, let's zero-pad the collector number (if integer)
+            int collNr;
+            String sortableCollNr;
+            try {
+                collNr = Integer.parseInt(inputCollNumber);
+                sortableCollNr = String.format("%05d", collNr);
+            } catch (NumberFormatException ex) {
+                String nonNumSub = inputCollNumber.replaceAll("[0-9]", "");
+                String onlyNumSub = inputCollNumber.replaceAll("[^0-9]", "");
+                try {
+                    collNr = Integer.parseInt(onlyNumSub);
+                } catch (NumberFormatException exon) {
+                    collNr = 0; // this is the case of ONLY-letters collector numbers
+                }
+                if ((collNr > 0) && (inputCollNumber.startsWith(onlyNumSub))) // e.g. 12a, 37+, 2018f,
+                    sortableCollNr = String.format("%05d", collNr) + nonNumSub;
+                else // e.g. WS6, S1
+                    sortableCollNr = nonNumSub + String.format("%05d", collNr);
+            }
+            sortableCollNumberLookup.put(inputCollNumber, sortableCollNr);
+            return sortableCollNr;
+        }
+
         @Override
-        public int compareTo(EditionEntry o) {
+        public int compareTo(CardInSet o) {
             final int nameCmp = name.compareToIgnoreCase(o.name);
             if (0 != nameCmp) {
                 return nameCmp;
@@ -250,17 +262,11 @@ public final class CardEdition implements Comparable<CardEdition> {
 
     private final static SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd");
 
-    /**
+    public static final CardEdition UNKNOWN = new CardEdition("1990-01-01", "???", "??", Type.UNKNOWN, "Undefined", FoilType.NOT_SUPPORTED, new CardInSet[]{});
-     * Equivalent to the set code of CardEdition.UNKNOWN
-     */
-    public static final String UNKNOWN_CODE = "???";
-    public static final CardEdition UNKNOWN = new CardEdition("1990-01-01", UNKNOWN_CODE, "??", Type.UNKNOWN, "Undefined", FoilType.NOT_SUPPORTED, new EditionEntry[]{});
     private Date date;
     private String code;
     private String code2;
     private String scryfallCode;
-    private String tokensCode;
-    private String tokenFallbackCode;
     private String cardsLanguage;
     private Type   type;
     private String name;
@@ -290,32 +296,31 @@ public final class CardEdition implements Comparable<CardEdition> {
     private String doublePickDuringDraft = "";
     private String[] chaosDraftThemes = new String[0];
 
-    private final ListMultimap<String, EditionEntry> cardMap;
+    private final ListMultimap<String, CardInSet> cardMap;
-    private final List<EditionEntry> cardsInSet;
+    private final List<CardInSet> cardsInSet;
-    private final ListMultimap<String, EditionEntry> tokenMap;
+    private final Map<String, Integer> tokenNormalized;
     // custom print sheets that will be loaded lazily
     private final Map<String, List<String>> customPrintSheetsToParse;
-    private ListMultimap<String, EditionEntry> otherMap = ArrayListMultimap.create();
 
     private int boosterArts = 1;
     private SealedTemplate boosterTpl = null;
     private final Map<String, SealedTemplate> boosterTemplates = new HashMap<>();
 
-    private CardEdition(ListMultimap<String, EditionEntry> cardMap, ListMultimap<String, EditionEntry> tokens, Map<String, List<String>> customPrintSheetsToParse) {
+    private CardEdition(ListMultimap<String, CardInSet> cardMap, Map<String, Integer> tokens, Map<String, List<String>> customPrintSheetsToParse) {
         this.cardMap = cardMap;
         this.cardsInSet = new ArrayList<>(cardMap.values());
         Collections.sort(cardsInSet);
-        this.tokenMap = tokens;
+        this.tokenNormalized = tokens;
         this.customPrintSheetsToParse = customPrintSheetsToParse;
     }
 
-    private CardEdition(EditionEntry[] cards, ListMultimap<String, EditionEntry> tokens) {
+    private CardEdition(CardInSet[] cards, Map<String, Integer> tokens) {
-        List<EditionEntry> cardsList = Arrays.asList(cards);
+        List<CardInSet> cardsList = Arrays.asList(cards);
         this.cardMap = ArrayListMultimap.create();
         this.cardMap.replaceValues("cards", cardsList);
         this.cardsInSet = new ArrayList<>(cardsList);
         Collections.sort(cardsInSet);
-        this.tokenMap = tokens;
+        this.tokenNormalized = tokens;
         this.customPrintSheetsToParse = new HashMap<>();
     }
 
@@ -332,8 +337,8 @@ public final class CardEdition implements Comparable<CardEdition> {
      * @param name the name of the set
      * @param cards the cards in the set
      */
-    private CardEdition(String date, String code, String code2, Type type, String name, FoilType foil, EditionEntry[] cards) {
+    private CardEdition(String date, String code, String code2, Type type, String name, FoilType foil, CardInSet[] cards) {
-        this(cards, ArrayListMultimap.create());
+        this(cards, new HashMap<>());
         this.code  = code;
         this.code2 = code2;
         this.type  = type;
@@ -356,7 +361,6 @@ public final class CardEdition implements Comparable<CardEdition> {
     public String getCode()  { return code;  }
     public String getCode2() { return code2; }
     public String getScryfallCode() { return scryfallCode.toLowerCase(); }
-    public String getTokensCode() { return tokensCode.toLowerCase(); }
     public String getCardsLangCode() { return cardsLanguage.toLowerCase(); }
     public Type   getType()  { return type;  }
     public String getName()  { return name;  }
@@ -381,14 +385,14 @@ public final class CardEdition implements Comparable<CardEdition> {
     public String getSheetReplaceCardFromSheet2() { return sheetReplaceCardFromSheet2; }
     public String[] getChaosDraftThemes() { return chaosDraftThemes; }
 
-    public List<EditionEntry> getCards() { return cardMap.get(EditionSectionWithCollectorNumbers.CARDS.getName()); }
+    public List<CardInSet> getCards() { return cardMap.get(EditionSectionWithCollectorNumbers.CARDS.getName()); }
-    public List<EditionEntry> getRebalancedCards() { return cardMap.get(EditionSectionWithCollectorNumbers.REBALANCED.getName()); }
+    public List<CardInSet> getRebalancedCards() { return cardMap.get(EditionSectionWithCollectorNumbers.REBALANCED.getName()); }
-    public List<EditionEntry> getFunnyEternalCards() { return cardMap.get(EditionSectionWithCollectorNumbers.ETERNAL.getName()); }
+    public List<CardInSet> getFunnyEternalCards() { return cardMap.get(EditionSectionWithCollectorNumbers.ETERNAL.getName()); }
-    public List<EditionEntry> getAllCardsInSet() {
+    public List<CardInSet> getAllCardsInSet() {
         return cardsInSet;
     }
 
-    private ListMultimap<String, EditionEntry> cardsInSetLookupMap = null;
+    private ListMultimap<String, CardInSet> cardsInSetLookupMap = null;
 
     /**
      * Get all the CardInSet instances with the input card name.
@@ -396,12 +400,12 @@ public final class CardEdition implements Comparable<CardEdition> {
      * @return A List of all the CardInSet instances for a given name.
      * If not fount, an Empty sequence (view) will be returned instead!
      */
-    public List<EditionEntry> getCardInSet(String cardName){
+    public List<CardInSet> getCardInSet(String cardName){
         if (cardsInSetLookupMap == null) {
             // initialise
             cardsInSetLookupMap = Multimaps.newListMultimap(new TreeMap<>(String.CASE_INSENSITIVE_ORDER), Lists::newArrayList);
-            List<EditionEntry> cardsInSet = this.getAllCardsInSet();
+            List<CardInSet> cardsInSet = this.getAllCardsInSet();
-            for (EditionEntry cis : cardsInSet){
+            for (CardInSet cis : cardsInSet){
                 String key = cis.name;
                 cardsInSetLookupMap.put(key, cis);
             }
@@ -409,19 +413,8 @@ public final class CardEdition implements Comparable<CardEdition> {
         return this.cardsInSetLookupMap.get(cardName);
     }
 
-    public EditionEntry getCardFromCollectorNumber(String collectorNumber) {
-        if(collectorNumber == null || collectorNumber.isEmpty())
-            return null;
-        for(EditionEntry c : this.cardsInSet) {
-            //Could build a map for this one too if it's used for more than one-offs.
-            if (c.collectorNumber.equalsIgnoreCase(collectorNumber))
-                return c;
-        }
-        return null;
-    }
-
     public boolean isRebalanced(String cardName) {
-        for (EditionEntry cis : getRebalancedCards()) {
+        for (CardInSet cis : getRebalancedCards()) {
             if (cis.name.equals(cardName)) {
                 return true;
             }
@@ -431,33 +424,7 @@ public final class CardEdition implements Comparable<CardEdition> {
 
     public boolean isModern() { return getDate().after(parseDate("2003-07-27")); } //8ED and above are modern except some promo cards and others
 
-    public Multimap<String, EditionEntry> getTokens() { return tokenMap; }
+    public Map<String, Integer> getTokens() { return tokenNormalized; }
-
-    public String getTokenSet(String token) {
-        if (tokenMap.containsKey(token)) {
-            return this.getCode();
-        }
-        if (this.tokenFallbackCode != null) {
-            return StaticData.instance().getCardEdition(this.tokenFallbackCode).getTokenSet(token);
-        }
-        return null;
-    }
-    public String getOtherSet(String token) {
-        if (otherMap.containsKey(token)) {
-            return this.getCode();
-        }
-        if (this.tokenFallbackCode != null) {
-            return StaticData.instance().getCardEdition(this.tokenFallbackCode).getOtherSet(token);
-        }
-        return null;
-    }
-
-    public EditionEntry findOther(String name) {
-        if (otherMap.containsKey(name)) {
-            return Aggregates.random(otherMap.get(name));
-        }
-        return null;
-    }
 
     @Override
     public int compareTo(final CardEdition o) {
@@ -541,8 +508,8 @@ public final class CardEdition implements Comparable<CardEdition> {
         for (String sectionName : cardMap.keySet()) {
             PrintSheet sheet = new PrintSheet(String.format("%s %s", this.getCode(), sectionName));
 
-            List<EditionEntry> cards = cardMap.get(sectionName);
+            List<CardInSet> cards = cardMap.get(sectionName);
-            for (EditionEntry card : cards) {
+            for (CardInSet card : cards) {
                 int index = 1;
                 if (cardToIndex.containsKey(card.name)) {
                     index = cardToIndex.get(card.name) + 1;
@@ -595,7 +562,6 @@ public final class CardEdition implements Comparable<CardEdition> {
             it should also match the Un-set and older alternate art cards
             like Merseine from FEM.
              */
-            // Collector numbers now should allow hyphens for Planeswalker Championship Promos
             //"(^(?<cnum>[0-9]+.?) )?((?<rarity>[SCURML]) )?(?<name>.*)$"
             /*  Ideally we'd use the named group above, but Android 6 and
                 earlier don't appear to support named groups.
@@ -609,20 +575,12 @@ public final class CardEdition implements Comparable<CardEdition> {
                     * functional variant name - grouping #9
              */
 //                "(^(.?[0-9A-Z]+.?))?(([SCURML]) )?(.*)$"
-                    "(^(.?[0-9A-Z-]+\\S?[A-Z]*)\\s)?(([SCURML])\\s)?([^@\\$]*)( @([^\\$]*))?( \\$(.+))?$"
+                    "(^(.?[0-9A-Z]+\\S?[A-Z]*)\\s)?(([SCURML])\\s)?([^@\\$]*)( @([^\\$]*))?( \\$(.+))?$"
             );
 
-            final Pattern tokenPattern = Pattern.compile(
+            ListMultimap<String, CardInSet> cardMap = ArrayListMultimap.create();
-                    /*
-                     * cnum - grouping #2
-                     * name - grouping #3
-                     * artist name - grouping #5
-                     */
-                    "(^(.?[0-9A-Z]+\\S?[A-Z]*)\\s)?([^@]*)( @(.*))?$"
-            );
-
-            ListMultimap<String, EditionEntry> cardMap = ArrayListMultimap.create();
             List<BoosterSlot> boosterSlots = null;
+            Map<String, Integer> tokenNormalized = new HashMap<>();
             Map<String, List<String>> customPrintSheetsToParse = new HashMap<>();
             List<String> editionSectionsWithCollectorNumbers = EditionSectionWithCollectorNumbers.getNames();
 
@@ -653,7 +611,7 @@ public final class CardEdition implements Comparable<CardEdition> {
                         String cardName = matcher.group(5);
                         String artistName = matcher.group(7);
                         String functionalVariantName = matcher.group(9);
-                        EditionEntry cis = new EditionEntry(cardName, collectorNumber, r, artistName, functionalVariantName);
+                        CardInSet cis = new CardInSet(cardName, collectorNumber, r, artistName, functionalVariantName);
 
                         cardMap.put(sectionName, cis);
                     }
@@ -667,58 +625,40 @@ public final class CardEdition implements Comparable<CardEdition> {
                 }
             }
 
-            ListMultimap<String, EditionEntry> tokenMap = ArrayListMultimap.create();
-            ListMultimap<String, EditionEntry> otherMap = ArrayListMultimap.create();
             // parse tokens section
             if (contents.containsKey("tokens")) {
                 for (String line : contents.get("tokens")) {
                     if (StringUtils.isBlank(line))
                         continue;
-                    Matcher matcher = tokenPattern.matcher(line);
 
-                    if (!matcher.matches()) {
+                    if (!tokenNormalized.containsKey(line)) {
-                        continue;
+                        tokenNormalized.put(line, 1);
+                    } else {
+                        tokenNormalized.put(line, tokenNormalized.get(line) + 1);
                     }
-
-                    String collectorNumber = matcher.group(2);
-                    String cardName = matcher.group(3);
-                    String artistName = matcher.group(5);
-                    // rarity isn't used for this anyway
-                    EditionEntry tis = new EditionEntry(cardName, collectorNumber, CardRarity.Token, artistName, null);
-                    tokenMap.put(cardName, tis);
-                }
-            }
-            if (contents.containsKey("other")) {
-                for (String line : contents.get("other")) {
-                    if (StringUtils.isBlank(line))
-                        continue;
-                    Matcher matcher = tokenPattern.matcher(line);
-
-                    if (!matcher.matches()) {
-                        continue;
-                    }
-                    String collectorNumber = matcher.group(2);
-                    String cardName = matcher.group(3);
-                    String artistName = matcher.group(5);
-                    EditionEntry tis = new EditionEntry(cardName, collectorNumber, CardRarity.Unknown, artistName, null);
-                    otherMap.put(cardName, tis);
                 }
             }
 
-            CardEdition res = new CardEdition(cardMap, tokenMap, customPrintSheetsToParse);
+            CardEdition res = new CardEdition(cardMap, tokenNormalized, customPrintSheetsToParse);
             res.boosterSlots = boosterSlots;
             // parse metadata section
             res.name  = metadata.get("name");
             res.date  = parseDate(metadata.get("date"));
             res.code  = metadata.get("code");
-            res.code2 = metadata.get("code2", res.code);
+            res.code2 = metadata.get("code2");
-            res.scryfallCode = metadata.get("ScryfallCode", res.code);
+            if (res.code2 == null) {
-            res.tokensCode = metadata.get("TokensCode", "T" + res.scryfallCode);
+                res.code2 = res.code;
-            res.tokenFallbackCode = metadata.get("TokenFallbackCode");
+            }
-            res.cardsLanguage = metadata.get("CardLang", "en");
+            res.scryfallCode = metadata.get("ScryfallCode");
-            res.boosterArts = metadata.getInt("BoosterCovers", 1);
+            if (res.scryfallCode == null) {
+                res.scryfallCode = res.code;
+            }
+            res.cardsLanguage = metadata.get("CardLang");
+            if (res.cardsLanguage == null) {
+                res.cardsLanguage = "en";
+            }
 
-            res.otherMap = otherMap;
+            res.boosterArts = metadata.getInt("BoosterCovers", 1);
 
             String boosterDesc = metadata.get("Booster");
 
@@ -838,7 +778,7 @@ public final class CardEdition implements Comparable<CardEdition> {
                 initAliases(E); //Made a method in case the system changes, so it's consistent.
             }
             CardEdition customBucket = new CardEdition("2990-01-01", "USER", "USER",
-                    Type.CUSTOM_SET, "USER", FoilType.NOT_SUPPORTED, new EditionEntry[]{});
+                    Type.CUSTOM_SET, "USER", FoilType.NOT_SUPPORTED, new CardInSet[]{});
             this.add(customBucket);
             initAliases(customBucket);
             this.lock = true; //Consider it initialized and prevent from writing any more data.
@@ -870,7 +810,7 @@ public final class CardEdition implements Comparable<CardEdition> {
 
         public CardEdition getEditionByCodeOrThrow(final String code) {
             final CardEdition set = this.get(code);
-            if (null == set && code.equals(UNKNOWN_CODE)) //Hardcoded set ??? is not with the others, needs special check.
+            if (null == set && code.equals("???")) //Hardcoded set ??? is not with the others, needs special check.
                 return UNKNOWN;
             if (null == set) {
                 throw new RuntimeException("Edition with code '" + code + "' not found");
@@ -1001,12 +941,4 @@ public final class CardEdition implements Comparable<CardEdition> {
         }
         return 0;
     }
-
-    public boolean hasBasicLands() {
-        for(String landName : MagicColor.Constant.BASIC_LANDS) {
-            if (null == StaticData.instance().getCommonCards().getCard(landName, this.getCode(), 0))
-                return false;
-        }
-        return true;
-    }
 }

forge-core/src/main/java/forge/card/CardFace.java

@@ -222,7 +222,7 @@ final class CardFace implements ICardFace, Cloneable {
                 else variant.replacements.addAll(0, this.replacements);
 
                 if(variant.variables == null) variant.variables = this.variables;
-                else this.variables.forEach((k, v) -> variant.variables.putIfAbsent(k, v));
+                else variant.variables.putAll(this.variables);
 
                 if(variant.nonAbilityText == null) variant.nonAbilityText = this.nonAbilityText;
                 if(variant.draftActions == null) variant.draftActions = this.draftActions;

forge-core/src/main/java/forge/card/CardRules.java

@@ -285,10 +285,7 @@ public final class CardRules implements ICardCharacteristics {
             return true;
         }
         CardType type = mainPart.getType();
-        if (!type.isLegendary()) {
+        if (type.isLegendary() && canBeCreature()) {
-            return false;
-        }
-        if (canBeCreature() || type.isVehicle() || type.isSpacecraft()) {
             return true;
         }
         return false;
@@ -399,7 +396,6 @@ public final class CardRules implements ICardCharacteristics {
     }
 
     public int getSetColorID() {
-        //Could someday generalize this to support other kinds of markings.
         return setColorID;
     }
 

forge-core/src/main/java/forge/card/CardSplitType.java

@@ -11,8 +11,7 @@ public enum CardSplitType
     Meld(FaceSelectionMethod.USE_ACTIVE_FACE, CardStateName.Meld),
     Split(FaceSelectionMethod.COMBINE, CardStateName.RightSplit),
     Flip(FaceSelectionMethod.USE_PRIMARY_FACE, CardStateName.Flipped),
-    Adventure(FaceSelectionMethod.USE_PRIMARY_FACE, CardStateName.Secondary),
+    Adventure(FaceSelectionMethod.USE_PRIMARY_FACE, CardStateName.Adventure),
-    Omen(FaceSelectionMethod.USE_PRIMARY_FACE, CardStateName.Secondary),
     Modal(FaceSelectionMethod.USE_ACTIVE_FACE, CardStateName.Modal),
     Specialize(FaceSelectionMethod.USE_ACTIVE_FACE, null);
 

forge-core/src/main/java/forge/card/CardStateName.java

@@ -5,11 +5,12 @@ public enum CardStateName {
     Original,
     FaceDown,
     Flipped,
+    Converted,
     Transformed,
     Meld,
     LeftSplit,
     RightSplit,
-    Secondary,
+    Adventure,
     Modal,
     EmptyRoom,
     SpecializeW,

forge-core/src/main/java/forge/card/CardType.java

@@ -26,7 +26,6 @@ import org.apache.commons.lang3.StringUtils;
 
 import java.util.*;
 import java.util.function.Predicate;
-import java.util.stream.Collectors;
 
 /**
  * <p>
@@ -316,12 +315,6 @@ public final class CardType implements Comparable<CardType>, CardTypeView {
         return landTypes;
     }
 
-    public Set<String> getBattleTypes() {
-        if(!isBattle())
-            return Set.of();
-        return subtypes.stream().filter(CardType::isABattleType).collect(Collectors.toSet());
-    }
-
     @Override
     public boolean hasStringType(String t) {
         if (t.isEmpty()) {
@@ -516,7 +509,7 @@ public final class CardType implements Comparable<CardType>, CardTypeView {
     @Override
     public boolean isAttachment() { return isAura() || isEquipment() || isFortification(); }
     @Override
-    public boolean isAura() { return hasSubtype("Aura"); }
+    public boolean isAura()           { return hasSubtype("Aura"); }
     @Override
     public boolean isEquipment()  { return hasSubtype("Equipment"); }
     @Override
@@ -529,9 +522,6 @@ public final class CardType implements Comparable<CardType>, CardTypeView {
         return hasSubtype("Contraption");
     }
 
-    public boolean isVehicle() { return hasSubtype("Vehicle"); }
-    public boolean isSpacecraft() { return hasSubtype("Spacecraft"); }
-
     @Override
     public boolean isSaga() {
         return hasSubtype("Saga");

forge-core/src/main/java/forge/card/CardTypeView.java

@@ -16,7 +16,6 @@ public interface CardTypeView extends Iterable<String>, Serializable {
 
     Set<String> getCreatureTypes();
     Set<String> getLandTypes();
-    Set<String> getBattleTypes();
 
     boolean hasStringType(String t);
     boolean hasType(CoreType type);

forge-core/src/main/java/forge/card/ColorSet.java

@@ -25,8 +25,6 @@ import forge.util.BinaryUtil;
 
 import java.io.Serializable;
 import java.util.*;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
 /**
  * <p>CardColor class.</p>
@@ -293,8 +291,14 @@ public final class ColorSet implements Comparable<ColorSet>, Iterable<Byte>, Ser
      */
     @Override
     public String toString() {
-        final ManaCostShard[] orderedShards = getOrderedShards();
+        if (this.orderWeight == -1) {
-        return Arrays.stream(orderedShards).map(ManaCostShard::toShortString).collect(Collectors.joining());
+            return "n/a";
+        }
+        final String toReturn = MagicColor.toLongString(myColor);
+        if (toReturn.equals(MagicColor.Constant.COLORLESS) && myColor != 0) {
+            return "multi";
+        }
+        return toReturn;
     }
 
     /**
@@ -372,10 +376,6 @@ public final class ColorSet implements Comparable<ColorSet>, Iterable<Byte>, Ser
         }
     }
 
-    public Stream<MagicColor.Color> stream() {
-        return this.toEnumSet().stream();
-    }
-
     //Get array of mana cost shards for color set in the proper order
     public ManaCostShard[] getOrderedShards() {
         return shardOrderLookup[myColor];

forge-core/src/main/java/forge/card/ICardDatabase.java

@@ -5,42 +5,43 @@ import forge.item.PaperCard;
 
 import java.util.Collection;
 import java.util.Date;
-import java.util.Map;
 import java.util.function.Predicate;
 import java.util.stream.Stream;
+import java.util.Set;
 
-/**
- * Magic Cards Database.
- * --------------------
- * This interface defines the general API for Database Access and Cards' Lookup.
- * <p>
- * Methods for single Card's lookup currently support three alternative strategies:
- * 1. [getCard]: Card search based on a single card's attributes
- *               (i.e. name, edition, art, collectorNumber)
- * <p>
- * 2. [getCardFromSet]: Card Lookup from a single Expansion set.
- *                     Particularly useful in Deck Editors when a specific Set is specified.
- * <p>
- * 3. [getCardFromEditions]: Card search considering a predefined `SetPreference` policy and/or a specified Date
- *                           when no expansion is specified for a card.
- *                           This method is particularly useful for Re-prints whenever no specific
- *                           Expansion is specified (e.g. in Deck Import) and a decision should be made
- *                           on which card to pick. This methods allows to adopt a SetPreference selection
- *                           policy to make this decision.
- * <p>
- * The API also includes methods to fetch Collection of Card (i.e. PaperCard instances):
- * - all cards (no filter)
- * - all unique cards (by name)
- * - all prints of a single card
- * - all cards from a single Expansion Set
- * - all cards compliant with a filter condition (i.e. Predicate)
- * <p>
- * Finally, various utility methods are supported:
- * - Get the foil version of a Card (if Any)
- * - Get the Order Number of a Card in an Expansion Set
- * - Get the number of Print/Arts for a card in a Set (useful for those exp. having multiple arts)
- * */
 public interface ICardDatabase extends Iterable<PaperCard> {
+    /**
+     * Magic Cards Database.
+     * --------------------
+     * This interface defines the general API for Database Access and Cards' Lookup.
+     *
+     * Methods for single Card's lookup currently support three alternative strategies:
+     * 1. [getCard]: Card search based on a single card's attributes
+     *               (i.e. name, edition, art, collectorNumber)
+     *
+     * 2. [getCardFromSet]: Card Lookup from a single Expansion set.
+     *                     Particularly useful in Deck Editors when a specific Set is specified.
+     *
+     * 3. [getCardFromEditions]: Card search considering a predefined `SetPreference` policy and/or a specified Date
+     *                           when no expansion is specified for a card.
+     *                           This method is particularly useful for Re-prints whenever no specific
+     *                           Expansion is specified (e.g. in Deck Import) and a decision should be made
+     *                           on which card to pick. This methods allows to adopt a SetPreference selection
+     *                           policy to make this decision.
+     *
+     * The API also includes methods to fetch Collection of Card (i.e. PaperCard instances):
+     * - all cards (no filter)
+     * - all unique cards (by name)
+     * - all prints of a single card
+     * - all cards from a single Expansion Set
+     * - all cards compliant with a filter condition (i.e. Predicate)
+     *
+     * Finally, various utility methods are supported:
+     * - Get the foil version of a Card (if Any)
+     * - Get the Order Number of a Card in an Expansion Set
+     * - Get the number of Print/Arts for a card in a Set (useful for those exp. having multiple arts)
+     * */
+
     /* SINGLE CARD RETRIEVAL METHODS
     *  ============================= */
     // 1. Card Lookup by attributes
@@ -49,20 +50,22 @@ public interface ICardDatabase extends Iterable<PaperCard> {
     PaperCard getCard(String cardName, String edition, int artIndex);
     // [NEW Methods] Including the card CollectorNumber as criterion for DB lookup
     PaperCard getCard(String cardName, String edition, String collectorNumber);
-    PaperCard getCard(String cardName, String edition, int artIndex, Map<String, String> flags);
+    PaperCard getCard(String cardName, String edition, int artIndex, String collectorNumber);
-    PaperCard getCard(String cardName, String edition, String collectorNumber, Map<String, String> flags);
+    PaperCard getCard(String cardName, String edition, int artIndex, Set<String> colorID);
 
     // 2. Card Lookup from a single Expansion Set
     PaperCard getCardFromSet(String cardName, CardEdition edition, boolean isFoil);  // NOT yet used, included for API symmetry
     PaperCard getCardFromSet(String cardName, CardEdition edition, String collectorNumber, boolean isFoil);
     PaperCard getCardFromSet(String cardName, CardEdition edition, int artIndex, boolean isFoil);
     PaperCard getCardFromSet(String cardName, CardEdition edition, int artIndex, String collectorNumber, boolean isFoil);
+    PaperCard getCardFromSet(String cardName, CardEdition edition, int artIndex, String collectorNumber, boolean isFoil, Set<String> colorID);
 
     // 3. Card lookup based on CardArtPreference Selection Policy
     PaperCard getCardFromEditions(String cardName, CardArtPreference artPreference);
     PaperCard getCardFromEditions(String cardName, CardArtPreference artPreference, Predicate<PaperCard> filter);
     PaperCard getCardFromEditions(String cardName, CardArtPreference artPreference, int artIndex);
     PaperCard getCardFromEditions(String cardName, CardArtPreference artPreference, int artIndex, Predicate<PaperCard> filter);
+    PaperCard getCardFromEditions(String cardName, CardArtPreference artPreference, int artIndex, Set<String> colorID);
 
     // 4. Specialised Card Lookup on CardArtPreference Selection and Release Date
     PaperCard getCardFromEditionsReleasedBefore(String cardName, CardArtPreference artPreference, Date releaseDate);

forge-core/src/main/java/forge/card/MagicColor.java

@@ -1,7 +1,6 @@
 package forge.card;
 
 import com.google.common.collect.ImmutableList;
-import forge.deck.DeckRecognizer;
 
 /**
  * Holds byte values for each color magic has.
@@ -188,12 +187,6 @@ public final class MagicColor {
         public String getName() {
             return name;
         }
-
-        public String getLocalizedName() {
-            //Should probably move some of this logic back here, or at least to a more general location.
-            return DeckRecognizer.getLocalisedMagicColorName(getName());
-        }
-
         public byte getColormask() {
             return colormask;
         }

forge-core/src/main/java/forge/card/mana/ManaCostShard.java

@@ -94,7 +94,6 @@ public enum ManaCostShard {
     /** The cmpc. */
     private final float cmpc;
     private final String stringValue;
-    private final String shortStringValue;
 
     /** The image key. */
     private final String imageKey;
@@ -126,7 +125,6 @@ public enum ManaCostShard {
         this.cmc = this.getCMC();
         this.cmpc = this.getCmpCost();
         this.stringValue = "{" + sValue + "}";
-        this.shortStringValue = sValue;
         this.imageKey = imgKey;
     }
 
@@ -234,21 +232,16 @@ public enum ManaCostShard {
         return ManaCostShard.valueOf(atoms);
     }
 
-    /**
+    /*
-     * @return the string representation of this shard - e.g. "{W}" "{2/U}" "{G/P}"
+     * (non-Javadoc)
+     * 
+     * @see java.lang.Object#toString()
      */
     @Override
     public final String toString() {
         return this.stringValue;
     }
 
-    /**
-     * @return The string representation of this shard without brackets - e.g. "W" "2/U" "G/P"
-     */
-    public final String toShortString() {
-        return this.shortStringValue;
-    }
-
     /**
      * Gets the cmc.
      * 

forge-core/src/main/java/forge/deck/CardPool.java

@@ -52,10 +52,7 @@ public class CardPool extends ItemPool<PaperCard> {
 
     public void add(final String cardRequest, final int amount) {
         CardDb.CardRequest request = CardDb.CardRequest.fromString(cardRequest);
-        if(request.collectorNumber != null && !request.collectorNumber.equals(IPaperCard.NO_COLLECTOR_NUMBER))
+        this.add(CardDb.CardRequest.compose(request.cardName, request.isFoil), request.edition, request.artIndex, amount, false, request.colorID);
-            this.add(CardDb.CardRequest.compose(request.cardName, request.isFoil), request.edition, request.collectorNumber, amount, false, request.flags);
-        else
-            this.add(CardDb.CardRequest.compose(request.cardName, request.isFoil), request.edition, request.artIndex, amount, false, request.flags);
     }
 
     public void add(final String cardName, final String setCode) {
@@ -74,20 +71,7 @@ public class CardPool extends ItemPool<PaperCard> {
     public void add(String cardName, String setCode, int artIndex, final int amount) {
         this.add(cardName, setCode, artIndex, amount, false, null);
     }
-    private void add(String cardName, String setCode, String collectorNumber, final int amount, boolean addAny, Map<String, String> flags) {
+    public void add(String cardName, String setCode, int artIndex, final int amount, boolean addAny, Set<String> colorID) {
-        Map<String, CardDb> dbs = StaticData.instance().getAvailableDatabases();
-        for (Map.Entry<String, CardDb> entry: dbs.entrySet()){
-            CardDb db = entry.getValue();
-            PaperCard paperCard = db.getCard(cardName, setCode, collectorNumber, flags);
-            if (paperCard != null) {
-                this.add(paperCard, amount);
-                return;
-            }
-        }
-        //Failed to find it. Fall back accordingly?
-        this.add(cardName, setCode, IPaperCard.NO_ART_INDEX, amount, addAny, flags);
-    }
-    private void add(String cardName, String setCode, int artIndex, final int amount, boolean addAny, Map<String, String> flags) {
         Map<String, CardDb> dbs = StaticData.instance().getAvailableDatabases();
         PaperCard paperCard = null;
         String selectedDbName = "";
@@ -97,7 +81,7 @@ public class CardPool extends ItemPool<PaperCard> {
             for (Map.Entry<String, CardDb> entry: dbs.entrySet()){
                 String dbName = entry.getKey();
                 CardDb db = entry.getValue();
-                paperCard = db.getCard(cardName, setCode, artIndex, flags);
+                paperCard = db.getCard(cardName, setCode, artIndex, colorID);
                 if (paperCard != null) {
                     selectedDbName = dbName;
                     break;
@@ -139,7 +123,7 @@ public class CardPool extends ItemPool<PaperCard> {
                 int cnt = artGroups[i - 1];
                 if (cnt <= 0)
                     continue;
-                PaperCard randomCard = cardDb.getCard(cardName, setCode, i, flags);
+                PaperCard randomCard = cardDb.getCard(cardName, setCode, i, colorID);
                 this.add(randomCard, cnt);
             }
         }
@@ -446,6 +430,7 @@ public class CardPool extends ItemPool<PaperCard> {
     public String toCardList(String separator) {
         List<Entry<PaperCard, Integer>> main2sort = Lists.newArrayList(this);
         main2sort.sort(ItemPoolSorter.BY_NAME_THEN_SET);
+        final CardDb commonDb = StaticData.instance().getCommonCards();
         StringBuilder sb = new StringBuilder();
 
         boolean isFirst = true;
@@ -456,8 +441,10 @@ public class CardPool extends ItemPool<PaperCard> {
             else
                 isFirst = false;
 
+            CardDb db = !e.getKey().getRules().isVariant() ? commonDb : StaticData.instance().getVariantCards();
             sb.append(e.getValue()).append(" ");
-            sb.append(CardDb.CardRequest.compose(e.getKey()));
+            db.appendCardToStringBuilder(e.getKey(), sb);
+
         }
         return sb.toString();
     }
@@ -476,4 +463,20 @@ public class CardPool extends ItemPool<PaperCard> {
         }
         return filteredPool;
     }
+
+    /**
+     * Applies a predicate to this CardPool's cards.
+     * @param predicate the Predicate to apply to this CardPool
+     * @return a new CardPool made from this CardPool with only the cards that agree with the provided Predicate
+     */
+    public CardPool getFilteredPoolWithCardsCount(Predicate<PaperCard> predicate) {
+        CardPool filteredPool = new CardPool();
+        for (Entry<PaperCard, Integer> entry : this.items.entrySet()) {
+            PaperCard pc = entry.getKey();
+            int count = entry.getValue();
+            if (predicate.test(pc))
+                filteredPool.add(pc, count);
+        }
+        return filteredPool;
+    }
 }

forge-core/src/main/java/forge/deck/Deck.java

@@ -247,7 +247,7 @@ public class Deck extends DeckBase implements Iterable<Entry<DeckSection, CardPo
 
         Map<String, List<String>> referenceDeckLoadingMap;
         if (deferredSections != null) {
-            this.normalizeDeferredSections();
+            this.validateDeferredSections();
             referenceDeckLoadingMap = new HashMap<>(this.deferredSections);
         } else
             referenceDeckLoadingMap = new HashMap<>(loadedSections);
@@ -267,7 +267,7 @@ public class Deck extends DeckBase implements Iterable<Entry<DeckSection, CardPo
                 continue;
             final List<String> cardsInSection = s.getValue();
             ArrayList<String> cardNamesWithNoEdition = getAllCardNamesWithNoSpecifiedEdition(cardsInSection);
-            if (!cardNamesWithNoEdition.isEmpty()) {
+            if (cardNamesWithNoEdition.size() > 0) {
                 includeCardsFromUnspecifiedSet = true;
                 if (smartCardArtSelection)
                     cardsWithNoEdition.put(sec, cardNamesWithNoEdition);
@@ -281,10 +281,10 @@ public class Deck extends DeckBase implements Iterable<Entry<DeckSection, CardPo
             optimiseCardArtSelectionInDeckSections(cardsWithNoEdition);
     }
 
-    private void normalizeDeferredSections() {
+    private void validateDeferredSections() {
         /*
          Construct a temporary (DeckSection, CardPool) Maps, to be sanitised and finalised
-         before copying into `this.parts`. This sanitization is applied because of the
+         before copying into `this.parts`. This sanitisation is applied because of the
          validation schema introduced in DeckSections.
          */
         Map<String, List<String>> validatedSections = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
@@ -296,33 +296,61 @@ public class Deck extends DeckBase implements Iterable<Entry<DeckSection, CardPo
             }
 
             final List<String> cardsInSection = s.getValue();
+            List<Pair<String, Integer>> originalCardRequests = CardPool.processCardList(cardsInSection);
             CardPool pool = CardPool.fromCardList(cardsInSection);
             if (pool.countDistinct() == 0)
                 continue;  // pool empty, no card has been found!
 
-            List<String> validatedSection = validatedSections.computeIfAbsent(s.getKey(), (k) -> new ArrayList<>());
+            // Filter pool by applying DeckSection Validation schema for Card Types (to avoid inconsistencies)
-            for (Entry<PaperCard, Integer> entry : pool) {
+            CardPool filteredPool = pool.getFilteredPoolWithCardsCount(deckSection::validate);
-                PaperCard card = entry.getKey();
+            // Add all the cards from ValidPool anyway!
-                String normalizedRequest = getPoolRequest(entry);
+            List<String> whiteList = validatedSections.getOrDefault(s.getKey(), null);
-                if(deckSection.validate(card))
+            if (whiteList == null)
-                    validatedSection.add(normalizedRequest);
+                whiteList = new ArrayList<>();
-                else {
+            for (Entry<PaperCard, Integer> entry : filteredPool) {
-                    // Card was in the wrong section. Move it to the right section.
+                String poolRequest = getPoolRequest(entry, originalCardRequests);
-                    DeckSection cardSection = DeckSection.matchingSection(card);
+                whiteList.add(poolRequest);
-                    assert(cardSection.validate(card)); //Card doesn't fit in the matchingSection?
-                    List<String> sectionCardList = validatedSections.computeIfAbsent(cardSection.name(), (k) -> new ArrayList<>());
-                    sectionCardList.add(normalizedRequest);
-                }
             }
+            validatedSections.put(s.getKey(), whiteList);
+
+            if (filteredPool.countDistinct() != pool.countDistinct()) {
+                CardPool blackList = pool.getFilteredPoolWithCardsCount(input -> !(deckSection.validate(input)));
+
+                for (Entry<PaperCard, Integer> entry : blackList) {
+                    DeckSection cardSection = DeckSection.matchingSection(entry.getKey());
+                    String poolRequest = getPoolRequest(entry, originalCardRequests);
+                    List<String> sectionCardList = validatedSections.getOrDefault(cardSection.name(), null);
+                    if (sectionCardList == null)
+                        sectionCardList = new ArrayList<>();
+                    sectionCardList.add(poolRequest);
+                    validatedSections.put(cardSection.name(), sectionCardList);
+                } // end for blacklist
+            } // end if
         } // end main for on deferredSections
 
         // Overwrite deferredSections
         this.deferredSections = validatedSections;
     }
 
-    private String getPoolRequest(Entry<PaperCard, Integer> entry) {
+    private String getPoolRequest(Entry<PaperCard, Integer> entry, List<Pair<String, Integer>> originalCardRequests) {
+        PaperCard card = entry.getKey();
         int amount = entry.getValue();
-        String poolCardRequest = CardDb.CardRequest.compose(entry.getKey());
+        String poolCardRequest = CardDb.CardRequest.compose(
+                card.isFoil() ? CardDb.CardRequest.compose(card.getName(), true) : card.getName(),
+                card.getEdition(), card.getArtIndex(), card.getColorID());
+        String originalRequestCandidate = null;
+        for (Pair<String, Integer> originalRequest : originalCardRequests){
+            String cardRequest = originalRequest.getLeft();
+            if (!StringUtils.startsWithIgnoreCase(poolCardRequest, cardRequest))
+                continue;
+            originalRequestCandidate = cardRequest;
+            int cardAmount = originalRequest.getRight();
+            if (amount == cardAmount)
+                return String.format("%d %s", cardAmount, cardRequest);
+        }
+        // This is just in case, it should never happen as we're
+        if (originalRequestCandidate != null)
+            return String.format("%d %s", amount, originalRequestCandidate);
         return String.format("%d %s", amount, poolCardRequest);
     }
 

forge-core/src/main/java/forge/deck/DeckRecognizer.java

@@ -472,8 +472,7 @@ public class DeckRecognizer {
             "side", "sideboard", "sb",
             "main", "card", "mainboard",
             "avatar", "commander", "schemes",
-            "conspiracy", "planes", "deck", "dungeon",
+            "conspiracy", "planes", "deck", "dungeon"};
-            "attractions", "contraptions"};
 
     private static CharSequence[] allCardTypes(){
         List<String> cardTypesList = new ArrayList<>();
@@ -672,8 +671,7 @@ public class DeckRecognizer {
                     return checkAndSetCardToken(pc, edition, cardCount, deckSecFromCardLine,
                                                 currentDeckSection, true);
                 // UNKNOWN card as in the Counterspell|FEM case
-                unknownCardToken = Token.UnknownCard(cardName, setCode, cardCount);
+                return Token.UnknownCard(cardName, setCode, cardCount);
-                continue;
             }
             // ok so we can simply ignore everything but card name - as set code does not exist
             // At this stage, we know the card name exists in the DB so a Card MUST be found
@@ -987,7 +985,7 @@ public class DeckRecognizer {
     private static String getMagicColourLabel(MagicColor.Color magicColor) {
         if (magicColor == null) // Multicolour
             return String.format("%s {W}{U}{B}{R}{G}", getLocalisedMagicColorName("Multicolour"));
-        return String.format("%s %s", magicColor.getLocalizedName(), magicColor.getSymbol());
+        return String.format("%s %s", getLocalisedMagicColorName(magicColor.getName()), magicColor.getSymbol());
     }
 
     private static final HashMap<Integer, String> manaSymbolsMap = new HashMap<Integer, String>() {{
@@ -1006,8 +1004,8 @@ public class DeckRecognizer {
         if (magicColor2 == null || magicColor2 == MagicColor.Color.COLORLESS
                 || magicColor1 == MagicColor.Color.COLORLESS)
             return String.format("%s // %s", getMagicColourLabel(magicColor1), getMagicColourLabel(magicColor2));
-        String localisedName1 = magicColor1.getLocalizedName();
+        String localisedName1 = getLocalisedMagicColorName(magicColor1.getName());
-        String localisedName2 = magicColor2.getLocalizedName();
+        String localisedName2 = getLocalisedMagicColorName(magicColor2.getName());
         String comboManaSymbol = manaSymbolsMap.get(magicColor1.getColormask() | magicColor2.getColormask());
         return String.format("%s/%s {%s}", localisedName1, localisedName2, comboManaSymbol);
     }

forge-core/src/main/java/forge/deck/DeckSection.java

@@ -88,7 +88,7 @@ public enum DeckSection {
             CardType t = card.getRules().getType();
             // NOTE: Same rules applies to both Deck and Side, despite "Conspiracy cards" are allowed
             // in the SideBoard (see Rule 313.2)
-            // Those will be matched later, in case (see `Deck::normalizeDeferredSections`)
+            // Those will be matched later, in case (see `Deck::validateDeferredSections`)
             return !t.isConspiracy() && !t.isDungeon() && !t.isPhenomenon() && !t.isPlane() && !t.isScheme() && !t.isVanguard();
         };
 

forge-core/src/main/java/forge/deck/io/DeckSerializer.java

@@ -61,8 +61,6 @@ public class DeckSerializer {
         }
     
         for(Entry<DeckSection, CardPool> s : d) {
-            if(s.getValue().isEmpty())
-                continue;
             out.add(TextUtil.enclosedBracket(s.getKey().toString()));
             out.add(s.getValue().toCardList(System.lineSeparator()));
         }

forge-core/src/main/java/forge/item/ArtStyle.java

@@ -1,13 +0,0 @@
-package forge.item;
-
-public enum ArtStyle {
-    Normal("fullborder", "normal"),
-    Crop("artcrop", "art_crop");
-
-    public final String filename;
-    public final String scryfall;
-    ArtStyle(String filename, String scryfall) {
-        this.filename = filename;
-        this.scryfall = scryfall;
-    }
-}

forge-core/src/main/java/forge/item/IPaperCard.java

@@ -2,10 +2,10 @@ package forge.item;
 
 import forge.card.CardRarity;
 import forge.card.CardRules;
-import forge.card.ColorSet;
 import forge.card.ICardFace;
 
 import java.io.Serializable;
+import java.util.Set;
 
 public interface IPaperCard extends InventoryItem, Serializable {
 
@@ -20,7 +20,7 @@ public interface IPaperCard extends InventoryItem, Serializable {
     String getEdition();
     String getCollectorNumber();
     String getFunctionalVariant();
-    ColorSet getMarkedColors();
+    Set<String> getColorID();
     int getArtIndex();
     boolean isFoil();
     boolean isToken();

forge-core/src/main/java/forge/item/ImageKey.java

@@ -1,100 +0,0 @@
-package forge.item;
-
-import java.io.Serializable;
-import java.io.UnsupportedEncodingException;
-import java.net.URLEncoder;
-import java.util.List;
-
-import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.tuple.Pair;
-
-import com.google.common.collect.Lists;
-
-import forge.ImageKeys;
-import forge.StaticData;
-import forge.card.CardEdition;
-import forge.card.CardStateName;
-
-public record ImageKey(String setCode, String name, String collectorNumber, String artistName, CardStateName state, ImageType type, boolean custom) implements Serializable
-{
-
-    public List<String> getFilename(ArtStyle art) {
-        List<String> result = Lists.newArrayList();
-        String cn = collectorNumber;
-        if (type == ImageType.Token) {
-            if (ImageKeys.HIDDEN_CARD.equals(name)) {
-                // hidden only exist as png
-                result.add("hidden.png");
-                return result;
-            }
-            // TODO Token doesn't use fullborder or artcrop ArtStyle yet
-            if (!StringUtils.isEmpty(setCode) && !setCode.equals(CardEdition.UNKNOWN_CODE)) {
-                if (!StringUtils.isEmpty(cn) && !cn.equals(IPaperCard.NO_COLLECTOR_NUMBER)) {
-                    result.add(setCode + "/" + cn + "_" + name);
-                }
-                result.add(setCode + "/" + name);
-            }
-            result.add(name);
-        } else if (type == ImageType.Card) {
-            if (!StringUtils.isEmpty(setCode) && !setCode.equals(CardEdition.UNKNOWN_CODE)) {
-                if (!StringUtils.isEmpty(cn) && !cn.equals(IPaperCard.NO_COLLECTOR_NUMBER)) {
-                    result.add(setCode + "/" + cn + "_" + name + "." + art.filename);
-                }
-                result.add(setCode + "/" + name + "." + art.filename);
-            }
-            result.add(name + "." + art.filename);
-        }
-        return result;
-    }
-
-    public Pair<String, String> getDownloadUrl(ArtStyle art) {
-        if (custom) {
-            return null;
-        }
-        if (type == ImageType.Token && ImageKeys.HIDDEN_CARD.equals(name)) {
-            return Pair.of("hidden.png", "https://cards.scryfall.io/back.png");
-        }
-        if (StringUtils.isEmpty(collectorNumber) || collectorNumber.equals(IPaperCard.NO_COLLECTOR_NUMBER)) {
-            return null;
-        }
-        // Scryfall only for Cards or Tokens
-        if (type != ImageType.Card && type != ImageType.Token) {
-            return null;
-        }
-        if (StringUtils.isEmpty(setCode) || setCode.equals(CardEdition.UNKNOWN_CODE)) {
-            return null;
-        }
-        CardEdition edition = StaticData.instance().getCardEdition(setCode);
-        if (edition == null || edition.getType() == CardEdition.Type.CUSTOM_SET) return null;
-        // differ token code
-        String setCode = type == ImageType.Card ? edition.getScryfallCode() : edition.getTokensCode();
-        String langCode = edition.getCardsLangCode();
-        String faceParam = "";
-        switch(state) {
-        case Modal:
-        case Secondary:
-        case Transformed:
-            faceParam = "&face=back";
-            break;
-        default:
-            faceParam = "&face=front";
-            break;
-        }
-
-        String ext = art.scryfall == "png" ? ".png" : ".jpg";
-        String filepath = setCode + "/" + collectorNumber + "_" + name + ext;
-        // TODO make scryfall art_crop of split cards separate
-        String collectorNumberEncoded;
-        try {
-            // encode with Charset isn't supported on Android
-            collectorNumberEncoded = URLEncoder.encode(collectorNumber, "UTF-8");
-        } catch (UnsupportedEncodingException e) {
-            collectorNumberEncoded = collectorNumber;
-        }
-
-        String url = ImageKeys.URL_PIC_SCRYFALL_DOWNLOAD + String.format(
-            "%s/%s/%s?format=image&version=%s%s", setCode, collectorNumberEncoded, langCode, art.scryfall, faceParam
-        );
-        return Pair.of(filepath, url);
-    }
-}

forge-core/src/main/java/forge/item/ImageType.java

@@ -1,12 +0,0 @@
-package forge.item;
-
-public enum ImageType {
-    Card,
-    Token,
-    Booster,
-    FatPack,
-    BoosterBox,
-    Precon,
-    TournamentPack,
-    ;
-}

forge-core/src/main/java/forge/item/PaperCard.java

@@ -26,9 +26,10 @@ import forge.util.Localizer;
 import forge.util.TextUtil;
 import org.apache.commons.lang3.StringUtils;
 
-import java.io.*;
+import java.io.IOException;
-import java.util.*;
+import java.io.ObjectInputStream;
-import java.util.stream.Collectors;
+import java.util.Optional;
+import java.util.Set;
 
 /**
  * A lightweight version of a card that matches real-world cards, to use outside of games (eg. inventory, decks, trade).
@@ -38,7 +39,6 @@ import java.util.stream.Collectors;
  * @author Forge
  */
 public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet, IPaperCard {
-    @Serial
     private static final long serialVersionUID = 2942081982620691205L;
 
     // Reference to rules
@@ -55,15 +55,16 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
     private String artist;
     private final int artIndex;
     private final boolean foil;
-    private final PaperCardFlags flags;
+    private Boolean hasImage;
-    private final String sortableName;
+    private final boolean noSell;
+    private Set<String> colorID;
+    private String sortableName;
     private final String functionalVariant;
 
     // Calculated fields are below:
     private transient CardRarity rarity; // rarity is given in ctor when set is assigned
     // Reference to a new instance of Self, but foiled!
-    private transient PaperCard foiledVersion, noSellVersion, flaglessVersion;
+    private transient PaperCard foiledVersion, noSellVersion;
-    private transient Boolean hasImage;
 
     @Override
     public String getName() {
@@ -88,8 +89,8 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
     }
 
     @Override
-    public ColorSet getMarkedColors() {
+    public Set<String> getColorID() {
-        return this.flags.markedColors;
+        return colorID;
     }
 
     @Override
@@ -146,32 +147,32 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
         return unFoiledVersion;
     }
     public PaperCard getNoSellVersion() {
-        if (this.flags.noSellValue)
+        if (this.noSell)
             return this;
 
-        if (this.noSellVersion == null)
+        if (this.noSellVersion == null) {
-            this.noSellVersion = new PaperCard(this, this.flags.withNoSellValueFlag(true));
+            this.noSellVersion = new PaperCard(this.rules, this.edition, this.rarity,
+                    this.artIndex, this.foil, String.valueOf(collectorNumber), this.artist, this.functionalVariant, true);
+        }
         return this.noSellVersion;
     }
-
+    public PaperCard getSellable() {
-    public PaperCard copyWithoutFlags() {
+        if (!this.noSell)
-        if(this.flaglessVersion == null) {
-            if(this.flags == PaperCardFlags.IDENTITY_FLAGS)
-                this.flaglessVersion = this;
-            else
-                this.flaglessVersion = new PaperCard(this, null);
-        }
-        return flaglessVersion;
-    }
-    public PaperCard copyWithFlags(Map<String, String> flags) {
-        if(flags == null || flags.isEmpty())
-            return this.copyWithoutFlags();
-        return new PaperCard(this, new PaperCardFlags(flags));
-    }
-    public PaperCard copyWithMarkedColors(ColorSet colors) {
-        if(Objects.equals(colors, this.flags.markedColors))
             return this;
-        return new PaperCard(this, this.flags.withMarkedColors(colors));
+
+        PaperCard sellable = new PaperCard(this.rules, this.edition, this.rarity,
+                this.artIndex, this.foil, String.valueOf(collectorNumber), this.artist, this.functionalVariant, false);
+        return sellable;
+    }
+    public PaperCard getColorIDVersion(Set<String> colors) {
+        if (colors == null && this.colorID == null)
+            return this;
+        if (this.colorID != null && this.colorID.equals(colors))
+            return this;
+        if (colors != null && colors.equals(this.colorID))
+            return this;
+        return new PaperCard(this.rules, this.edition, this.rarity,
+                this.artIndex, this.foil, String.valueOf(collectorNumber), this.artist, this.functionalVariant, this.noSell, colors);
     }
     @Override
     public String getItemType() {
@@ -179,12 +180,8 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
         return localizer.getMessage("lblCard");
     }
 
-    public PaperCardFlags getMarkedFlags() {
+    public boolean isNoSell() {
-        return this.flags;
+        return noSell;
-    }
-
-    public boolean hasNoSellValue() {
-        return this.flags.noSellValue;
     }
     public boolean hasImage() {
         return hasImage(false);
@@ -201,41 +198,38 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
                 IPaperCard.NO_COLLECTOR_NUMBER, IPaperCard.NO_ARTIST_NAME, IPaperCard.NO_FUNCTIONAL_VARIANT);
     }
 
-    public PaperCard(final PaperCard copyFrom, final PaperCardFlags flags) {
+    public PaperCard(final CardRules rules0, final String edition0, final CardRarity rarity0,
-        this(copyFrom.rules, copyFrom.edition, copyFrom.rarity, copyFrom.artIndex, copyFrom.foil, copyFrom.collectorNumber,
+                     final int artIndex0, final boolean foil0, final String collectorNumber0,
-                copyFrom.artist, copyFrom.functionalVariant, flags);
+                     final String artist0, final String functionalVariant) {
-        this.flaglessVersion = copyFrom.flaglessVersion;
+        this(rules0, edition0, rarity0, artIndex0, foil0, collectorNumber0, artist0, functionalVariant, false);
     }
 
     public PaperCard(final CardRules rules0, final String edition0, final CardRarity rarity0,
                      final int artIndex0, final boolean foil0, final String collectorNumber0,
-                     final String artist0, final String functionalVariant) {
+                     final String artist0, final String functionalVariant, final boolean noSell0) {
-        this(rules0, edition0, rarity0, artIndex0, foil0, collectorNumber0, artist0, functionalVariant, null);
+        this(rules0, edition0, rarity0, artIndex0, foil0, collectorNumber0, artist0, functionalVariant, noSell0, null);
     }
 
-    protected PaperCard(final CardRules rules, final String edition, final CardRarity rarity,
+    public PaperCard(final CardRules rules0, final String edition0, final CardRarity rarity0,
-                     final int artIndex, final boolean foil, final String collectorNumber,
+                     final int artIndex0, final boolean foil0, final String collectorNumber0,
-                     final String artist, final String functionalVariant, final PaperCardFlags flags) {
+                     final String artist0, final String functionalVariant, final boolean noSell0, final Set<String> colorID0) {
-        if (rules == null || edition == null || rarity == null) {
+        if (rules0 == null || edition0 == null || rarity0 == null) {
             throw new IllegalArgumentException("Cannot create card without rules, edition or rarity");
         }
-        this.rules = rules;
+        rules = rules0;
-        name = rules.getName();
+        name = rules0.getName();
-        this.edition = edition;
+        edition = edition0;
-        this.artIndex = Math.max(artIndex, IPaperCard.DEFAULT_ART_INDEX);
+        artIndex = Math.max(artIndex0, IPaperCard.DEFAULT_ART_INDEX);
-        this.foil = foil;
+        foil = foil0;
-        this.rarity = rarity;
+        rarity = rarity0;
-        this.artist = TextUtil.normalizeText(artist);
+        artist = TextUtil.normalizeText(artist0);
-        this.collectorNumber = (collectorNumber != null && !collectorNumber.isEmpty()) ? collectorNumber : IPaperCard.NO_COLLECTOR_NUMBER;
+        collectorNumber = (collectorNumber0 != null) && (collectorNumber0.length() > 0) ? collectorNumber0 : IPaperCard.NO_COLLECTOR_NUMBER;
         // If the user changes the language this will make cards sort by the old language until they restart the game.
         // This is a good tradeoff
-        sortableName = TextUtil.toSortableName(CardTranslation.getTranslatedName(rules.getName()));
+        sortableName = TextUtil.toSortableName(CardTranslation.getTranslatedName(rules0.getName()));
         this.functionalVariant = functionalVariant != null ? functionalVariant : IPaperCard.NO_FUNCTIONAL_VARIANT;
-
+        noSell = noSell0;
-        if(flags == null || flags.equals(PaperCardFlags.IDENTITY_FLAGS))
+        colorID = colorID0;
-            this.flags = PaperCardFlags.IDENTITY_FLAGS;
-        else
-            this.flags = flags;
     }
 
     public static PaperCard FAKE_CARD = new PaperCard(CardRules.getUnsupportedCardNamed("Fake Card"), "Fake Edition", CardRarity.Common);
@@ -262,7 +256,8 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
         }
         if (!getCollectorNumber().equals(other.getCollectorNumber()))
             return false;
-        if (!Objects.equals(flags, other.flags))
+        // colorID can be NULL
+        if (getColorID() != other.getColorID())
             return false;
         return (other.foil == foil) && (other.artIndex == artIndex);
     }
@@ -274,7 +269,13 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
      */
     @Override
     public int hashCode() {
-        return Objects.hash(name, edition, collectorNumber, artIndex, foil, flags);
+        final int code = (name.hashCode() * 11) + (edition.hashCode() * 59) +
+                (artIndex * 2) + (getCollectorNumber().hashCode() * 383);
+        final int id = Optional.ofNullable(colorID).map(Set::hashCode).orElse(0);
+        if (foil) {
+            return code + id + 1;
+        }
+        return code + id;
     }
 
     // FIXME: Check
@@ -306,7 +307,7 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
         String collectorNumber = collectorNumber0;
         if (collectorNumber.equals(NO_COLLECTOR_NUMBER))
             collectorNumber = null;
-        return CardEdition.getSortableCollectorNumber(collectorNumber);
+        return CardEdition.CardInSet.getSortableCollectorNumber(collectorNumber);
     }
 
     private String sortableCNKey = null;
@@ -338,7 +339,6 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
         return Integer.compare(artIndex, o.getArtIndex());
     }
 
-    @Serial
     private void readObject(ObjectInputStream ois) throws ClassNotFoundException, IOException {
         // default deserialization
         ois.defaultReadObject();
@@ -347,46 +347,17 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
         if (pc == null) {
             pc = StaticData.instance().getVariantCards().getCard(name, edition, artIndex);
             if (pc == null) {
-                System.out.println("PaperCard: " + name + " not found with set and index " + edition + ", " + artIndex);
+                throw new IOException(TextUtil.concatWithSpace("Card", name, "not found"));
-                pc = readObjectAlternate(name, edition);
-                if (pc == null) {
-                    throw new IOException(TextUtil.concatWithSpace("Card", name, "not found with set and index", edition, Integer.toString(artIndex)));
-                }
-                System.out.println("Alternate object found: " + pc.getName() + ", " + pc.getEdition() + ", " + pc.getArtIndex());
             }
         }
         rules = pc.getRules();
         rarity = pc.getRarity();
     }
 
-    private IPaperCard readObjectAlternate(String name, String edition) throws ClassNotFoundException, IOException {
-        IPaperCard pc = StaticData.instance().getCommonCards().getCard(name, edition);
-        if (pc == null) {
-            pc = StaticData.instance().getVariantCards().getCard(name, edition);
-        }
-
-        if (pc == null) {
-            pc = StaticData.instance().getCommonCards().getCard(name);
-            if (pc == null) {
-                pc = StaticData.instance().getVariantCards().getCard(name);
-            }
-        }
-
-        return pc;
-    }
-
-    @Serial
-    private Object readResolve() throws ObjectStreamException {
-        //If we deserialize an old PaperCard with no flags, reinitialize as a fresh copy to set default flags.
-        if(this.flags == null)
-            return new PaperCard(this, null);
-        return this;
-    }
-
     @Override
     public String getImageKey(boolean altState) {
-        String normalizedName = StringUtils.stripAccents(name);
+        String noramlizedName = StringUtils.stripAccents(name);
-        String imageKey = ImageKeys.CARD_PREFIX + normalizedName + CardDb.NameSetSeparator
+        String imageKey = ImageKeys.CARD_PREFIX + noramlizedName + CardDb.NameSetSeparator
                 + edition + CardDb.NameSetSeparator + artIndex;
         if (altState) {
             imageKey += ImageKeys.BACKFACE_POSTFIX;
@@ -522,111 +493,4 @@ public class PaperCard implements Comparable<IPaperCard>, InventoryItemFromSet,
     public boolean isRebalanced() {
         return StaticData.instance().isRebalanced(name);
     }
-
-    public String getCollectorNumberSuffix(CardStateName state) {
-        if (this.collectorNumber.equals(IPaperCard.NO_COLLECTOR_NUMBER)) {
-            return "";
-        }
-        if (getRules().getSplitType() == CardSplitType.Meld) {
-            return state == CardStateName.Meld ? "b" : "a";
-        }
-        switch(state) {
-        case SpecializeB:
-            return "b";
-        case SpecializeG:
-            return "g";
-        case SpecializeR:
-            return "r";
-        case SpecializeU:
-            return "u";
-        case SpecializeW:
-            return "w";
-        default:
-            return "";
-        }
-    }
-
-    /**
-     * Contains properties of a card which distinguish it from an otherwise identical copy of the card with the same
-     * name, edition, and collector number. Examples include permanent markings on the card, and flags for Adventure
-     * mode.
-     */
-    public static class PaperCardFlags implements Serializable {
-        @Serial
-        private static final long serialVersionUID = -3924720485840169336L;
-
-        /**
-         * Chosen colors, for cards like Cryptic Spires.
-         */
-        public final ColorSet markedColors;
-        /**
-         * Removes the sell value of the card in Adventure mode.
-         */
-        public final boolean noSellValue;
-
-        //TODO: Could probably move foil here.
-
-        static final PaperCardFlags IDENTITY_FLAGS = new PaperCardFlags(Map.of());
-
-        protected PaperCardFlags(Map<String, String> flags) {
-            if(flags.containsKey("markedColors"))
-                markedColors = ColorSet.fromNames(flags.get("markedColors").split(""));
-            else
-                markedColors = null;
-            noSellValue = flags.containsKey("noSellValue");
-        }
-
-        //Copy constructor. There are some better ways to do this, and they should be explored once we have more than 4
-        //or 5 fields here. Just need to ensure it's impossible to accidentally change a field while the PaperCardFlags
-        //object is in use.
-        private PaperCardFlags(PaperCardFlags copyFrom, ColorSet markedColors, Boolean noSellValue) {
-            if(markedColors == null)
-                markedColors = copyFrom.markedColors;
-            else if(markedColors.isColorless())
-                markedColors = null;
-            this.markedColors = markedColors;
-            this.noSellValue = noSellValue != null ? noSellValue : copyFrom.noSellValue;
-        }
-
-        public PaperCardFlags withMarkedColors(ColorSet markedColors) {
-            if(markedColors == null)
-                markedColors = ColorSet.getNullColor();
-            return new PaperCardFlags(this, markedColors, null);
-        }
-
-        public PaperCardFlags withNoSellValueFlag(boolean noSellValue) {
-            return new PaperCardFlags(this, null, noSellValue);
-        }
-
-        private Map<String, String> asMap;
-        public Map<String, String> toMap() {
-            if(asMap != null)
-                return asMap;
-            Map<String, String> out = new HashMap<>();
-            if(markedColors != null && !markedColors.isColorless())
-                out.put("markedColors", markedColors.toString());
-            if(noSellValue)
-                out.put("noSellValue", "true");
-            asMap = out;
-            return out;
-        }
-
-        @Override
-        public String toString() {
-            return this.toMap().entrySet().stream()
-                    .map((e) -> e.getKey() + "=" + e.getValue())
-                    .collect(Collectors.joining("\t"));
-        }
-
-        @Override
-        public boolean equals(Object o) {
-            if (!(o instanceof PaperCardFlags that)) return false;
-            return noSellValue == that.noSellValue && Objects.equals(markedColors, that.markedColors);
-        }
-
-        @Override
-        public int hashCode() {
-            return Objects.hash(markedColors, noSellValue);
-        }
-    }
 }

forge-core/src/main/java/forge/item/PaperToken.java

@@ -7,12 +7,11 @@ import org.apache.commons.lang3.StringUtils;
 
 import java.util.ArrayList;
 import java.util.Locale;
+import java.util.Set;
 
 public class PaperToken implements InventoryItemFromSet, IPaperCard {
     private static final long serialVersionUID = 1L;
     private String name;
-    private String collectorNumber;
-    private String artist;
     private transient CardEdition edition;
     private ArrayList<String> imageFileName = new ArrayList<>();
     private transient CardRules cardRules;
@@ -55,31 +54,75 @@ public class PaperToken implements InventoryItemFromSet, IPaperCard {
         return makeTokenFileName(fileName);
     }
 
-    public PaperToken(final CardRules c, CardEdition edition0, String imageFileName, String collectorNumber, String artist) {
+    public static String makeTokenFileName(final CardRules rules, CardEdition edition) {
+        ArrayList<String> build = new ArrayList<>();
+
+        String subtypes = StringUtils.join(rules.getType().getSubtypes(), " ");
+        if (!rules.getName().equals(subtypes)) {
+            return makeTokenFileName(rules.getName());
+        }
+
+        ColorSet colors = rules.getColor();
+
+        if (colors.isColorless()) {
+            build.add("C");
+        } else {
+            String color = "";
+            if (colors.hasWhite()) color += "W";
+            if (colors.hasBlue()) color += "U";
+            if (colors.hasBlack()) color += "B";
+            if (colors.hasRed()) color += "R";
+            if (colors.hasGreen()) color += "G";
+
+            build.add(color);
+        }
+
+        if (rules.getPower() != null && rules.getToughness() != null) {
+            build.add(rules.getPower());
+            build.add(rules.getToughness());
+        }
+
+        String cardTypes = "";
+        if (rules.getType().isArtifact()) cardTypes += "A";
+        if (rules.getType().isEnchantment()) cardTypes += "E";
+
+        if (!cardTypes.isEmpty()) {
+            build.add(cardTypes);
+        }
+
+        build.add(subtypes);
+
+        // Are these keywords sorted?
+        for (String keyword : rules.getMainPart().getKeywords()) {
+            build.add(keyword);
+        }
+
+        if (edition != null) {
+            build.add(edition.getCode());
+        }
+
+        return StringUtils.join(build, "_").replace('*', 'x').toLowerCase();
+    }
+
+    public PaperToken(final CardRules c, CardEdition edition0, String imageFileName) {
         this.cardRules = c;
         this.name = c.getName();
         this.edition = edition0;
-        this.collectorNumber = collectorNumber;
-        this.artist = artist;
 
-        if (collectorNumber != null && !collectorNumber.isEmpty() && edition != null && edition.getTokens().containsKey(imageFileName)) {
+        if (edition != null && edition.getTokens().containsKey(imageFileName)) {
-            int idx = 0;
+            this.artIndex = edition.getTokens().get(imageFileName);
-            // count the one with the same collectorNumber
+        }
-            for (CardEdition.EditionEntry t : edition.getTokens().get(imageFileName)) {
+
-                ++idx;
+        if (imageFileName == null) {
-                if (!t.collectorNumber().equals(collectorNumber)) {
+            // This shouldn't really happen. We can just use the normalized name again for the base image name
-                    continue;
+            this.imageFileName.add(makeTokenFileName(c, edition0));
-                }
-                // TODO make better image file names when collector number is known
-                // for the right index, we need to count the ones with wrong collector number too
-                this.imageFileName.add(String.format("%s|%s|%s|%d", imageFileName, edition.getCode(), collectorNumber, idx));
-            }
-            this.artIndex = this.imageFileName.size();
-        } else if (null == edition || CardEdition.UNKNOWN == edition) {
-            this.imageFileName.add(imageFileName);
         } else {
-            // Fallback if CollectorNumber is not used
+            String formatEdition = null == edition || CardEdition.UNKNOWN == edition ? "" : "_" + edition.getCode().toLowerCase();
-            this.imageFileName.add(String.format("%s|%s", imageFileName, edition.getCode()));
+
+            this.imageFileName.add(String.format("%s%s", imageFileName, formatEdition));
+            for (int idx = 2; idx <= this.artIndex; idx++) {
+                this.imageFileName.add(String.format("%s%d%s", imageFileName, idx, formatEdition));
+            }
         }
     }
 
@@ -95,14 +138,12 @@ public class PaperToken implements InventoryItemFromSet, IPaperCard {
 
     @Override
     public String getEdition() {
-        return edition != null ? edition.getCode() : CardEdition.UNKNOWN_CODE;
+        return edition != null ? edition.getCode() : "???";
     }
 
     @Override
     public String getCollectorNumber() {
-        if (collectorNumber.isEmpty())
+        return IPaperCard.NO_COLLECTOR_NUMBER;
-            return IPaperCard.NO_COLLECTOR_NUMBER;
-        return collectorNumber;
     }
 
     @Override
@@ -112,7 +153,7 @@ public class PaperToken implements InventoryItemFromSet, IPaperCard {
     }
 
     @Override
-    public ColorSet getMarkedColors() {
+    public Set<String> getColorID() {
         return null;
     }
 
@@ -137,8 +178,13 @@ public class PaperToken implements InventoryItemFromSet, IPaperCard {
     }
 
     @Override
-    public String getArtist() {
+    public String getArtist() { /*TODO*/
-        return artist;
+        return "";
+    }
+
+    // Unfortunately this is a property of token, cannot move it outside of class
+    public String getImageFilename() {
+        return getImageFilename(1);
     }
 
     public String getImageFilename(int idx) {
@@ -213,21 +259,24 @@ public class PaperToken implements InventoryItemFromSet, IPaperCard {
     // InventoryItem
     @Override
     public String getImageKey(boolean altState) {
-        String suffix = "";
+        if (hasBackFace()) {
-        if (hasBackFace() && altState) {
+            String edCode = edition != null ? "_" + edition.getCode().toLowerCase() : "";
-            if (collectorNumber != null && !collectorNumber.isEmpty() && edition != null) {
+            if (altState) {
-                String name = cardRules.getOtherPart().getName().toLowerCase().replace(" token", "").replace(" ", "_");
+                String name = ImageKeys.TOKEN_PREFIX + cardRules.getOtherPart().getName().toLowerCase().replace(" token", "");
-                return ImageKeys.getTokenKey(String.format("%s|%s|%s%s", name, edition.getCode(), collectorNumber, ImageKeys.BACKFACE_POSTFIX));
+                name.replace(" ", "_");
+                return name + edCode;
             } else {
-                suffix = ImageKeys.BACKFACE_POSTFIX;
+                String name = ImageKeys.TOKEN_PREFIX + cardRules.getMainPart().getName().toLowerCase().replace(" token", "");
+                name.replace(" ", "_");
+                return name + edCode;
             }
         }
         int idx = MyRandom.getRandom().nextInt(artIndex);
-        return getImageKey(idx) + suffix;
+        return getImageKey(idx);
     }
 
     public String getImageKey(int artIndex) {
-        return ImageKeys.getTokenKey(imageFileName.get(artIndex).replace(" ", "_"));
+        return ImageKeys.TOKEN_PREFIX + imageFileName.get(artIndex).replace(" ", "_");
     }
 
     public boolean isRebalanced() {

forge-core/src/main/java/forge/item/generation/BoosterGenerator.java

@@ -401,68 +401,46 @@ public class BoosterGenerator {
             System.out.println(numCards + " of type " + slotType);
 
             // For cards that end in '+', attempt to convert this card to foil.
-            boolean convertAllToFoil = slotType.endsWith("+");
+            boolean convertCardFoil = slotType.endsWith("+");
-            if (convertAllToFoil) {
+            if (convertCardFoil) {
                 slotType = slotType.substring(0, slotType.length() - 1);
             }
 
+            // Unpack Base
             BoosterSlot boosterSlot = boosterSlots.get(slotType);
-            Map<String, Integer> slotReplacementCount = bulkSlotReplacement(boosterSlot, numCards);
+            String determineSheet = boosterSlot.replaceSlot();
 
-            List<PaperCard> paperCards = Lists.newArrayList();
+            if (determineSheet.endsWith("+")) {
-            for(Map.Entry<String, Integer> entry : slotReplacementCount.entrySet()) {
+                determineSheet = determineSheet.substring(0, determineSheet.length() - 1);
-                String determineSheet = entry.getKey();
+                convertCardFoil = true;
-                int numCardsToGenerate = entry.getValue();
-
-                if (determineSheet == null || determineSheet.isEmpty() || numCardsToGenerate == 0) {
-                    continue;
-                }
-
-                // If the sheet ends with a '+', convert all cards in replacement section to foil
-                boolean convertThisToFoil = false;
-                if (determineSheet.endsWith("+")) {
-                    determineSheet = determineSheet.substring(0, determineSheet.length() - 1);
-                    convertThisToFoil = true;
-                }
-
-                String setCode = template.getEdition();
-                PrintSheet ps;
-                try {
-                    // Apply the edition to the sheet name by default. We'll try again if thats not a real sheet
-                    ps = getPrintSheet(determineSheet + " " + setCode);
-                } catch (Exception e) {
-                    ps = getPrintSheet(determineSheet);
-                }
-                if (convertAllToFoil || convertThisToFoil) {
-                    for (PaperCard pc : ps.random(numCardsToGenerate, true)) {
-                        paperCards.add(pc.getFoiled());
-                    }
-                } else {
-                    paperCards.addAll(ps.random(numCardsToGenerate, true));
-                }
-
-                result.addAll(paperCards);
             }
+
+            String setCode = template.getEdition();
+
+            // Ok, so we have a sheet now. Most should be standard sheets, but some named edition sheets
+            List<PaperCard> paperCards;
+            PrintSheet ps;
+            try {
+                // Apply the edition to the sheet name by default. We'll try again if thats not a real sheet
+                ps = getPrintSheet(determineSheet + " " + setCode);
+            } catch(Exception e) {
+                ps = getPrintSheet(determineSheet);
+            }
+            if (convertCardFoil) {
+                paperCards = Lists.newArrayList();
+                for(PaperCard pc : ps.random(numCards, true)) {
+                    paperCards.add(pc.getFoiled());
+                }
+            } else {
+                paperCards = ps.random(numCards, true);
+            }
+
+            result.addAll(paperCards);
         }
 
         return result;
     }
 
-    private static Map<String, Integer> bulkSlotReplacement(BoosterSlot boosterSlot, int numCards) {
-        Map<String, Integer> slotReplacementCount = new HashMap<>();
-
-        for(int i = 0; i < numCards; i++) {
-            String determineSheet = boosterSlot.replaceSlot();
-            if (slotReplacementCount.containsKey(determineSheet)) {
-                slotReplacementCount.put(determineSheet, slotReplacementCount.get(determineSheet) + 1);
-            } else {
-                slotReplacementCount.put(determineSheet, 1);
-            }
-        }
-
-        return slotReplacementCount;
-    }
-
     private static void ensureGuaranteedCardInBooster(List<PaperCard> result, SealedTemplate template, String boosterMustContain) {
         // First, see if there's already a card of the given type
         String[] types = TextUtil.split(boosterMustContain, ' ');

forge-core/src/main/java/forge/token/TokenDb.java

@@ -1,15 +1,10 @@
 package forge.token;
 
-import com.google.common.collect.HashMultimap;
 import com.google.common.collect.Maps;
-import com.google.common.collect.Multimap;
-
 import forge.card.CardDb;
 import forge.card.CardEdition;
 import forge.card.CardRules;
-import forge.item.IPaperCard;
 import forge.item.PaperToken;
-import forge.util.Aggregates;
 
 import java.util.*;
 import java.util.function.Predicate;
@@ -28,8 +23,8 @@ public class TokenDb implements ITokenDatabase {
 
     // The image names should be the same as the script name + _set
     // If that isn't found, consider falling back to the original token
-    private final Multimap<String, PaperToken> allTokenByName = HashMultimap.create();
+
-    private final Map<String, PaperToken> extraTokensByName = Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER);
+    private final Map<String, PaperToken> tokensByName = Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER);
 
     private final CardEdition.Collection editions;
     private final Map<String, CardRules> rulesByName;
@@ -43,87 +38,38 @@ public class TokenDb implements ITokenDatabase {
         return this.rulesByName.containsKey(rule);
 
     }
+    @Override
+    public PaperToken getToken(String tokenName) {
+        return getToken(tokenName, CardEdition.UNKNOWN.getName());
+    }
 
     public void preloadTokens() {
         for (CardEdition edition : this.editions) {
-            for (Map.Entry<String, Collection<CardEdition.EditionEntry>> inSet : edition.getTokens().asMap().entrySet()) {
+            for (String name : edition.getTokens().keySet()) {
-                String name = inSet.getKey();
+                try {
-                String fullName = String.format("%s_%s", name, edition.getCode().toLowerCase());
+                    getToken(name, edition.getCode());
-                for (CardEdition.EditionEntry t : inSet.getValue()) {
+                } catch(Exception e) {
-                    allTokenByName.put(fullName, addTokenInSet(edition, name, t));
+                    System.out.println(name + "_" + edition.getCode() + " defined in Edition file, but not defined as a token script.");
                 }
             }
         }
     }
 
-    protected boolean loadTokenFromSet(CardEdition edition, String name) {
-        String fullName = String.format("%s_%s", name, edition.getCode().toLowerCase());
-        if (allTokenByName.containsKey(fullName)) {
-            return true;
-        }
-        if (!edition.getTokens().containsKey(name)) {
-            return false;
-        }
-
-        for (CardEdition.EditionEntry t : edition.getTokens().get(name)) {
-            allTokenByName.put(fullName, addTokenInSet(edition, name, t));
-        }
-        return true;
-    }
-
-    protected PaperToken addTokenInSet(CardEdition edition, String name, CardEdition.EditionEntry t) {
-        CardRules rules;
-        if (rulesByName.containsKey(name)) {
-            rules = rulesByName.get(name);
-        } else if ("w_2_2_spirit".equals(name) || "w_3_3_spirit".equals(name)) { // Hotfix for Endure Token
-            rules = rulesByName.get("w_x_x_spirit");
-        } else {
-            throw new RuntimeException("wrong token name:" + name);
-        }
-        return new PaperToken(rules, edition, name, t.collectorNumber(), t.artistName());
-    }
-
-    // try all editions to find token
-    protected PaperToken fallbackToken(String name) {
-        for (CardEdition edition : this.editions) {
-            String fullName = String.format("%s_%s", name, edition.getCode().toLowerCase());
-            if (loadTokenFromSet(edition, name)) {
-                return Aggregates.random(allTokenByName.get(fullName));
-            }
-        }
-        return null;
-    }
-
-    @Override
-    public PaperToken getToken(String tokenName) {
-        return getToken(tokenName, CardEdition.UNKNOWN.getCode());
-    }
-
     @Override
     public PaperToken getToken(String tokenName, String edition) {
-        CardEdition realEdition = editions.getEditionByCodeOrThrow(edition);
+        String fullName = String.format("%s_%s", tokenName, edition.toLowerCase());
-        String fullName = String.format("%s_%s", tokenName, realEdition.getCode().toLowerCase());
 
-        // token exist in Set, return one at random
+        if (!tokensByName.containsKey(fullName)) {
-        if (loadTokenFromSet(realEdition, tokenName)) {
-            return Aggregates.random(allTokenByName.get(fullName));
-        }
-        PaperToken fallback = this.fallbackToken(tokenName);
-        if (fallback != null) {
-            return fallback;
-        }
-
-        if (!extraTokensByName.containsKey(fullName)) {
             try {
-                PaperToken pt = new PaperToken(rulesByName.get(tokenName), realEdition, tokenName, "", IPaperCard.NO_ARTIST_NAME);
+                PaperToken pt = new PaperToken(rulesByName.get(tokenName), editions.get(edition), tokenName);
-                extraTokensByName.put(fullName, pt);
+                tokensByName.put(fullName, pt);
                 return pt;
             } catch(Exception e) {
                 throw e;
             }
         }
 
-        return extraTokensByName.get(fullName);
+        return tokensByName.get(fullName);
     }
 
     @Override
@@ -173,7 +119,7 @@ public class TokenDb implements ITokenDatabase {
 
     @Override
     public List<PaperToken> getAllTokens() {
-        return new ArrayList<>(allTokenByName.values());
+        return new ArrayList<>(tokensByName.values());
     }
 
     @Override
@@ -193,6 +139,6 @@ public class TokenDb implements ITokenDatabase {
 
     @Override
     public Iterator<PaperToken> iterator() {
-        return allTokenByName.values().iterator();
+        return tokensByName.values().iterator();
     }
 }

forge-core/src/main/java/forge/util/ImageUtil.java

@@ -9,8 +9,6 @@ import forge.item.IPaperCard;
 import forge.item.PaperCard;
 import org.apache.commons.lang3.StringUtils;
 
-import java.net.URLEncoder;
-
 public class ImageUtil {
     public static float getNearestHQSize(float baseSize, float actualSize) {
         //get nearest power of actualSize to baseSize so that the image renders good
@@ -102,7 +100,7 @@ public class ImageUtil {
 
         if (includeSet) {
             String editionAliased = isDownloadUrl ? StaticData.instance().getEditions().getCode2ByCode(edition) : ImageKeys.getSetFolder(edition);
-            if (editionAliased.isEmpty()) //FIXME: Custom Cards Workaround
+            if (editionAliased == "") //FIXME: Custom Cards Workaround
                 editionAliased = edition;
             return TextUtil.concatNoSpace(editionAliased, "/", fname);
         } else {
@@ -166,7 +164,7 @@ public class ImageUtil {
 
     public static String getScryfallDownloadUrl(PaperCard cp, String face, String setCode, String langCode, boolean useArtCrop, boolean hyphenateAlchemy){
         String editionCode;
-        if (setCode != null && !setCode.isEmpty())
+        if ((setCode != null) && (setCode.length() > 0))
             editionCode = setCode;
         else
             editionCode = cp.getEdition().toLowerCase();
@@ -194,33 +192,8 @@ public class ImageUtil {
         String faceParam = "";
         if (cp.getRules().getOtherPart() != null) {
             faceParam = (face.equals("back") ? "&face=back" : "&face=front");
-        } else if (cp.getRules().getSplitType() == CardSplitType.Meld
-                    && !cardCollectorNumber.endsWith("a")
-                    && !cardCollectorNumber.endsWith("b")) {
-            // Only the bottom half of a meld card shares a collector number.
-            // Hanweir Garrison EMN already has a appended.
-            cardCollectorNumber += face.equals("back") ? "b" : "a";
         }
-
+        return String.format("%s/%s/%s?format=image&version=%s%s", editionCode, cardCollectorNumber,
-        String cardCollectorNumberEncoded;
-        try {
-            cardCollectorNumberEncoded = URLEncoder.encode(cardCollectorNumber, "UTF-8");
-        } catch (Exception e) {
-            // Unlikely, for the possibility that "UTF-8" is not supported.
-            System.err.println("UTF-8 encoding not supported on this device.");
-            cardCollectorNumberEncoded = cardCollectorNumber;
-        }
-
-        return String.format("%s/%s/%s?format=image&version=%s%s", editionCode, cardCollectorNumberEncoded,
-                langCode, versionParam, faceParam);
-    }
-
-    public static String getScryfallTokenDownloadUrl(String collectorNumber, String setCode, String langCode, String faceParam) {
-        String versionParam = "normal";
-        if (!faceParam.isEmpty()) {
-            faceParam = (faceParam.equals("back") ? "&face=back" : "&face=front");
-        }
-        return String.format("%s/%s/%s?format=image&version=%s%s", setCode, collectorNumber,
                 langCode, versionParam, faceParam);
     }
 

forge-core/src/main/java/forge/util/ItemPool.java

@@ -269,13 +269,6 @@ public class ItemPool<T extends InventoryItem> implements Iterable<Entry<T, Inte
         // need not set out-of-sync: either remove did set, or nothing was removed
     }
 
-    public void removeIf(Predicate<T> test) {
-        for (final T item : items.keySet()) {
-            if (test.test(item))
-                remove(item);
-        }
-    }
-
     public void clear() {
         items.clear();
     }

forge-game/pom.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 
     <modelVersion>4.0.0</modelVersion>
 

forge-game/src/main/java/forge/game/CardTraitBase.java

@@ -2,14 +2,12 @@ package forge.game;
 
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 
 import org.apache.commons.lang3.ArrayUtils;
 import org.apache.commons.lang3.StringUtils;
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Maps;
-import com.google.common.collect.Lists;
 
 import forge.card.CardStateName;
 import forge.card.MagicColor;
@@ -566,23 +564,13 @@ public abstract class CardTraitBase extends GameObject implements IHasCardView,
         return CardView.get(hostCard);
     }
 
-    protected List<IHasSVars> getSVarFallback(final String name) {
+    protected IHasSVars getSVarFallback() {
-        List<IHasSVars> result = Lists.newArrayList();
-
         if (this.getKeyword() != null && this.getKeyword().getStatic() != null) {
-            // only do when the keyword has part of the SVar in ins original string
+            return this.getKeyword().getStatic();
-            if (name == null || this.getKeyword().getOriginal().contains(name)) {
-                // TODO try to add the keyword instead if possible?
-                result.add(this.getKeyword().getStatic());
-            }
         }
         if (getCardState() != null)
-            result.add(getCardState());
+            return getCardState();
-        result.add(getHostCard());
+        return getHostCard();
-        return result;
-    }
-    protected Optional<IHasSVars> findSVar(final String name) {
-        return getSVarFallback(name).stream().filter(f -> f.hasSVar(name)).findFirst();
     }
 
     @Override
@@ -590,12 +578,12 @@ public abstract class CardTraitBase extends GameObject implements IHasCardView,
         if (sVars.containsKey(name)) {
             return sVars.get(name);
         }
-        return findSVar(name).map(o -> o.getSVar(name)).orElse("");
+        return getSVarFallback().getSVar(name);
     }
 
     @Override
     public boolean hasSVar(final String name) {
-        return sVars.containsKey(name) || findSVar(name).isPresent();
+        return sVars.containsKey(name) || getSVarFallback().hasSVar(name);
     }
 
     public Integer getSVarInt(final String name) {
@@ -610,21 +598,22 @@ public abstract class CardTraitBase extends GameObject implements IHasCardView,
     }
 
     @Override
-    public void setSVar(final String name, final String value) {
+    public final void setSVar(final String name, final String value) {
         sVars.put(name, value);
     }
 
     @Override
     public Map<String, String> getSVars() {
-        Map<String, String> res = Maps.newHashMap();
+        Map<String, String> res = Maps.newHashMap(getSVarFallback().getSVars());
-        // TODO reverse the order
-        for (IHasSVars s : getSVarFallback(null)) {
-            res.putAll(s.getSVars());
-        }
         res.putAll(sVars);
         return res;
     }
 
+    @Override
+    public Map<String, String> getDirectSVars() {
+        return sVars;
+    }
+
     @Override
     public void setSVars(Map<String, String> newSVars) {
         sVars = Maps.newTreeMap();

forge-game/src/main/java/forge/game/ForgeScript.java

@@ -122,10 +122,23 @@ public class ForgeScript {
                 }
             }
             return found;
-        } else if (property.startsWith("hasAbility")) {
+        } else if (property.equals("hasActivatedAbilityWithTapCost")) {
-            String valid = property.substring(11);
             for (final SpellAbility sa : cardState.getSpellAbilities()) {
-                if (sa.isValid(valid, sourceController, source, spellAbility)) {
+                if (sa.isActivatedAbility() && sa.getPayCosts().hasTapCost()) {
+                    return true;
+                }
+            }
+            return false;
+        } else if (property.equals("hasActivatedAbility")) {
+            for (final SpellAbility sa : cardState.getSpellAbilities()) {
+                if (sa.isActivatedAbility()) {
+                    return true;
+                }
+            }
+            return false;
+        } else if (property.equals("hasOtherActivatedAbility")) {
+            for (final SpellAbility sa : cardState.getSpellAbilities()) {
+                if (sa.isActivatedAbility() && !sa.equals(spellAbility)) {
                     return true;
                 }
             }
@@ -193,9 +206,7 @@ public class ForgeScript {
             return sa.isCrew();
         } else if (property.equals("Saddle")) {
             return sa.isKeyword(Keyword.SADDLE);
-        } else if (property.equals("Station")) {
+        } else if (property.equals("Cycling")) {
-            return sa.isKeyword(Keyword.STATION);
-        }else if (property.equals("Cycling")) {
             return sa.isCycling();
         } else if (property.equals("Dash")) {
             return sa.isDash();
@@ -207,8 +218,6 @@ public class ForgeScript {
             return sa.isEternalize();
         } else if (property.equals("Flashback")) {
             return sa.isFlashback();
-        } else if (property.equals("Harmonize")) {
-            return sa.isHarmonize();
         } else if (property.equals("Jumpstart")) {
             return sa.isJumpstart();
         } else if (property.equals("Kicked")) {
@@ -227,8 +236,6 @@ public class ForgeScript {
             return sa.isTurnFaceUp();
         } else if (property.equals("isCastFaceDown")) {
             return sa.isCastFaceDown();
-        } else if (property.equals("Unearth")) {
-            return sa.isKeyword(Keyword.UNEARTH);
         } else if (property.equals("Modular")) {
             return sa.isKeyword(Keyword.MODULAR);
         } else if (property.equals("Equip")) {

forge-game/src/main/java/forge/game/Game.java

@@ -22,7 +22,6 @@ import com.google.common.collect.HashBasedTable;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Multimap;
-import com.google.common.collect.Sets;
 import com.google.common.collect.Table;
 import com.google.common.eventbus.EventBus;
 import forge.GameCommand;
@@ -262,6 +261,7 @@ public class Game {
         return null;
     }
 
+
     public void addPlayer(int id, Player player) {
         playerCache.put(id, player);
     }
@@ -523,7 +523,7 @@ public class Game {
      * The Direction in which the turn order of this Game currently proceeds.
      */
     public final Direction getTurnOrder() {
-        if (phaseHandler.getPlayerTurn() != null && phaseHandler.getPlayerTurn().isTurnOrderReversed()) {
+        if (phaseHandler.getPlayerTurn() != null && phaseHandler.getPlayerTurn().getAmountOfKeyword("The turn order is reversed.") % 2 == 1) {
             return turnOrder.getOtherDirection();
         }
     	return turnOrder;
@@ -958,9 +958,9 @@ public class Game {
             // if the player who lost was the Monarch, someone else will be the monarch
             // TODO need to check rules if it should try the next player if able
             if (p.equals(getPhaseHandler().getPlayerTurn())) {
-                getAction().becomeMonarch(getNextPlayerAfter(p), p.getMonarchSet());
+                getAction().becomeMonarch(getNextPlayerAfter(p), null);
             } else {
-                getAction().becomeMonarch(getPhaseHandler().getPlayerTurn(), p.getMonarchSet());
+                getAction().becomeMonarch(getPhaseHandler().getPlayerTurn(), null);
             }
         }
 
@@ -970,9 +970,9 @@ public class Game {
             // If the player who has the initiative leaves the game on their own turn,
             // or the active player left the game at the same time, the next player in turn order takes the initiative.
             if (p.equals(getPhaseHandler().getPlayerTurn())) {
-                getAction().takeInitiative(getNextPlayerAfter(p), p.getInitiativeSet());
+                getAction().takeInitiative(getNextPlayerAfter(p), null);
             } else {
-                getAction().takeInitiative(getPhaseHandler().getPlayerTurn(), p.getInitiativeSet());
+                getAction().takeInitiative(getPhaseHandler().getPlayerTurn(), null);
             }
         }
 
@@ -1207,43 +1207,29 @@ public class Game {
 
     public int getCounterAddedThisTurn(CounterType cType, String validPlayer, String validCard, Card source, Player sourceController, CardTraitBase ctb) {
         int result = 0;
-        Set<CounterType> types = null;
+        if (!countersAddedThisTurn.containsRow(cType)) {
-        if (cType == null) {
-            types = countersAddedThisTurn.rowKeySet();
-        } else if (!countersAddedThisTurn.containsRow(cType)) {
             return result;
-        } else {
-            types = Sets.newHashSet(cType);
         }
-        for (CounterType type : types) {
+        for (Map.Entry<Player, List<Pair<Card, Integer>>> e : countersAddedThisTurn.row(cType).entrySet()) {
-            for (Map.Entry<Player, List<Pair<Card, Integer>>> e : countersAddedThisTurn.row(type).entrySet()) {
+           if (e.getKey().isValid(validPlayer.split(","), sourceController, source, ctb)) {
-                if (e.getKey().isValid(validPlayer.split(","), sourceController, source, ctb)) {
+               for (Pair<Card, Integer> p : e.getValue()) {
-                    for (Pair<Card, Integer> p : e.getValue()) {
+                   if (p.getKey().isValid(validCard.split(","), sourceController, source, ctb)) {
-                        if (p.getKey().isValid(validCard.split(","), sourceController, source, ctb)) {
+                       result += p.getValue();
-                            result += p.getValue();
+                   }
-                        }
+               }
-                    }
+           }
-                }
-            }
         }
         return result;
     }
     public int getCounterAddedThisTurn(CounterType cType, Card card) {
         int result = 0;
-        Set<CounterType> types = null;
+        if (!countersAddedThisTurn.containsRow(cType)) {
-        if (cType == null) {
-            types = countersAddedThisTurn.rowKeySet();
-        } else if (!countersAddedThisTurn.containsRow(cType)) {
             return result;
-        } else {
-            types = Sets.newHashSet(cType);
         }
-        for (CounterType type : types) {
+        for (List<Pair<Card, Integer>> l : countersAddedThisTurn.row(cType).values()) {
-            for (List<Pair<Card, Integer>> l : countersAddedThisTurn.row(type).values()) {
+            for (Pair<Card, Integer> p : l) {
-                for (Pair<Card, Integer> p : l) {
+                if (p.getKey().equalsWithGameTimestamp(card)) {
-                    if (p.getKey().equalsWithGameTimestamp(card)) {
+                    result += p.getValue();
-                        result += p.getValue();
-                    }
                 }
             }
         }

forge-game/src/main/java/forge/game/GameAction.java

@@ -22,7 +22,6 @@ import forge.GameCommand;
 import forge.StaticData;
 import forge.card.CardStateName;
 import forge.card.CardType.Supertype;
-import forge.card.ColorSet;
 import forge.card.GamePieceType;
 import forge.card.MagicColor;
 import forge.deck.DeckSection;
@@ -44,10 +43,11 @@ import forge.game.replacement.ReplacementType;
 import forge.game.spellability.SpellAbility;
 import forge.game.spellability.SpellAbilityPredicates;
 import forge.game.spellability.SpellPermanent;
+import forge.game.spellability.TargetRestrictions;
 import forge.game.staticability.StaticAbility;
+import forge.game.staticability.StaticAbilityCantAttackBlock;
 import forge.game.staticability.StaticAbilityContinuous;
 import forge.game.staticability.StaticAbilityLayer;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.trigger.TriggerType;
 import forge.game.zone.PlayerZone;
 import forge.game.zone.PlayerZoneBattlefield;
@@ -386,7 +386,7 @@ public class GameAction {
                     return moveToGraveyard(copied, cause, params);
                 }
             }
-            attachAuraOnIndirectETB(copied, params);
+            attachAuraOnIndirectEnterBattlefield(copied, params);
         }
 
         // Handle merged permanent here so all replacement effects are already applied.
@@ -519,7 +519,6 @@ public class GameAction {
                 }
                 card.setZone(zoneTo);
             }
-            copied.clearMergedCards();
         } else {
             storeChangesZoneAll(copied, zoneFrom, zoneTo, params);
             // "enter the battlefield as a copy" - apply code here
@@ -543,26 +542,26 @@ public class GameAction {
             game.addLeftGraveyardThisTurn(lastKnownInfo);
         }
 
-        if (c.hasMarkedColor()) {
+        if (c.hasChosenColorSpire()) {
-            copied.setMarkedColors(c.getMarkedColors());
+            copied.setChosenColorID(ImmutableSet.copyOf(c.getChosenColorID()));
         }
 
         copied.updateStateForView();
 
-        // we don't want always trigger before counters are placed
-        game.getTriggerHandler().suppressMode(TriggerType.Always);
-        // Need to apply any static effects to produce correct triggers
-        checkStaticAbilities();
-
         // needed for counters + ascend
         if (!suppress && toBattlefield) {
             game.getTriggerHandler().registerActiveTrigger(copied, false);
         }
 
-        // do ETB counters after zone add
+        if (!table.isEmpty()) {
-        table.replaceCounterEffect(game, null, true, true, params);
+            // we don't want always trigger before counters are placed
-
+            game.getTriggerHandler().suppressMode(TriggerType.Always);
-        game.getTriggerHandler().clearSuppression(TriggerType.Always);
+            // Need to apply any static effects to produce correct triggers
+            checkStaticAbilities();
+            // do ETB counters after zone add
+            table.replaceCounterEffect(game, null, true, true, params);
+            game.getTriggerHandler().clearSuppression(TriggerType.Always);
+        }
 
         // update static abilities after etb counters have been placed
         checkStaticAbilities();
@@ -646,8 +645,7 @@ public class GameAction {
                     // Ask controller if it wants to be on top or bottom of other meld.
                     unmeldPosition++;
                 }
-                unmeld = changeZone(null, zoneTo, unmeld, position, cause, params);
+                changeZone(null, zoneTo, unmeld, position, cause, params);
-                storeChangesZoneAll(unmeld, zoneFrom, zoneTo, params);
             }
         } else if (toBattlefield) {
             for (Player p : game.getPlayers()) {
@@ -707,9 +705,9 @@ public class GameAction {
             StaticAbility stAb = eff.addStaticAbility(AbilityUtils.getSVar(cause, cause.getParam("StaticEffect")));
             stAb.setActiveZone(EnumSet.of(ZoneType.Command));
             // needed for ETB lookahead like Bronzehide Lion
-            stAb.putParam("AffectedZone", "All");
+            stAb.putParam("AffectedZone", "Battlefield,Hand,Graveyard,Exile,Stack,Library,Command");
             SpellAbilityEffect.addForgetOnMovedTrigger(eff, "Battlefield");
-            eff.getOwner().getZone(ZoneType.Command).add(eff);
+            game.getAction().moveToCommand(eff, cause);
         }
 
         eff.addRemembered(copied);
@@ -726,6 +724,7 @@ public class GameAction {
         }
     }
 
+
     private void storeChangesZoneAll(Card c, Zone zoneFrom, Zone zoneTo, Map<AbilityKey, Object> params) {
         if (params != null && params.containsKey(AbilityKey.InternalTriggerTable)) {
             ((CardZoneTable) params.get(AbilityKey.InternalTriggerTable)).put(zoneFrom != null ? zoneFrom.getZoneType() : null, zoneTo.getZoneType(), c);
@@ -799,7 +798,7 @@ public class GameAction {
                 continue;
             }
 
-            if (stAb.checkMode(StaticAbilityMode.CantBlockBy)) {
+            if (stAb.checkMode("CantBlockBy")) {
                 if (!stAb.hasParam("ValidAttacker") || (stAb.hasParam("ValidBlocker") && stAb.getParam("ValidBlocker").equals("Creature.Self"))) {
                     continue;
                 }
@@ -809,7 +808,7 @@ public class GameAction {
                     }
                 }
             }
-            if (stAb.checkMode(StaticAbilityMode.MinMaxBlocker)) {
+            if (stAb.checkMode(StaticAbilityCantAttackBlock.MinMaxBlockerMode)) {
                 for (Card creature : IterableUtil.filter(game.getCardsIn(ZoneType.Battlefield), CardPredicates.CREATURES)) {
                     if (stAb.matchesValidParam("ValidCard", creature)) {
                         creature.updateAbilityTextForView();
@@ -935,10 +934,6 @@ public class GameAction {
         final PlayerZone removed = c.getOwner().getZone(ZoneType.Exile);
         final Card copied = moveTo(removed, c, cause, params);
 
-        if (c.isImmutable()) {            
-            return copied;
-        }
-
         final Map<AbilityKey, Object> runParams = AbilityKey.mapFromCard(c);
         runParams.put(AbilityKey.Cause, cause);
         if (origin != null) { // is generally null when adding via dev mode
@@ -1075,7 +1070,7 @@ public class GameAction {
     public boolean hasStaticAbilityAffectingZone(ZoneType zone, StaticAbilityLayer layer) {
         for (final Card ca : game.getCardsIn(ZoneType.STATIC_ABILITIES_SOURCE_ZONES)) {
             for (final StaticAbility stAb : ca.getStaticAbilities()) {
-                if (!stAb.checkConditions(StaticAbilityMode.Continuous)) {
+                if (!stAb.checkConditions("Continuous")) {
                     continue;
                 }
                 if (layer != null && !stAb.getLayers().contains(layer)) {
@@ -1107,13 +1102,13 @@ public class GameAction {
         // remove old effects
         game.getStaticEffects().clearStaticEffects(affectedCards);
 
+        for (final Player p : game.getPlayers()) {
+            p.clearStaticAbilities();
+        }
+
         // search for cards with static abilities
         final FCollection<StaticAbility> staticAbilities = new FCollection<>();
         final CardCollection staticList = new CardCollection();
-        Table<StaticAbility, StaticAbility, Set<StaticAbilityLayer>> dependencies = null;
-        if (preList.isEmpty()) {
-            dependencies = HashBasedTable.create();
-        }
 
         game.forEachCardInGame(new Visitor<Card>() {
             @Override
@@ -1121,7 +1116,7 @@ public class GameAction {
                 // need to get Card from preList if able
                 final Card co = preList.get(c);
                 for (StaticAbility stAb : co.getStaticAbilities()) {
-                    if (stAb.checkMode(StaticAbilityMode.Continuous) && stAb.zonesCheck()) {
+                    if (stAb.checkMode("Continuous")) {
                         staticAbilities.add(stAb);
                     }
                  }
@@ -1148,7 +1143,7 @@ public class GameAction {
                 StaticAbility stAb = staticsForLayer.get(0);
                 // dependency with CDA seems unlikely
                 if (!stAb.isCharacteristicDefining()) {
-                    stAb = findStaticAbilityToApply(layer, staticsForLayer, preList, affectedPerAbility, dependencies);
+                    stAb = findStaticAbilityToApply(layer, staticsForLayer, preList, affectedPerAbility);
                 }
                 staticsForLayer.remove(stAb);
                 final CardCollectionView previouslyAffected = affectedPerAbility.get(stAb);
@@ -1168,7 +1163,7 @@ public class GameAction {
                 if (affectedHere != null) {
                     for (final Card c : affectedHere) {
                         for (final StaticAbility st2 : c.getStaticAbilities()) {
-                            if (!staticAbilities.contains(st2) && st2.checkMode(StaticAbilityMode.Continuous) && st2.zonesCheck()) {
+                            if (!staticAbilities.contains(st2)) {
                                 toAdd.add(st2);
                                 st2.applyContinuousAbilityBefore(layer, preList);
                             }
@@ -1235,8 +1230,6 @@ public class GameAction {
             game.getTriggerHandler().runTrigger(TriggerType.Always, runParams, false);
 
             game.getTriggerHandler().runTrigger(TriggerType.Immediate, runParams, false);
-
-            game.getView().setDependencies(dependencies);
         }
 
         // Update P/T and type in the view only once after all the cards have been processed, to avoid flickering
@@ -1255,8 +1248,7 @@ public class GameAction {
         game.getTracker().unfreeze();
     }
 
-    private StaticAbility findStaticAbilityToApply(StaticAbilityLayer layer, List<StaticAbility> staticsForLayer, CardCollectionView preList, Map<StaticAbility, CardCollectionView> affectedPerAbility,
+    private StaticAbility findStaticAbilityToApply(StaticAbilityLayer layer, List<StaticAbility> staticsForLayer, CardCollectionView preList, Map<StaticAbility, CardCollectionView> affectedPerAbility) {
-            Table<StaticAbility, StaticAbility, Set<StaticAbilityLayer>> dependencies) {
         if (staticsForLayer.size() == 1) {
             return staticsForLayer.get(0);
         }
@@ -1270,11 +1262,12 @@ public class GameAction {
             dependencyGraph.addVertex(stAb);
 
             boolean exists = stAb.getHostCard().getStaticAbilities().contains(stAb);
-            boolean compareAffected = false;
+            boolean compareAffected = true;
             CardCollectionView affectedHere = affectedPerAbility.get(stAb);
             if (affectedHere == null) {
                 affectedHere = StaticAbilityContinuous.getAffectedCards(stAb, preList);
-                compareAffected = true;
+            } else {
+                compareAffected = false;
             }
             List<Object> effectResults = generateStaticAbilityResult(layer, stAb);
 
@@ -1302,24 +1295,21 @@ public class GameAction {
                 // ...what it applies to...
                 if (!dependency && compareAffected) {
                     CardCollectionView affectedAfterOther = StaticAbilityContinuous.getAffectedCards(stAb, preList);
-                    dependency = !Iterators.elementsEqual(affectedHere.iterator(), affectedAfterOther.iterator());
+                    if (!Iterators.elementsEqual(affectedHere.iterator(), affectedAfterOther.iterator())) {
+                        dependency = true;
+                    }
                 }
                 // ...or what it does to any of the things it applies to
                 if (!dependency) {
                     List<Object> effectResultsAfterOther = generateStaticAbilityResult(layer, stAb);
-                    dependency = !effectResults.equals(effectResultsAfterOther);
+                    if (!effectResults.equals(effectResultsAfterOther)) {
+                        dependency = true;
+                    }
                 }
 
                 if (dependency) {
                     dependencyGraph.addVertex(otherStAb);
                     dependencyGraph.addEdge(stAb, otherStAb);
-                    if (dependencies != null) {
-                        if (dependencies.contains(stAb, otherStAb)) {
-                            dependencies.get(stAb, otherStAb).add(layer);
-                        } else {
-                            dependencies.put(stAb, otherStAb, EnumSet.of(layer));
-                        }
-                    }
                 }
 
                 // undo changes and check next pair
@@ -1352,7 +1342,7 @@ public class GameAction {
         }
         dependencyGraph.removeAllVertices(toRemove);
 
-        // now the earliest one left is the correct choice
+        // now the earlist one left is the correct choice
         List<StaticAbility> statics = Lists.newArrayList(dependencyGraph.vertexSet());
         statics.sort(Comparator.comparing(s -> s.getHostCard().getLayerTimestamp()));
 
@@ -1465,12 +1455,17 @@ public class GameAction {
                 checkAgainCard |= stateBasedAction_Saga(c, sacrificeList);
                 checkAgainCard |= stateBasedAction_Battle(c, noRegCreats);
                 checkAgainCard |= stateBasedAction_Role(c, unAttachList);
-                checkAgainCard |= stateBasedAction704_attach(c, unAttachList);
+                checkAgainCard |= stateBasedAction704_attach(c, unAttachList); // Attachment
                 checkAgainCard |= stateBasedAction_Contraption(c, noRegCreats);
 
-                checkAgainCard |= stateBasedAction704_5q(c); // annihilate +1/+1 counters with -1/-1 ones
+                checkAgainCard |= stateBasedAction704_5r(c); // annihilate +1/+1 counters with -1/-1 ones
 
-                checkAgainCard |= stateBasedAction704_5r(c);
+                final CounterType dreamType = CounterType.get(CounterEnumType.DREAM);
+
+                if (c.getCounters(dreamType) > 7 && c.hasKeyword("CARDNAME can't have more than seven dream counters on it.")) {
+                    c.subtractCounter(dreamType,  c.getCounters(dreamType) - 7, null);
+                    checkAgainCard = true;
+                }
 
                 if (c.hasKeyword("The number of loyalty counters on CARDNAME is equal to the number of Beebles you control.")) {
                     int beeble = CardLists.getValidCardCount(game.getCardsIn(ZoneType.Battlefield), "Beeble.YouCtrl", c.getController(), c, null);
@@ -1512,7 +1507,9 @@ public class GameAction {
                 if (!spaceSculptors.isEmpty() && !spaceSculptors.contains(p)) {
                     checkAgain |= stateBasedAction704_5u(p);
                 }
-                checkAgain |= handleLegendRule(p, noRegCreats);
+                if (handleLegendRule(p, noRegCreats)) {
+                    checkAgain = true;
+                }
 
                 if ((game.getRules().hasAppliedVariant(GameType.Commander)
                         || game.getRules().hasAppliedVariant(GameType.Brawl)
@@ -1525,21 +1522,21 @@ public class GameAction {
                     }
                 }
 
-                // 704.5z If a player controls a permanent with start your engines! and that player has no speed, that player’s speed becomes 1.
+                // 704.5z If a player controls a permanent with start your engines! and that player has no speed, that player’s speed becomes 1. See rule 702.179, “Start Your Engines!”
                 if (p.getSpeed() == 0 && p.getCardsIn(ZoneType.Battlefield).anyMatch(c -> c.hasKeyword(Keyword.START_YOUR_ENGINES))) {
                     p.increaseSpeed();
                     checkAgain = true;
                 }
 
-                checkAgain |= handlePlaneswalkerRule(p, noRegCreats);
+                if (handlePlaneswalkerRule(p, noRegCreats)) {
+                    checkAgain = true;
+                }
             }
             for (Player p : spaceSculptors) {
                 checkAgain |= stateBasedAction704_5u(p);
             }
-
             // 704.5m World rule
             checkAgain |= handleWorldRule(noRegCreats);
-
             // only check static abilities once after destroying all the creatures
             // (e.g. helpful for Erebos's Titan and another creature dealing lethal damage to each other simultaneously)
             setHoldCheckingStaticAbilities(true);
@@ -1571,7 +1568,6 @@ public class GameAction {
                 orderedSacrificeList = true;
             }
             sacrifice(sacrificeList, null, true, mapParams);
-
             setHoldCheckingStaticAbilities(false);
 
             table.triggerChangesZoneAll(game, null);
@@ -1630,7 +1626,7 @@ public class GameAction {
 
     private boolean stateBasedAction_Saga(Card c, CardCollection sacrificeList) {
         boolean checkAgain = false;
-        if (!c.isSaga() || !c.hasChapter()) {
+        if (!c.isSaga()) {
             return false;
         }
         // needs to be effect, because otherwise it might be a cost?
@@ -1649,40 +1645,11 @@ public class GameAction {
 
     private boolean stateBasedAction_Battle(Card c, CardCollection removeList) {
         boolean checkAgain = false;
-        if (!c.isBattle()) {
+        if (!c.getType().isBattle()) {
-            return checkAgain;
+            return false;
-        }
-        Player battleController = c.getController();
-        Player battleProtector = c.getProtectingPlayer();
-        /*
-         704.5w If a battle has no player in the game designated as its protector and no attacking creatures are currently
-         attacking that battle, that battle’s controller chooses an appropriate player to be its protector based on its
-         battle type. If no player can be chosen this way, the battle is put into its owner’s graveyard.
-
-         704.5x If a Siege’s controller is also its designated protector, that player chooses an opponent to become its
-         protector. If no player can be chosen this way, the battle is put into its owner’s graveyard.
-         */
-        if (((battleProtector == null || !battleProtector.isInGame()) &&
-                (game.getCombat() == null || game.getCombat().getAttackersOf(c).isEmpty())) ||
-                (c.getType().hasStringType("Siege") && battleController.equals(battleProtector))) {
-            Player newProtector;
-            if (c.getType().getBattleTypes().contains("Siege"))
-                newProtector = battleController.getController().chooseSingleEntityForEffect(battleController.getOpponents(), new SpellAbility.EmptySa(ApiType.ChoosePlayer, c), "Choose an opponent to protect this battle", null);
-            else {
-                // Fall back to the controller. Technically should fall back to null per the above rules, but no official
-                // cards should use this branch. For now this better supports custom cards. May need to revise this later.
-                newProtector = battleController;
-            }
-            // seems unlikely unless range of influence gets implemented
-            if (newProtector == null) {
-                removeList.add(c);
-            } else {
-                c.setProtectingPlayer(newProtector);
-            }
-            checkAgain = true;
         }
         if (c.getCounters(CounterEnumType.DEFENSE) > 0) {
-            return checkAgain;
+            return false;
         }
         // 704.5v If a battle has defense 0 and it isn't the source of an ability that has triggered but not yet left the stack,
         // it’s put into its owner’s graveyard.
@@ -1758,12 +1725,12 @@ public class GameAction {
     }
 
     private boolean stateBasedAction_Contraption(Card c, CardCollection removeList) {
-        if (!c.isContraption())
+        if(!c.isContraption())
             return false;
         int currentSprocket = c.getSprocket();
 
         //A contraption that is in the battlefield without being assembled is put into the graveyard or junkyard.
-        if (currentSprocket == 0) {
+        if(currentSprocket == 0) {
             removeList.add(c);
             return true;
         }
@@ -1772,7 +1739,7 @@ public class GameAction {
         //A reassemble effect can handle that on its own. But if it changed controller due to some other effect,
         //we assign it here. A contraption uses sprocket -1 to signify it has been assembled previously but now needs
         //a new sprocket.
-        if (currentSprocket > 0 && currentSprocket <= 3)
+        if(currentSprocket > 0 && currentSprocket <= 3)
             return false;
 
         int sprocket = c.getController().getController().chooseSprocket(c);
@@ -1824,17 +1791,13 @@ public class GameAction {
         return false;
     }
 
-    private boolean stateBasedAction704_5q(Card c) {
+    private boolean stateBasedAction704_5r(Card c) {
         boolean checkAgain = false;
         final CounterType p1p1 = CounterType.get(CounterEnumType.P1P1);
         final CounterType m1m1 = CounterType.get(CounterEnumType.M1M1);
         int plusOneCounters = c.getCounters(p1p1);
         int minusOneCounters = c.getCounters(m1m1);
         if (plusOneCounters > 0 && minusOneCounters > 0) {
-            if (!c.canRemoveCounters(p1p1) || !c.canRemoveCounters(m1m1)) {
-                return checkAgain;
-            }
-
             int remove = Math.min(plusOneCounters, minusOneCounters);
             // If a permanent has both a +1/+1 counter and a -1/-1 counter on it,
             // N +1/+1 and N -1/-1 counters are removed from it, where N is the
@@ -1846,26 +1809,6 @@ public class GameAction {
         }
         return checkAgain;
     }
-    private boolean stateBasedAction704_5r(Card c) {
-        final CounterType dreamType = CounterType.get(CounterEnumType.DREAM);
-
-        int old = c.getCounters(dreamType);
-        if (old <= 0) {
-            return false;
-        }
-        Integer max = c.getCounterMax(dreamType);
-        if (max == null) {
-            return false;
-        }
-        if (old > max) {
-            if (!c.canRemoveCounters(dreamType)) {
-                return false;
-            }
-            c.subtractCounter(dreamType,  old - max, null);
-            return true;
-        }
-        return false;
-    }
 
     // If a token is in a zone other than the battlefield, it ceases to exist.
     private boolean stateBasedAction704_5d(Card c) {
@@ -1888,10 +1831,19 @@ public class GameAction {
 
     public void checkGameOverCondition() {
         // award loses as SBE
-        GameEndReason reason = null;
         List<Player> losers = null;
-        FCollectionView<Player> allPlayers = game.getPlayers();
 
+        FCollectionView<Player> allPlayers = game.getPlayers();
+        for (Player p : allPlayers) {
+            if (p.checkLoseCondition()) { // this will set appropriate outcomes
+                if (losers == null) {
+                    losers = Lists.newArrayListWithCapacity(3);
+                }
+                losers.add(p);
+            }
+        }
+
+        GameEndReason reason = null;
         // Has anyone won by spelleffect?
         for (Player p : allPlayers) {
             if (!p.hasWon()) {
@@ -1917,17 +1869,24 @@ public class GameAction {
             break;
         }
 
-        if (reason == null) {
+        // loop through all the non-losing players that can't win
+        // see if all of their opponents are in that "about to lose" collection
+        if (losers != null) {
             for (Player p : allPlayers) {
-                if (p.checkLoseCondition()) { // this will set appropriate outcomes
+                if (losers.contains(p)) {
-                    if (losers == null) {
+                    continue;
-                        losers = Lists.newArrayListWithCapacity(3);
-                    }
-                    losers.add(p);
                 }
+                if (p.cantWin()) {
+                    if (losers.containsAll(p.getOpponents())) {
+                        // what to do here?!?!?!
+                        System.err.println(p.toString() + " is about to win, but can't!");
+                    }
+                }
+
             }
         }
 
+        // need a separate loop here, otherwise ConcurrentModificationException is raised
         if (losers != null) {
             for (Player p : losers) {
                 game.onPlayerLost(p);
@@ -2040,7 +1999,7 @@ public class GameAction {
     }
 
     private boolean handleWorldRule(CardCollection noRegCreats) {
-        final List<Card> worlds = CardLists.filter(game.getCardsIn(ZoneType.Battlefield), c -> c.getType().hasSupertype(Supertype.World));
+        final List<Card> worlds = CardLists.getType(game.getCardsIn(ZoneType.Battlefield), "World");
         if (worlds.size() <= 1) {
             return false;
         }
@@ -2049,7 +2008,7 @@ public class GameAction {
         long ts = 0;
 
         for (final Card crd : worlds) {
-            long crdTs = crd.getWorldTimestamp();
+            long crdTs = crd.getGameTimestamp();
             if (crdTs > ts) {
                 ts = crdTs;
                 toKeep.clear();
@@ -2430,14 +2389,15 @@ public class GameAction {
             for (Card c : spires) {
                 // TODO: only do this for the AI, for the player part, get the encoded color from the deck file and pass
                 //  it to either player or the papercard object so it feels like rule based for the player side..
-                if (!c.hasMarkedColor()) {
+                if (!c.hasChosenColorSpire()) {
                     if (takesAction.isAI()) {
+                        List<String> colorChoices = new ArrayList<>(MagicColor.Constant.ONLY_COLORS);
                         String prompt = CardTranslation.getTranslatedName(c.getName()) + ": " +
                                 Localizer.getInstance().getMessage("lblChooseNColors", Lang.getNumeral(2));
                         SpellAbility sa = new SpellAbility.EmptySa(ApiType.ChooseColor, c, takesAction);
                         sa.putParam("AILogic", "MostProminentInComputerDeck");
-                        ColorSet chosenColors = ColorSet.fromNames(takesAction.getController().chooseColors(prompt, sa, 2, 2, MagicColor.Constant.ONLY_COLORS));
+                        Set<String> chosenColors = new HashSet<>(takesAction.getController().chooseColors(prompt, sa, 2, 2, colorChoices));
-                        c.setMarkedColors(chosenColors);
+                        c.setChosenColorID(chosenColors);
                     }
                 }
             }
@@ -2786,36 +2746,21 @@ public class GameAction {
      *            the source
      * @return true, if successful
      */
-    private boolean attachAuraOnIndirectETB(final Card source, Map<AbilityKey, Object> params) {
+    public static boolean attachAuraOnIndirectEnterBattlefield(final Card source, Map<AbilityKey, Object> params) {
-        // When an Aura ETB without being cast you can choose a valid card to attach it to
+        // When an Aura ETB without being cast you can choose a valid card to
-        if (!source.hasKeyword(Keyword.ENCHANT)) {
+        // attach it to
-            return false;
+        final SpellAbility aura = source.getFirstAttachSpell();
-        }
 
-        SpellAbility aura = source.getCurrentState().getAuraSpell();
         if (aura == null) {
             return false;
         }
         aura.setActivatingPlayer(source.getController());
+        final Game game = source.getGame();
+        final TargetRestrictions tgt = aura.getTargetRestrictions();
 
-        Set<ZoneType> zones = EnumSet.noneOf(ZoneType.class);
-        boolean canTargetPlayer = false;
-        for (KeywordInterface ki : source.getKeywords(Keyword.ENCHANT)) {
-            String o = ki.getOriginal();
-            String m[] = o.split(":");
-            String v = m[1];
-            if (v.contains("inZone")) { // currently the only other zone is Graveyard
-                zones.add(ZoneType.Graveyard);
-            } else {
-                zones.add(ZoneType.Battlefield);
-            }
-            if (v.startsWith("Player") || v.startsWith("Opponent")) {
-                canTargetPlayer = true;
-            }
-        }
         Player p = source.getController();
-        if (canTargetPlayer) {
+        if (tgt.canTgtPlayer()) {
-            final FCollection<Player> players = game.getPlayers().filter(PlayerPredicates.canBeAttached(source, null));
+            final FCollection<Player> players = game.getPlayers().filter(PlayerPredicates.canBeAttached(source, aura));
 
             final Player pa = p.getController().chooseSingleEntityForEffect(players, aura,
                     Localizer.getInstance().getMessage("lblSelectAPlayerAttachSourceTo", CardTranslation.getTranslatedName(source.getName())), null);
@@ -2824,7 +2769,9 @@ public class GameAction {
                 return true;
             }
         } else {
+            List<ZoneType> zones = Lists.newArrayList(tgt.getZone());
             CardCollection list = new CardCollection();
+
             if (params != null) {
                 if (zones.contains(ZoneType.Battlefield)) {
                     list.addAll((CardCollectionView) params.get(AbilityKey.LastStateBattlefield));
@@ -2837,7 +2784,7 @@ public class GameAction {
             }
             list.addAll(game.getCardsIn(zones));
 
-            list = CardLists.filter(list, CardPredicates.canBeAttached(source, null));
+            list = CardLists.filter(list, CardPredicates.canBeAttached(source, aura));
             if (list.isEmpty()) {
                 return false;
             }

forge-game/src/main/java/forge/game/GameActionUtil.java

@@ -43,7 +43,6 @@ import forge.game.spellability.*;
 import forge.game.staticability.StaticAbility;
 import forge.game.staticability.StaticAbilityAlternativeCost;
 import forge.game.staticability.StaticAbilityLayer;
-import forge.game.staticability.StaticAbilityMode;
 import forge.game.zone.Zone;
 import forge.game.zone.ZoneType;
 import forge.util.Aggregates;
@@ -184,34 +183,6 @@ public final class GameActionUtil {
                         flashback.setKeyword(inst);
                         flashback.setIntrinsic(inst.isIntrinsic());
                         alternatives.add(flashback);
-                    } else if (keyword.startsWith("Harmonize")) {
-                        if (!source.isInZone(ZoneType.Graveyard)) {
-                            continue;
-                        }
-
-                        if (keyword.equals("Harmonize") && source.getManaCost().isNoCost()) {
-                            continue;
-                        }
-
-                        SpellAbility harmonize = null;
-
-                        if (keyword.contains(":")) {
-                            final String[] k = keyword.split(":");
-                            harmonize = sa.copyWithManaCostReplaced(activator, new Cost(k[1], false));
-                            String extraParams =  k.length > 2 ? k[2] : "";
-                            if (!extraParams.isEmpty()) {
-                                for (Map.Entry<String, String> param : AbilityFactory.getMapParams(extraParams).entrySet()) {
-                                    harmonize.putParam(param.getKey(), param.getValue());
-                                }
-                            }
-                        } else {
-                            harmonize = sa.copy(activator);
-                        }
-                        harmonize.setAlternativeCost(AlternativeCost.Harmonize);
-                        harmonize.getRestrictions().setZone(ZoneType.Graveyard);
-                        harmonize.setKeyword(inst);
-                        harmonize.setIntrinsic(inst.isIntrinsic());
-                        alternatives.add(harmonize);
                     } else if (keyword.startsWith("Foretell")) {
                         // Foretell cast only from Exile
                         if (!source.isInZone(ZoneType.Exile) || !source.isForetold() || source.enteredThisTurn() ||
@@ -291,6 +262,8 @@ public final class GameActionUtil {
 
             // reset static abilities
             if (lkicheck) {
+                // unanimate host again
+                sa.undoAlternateHost(newHost);
                 game.getAction().checkStaticAbilities(false);
                 // clear delayed changes, this check should not have updated the view
                 game.getTracker().clearDelayed();
@@ -419,7 +392,7 @@ public final class GameActionUtil {
         costSources.addAll(game.getCardsIn(ZoneType.STATIC_ABILITIES_SOURCE_ZONES));
         for (final Card ca : costSources) {
             for (final StaticAbility stAb : ca.getStaticAbilities()) {
-                if (!stAb.checkConditions(StaticAbilityMode.OptionalCost)) {
+                if (!stAb.checkConditions("OptionalCost")) {
                     continue;
                 }
 
@@ -497,6 +470,7 @@ public final class GameActionUtil {
 
         // reset static abilities
         if (lkicheck) {
+            sa.undoAlternateHost(newHost);
             game.getAction().checkStaticAbilities(false);
             // clear delayed changes, this check should not have updated the view
             game.getTracker().clearDelayed();
@@ -611,8 +585,9 @@ public final class GameActionUtil {
                         " or greater>";
                 final Cost cost = new Cost(casualtyCost, false);
                 String str = "Pay for Casualty? " + cost.toSimpleString();
+                boolean v = pc.addKeywordCost(sa, cost, ki, str);
 
-                if (pc.addKeywordCost(sa, cost, ki, str)) {
+                if (v) {
                     if (result == null) {
                         result = sa.copy();
                     }
@@ -658,7 +633,9 @@ public final class GameActionUtil {
                 final Cost cost = new Cost(k[1], false);
                 String str = "Pay for Offspring? " + cost.toSimpleString();
 
-                if (pc.addKeywordCost(sa, cost, ki, str)) {
+                boolean v = pc.addKeywordCost(sa, cost, ki, str);
+
+                if (v) {
                     if (result == null) {
                         result = sa.copy();
                     }
@@ -705,25 +682,6 @@ public final class GameActionUtil {
             }
         }
 
-        if (sa.isHarmonize()) {
-            CardCollectionView creatures = activator.getCreaturesInPlay();
-            if (!creatures.isEmpty()) {
-                int max = Aggregates.max(creatures, Card::getNetPower);
-                int n = pc.chooseNumber(sa, "Choose power of creature to tap", 0, max);
-                final String harmonizeCost = "tapXType<1/Creature.powerEQ" + n + "/creature for Harmonize>";
-                final Cost cost = new Cost(harmonizeCost, false);
-
-                if (pc.addKeywordCost(sa, cost, sa.getKeyword(), "Tap creature?")) {
-                    if (result == null) {
-                        result = sa.copy();
-                    }
-                    result.getPayCosts().add(cost);
-                    reset = true;
-                    result.setOptionalKeywordAmount(sa.getKeyword(), n);
-                }
-            }
-        }
-
         if (host.isCreature()) {
             String kw = "As an additional cost to cast creature spells," +
                     " you may pay any amount of mana. If you do, that creature enters " +
@@ -947,16 +905,14 @@ public final class GameActionUtil {
         }
 
         if (fromZone != null && !fromZone.is(ZoneType.None)) { // and not a copy
-            // add back to where it came from, hopefully old state
-            // skip GameAction
-            oldCard.getZone().remove(oldCard);
-
             // might have been an alternative lki host
             oldCard = ability.getCardState().getCard();
 
             oldCard.setCastSA(null);
             oldCard.setCastFrom(null);
-
+            // add back to where it came from, hopefully old state
+            // skip GameAction
+            oldCard.getZone().remove(oldCard);
             // in some rare cases the old position no longer exists (Panglacial Wurm + Selvala)
             Integer newPosition = zonePosition >= 0 ? Math.min(zonePosition, fromZone.size()) : null;
             fromZone.add(oldCard, newPosition, null, true);

forge-game/src/main/java/forge/game/GameEndReason.java

@@ -23,12 +23,15 @@ package forge.game;
 public enum GameEndReason {
     /** The All opponents lost. */
     AllOpponentsLost,
+    // Noone won
+    /** The Draw. */
+    Draw, // Having little idea how they can reach a draw, so I didn't enumerate
+          // possible reasons here
+    // Special conditions, they force one player to win and thus end the game
 
-    /** Noone won */
+    /** The Wins game spell effect. */
-    Draw,
+    WinsGameSpellEffect, // ones that could be both hardcoded (felidar) and
-
+                        // scripted ( such as Mayael's Aria )
-    /** Special conditions, they force one player to win and thus end the game */
-    WinsGameSpellEffect,
 
     /** Used to end multiplayer games where the all humans have lost or conceded while AIs cannot end match by themselves.*/
     AllHumansLost,

forge-game/src/main/java/forge/game/GameEntity.java

@@ -37,11 +37,11 @@ import forge.game.card.CounterEnumType;
 import forge.game.card.CounterType;
 import forge.game.event.GameEventCardAttachment;
 import forge.game.keyword.Keyword;
-import forge.game.keyword.KeywordInterface;
 import forge.game.player.Player;
 import forge.game.replacement.ReplacementEffect;
 import forge.game.replacement.ReplacementType;
 import forge.game.spellability.SpellAbility;
+import forge.game.spellability.TargetRestrictions;
 import forge.game.staticability.StaticAbilityCantAttach;
 import forge.game.zone.ZoneType;
 
@@ -267,18 +267,15 @@ public abstract class GameEntity extends GameObject implements IIdentifiable {
     }
 
     protected boolean canBeEnchantedBy(final Card aura) {
-        if (!aura.hasKeyword(Keyword.ENCHANT)) {
+        // TODO need to check for multiple Enchant Keywords
-            return false;
+
+        SpellAbility sa = aura.getFirstAttachSpell();
+        TargetRestrictions tgt = null;
+        if (sa != null) {
+            tgt = sa.getTargetRestrictions();
         }
-        for (KeywordInterface ki : aura.getKeywords(Keyword.ENCHANT)) {
+
-            String k = ki.getOriginal();
+        return tgt != null && isValid(tgt.getValidTgts(), aura.getController(), aura, sa);
-            String m[] = k.split(":");
-            String v = m[1];
-            if (!isValid(v.split(","), aura.getController(), aura, null)) {
-                return false;
-            }
-        }
-        return true;
     }
 
     public boolean hasCounters() {
@@ -321,20 +318,11 @@ public abstract class GameEntity extends GameObject implements IIdentifiable {
         return canReceiveCounters(CounterType.get(type));
     }
 
-    public final void addCounter(final CounterType counterType, int n, final Player source, GameEntityCounterTable table) {
+    public final void addCounter(final CounterType counterType, final int n, final Player source, GameEntityCounterTable table) {
         if (n <= 0 || !canReceiveCounters(counterType)) {
             // As per rule 107.1b
             return;
         }
-
-        Integer max = getCounterMax(counterType);
-        if (max != null) {
-            n = Math.min(n, max - getCounters(counterType));
-            if (n <= 0) {
-                return;
-            }
-        }
-
         // doesn't really add counters, but is just a helper to add them to the Table
         // so the Table can handle the Replacement Effect
         table.put(source, this, counterType, n);
@@ -352,9 +340,6 @@ public abstract class GameEntity extends GameObject implements IIdentifiable {
     public void addCounterInternal(final CounterEnumType counterType, final int n, final Player source, final boolean fireEvents, GameEntityCounterTable table, Map<AbilityKey, Object> params) {
         addCounterInternal(CounterType.get(counterType), n, source, fireEvents, table, params);
     }
-    public Integer getCounterMax(final CounterType counterType) {
-        return null;
-    }
 
     public List<Pair<Integer, Boolean>> getDamageReceivedThisTurn() {
         return damageReceivedThisTurn;

forge-game/src/main/java/forge/game/GameEntityCounterTable.java

@@ -159,17 +159,12 @@ public class GameEntityCounterTable extends ForwardingTable<Optional<Player>, Ga
             }
 
             // Add ETB flag
-            Map<AbilityKey, Object> runParams = AbilityKey.newMap();
+            final Map<AbilityKey, Object> runParams = AbilityKey.newMap();
             runParams.put(AbilityKey.Cause, cause);
             if (params != null) {
                 runParams.putAll(params);
             }
 
-            boolean firstTime = false;
-            if (gm.getKey() instanceof Card c) {
-                firstTime = game.getCounterAddedThisTurn(null, c) == 0;
-            }
-
             // Apply counter after replacement effect
             for (Map.Entry<Optional<Player>, Map<CounterType, Integer>> e : values.entrySet()) {
                 boolean remember = cause != null && cause.hasParam("RememberPut");
@@ -187,13 +182,6 @@ public class GameEntityCounterTable extends ForwardingTable<Optional<Player>, Ga
                     }
                 }
             }
-
-            if (result.containsColumn(gm.getKey())) {
-                runParams = AbilityKey.newMap();
-                runParams.put(AbilityKey.Object, gm.getKey());
-                runParams.put(AbilityKey.FirstTime, firstTime);
-                game.getTriggerHandler().runTrigger(TriggerType.CounterTypeAddedAll, runParams, false);
-            }
         }
 
         int totalAdded = totalValues();

forge-game/src/main/java/forge/game/GameFormat.java

@@ -21,7 +21,7 @@ import com.google.common.collect.Lists;
 import forge.StaticData;
 import forge.card.CardDb;
 import forge.card.CardEdition;
-import forge.card.CardEdition.EditionEntry;
+import forge.card.CardEdition.CardInSet;
 import forge.card.CardRarity;
 import forge.deck.CardPool;
 import forge.deck.Deck;
@@ -156,7 +156,7 @@ public class GameFormat implements Comparable<GameFormat> {
             for (CardRarity cr: this.getAllowedRarities()) {
                 crp.add(StaticData.instance().getCommonCards().wasPrintedAtRarity(cr));
             }
-            p = p.and(IterableUtil.<PaperCard>or(crp));
+            p = p.and(IterableUtil.or(crp));
         }
         if (!this.getAdditionalCards().isEmpty()) {
             p = p.or(PaperCardPredicates.names(this.getAdditionalCards()));
@@ -226,9 +226,9 @@ public class GameFormat implements Comparable<GameFormat> {
         for (String setCode : allowedSetCodes_ro) {
             CardEdition edition = StaticData.instance().getEditions().get(setCode);
             if (edition != null) {
-                for (EditionEntry card : edition.getAllCardsInSet()) {
+                for (CardInSet card : edition.getAllCardsInSet()) {
-                    if (!bannedCardNames_ro.contains(card.name())) {
+                    if (!bannedCardNames_ro.contains(card.name)) {
-                        PaperCard pc = commonCards.getCard(card.name(), setCode, card.collectorNumber());
+                        PaperCard pc = commonCards.getCard(card.name, setCode, card.collectorNumber);
                         if (pc != null) {
                             cards.add(pc);
                         }

forge-game/src/main/java/forge/game/GameLogFormatter.java

@@ -304,7 +304,8 @@ public class GameLogFormatter extends IGameEventVisitor.Base<GameLogEntry> {
 
     @Override
     public GameLogEntry visit(GameEventCardForetold ev) {
-        return new GameLogEntry(GameLogEntryType.STACK_RESOLVE, ev.toString());
+        String sb = TextUtil.concatWithSpace(ev.activatingPlayer.toString(), "has foretold.");
+        return new GameLogEntry(GameLogEntryType.STACK_RESOLVE, sb);
     }
 
     @Override
@@ -312,11 +313,6 @@ public class GameLogFormatter extends IGameEventVisitor.Base<GameLogEntry> {
         return new GameLogEntry(GameLogEntryType.STACK_RESOLVE, ev.toString());
     }
 
-    @Override
-    public GameLogEntry visit(GameEventDoorChanged ev) {
-        return new GameLogEntry(GameLogEntryType.STACK_RESOLVE, ev.toString());
-    }
-
     @Subscribe
     public void recieve(GameEvent ev) {
         GameLogEntry le = ev.visit(this);

forge-game/src/main/java/forge/game/GameSnapshot.java

@@ -170,7 +170,7 @@ public class GameSnapshot {
         newPlayer.setDamageReceivedThisTurn(origPlayer.getDamageReceivedThisTurn());
         newPlayer.setLandsPlayedThisTurn(origPlayer.getLandsPlayedThisTurn());
         newPlayer.setCounters(Maps.newHashMap(origPlayer.getCounters()));
-        newPlayer.setBlessing(origPlayer.hasBlessing(), null);
+        newPlayer.setBlessing(origPlayer.hasBlessing());
         newPlayer.setRevolt(origPlayer.hasRevolt());
         newPlayer.setLibrarySearched(origPlayer.getLibrarySearched());
         newPlayer.setSpellsCastLastTurn(origPlayer.getSpellsCastLastTurn());
@@ -322,7 +322,7 @@ public class GameSnapshot {
             newCard.setLayerTimestamp(fromCard.getLayerTimestamp());
             newCard.setTapped(fromCard.isTapped());
             newCard.setFaceDown(fromCard.isFaceDown());
-            newCard.setManifested(fromCard.getManifestedSA());
+            newCard.setManifested(fromCard.isManifested());
             newCard.setSickness(fromCard.hasSickness());
             newCard.setState(fromCard.getCurrentStateName(), false);
         }

forge-game/src/main/java/forge/game/GameType.java

@@ -22,7 +22,7 @@ public enum GameType {
     Winston             (DeckFormat.Limited, true, true, true, "lblWinston", ""),
     Gauntlet            (DeckFormat.Constructed, false, true, true, "lblGauntlet", ""),
     Tournament          (DeckFormat.Constructed, false, true, true, "lblTournament", ""),
-    CommanderGauntlet   (DeckFormat.Commander, false, false, false, "lblCommanderGauntlet", "lblCommanderDesc"),
+    CommanderGauntlet   (DeckFormat.Commander, false, false, false, "lblCommander", "lblCommanderDesc"),
     Quest               (DeckFormat.QuestDeck, true, true, false, "lblQuest", ""),
     QuestDraft          (DeckFormat.Limited, true, true, true, "lblQuestDraft", ""),
     PlanarConquest      (DeckFormat.PlanarConquest, true, false, false, "lblPlanarConquest", ""),

forge-game/src/main/java/forge/game/GameView.java

@@ -1,12 +1,8 @@
 package forge.game;
 
 import java.util.List;
-import java.util.Set;
 
 import com.google.common.collect.Iterables;
-import com.google.common.collect.Table;
-import com.google.common.collect.Table.Cell;
-
 import forge.LobbyPlayer;
 import forge.deck.Deck;
 import forge.game.GameOutcome.AnteResult;
@@ -20,8 +16,6 @@ import forge.game.phase.PhaseType;
 import forge.game.player.PlayerView;
 import forge.game.player.RegisteredPlayer;
 import forge.game.spellability.StackItemView;
-import forge.game.staticability.StaticAbility;
-import forge.game.staticability.StaticAbilityLayer;
 import forge.game.zone.MagicStack;
 import forge.trackable.TrackableCollection;
 import forge.trackable.TrackableObject;
@@ -206,36 +200,15 @@ public class GameView extends TrackableObject {
     public TrackableCollection<CardView> getRevealedCollection() {
         return get(TrackableProperty.RevealedCardsCollection);
     }
+
     public void updateRevealedCards(TrackableCollection<CardView> collection) {
         set(TrackableProperty.RevealedCardsCollection, collection);
     }
 
-    public String getDependencies() {
-        return get(TrackableProperty.Dependencies);
-    }
-    public void setDependencies(Table<StaticAbility, StaticAbility, Set<StaticAbilityLayer>> dependencies) {
-        if (dependencies.isEmpty()) {
-            return;
-        }
-        StringBuilder sb = new StringBuilder();
-        StaticAbilityLayer layer = null;
-        for (StaticAbilityLayer sal : StaticAbilityLayer.CONTINUOUS_LAYERS_WITH_DEPENDENCY) {
-            for (Cell<StaticAbility, StaticAbility, Set<StaticAbilityLayer>> dep : dependencies.cellSet()) {
-                if (dep.getValue().contains(sal)) {
-                    if (layer != sal) {
-                        layer = sal;
-                        sb.append("Layer " + layer.num).append(": ");
-                    }
-                    sb.append(dep.getColumnKey().getHostCard().toString()).append(" <- ").append(dep.getRowKey().getHostCard().toString()).append("\n");
-                }
-            }
-        }
-        set(TrackableProperty.Dependencies, sb.toString());
-    }
-
     public CombatView getCombat() {
         return get(TrackableProperty.CombatView);
     }
+
     public void updateCombatView(CombatView combatView) {
         set(TrackableProperty.CombatView, combatView);
     }

forge-game/src/main/java/forge/game/IHasSVars.java

@@ -15,6 +15,7 @@ public interface IHasSVars {
     //public Set<String> getSVars();
 
     public Map<String, String> getSVars();
+    public Map<String, String> getDirectSVars();
 
     public void removeSVar(final String var);
 }

forge-game/src/main/java/forge/game/StaticEffect.java

@@ -206,6 +206,7 @@ public class StaticEffect {
             if (layers.contains(StaticAbilityLayer.ABILITIES)) {
                 p.removeChangedKeywords(getTimestamp(), ability.getId());
             }
+
         }
 
         // modify the affected card

forge-game/src/main/java/forge/game/ability/AbilityFactory.java

@@ -180,19 +180,26 @@ public final class AbilityFactory {
     }
 
     public static Cost parseAbilityCost(final CardState state, Map<String, String> mapParams, AbilityRecordType type) {
-        if (type == AbilityRecordType.SubAbility) {
+        Cost abCost = null;
-            return null;
+        if (type != AbilityRecordType.SubAbility) {
-        }
+            String cost = mapParams.get("Cost");
-        String cost = mapParams.get("Cost");
+            if (cost == null) {
-        if (cost != null) {
+                if (type == AbilityRecordType.Spell) {
-            return new Cost(cost, type == AbilityRecordType.Ability);
+                    SpellAbility firstAbility = state.getFirstAbility();
-        }
+                    if (firstAbility != null && firstAbility.isSpell()) {
-        if (type == AbilityRecordType.Spell) {
+                        // TODO might remove when Enchant Keyword is refactored
-            // for a Spell if no Cost is used, use the card states ManaCost
+                        System.err.println(state.getName() + " already has Spell using mana cost");
-            return new Cost(state.getManaCost(), false);
+                    }
-        } else {
+                    // for a Spell if no Cost is used, use the card states ManaCost
-            throw new RuntimeException("AbilityFactory : getAbility -- no Cost in " + state.getName());
+                    abCost = new Cost(state.getManaCost(), false);
+                } else {
+                    throw new RuntimeException("AbilityFactory : getAbility -- no Cost in " + state.getName());
+                }
+            } else {
+                abCost = new Cost(cost, type == AbilityRecordType.Ability);
+            }
         }
+        return abCost;
     }
 
     public static SpellAbility getAbility(AbilityRecordType type, ApiType api, Map<String, String> mapParams,
@@ -209,6 +216,15 @@ public final class AbilityFactory {
             }
         }
 
+        else if (api == ApiType.PermanentCreature || api == ApiType.PermanentNoncreature) {
+            // If API is a permanent type, and creating AF Spell
+            // Clear out the auto created SpellPermanent spell
+            if (type == AbilityRecordType.Spell
+                    && !mapParams.containsKey("SubAbility") && !mapParams.containsKey("NonBasicSpell")) {
+                hostCard.clearFirstSpell();
+            }
+        }
+
         if (abCost == null) {
             abCost = parseAbilityCost(state, mapParams, type);
         }
@@ -494,9 +510,8 @@ public final class AbilityFactory {
         AbilityRecordType leftType = AbilityRecordType.getRecordType(leftMap);
         ApiType leftApi = leftType.getApiTypeOf(leftMap);
         leftMap.put("StackDescription", leftMap.get("SpellDescription"));
-        leftMap.put("SpellDescription", "Fuse (You may cast one or both halves of this card from your hand.)");
+        leftMap.put("SpellDescription", "Fuse (you may cast both halves of this card from your hand).");
         leftMap.put("ActivationZone", "Hand");
-        leftMap.put("Secondary", "True");
 
         CardState rightState = card.getState(CardStateName.RightSplit);
         SpellAbility rightAbility = rightState.getFirstAbility();
@@ -511,10 +526,8 @@ public final class AbilityFactory {
         totalCost.add(parseAbilityCost(rightState, rightMap, rightType));
 
         final SpellAbility left = getAbility(leftType, leftApi, leftMap, totalCost, leftState, leftState);
-        left.setOriginalAbility(leftAbility);
         left.setCardState(card.getState(CardStateName.Original));
         final AbilitySub right = (AbilitySub) getAbility(AbilityRecordType.SubAbility, rightApi, rightMap, null, rightState, rightState);
-        right.setOriginalAbility(rightAbility);
         left.appendSubAbility(right);
         return left;
     }

forge-game/src/main/java/forge/game/ability/AbilityKey.java

@@ -38,6 +38,7 @@ public enum AbilityKey {
     Causer("Causer"),
     Championed("Championed"),
     ClassLevel("ClassLevel"),
+    Cost("Cost"),
     CostStack("CostStack"),
     CounterAmount("CounterAmount"),
     CounteredSA("CounteredSA"),
@@ -61,7 +62,6 @@ public enum AbilityKey {
     DefendingPlayer("DefendingPlayer"),
     Destination("Destination"),
     Devoured("Devoured"),
-    DicePTExchanges("DicePTExchanges"),
     Discard("Discard"),
     DiscardedBefore("DiscardedBefore"),
     DividedShieldAmount("DividedShieldAmount"),
@@ -72,6 +72,7 @@ public enum AbilityKey {
     Explored("Explored"),
     Explorer("Explorer"),
     ExtraTurn("ExtraTurn"),
+    Event("Event"),
     ETB("ETB"),
     Fighter("Fighter"),
     Fighters("Fighters"),
@@ -93,8 +94,8 @@ public enum AbilityKey {
     Mana("Mana"),
     MergedCards("MergedCards"),
     Mode("Mode"),
+    Modifier("Modifier"),
     MonstrosityAmount("MonstrosityAmount"),
-    NaturalResult("NaturalResult"),
     NewCard("NewCard"),
     NewCounterAmount("NewCounterAmount"),
     NoPreventDamage("NoPreventDamage"),
@@ -130,6 +131,7 @@ public enum AbilityKey {
     SourceSA("SourceSA"),
     SpellAbility("SpellAbility"),
     SpellAbilityTargets("SpellAbilityTargets"),
+    StackInstance("StackInstance"),
     StackSa("StackSa"),
     SurveilNum("SurveilNum"),
     Target("Target"),
@@ -139,7 +141,7 @@ public enum AbilityKey {
     Valiant("Valiant"),
     Won("Won"),
 
-    // below shared across different Replacements, don't reuse
+    // below used across different Replacements, don't reuse
     InternalTriggerTable("InternalTriggerTable"),
     SimultaneousETB("SimultaneousETB"); // for CR 614.13c
 

forge-game/src/main/java/forge/game/ability/AbilityUtils.java

@@ -538,8 +538,6 @@ public class AbilityUtils {
             val = handlePaid(card.getEmerged(), calcX[1], card, ability);
         } else if (calcX[0].startsWith("Crewed")) {
             val = handlePaid(card.getCrewedByThisTurn(), calcX[1], card, ability);
-        } else if (calcX[0].startsWith("ChosenCard")) {
-            val = handlePaid(card.getChosenCards(), calcX[1], card, ability);
         } else if (calcX[0].startsWith("Remembered")) {
             // Add whole Remembered list to handlePaid
             final CardCollection list = new CardCollection();
@@ -663,7 +661,7 @@ public class AbilityUtils {
                 Object o = root.getTriggeringObject(AbilityKey.fromString(calcX[0].substring(9)));
                 val = o instanceof Player ? playerXProperty((Player) o, calcX[1], card, ability) : 0;
             }
-            else if (calcX[0].equals("TriggeredSpellAbility") || calcX[0].equals("SpellTargeted")) {
+            else if (calcX[0].equals("TriggeredSpellAbility") || calcX[0].equals("TriggeredStackInstance") || calcX[0].equals("SpellTargeted")) {
                 final SpellAbility sat = Iterables.getFirst(getDefinedSpellAbilities(card, calcX[0], sa), null);
                 val = sat == null ? 0 : xCount(sat.getHostCard(), calcX[1], sat);
             }
@@ -1281,6 +1279,8 @@ public class AbilityUtils {
             final Object o = root.getTriggeringObject(AbilityKey.fromString(triggeringType));
             if (o instanceof SpellAbility) {
                 s = (SpellAbility) o;
+            } else if (o instanceof SpellAbilityStackInstance) {
+                s = ((SpellAbilityStackInstance) o).getSpellAbility();
             }
         } else if (defined.endsWith("Targeted") && sa instanceof SpellAbility) {
             final List<TargetChoices> targets = defined.startsWith("This") ? Arrays.asList(((SpellAbility)sa).getTargets()) : ((SpellAbility)sa).getAllTargetChoices();
@@ -1364,7 +1364,7 @@ public class AbilityUtils {
 
         // do blessing there before condition checks
         if (source.hasKeyword(Keyword.ASCEND) && controller.getZone(ZoneType.Battlefield).size() >= 10) {
-            controller.setBlessing(true, source.getSetCode());
+            controller.setBlessing(true);
         }
 
         if (source.hasKeyword(Keyword.GIFT) && sa.isGiftPromised()) {
@@ -1619,8 +1619,7 @@ public class AbilityUtils {
 
         final String[] sq;
         sq = l[0].split("\\.");
-        String[] paidparts = l[0].split("\\$", 2);
+
-        Iterable<Card> someCards = null;
         final Game game = c.getGame();
 
         if (ctb != null) {
@@ -1683,11 +1682,11 @@ public class AbilityUtils {
                            return doXMath(x, expr, c, ctb);
                         } else if (TriggerType.SpellCast.equals(t.getMode())) {
                             // Cast Trigger like Hydroid Krasis
-                            SpellAbility castSA = (SpellAbility) root.getTriggeringObject(AbilityKey.SpellAbility);
+                            SpellAbilityStackInstance castSI = (SpellAbilityStackInstance) root.getTriggeringObject(AbilityKey.StackInstance);
-                            if (castSA == null || castSA.getXManaCostPaid() == null) {
+                            if (castSI == null || castSI.getSpellAbility().getXManaCostPaid() == null) {
                                 return doXMath(0, expr, c, ctb);
                             }
-                            return doXMath(castSA.getXManaCostPaid(), expr, c, ctb);
+                            return doXMath(castSI.getSpellAbility().getXManaCostPaid(), expr, c, ctb);
                         } else if (TriggerType.Cycled.equals(t.getMode())) {
                             SpellAbility cycleSA = (SpellAbility) sa.getTriggeringObject(AbilityKey.Cause);
                             if (cycleSA == null || cycleSA.getXManaCostPaid() == null) {
@@ -1785,10 +1784,11 @@ public class AbilityUtils {
                 }
                 // Count$NumTimesChoseMode
                 if (sq[0].startsWith("NumTimesChoseMode")) {
+                    SpellAbility sub = sa.getRootAbility();
                     int amount = 0;
-                    SpellAbility tail = sa.getTailAbility();
+                    while (sub != null) {
-                    if (tail.hasSVar("CharmOrder")) {
+                        if (sub.getDirectSVars().containsKey("CharmOrder")) amount++;
-                        amount = tail.getSVarInt("CharmOrder");
+                        sub = sub.getSubAbility();
                     }
                     return doXMath(amount, expr, c, ctb);
                 }
@@ -1807,25 +1807,27 @@ public class AbilityUtils {
                 }
 
                 if (sq[0].startsWith("LastStateBattlefield")) {
-                    final String[] k = paidparts[0].split(" ");
+                    final String[] k = l[0].split(" ");
+                    CardCollectionView list;
                     // this is only for spells that were cast
                     if (sq[0].contains("WithFallback")) {
                         if (!sa.getHostCard().wasCast()) {
                             return doXMath(0, expr, c, ctb);
                         }
-                        someCards = sa.getHostCard().getCastSA().getLastStateBattlefield();
+                        list = sa.getHostCard().getCastSA().getLastStateBattlefield();
                     } else {
-                        someCards = sa.getLastStateBattlefield();
+                        list = sa.getLastStateBattlefield();
                     }
-                    if (someCards == null || Iterables.isEmpty(someCards)) {
+                    if (list == null || list.isEmpty()) {
                         // LastState is Empty
                         if (sq[0].contains("WithFallback")) {
-                            someCards = game.getCardsIn(ZoneType.Battlefield);
+                            list = game.getCardsIn(ZoneType.Battlefield);
                         } else {
                             return doXMath(0, expr, c, ctb);
                         }
                     }
-                    someCards = CardLists.getValidCards(someCards, k[1], player, c, sa);
+                    list = CardLists.getValidCards(list, k[1], player, c, sa);
+                    return doXMath(list.size(), expr, c, ctb);
                 }
 
                 if (sq[0].startsWith("LastStateGraveyard")) {
@@ -1852,10 +1854,6 @@ public class AbilityUtils {
                     return doXMath(list.size(), expr, c, ctb);
                 }
 
-                if (sq[0].equals("ActivatedThisGame")) {
-                    return doXMath(sa.getActivationsThisGame(), expr, c, ctb);
-                }
-
                 if (sq[0].equals("ResolvedThisTurn")) {
                     return doXMath(sa.getResolvedThisTurn(), expr, c, ctb);
                 }
@@ -1956,6 +1954,9 @@ public class AbilityUtils {
             return doXMath(sum, expr, c, ctb);
         }
 
+        String[] paidparts = l[0].split("\\$", 2);
+        Iterable<Card> someCards = null;
+
         // count valid cards in any specified zone/s
         if (sq[0].startsWith("Valid")) {
             String[] lparts = paidparts[0].split(" ", 2);
@@ -2214,7 +2215,7 @@ public class AbilityUtils {
         // Count$IfCastInOwnMainPhase.<numMain>.<numNotMain> // 7/10
         if (sq[0].contains("IfCastInOwnMainPhase")) {
             final PhaseHandler cPhase = game.getPhaseHandler();
-            final boolean isMyMain = cPhase.getPhase().isMain() && cPhase.isPlayerTurn(player) && c.wasCast();
+            final boolean isMyMain = cPhase.getPhase().isMain() && cPhase.isPlayerTurn(player) && c.getCastFrom() != null;
             return doXMath(Integer.parseInt(sq[isMyMain ? 1 : 2]), expr, c, ctb);
         }
 
@@ -2223,11 +2224,6 @@ public class AbilityUtils {
             return doXMath(game.getPhaseHandler().getNumUpkeep() - (game.getPhaseHandler().is(PhaseType.UPKEEP) ? 1 : 0), expr, c, ctb);
         }
 
-        // Count$FinishedEndOfTurnsThisTurn
-        if (sq[0].startsWith("FinishedEndOfTurnsThisTurn")) {
-            return doXMath(game.getPhaseHandler().getNumEndOfTurn() - (game.getPhaseHandler().is(PhaseType.END_OF_TURN) ? 1 : 0), expr, c, ctb);
-        }
-
         // Count$AttachedTo <restriction>
         if (sq[0].startsWith("AttachedTo")) {
             final String[] k = l[0].split(" ");
@@ -2270,9 +2266,6 @@ public class AbilityUtils {
         if (sq[0].equals("Delirium")) {
             return doXMath(calculateAmount(c, sq[player.hasDelirium() ? 1 : 2], ctb), expr, c, ctb);
         }
-        if (sq[0].equals("MaxSpeed")) {
-            return doXMath(calculateAmount(c, sq[player.maxSpeed() ? 1 : 2], ctb), expr, c, ctb);
-        }
         if (sq[0].equals("FatefulHour")) {
             return doXMath(calculateAmount(c, sq[player.getLife() <= 5 ? 1 : 2], ctb), expr, c, ctb);
         }
@@ -2322,10 +2315,6 @@ public class AbilityUtils {
             return doXMath(player.getNumDrawnLastTurn(), expr, c, ctb);
         }
 
-        if (sq[0].equals("YouFlipThisTurn")) {
-            return doXMath(player.getNumFlipsThisTurn(), expr, c, ctb);
-        }
-
         if (sq[0].equals("YouRollThisTurn")) {
             return doXMath(player.getNumRollsThisTurn(), expr, c, ctb);
         }
@@ -2411,10 +2400,6 @@ public class AbilityUtils {
             return doXMath(player.getMaxOpponentAssignedDamage(), expr, c, ctb);
         }
 
-        if (sq[0].equals("MaxCombatDamageThisTurn")) {
-            return doXMath(player.getMaxAssignedCombatDamage(), expr, c, ctb);
-        }
-
         if (sq[0].contains("TotalDamageThisTurn")) {
             String[] props = l[0].split(" ");
             int sum = 0;
@@ -2482,6 +2467,7 @@ public class AbilityUtils {
             // But these aren't really things you count so they'll show up in properties most likely
         }
 
+
         //Count$TypesSharedWith [defined]
         if (sq[0].startsWith("TypesSharedWith")) {
             Set<CardType.CoreType> thisTypes = Sets.newHashSet(c.getType().getCoreTypes());
@@ -2711,6 +2697,24 @@ public class AbilityUtils {
             return doXMath(calculateAmount(c, sq[res.size() > 0 ? 1 : 2], ctb), expr, c, ctb);
         }
 
+        if (sq[0].startsWith("CreatureType")) {
+            String[] sqparts = l[0].split(" ", 2);
+            final String[] rest = sqparts[1].split(",");
+
+            final CardCollectionView cardsInZones = sqparts[0].length() > 12
+                ? game.getCardsIn(ZoneType.listValueOf(sqparts[0].substring(12)))
+                : game.getCardsIn(ZoneType.Battlefield);
+
+            CardCollection cards = CardLists.getValidCards(cardsInZones, rest, player, c, ctb);
+            final Set<String> creatTypes = Sets.newHashSet();
+
+            for (Card card : cards) {
+                creatTypes.addAll(card.getType().getCreatureTypes());
+            }
+            // filter out fun types?
+            return doXMath(creatTypes.size(), expr, c, ctb);
+        }
+
         // Count$Chroma.<color name>
         if (sq[0].startsWith("Chroma")) {
             final CardCollectionView cards;
@@ -2769,6 +2773,16 @@ public class AbilityUtils {
             return game.getPhaseHandler().getPlanarDiceSpecialActionThisTurn();
         }
 
+        if (sq[0].equals("AllTypes")) {
+            List<Card> cards = getDefinedCards(c, sq[1], ctb);
+
+            int amount = countCardTypesFromList(cards, false) +
+                    countSuperTypesFromList(cards) +
+                    countSubTypesFromList(cards);
+
+            return doXMath(amount, expr, c, ctb);
+        }
+
         if (sq[0].equals("TotalTurns")) {
             return doXMath(game.getPhaseHandler().getTurn(), expr, c, ctb);
         }
@@ -2914,6 +2928,18 @@ public class AbilityUtils {
             return doXMath(colorSize[colorSize.length - 2], expr, c, ctb);
         }
 
+        if (sq[0].startsWith("ColorsCtrl")) {
+            final String restriction = l[0].substring(11);
+            final CardCollection list = CardLists.getValidCards(player.getCardsIn(ZoneType.Battlefield), restriction, player, c, ctb);
+            return doXMath(CardUtil.getColorsFromCards(list).countColors(), expr, c, ctb);
+        }
+
+        if (sq[0].startsWith("ColorsDefined")) {
+            final String restriction = l[0].substring(14);
+            final CardCollection list = getDefinedCards(c, restriction, ctb);
+            return doXMath(CardUtil.getColorsFromCards(list).countColors(), expr, c, ctb);
+        }
+
         // TODO move below to handlePaid
         if (sq[0].startsWith("SumPower")) {
             final String[] restrictions = l[0].split("_");
@@ -3398,14 +3424,17 @@ public class AbilityUtils {
             return doXMath(numTied, m, source, ctb);
         }
 
+        final String[] sq;
+        sq = l[0].split("\\.");
+
         // the number of players passed in
-        if (l[0].equals("Amount")) {
+        if (sq[0].equals("Amount")) {
             return doXMath(players.size(), m, source, ctb);
         }
 
-        if (l[0].startsWith("HasProperty")) {
+        if (sq[0].startsWith("HasProperty")) {
             int totPlayer = 0;
-            String property = l[0].substring(11);
+            String property = sq[0].substring(11);
             for (Player p : players) {
                 if (p.hasProperty(property, controller, source, ctb)) {
                     totPlayer++;
@@ -3429,7 +3458,7 @@ public class AbilityUtils {
             return doXMath(totPlayer, m, source, ctb);
         }
 
-        if (l[0].contains("DamageThisTurn")) {
+        if (sq[0].contains("DamageThisTurn")) {
             int totDmg = 0;
             for (Player p : players) {
                 totDmg += p.getAssignedDamage();
@@ -3675,10 +3704,6 @@ public class AbilityUtils {
             return doXMath(amount, m, source, ctb);
         }
 
-        if (value.equals("AttractionsVisitedThisTurn")) {
-            return doXMath(player.getAttractionsVisitedThisTurn(), m, source, ctb);
-        }
-
         if (value.startsWith("PlaneswalkedToThisTurn")) {
             int found = 0;
             String name = value.split(" ")[1];
@@ -3749,10 +3774,6 @@ public class AbilityUtils {
             return Aggregates.max(paidList, Card::getNetToughness);
         }
 
-        if (string.startsWith("TapPowerValue")) {
-            return CardLists.getTotalPower(paidList, ctb);
-        }
-
         if (string.startsWith("SumToughness")) {
             return Aggregates.sum(paidList, Card::getNetToughness);
         }
@@ -3761,10 +3782,6 @@ public class AbilityUtils {
             return Aggregates.max(paidList, Card::getCMC);
         }
 
-        if (string.equals("Colors")) {
-            return CardUtil.getColorsFromCards(paidList).countColors();
-        }
-
         if (string.equals("DifferentColorPair")) {
             final Set<ColorSet> diffPair = new HashSet<>();
             for (final Card card : paidList) {
@@ -3794,25 +3811,10 @@ public class AbilityUtils {
             return doXMath(num, splitString.length > 1 ? splitString[1] : null, source, ctb);
         }
 
-        if (string.startsWith("AllTypes")) {
-            return countCardTypesFromList(paidList, false) +
-                    countSuperTypesFromList(paidList) +
-                    countSubTypesFromList(paidList);
-        }
-
         if (string.startsWith("CardTypes")) {
             return doXMath(countCardTypesFromList(paidList, string.startsWith("CardTypesPermanent")), CardFactoryUtil.extractOperators(string), source, ctb);
         }
 
-        if (string.startsWith("CreatureType")) {
-            final Set<String> creatTypes = Sets.newHashSet();
-            for (Card card : paidList) {
-                creatTypes.addAll(card.getType().getCreatureTypes());
-            }
-            // filter out fun types?
-            return doXMath(creatTypes.size(), CardFactoryUtil.extractOperators(string), source, ctb);
-        }
-
         String filteredString = string;
         Iterable<Card> filteredList = paidList;
         final String[] filter = filteredString.split("_");

forge-game/src/main/java/forge/game/ability/ApiType.java

@@ -59,6 +59,7 @@ public enum ApiType {
     Cleanup (CleanUpEffect.class),
     Cloak (CloakEffect.class),
     Clone (CloneEffect.class),
+    CompanionChoose (ChooseCompanionEffect.class),
     Connive (ConniveEffect.class),
     CopyPermanent (CopyPermanentEffect.class),
     CopySpellAbility (CopySpellAbilityEffect.class),
@@ -85,14 +86,12 @@ public enum ApiType {
     Encode (EncodeEffect.class),
     EndCombatPhase (EndCombatPhaseEffect.class),
     EndTurn (EndTurnEffect.class),
-    Endure (EndureEffect.class),
     ExchangeLife (LifeExchangeEffect.class),
     ExchangeLifeVariant (LifeExchangeVariantEffect.class),
     ExchangeControl (ControlExchangeEffect.class),
     ExchangeControlVariant (ControlExchangeVariantEffect.class),
     ExchangePower (PowerExchangeEffect.class),
     ExchangeZone (ZoneExchangeEffect.class),
-    ExchangeTextBox (TextBoxExchangeEffect.class),
     Explore (ExploreEffect.class),
     Fight (FightEffect.class),
     FlipACoin (FlipCoinEffect.class),
@@ -208,7 +207,6 @@ public enum ApiType {
     BlankLine (BlankLineEffect.class),
     DamageResolve (DamageResolveEffect.class),
     ChangeZoneResolve (ChangeZoneResolveEffect.class),
-    CompanionChoose (CharmEffect.class),
     InternalLegendaryRule (CharmEffect.class),
     InternalIgnoreEffect (CharmEffect.class),
     InternalRadiation (InternalRadiationEffect.class),

forge-game/src/main/java/forge/game/ability/SpellAbilityEffect.java

@@ -83,8 +83,8 @@ public abstract class SpellAbilityEffect {
             if ("SpellDescription".equalsIgnoreCase(stackDesc)) {
                 if (params.containsKey("SpellDescription")) {
                     String rawSDesc = params.get("SpellDescription");
-                    if (rawSDesc.contains(",,,,,,")) rawSDesc = rawSDesc.replace(",,,,,,", " ");
+                    if (rawSDesc.contains(",,,,,,")) rawSDesc = rawSDesc.replaceAll(",,,,,,", " ");
-                    if (rawSDesc.contains(",,,")) rawSDesc = rawSDesc.replace(",,,", " ");
+                    if (rawSDesc.contains(",,,")) rawSDesc = rawSDesc.replaceAll(",,,", " ");
                     String spellDesc = CardTranslation.translateSingleDescriptionText(rawSDesc, sa.getHostCard());
 
                     //trim reminder text from StackDesc
@@ -356,7 +356,6 @@ public abstract class SpellAbilityEffect {
         boolean intrinsic = sa.isIntrinsic();
         boolean your = location.startsWith("Your");
         boolean combat = location.endsWith("Combat");
-        boolean upkeep = location.endsWith("Upkeep");
 
         String desc = sa.getParamOrDefault("AtEOTDesc", "");
 
@@ -366,16 +365,11 @@ public abstract class SpellAbilityEffect {
         if (combat) {
             location = location.substring(0, location.length() - "Combat".length());
         }
-        if (upkeep) {
-            location = location.substring(0, location.length() - "Upkeep".length());
-        }
 
         if (desc.isEmpty()) {
             StringBuilder sb = new StringBuilder();
             if (location.equals("Hand")) {
                 sb.append("Return ");
-            } else if (location.equals("Library")) {
-                sb.append("Shuffle ");
             } else if (location.equals("SacrificeCtrl")) {
                 sb.append("Its controller sacrifices ");
             } else {
@@ -384,8 +378,6 @@ public abstract class SpellAbilityEffect {
             sb.append(Lang.joinHomogenous(crds));
             if (location.equals("Hand")) {
                 sb.append(" to your hand");
-            } else if (location.equals("Library")) {
-                sb.append(" into your library");
             }
             sb.append(" at the ");
             if (combat) {
@@ -393,18 +385,14 @@ public abstract class SpellAbilityEffect {
             } else {
                 sb.append("beginning of ");
                 sb.append(your ? "your" : "the");
-                if (upkeep) {
+                sb.append(" next end step.");
-                    sb.append(" next upkeep.");
-                } else {
-                    sb.append(" next end step.");
-                }
             }
             desc = sb.toString();
         }
 
         StringBuilder delTrig = new StringBuilder();
         delTrig.append("Mode$ Phase | Phase$ ");
-        delTrig.append(combat ? "EndCombat " : upkeep ? "Upkeep" : "End Of Turn ");
+        delTrig.append(combat ? "EndCombat "  : "End Of Turn ");
 
         if (your) {
             delTrig.append("| ValidPlayer$ You ");
@@ -422,8 +410,6 @@ public abstract class SpellAbilityEffect {
         String trigSA = "";
         if (location.equals("Hand")) {
             trigSA = "DB$ ChangeZone | Defined$ DelayTriggerRememberedLKI | Origin$ Battlefield | Destination$ Hand";
-        } else if (location.equals("Library")) {
-            trigSA = "DB$ ChangeZone | Defined$ DelayTriggerRememberedLKI | Origin$ Battlefield | Destination$ Library | Shuffle$ True";
         } else if (location.equals("SacrificeCtrl")) {
             trigSA = "DB$ SacrificeAll | Defined$ DelayTriggerRememberedLKI";
         } else if (location.equals("Sacrifice")) {
@@ -781,11 +767,7 @@ public abstract class SpellAbilityEffect {
         return combatChanged;
     }
 
-    protected static void changeZoneUntilCommand(final CardZoneTable triggerList, final SpellAbility sa) {
+    protected static GameCommand untilHostLeavesPlayCommand(final CardZoneTable triggerList, final SpellAbility sa) {
-        if (!sa.hasParam("Duration")) {
-            return;
-        }
-
         final Card hostCard = sa.getHostCard();
         final Game game = hostCard.getGame();
         hostCard.addUntilLeavesBattlefield(triggerList.allCards());
@@ -800,7 +782,7 @@ public abstract class SpellAbilityEffect {
             lki = null;
         }
 
-        GameCommand gc = new GameCommand() {
+        return new GameCommand() {
 
             private static final long serialVersionUID = 1L;
 
@@ -855,13 +837,6 @@ public abstract class SpellAbilityEffect {
             }
 
         };
-
-        // corner case can lead to host exiling itself during the effect
-        if (sa.getParam("Duration").contains("UntilHostLeavesPlay") && !hostCard.isInPlay()) {
-            gc.run();
-        } else {
-            addUntilCommand(sa, gc);
-        }
     }
 
     protected static void discard(SpellAbility sa, final boolean effect, Map<Player, CardCollectionView> discardedMap, Map<AbilityKey, Object> params) {
@@ -922,8 +897,6 @@ public abstract class SpellAbilityEffect {
             } else {
                 game.getUpkeep().addUntilEnd(controller, until);
             }
-        } else if ("UntilTheEndOfYourNextUntap".equals(duration)) {
-            game.getUntap().addUntilEnd(controller, until);
         } else if ("UntilNextEndStep".equals(duration)) {
             game.getEndOfTurn().addAt(until);
         } else if ("UntilYourNextEndStep".equals(duration)) {
@@ -1024,9 +997,8 @@ public abstract class SpellAbilityEffect {
         return true;
     }
 
-    public static Player getNewChooser(final SpellAbility sa, final Player loser) {
+    public static Player getNewChooser(final SpellAbility sa, final Player activator, final Player loser) {
         // CR 800.4g
-        final Player activator = sa.getActivatingPlayer();
         final PlayerCollection options;
         if (loser.isOpponentOf(activator)) {
             options = activator.getOpponents();

forge-game/src/main/java/forge/game/ability/effects/AddPhaseEffect.java

@@ -25,7 +25,7 @@ public class AddPhaseEffect extends SpellAbilityEffect {
     public void resolve(SpellAbility sa) {
         final Card host = sa.getHostCard();
         final Player activator = sa.getActivatingPlayer();
-        boolean isTopsy = activator.isPhasesReversed();
+        boolean isTopsy = activator.getAmountOfKeyword("The phases of your turn are reversed.") % 2 == 1;
         PhaseHandler phaseHandler = activator.getGame().getPhaseHandler();
 
         PhaseType currentPhase = phaseHandler.getPhase();

forge-game/src/main/java/forge/game/ability/effects/AddTurnEffect.java

@@ -7,8 +7,6 @@ import forge.game.ability.SpellAbilityEffect;
 import forge.game.card.Card;
 import forge.game.phase.ExtraTurn;
 import forge.game.player.Player;
-import forge.game.replacement.ReplacementEffect;
-import forge.game.replacement.ReplacementHandler;
 import forge.game.spellability.SpellAbility;
 import forge.game.trigger.Trigger;
 import forge.game.trigger.TriggerHandler;
@@ -74,12 +72,11 @@ public class AddTurnEffect extends SpellAbilityEffect {
 
         final Card eff = createEffect(sa, sa.getActivatingPlayer(), name, image);
 
-        String strRe = "Event$ SetInMotion | EffectZone$ Command | Layer$ CantHappen | Description$ Schemes can't be set in Motion";
+        String stEffect = "Mode$ CantSetSchemesInMotion | EffectZone$ Command | Description$ Schemes can't be set in Motion";
-        ReplacementEffect re = ReplacementHandler.parseReplacement(strRe, eff, true);
+
-        eff.addReplacementEffect(re);
+        eff.addStaticAbility(stEffect);
 
         game.getAction().moveToCommand(eff, sa);
-        game.getEndOfTurn().addUntil(exileEffectCommand(game, eff));
     }
 
 }

forge-game/src/main/java/forge/game/ability/effects/AlterAttributeEffect.java

@@ -8,13 +8,13 @@ import forge.game.ability.AbilityKey;
 import forge.game.ability.SpellAbilityEffect;
 import forge.game.card.Card;
 import forge.game.card.CardCollection;
-import forge.game.event.GameEventCardPlotted;
 import forge.game.player.Player;
 import forge.game.spellability.SpellAbility;
 import forge.game.trigger.TriggerType;
 import forge.util.Lang;
 import forge.util.TextUtil;
 
+
 public class AlterAttributeEffect extends SpellAbilityEffect {
     @Override
     public void resolve(SpellAbility sa) {
@@ -48,8 +48,6 @@ public class AlterAttributeEffect extends SpellAbilityEffect {
                 switch (attr.trim()) {
                     case "Plotted":
                         altered = gameCard.setPlotted(activate);
-
-                        c.getGame().fireEvent(new GameEventCardPlotted(c, sa.getActivatingPlayer()));
                         break;
                     case "Solve":
                     case "Solved":

forge-game/src/main/java/forge/game/ability/effects/AnimateEffectBase.java

@@ -121,7 +121,6 @@ public abstract class AnimateEffectBase extends SpellAbilityEffect {
             if (perpetual) {
                 Map <String, Object> params = new HashMap<>();
                 params.put("AddKeywords", keywords);
-                params.put("RemoveKeywords", removeKeywords);
                 params.put("RemoveAll", removeAll);
                 params.put("Timestamp", timestamp);
                 params.put("Category", "Keywords");
@@ -165,8 +164,14 @@ public abstract class AnimateEffectBase extends SpellAbilityEffect {
 
         // remove abilities
         final List<SpellAbility> removedAbilities = Lists.newArrayList();
-        if (sa.hasParam("RemoveThisAbility")) {
+        boolean clearSpells = sa.hasParam("OverwriteSpells");
-            removedAbilities.add(sa.getOriginalAbility());
+
+        if (clearSpells) {
+            removedAbilities.addAll(Lists.newArrayList(c.getSpells()));
+        }
+
+        if (sa.hasParam("RemoveThisAbility") && !removedAbilities.contains(sa)) {
+            removedAbilities.add(sa);
         }
 
         // give abilities
@@ -246,7 +251,9 @@ public abstract class AnimateEffectBase extends SpellAbilityEffect {
         }
 
         if (!"Permanent".equals(duration) && !perpetual) {
-            if ("UntilAnimatedFaceup".equals(duration)) {
+            if ("UntilControllerNextUntap".equals(duration)) {
+                game.getUntap().addUntil(c.getController(), unanimate);
+            } else if ("UntilAnimatedFaceup".equals(duration)) {
                 c.addFaceupCommand(unanimate);
             } else {
                 addUntilCommand(sa, unanimate);

forge-game/src/main/java/forge/game/ability/effects/AscendEffect.java

@@ -39,7 +39,7 @@ public class AscendEffect extends SpellAbilityEffect {
             }
             // Player need 10+ permanents on the battlefield
             if (p.getZone(ZoneType.Battlefield).size() >= 10) {
-                p.setBlessing(true, sa.getOriginalHost().getSetCode());
+                p.setBlessing(true);
             }
         }
     }

forge-game/src/main/java/forge/game/ability/effects/AttachEffect.java

@@ -1,5 +1,6 @@
 package forge.game.ability.effects;
 
+
 import java.util.List;
 import java.util.Map;
 

forge-game/src/main/java/forge/game/ability/effects/BecomeMonarchEffect.java

@@ -24,7 +24,7 @@ public class BecomeMonarchEffect extends SpellAbilityEffect {
     @Override
     public void resolve(SpellAbility sa) {
         // TODO: improve ai and fix corner cases
-        final String set = sa.getOriginalHost().getSetCode();
+        final String set = sa.getHostCard().getSetCode();
 
         for (final Player p : getTargetPlayers(sa)) {
             if (!p.isInGame()) {

forge-game/src/main/java/forge/game/ability/effects/ChangeTargetsEffect.java

@@ -72,8 +72,8 @@ public class ChangeTargetsEffect extends SpellAbilityEffect {
                 // 2. prepare new target choices
                 SpellAbilityStackInstance replaceIn = chosenTarget.getKey();
                 GameObject oldTarget = chosenTarget.getValue();
-                TargetChoices newTargetBlock = replaceIn.getTargetChoices();
+                TargetChoices oldTargetBlock = replaceIn.getTargetChoices();
-                TargetChoices oldTargetBlock = newTargetBlock.clone();
+                TargetChoices newTargetBlock = oldTargetBlock.clone();
                 // gets the divided value from old target
                 Integer div = oldTargetBlock.getDividedValue(oldTarget);
                 // 3. test if updated choices would be correct.
@@ -87,7 +87,7 @@ public class ChangeTargetsEffect extends SpellAbilityEffect {
                     if (div != null) {
                         newTargetBlock.addDividedAllocation(newTarget, div);
                     }
-                    replaceIn.updateTarget(oldTargetBlock, sa.getHostCard());
+                    replaceIn.updateTarget(newTargetBlock, sa.getHostCard());
                 }
             } else {
                 while (changingTgtSI != null) {
@@ -104,26 +104,25 @@ public class ChangeTargetsEffect extends SpellAbilityEffect {
                             if (candidates.isEmpty()) {
                                 return;
                             }
-                            GameEntity choice = Aggregates.random(candidates);
-                            TargetChoices oldTarget = changingTgtSA.getTargets();
                             changingTgtSA.resetTargets();
+                            GameEntity choice = Aggregates.random(candidates);
                             changingTgtSA.getTargets().add(choice);
                             if (changingTgtSA.isDividedAsYouChoose()) {
                                 changingTgtSA.addDividedAllocation(choice, div);
                             }
-                            changingTgtSI.updateTarget(oldTarget, sa.getHostCard());
+
+                            changingTgtSI.updateTarget(changingTgtSA.getTargets(), sa.getHostCard());
                         }
                         else if (sa.hasParam("DefinedMagnet")) {
                             GameObject newTarget = Iterables.getFirst(getDefinedCardsOrTargeted(sa, "DefinedMagnet"), null);
                             if (newTarget != null && changingTgtSA.canTarget(newTarget)) {
                                 int div = changingTgtSA.getTotalDividedValue();
-                                TargetChoices oldTarget = changingTgtSA.getTargets();
                                 changingTgtSA.resetTargets();
                                 changingTgtSA.getTargets().add(newTarget);
+                                changingTgtSI.updateTarget(changingTgtSA.getTargets(), sa.getHostCard());
                                 if (changingTgtSA.isDividedAsYouChoose()) {
                                     changingTgtSA.addDividedAllocation(newTarget, div);
                                 }
-                                changingTgtSI.updateTarget(oldTarget, sa.getHostCard());
                             }
                         } else {
                             // Update targets, with a potential new target
@@ -133,9 +132,8 @@ public class ChangeTargetsEffect extends SpellAbilityEffect {
                                 source = changingTgtSA.getTargetCard();
                             }
                             Predicate<GameObject> filter = sa.hasParam("TargetRestriction") ? GameObjectPredicates.restriction(sa.getParam("TargetRestriction").split(","), activator, source, sa) : null;
-                            TargetChoices oldTarget = changingTgtSA.getTargets();
+                            TargetChoices newTarget = chooser.getController().chooseNewTargetsFor(changingTgtSA, filter, false);
-                            chooser.getController().chooseNewTargetsFor(changingTgtSA, filter, false);
+                            changingTgtSI.updateTarget(newTarget, sa.getHostCard());
-                            changingTgtSI.updateTarget(oldTarget, sa.getHostCard());
                         }
                     }
                     changingTgtSI = changingTgtSI.getSubInstance();

forge-game/src/main/java/forge/game/ability/effects/ChangeZoneAllEffect.java

@@ -107,8 +107,10 @@ public class ChangeZoneAllEffect extends SpellAbilityEffect {
             final Zone originZone = game.getZoneOf(c);
 
             // Fizzle spells so that they are removed from stack (e.g. Summary Dismissal)
-            if (originZone.is(ZoneType.Stack)) {
+            if (sa.hasParam("Fizzle")) {
-                game.getStack().remove(c);
+                if (originZone.is(ZoneType.Exile) || originZone.is(ZoneType.Hand) || originZone.is(ZoneType.Stack)) {
+                    game.getStack().remove(c);
+                }
             }
 
             if (remLKI) {
@@ -186,12 +188,10 @@ public class ChangeZoneAllEffect extends SpellAbilityEffect {
 
         triggerList.triggerChangesZoneAll(game, sa);
 
-        if (sa.hasParam("AtEOT") && !triggerList.isEmpty()) {
+        if (sa.hasParam("Duration")) {
-            registerDelayedTrigger(sa, sa.getParam("AtEOT"), triggerList.allCards());
+            addUntilCommand(sa, untilHostLeavesPlayCommand(triggerList, sa));
         }
 
-        changeZoneUntilCommand(triggerList, sa);
-
         // CR 701.20d If an effect would cause a player to shuffle a set of objects into a library,
         // that library is shuffled even if there are no objects in that set. 
         if (sa.hasParam("Shuffle")) {

forge-game/src/main/java/forge/game/ability/effects/ChangeZoneEffect.java

@@ -558,15 +558,22 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
                 continue;
             }
 
-            if (originZone.is(ZoneType.Stack)) {
-                game.getStack().remove(gameCard);
-            }
-
             Card movedCard = null;
             Map<AbilityKey, Object> moveParams = AbilityKey.newMap();
             AbilityKey.addCardZoneTableParams(moveParams, triggerList);
 
-            if (destination.equals(ZoneType.Battlefield)) {
+            if (destination.equals(ZoneType.Library)) {
+                // If a card is moved to library from the stack, remove its spells from the stack
+                if (sa.hasParam("Fizzle")) {
+                    // TODO only AI still targets as card, try to remove it
+                    if (gameCard.isInZone(ZoneType.Exile) || gameCard.isInZone(ZoneType.Hand) || gameCard.isInZone(ZoneType.Stack)) {
+                        // This only fizzles spells, not anything else.
+                        game.getStack().remove(gameCard);
+                    }
+                }
+
+                movedCard = game.getAction().moveToLibrary(gameCard, libraryPosition, sa, moveParams);
+            } else if (destination.equals(ZoneType.Battlefield)) {
                 moveParams.put(AbilityKey.SimultaneousETB, tgtCards);
                 if (sa.isReplacementAbility()) {
                     ReplacementEffect re = sa.getReplacementEffect();
@@ -663,24 +670,9 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
                 }
                 if (sa.isKeyword(Keyword.UNEARTH) && movedCard.isInPlay()) {
                     movedCard.setUnearthed(true);
-
+                    movedCard.addChangedCardKeywords(Lists.newArrayList("Haste"), null, false, game.getNextTimestamp(), null);
-                    final Card eff = createEffect(sa, sa.getActivatingPlayer(), "Unearth Effect", hostCard.getImageKey());
-
-                    // It gains haste.
-                    String s = "Mode$ Continuous | Affected$ Card.IsRemembered | EffectZone$ Command | AddKeyword$ Haste";
-                    eff.addStaticAbility(s);
-
-                    // If it would leave the battlefield, exile it instead of putting it anywhere else.
-                    addLeaveBattlefieldReplacement(eff, "Exile");
-
-                    eff.addRemembered(movedCard);
-
-                    movedCard.addLeavesPlayCommand(exileEffectCommand(game, eff));
-
-                    game.getAction().moveToCommand(eff, sa);
-
-                    // Exile it at the beginning of the next end step.
                     registerDelayedTrigger(sa, "Exile", Lists.newArrayList(movedCard));
+                    addLeaveBattlefieldReplacement(movedCard, sa, "Exile");
                 }
                 if (sa.hasParam("LeaveBattlefield")) {
                     addLeaveBattlefieldReplacement(movedCard, sa, sa.getParam("LeaveBattlefield"));
@@ -733,6 +725,15 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
                     commandCards.add(movedCard); //add to list to reveal the commandzone cards
                 }
 
+                // If a card is Exiled from the stack, remove its spells from the stack
+                if (sa.hasParam("Fizzle")) {
+                    if (gameCard.isInZone(ZoneType.Exile) || gameCard.isInZone(ZoneType.Hand)
+                            || gameCard.isInZone(ZoneType.Stack) || gameCard.isInZone(ZoneType.Command)) {
+                        // This only fizzles spells, not anything else.
+                        game.getStack().remove(gameCard);
+                    }
+                }
+
                 if (sa.hasParam("WithCountersType")) {
                     CounterType cType = CounterType.getType(sa.getParam("WithCountersType"));
                     int cAmount = AbilityUtils.calculateAmount(hostCard, sa.getParamOrDefault("WithCountersAmount", "1"), sa);
@@ -747,10 +748,8 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
                     if (sa.hasParam("ForetoldCost")) {
                         movedCard.setForetoldCostByEffect(true);
                     }
-                }
+                    // look at the exiled card
-                // look at the exiled card
+                    movedCard.addMayLookTemp(activator);
-                if (sa.hasParam("WithMayLook") || sa.hasParam("Foretold")) {
-                    movedCard.addMayLookFaceDownExile(activator);
                 }
 
                 // CR 400.7k
@@ -834,8 +833,9 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
         if (sa.hasParam("AtEOT") && !triggerList.isEmpty()) {
             registerDelayedTrigger(sa, sa.getParam("AtEOT"), triggerList.allCards());
         }
-
+        if ("UntilHostLeavesPlay".equals(sa.getParam("Duration"))) {
-        changeZoneUntilCommand(triggerList, sa);
+            addUntilCommand(sa, untilHostLeavesPlayCommand(triggerList, sa));
+        }
 
         // might set after card is moved again if something has changed
         if (destination.equals(ZoneType.Exile)) {
@@ -1040,9 +1040,6 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
 
                     handleCastWhileSearching(fetchList, decider);
                 }
-                if (sa.hasParam("RememberSearched")) {
-                    source.addRemembered(player);
-                }
                 final Map<AbilityKey, Object> runParams = AbilityKey.mapFromPlayer(decider);
                 runParams.put(AbilityKey.Target, player);
                 game.getTriggerHandler().runTrigger(TriggerType.SearchedLibrary, runParams, false);
@@ -1148,6 +1145,7 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
                         }
                     }
 
+
                     // If we're choosing multiple cards, only need to show the reveal dialog the first time through.
                     boolean shouldReveal = (i == 0);
                     Card c = null;
@@ -1382,11 +1380,8 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
                         if (sa.hasParam("ForetoldCost")) {
                             movedCard.setForetoldCostByEffect(true);
                         }
-                    }
+                        // look at the exiled card
-
+                        movedCard.addMayLookTemp(sa.getActivatingPlayer());
-                    // look at the exiled card
-                    if (sa.hasParam("WithMayLook") || sa.hasParam("Foretold")) {
-                        movedCard.addMayLookFaceDownExile(sa.getActivatingPlayer());
                     }
                 }
                 else {
@@ -1482,7 +1477,9 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
         }
         triggerList.triggerChangesZoneAll(game, sa);
 
-        changeZoneUntilCommand(triggerList, sa);
+        if ("UntilHostLeavesPlay".equals(sa.getParam("Duration"))) {
+            addUntilCommand(sa, untilHostLeavesPlayCommand(triggerList, sa));
+        }
     }
 
     private void handleCastWhileSearching(final CardCollection fetchList, final Player decider) {