leriomaggio
6320857864
Code formatting cleanup.
...
Also, it is important to emphasise that previous implementation of the "Strict" Card Art Preference policy were too stringent, and did not account for corner cases when the card could not be retrieved. This has been FIXED in the new API implementation.
2021-07-27 07:40:13 +01:00
leriomaggio
286533cf90
Aligned CardDb calls after API revision for getCardFromEditionsReleasedBefore(date).
2021-07-27 07:40:13 +01:00
leriomaggio
e2aa8874b6
Refactoring and Extension to CardDb Test cases
...
Huge refactoring in variable names and test case optimisations. Also, new tests for the new API are also included. In particular, additional corner cases tested, as well as verification with Legacy (previous) CardDb implementation.
2021-07-27 07:40:13 +01:00
leriomaggio
8de07821e0
Refactoring and Second Update to the new ICardDatabase APIs
...
This new revision of the APi brings a more consistent distribution of the different parameters and settings in DB API calls.
In particular, the changes affect the getCardFromEditions which are now separated into three sets of methods:
- methods to retrieve a card based on CardArtPreference
- methods to also include a Release Date restriction,
that can be now considered in both directions
(as in "releasedBefore" and "releasedAfter" a specified date).
These changes will be functional for new additions in future changes to Deck Importer, as well as will be used
to refine the implementation of the new Smart Card Art Selection in Decks.
From an implementation perspective, it is important to emphasise that all those methods are just syntactic sugar
for parameter passing to the **same** core (private) retrieval method (centralised single point of failure)
which incorporates all the required parameters, that would also be cumbersome to use in a public API.
2021-07-27 07:40:12 +01:00
Lyu Zong-Hong
106515d217
Fix for broken Maven build
2021-07-27 14:38:22 +09:00
Hans Mackowiak
70531a8f31
Merge branch 'classLevelStatic' into 'master'
...
Class: use Static Ability to follow CR
See merge request core-developers/forge!5115
2021-07-27 04:59:51 +00:00
Hans Mackowiak
6562a04667
Class: use Static Ability to follow CR
2021-07-27 04:59:50 +00:00
Michael Kamensky
4decf8bf64
Merge branch 'jumphh' into 'master'
...
Some other new Jumpstart cards
See merge request core-developers/forge!5120
2021-07-27 04:55:27 +00:00
Michael Kamensky
bb65d4d2ec
Merge branch 'manor' into 'master'
...
JHH: Some "seek" cards
See merge request core-developers/forge!5119
2021-07-27 04:55:21 +00:00
Michael Kamensky
119a53b0fd
Merge branch 'acolyte' into 'master'
...
JHH: Subversive Acolyte
See merge request core-developers/forge!5118
2021-07-27 04:54:36 +00:00
Michael Kamensky
c9036f90ef
Merge branch 'mdfc' into 'master'
...
Correctly evaluate modal faces
See merge request core-developers/forge!5112
2021-07-27 04:53:19 +00:00
Michael Kamensky
0cb35f7c84
Merge branch 'target' into 'master'
...
Fix hasAllTargets
See merge request core-developers/forge!5117
2021-07-27 04:52:51 +00:00
Michael Kamensky
3e3f0729a9
Merge branch 'render_token_emblem' into 'master'
...
Also render tokens and emblems when not using images
See merge request core-developers/forge!5121
2021-07-27 04:52:36 +00:00
Lyu Zong-Hong
8f70a6ab96
Pass CardView from scaleImage() too
2021-07-27 13:48:46 +09:00
Lyu Zong-Hong
5f39b98cc5
Also render tokens and emblems when not using images
2021-07-27 12:10:26 +09:00
Sol
d8dfbcf1a3
Update birgi_god_of_storytelling_harnfel_horn_of_bounty.txt
2021-07-27 02:49:04 +00:00
Northmoc
13217aaa3e
wingsteed_trainer.txt
2021-07-26 22:46:57 -04:00
Northmoc
da6162180e
sarkhans_scorn.txt
2021-07-26 22:22:48 -04:00
Northmoc
175db96e4f
CardFactoryUtil - add getMostProminentCreatureType
2021-07-26 19:44:19 -04:00
Northmoc
64e95df6a2
CardProperty - add "MostProminentCreatureTypeInLibrary"
2021-07-26 19:42:43 -04:00
Northmoc
d10a1e1a78
faceless_agent.txt
2021-07-26 19:41:04 -04:00
Northmoc
de4ae7bb3c
CharmEffect.java support GameActivationLimit in formatted desc
2021-07-26 19:09:25 -04:00
Northmoc
f0ead44849
subversive_acolyte.txt
2021-07-26 19:08:34 -04:00
Northmoc
f3ecd98f8a
manor_guardian.txt
2021-07-26 19:06:34 -04:00
tool4EvEr
7eec98db61
Fix CostSacrifice OriginalHost
2021-07-26 21:55:50 +02:00
tool4EvEr
5de3bab789
Fix targetPlayableSpellCard
2021-07-26 21:55:50 +02:00
tool4EvEr
9c57f10461
Fix achievement
2021-07-26 21:55:49 +02:00
tool4EvEr
91e8c24769
Clean up
2021-07-26 21:55:48 +02:00
tool4EvEr
20bc46c0fd
Correctly evaluate modal faces
2021-07-26 21:55:47 +02:00
tool4EvEr
ed8e5e3f2e
Fix hasAllTargets
2021-07-26 21:50:51 +02:00
Michael Kamensky
ab16bd9c19
Merge branch 'rebuke' into 'master'
...
AFC: Hellish Rebuke
See merge request core-developers/forge!5077
2021-07-26 16:59:41 +00:00
Michael Kamensky
114d23a6b8
Merge branch 'glade' into 'master'
...
you_happen_on_a_glade.txt cleanup
See merge request core-developers/forge!5116
2021-07-26 16:58:42 +00:00
Northmoc
f1054cf026
- add whitespace
2021-07-26 10:31:47 -04:00
Northmoc
2ff040d7d4
you_happen_on_a_glade.txt cleanup
2021-07-26 10:31:46 -04:00
Michael Kamensky
0d49de243f
Merge branch 'desktop_card_image_renderer' into 'master'
...
Port the mobile CardImageRenderer to Desktop
See merge request core-developers/forge!5114
2021-07-26 14:08:25 +00:00
Northmoc
329b5953cc
AbilityUtils.java - support "Caster" as Defined
2021-07-26 10:06:53 -04:00
Northmoc
5ae43b65ff
hellish_rebuke.txt finale tweaks
2021-07-26 10:04:12 -04:00
Lyu Zong-Hong
6e831a262d
Don't update image cache if automatically download missing card images is enabled
2021-07-26 22:46:44 +09:00
Lyu Zong-Hong
e6c5c8989c
Implement custom text box renderer
2021-07-26 22:15:08 +09:00
Northmoc
ef00ba8a8a
Support "Condition$ TargetIsTriggerRemembered" in TriggerDamageDone.java
2021-07-26 07:50:08 -04:00
Northmoc
9815acfbdb
move "IsTriggerRemembered" check from ValidTarget to trigger-specific Condition param
2021-07-26 07:50:07 -04:00
Northmoc
4ce37bcaf8
Add "TriggerRememberDefined" (seems to work)
2021-07-26 07:50:07 -04:00
Northmoc
133262a920
hellish_rebuke.txt draft
2021-07-26 07:50:06 -04:00
leriomaggio
29b9cb3ab0
New Set of Testcases (subclassing for regression and backlog) to force card with no Image and being sure same results apply.
2021-07-26 11:31:54 +01:00
leriomaggio
04ae8fc28a
FIX cardDB implementation (and corresponding Tests) for a bug not accounting for too-strict art preference policy for some cards.
2021-07-26 11:31:11 +01:00
Michael Kamensky
572cc75866
Merge branch 'leinore' into 'master'
...
leinore_autumn_sovereign.txt
See merge request core-developers/forge!5111
2021-07-26 03:55:29 +00:00
Michael Kamensky
fee731edde
Merge branch 'morden' into 'master'
...
Fix Mordenkainen's Polymorph
Closes #1942
See merge request core-developers/forge!5110
2021-07-26 03:55:10 +00:00
Michael Kamensky
dd3d26191a
Merge branch 'Fix_Sacrifice_Cards' into 'master'
...
Fixed Sacrificed cards that needed LKI
See merge request core-developers/forge!5113
2021-07-26 03:54:45 +00:00
Sol
77d9575e53
Update ANNOUNCEMENTS.txt
2021-07-26 03:31:06 +00:00
Lyu Zong-Hong
27856e65a0
Port Card Image Renderer to Desktop
2021-07-26 11:33:50 +09:00
