Re wrote the URL parsing logic again, but due to increased complexity put it into a utility class
Fixed desktop version opening up a lobby even when it did not connect to a server
Wired up the new error message to mobile, and both error messages to Desktop
* Refactor - Unknown set code to constant
* Refactor - Support for multiple initial selections for getChoices
* Covert noSell and marked color identities into serializable flags
* Fix cards in deck not being converted to newer noSell format
* unused imports
* Fix NPE
* Cleanup card filter
* Remove 14-year-old check that shouldn't be possible anymore
* CRLF -> LF
---------
Co-authored-by: Jetz <Jetz722@gmail.com>
* Initial commit of network improvements
Seperated server properties into their own file, this will eventually help facilitate a headless server.
Fixed the localhost ip mapping to give the correct IP Address instead of failing and defaulting to "localhost"
Fixed UPnP as well as added some additional options and choices regarding UPnP
Added localization strings to all language files. (Translators will need to translate these, but the current English string is there for easy reference so they dont have to search the en-US file)
* Initial commit of network improvements
Seperated server properties into their own file, this will eventually help facilitate a headless server.
Fixed the localhost ip mapping to give the correct IP Address instead of failing and defaulting to "localhost"
Fixed UPnP as well as added some additional options and choices regarding UPnP
Added localization strings to all language files. (Translators will need to translate these, but the current English string is there for easy reference so they dont have to search the en-US file)
* Fixed properties file reference
* Refactored server address parsing logic to use the Java URI class for improved readability and robustness.
Extracted reusable code into separate functions to enhance modularity and maintainability.
General code cleanup to improve structure and readability.
* Fixed a potential issue if a protocol was already specified in the connection url.
* Removed logger implementation as changing loggers is out of scope for this PR
Reverted to JUPnP as its implementation is fixed in #7367
Made some of the new localization strings generic as they can be used elsewhere
Added a server.preferences.example file
removed the server port from the old location (forge.progile.properties.example)
Added a server port back into ForgeConstants as it doesnt make sense for the prefered hosting port of the user to override the default Forge connection port.
* resolve conflicts between this branch and master
* Implemented a parent class for all preference Enums so they can be passed into a function regardless of type using IPref, necessary since I separated server settings into its own FNetPref file
Added server preferences section to the preferences Desktop GUI
Added a port preference setting and a UPnP preference setting to the aforementioned server preferences section
Added a localizedComboBox and localizedComboBoxListener so that localized strings can be used in combobox dropdowns in the server preferences section.
TODO: (In scope)
The new server preferences section needs to be added to Android and IOS perhaps?
TODO: (out of scope)
GamePlayerUtil has a bunch on non localized english strings that should be converted to localized
* Fixed unused import
* Resolved merge conflicts
Added server settings to the reset to defaults function
* Add command zone effect displaying speed
* Remove enum counter type for speed.
* Make Start Your Engines an SBA.
* LifeLost -> LifeLostAll per speed rules.
* Use same game event for all speed changes.
* Fix keyword not appearing in detail text
* Cleanup extra createSpeedEffect.
* Add support for arbitrary overlay text. Remove fake counters.
* Text styling.
* Remove extra SBA check.
* Remove speed from PlayerView; localization support.
---------
Co-authored-by: Jetz <Jetz722@gmail.com>
* AnimateSubAbility rework
* Remove old fix code, it will no longer be needed
* Add zone ordering
* Add labels
* Clean up
* Fix test
* Tweak logic
* Fix Gilraen
* Refactor with counter
* Clean up
* Cleanup effect if card can't ETB
* Update semesters_end.txt
Format abilities
* Return as Aura trickery
* Apply effect before RE
* Update scripts
* Fix order after creating it earlier
* Fix test
---------
Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
Co-authored-by: Hans Mackowiak <hanmac@gmx.de>
* Start of contraptions
* More contraption work
* More contraption stuff.
Steamflogger Boss implementation
* More Contraption things
* Use AI's preferred target for mandatory animate effects
* Possible fix for Boomflinger's empty target prompt
* Remove nullable low-definition mana pool icon.
* Contraption Predicates
* Desktop extra zone menu
* Remember cranked contraptions
* AnimateAi fallback to AITgts; Bee-Bee Gun
* Fix AI paying optional costs to assemble zero contraptions.
* Override predicted damage for DealDamage effects with random amounts
* Fix double prompt when reassembling other players' contraptions
* All remaining contraptions and support cards!
* Remove unused imports
* Some cleanup
* Implement non-assembled contraption rule.
Fix blank line prefix on card detail text.
---------
Co-authored-by: Jetz <Jetz722@gmail.com>
Replace copyonwritearray to a custom implementation for concurrent modification exception. A little bit slower but supports iterator operations.
Added FCollectionTest
