Commit Graph

1816 Commits

Author SHA1 Message Date
Jetz
4614c6c0c9 Cleanup - Map.getOrDefault and Map.computeIfAbsent 2024-08-10 12:48:52 -04:00
Jetz
bdc890c32c Cleanup - Collections.sort -> list.sort 2024-08-10 12:43:38 -04:00
Jetz
0ee46ff6ef Cleanup - .equals("") -> .isEmpty() 2024-08-10 12:28:18 -04:00
Jetz
9bbe4805a3 Cleanup - Redundant String.format 2024-08-10 12:21:50 -04:00
Jetz
09c76a4dc8 Cleanup - File IO streams 2024-08-10 11:09:31 -04:00
Jetz
ae9877ce3c Cleanup - Collection.toArray 2024-08-10 10:25:35 -04:00
Jetz
158ff30ff8 Cleanup - Missing break from loop with no further consequences 2024-08-10 10:19:01 -04:00
Jetz72
d62dfe1c8c Miscallaneous Cleanup Part 2 - Lambdas and Method References (#5737)
* Cleanup - Unnecessary Boxing

* Cleanup - Unnecessary Unboxing

* Cleanup - For-Each Loops

* Cleanup - `indexOf != -1` -> `contains`

* Cleanup - Merge identical catch blocks

* Cleanup - Try-with-resources

* Cleanup - System.lineSeparator

* Cleanup - Reference types to primitives
Some loops over Integers were switched to IntStreams to hopefully cut down on overall boxing.

* Cleanup - Manually filling and copying arrays

* Remove unused imports

* Switch a lambda to a method reference

* Cleanup - CardPredicate Aggregates to method references

* Cleanup - Other static functions to method references

* Cleanup - Ambiguous class reference
Unclear when or how this happened...

* Cleanup - Anonymous -> Method reference

* Cleanup - Anonymous -> Lambda

* Cleanup - Comparator helper methods

* Cleanup - final method in final class

* Cleanup - private final methods

* Remove unused imports

* Convert a couple more lambdas to comparators.

* Simplify creature type list comparison.

---------

Co-authored-by: Jetz <Jetz722@gmail.com>
Co-authored-by: tool4ever <therealtoolkit@hotmail.com>
2024-08-02 08:23:58 +03:00
Chris H
5fc6d38954 Autoclose FileOutputStreams (#5753) 2024-08-01 21:22:40 +03:00
Chris H
e6379daf91 Localizer fallback to English 2024-08-01 09:17:34 -04:00
Jetz72
ec9f6e2d2b Added attraction light icons (#5663)
Refactored functional variants to be merged in the card face rather than the card factory
Some variant characteristics now show in deck builder columns
Fixed loading progress amount
"[card] has neither ManaCost nor Color" warning now actually displays when these are missing.

Co-authored-by: Jetz <Jetz722@gmail.com>
Co-authored-by: tool4ever <therealtoolkit@hotmail.com>
2024-07-30 08:28:45 +03:00
Jetz72
3968c7e197 Miscallaneous Cleanup (#5703)
* Cleanup - Unnecessary Boxing

* Cleanup - Unnecessary Unboxing

* Cleanup - For-Each Loops

* Cleanup - `indexOf != -1` -> `contains`

* Cleanup - Merge identical catch blocks

* Cleanup - Try-with-resources

* Cleanup - System.lineSeparator

* Cleanup - Reference types to primitives
Some loops over Integers were switched to IntStreams to hopefully cut down on overall boxing.

* Cleanup - Manually filling and copying arrays

* Remove unused imports

* Switch a lambda to a method reference

---------

Co-authored-by: Jetz <Jetz722@gmail.com>
2024-07-29 17:23:43 +03:00
Jetz
983f2d2856 Fixed QuestCommander deck editor, hopefully. 2024-07-23 18:17:59 -04:00
Renato Filipe Vidal Santos
bb9c6dfd76 July 2024 cleanup: code (#5536)
* Update ChooseGenericEffectAi.java

* Update CardTranslation.java

* Update AltWinAchievements.java

* Update altwin-achievements.txt

* Update EffectEffect.java
2024-07-07 13:37:01 +03:00
Jetz
f63848f62e Don't treat avatar creature type as vanguard avatars 2024-07-04 22:05:42 -04:00
Chris H
c92dae1b99 Allow for eternal cards to not be filtered out by funny filter (#5505) 2024-07-03 16:46:41 +03:00
Chris H
3a61118ade Merge pull request #5357 from Jetz72/Attractions
Attraction Support
2024-07-02 11:02:43 -04:00
Chris H
33f34231f4 Add remaining Conspiracy cards
- Archdemon of Paliano
- Canal Dredger
- Deal Broker
- Lore Seeker
2024-06-28 20:40:49 -04:00
GitHub Actions
64b4b58399 [maven-release-plugin] prepare for next development iteration 2024-06-28 13:06:40 -04:00
GitHub Actions
463e4b1267 [maven-release-plugin] prepare release forge-1.6.63 2024-06-28 13:06:40 -04:00
Jetz
33c0e5dfd6 Merge branch 'master' into Attractions 2024-06-23 11:23:47 -04:00
Chris H
d4469ca736 Add Spire Phantasm, Agent of Acquisitions, Cogwork Librarian, Leovold's Operative (#5437)
* Next few Draft cards

* Code review fixes

* Add Spire Phantasm

* Add Agent of Acquisitions, Cogwork Librarian, Leovold's Operative

* Some small fixes

* Getting closer

* Now the UI is updating

* Switch DraftPack to a delegate class

* Fix agent of acquisitions when AI drafts it
2024-06-22 13:42:29 +03:00
Jetz
3e6871ce86 Merge branch 'master' into Attractions
# Conflicts:
#	forge-core/src/main/java/forge/deck/DeckFormat.java
2024-06-19 22:58:49 -04:00
NishacIroCode
c67eae5a1a Commenting out ununsed code to remove warnings. 2024-06-18 22:18:03 -04:00
NishacIroCode
66ef931b58 Initial commit for Piper-like cards. 2024-06-18 22:18:03 -04:00
Jetz
88c9559eea Mobile Deck Editor support for extra sections, including attractions. 2024-06-16 20:51:03 -04:00
Jetz
df40cdaea0 Made DeckSection.matchingSection more suitable for general use by shifting the responsibility of recognizing potential Commanders elsewhere. 2024-06-15 16:44:07 -04:00
Jetz
239735eaca Make countByName work for cards with multiple prints.
Add countByName to Deck
2024-06-15 12:39:38 -04:00
tool4ever
a9849696d3 CardRules: fix case with null tokens list (#5395)
* CardRules: fix NPE

* clean up

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2024-06-09 07:08:45 +03:00
Jetz
1e5e1ba6c0 Redundant import 2024-06-08 12:36:20 -04:00
Jetz
49e7576742 Merge remote-tracking branch 'origin/master' into Attractions
# Conflicts:
#	forge-core/src/main/java/forge/card/CardFace.java
#	forge-core/src/main/java/forge/card/CardRules.java
2024-06-07 22:13:24 -04:00
Jetz
279e1e520e Disambiguate requested print names 2024-06-07 21:59:59 -04:00
Jetz
8c8c8a779b AttractionsYouVisitedThisTurn and Squirrel Squatters
Untangled some oracle text methods in Card and CardState
Sly Spy, Everythingamajig, and two Garbage Elementals
Visit card text fix.
2 more Attractions
2024-06-07 21:36:10 -04:00
tool4ever
e49dd53b20 Include TokenScripts when checking for DeckHints (#5379)
* Include TokenScripts when checking for DeckHints

* Fix test

* Add field for extra logic

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2024-06-06 07:35:05 +03:00
TRT
2fb300eeb6 Fix Wonderscape Sage 2024-06-05 11:37:30 +02:00
Chris H
b57ed2b165 Applying some code review comments 2024-06-04 12:46:26 -04:00
Chris H
26ec757736 Show draft matters data in Card Detail Panel 2024-06-04 12:46:26 -04:00
Chris H
799fd4cc51 More draft matters 2024-06-04 12:46:26 -04:00
Jetz
beed2ad669 Merge fixes, performance tweaks, updated Unfinity's Editions file 2024-06-02 09:32:42 -04:00
Jetz
1b07896afe Merge branch 'master' into Attractions
# Conflicts:
#	forge-core/src/main/java/forge/card/CardRules.java
2024-06-02 02:16:31 -04:00
Jetz
174db0cac6 I think I see why nobody wanted to do this 2024-06-02 02:08:36 -04:00
dependabot[bot]
a647735c74 ---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-22 11:13:02 -04:00
Chris H
6087167673 Draft Matters - How many cards you've drafted this round (#5203) 2024-05-21 11:36:59 +02:00
tool4EvEr
6f27c56b21 Planar Nexus and support 2024-05-16 18:36:24 +02:00
Hans Mackowiak
31ab875d6e ManaCostShard: add Hybrid Colorless (#5199)
* ManaCostShard: add Hybrid Colorless

* Add Hybrid Colorless Sprite

* fix CostReduction for ColorlessHybrid

---------

Co-authored-by: tool4ever <therealtoolkit@hotmail.com>
2024-05-06 08:21:01 +03:00
Renato Filipe Vidal Santos
0c936170fc Tribal to Kindred update (#5186) 2024-05-04 19:39:42 +00:00
GitHub Actions
8a8c77c4ae [maven-release-plugin] prepare for next development iteration 2024-04-25 19:29:38 -04:00
GitHub Actions
a4591fe3ac [maven-release-plugin] prepare release forge-1.6.62 2024-04-25 19:29:38 -04:00
Agetian
9f13d36799 Deck-based AI hints metadata + predefined sideboarding plan support (#5113)
* - Support for AI hints in deck metadata.
- Support for pre-planned sideboarding using an AI hint.

* - Fix imports.

* - NPE prevention for cases when the AI has no sideboard.
2024-04-24 07:56:01 +03:00
Northmoc
9975d68f04 fix crashes issue4472 (#5008) 2024-04-12 18:47:56 +03:00