* Planechase effects draft
Draft to close#4262, by moving the planeswalking ability and the static chaos trigger to an effect carried with the player in a planechase game. Currently this effect is visible in the command zone much like the monarch or initiative (but with no image), which is something that needs fixing; I'd have it be a DetachedCardEffect but there's no linked card for it like there are for commander and companion effects (the active plane [or the face-up plane with the earliest timestamp, I suppose] would be a logical choice for the getCardForUi, but that would require updating it as the plane changes, and in any case because there's a separate effect for each player, the fact that the owner of a DetachedCardEffect is set as the owner of the linked card also adds some wrinkles. In any case, I've set the effects to be created in startGame after initPlane is run, rather than in initVariantZones as is the case for the commander and companion DetachedCardEffects, in anticipation of hopefully in the future making the effect be linked to an active plane).
* Update Player.java
* Move planar dice special action to effect
* Update ComputerUtilAbility.java
* Move die roll chaos to PlanarDice.java
* Fix Stonebinder's Familiar not triggering from Nivmagus Elemental
* Fix so it only triggers for cards
* Surveil triggers on empty library
* Fix missing trigger
* Fix trigger
* fix script
* Fix corner case freeze by trigger for loser (Kharn the Betrayer)
* Fix loser making trigger decision e.g. Shakedown Heavy
* Obeka fix when resolving after AP lost
* fix script
---------
Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
* isCounterableBy cleanup
* ~ move to Card
* update the rest
* ~ fix unused import
* ~ fix Counter better check for ValidSA instead of ValidCard
* ~remove last piece of text
* Fix Skeleton Crew triggering from own ETB
* Fix bad logic
* Add LKI support
* Prowl fix when card gets cast from another zone again
* Clean up
* Clean triggers
* Support LKI for leaves graveyard
* Update effects
* Fix logic
* Fix Living Breakthrough for X spells
* Extract lastState fallback logic
Closes#3318
(Agetian noted in that issue that passing a null for the SpellAbility argument in Player.planeswalk would cause issues with Player.java:2701-2702, but Player.planeswalk has since been altered and no longer has those lines anyway)
I've tested with all three combinations of
1. planar controller leaves the game while also the owner of an active plane (next player becomes planar controller, planeswalks)
2. planar controller leaves the game but doesn't own an active plane (next player takes control of active planes)
3. planar owner leaves the game when not the planar controller (planar controller planeswalks)
* Leaving current plane trigger
* Add a new macro system that tracks clicks
* Old macro system is still around, but currently inaccessible. Maybe give an option if people rebel against that.
Fixes an issue where planeswalk replacements were being applied before confirmation for optional planeswalks, thus making it so that one couldn't choose not to planeswalk with TARDIS's attack trigger if one also controls Susan Foreman