Commit Graph

8618 Commits

Author SHA1 Message Date
Northmoc
acb5151a82 Wave 3 of perpetual rework + Pump double P or T rework (#4423) 2024-01-09 09:31:02 +01:00
tool4ever
fc23a8d9e3 Improve TriggerHandler accuracy (#4484)
* Fix NPE

* Improve TriggerHandler accuracy
2024-01-08 20:13:35 +01:00
tool4ever
1a3a5cbf8c Fix Fatal Lore (#4488)
Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.59>
2024-01-08 09:12:49 +03:00
tool4ever
9ca64b2ad7 Update Card.java
Fix NPE
2024-01-04 22:48:26 +00:00
tool4ever
1e135e8d3b Support for Midnight Crusader Shuttle (#4478) 2024-01-04 16:47:58 +01:00
tool4ever
aa589134d8 Support for Genesis of the Daleks (#4462)
* Support for Genesis of the Daleks

* Fix Rift Elemental

* Fix script

* Fix logic

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2024-01-02 17:20:35 +03:00
tool4ever
76e9b35f72 Fix ProtectEffect (#4456) 2023-12-31 16:43:04 +00:00
Hans Mackowiak
f7d70f1a69 Riot: refactor into UnlessCost like Fabricate (#4448) 2023-12-31 10:12:28 +00:00
Klisz
c02f7c698d Planechase inherent effects (#4408)
* Planechase effects draft

Draft to close #4262, by moving the planeswalking ability and the static chaos trigger to an effect carried with the player in a planechase game. Currently this effect is visible in the command zone much like the monarch or initiative (but with no image), which is something that needs fixing; I'd have it be a DetachedCardEffect but there's no linked card for it like there are for commander and companion effects (the active plane [or the face-up plane with the earliest timestamp, I suppose] would be a logical choice for the getCardForUi, but that would require updating it as the plane changes, and in any case because there's a separate effect for each player, the fact that the owner of a DetachedCardEffect is set as the owner of the linked card also adds some wrinkles. In any case, I've set the effects to be created in startGame after initPlane is run, rather than in initVariantZones as is the case for the commander and companion DetachedCardEffects, in anticipation of hopefully in the future making the effect be linked to an active plane).

* Update Player.java

* Move planar dice special action to effect

* Update ComputerUtilAbility.java

* Move die roll chaos to PlanarDice.java
2023-12-31 09:11:30 +03:00
Hans Mackowiak
c29b6b7fcb GameAction: stop always trigger before etb counter (#4449)
* GameAction: stop always trigger before etb counter

* ~ always clear trigger and check for static abilities again
2023-12-30 15:35:46 +00:00
Hans Mackowiak
c5ecda3774 Overload keyword (#4415)
* Keyword: Overload

* update more cards

* finish Overload

* ~ fix desc

* remove CounterEffect AllValid

* Fix Overload Copy

* StackDescription!

---------

Co-authored-by: Northmoc <tnorthmoc@gmail.com>
2023-12-29 20:43:06 +03:00
Hans Mackowiak
e8a6121d24 Saga and Read ahead refactor for WHO (#4436)
* Saga and Read ahead refactor for WHO

* ~ fix copy sagaRep

* fix etb counter with Barbara Wright

* ~ fix
2023-12-29 20:42:30 +03:00
Hans Mackowiak
8295312ad2 WHO: add can't tap check (#4441)
* WHO: add can't tap check

* ~ update PlayEffect IllusionaryMask

* Patch more places

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2023-12-29 20:42:13 +03:00
Hans Mackowiak
38ef2b997d Revert "Revert "CardDb: add normalized Names (#4376)""
This reverts commit b396f41188.
2023-12-29 09:22:53 -05:00
Chris H
40219a67cf Villanous choice initial implementation (#4395)
* Villanous choice initial implementation

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2023-12-29 09:19:15 -05:00
tool4ever
730ba24864 Rasputin Dreamweaver fix (#4442)
Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2023-12-29 14:24:18 +03:00
tool4ever
a24af8d50e Fix Stonebinder's Familiar not triggering from Nivmagus Elemental (#4424)
* Fix Stonebinder's Familiar not triggering from Nivmagus Elemental

* Fix so it only triggers for cards

* Surveil triggers on empty library

* Fix missing trigger

* Fix trigger

* fix script

* Fix corner case freeze by trigger for loser (Kharn the Betrayer)

* Fix loser making trigger decision e.g. Shakedown Heavy

* Obeka fix when resolving after AP lost

* fix script

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2023-12-26 06:55:53 +03:00
Hans Mackowiak
e6a9ea20c7 Updates "Can't be countered" into Replacement Effects (#4429)
* isCounterableBy cleanup

* ~ move to Card

* update the rest

* ~ fix unused import

* ~ fix Counter better check for ValidSA instead of ValidCard

* ~remove last piece of text
2023-12-26 06:55:35 +03:00
Northmoc
7f5e75bdb0 PIP: Radiation mechanic implementation (#4204)
* PIP: Radiation mechanic implementation

* remove OVERRIDE

* remove unused property
2023-12-26 06:55:14 +03:00
tool4ever
155ddfa2d7 Desertion fix (#4417)
* Fix prototype state being applied twice

* Desertion fix
2023-12-21 17:27:08 +01:00
Hans Mackowiak
6ea6575f83 remove unused ProtectionKey 2023-12-21 08:17:02 +01:00
Northmoc
3bf1e39f05 Remaining perpetual rework (#4394) 2023-12-20 18:32:09 +01:00
Klisz
39b3e729b1 WHO the_matrix_of_time.txt + support (#4378) 2023-12-20 16:24:42 +01:00
tool4ever
151527a646 Fix card LKI existing in both lastStates at once (#4400)
* Fix card LKI existing in both lastStates at once
2023-12-20 16:21:43 +01:00
tool4ever
046f55cb78 ChangesZoneAll: add LKI support (#4385)
* Fix Skeleton Crew triggering from own ETB

* Fix bad logic

* Add LKI support

* Prowl fix when card gets cast from another zone again

* Clean up

* Clean triggers

* Support LKI for leaves graveyard

* Update effects

* Fix logic

* Fix Living Breakthrough for X spells

* Extract lastState fallback logic
2023-12-20 16:20:40 +01:00
Klisz
bb692b2a4b Update Game.java (#4409)
Closes #3318

(Agetian noted in that issue that passing a null for the SpellAbility argument in Player.planeswalk would cause issues with Player.java:2701-2702, but Player.planeswalk has since been altered and no longer has those lines anyway)

I've tested with all three combinations of
1. planar controller leaves the game while also the owner of an active plane (next player becomes planar controller, planeswalks)
2. planar controller leaves the game but doesn't own an active plane (next player takes control of active planes)
3. planar owner leaves the game when not the planar controller (planar controller planeswalks)

* Leaving current plane trigger
2023-12-19 19:24:19 +00:00
Chris H
b396f41188 Revert "CardDb: add normalized Names (#4376)"
This reverts commit ce9ca390f8.
2023-12-19 14:20:50 -05:00
Hans Mackowiak
ce9ca390f8 CardDb: add normalized Names (#4376) 2023-12-19 18:39:18 +01:00
Northmoc
de851fc749 YWOE high_fae_prankster.txt and support (#3921)
* high_fae_prankster.txt and support

* Perpetual rework

* fix imports

* fix imports

* 12/9 cards and tweaks

* fix absorb_energy

* tidy

* 12/10 updates

* 12/12 tweaks and fixes

* 12/13 tweaks

* last tweaks for this PR

* revert unneeded

* revert unneeded for real

* tidy executePerpetual

* cleanup imports

* tweaks 12/15

* fix imports

* LosePerpetualEffect

* cleanup import
2023-12-16 22:25:41 +03:00
Northmoc
41c8908c84 only move to DestZone2 if there is something to move (#4393) 2023-12-16 16:07:00 +00:00
tool4ever
bb1606f159 Fix new plane overwritten with old card (#4382)
* Fix new plane overwritten with old card

* AbilityKey cleanup

---------

Co-authored-by: TRT <>
2023-12-15 17:27:22 +03:00
tool4ever
90c3a13e3d Fix facedown permanent with adventure (#4355)
* Restore adventure text when card not in play

* Remove obsolete code

* Fix crash with Cybership

* Fix NPE
2023-12-15 09:58:30 +01:00
Klisz
023e41c8a0 WHO the_doctors_childhood_barn.txt (#4377)
* Create the_doctors_childhood_barn.txt

* Update the_doctors_childhood_barn.txt

* Update the_doctors_childhood_barn.txt

* Update the_doctors_childhood_barn.txt

* PlaneswalkedTo and ForgetOnPhasedIn

---------

Co-authored-by: tool4ever <therealtoolkit@hotmail.com>
2023-12-14 13:59:44 -05:00
Paul Hammerton
19fc5698bb Merge pull request #4297 from Northmoc/YLCI-3xBoon
YLCI: Merfolk Tunnel-Guide and support (X-time boons)
2023-12-11 14:28:35 +00:00
Northmoc
b4b1eb1889 spacing fix 2023-12-11 08:20:19 -05:00
Hans Mackowiak
430dade5b8 Protection rework for Plural removal (#4284)
* Protection rework for Plural removal

* deprecated getSingularType

* Update AbilityUtils.java

getPlural only for Descriptive

* ~ update view

* Update CardChangedWords.java

* Update AbilityUtils.java

fix lowercase color word replacement

* Update Card.java

add changedCardKeywordsByWord to getChangedCardKeywordsList

* Update CardDetailUtil.java

~ update view

* Before resolving apply text changes

---------

Co-authored-by: TRT <>
2023-12-10 17:04:43 +03:00
tool4ever
e8c17640a9 Fix NPE (#4322)
* Fix NPE

* Fix cards like Klinspire District that use two X SVar

* Clean up

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>
2023-12-08 18:33:41 -05:00
Chris H
03725d2049 Macro system based on recording clicks rather than typing (#4006)
* Add a new macro system that tracks clicks

* Old macro system is still around, but currently inaccessible. Maybe give an option if people rebel against that.
2023-12-07 12:36:13 -05:00
Klisz
4dbe4f1599 Update PlaneswalkEffect.java (#4315)
Fixes an issue where planeswalk replacements were being applied before confirmation for optional planeswalks, thus making it so that one couldn't choose not to planeswalk with TARDIS's attack trigger if one also controls Susan Foreman
2023-12-07 07:58:16 +01:00
Paul Hammerton
404d1c5ca2 Merge pull request #4303 from Klisz/14doc
SLD: the_fourteenth_doctor.txt + support
2023-12-06 15:57:31 +00:00
Klisz
f70ca58a70 WHO susan_foreman.txt + support (#4308)
* WHO susan_foreman.txt + support

* Update susan_foreman.txt
2023-12-06 10:48:05 -05:00
Northmoc
331006e629 YLCI: heralds_reveille + support (#4288)
* YLCI: heralds_reveille + support

* add reset to Player.onCleanupPhase()
2023-12-06 09:25:59 +01:00
Klisz
11f5e6cf20 Update CloneEffect.java 2023-12-05 20:02:43 -07:00
Klisz
1ff853ac2d de-duplicate code 2023-12-05 15:32:48 -07:00
Klisz
efd69b8153 SLD: the_fourteenth_doctor.txt + support 2023-12-05 14:02:12 -07:00
Northmoc
0c94e6de80 merfolk_tunnel_guide.txt initial 2023-12-05 08:27:58 -05:00
tool4ever
1ece8e6668 Clean up (#4295) 2023-12-05 12:36:23 +00:00
GitHub Actions
8c82589436 [maven-release-plugin] prepare for next development iteration 2023-12-04 20:40:21 -05:00
GitHub Actions
7e0088328b [maven-release-plugin] prepare release forge-1.6.59 2023-12-04 20:40:21 -05:00
Paul Hammerton
3ef29b4951 Merge pull request #4277 from Northmoc/WHO-trap
WHO: the_toymakers_trap.txt + support
2023-12-04 14:33:10 +00:00