Michael Kamensky
fbb1c906ea
[maven-release-plugin] prepare release forge-1.6.43
2021-07-19 07:29:51 +03:00
Meerkov
6c89f2053e
Fix: Multiple RemoveDeck hints now properly stack
...
Before: The *last* RemoveDeck hint overwrites all previous flags.
After: Every RemoveDeck hint is stored properly.
2021-07-18 15:35:52 -07:00
Hans Mackowiak
e753d45b42
Update getDefinedCards for how it get Valid* cards so the syntax is consistent with other Valid script. Also remove the hacky way to set Effect as mutable for Raging River and Plague of Vermin
2021-07-18 09:06:47 +00:00
leriomaggio
f1fbb0ff80
Restored removal of preferredArt attr in StaticData
2021-07-14 08:20:04 +01:00
leriomaggio
573901ce51
Merge remote-tracking branch 'upstream/master' into collector-number-in-card-list-and-card-db-refactoring
2021-07-13 08:22:58 +01:00
leriomaggio
7528b2b4b8
Improved implementantion for add w/ cardRequest and custom cards and fromCardlist
2021-07-13 08:09:06 +01:00
leriomaggio
6b60e478ee
Patch showing custom card warning properly
2021-07-12 09:22:15 +01:00
leriomaggio
e67402d5ae
Change of policy for custom cards load
...
I've decided to use the option in settings only for gameplay, and so always allowing the load of custom cards.
This is because otherwise the option should be much more pervasive, so inhibiting card catalog, sets filters, ...
So the option will just control the use of custom cards in decks for gameplay (still false by default!)
2021-07-11 19:48:23 +01:00
leriomaggio
72e40504d7
Deck conformance check now includes custom cards to be (eventually) used in games.
2021-07-11 19:07:23 +01:00
leriomaggio
811d6479f5
CardPool now includes the option to load custom cards and check preferences.
...
If Custom Card setting is disabled, an error message in logs will be printed accordingly.
Custom Cards will be loaded as such in Card Pool only if the option in settings is enabled.
2021-07-11 19:06:39 +01:00
leriomaggio
e6958305b5
StaticData now includes an extra option to control the use of Custom Cards
...
This option is read from ForgePreferences and passed to StaticData by FModel
2021-07-11 19:04:56 +01:00
leriomaggio
7664937c93
Updated CardArtPreference Constants value
...
Also, the CardArtPreference Enum now includes a new methods that allows seamless recognition (and instantiation) of corresponding enum value from Forge Preference - also with backward compatibility.
2021-07-09 20:20:52 +01:00
leriomaggio
d184856d16
Renamed Card Art Preference
2021-07-08 07:47:15 +01:00
leriomaggio
b0c1f1cb0b
Merge remote-tracking branch 'upstream/master' into collector-number-in-card-list-and-card-db-refactoring
2021-07-06 08:36:40 +01:00
leriomaggio
574d967cd4
New method to get Art Preference from CardDb, and refined load card method passing on edition from requestInfo
...
The revised implementation of `attemptToLoadCard` method now also takes into consideration any setcode that may be present into request info.
This is to reduce db lookup operation and returning a card from a very specific set.
2021-07-06 08:21:41 +01:00
leriomaggio
6adfa8b7a7
A few changes to all CardArtPreferences names and set value
...
Setting the value of card art preference from string now is more reliable, and it falls back automatically to the default
(Latest Art All editions).
This is to allow setting the enum value from Forge Preference Labels.
2021-07-06 08:19:31 +01:00
leriomaggio
91913879e9
Renamed SetPolicy for old art no promo
...
The new name, i.e. OldArtExcludedPromoAndOnlineEditions is more self-explanatory - a bit long though.
Won't exclude that I will come back at namings after having now worked on CardEdition.Type revision
2021-07-06 08:09:46 +01:00
leriomaggio
42223f109e
Merge remote-tracking branch 'upstream/master' into editions-type-review
2021-07-05 09:40:34 +01:00
leriomaggio
81ec996ab3
DRAFT_INNOVATION card edition type renamed as DRAFT
...
The new name IMHO is easier and more appropriate as a category name.
This would be a mismatch with Scryfall Nomenclature, but Forge contains already mismatch (e.g. REPRINT) so not a big deal.
2021-07-05 08:04:19 +01:00
Hans Mackowiak
5cb384afa2
Grist: Better check for StaticAbility using ExcludeZone, fix timestamp on Stack, and extra rule for canBeCommander
2021-07-04 18:27:31 +02:00
leriomaggio
3906c1f3a5
Merge remote-tracking branch 'upstream/master' into editions-type-review
2021-07-04 00:22:10 +01:00
leriomaggio
c9f0d81d29
Type for Custom editions changed from THIRDPARTY to CUSTOM_SET
2021-07-03 21:04:29 +01:00
Lyu Zong-Hong
be40fce2c6
Implement Dungeon mechanism and related spoiled cards
2021-06-26 18:29:14 +09:00
leriomaggio
bed2d0bddc
Merge remote-tracking branch 'upstream/master' into editions-type-review
2021-06-25 17:08:45 +01:00
friarsol
dc886b139a
Add full availability of other booster types
2021-06-22 23:36:12 -04:00
friarsol
2619cca56f
Add support for collector boosters
2021-06-21 21:44:54 -04:00
leriomaggio
79f4595292
Merge remote-tracking branch 'upstream/master' into editions-type-review
2021-06-21 11:45:15 +01:00
leriomaggio
3ba464665e
New methods returning a map of all editions per type.
...
This method is used to populate the "Sets" advanced filters in UI (so far, desktop only)
2021-06-21 11:43:51 +01:00
leriomaggio
844360fb34
CardEdition.Type now includes new methods for String representation (UI)
2021-06-21 11:43:01 +01:00
Lyu Zong-Hong
c7d7130344
Update oracle for MH2 release
2021-06-19 12:47:36 +09:00
leriomaggio
e8b6e066e3
Updated types in CardEdition enum
2021-06-16 07:25:38 +01:00
leriomaggio
b79fc195a1
Updaetd PROMO type from (old) PROMOS
2021-06-13 20:39:42 +01:00
leriomaggio
b8aaf8fb68
New Card Types categories also for custom editions
...
Card Editions now includes updated Types, following the new remapping.
Moreover, a new option to CardEdition.Reader has been added (in the constructor) in order to account for custom editions.
So far this new "reading mode" accounts for type that is "forced" always to be "THIRDPARTY" so to guarantee consistent sets filtering (so far only on Mobile platform).
This new option is integrated in StaticData when instantiating the collection for CustomEditions.
2021-06-13 20:23:34 +01:00
Michael Kamensky
4e1c6cb678
[maven-release-plugin] prepare for next development iteration
2021-06-12 16:30:00 +03:00
Michael Kamensky
7e1fd332e0
[maven-release-plugin] prepare release forge-1.6.42
2021-06-12 16:29:51 +03:00
Michael Kamensky
368c2f9796
[maven-release-plugin] prepare for next development iteration
2021-06-12 16:13:39 +03:00
Michael Kamensky
d658df35d6
[maven-release-plugin] prepare release forge-1.6.41
2021-06-12 16:13:31 +03:00
Michael Kamensky
c07f3ea34d
Merge branch 'master' of git.cardforge.org:core-developers/forge into agetian-master
2021-06-11 07:50:33 +03:00
leriomaggio
18febc5af0
Merge remote-tracking branch 'upstream/master' into collector-number-in-card-list-and-card-db-refactoring
2021-06-09 19:33:01 +01:00
leriomaggio
6ba081f1a0
getReplacementCard got a more significant name to also be used in DeckController
2021-06-09 19:06:28 +01:00
leriomaggio
7bcc4b46e1
Removed useless artIndex parameter
2021-06-09 19:04:38 +01:00
leriomaggio
0c813024d2
First improvement to API in convertXitaxMethod simplifying implementation thanks to new CardDb API
2021-06-09 18:51:08 +01:00
leriomaggio
319cb5515c
Updated PaperCard constructor to safely set Art index when negative values are passed in.
2021-06-09 17:53:05 +01:00
leriomaggio
448263d9de
Comment (and test!) to demonstrate that current implementation of getEarliestEditionWithAllCards not only has a misleading name, but also doesn't work the way it should!
2021-06-09 17:48:07 +01:00
leriomaggio
b17ea15935
Updates with new renamed CardArtPreference options in CardDb
2021-06-09 17:44:55 +01:00
leriomaggio
87257f0413
Using IPaperCard constants for ArtIndex instead of hard coded values when adding cards to pool
2021-06-09 17:44:07 +01:00
leriomaggio
5ad05f94ad
Updated API call to CardDB with getArtCount and getMaxArtIndex
2021-06-09 17:35:18 +01:00
leriomaggio
58cfbf4c0d
Updated API call to CardDB with PreferredCardArt
...
Note: the `convertByXitaxMethod` will be soon discontinued thanks to the new upcoming option and API.
Same will apply to those methods in StaticData
2021-06-09 17:33:37 +01:00
leriomaggio
eb9899e405
Updates to ITokenAPI aligned with Cards' Interface.
2021-06-09 17:26:12 +01:00
leriomaggio
8ea2f18fda
Updates to StaticData to pass on preferredArt to CardDb constructor and new CardArtPreference enum.
2021-06-09 17:24:57 +01:00
