Commit Graph

5436 Commits

Author SHA1 Message Date
Rob Schnautz
08a87ea112 Add conspiracy and ante cards to ban lists, update Standard, Modern, and Commander. Modern list is officially effective the 19th, all the rest is current. Add block formats. Reorder formats in the same order shown on the website. Move Extended to the end. To do: remove Extended. 2018-02-12 23:56:45 +00:00
Seravy
8f9857e72d Fixing Planeshift set alter foils in boosters
-Now always foil, and with the (guesstimated) correct chance.
2018-02-12 01:11:03 +01:00
Seravy
e04d88977e adding to cards L-Z
Added creatures with low power that have
-abilities that tap for something really valuable like drawing a card
-abilities that usually need to be saved until enemy turn (counter a spell, tap a creature, prevent damage)
-abilities that usually deal equal or more damage if not attacking (prodigal sorcerer, grim lavamancer)
Generally avoided abilities where activating before combat is an acceptable choice and thus the attack decision doesn't come up anyway as the AI already used the ability.
However, this behavior is unacceptable on certain abilities (mostly those with higher mana costs) which should not be used before the end of main 2 as it prevents the AI from actually playing their cards. (like Hanna Ship Navigator)

I suspect this will need quite a bit of improvement in the future but we have to start somewhere.
2018-02-11 22:13:58 +01:00
Hanmac
3e613a8b80 cards: remove triggerZones from Unequip trigger, it doesn't work with ChangeZoneAll effects 2018-02-11 21:04:49 +01:00
Seravy
1f364168e8 adding to cards D-K 2018-02-11 20:55:44 +01:00
Seravy
94eda92d21 Adding to cards A-C 2018-02-11 20:15:51 +01:00
Seravy
3662bb8e84 Implements Feature 2018-02-11 17:31:20 +01:00
Michael Kamensky
acf7a23965 Merge branch 'HornedKavuFix' into 'master'
Fixes Horned Kavu being played incorrectly (returning another Horned Kavu or itself)

See merge request core-developers/forge!201
2018-02-11 14:26:20 +00:00
Seravy
8579ae99a0 Fixes Horned Kavu being played incorrectly (returning another Horned Kavu or itself) 2018-02-11 14:42:41 +01:00
Hanmac
da5cb3d905 check lands: use shorter code for etb replacement 2018-02-11 12:11:04 +01:00
Michael Kamensky
d5da9a80f6 Merge branch 'assorted-fixes' into 'master'
- Fixed the AI targeting restrictions check, added an AI logic for The Scarab God.

See merge request core-developers/forge!199
2018-02-11 05:09:39 +00:00
Agetian
670966be57 - Fixed the AI targeting restrictions check in AiController to account for the AILogics that can pre-target cards.
- Added an AI logic for The Scarab God (can be generalized later).
2018-02-11 07:46:38 +03:00
Seravy
ff054d44b7 Adding to cards where needed part 3 - Done up to base set 10th ED, expansions Apocalypse 2018-02-11 02:14:58 +01:00
Seravy
e909cfc744 Adding to cards where needed part 2 2018-02-11 01:49:43 +01:00
Seravy
b51ca84a8f Adding to cards where needed (and removing from cards where it isn't safe to rely on one copy, like Moat) 2018-02-11 00:28:22 +01:00
Seravy
3a9af0480d Improves "NonStackingEffect" Svar behavior for the AI.
The AI will now not play a second copy of these cards if and only if, there is no copy of the card owned by that AI in play, except copies that are enchanted by Auras owned by other players.
Later, a better logic that actually determines whether the enchanting aura removes the relevant ability from the card or not should be added - Warp Artifact will not stop a disk from activating, but Arrest will (if it's a creature).

Note : Only add NonStackingEffect to permanents the AI shouldn't play more than one of at a time if and only if, removal of enchantment is not pontentially leathal to the AI.
For example, do not add to Ensnaring Bridge or Moat, as loss of those allows the enemy to swing with possibly accumulated large armies for likely too much damage.
Those cards will need a different logic, that avoids playing a second copy if and only if the threat the card protects from is already too dangerous.
2018-02-10 23:21:03 +01:00
austinio7116
cb37cf0889 Refresh of Frontier Cube to include RIX 2018-02-10 09:36:49 +00:00
Michael Kamensky
b5721a7e36 Merge branch 'OkkFix' into 'master'
Had wrong card name in Oracle text

See merge request core-developers/forge!192
2018-02-10 03:35:54 +00:00
Rob Schnautz
a3e5e40385 description, premium Spearbreaker Behemoth 2018-02-10 01:17:19 +00:00
Rob Schnautz
e13ed6f46e description, premium Paleoloth 2018-02-10 01:15:18 +00:00
Rob Schnautz
65dffbbe3a description 2018-02-10 01:12:15 +00:00
Rob Schnautz
16dafc9c57 description
(cherry picked from commit 909ee41e066207a9c3e4d943fd190e229765be66)
2018-02-10 01:06:35 +00:00
Rob Schnautz
bcd2f95e4d description
(cherry picked from commit f274dbe74e3fcda7e97c40df996b8b1533c04673)
2018-02-10 01:06:16 +00:00
Rob Schnautz
51ae7fee7e description 2018-02-10 00:55:19 +00:00
Rob Schnautz
2eb276f995 description, premium Treasury Thrull 2018-02-10 00:51:03 +00:00
Rob Schnautz
6a98f9947a description 2018-02-10 00:48:28 +00:00
Rob Schnautz
66cbd1a30e description 2018-02-10 00:45:17 +00:00
Rob Schnautz
c8d1b56d9e description, premium Phyrexian Hydra 2018-02-10 00:44:44 +00:00
Rob Schnautz
457ce2958e description, premium Doomwake Giant 2018-02-10 00:44:01 +00:00
Rob Schnautz
b7b6d5672e description, premium Conundrum Sphinx 2018-02-10 00:15:14 +00:00
Rob Schnautz
7dac6197e3 premium Djinn of Wishes 2018-02-10 00:12:03 +00:00
Rob Schnautz
ea40b439ee description, premium Resolute Archangel 2018-02-10 00:05:32 +00:00
Rob Schnautz
7061f7f26a premium Flameblast Dragon 2018-02-10 00:00:30 +00:00
Rob Schnautz
de1342a5d7 description, premium Jace's Mindseeker 2018-02-09 23:57:44 +00:00
Rob Schnautz
2f976dbeb3 description, premium Hellkite Charger 2018-02-09 23:51:56 +00:00
Seravy
e37e242bae Had wrong card name in Oracle text 2018-02-10 00:13:48 +01:00
Michael Kamensky
1740be22ae Merge branch 'InvasionWorld' into 'master'
Invasion world

See merge request core-developers/forge!189
2018-02-09 18:23:10 +00:00
Hanmac
35c499a074 Crafty Cutpurse: make it use a Control Layer for the Token Create Effect 2018-02-09 17:07:48 +01:00
Rob Schnautz
d2d4318659 Add new file 2018-02-09 04:17:32 +00:00
Agetian
fc6d1d2ab8 - Filename fix.
- Updating CHANGES.txt.
2018-02-09 06:47:28 +03:00
Michael Kamensky
7fb12fa5b3 Merge branch 'mtgo-editions' into 'master'
Five editions from MTGO

See merge request core-developers/forge!182
2018-02-09 03:37:07 +00:00
Michael Kamensky
791e53a935 Merge branch 'amonkhet' into 'master'
Amonkhet quest world

See merge request core-developers/forge!181
2018-02-09 03:36:24 +00:00
Rob Schnautz
ca61291995 comment out boosters until later to prevent corruption of quest files when shop tries to generate a booster 2018-02-09 01:45:57 +00:00
Rob Schnautz
a875557000 Commander Theme Decks 2018-02-09 01:38:33 +00:00
Rob Schnautz
517590883c Duel Decks: Mirrodin Pure vs. New Phyrexia 2018-02-09 01:19:35 +00:00
Rob Schnautz
ffa58f71f0 Magic Online Deck Series (TD0, but since this abbreviation was used for two sets, using the TD1 abbreviation that MTGO skipped) 2018-02-09 01:08:08 +00:00
Rob Schnautz
9017f1488f Treasure Chests 2018-02-09 00:59:39 +00:00
Rob Schnautz
c6bac3a247 Legendary Cube 2018-02-08 23:46:55 +00:00
Seravy
a7e48e8af0 The Domain deck is currently AI unplayable, but likely easy to fix later, see (20)
Most decks were tested in the old version (roughly 2017 October-November?).
They are AI playable albeit the AI doesn't play them perfectly - still it's good enough to include the world in a release. AI can always be improved later, as long as it doesn't self-defeat all the time with all the deck. (which was a real issue in the Tempest block where ~20 out of the 40 decks were unplayable for the AI, thus that world is still unfinished - AI has to be improved first.)
This is a list of issues I observed with the AI while testing the Invasion decks :

AI minor :
2. AI should prioritize returning Flametongue Kavu or Kavu Climer or other beneficial trigger creatures for gating creatures (or to any other bonuce effects)
3. Pernicious Deed should have that flag that prevents the AI from playing a second copy (same for Obvlivion Stone, Nevynnirral's Disk if they don't have it yet)
4. The AI seems to prefer playing normal lands first, "enters play tapped" lands later. That's usually the wrong play for the first few turns, where the AI wouldn't have a card to play from the mana anyway.
5. The AI seems to randomly send Captain Sisay to attack or search a card, this should be done smarter, always search if hand is not full and enemy isn't below 7 life?
6. Would be nice if the AI could recognize Rith's ability as one that produces potential blockers for the next turn.
9. When the AI plays a second copy of Teferi's Moat, it shouldn't pick the same color (and shouldn't play the second copy if the opponent plays only one color)
11. Not related to the invasion block but a generic issue : The AI prefers to kill the creatures I steal with Preacher instead of Preacher itself. I'm winning 99% of the games where I draw that card due to this, which likely messes up the difficulty testing results.
13. AI probably shouldn't play Skizzik without kicker as it sometimes does so then doesn't attack anyway or should learn to always attack with it if it wasn't kicked.
15. The AI had enough mana to play Urza's Rage with kicked and could have won the game by doing so, yet it played it without kicker and dealt only 3 damage. This happened more than once, it probably can't pay the kicker cost at all.
17. The AI uses Order // Chaos to kill creatures that are already having leathal damage on the stack from Powerstone Minefield
18. The AI sometimes doesn't seem to be able to use Tahngarth's ability, other times uses it during upkeep. It should never be used before the declare attackers step. (take advantage of vigilance)
19. Once the AI attacked with a 2/2 Quiron Dryan into my 2/3. It had Wax // Wane in hand but no mana to play it - all 3 lands were tapped.
21. Making Pulse of Llanowar, Elfhame Sanctuary and Fertile Ground AI playable would likely increase the AI playability of the block a lot (currently none of these cards are included in AI decks)
23. The AI used a counterspell to counter a spell targeting Glimmering Angel instead of activating the ability
25. The AI activated Crosis the Purger when I had zero cards in my hand.
26. Creatures with the "tap target creature" ability like Benalish Trapper and Stormscape Appreneic should not attack if the opponent has creatures that could be tapped next upkeep to prevent them from attacking.
(this seems to be a generic problem - small creatures with important noncombat abilties should be marked "stay home" and not attack unless the enemy is so low on health they can be defeated by 3 swings from the creature. This was one of the main problems
in Tempest block, for example Hermit Druid, Tradewind Rider and Ertai Wizard Adept. I really wanted to implement AI logic for this myself but...)
27. Yawgomoth's Ageanda should also be marked as a spell where the AI should never play a second copy (also it shouldn't be played without a large graveyard but I don't think the AI did that even once so maybe that's already implemented?)
33. The AI always picks "lose 1 life" on Putrid Warrior even if the opposite would be better.
36. AI played played a creature before Desolation Giant in the same turn.
39. AI doesn't seem to pay a kicker cost for Verdeloth the Ancient even if it has mana to do so.
40. AI uses Nightscape Master to bounce cards it could be killing with the other ability instead.
41. AI probably shouldn't use Recoil to bonuce own cards.

AI major :
1. AI should not play gating creatures if it would return another gating creature to hand, unless it's triggering kavu lair or sparkcaster ability.
7. The AI shouldn't sacrifice Fires of Yawimaya to deal 2 more damage when I still have 20 life. This should only be used to save creatures, or deal leathal damage to a blocker or player.
7b - it especially shouldn't do this is that results in the buffed creature no longer having haste and failing to attack!
8. The AI uses Rout as an instant during its own upkeep instead of waiting until main 1 and saving 2 mana (or possibly attacking first and doing it in main 2), this should never be used as an instant during the AI's own turn.
10. The AI seems to consistently fail paying both kicker costs on volvers even if it can afford doing it - it only pays one of them.
12. AI might be unable to pay the kicker for Dralnu's Pet - it had the mana and creature in hand but didn't do it. (and the creature was of a color the AI cannot play from hand)
14. Like Rout, Ghitu Fire also shouldn't be played as an instant during the AI's own upkeep. In fact, the AI generally should not use instant effects or cards during its own upkeep, it's very rarely the correct move, if ever.
22. The AI seems to be unable to play the card "Meddling Mage" even though it's marked with a "?" not an "AI" tag. I wouldn't expect it to play "fair" and pretend it has no idea what cards are in my deck (it guesses the color of my cards for other choices anyway) but in worst case it should at least play it as a 2/2 for 2 and name any random card it has no copies of in its deck.
24. The AI does not consider the board when picking colors for Voice of All. Even if I have two big white flying creatures in play, it still picks black because my deck has more black cards than white.
28. Once the AI had Temporal Spring and AEther Mutation in hand, and 4 life while I had 3 2/x creatures and it didn't play either bonuce spell. Maybe it was holding mana to cast Fact or Fiction later? (it had 5 lands, 3 forest 2 island)
(surprisingly it didn't even try to play Fact or Fiction before I won. Bug?)
29. The AI probably shouldn't play Phyrexian Arena when at low (below 10?) health.
30. AI didn't activate Pernicious Deed to destroy my 3/3 animated swamp that was killing them, even though it only takes an activation cost of 0. It also didn't activate it when I had a 4/4, they had a 4/4 and I had a 2/1 flying and they had 2 life.
After further games : In general the AI does not use Pernicious Deed very well (on top of playing 2-3 copies), and lets me hit them each turn with creatures and even dies, as long as I don't play too many at a time.
While I won't rate decks unplayable for just this, I'm pretty sure the decks including the card perform significantly worse than they could be and the card is borderline unplayable in the sense the AI obstinently refuses to activate it to save itself.
I suspect there is a threashold for how much advantage it expects from the card, and will not use it otherwise, even if not using it means losing the game. (even if I would be the only one losing permanents!)
31. The AI doesn't attack with units enchanted by Armadillo Cloak, and keeps them as blockers, even if it could gain several times the life it would lose to not blocking by the attack (AI had a 7/7 trample with it, I had two 2/x to attack and a 2/1 flying)
32. On the long term some sort of logic to decide whether to waste a kicker card immediately or wait for mana to use it with kicker would be nice, but it'll likely be hard to make one. (This is especially important for creatures, like Kavu Titan, volvers, etc)
34. When the AI has a 1/1 creature enchanter with Quicksilver Dagger, it still uses it to attack instead of tapping it to deal damage AND draw a card. (and this actually risks losing the creature to a "destroy target attacking..." spell)
35. The AI should play Warp Devotion before the bounce spells. As is, that deck works poorly.
37. AI had a Bloodfire Colossus in play, had active red mana, I had 3 life, it had 12, didn't activate to win, instead used Rout to destroy all creatures, and it didn't even sac it in response!
(I thought we improved the DamageAll logic? Is this card not using it?)
38. AI doesn't recognize Gerrard Capashen's ability to tap when attacking, so it fails to notice it could win the game as I only have 3 life and 1 blocker which could be tapped.

AI severe :
16. The AI seems to be unable to play Orim's Thunder at all, even if I have both a creature and an artifact and the creature is weak enough to be killed by the kicker effect. It can't even play it without kicker.
(I'll rank the deck with this card 1 higher to account for this bug getting fixed in the future - most of the AI's losses came from holding these and not using them to kill my creatures.)
20. The AI is unable to play Harrow and Allied Strategies even if it has no other cards to play and has mana. I unfortunately have to conclude the "Domain" deck is not AI playable as is - land searching and drawing are essential for it.
Note : I did see the AI play Harrow once in a blue moon, for example when it was about to die in combat, but it usually does not play the card.
28. AI used Dromar to return itself to hand by picking white (I had no white creatures). As all 5 dragon legends are actual opponents with their cards in the deck, and Dromar's doesn't have another creature, this is quite a big problem.
2018-02-09 00:27:00 +01:00
Rob Schnautz
41b73da329 fix set 2018-02-08 23:08:28 +00:00