Commit Graph

2908 Commits

Author SHA1 Message Date
Hanmac
2b055b84fb CardFactoryUtil: fixed Manifest 2016-12-17 11:04:05 +00:00
Agetian
eaf4e94851 - Reverting the RememberLKI change for now, breaks many other cards. 2016-12-17 08:08:03 +00:00
Agetian
3f2b5425b9 - AB Destroy should remember LKI if instructed to via RememberLKI parameter even if the creature is not destroyed (for the sake of subabilities that may reference that LKI). Fixes Phthisis + regenerating a creature. 2016-12-17 06:23:37 +00:00
Agetian
99b730ebc7 - NPE prevention in Charm effect (note: if the AI is trying a Charm effect while it hasn't chosen anything, then there's also an issue elsewhere in the logic, may need further examination/correction). 2016-12-16 18:59:14 +00:00
Agetian
f439fe52c4 - Fixed Everflowing Chalice NPEing after being cast via Delay. 2016-12-16 18:49:34 +00:00
Agetian
c2907aa915 - [Experimental] attempt to fix Kalitas, Traitor of Ghet interaction with mass removal by reading LKI about the card's last known zone on a Moved replacement effect event. 2016-12-16 07:07:11 +00:00
Hanmac
b8f7ea55f4 CardFactoryUtil: move Cumulative upkeep as part of SacrificeEffect and add it to Trigger
remove multiplyCost because its not needed anymore
2016-12-14 21:08:44 +00:00
Hanmac
ddb7bcd974 Cost: make Cost better copyable
When adding CostParts, make CostAddMana join together
2016-12-14 20:55:32 +00:00
Agetian
8d427fd2fe - Removed debug messages. 2016-12-14 16:28:54 +00:00
Agetian
3407e84965 - Temporary fix [attention required]: fill Execute parameter for SAs that are parented to Charm API. Fixes Sapphire Charm first ability crashing. Most likely requires a different fix, please correct. 2016-12-14 16:17:12 +00:00
Agetian
8c7f967d50 - Fixed Jhoira of the Ghitu Avatar crashing. 2016-12-14 16:08:29 +00:00
Agetian
24f993eaef - Somewhat neater implementation of Storm description. 2016-12-14 14:35:22 +00:00
Agetian
03f100686a - Added a missing parenthesis. 2016-12-14 04:40:30 +00:00
Agetian
8e8bc627ef - Fixed generation of Storm description (fixes e.g. Astral Steel and friends crashing). 2016-12-14 04:37:49 +00:00
Agetian
f32fe2d130 - A cleaner import cleanup 2016-12-13 19:16:19 +00:00
Agetian
e210a9d744 - Removed an unused import. 2016-12-13 19:15:11 +00:00
Agetian
3be3a5424e - Reverted the Delve change in CardFactoryUtil for now, looks not necessary. 2016-12-13 19:10:56 +00:00
Hanmac
7bd7a0fcea CardFactory: reorder SpellAbilities, the First should be SpellPermanent 2016-12-13 18:49:51 +00:00
Agetian
7e9454a9c9 - Fix Delve not working for permanents (most notably creatures) that have additional non-mana abilities. 2016-12-13 17:20:25 +00:00
Agetian
9cc3ba1a62 - Fixed Undying triggering twice. 2016-12-13 04:48:58 +00:00
Agetian
2fddaf0963 - Invoke sa.copy() when copying spell abilities in card factory to assign them a new ID such that they do not end up being locked to their original hosts. 2016-12-12 17:46:24 +00:00
Hanmac
3bdc2101e6 CardFactoryUtil: moved Echo to new Format 2016-12-12 06:04:29 +00:00
Agetian
9aaf5ccba0 - Fixed Surge description generation. 2016-12-12 05:24:58 +00:00
Hanmac
dbab21059d AbilityFactory: fixed additionalAbilities for AbilitySub without parent (might happen for Trigger) 2016-12-11 08:23:43 +00:00
Sol
79813ceed7 Fix Cumulative Upkeep not hitting the stack for AI 2016-12-10 20:54:55 +00:00
Hanmac
1ce2486044 Spell: add extra checkStaticAbilities to revent to unbestowed state 2016-12-10 19:18:50 +00:00
Agetian
f15b5ba4f9 - Additional changes to Card and Spell to support the visual flickering-free Bestow check 2016-12-10 18:59:59 +00:00
Agetian
86c30d0ffe - Attempting to preserve the visual flickering-fixing effect of the previously reverted r32578 by not updating the view when temporarily animating a Bestow creature to make checks.
- Note: this may introduce a bit of overhead and definitely adds a bit of extra complexity into an already bloated Card.java. A better solution is welcome (feel free to revert this if a better solution is implemented).
2016-12-10 18:47:29 +00:00
Agetian
1dee7d895b - Reverting r32578 (causes Soulflayer + Chromanticore and possibly other similar combinations operating on cards with Bestow not to work). 2016-12-10 18:45:30 +00:00
Hanmac
e6b8c230d0 CharmEffect: fixed it for effects on permanent cards 2016-12-10 17:35:15 +00:00
Hanmac
83953f3f0b EffectEffect: add more AbilityUtils into it, with that it can access SVars from SpellAbility
CardFactoryUtil: add Revealed Effect for Miracle (it shows the card and is more rules conform)
2016-12-10 15:36:37 +00:00
Hanmac
f43c806d4b StaticAbilities: updated MayLookAt to use it with getDefinedPlayers
AbilityUtils: make getDefinedPlayers work without SpellAbility, for the most generic
2016-12-10 13:48:27 +00:00
Agetian
d923fc9b14 - Attempting to fix DelayTriggerRemembered (fixes Dash mechanic, Necropotence). 2016-12-10 06:26:22 +00:00
Hanmac
d800e06fa5 CardFactory: remove everything about unparsedAbilities its not needed anymore 2016-12-09 22:11:21 +00:00
Hanmac
eea8ef284d CardFactoryUtil: add Changeling as Keyword 2016-12-09 05:59:38 +00:00
Hanmac
71a22ff7ca AbilityFactory: prevent StackError on cards like Crooked Scales 2016-12-08 06:16:57 +00:00
Hanmac
4cf2d22c76 Card: add Reminder for Miracle 2016-12-07 06:13:27 +00:00
Hanmac
8968ea3382 add new TriggerRevealed to use it for Miracle 2016-12-06 06:32:02 +00:00
Hanmac
f0bc477319 CardFactory: when a SpellAbility is copied, use Orignal Description and StackDescription in case last is autogenerated 2016-12-06 06:29:56 +00:00
Agetian
a954856cb2 - Fixed a NPE in SpellAbilityEffect (e.g. when generating Varchild's War-Riders trigger description). 2016-12-04 15:29:15 +00:00
Hanmac
7636090b83 TokenEffect: into Battlefield attacking only works when you are the Attacking Player 2016-12-04 07:55:13 +00:00
Hanmac
3b637b093e PumpEffect: add AtEOT for (some) DelayedTrigger 2016-12-03 19:46:38 +00:00
Hanmac
02221b9fe2 AbilityUtils: add more fixes for stuff like Skill Borrower 2016-12-03 19:33:12 +00:00
Hanmac
42f359a222 Untap & StaticAbility: add better coding for Blinding Beam 2016-12-03 17:34:17 +00:00
Hanmac
0453409490 SpellAbility: now does store the SubAbilities which are used by some Effects,
that makes it working to copy them to other cards.
rewrite Entwine to use CardFactoryUtil
2016-12-03 16:59:41 +00:00
Hanmac
a23d06b8c4 SpellAbilityRestriction: fixed Affected and revert Melek 2016-12-02 07:38:36 +00:00
Hanmac
3914f2137d Card: hide suspend keyword, it is done though ability 2016-11-28 19:04:22 +00:00
Hanmac
708b65fe13 AttachEffect: use getFirstAttachSpell instead of getAttachSpellAbility 2016-11-27 19:38:11 +00:00
Hanmac
dad9a04f60 SpellAbility: add findSubAbilityByType Helper function 2016-11-27 19:31:16 +00:00
Hanmac
eb2bd76ac2 WrappedAbility: use getTriggeringObjects, can't use RunParams because they might be overwritten. 2016-11-27 16:47:46 +00:00