From f2c0b0423fbf5ea7a8e18a9d30312b9cbef152a5 Mon Sep 17 00:00:00 2001 From: CCTV-1 Date: Sun, 16 Feb 2020 13:44:22 +0800 Subject: [PATCH] fix miss assigning replaceAll return value. --- forge-core/src/main/java/forge/deck/DeckBase.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/forge-core/src/main/java/forge/deck/DeckBase.java b/forge-core/src/main/java/forge/deck/DeckBase.java index 18402619549..a37d6769369 100644 --- a/forge-core/src/main/java/forge/deck/DeckBase.java +++ b/forge-core/src/main/java/forge/deck/DeckBase.java @@ -144,12 +144,12 @@ public abstract class DeckBase implements Serializable, Comparable, In */ public final String getBestFileName() { //string operator hard to guarantee filename legal,only replace some not allowed as file names characters - name.replaceAll("[\\/:*?\"<>|]",""); - if (name == "") { + final String result = name.replaceAll("[\\/:*?\"<>|]",""); + if (result == "") { //"getBestFileName" sha1 value return "bc2b4ac6bf8dd84112c79e4c733b0b5bd8f057b3"; } - return name; + return result; } public abstract boolean isEmpty();