From e28f19b83d0ca50975f358c78f2ef927e557eb47 Mon Sep 17 00:00:00 2001 From: Sol Date: Fri, 3 May 2013 21:23:08 +0000 Subject: [PATCH] - Revert all synchronized changes in MagicStack. This caused more issues than it solved. --- src/main/java/forge/game/zone/MagicStack.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/forge/game/zone/MagicStack.java b/src/main/java/forge/game/zone/MagicStack.java index 6427d96a343..26ee876e34c 100644 --- a/src/main/java/forge/game/zone/MagicStack.java +++ b/src/main/java/forge/game/zone/MagicStack.java @@ -162,7 +162,7 @@ public class MagicStack extends MyObservable { * @param ability * a {@link forge.card.spellability.SpellAbility} object. */ - public final synchronized void addAndUnfreeze(final SpellAbility ability) { + public final void addAndUnfreeze(final SpellAbility ability) { ability.getRestrictions().abilityActivated(); if ((ability.getRestrictions().getActivationNumberSacrifice() != -1) && (ability.getRestrictions().getNumberTurnActivations() >= ability.getRestrictions() @@ -224,7 +224,7 @@ public class MagicStack extends MyObservable { * @param sa * a SpellAbility. */ - public final synchronized void removeFromFrozenStack(SpellAbility sa) { + public final void removeFromFrozenStack(SpellAbility sa) { SpellAbilityStackInstance si = this.getInstanceFromSpellAbility(sa); this.getFrozenStack().remove(si); if (this.getFrozenStack().isEmpty()) { @@ -268,7 +268,7 @@ public class MagicStack extends MyObservable { * @param useX * a boolean. */ - public final synchronized void add(final SpellAbility sp, final boolean useX) { + public final void add(final SpellAbility sp, final boolean useX) { if (!useX) { this.add(sp); } else { @@ -297,7 +297,7 @@ public class MagicStack extends MyObservable { * @param sp * a {@link forge.card.spellability.SpellAbility} object. */ - public final synchronized void add(final SpellAbility sp) { + public final void add(final SpellAbility sp) { FThreads.assertExecutedByEdt(false); final ArrayList chosenTargets = sp.getAllTargetChoices(); @@ -582,7 +582,7 @@ public class MagicStack extends MyObservable { * resolveStack. *

*/ - public final synchronized void resolveStack() { + public final void resolveStack() { // Resolving the Stack // TODO: change to use forge.view.FView? @@ -669,7 +669,7 @@ public class MagicStack extends MyObservable { * a boolean. * @since 1.0.15 */ - public final synchronized void removeCardFromStack(final SpellAbility sa, final boolean fizzle) { + public final void removeCardFromStack(final SpellAbility sa, final boolean fizzle) { Card source = sa.getSourceCard(); // do nothing @@ -843,7 +843,7 @@ public class MagicStack extends MyObservable { * * @return a {@link forge.card.spellability.SpellAbility} object. */ - public final synchronized SpellAbility pop() { + public final SpellAbility pop() { final SpellAbilityStackInstance si = this.getStack().pop(); final SpellAbility sp = si.getSpellAbility(); return sp; @@ -915,7 +915,7 @@ public class MagicStack extends MyObservable { * @param sa * a {@link forge.card.spellability.SpellAbility} object. */ - public final synchronized void remove(final SpellAbility sa) { + public final void remove(final SpellAbility sa) { final SpellAbilityStackInstance si = this.getInstanceFromSpellAbility(sa); if (si == null) { @@ -934,7 +934,7 @@ public class MagicStack extends MyObservable { * a {@link forge.card.spellability.SpellAbilityStackInstance} * object. */ - public final synchronized void remove(final SpellAbilityStackInstance si) { + public final void remove(final SpellAbilityStackInstance si) { this.getStack().remove(si); this.getFrozenStack().remove(si); this.updateObservers();