From 71e132a9e06c61d7e9e7cb7295e9b01cdc2ba423 Mon Sep 17 00:00:00 2001
From: Anthony Calosa <anthonycalosa@gmail.com>
Date: Mon, 18 Aug 2025 05:52:24 +0800
Subject: [PATCH 1/2] fix RandomDeckGenerator AI Deck Selection by preference

---
 forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java b/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java
index 9be684b929c..611899dfc76 100644
--- a/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java
+++ b/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java
@@ -5,6 +5,7 @@ import forge.game.GameFormat;
 import forge.game.GameType;
 import forge.game.IHasGameType;
 import forge.gamemodes.quest.QuestController;
+import forge.localinstance.properties.ForgePreferences;
 import forge.model.FModel;
 import forge.util.Aggregates;
 import forge.util.IterableUtil;
@@ -174,7 +175,7 @@ public class RandomDeckGenerator extends DeckProxy implements Comparable<RandomD
             return getGeneratedDeck(); //fall back to generated deck if no decks in filtered list
         }
         Iterable<DeckProxy> AIDecks = IterableUtil.filter(decks, deckProxy -> deckProxy.getAI().inMainDeck == 0);
-        if (isAi && Iterables.size(AIDecks) > 10) return Aggregates.random(AIDecks).getDeck();
+        if (FModel.getPreferences().getPrefBoolean(ForgePreferences.FPref.UI_AUTO_AIDECK_SELECTION) && isAi && Iterables.size(AIDecks) > 10) return Aggregates.random(AIDecks).getDeck();
         return Aggregates.random(decks).getDeck();
     }
 

From e94985576ce075b0fc016fe8bfe64b5e248271a6 Mon Sep 17 00:00:00 2001
From: Anthony Calosa <anthonycalosa@gmail.com>
Date: Mon, 18 Aug 2025 05:56:54 +0800
Subject: [PATCH 2/2] refactor check

---
 .../src/main/java/forge/deck/RandomDeckGenerator.java      | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java b/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java
index 611899dfc76..b85bbef1194 100644
--- a/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java
+++ b/forge-gui/src/main/java/forge/deck/RandomDeckGenerator.java
@@ -174,8 +174,11 @@ public class RandomDeckGenerator extends DeckProxy implements Comparable<RandomD
         if (Iterables.isEmpty(decks)) {
             return getGeneratedDeck(); //fall back to generated deck if no decks in filtered list
         }
-        Iterable<DeckProxy> AIDecks = IterableUtil.filter(decks, deckProxy -> deckProxy.getAI().inMainDeck == 0);
-        if (FModel.getPreferences().getPrefBoolean(ForgePreferences.FPref.UI_AUTO_AIDECK_SELECTION) && isAi && Iterables.size(AIDecks) > 10) return Aggregates.random(AIDecks).getDeck();
+        if (isAi && FModel.getPreferences().getPrefBoolean(ForgePreferences.FPref.UI_AUTO_AIDECK_SELECTION)) {
+            Iterable<DeckProxy> AIDecks = IterableUtil.filter(decks, deckProxy -> deckProxy.getAI().inMainDeck == 0);
+            if (Iterables.size(AIDecks) > 10)
+                return Aggregates.random(AIDecks).getDeck();
+        }
         return Aggregates.random(decks).getDeck();
     }