renamed createIngamePlayer method to minimize confusion

forge-gui/src/main/java/forge/game/Game.java

@@ -98,7 +98,7 @@ public class Game {
         roIngamePlayers = Collections.unmodifiableList(ingamePlayers);
 
         for (RegisteredPlayer psc : players0) {
-            Player pl = psc.getPlayer().getPlayer(this);
+            Player pl = psc.getPlayer().createIngamePlayer(this);
             players.add(pl);
             ingamePlayers.add(pl);
 

forge-gui/src/main/java/forge/game/player/LobbyPlayer.java

@@ -84,7 +84,7 @@ public abstract class LobbyPlayer implements IHasIcon {
         this.avatarIndex = avatarIndex;
     }
 
-    public abstract Player getPlayer(Game gameState); // factory method to create player
+    public abstract Player createIngamePlayer(Game gameState); // factory method to create player
     public abstract PlayerController createControllerFor(Player p);
 
     public abstract void hear(LobbyPlayer player, String message);

forge-gui/src/main/java/forge/game/player/LobbyPlayerAi.java

@@ -31,7 +31,7 @@ public class LobbyPlayerAi extends LobbyPlayer {
     }
     
     @Override
-    public Player getPlayer(Game game) {
+    public Player createIngamePlayer(Game game) {
         Player ai = new Player(getName(), game);
         ai.setFirstController(createControllerFor(ai));
 

forge-gui/src/main/java/forge/game/player/LobbyPlayerRemote.java

@@ -22,7 +22,7 @@ public class LobbyPlayerRemote extends LobbyPlayer {
      * @see forge.game.player.LobbyPlayer#getPlayer(forge.game.GameState)
      */
     @Override
-    public Player getPlayer(Game gameState) {
+    public Player createIngamePlayer(Game gameState) {
         // Cannot create remote players yet 
         throw new UnsupportedOperationException("method is not implemented");
     }

forge-gui/src/main/java/forge/gui/player/LobbyPlayerHuman.java

@@ -26,7 +26,7 @@ public class LobbyPlayerHuman extends LobbyPlayer {
     }
     
     @Override
-    public Player getPlayer(Game game) {
+    public Player createIngamePlayer(Game game) {
         Player player = new Player(GuiDisplayUtil.personalizeHuman(getName()), game);
         player.setFirstController(new PlayerControllerHuman(game, player, this));
         

forge-gui/src/test/java/forge/gamesimulationtests/util/LobbyPlayerForTests.java

@@ -33,7 +33,7 @@ public class LobbyPlayerForTests extends LobbyPlayer {
 	}
 
 	@Override
-	public Player getPlayer( Game gameState ) {
+	public Player createIngamePlayer( Game gameState ) {
 		Player dummyPlayer = new Player( getName(), gameState );
 		dummyPlayer.setFirstController( createControllerFor( dummyPlayer ) );
 		return dummyPlayer;