external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-16 10:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Negation cleanup: IsNotCommander (#7064)

Browse Source
This commit is contained in:
Renato Filipe Vidal Santos
2025-02-22 20:38:15 +00:00
committed by GitHub
parent a05ecbc810
commit c358f4e71f
9 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
forge-game/src/main/java/forge/game/card/CardProperty.java
View File

@@ -2023,10 +2023,6 @@ public class CardProperty {
if (!card.isCommander()) {
return false;
}
} else if (property.equals("IsNotCommander")) {
if (card.isCommander()) {
return false;
}
} else if (property.startsWith("NotedFor")) {
final String key = property.substring("NotedFor".length());
for (String note : sourceController.getNotesForName(key)) {

2
forge-gui/res/cardsfolder/b/become_the_pilot.txt
View File

@@ -2,7 +2,7 @@ Name:Become the Pilot
ManaCost:3 U U
Types:Enchantment Aura
K:Enchant noncommander creature
A:SP$ Attach | ValidTgts$ Creature.IsNotCommander | TgtPrompt$ Select target noncommander creature | AILogic$ GainControl
A:SP$ Attach | ValidTgts$ Creature.!IsCommander | TgtPrompt$ Select target noncommander creature | AILogic$ GainControl
S:Mode$ Continuous | Affected$ Creature.EnchantedBy | GainControl$ You | Description$ You control enchanted creature.
S:Mode$ Continuous | Affected$ Creature.EnchantedBy | AddPower$ 2 | AddToughness$ 2 | Description$ Enchanted creature gets +2/+2 and can't be blocked unless it's attacking its owner or a permanent its owner controls.
S:Mode$ CantBlockBy | ValidAttacker$ Creature.EnchantedBy | ValidBlocker$ Creature.!ControlledBy EnchantedOwner

2
forge-gui/res/cardsfolder/l/lozhan_dragons_legacy.txt
View File

@@ -4,7 +4,7 @@ Types:Legendary Creature Dragon Shaman
PT:4/2
K:Flying
T:Mode$ SpellCast | ValidCard$ Card.Adventure,Dragon | ValidActivatingPlayer$ You | Execute$ TrigDamage | TriggerZones$ Battlefield | TriggerDescription$ Whenever you cast an Adventure spell or Dragon spell, CARDNAME deals damage equal to that spell's mana value to any target that isn't a commander.
SVar:TrigDamage:DB$ DealDamage | ValidTgts$ Any.IsNotCommander | TgtPrompt$ Select any target that isn't a commander | NumDmg$ X
SVar:TrigDamage:DB$ DealDamage | ValidTgts$ Any.!IsCommander | TgtPrompt$ Select any target that isn't a commander | NumDmg$ X
SVar:X:TriggeredStackInstance$CardManaCostLKI
SVar:BuffedBy:Creature.AdventureCard,Dragon
DeckHints:Type$Adventure|Dragon

2
forge-gui/res/cardsfolder/s/shield_broker.txt
View File

@@ -3,7 +3,7 @@ ManaCost:3 U U
Types:Creature Octopus Advisor
PT:3/4
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigPutCounter | TriggerDescription$ When CARDNAME enters, put a shield counter on target noncommander creature you don't control. You gain control of that creature for as long as it has a shield counter on it. (If it would be dealt damage or destroyed, remove a shield counter from it instead.)
SVar:TrigPutCounter:DB$ PutCounter | ValidTgts$ Creature.IsNotCommander+YouDontCtrl | TgtPrompt$ Select target noncommander creature you don't control | CounterType$ SHIELD | SubAbility$ DBEffect
SVar:TrigPutCounter:DB$ PutCounter | ValidTgts$ Creature.!IsCommander+YouDontCtrl | TgtPrompt$ Select target noncommander creature you don't control | CounterType$ SHIELD | SubAbility$ DBEffect
SVar:DBEffect:DB$ Effect | RememberObjects$ Targeted | StaticAbilities$ GainControl | ForgetOnMoved$ Battlefield | ForgetCounter$ SHIELD | Duration$ Permanent
SVar:GainControl:Mode$ Continuous | Affected$ Card.IsRemembered | GainControl$ You | Description$ You gain control of that creature for as long as it has a shield counter on it.
Oracle:When Shield Broker enters, put a shield counter on target noncommander creature you don't control. You gain control of that creature for as long as it has a shield counter on it. (If it would be dealt damage or destroyed, remove a shield counter from it instead.)

2
forge-gui/res/cardsfolder/s/slash_the_ranks.txt
View File

@@ -1,5 +1,5 @@
Name:Slash the Ranks
ManaCost:3 W W
Types:Sorcery
A:SP$ DestroyAll | ValidCards$ Creature.IsNotCommander,Planeswalker.IsNotCommander | SpellDescription$ Destroy all creatures and planeswalkers except for commanders.
A:SP$ DestroyAll | ValidCards$ Creature.!IsCommander,Planeswalker.!IsCommander | SpellDescription$ Destroy all creatures and planeswalkers except for commanders.
Oracle:Destroy all creatures and planeswalkers except for commanders.

2
forge-gui/res/cardsfolder/s/subjugate_the_hobbits.txt
View File

@@ -1,5 +1,5 @@
Name:Subjugate the Hobbits
ManaCost:5 U U
Types:Sorcery
A:SP$ GainControl | AllValid$ Creature.IsNotCommander+cmcLE3 | NewController$ You | SpellDescription$ Gain control of each noncommander creature with mana value 3 or less.
A:SP$ GainControl | AllValid$ Creature.!IsCommander+cmcLE3 | NewController$ You | SpellDescription$ Gain control of each noncommander creature with mana value 3 or less.
Oracle:Gain control of each noncommander creature with mana value 3 or less.

2
forge-gui/res/cardsfolder/t/the_peregrine_dynamo.txt
View File

@@ -3,7 +3,7 @@ ManaCost:3
Types:Legendary Artifact Creature Construct
PT:1/5
K:Haste
A:AB$ CopySpellAbility | Cost$ 1 T | TargetType$ Activated.YouCtrl,Triggered.YouCtrl | ValidTgts$ Card.Legendary+Other+IsNotCommander+YouCtrl | TgtPrompt$ Choose target triggered ability you control | MayChooseTarget$ True | SpellDescription$ Copy target activated or triggered ability you control from another legendary source that's not a commander. You may choose new targets for the copy.
A:AB$ CopySpellAbility | Cost$ 1 T | TargetType$ Activated.YouCtrl,Triggered.YouCtrl | ValidTgts$ Card.Legendary+Other+!IsCommander+YouCtrl | TgtPrompt$ Choose target triggered ability you control | MayChooseTarget$ True | SpellDescription$ Copy target activated or triggered ability you control from another legendary source that's not a commander. You may choose new targets for the copy.
SVar:BuffedBy:Legendary
DeckNeeds:Type$Legendary
Oracle:Haste\n{1}, {T}: Copy target activated or triggered ability you control from another legendary source that's not a commander. You may choose new targets for the copy. (Mana abilities can't be targeted.)

2
forge-gui/res/cardsfolder/y/you_will_know_true_suffering.txt
View File

@@ -2,6 +2,6 @@ Name:You Will Know True Suffering
ManaCost:no cost
Types:Scheme
T:Mode$ SetInMotion | ValidCard$ Card.Self | Execute$ TrigDamageAll | TriggerZones$ Command | TriggerDescription$ When you set this scheme in motion, it deals damage equal to your commander's mana value to each noncommander creature your opponents control.
SVar:TrigDamageAll:DB$ DamageAll | ValidCards$ Creature.IsNotCommander+OppCtrl | ValidDescription$ each noncommander creature your opponents control. | NumDmg$ X
SVar:TrigDamageAll:DB$ DamageAll | ValidCards$ Creature.!IsCommander+OppCtrl | ValidDescription$ each noncommander creature your opponents control. | NumDmg$ X
SVar:X:Count$ValidAll Card.IsCommander+YouOwn$SumCMC
Oracle:When you set this scheme in motion, it deals damage equal to your commander's mana value to each noncommander creature your opponents control.

2
forge-gui/src/main/java/forge/gui/card/CardScriptParser.java
View File

@@ -486,7 +486,7 @@ public final class CardScriptParser {
"hasActivatedAbility", "hasManaAbility",
"hasNonManaActivatedAbility", "NoAbilities", "HasCounters",
"wasNotCast", "ChosenType", "IsNotChosenType", "IsCommander",
"IsNotCommander", "IsRenowned");
"IsRenowned");
private static final Set<String> VALID_EXCLUSIVE_STARTSWITH = ImmutableSortedSet
.of("named", "notnamed", "OwnedBy", "ControlledBy",
"ControllerControls", "AttachedTo", "EnchantedBy",