Advanced Search for Artists (#1419)

* Advanced Search for Artists

* Clean up

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.59>

forge-game/src/main/java/forge/game/cost/CostAdjustment.java

@@ -433,10 +433,6 @@ public class CostAdjustment {
         if (!st.matchesValidParam("Activator", activator)) {
             return false;
         }
-        if (st.hasParam("NonActivatorTurn") && (activator == null
-                || game.getPhaseHandler().isPlayerTurn(activator))) {
-            return false;
-        }
 
         if (st.hasParam("Type")) {
             final String type = st.getParam("Type");

forge-game/src/main/java/forge/game/player/PlayerProperty.java

@@ -49,11 +49,11 @@ public class PlayerProperty {
                 return false;
             }
         } else if (property.equals("Active")) {
-            if (!player.equals(game.getPhaseHandler().getPlayerTurn())) {
+            if (!game.getPhaseHandler().isPlayerTurn(player)) {
                 return false;
             }
         } else if (property.equals("NonActive")) {
-            if (player.equals(game.getPhaseHandler().getPlayerTurn())) {
+            if (game.getPhaseHandler().isPlayerTurn(player)) {
                 return false;
             }
         } else if (property.equals("OpponentToActive")) {

forge-gui/res/cardsfolder/d/defense_grid.txt

@@ -1,6 +1,6 @@
 Name:Defense Grid
 ManaCost:2
 Types:Artifact
-S:Mode$ RaiseCost | Activator$ Player | Type$ Spell | Amount$ 3 | NonActivatorTurn$ True | Description$ Each spell costs {3} more to cast except during its controller's turn.
+S:Mode$ RaiseCost | Activator$ Player.NonActive | Type$ Spell | Amount$ 3 | Description$ Each spell costs {3} more to cast except during its controller's turn.
 AI:RemoveDeck:Random
 Oracle:Each spell costs {3} more to cast except during its controller's turn.

forge-gui/res/cardsfolder/k/kindred_boon.txt

@@ -3,6 +3,6 @@ ManaCost:2 W W
 Types:Enchantment
 K:ETBReplacement:Other:ChooseCT
 SVar:ChooseCT:DB$ ChooseType | Type$ Creature | AILogic$ MostProminentInComputerDeck | SpellDescription$ As CARDNAME enters the battlefield, choose a creature type.
-S:Mode$ Continuous | Affected$ Creature.ChosenType+YouCtrl+counters_GE1_DIVINITY | AddKeyword$ Indestructible | Description$ Each creature you control with a divinity counter on it has indestructible.
+S:Mode$ Continuous | Affected$ Creature.YouCtrl+counters_GE1_DIVINITY | AddKeyword$ Indestructible | Description$ Each creature you control with a divinity counter on it has indestructible.
 A:AB$ PutCounter | Cost$ 1 W | ValidTgts$ Creature.ChosenType+YouCtrl | TgtPrompt$ Select target creature you control of the chosen type | CounterType$ DIVINITY | CounterNum$ 1 | SpellDescription$ Put a divinity counter on target creature you control of the chosen type.
 Oracle:As Kindred Boon enters the battlefield, choose a creature type.\n{1}{W}: Put a divinity counter on target creature you control of the chosen type.\nEach creature you control with a divinity counter on it has indestructible.

forge-gui/res/cardsfolder/upcoming/dihada_binder_of_wills.txt

@@ -1,5 +1,5 @@
 Name:Dihada, Binder of Wills
-ManaCost:3 R W B
+ManaCost:1 R W B
 Types:Legendary Planeswalker Dihada
 Loyalty:5
 Text:CARDNAME can be your commander.

forge-gui/res/languages/de-DE.properties

@@ -2241,6 +2241,7 @@ lblSubtype=Untertyp
 lblGenericCost=Generische Kosten
 lblManaCost=Mana-Kosten
 lblFirstPrinting=Erstdruck
+lblArtist=Artist
 lblAverageCMC=Durchschnittlicher Manabetrag
 lblMainDeck=Hauptdeck
 lblMainDeckSize=Größe Hauptdeck

forge-gui/res/languages/en-US.properties

@@ -2239,6 +2239,7 @@ lblSubtype=Subtype
 lblGenericCost=Generic Cost
 lblManaCost=Mana Cost
 lblFirstPrinting=First Printing
+lblArtist=Artist
 lblAverageCMC=Average Mana Value
 lblMainDeck=Main Deck
 lblMainDeckSize=Main Deck Size

forge-gui/res/languages/es-ES.properties

@@ -2239,6 +2239,7 @@ lblSubtype=Subtipo
 lblGenericCost=Coste Genérico
 lblManaCost=Coste de maná
 lblFirstPrinting=Primera impresión
+lblArtist=Artist
 lblAverageCMC=Media de CMC
 lblMainDeck=Mazo principal
 lblMainDeckSize=Tamaño del mazo principal

forge-gui/res/languages/it-IT.properties

@@ -2238,6 +2238,7 @@ lblSubtype=Sottotipo
 lblGenericCost=Costo generico
 lblManaCost=Costo di mana
 lblFirstPrinting=Prima stampa
+lblArtist=Artist
 lblAverageCMC=CMC medio
 lblMainDeck=Mazzo
 lblMainDeckSize=Dimensione del mazzo

forge-gui/res/languages/ja-JP.properties

@@ -2238,6 +2238,7 @@ lblSubtype=サブタイプ
 lblGenericCost=不特定コスト
 lblManaCost=マナコスト
 lblFirstPrinting=初版
+lblArtist=Artist
 lblAverageCMC=マナ総量平均
 lblMainDeck=メインデッキ
 lblMainDeckSize=メインデッキ枚数

forge-gui/res/languages/pt-BR.properties

@@ -2308,6 +2308,7 @@ lblSubtype=Subtipo
 lblGenericCost=Custo Genérico
 lblManaCost=Custo de Mana
 lblFirstPrinting=Primeira Impressão
+lblArtist=Artist
 lblAverageCMC=Valor Médio de Mana
 lblMainDeck=Deck Principal
 lblMainDeckSize=Tamanho do Deck Principal

forge-gui/res/languages/zh-CN.properties

@@ -2240,6 +2240,7 @@ lblSubtype=副类别
 lblGenericCost=无色费用
 lblManaCost=法术力费用
 lblFirstPrinting=第一次印刷
+lblArtist=Artist
 lblAverageCMC=平均法术力值
 lblMainDeck=主牌
 lblMainDeckSize=主牌大小

forge-gui/src/main/java/forge/itemmanager/AdvancedSearch.java

@@ -299,6 +299,12 @@ public class AdvancedSearch {
                 return cards.get(0) == input;
             }
         }),
+        CARD_ARTIST("lblArtist", PaperCard.class, FilterOperator.STRING_OPS, new StringEvaluator<PaperCard>() {
+            @Override
+            protected String getItemValue(PaperCard input) {
+                return input.getArtist();
+            }
+        }),
         INVITEM_NAME("lblName", InventoryItem.class, FilterOperator.STRING_OPS, new StringEvaluator<InventoryItem>() {
             @Override
             protected String getItemValue(InventoryItem input) {