external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-20 04:38:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a TODO to game sim code.

Browse Source
This commit is contained in:
Myrd
2016-01-01 19:06:16 +00:00
parent 04834372e1
commit b43c481b2b
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
forge-ai/src/main/java/forge/ai/simulation/GameCopier.java
View File

@@ -191,6 +191,11 @@ public class GameCopier {
newCard = CardFactory.makeToken(CardFactory.TokenInfo.fromString(tokenStr), owner).get(0); newCard = CardFactory.makeToken(CardFactory.TokenInfo.fromString(tokenStr), owner).get(0);
} else { } else {
newCard = Card.fromPaperCard(c.getPaperCard(), owner); newCard = Card.fromPaperCard(c.getPaperCard(), owner);
// TODO: The above is very expensive and accounts for the vast majority of GameCopier execution time.
// The issue is that it requires parsing the original card from scratch from the paper card. We should
// improve the copier to accurately copy the card from its actual state, so that the paper card shouldn't
// be needed. Then, we can construct the card via:
// newCard = new Card(newGame.nextCardId(), newGame);
} }
cardMap.put(c, newCard); cardMap.put(c, newCard);