diff --git a/forge-core/src/main/java/forge/card/CardDb.java b/forge-core/src/main/java/forge/card/CardDb.java index 17ada0b5f5b..a3e05f60feb 100644 --- a/forge-core/src/main/java/forge/card/CardDb.java +++ b/forge-core/src/main/java/forge/card/CardDb.java @@ -218,7 +218,7 @@ public final class CardDb implements ICardDatabase, IDeckGenPool { CardRequest request = fromPreferredArtEntry(preferredArt, isFoil); if (request != null) // otherwise, simply discard it and go on. return request; - System.err.println(String.format("[LOG]: Faulty Entry in Preferred Art for Card %s - Please check!", cardName)); + System.err.printf("[LOG]: Faulty Entry in Preferred Art for Card %s - Please check!%n", cardName); } } // finally, check whether any between artIndex and CollectorNumber has been set diff --git a/forge-gui-desktop/src/main/java/forge/control/FControl.java b/forge-gui-desktop/src/main/java/forge/control/FControl.java index e82a3fc7629..6ebdbb2783b 100644 --- a/forge-gui-desktop/src/main/java/forge/control/FControl.java +++ b/forge-gui-desktop/src/main/java/forge/control/FControl.java @@ -234,7 +234,7 @@ public enum FControl implements KeyEventDispatcher { FModel.getQuest().load(QuestDataIO.loadData(data)); } catch(IOException ex) { ex.printStackTrace(); - System.out.println(String.format("Error loading quest data (%s).. skipping for now..", questname)); + System.err.printf("Error loading quest data (%s).. skipping for now..%n", questname); } } diff --git a/forge-gui-desktop/src/main/java/forge/screens/home/quest/CSubmenuQuestLoadData.java b/forge-gui-desktop/src/main/java/forge/screens/home/quest/CSubmenuQuestLoadData.java index 955b4c46d51..102d41bc70e 100644 --- a/forge-gui-desktop/src/main/java/forge/screens/home/quest/CSubmenuQuestLoadData.java +++ b/forge-gui-desktop/src/main/java/forge/screens/home/quest/CSubmenuQuestLoadData.java @@ -60,11 +60,11 @@ public enum CSubmenuQuestLoadData implements ICDoc { arrQuests.clear(); for (final File f : arrFiles) { try { - System.out.println(String.format("About to load quest (%s)... ", f.getName())); + System.out.printf("About to load quest (%s)... %n", f.getName()); arrQuests.put(f.getName(), QuestDataIO.loadData(f)); } catch(IOException ex) { ex.printStackTrace(); - System.out.println(String.format("Error loading quest data (%s).. skipping for now..", f.getName())); + System.err.printf("Error loading quest data (%s).. skipping for now..%n", f.getName()); restorableQuests.add(f.getName()); } } diff --git a/forge-gui-mobile/src/forge/Graphics.java b/forge-gui-mobile/src/forge/Graphics.java index 8da9f8d73d3..36b1089954d 100644 --- a/forge-gui-mobile/src/forge/Graphics.java +++ b/forge-gui-mobile/src/forge/Graphics.java @@ -1371,7 +1371,7 @@ public class Graphics { Dtransforms.removeFirst(); transformCount--; if (transformCount != Dtransforms.size()) { - System.err.println(String.format("Stack count: %d, transformCount: %d", Dtransforms.size(), transformCount)); + System.err.printf("Stack count: %d, transformCount: %d%n", Dtransforms.size(), transformCount); transformCount = 0; Dtransforms.clear(); } diff --git a/forge-gui-mobile/src/forge/screens/quest/LoadQuestScreen.java b/forge-gui-mobile/src/forge/screens/quest/LoadQuestScreen.java index c763a731236..46b7478a2ae 100644 --- a/forge-gui-mobile/src/forge/screens/quest/LoadQuestScreen.java +++ b/forge-gui-mobile/src/forge/screens/quest/LoadQuestScreen.java @@ -85,7 +85,7 @@ public class LoadQuestScreen extends LaunchScreen { try { arrQuests.put(f.getName(), QuestDataIO.loadData(f)); } catch (IOException e) { - System.err.println(String.format("Failed to load quest '%s'", f.getName())); + System.err.printf("Failed to load quest '%s'%n", f.getName()); // Failed to load last quest, don't continue with quest loading stuff return; } diff --git a/forge-gui-mobile/src/forge/screens/quest/QuestMenu.java b/forge-gui-mobile/src/forge/screens/quest/QuestMenu.java index 8d5a79fe466..f080d2608d3 100644 --- a/forge-gui-mobile/src/forge/screens/quest/QuestMenu.java +++ b/forge-gui-mobile/src/forge/screens/quest/QuestMenu.java @@ -127,7 +127,7 @@ public class QuestMenu extends FPopupMenu implements IVQuestStats { try { FModel.getQuest().load(QuestDataIO.loadData(data)); } catch (IOException e) { - System.err.println(String.format("Failed to load quest '%s'", questname)); + System.err.printf("Failed to load quest '%s'%n", questname); // Failed to load last quest, don't continue with quest loading stuff return; } diff --git a/forge-gui/src/main/java/forge/gamemodes/match/input/InputSelectEntitiesFromList.java b/forge-gui/src/main/java/forge/gamemodes/match/input/InputSelectEntitiesFromList.java index 7cfc7461889..340c43ce2b3 100644 --- a/forge-gui/src/main/java/forge/gamemodes/match/input/InputSelectEntitiesFromList.java +++ b/forge-gui/src/main/java/forge/gamemodes/match/input/InputSelectEntitiesFromList.java @@ -44,7 +44,7 @@ public class InputSelectEntitiesFromList extends InputSele super(controller, Math.min(min, validChoices0.size()), Math.min(max, validChoices0.size()), sa0, tallyType0, tally0); validChoices = validChoices0; if (min > validChoices.size()) { // pfps does this really do anything useful?? - System.out.println(String.format("Trying to choose at least %d things from a list with only %d things!", min, validChoices.size())); + System.out.printf("Trying to choose at least %d things from a list with only %d things!%n", min, validChoices.size()); } ArrayList vCards = new ArrayList<>(); for (T c : validChoices0) { diff --git a/forge-gui/src/main/java/forge/gamemodes/net/CompatibleObjectDecoder.java b/forge-gui/src/main/java/forge/gamemodes/net/CompatibleObjectDecoder.java index 2af0a82aa28..3b70145ddc8 100644 --- a/forge-gui/src/main/java/forge/gamemodes/net/CompatibleObjectDecoder.java +++ b/forge-gui/src/main/java/forge/gamemodes/net/CompatibleObjectDecoder.java @@ -37,7 +37,7 @@ public class CompatibleObjectDecoder extends LengthFieldBasedFrameDecoder { try { var5 = ois.readObject(); } catch (StreamCorruptedException e) { - System.err.println(String.format("Version Mismatch: %s", e.getMessage())); + System.err.printf("Version Mismatch: %s%n", e.getMessage()); } finally { ois.close(); } diff --git a/forge-gui/src/main/java/forge/gamemodes/net/GameProtocolHandler.java b/forge-gui/src/main/java/forge/gamemodes/net/GameProtocolHandler.java index 8673cc5c5c6..5fd23a11af5 100644 --- a/forge-gui/src/main/java/forge/gamemodes/net/GameProtocolHandler.java +++ b/forge-gui/src/main/java/forge/gamemodes/net/GameProtocolHandler.java @@ -41,7 +41,7 @@ public abstract class GameProtocolHandler extends ChannelInboundHandlerAdapte if (method == null) { //throw new IllegalStateException(String.format("Method %s not found", protocolMethod.name())); catchedError[0] += String.format("IllegalStateException: Method %s not found (GameProtocolHandler.java Line 43)\n", protocolMethod.name()); - System.err.println(String.format("Method %s not found", protocolMethod.name())); + System.err.printf("Method %s not found%n", protocolMethod.name()); } final Object[] args = event.getObjects(); @@ -58,7 +58,7 @@ public abstract class GameProtocolHandler extends ChannelInboundHandlerAdapte try { method.invoke(toInvoke, args); } catch (final IllegalAccessException | IllegalArgumentException e) { - System.err.println(String.format("Unknown protocol method %s with %d args", methodName, args == null ? 0 : args.length)); + System.err.printf("Unknown protocol method %s with %d args%n", methodName, args == null ? 0 : args.length); } catch (final InvocationTargetException e) { //throw new RuntimeException(e.getTargetException()); catchedError[0] += (String.format("RuntimeException: %s (GameProtocolHandler.java Line 65)\n", e.getTargetException().toString())); @@ -72,10 +72,10 @@ public abstract class GameProtocolHandler extends ChannelInboundHandlerAdapte protocolMethod.checkReturnValue(theReply); reply = (Serializable) theReply; } else if (theReply != null) { - System.err.println(String.format("Non-serializable return type %s for method %s, returning null", returnType.getName(), methodName)); + System.err.printf("Non-serializable return type %s for method %s, returning null%n", returnType.getName(), methodName); } } catch (final IllegalAccessException | IllegalArgumentException e) { - System.err.println(String.format("Unknown protocol method %s with %d args, replying with null", methodName, args == null ? 0 : args.length)); + System.err.printf("Unknown protocol method %s with %d args, replying with null%n", methodName, args == null ? 0 : args.length); } catch (final NullPointerException | InvocationTargetException e) { //throw new RuntimeException(e.getTargetException()); catchedError[0] += e.toString(); diff --git a/forge-gui/src/main/java/forge/gamemodes/net/ProtocolMethod.java b/forge-gui/src/main/java/forge/gamemodes/net/ProtocolMethod.java index 805a5792517..dc768de2cd8 100644 --- a/forge-gui/src/main/java/forge/gamemodes/net/ProtocolMethod.java +++ b/forge-gui/src/main/java/forge/gamemodes/net/ProtocolMethod.java @@ -138,7 +138,7 @@ public enum ProtocolMethod { } return candidate; } catch (final NoSuchMethodException | SecurityException e) { - System.err.println(String.format("Warning: class contains no accessible method named %s", name())); + System.err.printf("Warning: class contains no accessible method named %s%n", name()); return getMethodNoArgs(); } } @@ -147,7 +147,7 @@ public enum ProtocolMethod { try { return mode.toInvoke.getMethod(name(), (Class[]) null); } catch (final NoSuchMethodException | SecurityException e) { - System.err.println(String.format("Warning: class contains no accessible arg-less method named %s", name())); + System.err.printf("Warning: class contains no accessible arg-less method named %s%n", name()); return null; } } @@ -168,7 +168,7 @@ public enum ProtocolMethod { final Class type = this.args[iArg]; if (!ReflectionUtil.isInstance(arg, type)) { //throw new InternalError(String.format("Protocol method %s: illegal argument (%d) of type %s, %s expected", name(), iArg, arg.getClass().getName(), type.getName())); - System.err.println(String.format("InternalError: Protocol method %s: illegal argument (%d) of type %s, %s expected (ProtocolMethod.java)", name(), iArg, arg.getClass().getName(), type.getName())); + System.err.printf("InternalError: Protocol method %s: illegal argument (%d) of type %s, %s expected (ProtocolMethod.java)%n", name(), iArg, arg.getClass().getName(), type.getName()); } } } catch (Exception e) { @@ -183,7 +183,7 @@ public enum ProtocolMethod { } if (!ReflectionUtil.isInstance(value, returnType)) { //throw new IllegalStateException(String.format("Protocol method %s: illegal return object type %s returned by client, expected %s", name(), value.getClass().getName(), getReturnType().getName())); - System.err.println(String.format("IllegalStateException: Protocol method %s: illegal return object type %s returned by client, expected %s (ProtocolMethod.java)", name(), value.getClass().getName(), getReturnType().getName())); + System.err.printf("IllegalStateException: Protocol method %s: illegal return object type %s returned by client, expected %s (ProtocolMethod.java)%n", name(), value.getClass().getName(), getReturnType().getName()); } } } diff --git a/forge-gui/src/main/java/forge/gui/download/GuiDownloadService.java b/forge-gui/src/main/java/forge/gui/download/GuiDownloadService.java index 1ae2637f4c0..8f82b609ccc 100644 --- a/forge-gui/src/main/java/forge/gui/download/GuiDownloadService.java +++ b/forge-gui/src/main/java/forge/gui/download/GuiDownloadService.java @@ -338,7 +338,7 @@ public abstract class GuiDownloadService implements Runnable { } catch (final FileNotFoundException fnfe) { String formatStr = " Error - the LQ picture %s could not be found on the server. [%s] - %s"; - System.out.println(String.format(formatStr, fileDest.getName(), url, fnfe.getMessage())); + System.out.printf((formatStr) + "%n", fileDest.getName(), url, fnfe.getMessage()); } catch (final Exception ex) { Log.error("LQ Pictures", "Error downloading pictures", ex);