external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-20 12:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix simulation AI exception with random effects.

Browse Source 
Uses a seeded deterministic random generator when simulating choices, which ensures  the same number of sub-choices are always used, which the code requires. Adds a test.
This commit is contained in:
asvitkine
2022-12-09 16:08:44 -05:00
parent 95167ed675
commit 96b6bafc2b
3 changed files with 66 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
forge-ai/src/main/java/forge/ai/simulation/SpellAbilityPicker.java
View File

@@ -1,8 +1,10 @@
package forge.ai.simulation;
import forge.util.MyRandom;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Random;
import java.util.Set;
import forge.ai.AiPlayDecision;
@@ -363,10 +365,17 @@ public class SpellAbilityPicker {
controller.evaluateSpellAbility(saList, saIndex);
SpellAbility sa = saList.get(saIndex);
// Use a deterministic random seed when evaluating different choices of a spell ability.
// This is needed as otherwise random effects may result in a different number of choices
// each iteration, which will break the logic in SpellAbilityChoicesIterator.
Random origRandom = MyRandom.getRandom();
long randomSeedToUse = origRandom.nextLong();
Score bestScore = new Score(Integer.MIN_VALUE);
final SpellAbilityChoicesIterator choicesIterator = new SpellAbilityChoicesIterator(controller);
Score lastScore = null;
Score lastScore;
do {
MyRandom.setRandom(new Random(randomSeedToUse));
GameSimulator simulator = new GameSimulator(controller, game, player, phase);
simulator.setInterceptor(choicesIterator);
lastScore = simulator.simulateSpellAbility(sa);
@@ -375,6 +384,7 @@ public class SpellAbilityPicker {
}
} while (choicesIterator.advance(lastScore));
controller.doneEvaluating(bestScore);
MyRandom.setRandom(origRandom);
return bestScore;
}