From 87db02f77b08b51e69882aa362d51d99912eac3b Mon Sep 17 00:00:00 2001 From: Sloth Date: Wed, 11 Mar 2015 14:19:06 +0000 Subject: [PATCH] - Fixed ChooseSourceEffect from crashing when selecting fake cards. --- .../game/ability/effects/ChooseSourceEffect.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/forge-game/src/main/java/forge/game/ability/effects/ChooseSourceEffect.java b/forge-game/src/main/java/forge/game/ability/effects/ChooseSourceEffect.java index d4df683d37d..af590427402 100644 --- a/forge-game/src/main/java/forge/game/ability/effects/ChooseSourceEffect.java +++ b/forge-game/src/main/java/forge/game/ability/effects/ChooseSourceEffect.java @@ -106,24 +106,24 @@ public class ChooseSourceEffect extends SpellAbilityEffect { Card divCommandZoneSources = new Card(-4, game); divCommandZoneSources.setName("--CARDS IN THE COMMAND ZONE:--"); - if (permanentSources.size() > 0) { + if (!permanentSources.isEmpty()) { sourcesToChooseFrom.add(divPermanentSources); sourcesToChooseFrom.addAll(permanentSources); } - if (stackSources.size() > 0) { + if (!stackSources.isEmpty()) { sourcesToChooseFrom.add(divStackSources); sourcesToChooseFrom.addAll(stackSources); } - if (referencedSources.size() > 0) { + if (!referencedSources.isEmpty()) { sourcesToChooseFrom.add(divReferencedSources); sourcesToChooseFrom.addAll(referencedSources); } - if (commandZoneSources.size() > 0) { + if (!commandZoneSources.isEmpty()) { sourcesToChooseFrom.add(divCommandZoneSources); sourcesToChooseFrom.addAll(commandZoneSources); } - if (sourcesToChooseFrom.size() == 0) { + if (sourcesToChooseFrom.isEmpty()) { return; } @@ -138,7 +138,7 @@ public class ChooseSourceEffect extends SpellAbilityEffect { Card o = null; do { o = p.getController().chooseSingleEntityForEffect(sourcesToChooseFrom, sa, choiceTitle); - } while (o.equals(divPermanentSources) || o.equals(divStackSources) || o.equals(divReferencedSources) || o.equals(divCommandZoneSources)); + } while (o == null); chosen.add(o); sourcesToChooseFrom.remove(o); }