external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-14 09:48:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not steal keyboard focus when "Visually Alert on Receipt of Priority" is enabled

Browse Source 
When the "Visually Alert on Receipt of Priority" feature is enabled,
the `showTab()` call at the beginning of `forge.gui.framework.SDisplayUtil.remind()`
steals focus from the primary button whenever anything goes on the
stack.

This change, previously suggested by pfps as probably not necessary, is
indeed necessary after all to prevent that focus stealing by restoring
focus to the previous owner only if the owner was an `FButton`.

fixes https://github.com/Card-Forge/forge/issues/7660
This commit is contained in:
Seth Milliken
2025-05-31 13:27:09 -07:00
committed by Chris H
parent 567e13c92b
commit 7fa89cbc2e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
forge-gui-desktop/src/main/java/forge/gui/framework/SDisplayUtil.java
View File

@@ -18,6 +18,7 @@ import javax.swing.JPanel;
import javax.swing.SwingUtilities;
import forge.gui.FThreads;
import forge.toolbox.FButton;
import forge.view.FFrame;
/**
@@ -103,9 +104,8 @@ public class SDisplayUtil {
if (dc != null) {
dc.setSelected(tab0);
}
// set focus back to previous owner, if any
// if (null != c && c instanceof FButton) { //pfps UGLY but maybe necessary (probably not)
if (null != c) {
// To prevent stealing keyboard focus, set focus back to previous owner, but only if it was a button.
if (c instanceof FButton) {
c.requestFocusInWindow();
}
};