external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-18 11:48:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix running out of memory from too many waiting triggers (#8466)

Browse Source
This commit is contained in:
tool4ever
2025-08-20 10:42:04 +01:00
committed by GitHub
parent 283198f0a4
commit 715ba9803f
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
forge-game/src/main/java/forge/game/trigger/TriggerHandler.java
View File

@@ -262,9 +262,16 @@ public class TriggerHandler {
return; return;
} }
// too many waiting triggers might cause OutOfMemory exception
// such high amount usually happens from looping on one type:
// e.g. Heroes' Bane counters ability
// we can just run further triggers directly, side effects are highly unlikely
// (could also make this depend on Runtime.getRuntime().freeMemory()
// - but probably overkill)
boolean canWait = waitingTriggers.size() < 9999;
if (mode == TriggerType.Always) { if (mode == TriggerType.Always) {
runStateTrigger(runParams); runStateTrigger(runParams);
} else if ((game.getStack().isFrozen() || holdTrigger) && mode != TriggerType.TapsForMana && mode != TriggerType.ManaAdded) { } else if (canWait && (game.getStack().isFrozen() || holdTrigger) && mode != TriggerType.TapsForMana && mode != TriggerType.ManaAdded) {
waitingTriggers.add(new TriggerWaiting(mode, runParams)); waitingTriggers.add(new TriggerWaiting(mode, runParams));
} else { } else {
runWaitingTrigger(new TriggerWaiting(mode, runParams)); runWaitingTrigger(new TriggerWaiting(mode, runParams));