From 615abebe99607cf32e0598f1bcb061f6be4ee3e0 Mon Sep 17 00:00:00 2001 From: swordshine Date: Sat, 22 Jun 2013 10:29:43 +0000 Subject: [PATCH] - Fixed ChangeZoneAll, TapAll, UntapAll effect --- .../java/forge/card/ability/effects/ChangeZoneAllEffect.java | 2 +- src/main/java/forge/card/ability/effects/TapAllEffect.java | 2 +- src/main/java/forge/card/ability/effects/UntapAllEffect.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/forge/card/ability/effects/ChangeZoneAllEffect.java b/src/main/java/forge/card/ability/effects/ChangeZoneAllEffect.java index 46617b333ac..ba6e4153af3 100644 --- a/src/main/java/forge/card/ability/effects/ChangeZoneAllEffect.java +++ b/src/main/java/forge/card/ability/effects/ChangeZoneAllEffect.java @@ -49,7 +49,7 @@ public class ChangeZoneAllEffect extends SpellAbilityEffect { List tgtPlayers = getTargetPlayers(sa); final Game game = sa.getActivatingPlayer().getGame(); - if ((tgtPlayers == null) || tgtPlayers.isEmpty() || sa.hasParam("UseAllOriginZones")) { + if (!sa.usesTargeting() || sa.hasParam("UseAllOriginZones")) { cards = game.getCardsIn(origin); } else if (origin.contains(ZoneType.Library) && sa.hasParam("Search")) { // Search library using changezoneall effect need a param "Search" diff --git a/src/main/java/forge/card/ability/effects/TapAllEffect.java b/src/main/java/forge/card/ability/effects/TapAllEffect.java index 1fd79ecce56..34cd94ab73d 100644 --- a/src/main/java/forge/card/ability/effects/TapAllEffect.java +++ b/src/main/java/forge/card/ability/effects/TapAllEffect.java @@ -40,7 +40,7 @@ public class TapAllEffect extends SpellAbilityEffect { final List tgtPlayers = getTargetPlayers(sa); - if ((tgtPlayers == null) || tgtPlayers.isEmpty()) { + if (!sa.usesTargeting()) { cards = game.getCardsIn(ZoneType.Battlefield); } else { cards = new ArrayList(); diff --git a/src/main/java/forge/card/ability/effects/UntapAllEffect.java b/src/main/java/forge/card/ability/effects/UntapAllEffect.java index c850db3a13b..aaedcba33eb 100644 --- a/src/main/java/forge/card/ability/effects/UntapAllEffect.java +++ b/src/main/java/forge/card/ability/effects/UntapAllEffect.java @@ -38,7 +38,7 @@ public class UntapAllEffect extends SpellAbilityEffect { valid = sa.getParam("ValidCards"); } - if (tgtPlayers.isEmpty()) { + if (!sa.usesTargeting()) { list = sa.getActivatingPlayer().getGame().getCardsIn(ZoneType.Battlefield); } else { list = new ArrayList();