external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-18 11:48:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache trigger constructor instead of looking it up each time createTrigger is called. This was showing up in profiles of simulation code.

Browse Source
This commit is contained in:
Myrd
2015-02-14 06:57:15 +00:00
parent 8aae10fedd
commit 5d6f5912e3
1 changed files with 22 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
forge-game/src/main/java/forge/game/trigger/TriggerType.java
View File

@@ -71,9 +71,25 @@ public enum TriggerType {
Vote(TriggerVote.class); Vote(TriggerVote.class);
private final Class<? extends Trigger> classTrigger; private final Class<? extends Trigger> classTrigger;
private final Constructor<? extends Trigger> constructor;
private TriggerType(Class<? extends Trigger> clasz) { private TriggerType(Class<? extends Trigger> clasz) {
classTrigger = clasz; classTrigger = clasz;
constructor = findConstructor(clasz);
} }
private static Constructor<? extends Trigger> findConstructor(Class<? extends Trigger> clasz) {
@SuppressWarnings("unchecked")
Constructor<? extends Trigger>[] cc = (Constructor<? extends Trigger>[]) clasz.getDeclaredConstructors();
for (Constructor<? extends Trigger> c : cc) {
Class<?>[] pp = c.getParameterTypes();
if (pp[0].isAssignableFrom(Map.class)) {
return c;
}
}
throw new RuntimeException("No constructor found that would take Map as 1st parameter in class " + clasz.getName());
}
/** /**
* TODO: Write javadoc for this method. * TODO: Write javadoc for this method.
* @param string * @param string
@@ -109,21 +125,12 @@ public enum TriggerType {
* @return * @return
*/ */
public Trigger createTrigger(Map<String, String> mapParams, Card host, boolean intrinsic) { public Trigger createTrigger(Map<String, String> mapParams, Card host, boolean intrinsic) {
@SuppressWarnings("unchecked") try {
Constructor<? extends Trigger>[] cc = (Constructor<? extends Trigger>[]) classTrigger.getDeclaredConstructors(); Trigger res = constructor.newInstance(mapParams, host, intrinsic);
for (Constructor<? extends Trigger> c : cc) { res.setMode(this);
Class<?>[] pp = c.getParameterTypes(); return res;
if (pp[0].isAssignableFrom(Map.class)) { } catch (IllegalArgumentException | InstantiationException | IllegalAccessException | InvocationTargetException e) {
try { throw new RuntimeException(e);
Trigger res = c.newInstance(mapParams, host, intrinsic);
res.setMode(this);
return res;
} catch (IllegalArgumentException | InstantiationException | IllegalAccessException | InvocationTargetException e) {
// TODO Auto-generated catch block ignores the exception, but sends it to System.err and probably forge.log.
e.printStackTrace();
}
}
} }
throw new RuntimeException("No constructor found that would take Map as 1st parameter in class " + classTrigger.getName());
} }
} }