external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-19 04:08:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some more NPE related to gauntlets

Browse Source
This commit is contained in:
TRT
2021-10-18 15:26:09 +02:00
parent 501d5501db
commit 5b72d1f682
5 changed files with 27 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
forge-game/src/main/java/forge/game/ability/effects/DamageDealEffect.java
View File

@@ -197,13 +197,7 @@ public class DamageDealEffect extends DamageBaseEffect {
return;
}
CardCollection assigneeCards = new CardCollection();
// Do we have a way of doing this in a better fashion?
for (GameObject obj : tgts) {
if (obj instanceof Card) {
assigneeCards.add((Card) obj);
}
}
CardCollection assigneeCards = new CardCollection(Iterables.filter(tgts, Card.class));
Player assigningPlayer = players.get(0);
Map<Card, Integer> map = assigningPlayer.getController().assignCombatDamage(sourceLKI, assigneeCards, dmg, null, true);

4
forge-gui-desktop/src/main/java/forge/screens/home/gauntlet/CSubmenuGauntletBuild.java
View File

@@ -122,7 +122,7 @@ public enum CSubmenuGauntletBuild implements ICDoc {
}
private void addDeck() {
final Deck deckToAdd = view.getLstLeft().getPlayer().getDeck();
final Deck deckToAdd = view.getLstLeft().getPlayer() != null ? view.getLstLeft().getPlayer().getDeck() : null;
if (null == deckToAdd) {
return;
}
@@ -145,7 +145,7 @@ public enum CSubmenuGauntletBuild implements ICDoc {
private void deckUp() {
final int oldIndex = view.getLstRight().getSelectedIndex();
if (oldIndex == 0) { return; }
if (oldIndex <= 0) { return; }
final Deck movingDeck = workingDecks.remove(oldIndex);
workingDecks.add(oldIndex - 1, movingDeck);

2
forge-gui/src/main/java/forge/deck/DeckgenUtil.java
View File

@@ -425,6 +425,8 @@ public class DeckgenUtil {
/** @return {@link forge.deck.Deck} */
public static Deck getRandomCustomDeck() {
final IStorage<Deck> allDecks = FModel.getDecks().getConstructed();
// in case user has not created any yet
if (allDecks.size() == 0) { return null; }
final int rand = (int) (Math.floor(MyRandom.getRandom().nextDouble() * allDecks.size()));
final String name = allDecks.getItemNames().toArray(new String[0])[rand];
return allDecks.get(name);

2
forge-gui/src/main/java/forge/gamemodes/gauntlet/GauntletUtil.java
View File

@@ -59,8 +59,10 @@ public class GauntletUtil {
break;
case CUSTOM_DECK:
deck = DeckgenUtil.getRandomCustomDeck();
if (deck != null) { // fall back to precon if none available
eventNames.add(deck.getName());
break;
}
case PRECONSTRUCTED_DECK:
deck = DeckgenUtil.getRandomPreconDeck();
eventNames.add(deck.getName());

2
forge-gui/src/main/java/forge/gamemodes/tournament/TournamentUtil.java
View File

@@ -56,8 +56,10 @@ public class TournamentUtil {
break;
case CUSTOM_DECK:
deck = DeckgenUtil.getRandomCustomDeck();
if (deck != null) { // fall back to precon if none available
eventNames.add(deck.getName());
break;
}
case PRECONSTRUCTED_DECK:
deck = DeckgenUtil.getRandomPreconDeck();
eventNames.add(deck.getName());