From 6eec0e8988f568df6591b69a620ad041be44dedd Mon Sep 17 00:00:00 2001 From: Jetz Date: Sat, 16 Aug 2025 11:13:42 -0400 Subject: [PATCH 1/2] Fix another potential NPE deserializing old decks... --- forge-core/src/main/java/forge/deck/Deck.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/forge-core/src/main/java/forge/deck/Deck.java b/forge-core/src/main/java/forge/deck/Deck.java index a369f711e23..c4bf28b2a65 100644 --- a/forge-core/src/main/java/forge/deck/Deck.java +++ b/forge-core/src/main/java/forge/deck/Deck.java @@ -633,7 +633,7 @@ public class Deck extends DeckBase implements Iterable Date: Sun, 17 Aug 2025 06:13:51 +0800 Subject: [PATCH 2/2] prevent NPE --- forge-core/src/main/java/forge/deck/Deck.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/forge-core/src/main/java/forge/deck/Deck.java b/forge-core/src/main/java/forge/deck/Deck.java index c4bf28b2a65..4d6b34e22a7 100644 --- a/forge-core/src/main/java/forge/deck/Deck.java +++ b/forge-core/src/main/java/forge/deck/Deck.java @@ -210,10 +210,13 @@ public class Deck extends DeckBase implements Iterable kv : parts.entrySet()) { - CardPool cp = new CardPool(); - result.parts.put(kv.getKey(), cp); - cp.addAll(kv.getValue()); + // parts shouldn't be null + if (parts != null) { + for (Entry kv : parts.entrySet()) { + CardPool cp = new CardPool(); + result.parts.put(kv.getKey(), cp); + cp.addAll(kv.getValue()); + } } result.setAiHints(StringUtils.join(aiHints, " | ")); result.setDraftNotes(draftNotes); @@ -686,4 +689,4 @@ public class Deck extends DeckBase implements Iterable