external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-19 04:08:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'sonarqubefixes01' into 'master'

Browse Source 
Fixes some SonarQube detected bugs

See merge request core-developers/forge!2019
This commit is contained in:
swordshine
2019-08-10 10:32:18 +00:00
parent 0899629e16 2534c2c27a
commit 49bdff3f17
17 changed files with 67 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
forge-game/src/main/java/forge/game/GameFormat.java
View File

@@ -370,7 +370,7 @@ public class GameFormat implements Comparable<GameFormat> {
rarities = Lists.newArrayList();
for (String s: Arrays.asList(strCars.split(", "))) {
cr = CardRarity.smartValueOf(s);
if (cr.name() != "Unknown") {
if (!cr.name().equals("Unknown")) {
rarities.add(cr);
}
}

4
forge-game/src/main/java/forge/game/ability/effects/ChangeZoneEffect.java
View File

@@ -180,7 +180,7 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
sb.append(num).append(" of those ").append(type).append(" card(s)");
} else {
sb.append(destination.equals("Exile") ? " exiles " : " puts ");
if (type == "Card") {
if (type.equals("Card")) {
sb.append(num);
} else {
sb.append(num).append(" ").append(type);
@@ -208,7 +208,7 @@ public class ChangeZoneEffect extends SpellAbilityEffect {
}
sb.append(" of ").append(fetchPlayer);
if (fetchPlayer != "their") {
if (!fetchPlayer.equals("their")) {
sb.append("'s");
}
sb.append(" library");