external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-20 20:58:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize more temporary allocations.

Browse Source
This commit is contained in:
Myrd
2014-12-30 22:19:54 +00:00
parent b39a7d310c
commit 46a870a0ea
1 changed files with 24 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
forge-game/src/main/java/forge/game/combat/CombatUtil.java
View File

@@ -500,6 +500,23 @@ public class CombatUtil {
return true; return true;
} }
// Cache landwalk ability strings instead of generating them each time.
private static final String[] LANDWALK_KEYWORDS;
private static final String[] SNOW_LANDWALK_KEYWORDS;
private static final String[] IGNORE_LANDWALK_KEYWORDS;
static {
final int size = MagicColor.Constant.BASIC_LANDS.size();
LANDWALK_KEYWORDS = new String[size];
SNOW_LANDWALK_KEYWORDS = new String[size];
IGNORE_LANDWALK_KEYWORDS = new String[size];
for (int i = 0; i < size; i++) {
final String basic = MagicColor.Constant.BASIC_LANDS.get(i);
final String landwalk = basic + "walk";;
LANDWALK_KEYWORDS[i] = landwalk;
SNOW_LANDWALK_KEYWORDS[i] = "Snow " + landwalk.toLowerCase();
IGNORE_LANDWALK_KEYWORDS[i] = "May be blocked as though it doesn't have " + landwalk + ".";
}
}
public static boolean isUnblockableFromLandwalk(final Card attacker, final Player defendingPlayer) { public static boolean isUnblockableFromLandwalk(final Card attacker, final Player defendingPlayer) {
//May be blocked as though it doesn't have landwalk. (Staff of the Ages) //May be blocked as though it doesn't have landwalk. (Staff of the Ages)
@@ -509,31 +526,18 @@ public class CombatUtil {
List<String> walkTypes = Lists.newArrayList(); List<String> walkTypes = Lists.newArrayList();
for (final String basic : MagicColor.Constant.BASIC_LANDS) { for (int i = 0; i < LANDWALK_KEYWORDS.length; i++) {
final StringBuilder sbLand = new StringBuilder(); final String basic = MagicColor.Constant.BASIC_LANDS.get(i);
sbLand.append(basic); final String landwalk = LANDWALK_KEYWORDS[i];
sbLand.append("walk"); final String snowwalk = SNOW_LANDWALK_KEYWORDS[i];
final String landwalk = sbLand.toString(); final String mayBeBlocked = IGNORE_LANDWALK_KEYWORDS[i];
StringBuilder sbSnow = new StringBuilder();
sbSnow.append("Snow ");
sbSnow.append(landwalk.toLowerCase());
final String snowwalk = sbSnow.toString();
sbLand.insert(0, "May be blocked as though it doesn't have "); //Deadfall, etc.
sbLand.append(".");
final String mayBeBlocked = sbLand.toString();
if (attacker.hasKeyword(landwalk) && !attacker.hasKeyword(mayBeBlocked)) { if (attacker.hasKeyword(landwalk) && !attacker.hasKeyword(mayBeBlocked)) {
walkTypes.add(basic); walkTypes.add(basic);
} }
if (attacker.hasKeyword(snowwalk)) { if (attacker.hasKeyword(snowwalk)) {
StringBuilder sbSnowType = new StringBuilder(); walkTypes.add(basic + ".Snow");
sbSnowType.append(basic);
sbSnowType.append(".Snow");
walkTypes.add(sbSnowType.toString());
} }
} }