external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-18 19:58:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

- Prevent a NPE ensuing from potentially "bleeding" a challenge from one quest world to another.

Browse Source
This commit is contained in:
Agetian
2016-12-14 10:40:18 +00:00
parent 03f100686a
commit 432ab1bcf3
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
forge-gui/src/main/java/forge/quest/QuestController.java
View File

@@ -508,6 +508,16 @@ public class QuestController {
final List<String> unlockedChallengeIds = new ArrayList<String>();
final List<String> availableChallengeIds = achievements.getCurrentChallenges();
// clean up challenges potentially coming over from a different quest world
List<String> nonExistentIds = new ArrayList<String>();
for (String cid : availableChallengeIds) {
if (this.getChallenges().get(cid) == null) {
System.out.println("Warning: removing a challenge that does not exist in the current quest world: " + cid);
nonExistentIds.add(cid);
}
}
availableChallengeIds.removeAll(nonExistentIds);
int maxChallenges = achievements.getWin() / getTurnsToUnlockChallenge() - achievements.getChallengesPlayed();
if (maxChallenges > 5) {
maxChallenges = 5;