external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-18 03:38:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

- Fixing additional abilities not working for Mana Clash, Fiery Gambit et al. (not created for Repeat/RepeatEach APIs)

Browse Source
This commit is contained in:
Agetian
2016-12-29 15:51:33 +00:00
parent 9b86aebaaa
commit 256f539cb0
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
forge-game/src/main/java/forge/game/ability/AbilityFactory.java
View File

@@ -31,6 +31,8 @@ import java.util.Map;
import com.google.common.base.Function;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import java.util.ArrayList;
import java.util.Arrays;
/**
* <p>
@@ -240,7 +242,11 @@ public final class AbilityFactory {
}
}
if (type != AbilityRecordType.SubAbility || parent == null || parent.getApi() == ApiType.Charm) {
// FIXME: this is a list of APIs that fail to work unless additional abilities are created for them below.
// Is there are reason we are not just creating additional abilities by default for all APIs?
List<ApiType> apiList = new ArrayList<>(Arrays.asList(ApiType.Charm, ApiType.Repeat, ApiType.RepeatEach));
if (type != AbilityRecordType.SubAbility || parent == null || apiList.contains(parent.getApi())) {
for (final String key : additionalAbilityKeys) {
if (mapParams.containsKey(key) && spellAbility.getAdditonalAbility(key) == null) {
spellAbility.setAdditionalAbility(key, getSubAbility(hostCard, mapParams.get(key), spellAbility));