diff --git a/forge-core/src/main/java/forge/card/CardRulesPredicates.java b/forge-core/src/main/java/forge/card/CardRulesPredicates.java index 131b6c738cf..b5727b9cbec 100644 --- a/forge-core/src/main/java/forge/card/CardRulesPredicates.java +++ b/forge-core/src/main/java/forge/card/CardRulesPredicates.java @@ -604,6 +604,7 @@ public final class CardRulesPredicates { }; public static final Predicate IS_PLANESWALKER = CardRulesPredicates.coreType(true, CardType.CoreType.Planeswalker); + public static final Predicate IS_BATTLE = CardRulesPredicates.coreType(true, CardType.CoreType.Battle); public static final Predicate IS_INSTANT = CardRulesPredicates.coreType(true, CardType.CoreType.Instant); public static final Predicate IS_SORCERY = CardRulesPredicates.coreType(true, CardType.CoreType.Sorcery); public static final Predicate IS_ENCHANTMENT = CardRulesPredicates.coreType(true, CardType.CoreType.Enchantment); diff --git a/forge-gui-desktop/src/main/java/forge/itemmanager/filters/CardTypeFilter.java b/forge-gui-desktop/src/main/java/forge/itemmanager/filters/CardTypeFilter.java index a80e406082b..a3e1de165ae 100644 --- a/forge-gui-desktop/src/main/java/forge/itemmanager/filters/CardTypeFilter.java +++ b/forge-gui-desktop/src/main/java/forge/itemmanager/filters/CardTypeFilter.java @@ -37,6 +37,7 @@ public class CardTypeFilter extends StatTypeFilter { addToggleButton(widget, StatTypes.PLANESWALKER); addToggleButton(widget, StatTypes.INSTANT); addToggleButton(widget, StatTypes.SORCERY); + addToggleButton(widget, StatTypes.BATTLE); } @Override diff --git a/forge-gui-mobile/src/forge/card/CardZoom.java b/forge-gui-mobile/src/forge/card/CardZoom.java index af1f739329c..9068323150d 100644 --- a/forge-gui-mobile/src/forge/card/CardZoom.java +++ b/forge-gui-mobile/src/forge/card/CardZoom.java @@ -66,6 +66,8 @@ public class CardZoom extends FOverlay { } public static void show(final List items0, int currentIndex0, ActivateHandler activateHandler0) { + if (items == null) { return; } + if (currentIndex0 < 0 || items.size() <= currentIndex0) { return; } items = items0; activateHandler = activateHandler0; currentIndex = currentIndex0; diff --git a/forge-gui/res/languages/en-US.properties b/forge-gui/res/languages/en-US.properties index ddcc90817c0..b5e49a87152 100644 --- a/forge-gui/res/languages/en-US.properties +++ b/forge-gui/res/languages/en-US.properties @@ -824,6 +824,7 @@ lblEnchantments=Enchantments lblPlaneswalkers=Planeswalkers lblInstants=Instants lblSorceries=Sorceries +lblBattles=Battles lblCCMC0=Cards with mana value 0 lblCCMC1=Cards with mana value 1 lblCCMC2=Cards with mana value 2 diff --git a/forge-gui/src/main/java/forge/itemmanager/GroupDef.java b/forge-gui/src/main/java/forge/itemmanager/GroupDef.java index 9e0808c2f45..40bd8bfd68a 100644 --- a/forge-gui/src/main/java/forge/itemmanager/GroupDef.java +++ b/forge-gui/src/main/java/forge/itemmanager/GroupDef.java @@ -97,7 +97,7 @@ public enum GroupDef { if (type.isLand()) { //make Artifact Lands appear in Lands group return 2; } - if (type.isArtifact() || type.isEnchantment() || type.isPlaneswalker() || type.isInstant() || type.isSorcery()) { + if (type.isArtifact() || type.isEnchantment() || type.isPlaneswalker() || type.isInstant() || type.isSorcery() || type.isBattle()) { return 1; } } @@ -106,7 +106,7 @@ public enum GroupDef { }), CARD_TYPE("lblType", - new String[] { "Planeswalker", "Creature", "Sorcery", "Instant", "Artifact", "Enchantment", "Land", "Tribal instant" }, + new String[] { "Planeswalker", "Creature", "Sorcery", "Instant", "Artifact", "Enchantment", "Land", "Tribal instant", "Battle" }, new Function() { @Override public ColumnDef apply(final Integer groupIndex) { @@ -142,6 +142,9 @@ public enum GroupDef { if (type.isEnchantment()) { return 5; } + if (type.isBattle()) { + return 8; + } if (type.isLand()) { return 6; } diff --git a/forge-gui/src/main/java/forge/itemmanager/SItemManagerUtil.java b/forge-gui/src/main/java/forge/itemmanager/SItemManagerUtil.java index 96a15a9210d..712f4aae0a4 100644 --- a/forge-gui/src/main/java/forge/itemmanager/SItemManagerUtil.java +++ b/forge-gui/src/main/java/forge/itemmanager/SItemManagerUtil.java @@ -47,6 +47,7 @@ public final class SItemManagerUtil { PLANESWALKER (FSkinProp.IMG_PLANESWALKER, CardRulesPredicates.Presets.IS_PLANESWALKER, "lblPlaneswalkers"), INSTANT (FSkinProp.IMG_INSTANT, CardRulesPredicates.Presets.IS_INSTANT, "lblInstants"), SORCERY (FSkinProp.IMG_SORCERY, CardRulesPredicates.Presets.IS_SORCERY, "lblSorceries"), + BATTLE (FSkinProp.IMG_BATTLE, CardRulesPredicates.Presets.IS_BATTLE, "lblBattles"), CMC_0 (FSkinProp.IMG_MANA_0, new CardRulesPredicates.LeafNumber(CardRulesPredicates.LeafNumber.CardField.CMC, ComparableOp.EQUALS, 0), "lblCCMC0"), CMC_1 (FSkinProp.IMG_MANA_1, new CardRulesPredicates.LeafNumber(CardRulesPredicates.LeafNumber.CardField.CMC, ComparableOp.EQUALS, 1), "lblCCMC1"), diff --git a/forge-gui/src/main/java/forge/localinstance/skin/FSkinProp.java b/forge-gui/src/main/java/forge/localinstance/skin/FSkinProp.java index 67244b90ccc..a896297ef29 100644 --- a/forge-gui/src/main/java/forge/localinstance/skin/FSkinProp.java +++ b/forge-gui/src/main/java/forge/localinstance/skin/FSkinProp.java @@ -363,6 +363,7 @@ public enum FSkinProp { IMG_PLANESWALKER (new int[] {330, 740, 80, 80}, PropType.MANAICONS), IMG_PACK (new int[] {80, 760, 40, 40}, PropType.IMAGE), IMG_SORCERY (new int[] {412, 740, 80, 80}, PropType.MANAICONS), + IMG_BATTLE (new int[] {412, 740, 80, 80}, PropType.MANAICONS), // TODO Change location once we have Battle in skin IMG_COMMANDER (new int[] {120, 760, 40, 40}, PropType.IMAGE), IMG_ALCHEMY (new int[] {248, 822, 80, 80}, PropType.MANAICONS),