external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-17 19:28:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

minimize UI update messages during import phase

Browse Source
This commit is contained in:
myk
2013-03-13 18:00:32 +00:00
parent f268283660
commit 241fd05959
1 changed files with 30 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/main/java/forge/gui/DialogMigrateProfile.java
View File

@@ -380,6 +380,7 @@ public class DialogMigrateProfile {
_operationLog.setLineWrap(true); _operationLog.setLineWrap(true);
_operationLog.setEditable(false); _operationLog.setEditable(false);
// autoscroll to bottom when we append text // autoscroll to bottom when we append text
// it would be nice if we only autoscrolled when the caret is at the bottom, though
DefaultCaret caret = (DefaultCaret)_operationLog.getCaret(); DefaultCaret caret = (DefaultCaret)_operationLog.getCaret();
caret.setUpdatePolicy(DefaultCaret.ALWAYS_UPDATE); caret.setUpdatePolicy(DefaultCaret.ALWAYS_UPDATE);
JScrollPane scroller = new JScrollPane(_operationLog); JScrollPane scroller = new JScrollPane(_operationLog);
@@ -461,6 +462,7 @@ public class DialogMigrateProfile {
final MigrationSourceAnalyzer msa = new MigrationSourceAnalyzer(_srcDir, cb); final MigrationSourceAnalyzer msa = new MigrationSourceAnalyzer(_srcDir, cb);
final int numFilesToAnalyze = msa.getNumFilesToAnalyze(); final int numFilesToAnalyze = msa.getNumFilesToAnalyze();
// update only once every half-second so we're not flooding the UI with updates
timer = new Timer(500, null); timer = new Timer(500, null);
final Timer finalTimer = timer; final Timer finalTimer = timer;
timer.addActionListener(new ActionListener() { timer.addActionListener(new ActionListener() {
@@ -721,6 +723,14 @@ public class DialogMigrateProfile {
// working with textbox text is thread safe // working with textbox text is thread safe
_operationLog.setText(""); _operationLog.setText("");
// only update the text box once very half second
final long updateIntervalMs = 500;
long lastUpdateTimestampMs = System.currentTimeMillis();
StringBuffer opLogBuf = new StringBuffer();
// only update the progress bar when we expect the visual value to change
final long progressInterval = Math.max(1, _operations.size() / _progressBar.getWidth());
int numOps = 0; int numOps = 0;
int numSucceeded = 0; int numSucceeded = 0;
int numFailed = 0; int numFailed = 0;
@@ -728,12 +738,23 @@ public class DialogMigrateProfile {
if (_cancel) { break; } if (_cancel) { break; }
final int curOpNum = ++numOps; final int curOpNum = ++numOps;
SwingUtilities.invokeLater(new Runnable() { if (0 == curOpNum % progressInterval) {
@Override public void run() { SwingUtilities.invokeLater(new Runnable() {
if (_cancel) { return; } @Override public void run() {
_progressBar.setValue(curOpNum); if (_cancel) { return; }
} _progressBar.setValue(curOpNum);
}); }
});
}
long curTimeMs = System.currentTimeMillis();
if (updateIntervalMs <= curTimeMs - lastUpdateTimestampMs) {
lastUpdateTimestampMs = curTimeMs;
// working with textbox text is thread safe
_operationLog.append(opLogBuf.toString());
opLogBuf.setLength(0);
}
File srcFile = op.getKey(); File srcFile = op.getKey();
File destFile = op.getValue(); File destFile = op.getValue();
@@ -747,13 +768,12 @@ public class DialogMigrateProfile {
srcFile.delete(); srcFile.delete();
} }
// working with textbox text is thread safe opLogBuf.append(String.format("%s %s -> %s\n",
_operationLog.append(String.format("%s %s -> %s\n",
_move ? "Moved" : "Copied", _move ? "Moved" : "Copied",
srcFile.getAbsolutePath(), destFile.getAbsolutePath())); srcFile.getAbsolutePath(), destFile.getAbsolutePath()));
++numSucceeded; ++numSucceeded;
} catch (IOException e) { } catch (IOException e) {
_operationLog.append(String.format("Failed to %s %s -> %s (%s)\n", opLogBuf.append(String.format("Failed to %s %s -> %s (%s)\n",
_move ? "move" : "copy", _move ? "move" : "copy",
srcFile.getAbsolutePath(), destFile.getAbsolutePath(), srcFile.getAbsolutePath(), destFile.getAbsolutePath(),
e.getMessage())); e.getMessage()));
@@ -762,6 +782,7 @@ public class DialogMigrateProfile {
} }
// append summary footer // append summary footer
_operationLog.append(opLogBuf.toString());
_operationLog.append(String.format("\nImport complete. %d files %s, %d errors", _operationLog.append(String.format("\nImport complete. %d files %s, %d errors",
numSucceeded, _move ? "moved" : "copied", numFailed)); numSucceeded, _move ? "moved" : "copied", numFailed));
} catch (final Exception e) { } catch (final Exception e) {