external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-17 11:18:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Renamed and optimised implementation for getTheLatestOfAllTheOriginalEditionsOfCardsIn + tests

Browse Source 
`getTheLatestOfAllTheOriginalEditionsOfCardsIn` is the new name for `getEarliestEditionWithAllCards` which better clarifies the intent of the method.
The implementation has been optimised, according to the new CardDb behaviour and APIs.

The tests have been extended to verify that the output of the method is always consistent regardless of the edition of cards in the input CardPool.
This commit is contained in:
leriomaggio
2021-07-28 15:56:17 +01:00
parent 1697c1205f
commit 1eaf644e5b
2 changed files with 38 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
forge-gui-desktop/src/test/java/forge/card/CardEditionCollectionTestCase.java
View File

@@ -13,7 +13,7 @@ import static org.testng.Assert.assertEquals;
public class CardEditionCollectionTestCase extends ForgeCardMockTestCase {
@Test
public void getEarliestEditionWithAllCardsNotWorkingAsExpected(){
public void testGetTheLatestOfAllTheOriginalEditionsOfCardsInPoolWithOriginalSets(){
CardEdition.Collection editions = FModel.getMagicDb().getEditions();
CardDb cardDb = FModel.getMagicDb().getCommonCards();
@@ -30,7 +30,29 @@ public class CardEditionCollectionTestCase extends ForgeCardMockTestCase {
CardPool pool = new CardPool();
pool.add(cards);
CardEdition ed = editions.getEarliestEditionWithAllCards(pool);
CardEdition ed = editions.getTheLatestOfAllTheOriginalEditionsOfCardsIn(pool);
assertEquals(ed.getCode(), "ALL");
}
@Test
public void testGetTheLatestOfAllTheOriginalEditionsOfCardsInPoolWithLatestArtSets(){
CardEdition.Collection editions = FModel.getMagicDb().getEditions();
CardDb cardDb = FModel.getMagicDb().getCommonCards();
String[] cardNames = {"Shivan Dragon", "Animate Wall", "Balance", "Blessing", "Force of Will"};
String[] expectedSets = {"M20", "MED", "SLD", "M14", "2XM"};
List<PaperCard> cards = new ArrayList<>();
for (int i=0; i < 5; i++){
String cardName = cardNames[i];
String expectedSet = expectedSets[i];
PaperCard card = cardDb.getCardFromEditions(cardName, CardDb.CardArtPreference.LATEST_ART_ALL_EDITIONS);
assertEquals(card.getEdition(), expectedSet, "Assertion Failed for "+cardName);
cards.add(card);
}
CardPool pool = new CardPool();
pool.add(cards);
CardEdition ed = editions.getTheLatestOfAllTheOriginalEditionsOfCardsIn(pool);
assertEquals(ed.getCode(), "ALL");
}
}