From 158ff30ff800d003309d210b4ab73a12eeca6029 Mon Sep 17 00:00:00 2001 From: Jetz Date: Sat, 10 Aug 2024 10:19:01 -0400 Subject: [PATCH] Cleanup - Missing break from loop with no further consequences --- forge-ai/src/main/java/forge/ai/ComputerUtilCard.java | 1 + forge-ai/src/main/java/forge/ai/ability/DamagePreventAi.java | 1 + forge-core/src/main/java/forge/card/CardRules.java | 1 + .../src/main/java/forge/gamemodes/quest/QuestEventDraft.java | 2 ++ 4 files changed, 5 insertions(+) diff --git a/forge-ai/src/main/java/forge/ai/ComputerUtilCard.java b/forge-ai/src/main/java/forge/ai/ComputerUtilCard.java index 596aa6a88d2..c7d1e6f8145 100644 --- a/forge-ai/src/main/java/forge/ai/ComputerUtilCard.java +++ b/forge-ai/src/main/java/forge/ai/ComputerUtilCard.java @@ -2092,6 +2092,7 @@ public class ComputerUtilCard { for (Card card2 : card.getEnchantedBy()) { if (card2.getOwner() != ai) { disabledByEnemy = true; + break; } } if (!disabledByEnemy) { diff --git a/forge-ai/src/main/java/forge/ai/ability/DamagePreventAi.java b/forge-ai/src/main/java/forge/ai/ability/DamagePreventAi.java index b8ecd9b6f96..7e95fdd2be3 100644 --- a/forge-ai/src/main/java/forge/ai/ability/DamagePreventAi.java +++ b/forge-ai/src/main/java/forge/ai/ability/DamagePreventAi.java @@ -51,6 +51,7 @@ public class DamagePreventAi extends SpellAbilityAi { for (final Object o : objects) { if (threatenedObjects.contains(o)) { chance = true; + break; } } } else { diff --git a/forge-core/src/main/java/forge/card/CardRules.java b/forge-core/src/main/java/forge/card/CardRules.java index 0ac41faaaec..e20382c6ea5 100644 --- a/forge-core/src/main/java/forge/card/CardRules.java +++ b/forge-core/src/main/java/forge/card/CardRules.java @@ -283,6 +283,7 @@ public final class CardRules implements ICardCharacteristics { for (String staticAbility : mainPart.getStaticAbilities()) { // Check for Grist if (staticAbility.contains("CharacteristicDefining$ True") && staticAbility.contains("AddType$ Creature")) { creature = true; + break; } } if (type.isLegendary() && creature) { diff --git a/forge-gui/src/main/java/forge/gamemodes/quest/QuestEventDraft.java b/forge-gui/src/main/java/forge/gamemodes/quest/QuestEventDraft.java index d8fb7690bf0..1a05e8c4cd4 100644 --- a/forge-gui/src/main/java/forge/gamemodes/quest/QuestEventDraft.java +++ b/forge-gui/src/main/java/forge/gamemodes/quest/QuestEventDraft.java @@ -251,6 +251,7 @@ public class QuestEventDraft implements IQuestEvent { for (final String name : aiNames) { if (playerName.equals(name)) { isHumanPlayer = false; + break; } } @@ -812,6 +813,7 @@ public class QuestEventDraft implements IQuestEvent { for (CardEdition set : block.getSets()) { if (!allowedQuestSets.contains(set)) { blockAllowed = false; + break; } }