external-repos/forge
1
0
Fork 0
mirror of https://github.com/Card-Forge/forge.git synced 2025-11-20 04:38:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'tasha' into 'master'

Browse Source 
Tasha's Hideous Laughter: Fix infinite loop when lib empties

See merge request core-developers/forge!5039
This commit is contained in:
Michael Kamensky
2021-07-16 09:51:23 +00:00
parent 2bb3fdf088 764a77b69e
commit 07a8f78c27
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
forge-game/src/main/java/forge/game/ability/effects/RepeatEffect.java
View File

@@ -49,7 +49,7 @@ public class RepeatEffect extends SpellAbilityEffect {
// TODO Replace Infinite Loop Break with a game draw. Here are the scenarios that can cause this: // TODO Replace Infinite Loop Break with a game draw. Here are the scenarios that can cause this:
// Helm of Obedience vs Graveyard to Library replacement effect // Helm of Obedience vs Graveyard to Library replacement effect
if(source.getName().equals("Helm of Obedience")) { if (source.getName().equals("Helm of Obedience")) {
StringBuilder infLoop = new StringBuilder(sa.getHostCard().toString()); StringBuilder infLoop = new StringBuilder(sa.getHostCard().toString());
infLoop.append(" - To avoid an infinite loop, this repeat has been broken "); infLoop.append(" - To avoid an infinite loop, this repeat has been broken ");
infLoop.append(" and the game will now continue in the current state, ending the loop early. "); infLoop.append(" and the game will now continue in the current state, ending the loop early. ");

3
forge-gui/res/cardsfolder/upcoming/tashas_hideous_laughter.txt
View File

@@ -2,8 +2,9 @@ Name:Tasha's Hideous Laughter
ManaCost:1 U U ManaCost:1 U U
Types:Sorcery Types:Sorcery
A:SP$ RepeatEach | RepeatPlayers$ Opponent | RepeatSubAbility$ DBRepeat | SpellDescription$ Each opponent exiles cards from the top of their library until that player has exiled cards with total mana value 20 or more. A:SP$ RepeatEach | RepeatPlayers$ Opponent | RepeatSubAbility$ DBRepeat | SpellDescription$ Each opponent exiles cards from the top of their library until that player has exiled cards with total mana value 20 or more.
SVar:DBRepeat:DB$ Repeat | RepeatSubAbility$ DBExile | RepeatCheckSVar$ X | RepeatSVarCompare$ LT20 | SubAbility$ DBCleanup SVar:DBRepeat:DB$ Repeat | RepeatSubAbility$ DBExile | RepeatCheckSVar$ X | RepeatSVarCompare$ LT20 | MaxRepeat$ Y | SubAbility$ DBCleanup
SVar:DBExile:DB$ Dig | Defined$ Remembered | DigNum$ 1 | ChangeNum$ All | DestinationZone$ Exile | Imprint$ True SVar:DBExile:DB$ Dig | Defined$ Remembered | DigNum$ 1 | ChangeNum$ All | DestinationZone$ Exile | Imprint$ True
SVar:DBCleanup:DB$ Cleanup | ClearImprinted$ True SVar:DBCleanup:DB$ Cleanup | ClearImprinted$ True
SVar:X:Imprinted$CardManaCost SVar:X:Imprinted$CardManaCost
SVar:Y:PlayerCountRemembered$CardsInLibrary
Oracle:Each opponent exiles cards from the top of their library until that player has exiled cards with total mana value 20 or more. Oracle:Each opponent exiles cards from the top of their library until that player has exiled cards with total mana value 20 or more.